[GitHub] spark pull request #18361: [SPARK-19660][SQL][FOLLOWUP] Replace mapred.input...

[wangyum]

Github user wangyum commented on a diff in the pull request:

https://github.com/apache/spark/pull/18361#discussion_r127190632
  
--- Diff: 
core/src/main/scala/org/apache/spark/internal/io/SparkHadoopWriter.scala ---
@@ -197,7 +197,7 @@ class HadoopMapRedWriteConfigUtil[K, V: ClassTag](conf: 
SerializableJobConf)
 FileCommitProtocol.instantiate(
   className = classOf[HadoopMapRedCommitProtocol].getName,
   jobId = jobId.toString,
-  outputPath = getConf.get("mapred.output.dir"),
+  outputPath = 
getConf.get("mapreduce.output.fileoutputformat.outputdir"),
--- End diff --

OK. close this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #18361: [SPARK-19660][SQL][FOLLOWUP] Replace mapred.input...

[wangyum]

Github user wangyum closed the pull request at:

https://github.com/apache/spark/pull/18361


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #18361: [SPARK-19660][SQL][FOLLOWUP] Replace mapred.input...

[jiangxb1987]

Github user jiangxb1987 commented on a diff in the pull request:

https://github.com/apache/spark/pull/18361#discussion_r126982493
  
--- Diff: 
core/src/main/scala/org/apache/spark/internal/io/SparkHadoopWriter.scala ---
@@ -197,7 +197,7 @@ class HadoopMapRedWriteConfigUtil[K, V: ClassTag](conf: 
SerializableJobConf)
 FileCommitProtocol.instantiate(
   className = classOf[HadoopMapRedCommitProtocol].getName,
   jobId = jobId.toString,
-  outputPath = getConf.get("mapred.output.dir"),
+  outputPath = 
getConf.get("mapreduce.output.fileoutputformat.outputdir"),
--- End diff --

This is intended to support the old mapred API, see the comments above this 
class.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #18361: [SPARK-19660][SQL][FOLLOWUP] Replace mapred.input...

[jiangxb1987]

Github user jiangxb1987 commented on a diff in the pull request:

https://github.com/apache/spark/pull/18361#discussion_r126982587
  
--- Diff: 
core/src/test/scala/org/apache/spark/scheduler/OutputCommitCoordinatorSuite.scala
 ---
@@ -265,7 +265,7 @@ private case class OutputCommitFunctions(tempDirPath: 
String) {
 val committer = FileCommitProtocol.instantiate(
   className = classOf[HadoopMapRedCommitProtocol].getName,
   jobId = jobId.value.getId.toString,
-  outputPath = jobConf.get("mapred.output.dir"),
+  outputPath = 
jobConf.get("mapreduce.output.fileoutputformat.outputdir"),
--- End diff --

ditto


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #18361: [SPARK-19660][SQL][FOLLOWUP] Replace mapred.input...

[wangyum]

GitHub user wangyum opened a pull request:

https://github.com/apache/spark/pull/18361

[SPARK-19660][SQL][FOLLOWUP] Replace mapred.input.dir.recursive to 
mapreduce.input.fileinputformat.input.dir.recursive

## What changes were proposed in this pull request?

Replace `mapred.input.dir.recursive` to 
`mapreduce.input.fileinputformat.input.dir.recursive`, this property did't 
record in 
[DeprecatedProperties.html](http://hadoop.apache.org/docs/r2.6.0/hadoop-project-dist/hadoop-common/DeprecatedProperties.html),
 but [source 
code](https://github.com/apache/hadoop/blob/release-2.6.0/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/util/ConfigUtil.java#L532)
 has.


## How was this patch tested?

Exists tests


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/wangyum/spark 
SPARK-19660-mapred.input.dir.recursive

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/18361.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #18361


commit cbb11a89601a670e044673f83d3572a7fab0c7e5
Author: Yuming Wang 
Date:   2017-06-20T10:29:02Z

Replace mapred.input.dir.recursive to 
mapreduce.input.fileinputformat.input.dir.recursive




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org