[GitHub] spark pull request #20344: [MINOR] Typo fixes

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/spark/pull/20344


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #20344: [MINOR] Typo fixes

[jaceklaskowski]

GitHub user jaceklaskowski opened a pull request:

https://github.com/apache/spark/pull/20344

[MINOR] Typo fixes

## What changes were proposed in this pull request?

Typo fixes

## How was this patch tested?

Local build / Doc-only changes

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jaceklaskowski/spark typo-fixes

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/20344.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #20344


commit 9fff0ed104650f4e92ae87deb91381cd79ac5bfa
Author: Jacek Laskowski 
Date:   2018-01-21T17:59:26Z

[MINOR] Typo fixes




---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #20344: [MINOR] Typo fixes

[srowen]

Github user srowen commented on a diff in the pull request:

https://github.com/apache/spark/pull/20344#discussion_r162821736
  
--- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/unresolved.scala
 ---
@@ -199,7 +199,7 @@ case class UnresolvedGenerator(name: 
FunctionIdentifier, children: Seq[Expressio
   override def prettyName: String = name.unquotedString
   override def toString: String = s"'$name(${children.mkString(", ")})"
 
-  override def eval(input: InternalRow = null): 
TraversableOnce[InternalRow] =
+  override def eval(input: InternalRow = EmptyRow): 
TraversableOnce[InternalRow] =
--- End diff --

Likewise this could be a functional change


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #20344: [MINOR] Typo fixes

[srowen]

Github user srowen commented on a diff in the pull request:

https://github.com/apache/spark/pull/20344#discussion_r162821723
  
--- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
 ---
@@ -1222,7 +1222,7 @@ class Analyzer(
 wf
   }
 // We get an aggregate function, we need to wrap it in an 
AggregateExpression.
-case agg: AggregateFunction => AggregateExpression(agg, 
Complete, isDistinct)
+case agg: AggregateFunction => 
agg.toAggregateExpression(isDistinct)
--- End diff --

This doesn't look like a typo fix


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org