[GitHub] spark pull request #20739: [SPARK-23603][SQL]When the length of the json is ...

2018-06-27 Thread cxzl25
Github user cxzl25 closed the pull request at:

https://github.com/apache/spark/pull/20739


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request #20739: [SPARK-23603][SQL]When the length of the json is ...

2018-03-05 Thread cxzl25
GitHub user cxzl25 opened a pull request:

https://github.com/apache/spark/pull/20739

[SPARK-23603][SQL]When the length of the json is in a range,get_json_object 
will result in missing tail data

## What changes were proposed in this pull request?
Replace writeRaw(char[] text, int offset, int len) with writeRaw(String 
text)
Jackson(>=2.7.7) fixes the possibility of missing tail data when the length 
of the value is in a range

[https://github.com/FasterXML/jackson/wiki/Jackson-Release-2.7.7](https://github.com/FasterXML/jackson/wiki/Jackson-Release-2.7.7)

[https://github.com/FasterXML/jackson-core/issues/30](https://github.com/FasterXML/jackson-core/issues/307)
## How was this patch tested?
org.apache.spark.sql.catalyst.expressions.JsonExpressionsSuite
test("some big value")


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/cxzl25/spark fix_udf_get_json_object

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/20739.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #20739


commit 5a83def86eb5a75eae0ff8f43e892e3daa52d50c
Author: sychen 
Date:   2018-03-05T15:30:44Z

Replace writeRaw(char[] text, int offset, int len) with writeRaw(String 
text)




---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org