[GitHub] spark pull request #20897: [MINOR][DOC] Fix a few markdown typos

2018-04-02 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/spark/pull/20897


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #20897: [MINOR][DOC] Fix a few markdown typos

2018-04-01 Thread HyukjinKwon 
Github user HyukjinKwon commented on a diff in the pull request:

https://github.com/apache/spark/pull/20897#discussion_r178481415
  
--- Diff: docs/mllib-pmml-model-export.md ---
@@ -7,15 +7,15 @@ displayTitle: PMML model export - RDD-based API
 * Table of contents
 {:toc}
 
-## `spark.mllib` supported models
--- End diff --

nice


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #20897: [MINOR][DOC] Fix a few markdown typos

2018-04-01 Thread Lemonjing 
Github user Lemonjing commented on a diff in the pull request:

https://github.com/apache/spark/pull/20897#discussion_r178481268
  
--- Diff: docs/mllib-pmml-model-export.md ---
@@ -7,15 +7,15 @@ displayTitle: PMML model export - RDD-based API
 * Table of contents
 {:toc}
 
-## `spark.mllib` supported models
--- End diff --

backquotes in mds cause display problems (see 
http://spark.apache.org/docs/latest/mllib-pmml-model-export.html)


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #20897: [MINOR][DOC] Fix a few markdown typos

2018-03-27 Thread HyukjinKwon 
Github user HyukjinKwon commented on a diff in the pull request:

https://github.com/apache/spark/pull/20897#discussion_r177318153
  
--- Diff: docs/mllib-feature-extraction.md ---
@@ -278,8 +278,8 @@ for details on the API.
 multiplication. In other words, it scales each column of the dataset by a 
scalar multiplier. This
 represents the [Hadamard 
product](https://en.wikipedia.org/wiki/Hadamard_product_%28matrices%29)
 between the input vector, `v` and transforming vector, `scalingVec`, to 
yield a result vector.
-Qu8T948*1#
--- End diff --

he is an active commiter / pmc. let's wait for few more days before we go 
ahead.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #20897: [MINOR][DOC] Fix a few markdown typos

2018-03-26 Thread Lemonjing 
Github user Lemonjing commented on a diff in the pull request:

https://github.com/apache/spark/pull/20897#discussion_r177113075
  
--- Diff: docs/mllib-feature-extraction.md ---
@@ -278,8 +278,8 @@ for details on the API.
 multiplication. In other words, it scales each column of the dataset by a 
scalar multiplier. This
 represents the [Hadamard 
product](https://en.wikipedia.org/wiki/Hadamard_product_%28matrices%29)
 between the input vector, `v` and transforming vector, `scalingVec`, to 
yield a result vector.
-Qu8T948*1#
--- End diff --

@HyukjinKwon  If the original author did not reply, you can look at my 
latest reply and confirm this confused character sequence.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #20897: [MINOR][DOC] Fix a few markdown typos

2018-03-25 Thread HyukjinKwon 
Github user HyukjinKwon commented on a diff in the pull request:

https://github.com/apache/spark/pull/20897#discussion_r176931905
  
--- Diff: docs/mllib-feature-extraction.md ---
@@ -278,8 +278,8 @@ for details on the API.
 multiplication. In other words, it scales each column of the dataset by a 
scalar multiplier. This
 represents the [Hadamard 
product](https://en.wikipedia.org/wiki/Hadamard_product_%28matrices%29)
 between the input vector, `v` and transforming vector, `scalingVec`, to 
yield a result vector.
-Qu8T948*1#
--- End diff --

@jkbradley, would you mind if I ask this was mistakenly written for sure?


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #20897: [MINOR][DOC] Fix a few markdown typos

2018-03-23 Thread Lemonjing 
GitHub user Lemonjing opened a pull request:

https://github.com/apache/spark/pull/20897

[MINOR][DOC] Fix a few markdown typos

## What changes were proposed in this pull request?

Easy fix in the markdown.

## How was this patch tested?

jekyII build test manually.

Please review http://spark.apache.org/contributing.html before opening a 
pull request.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Lemonjing/spark master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/20897.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #20897


commit 937bbef522eedddbcb502f7f9692564040a63cd7
Author: lemonjing <932191671@...>
Date:   2018-03-24T04:45:43Z

[MINOR][DOC] Fix a few markdown typos




---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org