[GitHub] spark pull request #22092: [SPARK-25101][CORE]Creating leaderLatch with id f...

2018-11-10 Thread wangyum 
Github user wangyum commented on a diff in the pull request:

https://github.com/apache/spark/pull/22092#discussion_r232449802
  
--- Diff: 
core/src/main/scala/org/apache/spark/deploy/master/ZooKeeperLeaderElectionAgent.scala
 ---
@@ -19,7 +19,6 @@ package org.apache.spark.deploy.master
 
 import org.apache.curator.framework.CuratorFramework
 import org.apache.curator.framework.recipes.leader.{LeaderLatch, 
LeaderLatchListener}
-
--- End diff --

Do not remove this line.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #22092: [SPARK-25101][CORE]Creating leaderLatch with id f...

2018-08-13 Thread yuliyaZharnosek 
GitHub user yuliyaZharnosek opened a pull request:

https://github.com/apache/spark/pull/22092

[SPARK-25101][CORE]Creating leaderLatch with id for getting info abou…

…t spark master nodes from zk

## What changes were proposed in this pull request?

This PR proposes add id to LeaderLatch, because in special cases developers 
need monitor zk for presence leaderLatch for spark master node (sometimes 
master nodes start before zk and all of them are in STANDBY status). For 
prevent this cases I want monitor zk and if master hasn't leaderLatch I will 
restart it.

## How was this patch tested?
running all tests in spark project (mvn test)

(Please explain how this patch was tested. E.g. unit tests, integration 
tests, manual tests)
(If this patch involves UI changes, please attach a screenshot; otherwise, 
remove this)

Please review http://spark.apache.org/contributing.html before opening a 
pull request.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/yuliyaZharnosek/spark SPARK-25101

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/22092.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #22092


commit 5b96e4d08b92ba0421e1786bbb00f4e9e1d9def7
Author: Yuliya Zhernosek 
Date:   2018-08-13T12:08:52Z

[SPARK-25101][CORE]Creating leaderLatch with id for getting info about 
spark master nodes from zk




---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org