[GitHub] spark pull request #22813: [SPARK-25818][CORE] WorkDirCleanup should only re...

2018-11-10 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/spark/pull/22813


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request #22813: [SPARK-25818][CORE] WorkDirCleanup should only re...

2018-10-24 Thread ouyangxiaochen
GitHub user ouyangxiaochen opened a pull request:

https://github.com/apache/spark/pull/22813

[SPARK-25818][CORE] WorkDirCleanup should only remove the directory at the 
beginning of t…

## What changes were proposed in this pull request?

The cleanup mechanism will clear all the eligible directories under 
SPARK_WORK_DIR. If the other configured paths are the same as the 
SPARK_WORK_DIR configuration, this will cause the file directories of other 
configuration items to be deleted by mistake. For example, the SPARK_LOCAL_DIRS 
and SPARK_WORK_DIR settings are the same.

We should add an another condition which start with 'app-'  when removing 
the app-* directories  in  SPARK_WORK_DIR


## How was this patch tested?
manual test


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ouyangxiaochen/spark SPARK-25818

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/22813.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #22813


commit cf8b30f64f8855ea1574fa47955a7ce42c7d0703
Author: ouyangxiaochen 
Date:   2018-10-24T06:48:24Z

WorkDirCleanup should only remove the directory at the beginning of the app-




---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org