[GitHub] spark pull request #22838: [SPARK-25835][K8s] fix issues with k8s tests
Github user skonto commented on a diff in the pull request: https://github.com/apache/spark/pull/22838#discussion_r228314627 --- Diff: pom.xml --- @@ -2654,6 +2654,16 @@ kubernetes + +resource-managers/kubernetes/core + + + + + kubernetes-tests + + false + --- End diff -- @dongjoon-hyun we had a discussion on the list, I thought I would have a look at it. Anyway I can remove that part is it ok? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #22838: [SPARK-25835][K8s] fix issues with k8s tests
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/22838#discussion_r228313490 --- Diff: pom.xml --- @@ -2654,6 +2654,16 @@ kubernetes + +resource-managers/kubernetes/core + + + + + kubernetes-tests + + false + --- End diff -- BTW, there is a prior PR from @srowen . In this case, we prefer the older one. - https://github.com/apache/spark/pull/22829 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #22838: [SPARK-25835][K8s] fix issues with k8s tests
GitHub user skonto opened a pull request: https://github.com/apache/spark/pull/22838 [SPARK-25835][K8s] fix issues with k8s tests ## What changes were proposed in this pull request? - Fixes the scala version propagation issue. - Disables the tests under the k8s profile, now we will run them manually. Adds a test specific one otherwise tests will not run if we just remove the module from the kubernetes profile. ## How was this patch tested? Manually by running the tests with different versions of scala. You can merge this pull request into a Git repository by running: $ git pull https://github.com/skonto/spark propagate-scala2.12 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/22838.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #22838 commit 02894561ba0b3e89d282958ae34087edef857c6f Author: Stavros Kontopoulos Date: 2018-10-25T19:15:45Z fix issues with k8s tests --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
