[GitHub] spark pull request #23037: [SPARK-26083][k8s] Add Copy pyspark into correspo...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/spark/pull/23037


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #23037: [SPARK-26083][k8s] Add Copy pyspark into correspo...

[AzureQ]

Github user AzureQ commented on a diff in the pull request:

https://github.com/apache/spark/pull/23037#discussion_r237618024
  
--- Diff: 
resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/PythonTestsSuite.scala
 ---
@@ -89,6 +94,90 @@ private[spark] trait PythonTestsSuite { k8sSuite: 
KubernetesSuite =>
   isJVM = false,
   pyFiles = Some(PYSPARK_CONTAINER_TESTS))
   }
+
+  test("Run PySpark shell", k8sTestTag) {
+val labels = Map("spark-app-selector" -> driverPodName)
+val driverPort = 7077
+val blockManagerPort = 1
+val driverService = testBackend
+  .getKubernetesClient
+  .services()
+  .inNamespace(kubernetesTestComponents.namespace)
+  .createNew()
--- End diff --

Thanks for pointing it out. I'll work on it. Was following 
https://github.com/apache/spark/blob/master/resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/ClientModeTestsSuite.scala


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #23037: [SPARK-26083][k8s] Add Copy pyspark into correspo...

[vanzin]

Github user vanzin commented on a diff in the pull request:

https://github.com/apache/spark/pull/23037#discussion_r236468362
  
--- Diff: 
resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/PythonTestsSuite.scala
 ---
@@ -89,6 +94,90 @@ private[spark] trait PythonTestsSuite { k8sSuite: 
KubernetesSuite =>
   isJVM = false,
   pyFiles = Some(PYSPARK_CONTAINER_TESTS))
   }
+
+  test("Run PySpark shell", k8sTestTag) {
+val labels = Map("spark-app-selector" -> driverPodName)
+val driverPort = 7077
+val blockManagerPort = 1
+val driverService = testBackend
+  .getKubernetesClient
+  .services()
+  .inNamespace(kubernetesTestComponents.namespace)
+  .createNew()
--- End diff --

This doesn't seem to follow the usual indentation used in this module, 
which makes these calls easier to read. e.g.


https://github.com/apache/spark/blob/master/resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/PodTemplateConfigMapStep.scala#L33


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org