Re: [PR] [SPARK-48068][PYTHON] Fix `mypy` failure in Python 3.10 and 3.11 [spark]
dongjoon-hyun commented on PR #46314: URL: https://github.com/apache/spark/pull/46314#issuecomment-2088083907 Since Infra Image is using `3.9.19` already, let me upgrade Python version to Python 3.10 at linter job first. ``` $ docker run -it --rm ghcr.io/apache/apache-spark-ci-image:master-8905641334 bash root@7983729755b6:/# python3.9 --version Python 3.9.19 ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
Re: [PR] [SPARK-48068][PYTHON] Fix `mypy` failure in Python 3.10 and 3.11 [spark]
dongjoon-hyun commented on PR #46314: URL: https://github.com/apache/spark/pull/46314#issuecomment-2088075633 Thank you, @HyukjinKwon . Ya, let me upgrade it, @HyukjinKwon . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
Re: [PR] [SPARK-48068][PYTHON] Fix `mypy` failure in Python 3.10 and 3.11 [spark]
HyukjinKwon commented on PR #46314: URL: https://github.com/apache/spark/pull/46314#issuecomment-2088074043 Maybe we should just upgrade our Python version in CI. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
Re: [PR] [SPARK-48068][PYTHON] Fix `mypy` failure in Python 3.10 and 3.11 [spark]
HyukjinKwon commented on PR #46314: URL: https://github.com/apache/spark/pull/46314#issuecomment-2088073883 I have the same problem in my local but I think it's because of the Python version we're using -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
Re: [PR] [SPARK-48068][PYTHON] Fix `mypy` failure in Python 3.10 and 3.11 [spark]
dongjoon-hyun commented on PR #46314: URL: https://github.com/apache/spark/pull/46314#issuecomment-2088052836 Although I verified it locally with Python 3.9, CI seems to behave differently. Let me check more. ``` $ python3 --version Python 3.9.18 $ dev/lint-python starting python compilation test... python compilation succeeded. starting black test... black checks passed. starting PySpark custom errors check... PySpark custom errors check passed. starting flake8 test... flake8 checks passed. starting mypy annotations test... annotations passed mypy checks. starting mypy examples test... examples passed mypy checks. starting mypy data test... annotations passed data checks. all lint-python tests passed! ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
Re: [PR] [SPARK-48068][PYTHON] Fix `mypy` failure in Python 3.10 and 3.11 [spark]
dongjoon-hyun commented on PR #46314: URL: https://github.com/apache/spark/pull/46314#issuecomment-2088047219 Could you review this PR, @LuciferYang ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
