Re: [PR] [SPARK-48149][INFRA][FOLLOWUP] Use single quotation mark [spark]
dongjoon-hyun commented on PR #46454: URL: https://github.com/apache/spark/pull/46454#issuecomment-2099625781 Thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
Re: [PR] [SPARK-48149][INFRA][FOLLOWUP] Use single quotation mark [spark]
HyukjinKwon closed pull request #46454: [SPARK-48149][INFRA][FOLLOWUP] Use single quotation mark URL: https://github.com/apache/spark/pull/46454 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
Re: [PR] [SPARK-48149][INFRA][FOLLOWUP] Use single quotation mark [spark]
HyukjinKwon commented on PR #46454: URL: https://github.com/apache/spark/pull/46454#issuecomment-2099623389 Merged to master. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
Re: [PR] [SPARK-48149][INFRA][FOLLOWUP] Use single quotation mark [spark]
dongjoon-hyun commented on PR #46454: URL: https://github.com/apache/spark/pull/46454#issuecomment-2099617650 Could you review this fix, @HyukjinKwon ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
Re: [PR] [SPARK-48149][INFRA][FOLLOWUP] Use single quotation mark [spark]
dongjoon-hyun commented on code in PR #46454: URL: https://github.com/apache/spark/pull/46454#discussion_r1593303069 ## .github/workflows/build_python.yml: ## @@ -34,9 +34,9 @@ jobs: fail-fast: false matrix: include: - - pyversion: ${{ github.event.schedule == '0 15 * * *' && "pypy3" }} - - pyversion: ${{ github.event.schedule == '0 17 * * *' && "python3.10" }} - - pyversion: ${{ github.event.schedule == '0 19 * * *' && "python3.12" }} + - pyversion: ${{ github.event.schedule == '0 15 * * *' && 'pypy3' }} + - pyversion: ${{ github.event.schedule == '0 17 * * *' && 'python3.10' }} + - pyversion: ${{ github.event.schedule == '0 19 * * *' && 'python3.12' }} Review Comment: Single quotation mark will work like the following. https://github.com/apache/spark/blob/84c5b919d99872858d2f98db21fd3482f27dcbfc/.github/workflows/build_and_test.yml#L202 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org