Re: [Rpm-maint] [rpm-software-management/rpm] Cleanup fingerprint cache creation (#1068)

2020-02-14 Thread Panu Matilainen
Merged #1068 into master.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1068#event-3038286887___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Cleanup fingerprint cache creation (#1068)

2020-02-14 Thread Panu Matilainen
pmatilai approved this pull request.

Cool, thanks.



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1068#pullrequestreview-358856233___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Cleanup fingerprint cache creation (#1068)

2020-02-14 Thread Michael Schroeder
@mlschroe pushed 1 commit.

3252e1e25872bc7820828425e1daea51d0700b13  Remove duplicated code in 
fpLookupSubdir


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1068/files/03676d0c776d7fa7e000322e5f7c2ec9efe5e13f..3252e1e25872bc7820828425e1daea51d0700b13
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Cleanup fingerprint cache creation (#1068)

2020-02-14 Thread Panu Matilainen
Ouch, no. Sorry.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1068#issuecomment-586170405___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Cleanup fingerprint cache creation (#1068)

2020-02-14 Thread Panu Matilainen
Reopened #1068.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1068#event-3037996933___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Cleanup fingerprint cache creation (#1068)

2020-02-14 Thread Igor Gnatenko
@pmatilai was it intentional to close PR?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1068#issuecomment-586161085___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Cleanup fingerprint cache creation (#1068)

2020-02-14 Thread Panu Matilainen
Closed #1068.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1068#event-3037849435___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Cleanup fingerprint cache creation (#1068)

2020-02-14 Thread Panu Matilainen
Nice.

Since you're fixing the cicle/cycle comment typo already: care to fix that 
entire comment while we're at it? These patches get rid of all the other // 
comments in there, so that one out-of-style sticks out even more now. Plus it 
could be more concise, really. Not that this is a requirement, just would be 
nice.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1068#issuecomment-586150577___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint