Re: Apparent synchronization bug in rsync

2022-12-08 Thread Wayne Davison via rsync
On Thu, Dec 8, 2022 at 12:49 PM Kevin Korb wrote:

> The first "Bug Fix" listed in https://rsync.samba.org/ftp/rsync/NEWS#3.2.4 is
> almost certainly related.  Apparently it was fixed via remote option but
> since your test doesn't include networking that fix wouldn't help.
>

No, the bug was fixed in 3.2.4 and it included an extra feature that allows
rsync to bypass the bug in an older remote rsync that still has the bug.

On 12/8/22 15:03, Mark Raymond wrote:

> This looks like a bug to me; am I missing something? If it is a bug,
> I'm  happy to create an issue in GitHub.
>

I have managed to get a test case that fails.  If you want to also supply
one, feel free.
-- 
Please use reply-all for most replies to avoid omitting the mailing list.
To unsubscribe or change options: https://lists.samba.org/mailman/listinfo/rsync
Before posting, read: http://www.catb.org/~esr/faqs/smart-questions.html


Re: Apparent synchronization bug in rsync

2022-12-08 Thread Mark Raymond via rsync
Interesting, in that bug the problem was *solved* by adding 
--no-whole-file when using --inplace and --sparse, whereas in my case 
the problem is *caused* by using --no-whole-file alongside --inplace and 
--sparse.


On 08/12/2022 20:48, Kevin Korb via rsync wrote:
The first "Bug Fix" listed in 
https://rsync.samba.org/ftp/rsync/NEWS#3.2.4 is almost certainly 
related.  Apparently it was fixed via remote option but since your 
test doesn't include networking that fix wouldn't help.


On 12/8/22 15:03, Mark Raymond via rsync wrote:
I believe I have found a synchronization bug in rsync. I have a pair 
of files, which when synced with


rsync --no-whole-file --inplace -S

are not identical afterwards. All three options are required, if I 
remove any one of the the files sync correctly. I have put the two 
files, along with a minimal test script, in this GitHub repo: 
https://github.com/mark-raymond/rsync-test


This looks like a bug to me; am I missing something? If it is a bug, 
I'm happy to create an issue in GitHub.


--
Please use reply-all for most replies to avoid omitting the mailing list.
To unsubscribe or change options: https://lists.samba.org/mailman/listinfo/rsync
Before posting, read: http://www.catb.org/~esr/faqs/smart-questions.html


Re: Apparent synchronization bug in rsync

2022-12-08 Thread Kevin Korb via rsync
The first "Bug Fix" listed in 
https://rsync.samba.org/ftp/rsync/NEWS#3.2.4 is almost certainly 
related.  Apparently it was fixed via remote option but since your test 
doesn't include networking that fix wouldn't help.


On 12/8/22 15:03, Mark Raymond via rsync wrote:
I believe I have found a synchronization bug in rsync. I have a pair of 
files, which when synced with||

||
|rsync --no-whole-file --inplace -S|||
||
|are not| identical afterwards. All three options are required, if I 
remove any one of the the files sync correctly. I have put the two 
files, along with a minimal test script, in this GitHub repo: 
https://github.com/mark-raymond/rsync-test


This looks like a bug to me; am I missing something? If it is a bug, I'm 
happy to create an issue in GitHub.

||



--
~*-,._.,-*~'`^`'~*-,._.,-*~'`^`'~*-,._.,-*~'`^`'~*-,._.,-*~'`^`'~*-,._.,
Kevin Korb  Phone:(407) 252-6853
Systems Administrator   Internet:
FutureQuest, Inc.   ke...@futurequest.net  (work)
Orlando, Floridak...@sanitarium.net (personal)
Web page:   https://sanitarium.net/
PGP public key available on web site.
~*-,._.,-*~'`^`'~*-,._.,-*~'`^`'~*-,._.,-*~'`^`'~*-,._.,-*~'`^`'~*-,._.,

--
Please use reply-all for most replies to avoid omitting the mailing list.
To unsubscribe or change options: https://lists.samba.org/mailman/listinfo/rsync
Before posting, read: http://www.catb.org/~esr/faqs/smart-questions.html


Apparent synchronization bug in rsync

2022-12-08 Thread Mark Raymond via rsync
I believe I have found a synchronization bug in rsync. I have a pair of 
files, which when synced with||

||
|rsync --no-whole-file --inplace -S|||
||
|are not| identical afterwards. All three options are required, if I 
remove any one of the the files sync correctly. I have put the two 
files, along with a minimal test script, in this GitHub repo: 
https://github.com/mark-raymond/rsync-test


This looks like a bug to me; am I missing something? If it is a bug, I'm 
happy to create an issue in GitHub.

||

--
Please use reply-all for most replies to avoid omitting the mailing list.
To unsubscribe or change options: https://lists.samba.org/mailman/listinfo/rsync
Before posting, read: http://www.catb.org/~esr/faqs/smart-questions.html