Re: [sane-devel] pthread change proposal
Hi, On 2023-01-10 04:58, m. allan noah wrote: No way. It is not good practice to add a major, potentially breaking, and partially untested change to git mere days before a release. I propose that this change (or a derivative) gets merged a couple weeks after the release. Yeah, you are completely right. I will complete the work after the release and put out a call for testing then. Not sure what I was thinking. A temporary lapse of insanity on my part ;) In my defense I did post my worries that the code was largely untested and it was close to the release date. We *could* perhaps do a small change to the build system that enables MacOS builds again without the major structural changes involved in sanei_pthread. We do have some feedback that such a change does work for MacOS users and that would satisfy them in the short term. I will look into it. Cheers, Ralph
Re: [sane-devel] pthread change proposal
yes, stability rules. On January 10, 2023 1:58:38 PM GMT+01:00, "m. allan noah" wrote: >No way. It is not good practice to add a major, potentially breaking, and >partially untested change to git mere days before a release. I propose that >this change (or a derivative) gets merged a couple weeks after the release. > >allan > >On Tue, Jan 10, 2023 at 1:06 AM Ralph Little wrote: > >> Hi, >> We have a long-running issue related to pthread use in SANE backends. >> See here: https://gitlab.com/sane-project/backends/-/issues/153 >> >> I proposed a change to sanei_thread to try to sort some of these issues >> while improving detection of builds that abuse the restrictions >> surrounding pthread_t values. That proposal is here: >> https://gitlab.com/sane-project/backends/-/merge_requests/750 >> >> Povilas and I had some discussions about this solution and given the >> impending release of 1.2.1, someone has expressed a desire to see these >> issues solved, particularly as they relate to MacOS, which is properly >> broken at the moment. :( >> >> Could I get some further comments on the proposed solution and I would >> especially appreciate if we could see some testing of that branch >> solution on platforms other than Linux? >> >> Cheers, >> Ralph >> >> > >-- >"well, I stand up next to a mountain- and I chop it down with the edge of >my hand" -- "They who can give up essential liberty to obtain a little temporary safety, deserve neither liberty nor safety." Benjamin Franklin (1775)
Re: [sane-devel] pthread change proposal
No way. It is not good practice to add a major, potentially breaking, and partially untested change to git mere days before a release. I propose that this change (or a derivative) gets merged a couple weeks after the release. allan On Tue, Jan 10, 2023 at 1:06 AM Ralph Little wrote: > Hi, > We have a long-running issue related to pthread use in SANE backends. > See here: https://gitlab.com/sane-project/backends/-/issues/153 > > I proposed a change to sanei_thread to try to sort some of these issues > while improving detection of builds that abuse the restrictions > surrounding pthread_t values. That proposal is here: > https://gitlab.com/sane-project/backends/-/merge_requests/750 > > Povilas and I had some discussions about this solution and given the > impending release of 1.2.1, someone has expressed a desire to see these > issues solved, particularly as they relate to MacOS, which is properly > broken at the moment. :( > > Could I get some further comments on the proposed solution and I would > especially appreciate if we could see some testing of that branch > solution on platforms other than Linux? > > Cheers, > Ralph > > -- "well, I stand up next to a mountain- and I chop it down with the edge of my hand"
