[sane-devel] How to submit new scanner backend code

2012-01-21 Thread Bruce Karsh
Thanks for adding this printer.

I tried it and it works. I have a couple of comments about the doc.

1. Canon sells this device as the Canon 882, but it reports itself as
an 880. (880 probably refers to a family of simialr printer models,
not a specific model).  Someone who just bought one wouldn't
necessarily know that. So is there a way for the docs to also mention
882?

2. In pixma.desc it says ADF empty buggy. For the record, I can
confirm that it is still buggy. I tried scanning using the ADF with
the ADF empty and xsane threw up error dialogs. Adding documents
didn't help. Turning the printer off then on didn't help. When I
restarted xsane, it could no longer contact the printer. What worked
was to unplug the printer, plug it back in, then start xsane. I ran
strace to try to diagnose the problem. Strace showed that xsane could
not connect to port 8612 on the printer. I'm guessing that this is the
same bug as in PIXMA_870, not something newly introduced.

On Wed, Jan 18, 2012 at 12:00 AM, Rolf Bensch rolf at bensch-online.de wrote:
 Hello Bruce,

 your patch is in the git tree now.

 Please check your scanner again and also the documentation files.

 Cheers,
 Rolf


 Am -10.01.-28163 20:59, schrieb Bruce Karsh:

 I've added support in /backend for the MX882 scanner. I'd like to get
 this into the tree. What's the best way to go about this?

 (Although the box says MX882, it reports itself as an MX880). The
 patch is very short:

 diff -r SANE/sane-backends-1.0.22/backend/pixma_mp150.c
 SANE-ORIG/sane-backends-1.0.22/backend/pixma_mp150.c
 165,167d164
  ?/* PIXMA 2011 vintage */
  ?#define MX880_PID 0x1750
 
 1230d1226
  ? ? ? ? ?s-cfg-pid == MX880_PID ||
 1648,1650d1643
 
  ? ?/* PIXMA 2011 vintage */
  ? ?DEVICE (Canon PIXMA MX880, MX880, MX880_PID, 2400, 638, 877,
 PIXMA_CAP_CIS | PIXMA_CAP_ADFDUP),






[sane-devel] How to submit new scanner backend code

2012-01-21 Thread Rolf Bensch
Hi Bruce,


Am 21.01.2012 16:11, schrieb Bruce Karsh:
 Thanks for adding this printer.

 I tried it and it works. I have a couple of comments about the doc.

 1. Canon sells this device as the Canon 882, but it reports itself as
 an 880. (880 probably refers to a family of simialr printer models,
 not a specific model).  Someone who just bought one wouldn't
 necessarily know that. So is there a way for the docs to also mention
 882?

Then we should name this scanner as it is: MX882. Please try the 
attached patch.

If everything works, I also can change the doc files and commit this 
change to git.


 2. In pixma.desc it says ADF empty buggy. For the record, I can
 confirm that it is still buggy. I tried scanning using the ADF with
 the ADF empty and xsane threw up error dialogs. Adding documents
 didn't help. Turning the printer off then on didn't help. When I
 restarted xsane, it could no longer contact the printer. What worked
 was to unplug the printer, plug it back in, then start xsane. I ran
 strace to try to diagnose the problem. Strace showed that xsane could
 not connect to port 8612 on the printer. I'm guessing that this is the
 same bug as in PIXMA_870, not something newly introduced.


Please report this to the bug tracker.

Cheers,
Rolf
-- next part --
A non-text attachment was scrubbed...
Name: pixma_mp150.c.diff
Type: text/x-patch
Size: 1182 bytes
Desc: not available
URL: 
http://lists.alioth.debian.org/pipermail/sane-devel/attachments/20120121/28e734ad/attachment.bin


[sane-devel] Subject: [PATCH 0/4] fix and cleanup portable PATH_SEP and DIR_PATH defines

2012-01-21 Thread Chris Bagwell
On Tue, Jan 17, 2012 at 6:13 PM, Ruediger Meier sweet_f_a at gmx.de wrote:
 On Wednesday 18 January 2012, Chris Bagwell wrote:
 On Tue, Jan 17, 2012 at 3:01 PM, Ruediger Meier wrote:

  Thx, I just see I've messed up that patch series a little while
  playing around with my MUA. Could you cleanly apply it? If not then
  I would reroll it.

 I haven't tried yet. ?Can you resend directly to me to save time?
 You can send as attachements to me until you get MUA worked out.

 Please pull from my private clone
 git://github.com/rudimeier/sane-backends.git

 branches
 win32/path
 win32/scsi


Thanks.  That was easiest way.

I've just pushed your changes.  I added a change log entry to your
second patch series.

I appreciate the scsi fix.  I was struggle with how to fix that since
it was reported not compiling with mingw64.

Chris