svn commit: r1683575 - /james/hupa/trunk/client/src/main/java/org/apache/hupa/client/activity/ComposeActivity.java
Author: dongxu
Date: Thu Jun 4 15:22:08 2015
New Revision: 1683575
URL: http://svn.apache.org/r1683575
Log:
it will redirect the inbox rather than nullpointerexception.
Modified:
james/hupa/trunk/client/src/main/java/org/apache/hupa/client/activity/ComposeActivity.java
Modified:
james/hupa/trunk/client/src/main/java/org/apache/hupa/client/activity/ComposeActivity.java
URL:
http://svn.apache.org/viewvc/james/hupa/trunk/client/src/main/java/org/apache/hupa/client/activity/ComposeActivity.java?rev=1683575r1=1683574r2=1683575view=diff
==
---
james/hupa/trunk/client/src/main/java/org/apache/hupa/client/activity/ComposeActivity.java
(original)
+++
james/hupa/trunk/client/src/main/java/org/apache/hupa/client/activity/ComposeActivity.java
Thu Jun 4 15:22:08 2015
@@ -395,8 +395,6 @@ public class ComposeActivity extends App
}
});
} else if (forward.equals(place.getToken())) {
-// FIXME will get a NullPointerException given accessing
-// directly from some URL like #/compose:forward
SendForwardMessageRequest req = rf.sendForwardMessageRequest();
SendForwardMessageAction action =
req.create(SendForwardMessageAction.class);
action.setReferences(oldDetails.getReferences());
-
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org
svn commit: r1683566 - in /james/mailbox/trunk: memory/src/test/java/org/apache/james/mailbox/inmemory/ memory/src/test/java/org/apache/james/mailbox/inmemory/mail/ store/src/test/java/org/apache/jame
Author: eric
Date: Thu Jun 4 14:55:23 2015
New Revision: 1683566
URL: http://svn.apache.org/r1683566
Log:
Fix eric mess (MAILBOX-11)
Added:
james/mailbox/trunk/memory/src/test/java/org/apache/james/mailbox/inmemory/InMemoryMailboxMapperTest.java
james/mailbox/trunk/store/src/test/java/org/apache/james/mailbox/store/StoreMailboxManagerTest.java
Removed:
james/mailbox/trunk/memory/src/test/java/org/apache/james/mailbox/inmemory/mail/
james/mailbox/trunk/store/src/test/java/org/apache/james/mailbox/store/StoreMailboxManager.java
Added:
james/mailbox/trunk/memory/src/test/java/org/apache/james/mailbox/inmemory/InMemoryMailboxMapperTest.java
URL:
http://svn.apache.org/viewvc/james/mailbox/trunk/memory/src/test/java/org/apache/james/mailbox/inmemory/InMemoryMailboxMapperTest.java?rev=1683566view=auto
==
---
james/mailbox/trunk/memory/src/test/java/org/apache/james/mailbox/inmemory/InMemoryMailboxMapperTest.java
(added)
+++
james/mailbox/trunk/memory/src/test/java/org/apache/james/mailbox/inmemory/InMemoryMailboxMapperTest.java
Thu Jun 4 14:55:23 2015
@@ -0,0 +1,86 @@
+/
+ * Licensed to the Apache Software Foundation (ASF) under one *
+ * or more contributor license agreements. See the NOTICE file *
+ * distributed with this work for additional information*
+ * regarding copyright ownership. The ASF licenses this file *
+ * to you under the Apache License, Version 2.0 (the*
+ * License); you may not use this file except in compliance *
+ * with the License. You may obtain a copy of the License at *
+ * *
+ * http://www.apache.org/licenses/LICENSE-2.0 *
+ * *
+ * Unless required by applicable law or agreed to in writing, *
+ * software distributed under the License is distributed on an *
+ * AS IS BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY *
+ * KIND, either express or implied. See the License for the*
+ * specific language governing permissions and limitations *
+ * under the License. *
+ /
+
+package org.apache.james.mailbox.inmemory;
+
+import org.apache.james.mailbox.exception.MailboxException;
+import org.apache.james.mailbox.mock.MockMailboxSession;
+import org.apache.james.mailbox.model.MailboxPath;
+import org.apache.james.mailbox.store.mail.MailboxMapper;
+import org.apache.james.mailbox.store.mail.model.Mailbox;
+import org.apache.james.mailbox.store.mail.model.impl.SimpleMailbox;
+import org.junit.Before;
+import org.junit.Test;
+
+import static org.assertj.core.api.Assertions.assertThat;
+
+public class InMemoryMailboxMapperTest {
+
+public static final int UID_VALIDITY = 10;
+
+private MailboxPath user1InboxPath;
+private MailboxPath user1SubMailbox1Path;
+private MailboxPath user1SubMailbox2Path;
+private MailboxPath user2OtherBoxPath;
+private MailboxPath user1OtherNamespacePath;
+
+private MailboxLong user1Inbox;
+private MailboxLong user1SubMailbox1;
+private MailboxLong user1SubMailbox2;
+
+private MailboxMapperLong mapper;
+
+@Before
+public void setUp() throws MailboxException {
+user1InboxPath = new MailboxPath(#private, user1, INBOX);
+user1SubMailbox1Path = new MailboxPath(#private, user1,
INBOX.sub1);
+user1SubMailbox2Path = new MailboxPath(#private, user1,
INBOX.sub2);
+user2OtherBoxPath = new MailboxPath(#private, user2, other.user);
+user1OtherNamespacePath = new MailboxPath(#namspace, user1,
other.namespace);
+user1Inbox = new SimpleMailboxLong(user1InboxPath, UID_VALIDITY);
+user1SubMailbox1 = new SimpleMailboxLong(user1SubMailbox1Path,
UID_VALIDITY);
+user1SubMailbox2 = new SimpleMailboxLong(user1SubMailbox2Path,
UID_VALIDITY);
+mapper = new
InMemoryMailboxSessionMapperFactory().createMailboxMapper(new
MockMailboxSession(user));
+mapper.save(user1Inbox);
+mapper.save(user1SubMailbox1);
+mapper.save(user1SubMailbox2);
+mapper.save(new SimpleMailboxLong(user2OtherBoxPath, UID_VALIDITY));
+mapper.save(new SimpleMailboxLong(user1OtherNamespacePath,
UID_VALIDITY));
+}
+
+@Test
+public void
findMailboxWithPatchLikeOnAllMaillboxesShouldReturnMailboxesBelongingToThisNamespaceAndUser()
throws MailboxException{
+assertThat(mapper.findMailboxWithPathLike(new MailboxPath(#private,
user1, %)))
+.containsOnly(user1Inbox, user1SubMailbox1, user1SubMailbox2);
+}
+
+@Test
+public void findMailboxWithPatchLikeBasedOnInboxShouldReturnItsChildren()
throws MailboxException{
+assertThat(mapper.findMailboxWithPathLike(new
[jira] [Commented] (MAILBOX-11) MailboxQuery ignore namespace
[ https://issues.apache.org/jira/browse/MAILBOX-11?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14572920#comment-14572920 ] Eric Charles commented on MAILBOX-11: - Sorry for the mess. Should be ok now. MailboxQuery ignore namespace - Key: MAILBOX-11 URL: https://issues.apache.org/jira/browse/MAILBOX-11 Project: James Mailbox Issue Type: Bug Environment: Linux, JDK 1.6 Reporter: François-Denis Gonthier Assignee: Eric Charles Fix For: 0.6 Attachments: 0001-MAILBOX-11-Add-filters-on-namespace-and-user-for-sea.patch MailboxQuery doesn't pay any attention to namespace of the mailbox it is based on. For example, Mozilla Thunderbird might to mailbox search with expressions like #private.%. That expression is passed directly to the isExpressionMatch method of the MailboxQuery class. This has obviously incorrect results. Arguments to the isExpressionMatch method should be parsed to separate the namespace from the mailbox name or isExpressionMatch should do the parsing itself. In that case the argument name should be renamed to something like 'searchExpression' instead of 'name' which doesn't convey the right meaning. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org
svn commit: r1683571 - in /james/hupa/trunk/client/src/main/java/org/apache/hupa/client/validation: EmailListValidator.java NotEmptyValidator.java
Author: dongxu
Date: Thu Jun 4 15:06:12 2015
New Revision: 1683571
URL: http://svn.apache.org/r1683571
Log:
remove some warnings using the suppress warnings.
Modified:
james/hupa/trunk/client/src/main/java/org/apache/hupa/client/validation/EmailListValidator.java
james/hupa/trunk/client/src/main/java/org/apache/hupa/client/validation/NotEmptyValidator.java
Modified:
james/hupa/trunk/client/src/main/java/org/apache/hupa/client/validation/EmailListValidator.java
URL:
http://svn.apache.org/viewvc/james/hupa/trunk/client/src/main/java/org/apache/hupa/client/validation/EmailListValidator.java?rev=1683571r1=1683570r2=1683571view=diff
==
---
james/hupa/trunk/client/src/main/java/org/apache/hupa/client/validation/EmailListValidator.java
(original)
+++
james/hupa/trunk/client/src/main/java/org/apache/hupa/client/validation/EmailListValidator.java
Thu Jun 4 15:06:12 2015
@@ -40,7 +40,8 @@ public class EmailListValidator extends
this.text = text;
}
-@Override
+@SuppressWarnings(unchecked)
+ @Override
public void invokeActions(ValidationResult result) {
for (ValidationActionHasText action : getFailureActions())
action.invoke(result, text);
Modified:
james/hupa/trunk/client/src/main/java/org/apache/hupa/client/validation/NotEmptyValidator.java
URL:
http://svn.apache.org/viewvc/james/hupa/trunk/client/src/main/java/org/apache/hupa/client/validation/NotEmptyValidator.java?rev=1683571r1=1683570r2=1683571view=diff
==
---
james/hupa/trunk/client/src/main/java/org/apache/hupa/client/validation/NotEmptyValidator.java
(original)
+++
james/hupa/trunk/client/src/main/java/org/apache/hupa/client/validation/NotEmptyValidator.java
Thu Jun 4 15:06:12 2015
@@ -38,7 +38,8 @@ public class NotEmptyValidator extends V
public NotEmptyValidator(HasText text) {
this.text = text;
}
-@Override
+@SuppressWarnings(unchecked)
+ @Override
public void invokeActions(ValidationResult result) {
for (ValidationActionHasText action : getFailureActions())
action.invoke(result, text);
-
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org
[jira] [Closed] (MAILBOX-217) We should index attachment in elastic search
[ https://issues.apache.org/jira/browse/MAILBOX-217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tellier Benoit closed MAILBOX-217. -- Resolution: Duplicate We are reviewing work I did for this feature. This issue will be divided in smallest issues. The first one is MAILBOX-234 We should index attachment in elastic search Key: MAILBOX-217 URL: https://issues.apache.org/jira/browse/MAILBOX-217 Project: James Mailbox Issue Type: Improvement Reporter: Tellier Benoit Attachment should be indexed in message document as nested document. Their textual content should be available for better search results. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org
[jira] [Created] (MAILBOX-235) Convert James Query to ElasticSearch query.
Tellier Benoit created MAILBOX-235: -- Summary: Convert James Query to ElasticSearch query. Key: MAILBOX-235 URL: https://issues.apache.org/jira/browse/MAILBOX-235 Project: James Mailbox Issue Type: New Feature Reporter: Tellier Benoit We should manage to convert James query into a combinaiseon of filters and queries. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org
Jenkins build is still unstable: james-server-trunk #5271
See https://builds.apache.org/job/james-server-trunk/5271/ - To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org
Jenkins build is still unstable: james-server-trunk » Apache James :: Server :: POP3 #5271
See https://builds.apache.org/job/james-server-trunk/org.apache.james$james-server-protocols-pop3/5271/ - To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org
[jira] [Created] (MAILBOX-234) Convert Message into JSON
Tellier Benoit created MAILBOX-234: -- Summary: Convert Message into JSON Key: MAILBOX-234 URL: https://issues.apache.org/jira/browse/MAILBOX-234 Project: James Mailbox Issue Type: New Feature Reporter: Tellier Benoit This would give us the ability to index e-mails in ElasticSearch. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org
