[jira] [Created] (JAMES-2267) Improve mailet integration test fluency

[Tellier Benoit (JIRA)]

Tellier Benoit created JAMES-2267:
-

 Summary: Improve mailet integration test fluency
 Key: JAMES-2267
 URL: https://issues.apache.org/jira/browse/JAMES-2267
 Project: James Server
  Issue Type: Improvement
  Components: Mailet Contributions
Affects Versions: master
Reporter: Tellier Benoit


We can significantly improve readability by:
 - Providing some defaults for testing mailet configuration. Especially 
`postmaster` and `threads` options
 - Avoid calling `build` method. This can be done explicitly by the target 
method, and result in less boiler plate and more compact code.
 - We can factorize BCC mailet. Its configuration is compulsory, and it's 
content can not be customized.
 - We can get ride of various constants (factorize them and better rely on 
builders capabilities)
 - We can avoid launching a full JMAP server when not needed
 - SMTP and IMAP clients should be test rules. That way, no try with resource 
is needed.
 - We can also clean some configuration there, some user/mailbox creation might 
also not be needed.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org

[jira] [Created] (JAMES-2266) Add a utility for correcting Ghost mailbox bug

[Tellier Benoit (JIRA)]

Tellier Benoit created JAMES-2266:
-

 Summary: Add a utility for correcting Ghost mailbox bug
 Key: JAMES-2266
 URL: https://issues.apache.org/jira/browse/JAMES-2266
 Project: James Server
  Issue Type: New Feature
  Components: cassandra, webadmin
Affects Versions: master
Reporter: Tellier Benoit


The idea is to solve the symptoms of ghostmailbox bug (described in MAILBOX-322 
)

We need a utility able to merge the old mailbox with the new one:

 - The old mailbox should no more be available
 - It's content and rights should be merged with the new mailbox

We need this as a webadmin runnable task.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org

james-project git commit: Cleanup: Avoid using AssertJ Assertions.fail()

[btellier]

Repository: james-project
Updated Branches:
  refs/heads/master cba3030e6 -> a1340b7c0


Cleanup: Avoid using AssertJ Assertions.fail()


Project: http://git-wip-us.apache.org/repos/asf/james-project/repo
Commit: http://git-wip-us.apache.org/repos/asf/james-project/commit/a1340b7c
Tree: http://git-wip-us.apache.org/repos/asf/james-project/tree/a1340b7c
Diff: http://git-wip-us.apache.org/repos/asf/james-project/diff/a1340b7c

Branch: refs/heads/master
Commit: a1340b7c022530c9c98881fa5fcf0969568fac8d
Parents: cba3030
Author: benwa 
Authored: Mon Dec 18 13:05:31 2017 +0700
Committer: benwa 
Committed: Wed Dec 20 13:13:02 2017 +0700

--
 .../init/CassandraTypeProviderTest.java |  15 +-
 .../mail/CassandraMailboxMapperTest.java|  20 +--
 .../store/mail/model/MailboxMapperTest.java |  45 ++
 .../mailbox/store/quota/QuotaCheckerTest.java   |  42 ++---
 .../org/apache/james/cli/ServerCmdTest.java |  44 ++---
 .../utils/InMemoryMailRepositoryStoreTest.java  |  34 ++--
 .../lib/AbstractRecipientRewriteTableTest.java  | 159 +++
 .../james/rrt/lib/RewriteTablesStepdefs.java|  15 +-
 .../resources/cucumber/rewrite_tables.feature   |  10 +-
 9 files changed, 137 insertions(+), 247 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/james-project/blob/a1340b7c/backends-common/cassandra/src/test/java/org/apache/james/backends/cassandra/init/CassandraTypeProviderTest.java
--
diff --git 
a/backends-common/cassandra/src/test/java/org/apache/james/backends/cassandra/init/CassandraTypeProviderTest.java
 
b/backends-common/cassandra/src/test/java/org/apache/james/backends/cassandra/init/CassandraTypeProviderTest.java
index 3517349..4a3212b 100644
--- 
a/backends-common/cassandra/src/test/java/org/apache/james/backends/cassandra/init/CassandraTypeProviderTest.java
+++ 
b/backends-common/cassandra/src/test/java/org/apache/james/backends/cassandra/init/CassandraTypeProviderTest.java
@@ -21,7 +21,6 @@ package org.apache.james.backends.cassandra.init;
 
 import static com.datastax.driver.core.DataType.text;
 import static org.assertj.core.api.Assertions.assertThat;
-import static org.assertj.core.api.Assertions.fail;
 
 import java.util.Arrays;
 import java.util.List;
@@ -80,7 +79,8 @@ public class CassandraTypeProviderTest {
 
 @Test
 public void initializeTypesShouldCreateTheTypes() {
-deleteMailboxBaseType();
+cassandra.getConf().execute(SchemaBuilder.dropType(TYPE_NAME));
+
 new CassandraTypesCreator(module, 
cassandra.getConf()).initializeTypes();
 CassandraTypesProvider cassandraTypesProviderTest = new 
CassandraTypesProvider(module, cassandra.getConf());
 assertThat(cassandraTypesProviderTest.getDefinedUserType(TYPE_NAME))
@@ -94,15 +94,4 @@ public class CassandraTypeProviderTest {
 .isNotNull();
 }
 
-private void deleteMailboxBaseType() {
-try {
-cassandra.getConf().execute(SchemaBuilder.dropType(TYPE_NAME));
-} catch (Exception exception) {
-exception.printStackTrace();
-fail("Exception is thrown on Type deletion");
-}
-}
-
-
-
 }

http://git-wip-us.apache.org/repos/asf/james-project/blob/a1340b7c/mailbox/cassandra/src/test/java/org/apache/james/mailbox/cassandra/mail/CassandraMailboxMapperTest.java
--
diff --git 
a/mailbox/cassandra/src/test/java/org/apache/james/mailbox/cassandra/mail/CassandraMailboxMapperTest.java
 
b/mailbox/cassandra/src/test/java/org/apache/james/mailbox/cassandra/mail/CassandraMailboxMapperTest.java
index 2827bf9..b316a99 100644
--- 
a/mailbox/cassandra/src/test/java/org/apache/james/mailbox/cassandra/mail/CassandraMailboxMapperTest.java
+++ 
b/mailbox/cassandra/src/test/java/org/apache/james/mailbox/cassandra/mail/CassandraMailboxMapperTest.java
@@ -20,9 +20,7 @@
 package org.apache.james.mailbox.cassandra.mail;
 
 import static org.assertj.core.api.Assertions.assertThat;
-import static org.assertj.core.api.Assertions.fail;
-
-import java.util.Optional;
+import static org.assertj.core.api.Assertions.assertThatThrownBy;
 
 import org.apache.commons.lang3.StringUtils;
 import org.apache.james.backends.cassandra.CassandraCluster;
@@ -30,7 +28,6 @@ import 
org.apache.james.backends.cassandra.DockerCassandraRule;
 import org.apache.james.backends.cassandra.init.CassandraConfiguration;
 import org.apache.james.backends.cassandra.init.CassandraModuleComposite;
 import org.apache.james.backends.cassandra.utils.CassandraUtils;
-import 
org.apache.james.mailbox.cassandra.mail.CassandraMailboxPathDAO.CassandraIdAndPath;
 import org.apache.james.mailbox.cassandra.modules.CassandraAclModule;
 import 

[jira] [Resolved] (JAMES-2260) RemoteDelivery mailet delayTime parse issue

[Tellier Benoit (JIRA)]

 [ 
https://issues.apache.org/jira/browse/JAMES-2260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tellier Benoit resolved JAMES-2260.
---
Resolution: Fixed

> RemoteDelivery mailet delayTime parse issue
> ---
>
> Key: JAMES-2260
> URL: https://issues.apache.org/jira/browse/JAMES-2260
> Project: James Server
>  Issue Type: Bug
>  Components: Remote Delivery
>Affects Versions: 3.0.0-beta5, master
>Reporter: Taro App
>Priority: Minor
> Attachments: Delay.patch, DelayTest.java.patch, 
> DelaysAndMaxRetry.patch, DelaysAndMaxRetryTest.java.patch
>
>
> This works:
> {code:xml}
> 3* 5 minutes,3* 15 minutes,23* 1 hour
> {code}
> But these don't work:
> {code:xml}
> 3* 5 minutes, 3* 15 minutes, 23* 1 hour
> 3 * 5 minutes,3 * 15 minutes,23 * 1 hour
> 3 * 5 minutes, 3 * 15 minutes, 23 * 1 hour
> {code}
> Notice the spaces. The last one is usually what people would write.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org

[jira] [Closed] (JAMES-2260) RemoteDelivery mailet delayTime parse issue

[Tellier Benoit (JIRA)]

 [ 
https://issues.apache.org/jira/browse/JAMES-2260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tellier Benoit closed JAMES-2260.
-

> RemoteDelivery mailet delayTime parse issue
> ---
>
> Key: JAMES-2260
> URL: https://issues.apache.org/jira/browse/JAMES-2260
> Project: James Server
>  Issue Type: Bug
>  Components: Remote Delivery
>Affects Versions: 3.0.0-beta5, master
>Reporter: Taro App
>Priority: Minor
> Attachments: Delay.patch, DelayTest.java.patch, 
> DelaysAndMaxRetry.patch, DelaysAndMaxRetryTest.java.patch
>
>
> This works:
> {code:xml}
> 3* 5 minutes,3* 15 minutes,23* 1 hour
> {code}
> But these don't work:
> {code:xml}
> 3* 5 minutes, 3* 15 minutes, 23* 1 hour
> 3 * 5 minutes,3 * 15 minutes,23 * 1 hour
> 3 * 5 minutes, 3 * 15 minutes, 23 * 1 hour
> {code}
> Notice the spaces. The last one is usually what people would write.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org

[jira] [Commented] (JAMES-2260) RemoteDelivery mailet delayTime parse issue

[btell...@apache.org (JIRA)]

[ 
https://issues.apache.org/jira/browse/JAMES-2260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16297763#comment-16297763
 ] 

btell...@apache.org commented on JAMES-2260:


https://github.com/apache/james-project/pull/89 solved the issue

> RemoteDelivery mailet delayTime parse issue
> ---
>
> Key: JAMES-2260
> URL: https://issues.apache.org/jira/browse/JAMES-2260
> Project: James Server
>  Issue Type: Bug
>  Components: Remote Delivery
>Affects Versions: 3.0.0-beta5, master
>Reporter: Taro App
>Priority: Minor
> Attachments: Delay.patch, DelayTest.java.patch, 
> DelaysAndMaxRetry.patch, DelaysAndMaxRetryTest.java.patch
>
>
> This works:
> {code:xml}
> 3* 5 minutes,3* 15 minutes,23* 1 hour
> {code}
> But these don't work:
> {code:xml}
> 3* 5 minutes, 3* 15 minutes, 23* 1 hour
> 3 * 5 minutes,3 * 15 minutes,23 * 1 hour
> 3 * 5 minutes, 3 * 15 minutes, 23 * 1 hour
> {code}
> Notice the spaces. The last one is usually what people would write.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org

[jira] [Commented] (JAMES-2260) RemoteDelivery mailet delayTime parse issue

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/JAMES-2260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16297755#comment-16297755
 ] 

ASF GitHub Bot commented on JAMES-2260:
---

Github user chibenwa commented on the issue:

https://github.com/apache/james-project/pull/89
  
Hi,

I just merged this contribution. You can find it on master, and it will be 
available in the next release.

Thanks again for your commitment to the James project.

One last thing: Can you close this pull request? This will avoid me to ask 
about it to the Apache infrastructure team.

Benoit Tellier


> RemoteDelivery mailet delayTime parse issue
> ---
>
> Key: JAMES-2260
> URL: https://issues.apache.org/jira/browse/JAMES-2260
> Project: James Server
>  Issue Type: Bug
>  Components: Remote Delivery
>Affects Versions: 3.0.0-beta5, master
>Reporter: Taro App
>Priority: Minor
> Attachments: Delay.patch, DelayTest.java.patch, 
> DelaysAndMaxRetry.patch, DelaysAndMaxRetryTest.java.patch
>
>
> This works:
> {code:xml}
> 3* 5 minutes,3* 15 minutes,23* 1 hour
> {code}
> But these don't work:
> {code:xml}
> 3* 5 minutes, 3* 15 minutes, 23* 1 hour
> 3 * 5 minutes,3 * 15 minutes,23 * 1 hour
> 3 * 5 minutes, 3 * 15 minutes, 23 * 1 hour
> {code}
> Notice the spaces. The last one is usually what people would write.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org

[1/2] james-project git commit: JAMES-2260 RemoteDelivery retry delays configuration can contain spaces

[btellier]

Repository: james-project
Updated Branches:
  refs/heads/master c424accd9 -> cba3030e6


JAMES-2260 RemoteDelivery retry delays configuration can contain spaces


Project: http://git-wip-us.apache.org/repos/asf/james-project/repo
Commit: http://git-wip-us.apache.org/repos/asf/james-project/commit/1a7b6a94
Tree: http://git-wip-us.apache.org/repos/asf/james-project/tree/1a7b6a94
Diff: http://git-wip-us.apache.org/repos/asf/james-project/diff/1a7b6a94

Branch: refs/heads/master
Commit: 1a7b6a94bfa24a48dc965a99b8b8c165514eeef3
Parents: c424acc
Author: apptaro 
Authored: Mon Dec 18 15:46:22 2017 +0900
Committer: benwa 
Committed: Wed Dec 20 08:23:05 2017 +0700

--
 server/app/src/main/resources/mailetcontainer.xml   | 9 +
 .../james/transport/mailets/remoteDelivery/Delay.java   | 2 +-
 .../transport/mailets/remoteDelivery/DelaysAndMaxRetry.java | 1 +
 .../james/transport/mailets/remoteDelivery/DelayTest.java   | 5 +
 .../mailets/remoteDelivery/DelaysAndMaxRetryTest.java   | 7 +++
 5 files changed, 15 insertions(+), 9 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/james-project/blob/1a7b6a94/server/app/src/main/resources/mailetcontainer.xml
--
diff --git a/server/app/src/main/resources/mailetcontainer.xml 
b/server/app/src/main/resources/mailetcontainer.xml
index 93760a9..bce475e 100644
--- a/server/app/src/main/resources/mailetcontainer.xml
+++ b/server/app/src/main/resources/mailetcontainer.xml
@@ -294,14 +294,7 @@ Regards, Postmaster XXX.YYY
   
   5000, 10, 50
   25

http://git-wip-us.apache.org/repos/asf/james-project/blob/1a7b6a94/server/mailet/mailets/src/main/java/org/apache/james/transport/mailets/remoteDelivery/Delay.java
--
diff --git 
a/server/mailet/mailets/src/main/java/org/apache/james/transport/mailets/remoteDelivery/Delay.java
 
b/server/mailet/mailets/src/main/java/org/apache/james/transport/mailets/remoteDelivery/Delay.java
index d293f13..8d48757 100644
--- 
a/server/mailet/mailets/src/main/java/org/apache/james/transport/mailets/remoteDelivery/Delay.java
+++ 
b/server/mailet/mailets/src/main/java/org/apache/james/transport/mailets/remoteDelivery/Delay.java
@@ -43,7 +43,7 @@ public class Delay {
 if (Strings.isNullOrEmpty(initString)) {
 throw new NumberFormatException("Null or Empty strings are not 
permitted");
 }
-List parts = Splitter.on('*').splitToList(initString);
+List parts = 
Splitter.on('*').trimResults().splitToList(initString);
 
 if (parts.size() == 1) {
 return new Delay(DEFAULT_ATTEMPTS, 
TimeConverter.getMilliSeconds(parts.get(0)));

http://git-wip-us.apache.org/repos/asf/james-project/blob/1a7b6a94/server/mailet/mailets/src/main/java/org/apache/james/transport/mailets/remoteDelivery/DelaysAndMaxRetry.java
--
diff --git 
a/server/mailet/mailets/src/main/java/org/apache/james/transport/mailets/remoteDelivery/DelaysAndMaxRetry.java
 
b/server/mailet/mailets/src/main/java/org/apache/james/transport/mailets/remoteDelivery/DelaysAndMaxRetry.java
index e627ea0..ecd9deb 100644
--- 
a/server/mailet/mailets/src/main/java/org/apache/james/transport/mailets/remoteDelivery/DelaysAndMaxRetry.java
+++ 
b/server/mailet/mailets/src/main/java/org/apache/james/transport/mailets/remoteDelivery/DelaysAndMaxRetry.java
@@ -81,6 +81,7 @@ public class DelaysAndMaxRetry {
 
 List delayStrings = Splitter.on(',')
 .omitEmptyStrings()
+.trimResults()
 .splitToList(delaysAsString);
 
 ImmutableList.Builder builder = ImmutableList.builder();

http://git-wip-us.apache.org/repos/asf/james-project/blob/1a7b6a94/server/mailet/mailets/src/test/java/org/apache/james/transport/mailets/remoteDelivery/DelayTest.java
--
diff --git 
a/server/mailet/mailets/src/test/java/org/apache/james/transport/mailets/remoteDelivery/DelayTest.java
 
b/server/mailet/mailets/src/test/java/org/apache/james/transport/mailets/remoteDelivery/DelayTest.java
index b940c3e..6adb15d 100644
--- 
a/server/mailet/mailets/src/test/java/org/apache/james/transport/mailets/remoteDelivery/DelayTest.java
+++ 
b/server/mailet/mailets/src/test/java/org/apache/james/transport/mailets/remoteDelivery/DelayTest.java
@@ -94,6 +94,11 @@ public class DelayTest {
 public void stringConstructorShouldWorkForNumberAttemptsAndUnit() throws 
Exception {
 assertThat(Delay.from("2*36s")).isEqualTo(new Delay(2, 36000));
 }
+
+@Test
+public void 
stringConstructorShouldWorkForNumberAttemptsAndUnitWithSpaces() 

[2/2] james-project git commit: JAMES-2260 Fix typo s/expended/expanded/

[btellier]

JAMES-2260 Fix typo s/expended/expanded/


Project: http://git-wip-us.apache.org/repos/asf/james-project/repo
Commit: http://git-wip-us.apache.org/repos/asf/james-project/commit/cba3030e
Tree: http://git-wip-us.apache.org/repos/asf/james-project/tree/cba3030e
Diff: http://git-wip-us.apache.org/repos/asf/james-project/diff/cba3030e

Branch: refs/heads/master
Commit: cba3030e677b9ab12a52342fdcd9b30992bc541f
Parents: 1a7b6a9
Author: benwa 
Authored: Mon Dec 18 17:15:02 2017 +0700
Committer: benwa 
Committed: Wed Dec 20 08:23:06 2017 +0700

--
 .../mailets/remoteDelivery/DelaysAndMaxRetry.java   |  3 ++-
 .../remoteDelivery/RemoteDeliveryConfiguration.java |  4 ++--
 .../remoteDelivery/DelaysAndMaxRetryTest.java   | 16 
 3 files changed, 12 insertions(+), 11 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/james-project/blob/cba3030e/server/mailet/mailets/src/main/java/org/apache/james/transport/mailets/remoteDelivery/DelaysAndMaxRetry.java
--
diff --git 
a/server/mailet/mailets/src/main/java/org/apache/james/transport/mailets/remoteDelivery/DelaysAndMaxRetry.java
 
b/server/mailet/mailets/src/main/java/org/apache/james/transport/mailets/remoteDelivery/DelaysAndMaxRetry.java
index ecd9deb..e2b43ba 100644
--- 
a/server/mailet/mailets/src/main/java/org/apache/james/transport/mailets/remoteDelivery/DelaysAndMaxRetry.java
+++ 
b/server/mailet/mailets/src/main/java/org/apache/james/transport/mailets/remoteDelivery/DelaysAndMaxRetry.java
@@ -20,6 +20,7 @@
 package org.apache.james.transport.mailets.remoteDelivery;
 
 import java.util.List;
+
 import javax.mail.MessagingException;
 
 import org.slf4j.Logger;
@@ -134,7 +135,7 @@ public class DelaysAndMaxRetry {
  * @param list the list to expand
  * @return the expanded list
  */
-public List getExpendedDelays() {
+public List getExpandedDelays() {
 ImmutableList.Builder builder = ImmutableList.builder();
 for (Delay delay: delays) {
 builder.addAll(delay.getExpendendDelays());

http://git-wip-us.apache.org/repos/asf/james-project/blob/cba3030e/server/mailet/mailets/src/main/java/org/apache/james/transport/mailets/remoteDelivery/RemoteDeliveryConfiguration.java
--
diff --git 
a/server/mailet/mailets/src/main/java/org/apache/james/transport/mailets/remoteDelivery/RemoteDeliveryConfiguration.java
 
b/server/mailet/mailets/src/main/java/org/apache/james/transport/mailets/remoteDelivery/RemoteDeliveryConfiguration.java
index d6c59d8..1c970d6 100644
--- 
a/server/mailet/mailets/src/main/java/org/apache/james/transport/mailets/remoteDelivery/RemoteDeliveryConfiguration.java
+++ 
b/server/mailet/mailets/src/main/java/org/apache/james/transport/mailets/remoteDelivery/RemoteDeliveryConfiguration.java
@@ -24,8 +24,8 @@ import java.util.List;
 import java.util.Optional;
 import java.util.Properties;
 
-import org.apache.james.domainlist.api.DomainList;
 import org.apache.commons.lang3.tuple.Pair;
+import org.apache.james.domainlist.api.DomainList;
 import org.apache.mailet.MailetConfig;
 import org.apache.mailet.base.MailetUtil;
 import org.slf4j.Logger;
@@ -101,7 +101,7 @@ public class RemoteDeliveryConfiguration {
 
 DelaysAndMaxRetry delaysAndMaxRetry = 
computeDelaysAndMaxRetry(mailetConfig);
 maxRetries = delaysAndMaxRetry.getMaxRetries();
-delayTimes = delaysAndMaxRetry.getExpendedDelays();
+delayTimes = delaysAndMaxRetry.getExpandedDelays();
 smtpTimeout = computeSmtpTimeout(mailetConfig);
 connectionTimeout = computeConnectionTimeout(mailetConfig);
 dnsProblemRetry = computeDnsProblemRetry(mailetConfig);

http://git-wip-us.apache.org/repos/asf/james-project/blob/cba3030e/server/mailet/mailets/src/test/java/org/apache/james/transport/mailets/remoteDelivery/DelaysAndMaxRetryTest.java
--
diff --git 
a/server/mailet/mailets/src/test/java/org/apache/james/transport/mailets/remoteDelivery/DelaysAndMaxRetryTest.java
 
b/server/mailet/mailets/src/test/java/org/apache/james/transport/mailets/remoteDelivery/DelaysAndMaxRetryTest.java
index 223acb2..133743d 100644
--- 
a/server/mailet/mailets/src/test/java/org/apache/james/transport/mailets/remoteDelivery/DelaysAndMaxRetryTest.java
+++ 
b/server/mailet/mailets/src/test/java/org/apache/james/transport/mailets/remoteDelivery/DelaysAndMaxRetryTest.java
@@ -114,30 +114,30 @@ public class DelaysAndMaxRetryTest {
 }
 
 @Test
-public void getExpendedDelaysShouldReturnEmptyWhenNoDelay() throws 
Exception {
+public void getExpandedDelaysShouldReturnEmptyWhenNoDelay() throws 
Exception {
 DelaysAndMaxRetry 

[jira] [Commented] (JAMES-2263) onMailetException doesn't work even the default onMailetException="error"

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/JAMES-2263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16297739#comment-16297739
 ] 

ASF GitHub Bot commented on JAMES-2263:
---

Github user chibenwa commented on the issue:

https://github.com/apache/james-project/pull/91
  
@apptaro  When merged the fixes are available on the master branch. You 
could be using it while waiting for a fix.

Concerning a release date, that is a good question. We need to switch to 
time based release so that I'm confident answering it.

Cheers,


> onMailetException doesn't work even the default onMailetException="error"
> -
>
> Key: JAMES-2263
> URL: https://issues.apache.org/jira/browse/JAMES-2263
> Project: James Server
>  Issue Type: Bug
>  Components: Matchers/Mailets (bundled), SpoolManager & Processors
>Affects Versions: 3.0.0-beta5
>Reporter: Taro App
>
> Tested with 3.0.1. When a mailet raises an exception, the message is not sent 
> to the processor specified with onMailetException. Only 
> onMailetException="ignore" works. Other values don't work, the even the 
> default onMailetException="error". Instead the message is somehow processed 7 
> times and then discarded.
> See org.apache.james.mailetcontainer.impl.camel.CamelProcessor.java:106, the 
> exception and the onMailetException value is passed to 
> ProcessorUtil.handleException, which then re-throw the exception. The 
> re-thrown exception is never catched and the mail object is discard at 
> org.apache.james.mailetcontainer.impl.JamesMailSpooler.java:183.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org

Re: Git Repos

[dongxu]

Hey Eric,

can you please help push a request to migrate james-hupa from SVN to
Git https://reporeq.apache.org/

Thanks.

On Mon, Dec 18, 2017 at 9:03 AM, dongxu  wrote:
> Hi guys,
>
> Can I apply to move james-hupa to git and then continue to maintain
> the project?
>
> On Sun, Jul 3, 2016 at 5:17 PM, Eric Charles  wrote:
 What about http://james.apache.org/contribute.html where we could also
 introduce the different repositories and explain the overall
 architecture of the James project and how we accept pull requests from
 github.

 Any thoughts?
>>>
>>>
>>> The website needs a lot of love. Thank you for taking your time to go
>>> through all these tasks that need to be done.
>>>
>>
>> This can be followed on JAMES-1789 (consolidate documentation) and
>> INFRA-12204 (Migrate James website from svnpubsub to the git workflow)
>>
>>
>> -
>> To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
>> For additional commands, e-mail: server-dev-h...@james.apache.org
>>

-
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org

[jira] [Commented] (JAMES-2263) onMailetException doesn't work even the default onMailetException="error"

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/JAMES-2263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16297730#comment-16297730
 ] 

ASF GitHub Bot commented on JAMES-2263:
---

Github user apptaro commented on the issue:

https://github.com/apache/james-project/pull/91
  
Do you know when this fix is included in the release?


> onMailetException doesn't work even the default onMailetException="error"
> -
>
> Key: JAMES-2263
> URL: https://issues.apache.org/jira/browse/JAMES-2263
> Project: James Server
>  Issue Type: Bug
>  Components: Matchers/Mailets (bundled), SpoolManager & Processors
>Affects Versions: 3.0.0-beta5
>Reporter: Taro App
>
> Tested with 3.0.1. When a mailet raises an exception, the message is not sent 
> to the processor specified with onMailetException. Only 
> onMailetException="ignore" works. Other values don't work, the even the 
> default onMailetException="error". Instead the message is somehow processed 7 
> times and then discarded.
> See org.apache.james.mailetcontainer.impl.camel.CamelProcessor.java:106, the 
> exception and the onMailetException value is passed to 
> ProcessorUtil.handleException, which then re-throw the exception. The 
> re-thrown exception is never catched and the mail object is discard at 
> org.apache.james.mailetcontainer.impl.JamesMailSpooler.java:183.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org