Re: new releases

2018-06-15 Thread Dirk Hohndel

> On Jun 16, 2018, at 2:01 PM, Jan Iversen  wrote:
>> 
>> So far I found one odd bug in Subsurface-mobile with downloading from the 
>> Suunto EON Steel. Even though I had new dives on the DC, Subsurface-mobile 
>> told me there were no new dives. I added debug output and tried again, and 
>> of course it worked correctly :-/
> This also happens on the mobile version (master and test flight), with Suunto 
> EON Core. I have seen it a couple of times. Connection with BLE is made 
> correctly, firmware version etc. written on screen and then no dives found. 
> If you try again without restarting ssrf it  works. I thought it was 
> something like a ble tineout. There are no indications in the normal logs.

Linus is looking into that one

>> The other issue I see on Mac is that some of the dialogs have partially cut 
>> off texts. I'm currently trying to figure out how to even debug this. 
>> There's no reason I can figure out why those should not automatically size 
>> correctly...
> I can confirm that. It hits the divedetails window among others. I have not 
> searched for it, but I saw about a month ago.

I think I have fixed this. Waiting for comments from Robert

>> What other bugs do we know of for either desktop or mobile?
> mobile: the ssrf logo in the coral picture, still shows as a black spot.

Right. I noticed that as well.

/D
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface


Re: new releases

2018-06-15 Thread Linus Torvalds
On Sat, Jun 16, 2018 at 2:01 PM Jan Iversen  wrote:
> >
> > So far I found one odd bug in Subsurface-mobile with downloading from the 
> > Suunto EON Steel. Even though I had new dives on the DC, Subsurface-mobile 
> > told me there were no new dives. I added debug output and tried again, and 
> > of course it worked correctly :-/
>
> This also happens on the mobile version (master and test flight), with Suunto 
> EON Core. I have seen it a couple of times. Connection with BLE is made 
> correctly, firmware version etc. written on screen and then no dives found. 
> If you try again without restarting ssrf it  works. I thought it was 
> something like a ble tineout. There are no indications in the normal logs.

I've been trying to debug this today, and it isn't really us doing
anything wrong per se, it's that BLE communication isn't reliable, and
we don't handle lost packets correctly.

So everything works as long as no packets are lost. Which is sadly not
nearly as common as it should be.

I'm trying to figure out how we should re-send the command when the
reply gets lost, but I don't have any traces for this, so I'm mainly
just guessing and doing some trial-and-error.

Wish me luck.

In the meantime, "just retry" is  the way to get it to work.
Eventually it will - at least as long as you're not trying to download
too much, and at least as long as the environment isn't too noisy for
BLE.

Linus
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface


Re: new releases

2018-06-15 Thread Jan Iversen


Enviado desde mi iPad

> El 16 jun 2018, a las 1:16, Dirk Hohndel  escribió:
> 
> We have lapsed on our goal to do regular releases.
> 
> Can we use the next two weeks to get both desktop and mobile into releasable 
> shape? Linus and I are doing "in the field testing" this week in Japan - and 
> true to our past track record, we have brought a freak storm to Okinawa...
> 
> So far I found one odd bug in Subsurface-mobile with downloading from the 
> Suunto EON Steel. Even though I had new dives on the DC, Subsurface-mobile 
> told me there were no new dives. I added debug output and tried again, and of 
> course it worked correctly :-/
This also happens on the mobile version (master and test flight), with Suunto 
EON Core. I have seen it a couple of times. Connection with BLE is made 
correctly, firmware version etc. written on screen and then no dives found. If 
you try again without restarting ssrf it  works. I thought it was something 
like a ble tineout. There are no indications in the normal logs.

> The other issue I see on Mac is that some of the dialogs have partially cut 
> off texts. I'm currently trying to figure out how to even debug this. There's 
> no reason I can figure out why those should not automatically size 
> correctly...
I can confirm that. It hits the divedetails window among others. I have not 
searched for it, but I saw about a month ago.

> 
> What other bugs do we know of for either desktop or mobile?
mobile: the ssrf logo in the coral picture, still shows as a black spot.

rgds
jan I
> 
> I just pushed the latest strings to transifex, hopefully two weeks of warning 
> should make it reasonably easy to get the translations dealt with...
> 
> Thanks everyone!
> 
> /D
> ___
> subsurface mailing list
> subsurface@subsurface-divelog.org
> http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface


Re: Suunto DM5 Imports broken

2018-06-15 Thread Miika Turkia
I just sent a pull req that should take care of this. However, I do not
possess test data with the new format. Could you Rainer send me a sample
file? (The addition for support for the new format is quite trivial, but
still I would like to test it out.)

miika

On Fri, Jun 15, 2018 at 12:32 AM, Miika Turkia 
wrote:

> I will try to take a look into this within a few days
>
> miika
>
> > On 8 Jun 2018, at 0.25, Dirk Hohndel  wrote:
> >
> > Miika is the wunderkind-slash-madman who maintains our importers and
> deals with the XSLT...
> >
> > /D
> >
> >> On Jun 7, 2018, at 1:58 AM, Rainer Mohr  wrote:
> >>
> >> Gentlemen,
> >>
> >> Just noticed, that the Suunto DM5 Import is very broken as it can't
> parse the profile data from recent and semi-recent DM5 files properly.
> >> Suunto has once again changed their data structures in the profile part
> of DM5. Noticed after quite a few broken profiles popped up on divelogs.de
> >> Now the 'SampleBlob' can contain not only blocks of 16, 23 and 26
> Bytes, but new: 30 Bytes (detectable by first Byte being '5')
> >>
> >> Here is my PHP code for handling the profile parts from the SQLite
> Data, hope someone can translate this into what you need, as I would be
> useless at doing so:
> >>
> >>  >> // $databaserow contains the data from one dive, queried from the
> database
> >> $data = $databaserow['SampleBlob'];
> >> $samples = Array();
> >>
> >> // Depending on first Byte: Samples are in blocks of 23 or 16 or 26 or
> 30 bytes
> >> if (ord($data[0])==3) { // 23 Bytes per sample
> >>$data = substr($data,1,strlen($data));
> >>for($i = 0; $i < strlen($data)/23; ++$i) {
> >>$s = unpack("f",$data[$i*23+2].$data[$i*23+3].$data[$i*23+4].$
> data[$i*23+5]);
> >>if ($s[1] < 200) $samples[] = round($s[1],1);
> >>}
> >> } elseif (ord($data[0])==4) { // 26 Bytes per sample
> >>$data = substr($data,1,strlen($data));
> >>for($i = 0; $i < strlen($data)/26; ++$i) {
> >>$s = unpack("f",$data[$i*26+2].$data[$i*26+3].$data[$i*26+4].$
> data[$i*26+5]);
> >>if ($s[1] < 200) $samples[] = round($s[1],1);
> >>}
> >> } elseif (ord($data[0])==5) { // 30 Bytes per sample
> >>$data = substr($data,1,strlen($data));
> >>for($i = 0; $i < strlen($data)/30; ++$i) {
> >>$s = unpack("f",$data[$i*30+2].$data[$i*30+3].$data[$i*30+4].$
> data[$i*30+5]);
> >>if ($s[1] < 200) $samples[] = round($s[1],1);
> >>}
> >> } else { // 16 Bytes per sample
> >>for($i = 0; $i < strlen($data)/16; ++$i) {
> >>$s = unpack("f",$data[$i*16+3].$data[$i*16+4].$data[$i*16+5].$
> data[$i*16+6]);
> >>if ($s[1] < 200) $samples[] = round($s[1],1);
> >>}
> >> }
> >>
> >> // in case Dives from imported DM4 are available
> >> if (count($samples)==0) {
> >>$data = $databaserow['ProfileBlob'];
> >>for($i = 0; $i < strlen($data)/4; ++$i) {
> >>$s = unpack("f",$data[$i*4].$data[$
> i*4+1].$data[$i*4+2].$data[$i*4+3]);
> >>if ($s[1] < 200) $samples[] = round($s[1],1);
> >>}
> >> }
> >> ?>
> >>
> >> Rainer
> >>
> >>
> >> ___
> >> subsurface mailing list
> >> subsurface@subsurface-divelog.org
> >> http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
> >
>
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface


new releases

2018-06-15 Thread Dirk Hohndel
We have lapsed on our goal to do regular releases.

Can we use the next two weeks to get both desktop and mobile into releasable 
shape? Linus and I are doing "in the field testing" this week in Japan - and 
true to our past track record, we have brought a freak storm to Okinawa...

So far I found one odd bug in Subsurface-mobile with downloading from the 
Suunto EON Steel. Even though I had new dives on the DC, Subsurface-mobile told 
me there were no new dives. I added debug output and tried again, and of course 
it worked correctly :-/
The other issue I see on Mac is that some of the dialogs have partially cut off 
texts. I'm currently trying to figure out how to even debug this. There's no 
reason I can figure out why those should not automatically size correctly...

What other bugs do we know of for either desktop or mobile?

I just pushed the latest strings to transifex, hopefully two weeks of warning 
should make it reasonably easy to get the translations dealt with...

Thanks everyone!

/D
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface