[Touch-packages] [Bug 1747499] Re: 98-reboot-required and Interaction with livepatch
** Tags added: reboot-required -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to unattended-upgrades in Ubuntu. https://bugs.launchpad.net/bugs/1747499 Title: 98-reboot-required and Interaction with livepatch Status in unattended-upgrades package in Ubuntu: Fix Released Status in update-notifier package in Ubuntu: Fix Released Status in unattended-upgrades source package in Focal: Fix Released Status in update-notifier source package in Focal: Fix Released Bug description: [Impact] * If a system is using canonical livepatch, has it enabled, and patches are applied, it could be confusing for a user to receive a "system restart required" messages in the MOTD when logging in. * Livepatch is available on LTS releases. Thus, the users can be confused following a kernel update on 20.04. * The upload prevents update-notifier and unattended-ugprades hooks from adding "system restart"-related messages to motd when Livepatch is enabled. Livepatch, when enabled, already contributes to the motd message so there is no need to have duplicate (and sometimes contradictory) information. [Test Plan] * how to reproduce the bug: 1. Install and boot a 20.04 server VM 2. Make sure it runs a generic kernel (or another flavour that supports Livepatch) 3. Enable Livepatch using the following command: $ ua attach # replace by an actual contract token 4. Upgrade the kernel (if you are already running the latest available kernel update, you can install a different flavour) 5. Upon logging in again, the motd will show ***System restart required***. * other testing appropriate to perform before landing this update: * Making sure that the patch has no impact when livepatch is not enabled. * The motd should show ***System restart required*** after upgrading the kernel if livepatch is not enabled. [Where problems could occur] * The change updates a hook script in /etc/kernel/postinst.d/. Scripts in this directory are executing when upgrading / installing a kernel. If somehow the script is broken, it can prevent dpkg for succeeding when upgrading / installing the kernel. * If the implementation is wrong, we might end up "losing" the ***System restart required*** message when livepatch is disabled [Original bug description] If a system is using canonical livepatch, has it enabled, and patches are applied, it could be confusing for a user to receive a "system restart required" messages in the MOTD when logging in. That message, when present, is printed by 98-reboot-required which essentially just cats /var/run/reboot-required to stdout. That file is placed by packages that require a reboot so that they are properly used in their updated versions. Examples that come to mind are libc and the kernel. There is a secondary file that can be created which says which packages requested the reboot. That would be /var/run/reboot- required.pkgs Ideally that script should not print out the reboot required message if a) livepatch is installed and enabled; b) the only trigger for the reboot is a kernel update. For (a), one can use the command "ubuntu-advantage is-livepatch- enabled" and check $?. That is in the ubuntu-advantage-tools package. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/unattended-upgrades/+bug/1747499/+subscriptions -- Mailing list: https://launchpad.net/~touch-packages Post to : touch-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~touch-packages More help : https://help.launchpad.net/ListHelp
[Touch-packages] [Bug 1747499] Re: 98-reboot-required and Interaction with livepatch
The package FTBFS against -proposed but builds successfully against the -release pocket. Based on the error, it seems related to recent changes in how apt determines kernels that can be autoremoved. apt (2.0.7) focal; urgency=medium * Revert "Protect currently running kernel at run-time" * Backport Determine autoremovable kernels at run-time (LP: #1615381) as of 2.4.5; including the change to only protect two kernels, not last installed one (LP: #1968154) -- Julian Andres Klode Mon, 25 Apr 2022 15:58:46 +0200 -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to unattended-upgrades in Ubuntu. https://bugs.launchpad.net/bugs/1747499 Title: 98-reboot-required and Interaction with livepatch Status in unattended-upgrades package in Ubuntu: Fix Released Status in update-notifier package in Ubuntu: Fix Released Status in unattended-upgrades source package in Focal: Fix Committed Status in update-notifier source package in Focal: Fix Committed Bug description: [Impact] * If a system is using canonical livepatch, has it enabled, and patches are applied, it could be confusing for a user to receive a "system restart required" messages in the MOTD when logging in. * Livepatch is available on LTS releases. Thus, the users can be confused following a kernel update on 20.04. * The upload prevents update-notifier and unattended-ugprades hooks from adding "system restart"-related messages to motd when Livepatch is enabled. Livepatch, when enabled, already contributes to the motd message so there is no need to have duplicate (and sometimes contradictory) information. [Test Plan] * how to reproduce the bug: 1. Install and boot a 20.04 server VM 2. Make sure it runs a generic kernel (or another flavour that supports Livepatch) 3. Enable Livepatch using the following command: $ ua attach # replace by an actual contract token 4. Upgrade the kernel (if you are already running the latest available kernel update, you can install a different flavour) 5. Upon logging in again, the motd will show ***System restart required***. * other testing appropriate to perform before landing this update: * Making sure that the patch has no impact when livepatch is not enabled. * The motd should show ***System restart required*** after upgrading the kernel if livepatch is not enabled. [Where problems could occur] * The change updates a hook script in /etc/kernel/postinst.d/. Scripts in this directory are executing when upgrading / installing a kernel. If somehow the script is broken, it can prevent dpkg for succeeding when upgrading / installing the kernel. * If the implementation is wrong, we might end up "losing" the ***System restart required*** message when livepatch is disabled [Original bug description] If a system is using canonical livepatch, has it enabled, and patches are applied, it could be confusing for a user to receive a "system restart required" messages in the MOTD when logging in. That message, when present, is printed by 98-reboot-required which essentially just cats /var/run/reboot-required to stdout. That file is placed by packages that require a reboot so that they are properly used in their updated versions. Examples that come to mind are libc and the kernel. There is a secondary file that can be created which says which packages requested the reboot. That would be /var/run/reboot- required.pkgs Ideally that script should not print out the reboot required message if a) livepatch is installed and enabled; b) the only trigger for the reboot is a kernel update. For (a), one can use the command "ubuntu-advantage is-livepatch- enabled" and check $?. That is in the ubuntu-advantage-tools package. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/unattended-upgrades/+bug/1747499/+subscriptions -- Mailing list: https://launchpad.net/~touch-packages Post to : touch-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~touch-packages More help : https://help.launchpad.net/ListHelp
[Touch-packages] [Bug 1747499] Re: 98-reboot-required and Interaction with livepatch
Trying to validate this upload but unattended-upgrades failed to build
with:
Applying pinning: PkgFilePin(id=0, priority=-32768)
Applying pin -32768 to package_file: >/test/root.unused-deps/var/lib/apt/lists/archive.ubuntu.com_ubuntu_dists_lucid-updates_main_binary-amd64_Packages'
a=lucid-updates,c=main,v=10.04,o=Ubuntu,l=Ubuntu arch='amd64'
site='archive.ubuntu.com' IndexType='Debian Package Index' Size=106 ID:0>
Using
(^linux-image-[1-9][0-9]*\.[0-9]+\.[0-9]+-[0-9]+(-.+)?$|^.*-modules-[1-9][0-9]*\.[0-9]+\.[0-9]+-[0-9]+(-.+)?$|^linux-headers-[1-9][0-9]*\.[0-9]+\.[0-9]+-[0-9]+(-.+)?$)
regexp to find kernel packages
Using
(^linux-image-5\.4\.0\-109\-generic$|^linux-image-5\.4\.0\-109$|^.*-modules-5\.4\.0\-109\-generic$|^.*-modules-5\.4\.0\-109$|^linux-headers-5\.4\.0\-109\-generic$|^linux-headers-5\.4\.0\-109$)
regexp to find running kernel packages
{'old-unused-dependency', 'any-old-unused-modules'}
Keeping auto-removable test-package-dependency package(s) because it would also
remove the following packages which should be kept in this step:
old-unused-dependency
The following packages are marked for installation or upgrade which is not
allowed when performing autoremovals: forbidden-dependency
.
==
FAIL: test_remove_unused_dependencies_new_unused_only
(__main__.TestRemoveUnused)
--
Traceback (most recent call last):
File "./test_remove_unused.py", line 164, in
test_remove_unused_dependencies_new_unused_only
self.assertTrue(needle_kernel_good in haystack,
AssertionError: False is not true : Can not find 'Removing unused kernel
packages: linux-image-4.05.0-1021-kvm
' in '2022-05-10 20:56:21,336 INFO Starting unattended upgrades script
--
You received this bug notification because you are a member of Ubuntu
Touch seeded packages, which is subscribed to unattended-upgrades in
Ubuntu.
https://bugs.launchpad.net/bugs/1747499
Title:
98-reboot-required and Interaction with livepatch
Status in unattended-upgrades package in Ubuntu:
Fix Released
Status in update-notifier package in Ubuntu:
Fix Released
Status in unattended-upgrades source package in Focal:
Fix Committed
Status in update-notifier source package in Focal:
Fix Committed
Bug description:
[Impact]
* If a system is using canonical livepatch, has it enabled, and
patches are applied, it could be confusing for a user to receive a
"system restart required" messages in the MOTD when logging in.
* Livepatch is available on LTS releases. Thus, the users can be
confused following a kernel update on 20.04.
* The upload prevents update-notifier and unattended-ugprades hooks from
adding "system restart"-related messages to motd when Livepatch is enabled.
Livepatch, when enabled, already contributes to the motd message so there is
no need to have duplicate (and sometimes contradictory) information.
[Test Plan]
* how to reproduce the bug:
1. Install and boot a 20.04 server VM
2. Make sure it runs a generic kernel (or another flavour that supports
Livepatch)
3. Enable Livepatch using the following command:
$ ua attach # replace by an actual contract token
4. Upgrade the kernel (if you are already running the latest available
kernel update, you can install a different flavour)
5. Upon logging in again, the motd will show ***System restart required***.
* other testing appropriate to perform before landing this update:
* Making sure that the patch has no impact when livepatch is not enabled.
* The motd should show ***System restart required*** after upgrading the
kernel if livepatch is not enabled.
[Where problems could occur]
* The change updates a hook script in /etc/kernel/postinst.d/.
Scripts in this directory are executing when upgrading / installing a
kernel. If somehow the script is broken, it can prevent dpkg for
succeeding when upgrading / installing the kernel.
* If the implementation is wrong, we might end up "losing" the
***System restart required*** message when livepatch is disabled
[Original bug description]
If a system is using canonical livepatch, has it enabled, and patches
are applied, it could be confusing for a user to receive a "system
restart required" messages in the MOTD when logging in.
That message, when present, is printed by 98-reboot-required which
essentially just cats /var/run/reboot-required to stdout. That file is
placed by packages that require a reboot so that they are properly
used in their updated versions. Examples that come to mind are libc
and the kernel.
There is a secondary file that can be created which says which
packages requested the reboot. That would be /var/run/reboot-
required.pkgs
Ideally that script should not print out the reboot required message
if a) livepatch is installed and enabled; b) the only trigger
[Touch-packages] [Bug 1747499] Re: 98-reboot-required and Interaction with livepatch
Hello Andreas, or anyone else affected, Accepted update-notifier into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/update- notifier/3.192.30.11 in a few hours, and then in the -proposed repository. Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users. If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed- focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification- failed-focal. In either case, without details of your testing we will not be able to proceed. Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping! N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days. ** Changed in: update-notifier (Ubuntu Focal) Status: In Progress => Fix Committed ** Tags added: verification-needed verification-needed-focal ** Changed in: unattended-upgrades (Ubuntu Focal) Status: In Progress => Fix Committed -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to unattended-upgrades in Ubuntu. https://bugs.launchpad.net/bugs/1747499 Title: 98-reboot-required and Interaction with livepatch Status in unattended-upgrades package in Ubuntu: Fix Released Status in update-notifier package in Ubuntu: Fix Released Status in unattended-upgrades source package in Focal: Fix Committed Status in update-notifier source package in Focal: Fix Committed Bug description: [Impact] * If a system is using canonical livepatch, has it enabled, and patches are applied, it could be confusing for a user to receive a "system restart required" messages in the MOTD when logging in. * Livepatch is available on LTS releases. Thus, the users can be confused following a kernel update on 20.04. * The upload prevents update-notifier and unattended-ugprades hooks from adding "system restart"-related messages to motd when Livepatch is enabled. Livepatch, when enabled, already contributes to the motd message so there is no need to have duplicate (and sometimes contradictory) information. [Test Plan] * how to reproduce the bug: 1. Install and boot a 20.04 server VM 2. Make sure it runs a generic kernel (or another flavour that supports Livepatch) 3. Enable Livepatch using the following command: $ ua attach # replace by an actual contract token 4. Upgrade the kernel (if you are already running the latest available kernel update, you can install a different flavour) 5. Upon logging in again, the motd will show ***System restart required***. * other testing appropriate to perform before landing this update: * Making sure that the patch has no impact when livepatch is not enabled. * The motd should show ***System restart required*** after upgrading the kernel if livepatch is not enabled. [Where problems could occur] * The change updates a hook script in /etc/kernel/postinst.d/. Scripts in this directory are executing when upgrading / installing a kernel. If somehow the script is broken, it can prevent dpkg for succeeding when upgrading / installing the kernel. * If the implementation is wrong, we might end up "losing" the ***System restart required*** message when livepatch is disabled [Original bug description] If a system is using canonical livepatch, has it enabled, and patches are applied, it could be confusing for a user to receive a "system restart required" messages in the MOTD when logging in. That message, when present, is printed by 98-reboot-required which essentially just cats /var/run/reboot-required to stdout. That file is placed by packages that require a reboot so that they are properly used in their updated versions. Examples that come to mind are libc and the kernel. There is a secondary file that can be created which says which packages requested the reboot. That would be /var/run/reboot- required.pkgs Ideally that script should not print out the reboot required message if a) livepatch is installed and enabled; b) the only trigger for the reboot is a kernel update. For (a), one can use the command "ubuntu-advantage is-livepatch- enabled" and check $?. That is in the ubuntu-advantage-tools package. To manage notifications about this bug go to:
[Touch-packages] [Bug 1747499] Re: 98-reboot-required and Interaction with livepatch
Moving the packages to Fix Released since the patches were already in Jammy: update-notifier - fixed in 3.192.47: http://changelogs.ubuntu.com/changelogs/pool/main/u/update- notifier/update-notifier_3.192.54/changelog unattended-upgrades - fixed in 2.8ubuntu1: http://changelogs.ubuntu.com/changelogs/pool/main/u/unattended- upgrades/unattended-upgrades_2.8ubuntu1/changelog ** Changed in: unattended-upgrades (Ubuntu) Status: Confirmed => Fix Released ** Changed in: update-notifier (Ubuntu) Status: Confirmed => Fix Released -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to unattended-upgrades in Ubuntu. https://bugs.launchpad.net/bugs/1747499 Title: 98-reboot-required and Interaction with livepatch Status in unattended-upgrades package in Ubuntu: Fix Released Status in update-notifier package in Ubuntu: Fix Released Status in unattended-upgrades source package in Focal: In Progress Status in update-notifier source package in Focal: In Progress Bug description: [Impact] * If a system is using canonical livepatch, has it enabled, and patches are applied, it could be confusing for a user to receive a "system restart required" messages in the MOTD when logging in. * Livepatch is available on LTS releases. Thus, the users can be confused following a kernel update on 20.04. * The upload prevents update-notifier and unattended-ugprades hooks from adding "system restart"-related messages to motd when Livepatch is enabled. Livepatch, when enabled, already contributes to the motd message so there is no need to have duplicate (and sometimes contradictory) information. [Test Plan] * how to reproduce the bug: 1. Install and boot a 20.04 server VM 2. Make sure it runs a generic kernel (or another flavour that supports Livepatch) 3. Enable Livepatch using the following command: $ ua attach # replace by an actual contract token 4. Upgrade the kernel (if you are already running the latest available kernel update, you can install a different flavour) 5. Upon logging in again, the motd will show ***System restart required***. * other testing appropriate to perform before landing this update: * Making sure that the patch has no impact when livepatch is not enabled. * The motd should show ***System restart required*** after upgrading the kernel if livepatch is not enabled. [Where problems could occur] * The change updates a hook script in /etc/kernel/postinst.d/. Scripts in this directory are executing when upgrading / installing a kernel. If somehow the script is broken, it can prevent dpkg for succeeding when upgrading / installing the kernel. * If the implementation is wrong, we might end up "losing" the ***System restart required*** message when livepatch is disabled [Original bug description] If a system is using canonical livepatch, has it enabled, and patches are applied, it could be confusing for a user to receive a "system restart required" messages in the MOTD when logging in. That message, when present, is printed by 98-reboot-required which essentially just cats /var/run/reboot-required to stdout. That file is placed by packages that require a reboot so that they are properly used in their updated versions. Examples that come to mind are libc and the kernel. There is a secondary file that can be created which says which packages requested the reboot. That would be /var/run/reboot- required.pkgs Ideally that script should not print out the reboot required message if a) livepatch is installed and enabled; b) the only trigger for the reboot is a kernel update. For (a), one can use the command "ubuntu-advantage is-livepatch- enabled" and check $?. That is in the ubuntu-advantage-tools package. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/unattended-upgrades/+bug/1747499/+subscriptions -- Mailing list: https://launchpad.net/~touch-packages Post to : touch-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~touch-packages More help : https://help.launchpad.net/ListHelp
[Touch-packages] [Bug 1747499] Re: 98-reboot-required and Interaction with livepatch
Thank you for the patches Olivier! LGTM, I've sponsored it for both affected packages. The only thing I needed to change is the version string for unattended- upgrades 2.3ubuntu1 -> 2.3ubuntu0.2 (as this is an SRU, https://wiki.ubuntu.com/SecurityTeam/UpdatePreparation#Update_the_packaging) ** Changed in: update-notifier (Ubuntu Focal) Status: New => In Progress ** Changed in: unattended-upgrades (Ubuntu Focal) Status: New => In Progress -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to unattended-upgrades in Ubuntu. https://bugs.launchpad.net/bugs/1747499 Title: 98-reboot-required and Interaction with livepatch Status in unattended-upgrades package in Ubuntu: Confirmed Status in update-notifier package in Ubuntu: Confirmed Status in unattended-upgrades source package in Focal: In Progress Status in update-notifier source package in Focal: In Progress Bug description: [Impact] * If a system is using canonical livepatch, has it enabled, and patches are applied, it could be confusing for a user to receive a "system restart required" messages in the MOTD when logging in. * Livepatch is available on LTS releases. Thus, the users can be confused following a kernel update on 20.04. * The upload prevents update-notifier and unattended-ugprades hooks from adding "system restart"-related messages to motd when Livepatch is enabled. Livepatch, when enabled, already contributes to the motd message so there is no need to have duplicate (and sometimes contradictory) information. [Test Plan] * how to reproduce the bug: 1. Install and boot a 20.04 server VM 2. Make sure it runs a generic kernel (or another flavour that supports Livepatch) 3. Enable Livepatch using the following command: $ ua attach # replace by an actual contract token 4. Upgrade the kernel (if you are already running the latest available kernel update, you can install a different flavour) 5. Upon logging in again, the motd will show ***System restart required***. * other testing appropriate to perform before landing this update: * Making sure that the patch has no impact when livepatch is not enabled. * The motd should show ***System restart required*** after upgrading the kernel if livepatch is not enabled. [Where problems could occur] * The change updates a hook script in /etc/kernel/postinst.d/. Scripts in this directory are executing when upgrading / installing a kernel. If somehow the script is broken, it can prevent dpkg for succeeding when upgrading / installing the kernel. * If the implementation is wrong, we might end up "losing" the ***System restart required*** message when livepatch is disabled [Original bug description] If a system is using canonical livepatch, has it enabled, and patches are applied, it could be confusing for a user to receive a "system restart required" messages in the MOTD when logging in. That message, when present, is printed by 98-reboot-required which essentially just cats /var/run/reboot-required to stdout. That file is placed by packages that require a reboot so that they are properly used in their updated versions. Examples that come to mind are libc and the kernel. There is a secondary file that can be created which says which packages requested the reboot. That would be /var/run/reboot- required.pkgs Ideally that script should not print out the reboot required message if a) livepatch is installed and enabled; b) the only trigger for the reboot is a kernel update. For (a), one can use the command "ubuntu-advantage is-livepatch- enabled" and check $?. That is in the ubuntu-advantage-tools package. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/unattended-upgrades/+bug/1747499/+subscriptions -- Mailing list: https://launchpad.net/~touch-packages Post to : touch-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~touch-packages More help : https://help.launchpad.net/ListHelp
[Touch-packages] [Bug 1747499] Re: 98-reboot-required and Interaction with livepatch
** Tags added: fr-1788 -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to unattended-upgrades in Ubuntu. https://bugs.launchpad.net/bugs/1747499 Title: 98-reboot-required and Interaction with livepatch Status in unattended-upgrades package in Ubuntu: Confirmed Status in update-notifier package in Ubuntu: Confirmed Status in unattended-upgrades source package in Focal: New Status in update-notifier source package in Focal: New Bug description: [Impact] * If a system is using canonical livepatch, has it enabled, and patches are applied, it could be confusing for a user to receive a "system restart required" messages in the MOTD when logging in. * Livepatch is available on LTS releases. Thus, the users can be confused following a kernel update on 20.04. * The upload prevents update-notifier and unattended-ugprades hooks from adding "system restart"-related messages to motd when Livepatch is enabled. Livepatch, when enabled, already contributes to the motd message so there is no need to have duplicate (and sometimes contradictory) information. [Test Plan] * how to reproduce the bug: 1. Install and boot a 20.04 server VM 2. Make sure it runs a generic kernel (or another flavour that supports Livepatch) 3. Enable Livepatch using the following command: $ ua attach # replace by an actual contract token 4. Upgrade the kernel (if you are already running the latest available kernel update, you can install a different flavour) 5. Upon logging in again, the motd will show ***System restart required***. * other testing appropriate to perform before landing this update: * Making sure that the patch has no impact when livepatch is not enabled. * The motd should show ***System restart required*** after upgrading the kernel if livepatch is not enabled. [Where problems could occur] * The change updates a hook script in /etc/kernel/postinst.d/. Scripts in this directory are executing when upgrading / installing a kernel. If somehow the script is broken, it can prevent dpkg for succeeding when upgrading / installing the kernel. * If the implementation is wrong, we might end up "losing" the ***System restart required*** message when livepatch is disabled [Original bug description] If a system is using canonical livepatch, has it enabled, and patches are applied, it could be confusing for a user to receive a "system restart required" messages in the MOTD when logging in. That message, when present, is printed by 98-reboot-required which essentially just cats /var/run/reboot-required to stdout. That file is placed by packages that require a reboot so that they are properly used in their updated versions. Examples that come to mind are libc and the kernel. There is a secondary file that can be created which says which packages requested the reboot. That would be /var/run/reboot- required.pkgs Ideally that script should not print out the reboot required message if a) livepatch is installed and enabled; b) the only trigger for the reboot is a kernel update. For (a), one can use the command "ubuntu-advantage is-livepatch- enabled" and check $?. That is in the ubuntu-advantage-tools package. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/unattended-upgrades/+bug/1747499/+subscriptions -- Mailing list: https://launchpad.net/~touch-packages Post to : touch-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~touch-packages More help : https://help.launchpad.net/ListHelp
[Touch-packages] [Bug 1747499] Re: 98-reboot-required and Interaction with livepatch
** Also affects: update-notifier (Ubuntu Focal) Importance: Undecided Status: New ** Also affects: unattended-upgrades (Ubuntu Focal) Importance: Undecided Status: New -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to unattended-upgrades in Ubuntu. https://bugs.launchpad.net/bugs/1747499 Title: 98-reboot-required and Interaction with livepatch Status in unattended-upgrades package in Ubuntu: Confirmed Status in update-notifier package in Ubuntu: Confirmed Status in unattended-upgrades source package in Focal: New Status in update-notifier source package in Focal: New Bug description: [Impact] * If a system is using canonical livepatch, has it enabled, and patches are applied, it could be confusing for a user to receive a "system restart required" messages in the MOTD when logging in. * Livepatch is available on LTS releases. Thus, the users can be confused following a kernel update on 20.04. * The upload prevents update-notifier and unattended-ugprades hooks from adding "system restart"-related messages to motd when Livepatch is enabled. Livepatch, when enabled, already contributes to the motd message so there is no need to have duplicate (and sometimes contradictory) information. [Test Plan] * how to reproduce the bug: 1. Install and boot a 20.04 server VM 2. Make sure it runs a generic kernel (or another flavour that supports Livepatch) 3. Enable Livepatch using the following command: $ ua attach # replace by an actual contract token 4. Upgrade the kernel (if you are already running the latest available kernel update, you can install a different flavour) 5. Upon logging in again, the motd will show ***System restart required***. * other testing appropriate to perform before landing this update: * Making sure that the patch has no impact when livepatch is not enabled. * The motd should show ***System restart required*** after upgrading the kernel if livepatch is not enabled. [Where problems could occur] * The change updates a hook script in /etc/kernel/postinst.d/. Scripts in this directory are executing when upgrading / installing a kernel. If somehow the script is broken, it can prevent dpkg for succeeding when upgrading / installing the kernel. * If the implementation is wrong, we might end up "losing" the ***System restart required*** message when livepatch is disabled [Original bug description] If a system is using canonical livepatch, has it enabled, and patches are applied, it could be confusing for a user to receive a "system restart required" messages in the MOTD when logging in. That message, when present, is printed by 98-reboot-required which essentially just cats /var/run/reboot-required to stdout. That file is placed by packages that require a reboot so that they are properly used in their updated versions. Examples that come to mind are libc and the kernel. There is a secondary file that can be created which says which packages requested the reboot. That would be /var/run/reboot- required.pkgs Ideally that script should not print out the reboot required message if a) livepatch is installed and enabled; b) the only trigger for the reboot is a kernel update. For (a), one can use the command "ubuntu-advantage is-livepatch- enabled" and check $?. That is in the ubuntu-advantage-tools package. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/unattended-upgrades/+bug/1747499/+subscriptions -- Mailing list: https://launchpad.net/~touch-packages Post to : touch-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~touch-packages More help : https://help.launchpad.net/ListHelp
[Touch-packages] [Bug 1747499] Re: 98-reboot-required and Interaction with livepatch
** Description changed: + + [Impact] + + * If a system is using canonical livepatch, has it enabled, and patches + are applied, it could be confusing for a user to receive a "system + restart required" messages in the MOTD when logging in. + + * Livepatch is available on LTS releases. Thus, the users can be + confused following a kernel update on 20.04. + + * The upload prevents update-notifier and unattended-ugprades hooks from adding "system restart"-related messages to motd when Livepatch is enabled. + Livepatch, when enabled, already contributes to the motd message so there is no need to have duplicate (and sometimes contradictory) information. + + [Test Plan] + + * how to reproduce the bug: + +1. Install and boot a 20.04 server VM +2. Make sure it runs a generic kernel (or another flavour that supports Livepatch) +3. Enable Livepatch using the following command: +$ ua attach # replace by an actual contract token +4. Upgrade the kernel (if you are already running the latest available kernel update, you can install a different flavour) +5. Upon logging in again, the motd will show ***System restart required***. + + * other testing appropriate to perform before landing this update: + + * Making sure that the patch has no impact when livepatch is not enabled. + * The motd should show ***System restart required*** after upgrading the kernel if livepatch is not enabled. + + [Where problems could occur] + + * The change updates a hook script in /etc/kernel/postinst.d/. Scripts + in this directory are executing when upgrading / installing a kernel. If + somehow the script is broken, it can prevent dpkg for succeeding when + upgrading / installing the kernel. + + * If the implementation is wrong, we might end up "losing" the + ***System restart required*** message when livepatch is disabled + + [Original bug description] + If a system is using canonical livepatch, has it enabled, and patches are applied, it could be confusing for a user to receive a "system restart required" messages in the MOTD when logging in. That message, when present, is printed by 98-reboot-required which essentially just cats /var/run/reboot-required to stdout. That file is placed by packages that require a reboot so that they are properly used in their updated versions. Examples that come to mind are libc and the kernel. There is a secondary file that can be created which says which packages requested the reboot. That would be /var/run/reboot-required.pkgs Ideally that script should not print out the reboot required message if a) livepatch is installed and enabled; b) the only trigger for the reboot is a kernel update. For (a), one can use the command "ubuntu-advantage is-livepatch-enabled" and check $?. That is in the ubuntu-advantage-tools package. -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to unattended-upgrades in Ubuntu. https://bugs.launchpad.net/bugs/1747499 Title: 98-reboot-required and Interaction with livepatch Status in unattended-upgrades package in Ubuntu: Confirmed Status in update-notifier package in Ubuntu: Confirmed Bug description: [Impact] * If a system is using canonical livepatch, has it enabled, and patches are applied, it could be confusing for a user to receive a "system restart required" messages in the MOTD when logging in. * Livepatch is available on LTS releases. Thus, the users can be confused following a kernel update on 20.04. * The upload prevents update-notifier and unattended-ugprades hooks from adding "system restart"-related messages to motd when Livepatch is enabled. Livepatch, when enabled, already contributes to the motd message so there is no need to have duplicate (and sometimes contradictory) information. [Test Plan] * how to reproduce the bug: 1. Install and boot a 20.04 server VM 2. Make sure it runs a generic kernel (or another flavour that supports Livepatch) 3. Enable Livepatch using the following command: $ ua attach # replace by an actual contract token 4. Upgrade the kernel (if you are already running the latest available kernel update, you can install a different flavour) 5. Upon logging in again, the motd will show ***System restart required***. * other testing appropriate to perform before landing this update: * Making sure that the patch has no impact when livepatch is not enabled. * The motd should show ***System restart required*** after upgrading the kernel if livepatch is not enabled. [Where problems could occur] * The change updates a hook script in /etc/kernel/postinst.d/. Scripts in this directory are executing when upgrading / installing a kernel. If somehow the script is broken, it can prevent dpkg for succeeding when upgrading / installing the kernel. * If the implementation is
[Touch-packages] [Bug 1747499] Re: 98-reboot-required and Interaction with livepatch
The attachment "debdiff for unattended-upgrades (focal)" seems to be a debdiff. The ubuntu-sponsors team has been subscribed to the bug report so that they can review and hopefully sponsor the debdiff. If the attachment isn't a patch, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are member of the ~ubuntu-sponsors, unsubscribe the team. [This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issue please contact him.] ** Tags added: patch -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to unattended-upgrades in Ubuntu. https://bugs.launchpad.net/bugs/1747499 Title: 98-reboot-required and Interaction with livepatch Status in unattended-upgrades package in Ubuntu: Confirmed Status in update-notifier package in Ubuntu: Confirmed Bug description: If a system is using canonical livepatch, has it enabled, and patches are applied, it could be confusing for a user to receive a "system restart required" messages in the MOTD when logging in. That message, when present, is printed by 98-reboot-required which essentially just cats /var/run/reboot-required to stdout. That file is placed by packages that require a reboot so that they are properly used in their updated versions. Examples that come to mind are libc and the kernel. There is a secondary file that can be created which says which packages requested the reboot. That would be /var/run/reboot- required.pkgs Ideally that script should not print out the reboot required message if a) livepatch is installed and enabled; b) the only trigger for the reboot is a kernel update. For (a), one can use the command "ubuntu-advantage is-livepatch- enabled" and check $?. That is in the ubuntu-advantage-tools package. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/unattended-upgrades/+bug/1747499/+subscriptions -- Mailing list: https://launchpad.net/~touch-packages Post to : touch-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~touch-packages More help : https://help.launchpad.net/ListHelp
[Touch-packages] [Bug 1747499] Re: 98-reboot-required and Interaction with livepatch
** Patch added: "debdiff for update-notifier (focal)" https://bugs.launchpad.net/ubuntu/+source/update-notifier/+bug/1747499/+attachment/5583992/+files/1-update-notifier-3.192.30.10.3.192.30.11.debdiff ** Changed in: unattended-upgrades (Ubuntu) Status: New => Confirmed -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to unattended-upgrades in Ubuntu. https://bugs.launchpad.net/bugs/1747499 Title: 98-reboot-required and Interaction with livepatch Status in unattended-upgrades package in Ubuntu: Confirmed Status in update-notifier package in Ubuntu: Confirmed Bug description: If a system is using canonical livepatch, has it enabled, and patches are applied, it could be confusing for a user to receive a "system restart required" messages in the MOTD when logging in. That message, when present, is printed by 98-reboot-required which essentially just cats /var/run/reboot-required to stdout. That file is placed by packages that require a reboot so that they are properly used in their updated versions. Examples that come to mind are libc and the kernel. There is a secondary file that can be created which says which packages requested the reboot. That would be /var/run/reboot- required.pkgs Ideally that script should not print out the reboot required message if a) livepatch is installed and enabled; b) the only trigger for the reboot is a kernel update. For (a), one can use the command "ubuntu-advantage is-livepatch- enabled" and check $?. That is in the ubuntu-advantage-tools package. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/unattended-upgrades/+bug/1747499/+subscriptions -- Mailing list: https://launchpad.net/~touch-packages Post to : touch-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~touch-packages More help : https://help.launchpad.net/ListHelp
[Touch-packages] [Bug 1747499] Re: 98-reboot-required and Interaction with livepatch
** Patch added: "debdiff for unattended-upgrades (focal)" https://bugs.launchpad.net/ubuntu/+source/update-notifier/+bug/1747499/+attachment/5583991/+files/1-unattended-upgrades-2.3ubuntu0.1-2.3ubuntu1.debdiff -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to unattended-upgrades in Ubuntu. https://bugs.launchpad.net/bugs/1747499 Title: 98-reboot-required and Interaction with livepatch Status in unattended-upgrades package in Ubuntu: Confirmed Status in update-notifier package in Ubuntu: Confirmed Bug description: If a system is using canonical livepatch, has it enabled, and patches are applied, it could be confusing for a user to receive a "system restart required" messages in the MOTD when logging in. That message, when present, is printed by 98-reboot-required which essentially just cats /var/run/reboot-required to stdout. That file is placed by packages that require a reboot so that they are properly used in their updated versions. Examples that come to mind are libc and the kernel. There is a secondary file that can be created which says which packages requested the reboot. That would be /var/run/reboot- required.pkgs Ideally that script should not print out the reboot required message if a) livepatch is installed and enabled; b) the only trigger for the reboot is a kernel update. For (a), one can use the command "ubuntu-advantage is-livepatch- enabled" and check $?. That is in the ubuntu-advantage-tools package. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/unattended-upgrades/+bug/1747499/+subscriptions -- Mailing list: https://launchpad.net/~touch-packages Post to : touch-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~touch-packages More help : https://help.launchpad.net/ListHelp
[Touch-packages] [Bug 1747499] Re: 98-reboot-required and Interaction with livepatch
** Also affects: unattended-upgrades (Ubuntu) Importance: Undecided Status: New -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to unattended-upgrades in Ubuntu. https://bugs.launchpad.net/bugs/1747499 Title: 98-reboot-required and Interaction with livepatch Status in unattended-upgrades package in Ubuntu: New Status in update-notifier package in Ubuntu: Confirmed Bug description: If a system is using canonical livepatch, has it enabled, and patches are applied, it could be confusing for a user to receive a "system restart required" messages in the MOTD when logging in. That message, when present, is printed by 98-reboot-required which essentially just cats /var/run/reboot-required to stdout. That file is placed by packages that require a reboot so that they are properly used in their updated versions. Examples that come to mind are libc and the kernel. There is a secondary file that can be created which says which packages requested the reboot. That would be /var/run/reboot- required.pkgs Ideally that script should not print out the reboot required message if a) livepatch is installed and enabled; b) the only trigger for the reboot is a kernel update. For (a), one can use the command "ubuntu-advantage is-livepatch- enabled" and check $?. That is in the ubuntu-advantage-tools package. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/unattended-upgrades/+bug/1747499/+subscriptions -- Mailing list: https://launchpad.net/~touch-packages Post to : touch-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~touch-packages More help : https://help.launchpad.net/ListHelp
