[Bug 251795] Re: /etc/environment PATH should not have quotes
** Changed in: krb5 (Ubuntu) Status: New = Confirmed -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to krb5 in Ubuntu. https://bugs.launchpad.net/bugs/251795 Title: /etc/environment PATH should not have quotes To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/krb5/+bug/251795/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 251795] Re: /etc/environment PATH should not have quotes
** Also affects: krb5-appl (Ubuntu) Importance: Undecided Status: New ** Changed in: krb5-appl (Ubuntu) Status: New = Confirmed -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to krb5 in Ubuntu. https://bugs.launchpad.net/bugs/251795 Title: /etc/environment PATH should not have quotes To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/krb5/+bug/251795/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 251795] Re: /etc/environment PATH should not have quotes
Reading the code as suggested by Sam, I see that everything after = and before a newline is copied into the environment using 'setenv()'. So no quote expansion is done. I'm not sure what the fix is, but there's certainly the possibility that programs will misinterpret this. I'm marking it as Confirmed in krb5. The simple fix would be to add very basic quote expansion. The code in pam that does this does not support escaped quotes, and is not exposed as an extermal library, so I think its safe to just copy that. Marking Confirmed, also adding krb5-appl since it has been split out since 10.10. I'm attaching a patch which might solve it, but I am not sure how to test it. -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to krb5 in Ubuntu. https://bugs.launchpad.net/bugs/251795 Title: /etc/environment PATH should not have quotes To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/krb5/+bug/251795/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 251795] Re: /etc/environment PATH should not have quotes
** Patch added: fix-quote-expansion.patch https://bugs.launchpad.net/ubuntu/+source/krb5-appl/+bug/251795/+attachment/2164419/+files/fix-quote-expansion.patch ** Tags added: patch ** Changed in: krb5 (Ubuntu) Importance: Undecided = Low ** Changed in: krb5-appl (Ubuntu) Importance: Undecided = Low -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to krb5 in Ubuntu. https://bugs.launchpad.net/bugs/251795 Title: /etc/environment PATH should not have quotes To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/krb5/+bug/251795/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 251795] Re: /etc/environment PATH should not have quotes
This behavior has persisted in /etc/environment now for at least 3 years, with only one report of misbehavior as a result. I don't believe it's worth the effort to try to correct this now and risk getting inconsistent behavior on upgraded vs. newly-installed systems, especially as pam_env, which owns /etc/environment, *does* parse out the quotes from variable assignments. If something else is reading /etc/environment directly, bypassing pam_env, and parsing it differently than pam_env itself does, then as Colin says, this is a bug in that component. I'm therefore reassigning this bug report to the krb5 package, as this needs to be fixed in krb5 -rsh-server. ** Package changed: pam (Ubuntu) = krb5 (Ubuntu) -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to krb5 in Ubuntu. https://bugs.launchpad.net/bugs/251795 Title: /etc/environment PATH should not have quotes -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
Re: [Bug 251795] Re: /etc/environment PATH should not have quotes
So, fixing this particular bug in krb5-rsh-server is almost certainly relatively easy. Fixing krb5-rsh-server to use PAM directly is more involved; it should be done, but there is not a lot of resources going into krb5-rsh-server and krb5-clients at the moment. Upstream split these into the krb5-appl package in significant part to provide a lower level of support for these packages. The code in question is in bsd/login.c in the krb5-appl package. Particularly, look at the read_env_vars_from_file function. I don't have time right now to generate a patch or test it, but I wanted to document where to look because I did have that time. --Sam -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to krb5 in Ubuntu. https://bugs.launchpad.net/bugs/251795 Title: /etc/environment PATH should not have quotes -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
