[Bug 713237] Re: shutdown segv due to race w/ free_waiter threads
lucid has seen the end of its life and is no longer receiving any updates. Marking the lucid task for this ticket as Won't Fix. ** Changed in: multipath-tools (Ubuntu Lucid) Status: Triaged = Won't Fix -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to multipath-tools in Ubuntu. https://bugs.launchpad.net/bugs/713237 Title: shutdown segv due to race w/ free_waiter threads To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/multipath-tools/+bug/713237/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 713237] Re: shutdown segv due to race w/ free_waiter threads
Maverick has long since stopped to receive any updates. Marking the Maverick task for this ticket as Won't Fix. ** Changed in: multipath-tools (Ubuntu Maverick) Status: New = Won't Fix -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to multipath-tools in Ubuntu. https://bugs.launchpad.net/bugs/713237 Title: shutdown segv due to race w/ free_waiter threads To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/multipath-tools/+bug/713237/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 713237] Re: shutdown segv due to race w/ free_waiter threads
** Tags added: testcase -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to multipath-tools in Ubuntu. https://bugs.launchpad.net/bugs/713237 Title: shutdown segv due to race w/ free_waiter threads To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/multipath-tools/+bug/713237/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 713237] Re: shutdown segv due to race w/ free_waiter threads
Accepted multipath-tools into lucid-proposed, the package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance! ** Changed in: multipath-tools (Ubuntu Lucid) Status: New = Fix Committed ** Tags added: verification-needed -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to multipath-tools in Ubuntu. https://bugs.launchpad.net/bugs/713237 Title: shutdown segv due to race w/ free_waiter threads -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 713237] Re: shutdown segv due to race w/ free_waiter threads
The upload to lucid-proposed was deleted, as the version was higher than that of the dev release, oneiric. If you happened to download that version while it was briefly available, you should manually downgrade back to 0.4.8-14ubuntu4, otherwise you run the risk of not updating this package on an upgrade to maverick. ** Changed in: multipath-tools (Ubuntu Lucid) Importance: Undecided = Low ** Changed in: multipath-tools (Ubuntu Lucid) Status: Fix Committed = Triaged ** Tags removed: verification-needed -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to multipath-tools in Ubuntu. https://bugs.launchpad.net/bugs/713237 Title: shutdown segv due to race w/ free_waiter threads -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 713237] Re: shutdown segv due to race w/ free_waiter threads
** Description changed:
Binary package hint: multipath-tools
+
+ ==
+ SRU Justification:
+ 1. Impact: segv on multipathd shutdown
+ 2. How bug was addressed: a patch was cherrypicked from upstream which fixes
this
+ 3. Minimal patch: see patch in attached bzr tree
+ 4. TEST CASE: stop multipathd.
+ 5. Regression potential: none, this patch was taken from upstream.
+ ==
I received a coredump from a customer (running a lucid-based system).
Analyzing the core from multipathd shows that we are crashing in
waiter.c::free_waiter().
void free_waiter (void *data)
{
- struct event_thread *wp = (struct event_thread *)data;
+ struct event_thread *wp = (struct event_thread *)data;
- /*
- * indicate in mpp that the wp is already freed storage
- */
- lock(wp-vecs-lock);
+ /*
+ * indicate in mpp that the wp is already freed storage
+ */
+ lock(wp-vecs-lock);
- if (wp-mpp)
- /*
-* be careful, mpp may already be freed -- null if so
-*/
- wp-mpp-waiter = NULL;
- else
- condlog(3, free_waiter, mpp freed before wp=%p,, wp);
+ if (wp-mpp)
+ /*
+ * be careful, mpp may already be freed -- null if so
+ */
+ wp-mpp-waiter = NULL;
+ else
+ condlog(3, free_waiter, mpp freed before wp=%p,, wp);
- unlock(wp-vecs-lock); Crashing here
+ unlock(wp-vecs-lock); Crashing here
- if (wp-dmt)
- dm_task_destroy(wp-dmt);
+ if (wp-dmt)
+ dm_task_destroy(wp-dmt);
- FREE(wp);
+ FREE(wp);
}
The lock is NULL:
(gdb) print wp-vecs-lock
$3 = (pthread_mutex_t *) 0x0
This appears to be the upstream issue fixed here:
http://git.kernel.org/gitweb.cgi?p=linux/storage/multipath-tools/.git;a=commitdiff;h=a403f57b991f3be7c7ea6250d95fad1554c9d6ca
This fix is currently missing from all versions of multipath-tools in
lucid-natty.
(The original customer issue was filed in the private bug #712875.)
** Also affects: multipath-tools (Ubuntu Lucid)
Importance: Undecided
Status: New
** Also affects: multipath-tools (Ubuntu Maverick)
Importance: Undecided
Status: New
--
You received this bug notification because you are a member of Ubuntu
Server Team, which is subscribed to multipath-tools in Ubuntu.
https://bugs.launchpad.net/bugs/713237
Title:
shutdown segv due to race w/ free_waiter threads
--
Ubuntu-server-bugs mailing list
Ubuntu-server-bugs@lists.ubuntu.com
Modify settings or unsubscribe at:
https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 713237] Re: shutdown segv due to race w/ free_waiter threads
This bug was fixed in the package multipath-tools - 0.4.8-14ubuntu9 --- multipath-tools (0.4.8-14ubuntu9) natty; urgency=low * Fix segv caused by race condition with free_waiter threads during shutdown, using backport from upstream. (LP: #713237) -- dann frazier dann.fraz...@canonical.com Thu, 03 Feb 2011 16:37:10 -0700 ** Changed in: multipath-tools (Ubuntu) Status: In Progress = Fix Released -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to multipath-tools in ubuntu. https://bugs.launchpad.net/bugs/713237 Title: shutdown segv due to race w/ free_waiter threads -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 713237] Re: shutdown segv due to race w/ free_waiter threads
** Changed in: multipath-tools (Ubuntu) Status: New = Confirmed ** Changed in: multipath-tools (Ubuntu) Assignee: (unassigned) = Serge Hallyn (serge-hallyn) ** Changed in: multipath-tools (Ubuntu) Importance: Undecided = Low -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to multipath-tools in ubuntu. https://bugs.launchpad.net/bugs/713237 Title: shutdown segv due to race w/ free_waiter threads -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 713237] Re: shutdown segv due to race w/ free_waiter threads
Thanks for the patch, Dann. I would ask you to hit 'propose for merge' from your lp tree, but I think it would be nice to have DEP-3 tags in the patch to help out future maintainers. So I'll add those to my own version and propose that for merge. -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to multipath-tools in ubuntu. https://bugs.launchpad.net/bugs/713237 Title: shutdown segv due to race w/ free_waiter threads -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 713237] Re: shutdown segv due to race w/ free_waiter threads
Tree proposed for merging. Reminder this bug should be SRU'd to lucid and maverick after the fix is applied to natty. ** Branch linked: lp:~serge-hallyn/ubuntu/natty/multipath-tools /free_waiter-race ** Changed in: multipath-tools (Ubuntu) Status: Confirmed = In Progress -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to multipath-tools in ubuntu. https://bugs.launchpad.net/bugs/713237 Title: shutdown segv due to race w/ free_waiter threads -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
Re: [Bug 713237] Re: shutdown segv due to race w/ free_waiter threads
On Wed, Feb 09, 2011 at 09:37:17PM -, Serge Hallyn wrote: Thanks for the patch, Dann. I would ask you to hit 'propose for merge' from your lp tree, but I think it would be nice to have DEP-3 tags in the patch to help out future maintainers. So I'll add those to my own version and propose that for merge. Sounds good, thanks Serge. -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to multipath-tools in ubuntu. https://bugs.launchpad.net/bugs/713237 Title: shutdown segv due to race w/ free_waiter threads -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 713237] Re: shutdown segv due to race w/ free_waiter threads
** Branch linked: lp:~dannf/ubuntu/natty/multipath-tools/free_waiter- race -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to multipath-tools in ubuntu. https://bugs.launchpad.net/bugs/713237 Title: shutdown segv due to race w/ free_waiter threads -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
