[Bug 26881] noinclude tag breaks Proofread under Internet Explorer
https://bugzilla.wikimedia.org/show_bug.cgi?id=26881 --- Comment #14 from Bawolff bawolff...@gmail.com 2011-10-01 12:50:22 UTC --- (In reply to comment #13) Not fixed yet :S Go to http://ca.wikisource.org/wiki/Pàgina:Buscant_lo_desconegut_(1898).djvu/2 with Internet Explorer 8. It contains AAAnoincludeBBB/noincludeCCC in the edit box. Click edit (or modify) but do not make any change. Click show changes for watching how the changes have run: I can see an extra div class=pagetext in the noinclude header, AAA in the edit box (without anything else), BBB in the noinclude footer, and CCC has disapeared. Firefox 5.0 runs 0 changes. I don't think the fix was deployed yet... -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26881] noinclude tag breaks Proofread under Internet Explorer
https://bugzilla.wikimedia.org/show_bug.cgi?id=26881 --- Comment #13 from Aleator aleator_w...@yahoo.es 2011-10-01 01:50:11 UTC --- Not fixed yet :S Go to http://ca.wikisource.org/wiki/Pàgina:Buscant_lo_desconegut_(1898).djvu/2 with Internet Explorer 8. It contains AAAnoincludeBBB/noincludeCCC in the edit box. Click edit (or modify) but do not make any change. Click show changes for watching how the changes have run: I can see an extra div class=pagetext in the noinclude header, AAA in the edit box (without anything else), BBB in the noinclude footer, and CCC has disapeared. Firefox 5.0 runs 0 changes. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26881] noinclude tag breaks Proofread under Internet Explorer
https://bugzilla.wikimedia.org/show_bug.cgi?id=26881 Mark A. Hershberger m...@everybody.org changed: What|Removed |Added Keywords|need-review |reviewed Status|REOPENED|RESOLVED Resolution||FIXED --- Comment #12 from Mark A. Hershberger m...@everybody.org 2011-09-29 17:52:39 UTC --- r98422 -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26881] noinclude tag breaks Proofread under Internet Explorer
https://bugzilla.wikimedia.org/show_bug.cgi?id=26881 Beau b...@adres.pl changed: What|Removed |Added Keywords||patch CC||b...@adres.pl -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26881] noinclude tag breaks Proofread under Internet Explorer
https://bugzilla.wikimedia.org/show_bug.cgi?id=26881 Bawolff bawolff...@gmail.com changed: What|Removed |Added Keywords||need-review -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26881] noinclude tag breaks Proofread under Internet Explorer
https://bugzilla.wikimedia.org/show_bug.cgi?id=26881 Mark A. Hershberger m...@everybody.org changed: What|Removed |Added AssignedTo|thoma...@gmx.de |wikibugs-l@lists.wikimedia. ||org -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26881] noinclude tag breaks Proofread under Internet Explorer
https://bugzilla.wikimedia.org/show_bug.cgi?id=26881
Philippe Elie phil...@free.fr changed:
What|Removed |Added
CC||phil...@free.fr
--- Comment #10 from Philippe Elie phil...@free.fr 2011-07-29 17:14:39 UTC ---
hi, I've no working IE to test, but I can reproduce it with Opera 10.
re3 = /^([\s\S]*?)noinclude([\s\S]*?)\/noinclude/;
here there is two competing non-greedy group, I think FF is right by making the
first one maximal, it's the same case as greedy, if there is choice for
multiple ways to do a match, the match at the same level of greediness must be
maximal from left to right. I guess this is why the comment talk about
lookahead, because with non-greedy competition, match must be moved from right
to left to implement that. The trouble is that Thomas didn't think the same
things can occur with re3 if the page contains more than two
noinclude/noinclude sequence. More boring re3 miss a final $ so only a part
of the remaining part is matched and some data are lost.
This works on Opera, by making both group greedy:
re3 = /^([\s\S]*)noinclude([\s\S]*)\/noinclude\s*$/;
I included too a \s*$ at the end to ensure if we match, we match the whole
data, this way if for some reason the match fail, we will go to the if (m3) {..
} else { pageBody = m2[2]; pageFooter = ''; } which ensure than no data can
be lost (re2 is terminated by a $). Patch attached, test with IE needed.
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26881] noinclude tag breaks Proofread under Internet Explorer
https://bugzilla.wikimedia.org/show_bug.cgi?id=26881 --- Comment #11 from Philippe Elie phil...@free.fr 2011-07-29 17:17:36 UTC --- Created attachment 8840 -- https://bugzilla.wikimedia.org/attachment.cgi?id=8840 Proofread.js: fix for data lost when more than two noinclude/noinclude sequence exists -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26881] noinclude tag breaks Proofread under Internet Explorer
https://bugzilla.wikimedia.org/show_bug.cgi?id=26881 Andrew Billinghurst billinghu...@gmail.com changed: What|Removed |Added CC||billinghu...@gmail.com --- Comment #9 from Andrew Billinghurst billinghu...@gmail.com 2011-06-22 10:03:33 UTC --- @Mark A. Hershberger the behaviour that you report will be due to your not opening the header/footer combination, and if you have NO toolbar, or the Wikieditor, you cannot expand those sections. One needs to regress to the older toolbar. [Matter discussed elsewhere in bugzilla. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26881] noinclude tag breaks Proofread under Internet Explorer
https://bugzilla.wikimedia.org/show_bug.cgi?id=26881 Andrew Billinghurst billinghu...@gmail.com changed: What|Removed |Added Web browser|--- |Internet Explorer 8.x -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26881] noinclude tag breaks Proofread under Internet Explorer
https://bugzilla.wikimedia.org/show_bug.cgi?id=26881 Mark A. Hershberger m...@everybody.org changed: What|Removed |Added Keywords|triage | -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26881] noinclude tag breaks Proofread under Internet Explorer
https://bugzilla.wikimedia.org/show_bug.cgi?id=26881 Mark A. Hershberger m...@everybody.org changed: What|Removed |Added Keywords||triage -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26881] noinclude tag breaks Proofread under Internet Explorer
https://bugzilla.wikimedia.org/show_bug.cgi?id=26881 --- Comment #7 from Mark A. Hershberger m...@everybody.org 2011-01-29 19:11:55 UTC --- I think this may be there in FF 3.6.13 on Linux. When I first visit the page I see: AAABBBCCC Clicking Modifica shows the edit box containing: AAAnoincludeBBB/noincludeCCC Clicking the [+] box displays the following in Peu de pàgina (noinclude): -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26881] noinclude tag breaks Proofread under Internet Explorer
https://bugzilla.wikimedia.org/show_bug.cgi?id=26881 --- Comment #8 from Aleator aleator_w...@yahoo.es 2011-01-29 19:49:34 UTC --- (In reply to comment #7) I think this may be there in FF 3.6.13 on Linux. When I first visit the page I see: AAABBBCCC Clicking Modifica shows the edit box containing: AAAnoincludeBBB/noincludeCCC Clicking the [+] box displays the following in Peu de pàgina (noinclude): That's the expected and correct behaviour (FF works 100% fine). The same edition in IE 8.0 leaves AAA in the body (Cos de la pàgina), BBB has jumped to the footer (Peu de pàgina), and... there's no CCC and (if we save that edit info will be lost). The key is pr_make_edit_area. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26881] noinclude tag breaks Proofread under Internet Explorer
https://bugzilla.wikimedia.org/show_bug.cgi?id=26881 Bawolff bawolff...@gmail.com changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|WORKSFORME | --- Comment #6 from Bawolff bawolff...@gmail.com 2011-01-28 17:29:11 UTC --- Said JS is only executed when editing the page, before i thought you meant it happened when you were viewing not editing the page. there is a comment there saying apparently lookahead is not supported by all browsers so let us do another regexp However said regex does not use look-ahead assertions, so I'm not sure what that's about. But anyways, I'm not familiar enough with the code to know what I'm talking about here. Anyways, tested http://ca.wikisource.org/w/index.php?title=P%C3%A0gina:Buscant_lo_desconegut_(1898).djvu/2action=edit in IE6, and confirmed bug is present. Re-opening bug. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26881] noinclude tag breaks Proofread under Internet Explorer
https://bugzilla.wikimedia.org/show_bug.cgi?id=26881 Mark A. Hershberger m...@everybody.org changed: What|Removed |Added Status|NEW |RESOLVED CC||m...@everybody.org Resolution||WORKSFORME --- Comment #3 from Mark A. Hershberger m...@everybody.org 2011-01-27 16:18:46 UTC --- Cannot reproduce with IE8 on http://ca.wikisource.org/wiki/Pàgina:Buscant_lo_desconegut_(1898).djvu/2 when I try. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26881] noinclude tag breaks Proofread under Internet Explorer
https://bugzilla.wikimedia.org/show_bug.cgi?id=26881 --- Comment #4 from Aleator aleator_w...@yahoo.es 2011-01-28 01:57:03 UTC --- Mmm... It's not ProofreadPage_body.php, because html parses identical in both browsers. I've found the responsible code at http://ca.wikisource.org/w/extensions/ProofreadPage/proofread.js?26 The behaviour of the regexp is different in the 2 browsers: - With MF, regexp matches so m exists and splits the text correctly in the 3 desired parts. - With my IE 8.0, m don't exist (no matching, why? [comment on code shows the author realized not all browsers worked]). So it tries to split text in 2-3 times. First into m2[1] (header, splits but I see 3 extra line breaks, those between the end of div class=pagetext and the beginnig of the next /noinclude) and m2[2] (body+footer). And then m[2] into m3[1] (body, truncated) and m3[2] (footer, part of what should be the body, being lost the end part). It makes sense studying the code. I'm trying to get the correct combination of the regexp (e.g. http://ca.wikisource.org/w/index.php?title=Usuari:Aleator/vector.jsoldid=29992, testing with the sandbox http://ca.wikisource.org/w/index.php?title=Viquitexts:P%C3%A0gina_de_provesoldid=29824), but I still don't have the solution. I'll keep trying. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26881] noinclude tag breaks Proofread under Internet Explorer
https://bugzilla.wikimedia.org/show_bug.cgi?id=26881 --- Comment #5 from Aleator aleator_w...@yahoo.es 2011-01-28 01:58:20 UTC --- The function is pr_make_edit_area. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26881] noinclude tag breaks Proofread under Internet Explorer
https://bugzilla.wikimedia.org/show_bug.cgi?id=26881 --- Comment #1 from Aleator aleator_w...@yahoo.es 2011-01-24 01:08:04 UTC --- Hint: it could be related to $page_regexp from parse_page function at ProofreadPage_body.php. I can interpret it as if it divides the $text into three parts depending on the noinclude tags (I suppose for detecting header, body and footer). But cannot explain the diference between MF vs IE. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 26881] noinclude tag breaks Proofread under Internet Explorer
https://bugzilla.wikimedia.org/show_bug.cgi?id=26881 Bawolff bawolff...@gmail.com changed: What|Removed |Added CC||bawolff...@gmail.com --- Comment #2 from Bawolff bawolff...@gmail.com 2011-01-24 01:59:09 UTC --- Can not reproduce on IE6 (Admittedly that's the wrong version of IE, but its what i had available at the moment). I don't see the BBB's being differentiated in any way in the html source, so i have no idea what could cause this. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
