[Bug 29595] Search suggestions broken on als.wikipedia.org
https://bugzilla.wikimedia.org/show_bug.cgi?id=29595 --- Comment #26 from Clemens Kienzle clemens.kien...@gmx.net 2011-11-15 08:52:32 UTC --- Everything appears to be working fine now (at least after clearing my browser). Awesome! Thank you so much for your work! -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 29595] Search suggestions broken on als.wikipedia.org
https://bugzilla.wikimedia.org/show_bug.cgi?id=29595
Brion Vibber br...@wikimedia.org changed:
What|Removed |Added
CC||br...@wikimedia.org
--- Comment #19 from Brion Vibber br...@wikimedia.org 2011-11-14 20:55:24 UTC
---
As of 2011-11-14, search suggestions do not work for me on als.wikipedia.org.
As of 2011-11-14, the magic title replacement when using {{Titel}} does work
for me on als.wikipedia.org.
Bug 32366 appears to just be a continuation of this bug, so I'll merge it in.
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 29595] Search suggestions broken on als.wikipedia.org
https://bugzilla.wikimedia.org/show_bug.cgi?id=29595 --- Comment #20 from Brion Vibber br...@wikimedia.org 2011-11-14 20:56:04 UTC --- *** Bug 32366 has been marked as a duplicate of this bug. *** -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 29595] Search suggestions broken on als.wikipedia.org
https://bugzilla.wikimedia.org/show_bug.cgi?id=29595 --- Comment #21 from Brion Vibber br...@wikimedia.org 2011-11-14 21:10:08 UTC --- So here's your problem. The code that does the properTitle replacement is in another script: https://als.wikipedia.org/w/index.php?title=MediaWiki:If-pTitle.js which never got updated. If that was getting run with regular jQuery back in the $ slot, it would fail here: var pTitle = $(pTitle).innerHTML; returning undefined. which would then get used in the title replacement. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 29595] Search suggestions broken on als.wikipedia.org
https://bugzilla.wikimedia.org/show_bug.cgi?id=29595 --- Comment #22 from Brion Vibber br...@wikimedia.org 2011-11-14 21:17:20 UTC --- Also look like they would break with jQuery due to use of this custom $ function: https://als.wikipedia.org/wiki/MediaWiki:If-WikiPoll.js https://als.wikipedia.org/wiki/MediaWiki:If-anon-feedback.js https://als.wikipedia.org/wiki/MediaWiki:If-hideable-portlets.js https://als.wikipedia.org/wiki/MediaWiki:If-hideable-sidebar.js https://als.wikipedia.org/wiki/MediaWiki:If-history.js https://als.wikipedia.org/wiki/MediaWiki:If-markedPatrolled.js https://als.wikipedia.org/wiki/MediaWiki:If-search.js https://als.wikipedia.org/wiki/MediaWiki:If-sidebar-bug.js Need SSL fixes (switch style images to protocol-relative) at least: https://als.wikipedia.org/wiki/MediaWiki:If-LinkFA.js https://als.wikipedia.org/wiki/MediaWiki:If-anon-feedback.js https://als.wikipedia.org/wiki/MediaWiki:If-pVC.js -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 29595] Search suggestions broken on als.wikipedia.org
https://bugzilla.wikimedia.org/show_bug.cgi?id=29595 --- Comment #23 from Brion Vibber br...@wikimedia.org 2011-11-14 22:03:57 UTC --- Ok I've resolved some of the main breakages -- and the title script is updated to work -- but the search suggestions still aren't working for me, so I'll have to poke a little more. Will return shortly. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 29595] Search suggestions broken on als.wikipedia.org
https://bugzilla.wikimedia.org/show_bug.cgi?id=29595 --- Comment #24 from Brion Vibber br...@wikimedia.org 2011-11-14 22:36:55 UTC --- The actual search suggestions appear to have been broken by this script: https://de.wiktionary.org/wiki/MediaWiki:If-search.js which appears to blindly destroy any DOM attachments such as, say, event handlers in the search form. I've removed it as it's unclear what it's even for. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 29595] Search suggestions broken on als.wikipedia.org
https://bugzilla.wikimedia.org/show_bug.cgi?id=29595 Brion Vibber br...@wikimedia.org changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution||FIXED --- Comment #25 from Brion Vibber br...@wikimedia.org 2011-11-14 22:54:29 UTC --- Ok I think I've got these all worked out now. I've also removed the If-search.js script that was being pulled in from the master copy on de.wiktionary.org; that script itself is broken (it's what stopped search suggestions from working) and appears to be of limited/no use at present. I've checked in with Krinkle about that script; it may get tweaked in future to work cleaner or be dropped entirely, depending. Currently I see working search suggestions, the title replacements work, and the SSL mixed-mode warnings I was seeing on https://als.wikipedia.org/ appear to now be resolved. Please give a shout if anything else is broken! -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 29595] Search suggestions broken on als.wikipedia.org
https://bugzilla.wikimedia.org/show_bug.cgi?id=29595 --- Comment #16 from Holder als.hol...@gmail.com 2011-07-12 12:23:41 UTC --- I undid all your modifications because I didn't know which of them was responsible for the breaking of the template. I don't think that the template is related to the search function. Search suggestions don't work for me too. Perhaps this depends on the used browser? I'm using Firefox 5.0. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 29595] Search suggestions broken on als.wikipedia.org
https://bugzilla.wikimedia.org/show_bug.cgi?id=29595 --- Comment #17 from Holder als.hol...@gmail.com 2011-07-12 12:39:29 UTC --- Krinkle, I've taken over your global.js skript on meta, now search suggestions are working fine for me :-). -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 29595] Search suggestions broken on als.wikipedia.org
https://bugzilla.wikimedia.org/show_bug.cgi?id=29595 --- Comment #18 from Holder als.hol...@gmail.com 2011-07-12 12:58:29 UTC --- On the other side the title template isn't working now. It seems that there is indeed a relation between this template and the search suggestions ... -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 29595] Search suggestions broken on als.wikipedia.org
https://bugzilla.wikimedia.org/show_bug.cgi?id=29595 --- Comment #15 from Clemens Kienzle clemens.kien...@gmx.net 2011-07-11 07:23:04 UTC --- Strange that the search suggestions work for you, they don't work for me (or any other users I've talked to). It will take me to the article if I enter the whole title, but it won't display any suggestions as I type. Holder undid the modifications because several templates stopped working. Most importantly: http://als.wikipedia.org/wiki/Vorlage:Titel On als.wikipedia, all articles are saved under the Standard German keyword, but the Alemannic title is displayed through the above template. For example, on http://als.wikipedia.org/wiki/Kartoffel the title is displayed as Härdöpfel. Something in the changes you made caused this template to stop working. So instead of Härdöpfel it would display undefined. Since this affects nearly all pages, it is pretty serious. Maybe we should first figure out why Vorlage:Titel doesn't work with your modifications, and then figure out the search function? Should I open a new bug for that? -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 29595] Search suggestions broken on als.wikipedia.org
https://bugzilla.wikimedia.org/show_bug.cgi?id=29595 Krinkle krinklem...@gmail.com changed: What|Removed |Added Summary|Search engine on|Search suggestions broken |als.wikipedia.org |on als.wikipedia.org --- Comment #13 from Krinkle krinklem...@gmail.com 2011-07-11 00:01:54 UTC --- What exactly is broken ? The search itself works fine: http://i.imgur.com/XHuhQ.png The search suggestions work fine too: http://i.imgur.com/NBaGH.png I've renamed the title as I suspect your report is about the suggestions underneath during the typing, not about the search itself. (drop down menu). How exactly is that template related to the search ? -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 29595] Search suggestions broken on als.wikipedia.org
https://bugzilla.wikimedia.org/show_bug.cgi?id=29595 --- Comment #14 from Krinkle krinklem...@gmail.com 2011-07-11 00:04:13 UTC --- Why did you undo all modifications I made to the site scripts ? What exactly broke where ? Samples and screenshots will help if you want me to fix it. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
