[MediaWiki-CodeReview] [MediaWiki r103260]: New comment added
G.Hagedorn posted a comment on MediaWiki.r103260. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/103260#c28286 Commit summary for MediaWiki.r103260: (follow-up r100023; bug 32438) $pagesCount is total number of members a category has, not the number that are normal pages. G.Hagedorn's comment: Please tag for 1.18 as well, this fixes erroneous category page display. Has been applied to 1.18wmf1 in r106667, tag 1.18wmf1 needs to be deleted. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r103260]: New comment added
G.Hagedorn posted a comment on MediaWiki.r103260. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/103260#c28287 Commit summary for MediaWiki.r103260: (follow-up r100023; bug 32438) $pagesCount is total number of members a category has, not the number that are normal pages. G.Hagedorn's comment: PS: some additional changes to this in r103315 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r107014]: Revision status changed
Nikerabbit changed the status of MediaWiki.r107014 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107014 Old status: new New status: ok Commit summary for MediaWiki.r107014: [mediawiki.api] bug fixes * error callback of some convenience functions was broken. Second argument to get() is ajaxOptions, there is no third argument. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r107036]: New comment added
Siebrand posted a comment on MediaWiki.r107036.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107036#c28288
Commit summary for MediaWiki.r107036:
Adding support for managing puppet classes and variables through the interface,
rather than LocalSettings.php. Resolves bug 32221 and bug 3.
Siebrand's comment:
{{messagedocumentation}}
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r106706]: New comment added
Santhosh.thottingal posted a comment on MediaWiki.r106706.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106706#c28289
Commit summary for MediaWiki.r106706:
[WebFonts] Code quality clean up
* Various good practices, white space conventions (Thanks JSLint)
* Such as:
-- JavaScript does not have block scope! Removed var statements from loops, and
put them outside the loop for clarity
-- Optimize a few loops (swapped a 'for in' loop for a 'for i length' loop,
since it was an array, and improved the existing one by caching the length
property since otherwise the length property would be accessed every iteration
- also prevents infinite loops in some situations)
-- Combining var statements. Ideally every function only needs 1 var statement
(since there is only function scope and everything is hoisted internally
anyway), but no time to go through and restructure them all right now, did most
of them.
-- Improve function documentation ('@param config The webfont configuration.'
- '@param fonts {Array} List of fonts to be provided as a menu option.')
-- Removed unused variables (such as 'languages' in
loadFontsForFontFamilyStyle, added in r100677)
-- Using strict comparison to false values (match(..) === null), both for speed
gain and improve readability as loose comparison is ambiguous in JavaScript
(val == null also returns true for undefined instead of null)
-- Using direct property access and strict comparison instead of an ' in '
lookup
-- Rename a variable called 'config' to 'fonts' (array) to avoid confusion with
another variable that is a plain object also called 'config'
-- Make 'mw' a local variable by passing it through the IIFE closure from the
global scope (for faster lookups in the context object)
-- Using the || operator in a variable assignment as var = foo || bar
instead of var = foo ? foo : bar. In JavaScript comparison operators do not
return boolean, instead they return the last compared value. (which in an
if-statement is then type-coerced to a boolean)
-- Using mw.util.addCSS instead of creating a new style element locally.
-- Trailing whitespace
-- Redundant spaces (e.g. double space where single space was intended)
Santhosh.thottingal's comment:
Thanks Krinkle, I used mw.util.addCSS in r107043 and looks like crash issue is
resolved.
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r107016]: New comment added
Nikerabbit posted a comment on MediaWiki.r107016. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107016#c28290 Commit summary for MediaWiki.r107016: Improved error reporting: * Altered ScoreException to accept error message parameters * Use error CSS for ScoreCallException * The error messages themselves have been made clearer Nikerabbit's comment: Would it be easier to just pass the Message objects around? Then the caller can feed the parameters to that message and the exception can format it how it wants. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r106992]: New comment added
Santhosh.thottingal posted a comment on MediaWiki.r106992. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106992#c28291 Commit summary for MediaWiki.r106992: [Core JS] mw.util.addCSS: Insert style tag into dom before setting cssText * Fixes bug 33305 Santhosh.thottingal's comment: I think the release-notes text is wrong. It should be : (bug 33305) Make mw.util.addCSS resistant to IE's @font-face bug with setting cssText '''after''' DOM insertion. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r107021]: Revision status changed
Nikerabbit changed the status of MediaWiki.r107021 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107021 Old status: new New status: ok Commit summary for MediaWiki.r107021: call_user_func_array() is not actually necessary ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r106706]: Revision status changed
Santhosh.thottingal changed the status of MediaWiki.r106706 to resolved
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106706
Old status: new
New status: resolved
Commit summary for MediaWiki.r106706:
[WebFonts] Code quality clean up
* Various good practices, white space conventions (Thanks JSLint)
* Such as:
-- JavaScript does not have block scope! Removed var statements from loops, and
put them outside the loop for clarity
-- Optimize a few loops (swapped a 'for in' loop for a 'for i length' loop,
since it was an array, and improved the existing one by caching the length
property since otherwise the length property would be accessed every iteration
- also prevents infinite loops in some situations)
-- Combining var statements. Ideally every function only needs 1 var statement
(since there is only function scope and everything is hoisted internally
anyway), but no time to go through and restructure them all right now, did most
of them.
-- Improve function documentation ('@param config The webfont configuration.'
- '@param fonts {Array} List of fonts to be provided as a menu option.')
-- Removed unused variables (such as 'languages' in
loadFontsForFontFamilyStyle, added in r100677)
-- Using strict comparison to false values (match(..) === null), both for speed
gain and improve readability as loose comparison is ambiguous in JavaScript
(val == null also returns true for undefined instead of null)
-- Using direct property access and strict comparison instead of an ' in '
lookup
-- Rename a variable called 'config' to 'fonts' (array) to avoid confusion with
another variable that is a plain object also called 'config'
-- Make 'mw' a local variable by passing it through the IIFE closure from the
global scope (for faster lookups in the context object)
-- Using the || operator in a variable assignment as var = foo || bar
instead of var = foo ? foo : bar. In JavaScript comparison operators do not
return boolean, instead they return the last compared value. (which in an
if-statement is then type-coerced to a boolean)
-- Using mw.util.addCSS instead of creating a new style element locally.
-- Trailing whitespace
-- Redundant spaces (e.g. double space where single space was intended)
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r107023]: Revision status changed
Nikerabbit changed the status of MediaWiki.r107023 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107023 Old status: new New status: ok Commit summary for MediaWiki.r107023: Update documentation on params method of Message class to indicate it can either be varags, or it can also take an array of all the parameters as the first argument. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r107026]: Revision status changed
Nikerabbit changed the status of MediaWiki.r107026 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107026 Old status: new New status: ok Commit summary for MediaWiki.r107026: Followup r106817 If in doubt, add more .. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r107027]: Revision status changed
Nikerabbit changed the status of MediaWiki.r107027 to resolved URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107027 Old status: new New status: resolved Commit summary for MediaWiki.r107027: Update paths from r106787 And also, use more newer/familiar code for inclusion of maintenance script base ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r100535]: Revision status changed
Hashar changed the status of MediaWiki.r100535 to resolved URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100535 Old status: new New status: resolved Commit summary for MediaWiki.r100535: Added a basic thumb-handler.php file, configured via thumb.config.php. The code is based on the wmf thumb handler, but simplified. It is disabled by default. * The thumb.php parameter extraction can also be overridden by the config to handle more complex setups and things like OggHandler and PagedTiffHandler. * A simple 404 error page is also included. It can be overridden by the config. * Additional HTTP headers can be passed through cURL via the config. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r100535]: Revision status changed
Hashar changed the status of MediaWiki.r100535 to reverted URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100535 Old status: resolved New status: reverted Commit summary for MediaWiki.r100535: Added a basic thumb-handler.php file, configured via thumb.config.php. The code is based on the wmf thumb handler, but simplified. It is disabled by default. * The thumb.php parameter extraction can also be overridden by the config to handle more complex setups and things like OggHandler and PagedTiffHandler. * A simple 404 error page is also included. It can be overridden by the config. * Additional HTTP headers can be passed through cURL via the config. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r101117]: Revision status changed
Hashar changed the status of MediaWiki.r101117 to reverted URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101117 Old status: new New status: reverted Commit summary for MediaWiki.r101117: FU r100535: * Thumb handler can now also work without cURL * Combined related config vars into array config vars * Folded $thgThumb404File into $thgThumbCallbacks * Avoided some global pollution ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r101117]: Revision status changed
Hashar changed the status of MediaWiki.r101117 to resolved URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101117 Old status: reverted New status: resolved Commit summary for MediaWiki.r101117: FU r100535: * Thumb handler can now also work without cURL * Combined related config vars into array config vars * Folded $thgThumb404File into $thgThumbCallbacks * Avoided some global pollution ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r100535]: Revision status changed
Hashar changed the status of MediaWiki.r100535 to resolved URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100535 Old status: reverted New status: resolved Commit summary for MediaWiki.r100535: Added a basic thumb-handler.php file, configured via thumb.config.php. The code is based on the wmf thumb handler, but simplified. It is disabled by default. * The thumb.php parameter extraction can also be overridden by the config to handle more complex setups and things like OggHandler and PagedTiffHandler. * A simple 404 error page is also included. It can be overridden by the config. * Additional HTTP headers can be passed through cURL via the config. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r100782]: Revision status changed
Hashar changed the status of MediaWiki.r100782 to resolved URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100782 Old status: new New status: resolved Commit summary for MediaWiki.r100782: FU r100535: * Added thumb-handler.php5 file * Moved 404.php to thumb-handler.php as wfDisplay404Error() * Removed excess short-circuiting error cases in thumb-handler.php * Moved cURL extension check to the top of the file * Improved sample $thgThumbHashFragment regex value * Cleaned up wfStreamThumbViaCurl() error handling code a bit ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r100577]: New comment added
Aaron Schulz posted a comment on MediaWiki.r100577. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100577#c28292 Commit summary for MediaWiki.r100577: FU r100535: * Changed custom functions to work via a $thgThumbCallbacks variable * Added 'checkCache' and 'fillCache' hooks to $thgThumbCallbacks * Minor regex cleanup to wfExtractThumbParams() * Re-organized a bit of the wfStreamThumbViaCurl() code Aaron Schulz's comment: This was basically totally redone in r105512. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r107029]: Revision status changed
Nikerabbit changed the status of MediaWiki.r107029 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107029 Old status: new New status: ok Commit summary for MediaWiki.r107029: Followup r107027, require_once will work much better ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r100610]: Revision status changed
Hashar changed the status of MediaWiki.r100610 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100610 Old status: new New status: ok Commit summary for MediaWiki.r100610: * (bug 31921) Fix for r78201: magic words REVISIONDAY, REVISIONMONTH and REVISIONYEAR now give current values on preview ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r100610]: New comment added
Hashar posted a comment on MediaWiki.r100610. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100610#c28293 Commit summary for MediaWiki.r100610: * (bug 31921) Fix for r78201: magic words REVISIONDAY, REVISIONMONTH and REVISIONYEAR now give current values on preview Hashar's comment: Merged in REL1_18 by r107046 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r100445]: Revision status changed
Hashar changed the status of MediaWiki.r100445 to resolved URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100445 Old status: new New status: resolved Commit summary for MediaWiki.r100445: Use local context to get messages ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r94881]: New comment added
Marooned posted a comment on MediaWiki.r94881. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94881#c28294 Commit summary for MediaWiki.r94881: Relative values of the Location header are incorrect as stated in RFC, however they do happen and modern browsers support them. This function loops backwards through all locations in order to build the proper absolute URI - Marooned at wikia-inc.com Marooned's comment: I can't remember the site causing troubles but I've fixed that functions because of a real case. I got multiple Location headers from getResponseHeaders() and some of them were relative. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r106948]: New comment added
Marooned posted a comment on MediaWiki.r106948. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106948#c28295 Commit summary for MediaWiki.r106948: tests for r94881 which interprets relative Location: headers Marooned's comment: As I've answered you under 94881, I stumbled upon some real page giving me multiple Location headers. Hence the fix. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r107050]: New comment added, and revision status changed
Nikerabbit changed the status of MediaWiki.r107050 to ok and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107050#c28296 Old Status: new New Status: ok Commit summary for MediaWiki.r107050: Add gender support for two messages. Uncertain yet if this is properly done in the code. From ApiViewFeedbackArticleFeedbackv5.php: $found = wfMessage( 'articlefeedbackv5-form1-header-found', $name )-escaped(); Nikerabbit's comment: It's usually around the verb, but I see no reason why it wouldn't work. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r105645]: New comment added
Hashar posted a comment on MediaWiki.r105645. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/105645#c28297 Commit summary for MediaWiki.r105645: Add a configuration variable to work around the issue that has been reported at least twice on IRC: pages from MW with a 404 status code have the last block of their body replaced, and their headers appended to, resulting in totally broken output for page views of non-existent pages. BizLand or some reseller is probably at fault. Hashar's comment: Perfect! Looks fine to me 8-) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r107051]: New comment added
Siebrand posted a comment on MediaWiki.r107051. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107051#c28298 Commit summary for MediaWiki.r107051: Add a help link to WebFonts, pointing to mediawiki.org. i18n card #303 Siebrand's comment: Can we make the help URL configurable in a messag? Then at least locall communities will be able to override the centralised help page. If we don't do this, I expect a change request for it almost immediately after deployment ... ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r107048]: Revision status changed
Nikerabbit changed the status of MediaWiki.r107048 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107048 Old status: new New status: ok Commit summary for MediaWiki.r107048: Typo in CommonsHelper English ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r107049]: Revision status changed
Nikerabbit changed the status of MediaWiki.r107049 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107049 Old status: new New status: ok Commit summary for MediaWiki.r107049: Better help icon. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r104392]: Revision status changed
Nikerabbit changed the status of MediaWiki.r104392 to resolved URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104392 Old status: new New status: resolved Commit summary for MediaWiki.r104392: Correct the pointer behavior on the menu items. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r106432]: Revision status changed
Nikerabbit changed the status of MediaWiki.r106432 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106432 Old status: new New status: ok Commit summary for MediaWiki.r106432: it is not possible to stop propagation of live events. changed to delegage. Merged the two live bindings to single. And prevented hiding the menu if clicked. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r106435]: Revision status changed
Nikerabbit changed the status of MediaWiki.r106435 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106435 Old status: new New status: ok Commit summary for MediaWiki.r106435: Updated the Tamil bamini keymap. Ref Bug 31904 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r107045]: Revision status changed
Nikerabbit changed the status of MediaWiki.r107045 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107045 Old status: new New status: ok Commit summary for MediaWiki.r107045: Moved SQLite test .sql files to the common test data directory ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r106945]: Revision status changed
Nikerabbit changed the status of MediaWiki.r106945 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106945 Old status: new New status: ok Commit summary for MediaWiki.r106945: profiling ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r106944]: Revision status changed
Nikerabbit changed the status of MediaWiki.r106944 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106944 Old status: new New status: ok Commit summary for MediaWiki.r106944: Added 2 new feeds: Did you know? and Quote of the day; message documentation ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r106930]: Revision status changed
Nikerabbit changed the status of MediaWiki.r106930 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106930 Old status: new New status: ok Commit summary for MediaWiki.r106930: Renamed parameter 'channel' into 'feed' for clarity ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r106824]: Revision status changed
Nikerabbit changed the status of MediaWiki.r106824 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106824 Old status: new New status: ok Commit summary for MediaWiki.r106824: Made todaysStart() honor local time zone ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r106814]: Revision status changed
Nikerabbit changed the status of MediaWiki.r106814 to resolved URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106814 Old status: new New status: resolved Commit summary for MediaWiki.r106814: Roughly done. Needs i18n review, messages 'ffeed-*-page' should be left untranslated ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r107054]: New comment added
Nikerabbit posted a comment on MediaWiki.r107054. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107054#c28299 Commit summary for MediaWiki.r107054: do not evaluate '?php' line This happen when you are sending to eval.php a php file. The first line is the string '?php' which is passed to eval(). Boom! This patch skip that string. Example usage: $ cat somefile.php ?php echo Working!\n; $ $ cat somefile.php | php maintenance/eval.php Working! $ Nikerabbit's comment: Why would you want to evaluate a php file this way? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r107047]: Revision status changed
Nikerabbit changed the status of MediaWiki.r107047 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107047 Old status: new New status: ok Commit summary for MediaWiki.r107047: remove bug 31921 from 1.19 RN Fix was merged in REL1_18 by r107046 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r107054]: Revision status changed
MaxSem changed the status of MediaWiki.r107054 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107054 Old status: new New status: ok Commit summary for MediaWiki.r107054: do not evaluate '?php' line This happen when you are sending to eval.php a php file. The first line is the string '?php' which is passed to eval(). Boom! This patch skip that string. Example usage: $ cat somefile.php ?php echo Working!\n; $ $ cat somefile.php | php maintenance/eval.php Working! $ ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r107046]: Revision status changed
Nikerabbit changed the status of MediaWiki.r107046 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107046 Old status: new New status: ok Commit summary for MediaWiki.r107046: MFT to REL1_18 r100610, bug 31921 This is a regression in REL1_18: (bug 31921) Magic words REVISIONDAY, REVISIONMONTH and REVISIONYEAR now give current values on preview ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r107044]: Revision status changed
Nikerabbit changed the status of MediaWiki.r107044 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107044 Old status: new New status: ok Commit summary for MediaWiki.r107044: adding Wikinaut ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r107051]: New comment added
Santhosh.thottingal posted a comment on MediaWiki.r107051. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107051#c28301 Commit summary for MediaWiki.r107051: Add a help link to WebFonts, pointing to mediawiki.org. i18n card #303 Santhosh.thottingal's comment: Help link made configurable in r107056 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r106764]: Revision status changed
Tim Starling changed the status of MediaWiki.r106764 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106764 Old status: new New status: ok Commit summary for MediaWiki.r106764: FU r106752: Fixed directory b/c for ForeignAPIRepo, which was moved to Setup.php ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r106765]: New comment added, and revision status changed
Tim Starling changed the status of MediaWiki.r106765 to ok and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106765#c28302 Old Status: new New Status: ok Commit summary for MediaWiki.r106765: Set deleted zone container in UploadFromUrlTestSuite Tim Starling's comment: Was this the reason for the Jenkins failure? If so, well done isolating it. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r106771]: Revision status changed
Tim Starling changed the status of MediaWiki.r106771 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106771 Old status: new New status: ok Commit summary for MediaWiki.r106771: Set deleted zone container in parserTest.inc ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r107042]: New comment added
Moejoe000 posted a comment on MediaWiki.r107042. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107042#c28303 Commit summary for MediaWiki.r107042: Make apibase of $wgForeignFileRepos (InstantCommons) protocol relative too Moejoe000's comment: AFIAK, this is used by MediaWiki itself (phase3/includes/filerepo/ForeignAPIRepo.php) to fetch data from commons. Does this make any sense to be here protocol-relative? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r106834]: Revision status changed
Tim Starling changed the status of MediaWiki.r106834 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106834 Old status: new New status: ok Commit summary for MediaWiki.r106834: FU r106752: added b/c code to FSRepo to make things easy for extensions (like ConfirmAccount) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r106841]: Revision status changed
Tim Starling changed the status of MediaWiki.r106841 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106841 Old status: new New status: ok Commit summary for MediaWiki.r106841: Cleaned up some references to FSRepo in code and comments. This should have no noticeable functional changes. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r106894]: Revision status changed
Tim Starling changed the status of MediaWiki.r106894 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106894 Old status: new New status: ok Commit summary for MediaWiki.r106894: FU r106752: use media- instead of images- in container names. Long live books, video, 3D meshes, and animated holograms from the future! ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r106978]: Revision status changed
Tim Starling changed the status of MediaWiki.r106978 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106978 Old status: new New status: ok Commit summary for MediaWiki.r106978: * Added FileRepo::SKIP_LOCKING constant and made storeBatch() check it. * Made File::maybeDoTransform() use the FileRepo::store() and a new File::getThumbRel() function. Looks cleaner and loosens FileBackend coupling. * Also made storeTemp() use FileRepo::SKIP_LOCKING for performance. * Killed some useless initZones() calls in FileRepo. Extensions may not even use these zones. Likewise, it could make tests fail even though they don't those zones. We already do the sanity with some prepare() calls in storeBatch(). * Removed FileRepo::SKIP_VALIDATION, not used by anything now. * Moved getUrlRel() down a bit. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r107056]: New comment added
Nikerabbit posted a comment on MediaWiki.r107056. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107056#c28304 Commit summary for MediaWiki.r107056: Get the help link from messages based on content language. Nikerabbit's comment: You don't need to load webfonts-help-page in resource loader. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r106597]: New comment added
Toniher posted a comment on MediaWiki.r106597. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106597#c28305 Commit summary for MediaWiki.r106597: added UserFunction Toniher's comment: I've already addressed, at least partially, some of the concerns that were raised in this review. Thanks for your comments. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r106982]: New comment added, and revision status changed
Tim Starling changed the status of MediaWiki.r106982 to ok and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106982#c28306 Old Status: new New Status: ok Commit summary for MediaWiki.r106982: * FU r106752: unbreak urls to ForeignAPIRepo file thumbnails. FileRepo no longer uses bogus public root URL/thumb default for the thumnail URL when the public root URL wasn't even set. This was making ForeignAPIRepo not set it since it saw that it was already set. * Cleaned up and added some missing sanity checks for scriptDirUrl member in FileRepo. Made some related documentation tweaks. * Removed pointless getRepo() call in File. Tim Starling's comment: Is that why people keep tagging them [[Special:Code/MediaWiki/tag/lamecommitsummary|lamecommitsummary]]? Because everyone assumes Aaron is telling a revision to f*** itself? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r107054]: New comment added
Hashar posted a comment on MediaWiki.r107054. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107054#c28307 Commit summary for MediaWiki.r107054: do not evaluate '?php' line This happen when you are sending to eval.php a php file. The first line is the string '?php' which is passed to eval(). Boom! This patch skip that string. Example usage: $ cat somefile.php ?php echo Working!\n; $ $ cat somefile.php | php maintenance/eval.php Working! $ Hashar's comment: When using eval.php, I write the commands in a file ending with .php. My editor requires the first line to be '?php' to enable syntax coloring :-) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r107054]: New comment added
Hashar posted a comment on MediaWiki.r107054. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107054#c28308 Commit summary for MediaWiki.r107054: do not evaluate '?php' line This happen when you are sending to eval.php a php file. The first line is the string '?php' which is passed to eval(). Boom! This patch skip that string. Example usage: $ cat somefile.php ?php echo Working!\n; $ $ cat somefile.php | php maintenance/eval.php Working! $ Hashar's comment: You get kaboom. But since whoever that will do that is probably a developer, that person can amend my change so eval.php supports that syntax 8-) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r107055]: New comment added, and revision status changed
Hashar changed the status of MediaWiki.r107055 to ok and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107055#c28309 Old Status: new New Status: ok Commit summary for MediaWiki.r107055: Fixed a typo in r107054 Hashar's comment: I need to make an infograph out of that and print it above my desk. I unfortunately keep doing that mistake :-( Thanks for the fix MaxSem! ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r107054]: New comment added
MaxSem posted a comment on MediaWiki.r107054. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107054#c28310 Commit summary for MediaWiki.r107054: do not evaluate '?php' line This happen when you are sending to eval.php a php file. The first line is the string '?php' which is passed to eval(). Boom! This patch skip that string. Example usage: $ cat somefile.php ?php echo Working!\n; $ $ cat somefile.php | php maintenance/eval.php Working! $ MaxSem's comment: Including the removal of initial ?php ;) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r106982]: New comment added
Peachey88 posted a comment on MediaWiki.r106982. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106982#c28311 Commit summary for MediaWiki.r106982: * FU r106752: unbreak urls to ForeignAPIRepo file thumbnails. FileRepo no longer uses bogus public root URL/thumb default for the thumnail URL when the public root URL wasn't even set. This was making ForeignAPIRepo not set it since it saw that it was already set. * Cleaned up and added some missing sanity checks for scriptDirUrl member in FileRepo. Made some related documentation tweaks. * Removed pointless getRepo() call in File. Peachey88's comment: Yes, well mainly the part about FU being lame and un-descriptive in a way, Can't contest to the latter part of that question. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r107016]: New comment added
GrafZahl posted a comment on MediaWiki.r107016. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107016#c28312 Commit summary for MediaWiki.r107016: Improved error reporting: * Altered ScoreException to accept error message parameters * Use error CSS for ScoreCallException * The error messages themselves have been made clearer GrafZahl's comment: Sure, but wouldn't that mean more work for the caller? Like codethrow ScoreException( wfMessage( 'score-foo' )-inContentLanguage()-params( $bar1, $bar2, $bar3 ) );/code every time an exception is thrown? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r107058]: Revision status changed
Aaron Schulz changed the status of MediaWiki.r107058 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107058 Old status: new New status: ok Commit summary for MediaWiki.r107058: bind temp file and purge after encoding to prevent deletion/race condition on the temp file name. follow up r106956 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r106956]: Revision status changed
Aaron Schulz changed the status of MediaWiki.r106956 to resolved URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106956 Old status: fixme New status: resolved Commit summary for MediaWiki.r106956: Encode videos in temp and only add to FileRepo once done. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r106459]: New comment added
Tim Starling posted a comment on MediaWiki.r106459. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106459#c28313 Commit summary for MediaWiki.r106459: Commit Lilypond replacement from https://github.com/TheCount/score See https://wikisource.org/w/index.php?title=Wikisource%3AScriptoriumaction=historysubmitdiff=323108oldid=323079 for original discussion. Tim Starling's comment: pre + $cmd = $wgLilyPond + . -dsafe='#t' -dbackend=eps --png --header=texidoc + . wfEscapeShellArg( $lilypondFile ) + . 21; // FIXME: This last bit is probably not portable /pre 21 is portable enough, it works in the CMD.EXE versions of Windows, which is all we support with wfEscapeShellArg(), and it works in UNIX as well. However the single quoting -dsafe='#t' is not portable, double quotes are required on Windows. Use wfEscapeShellArg( -dsafe=#t ). ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r107020]: Revision status changed
Tim Starling changed the status of MediaWiki.r107020 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107020 Old status: new New status: ok Commit summary for MediaWiki.r107020: FU r105512: urldecode() the file and thumb name in wfExtractThumbParams() for 404 handling as needed. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r107028]: Revision status changed
Tim Starling changed the status of MediaWiki.r107028 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107028 Old status: new New status: ok Commit summary for MediaWiki.r107028: * FU r106752: de-uglified Setup.php by moving most of the b/c code into FileBackendGroup. Deferred registration of file backends and lock managers to the respective singleton() functions for the group objects. * Refactored FileRepo::initZones() to require the specific zones; nothing was using it differently. * Removed deleted zone check in deleteBatch(), a similar error will instead trigger with the initZones() call as needed. * Added $wgLocalFileRepo comment. * Updated tests. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r106770]: Revision status changed
Tim Starling changed the status of MediaWiki.r106770 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106770 Old status: new New status: ok Commit summary for MediaWiki.r106770: FU r106752: unbreak other sizes links on File: pages by working around the suck /media system. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97022]: Revision status changed
Tim Starling changed the status of MediaWiki.r97022 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97022 Old status: new New status: ok Commit summary for MediaWiki.r97022: Possible fix for issue reported in r83762. I had a hard time confirming the problem/fix with profiling. Committing this now to get more attention. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r107054]: New comment added
Nikerabbit posted a comment on MediaWiki.r107054. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107054#c28314 Commit summary for MediaWiki.r107054: do not evaluate '?php' line This happen when you are sending to eval.php a php file. The first line is the string '?php' which is passed to eval(). Boom! This patch skip that string. Example usage: $ cat somefile.php ?php echo Working!\n; $ $ cat somefile.php | php maintenance/eval.php Working! $ Nikerabbit's comment: Can't you just make the first line '#?php' ? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r94881]: New comment added
Marooned posted a comment on MediaWiki.r94881. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94881#c28315 Commit summary for MediaWiki.r94881: Relative values of the Location header are incorrect as stated in RFC, however they do happen and modern browsers support them. This function loops backwards through all locations in order to build the proper absolute URI - Marooned at wikia-inc.com Marooned's comment: Found it - the site that at that time caused multiple redirections was: http://borntoolatevintage.com/ I can see it still does 2 redirects http://borntoolatevintage.com/ = http://www.artfire.com/users/BornTooLateVintage = http://www.artfire.com/ext/shop/studio/BornTooLateVintage though haven't checked if the latter is still relative or was changed into absolute. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r107016]: New comment added
Nikerabbit posted a comment on MediaWiki.r107016. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107016#c28316 Commit summary for MediaWiki.r107016: Improved error reporting: * Altered ScoreException to accept error message parameters * Use error CSS for ScoreCallException * The error messages themselves have been made clearer Nikerabbit's comment: Make it either one of these: #1 throw ScoreException( wfMessage( 'score-foo' )-params( $bar1, $bar2, $bar3 ) ); #2 throw ScoreException( wfMessage( 'score-foo, $bar1, $bar2, $bar3 ) ); You can do the -inContentLanguage() inside the exception. Then this isn't any more work for the caller compared to providing the message name and params separated. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r107056]: Revision status changed
Nikerabbit changed the status of MediaWiki.r107056 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107056 Old status: new New status: ok Commit summary for MediaWiki.r107056: Get the help link from messages based on content language. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r107057]: Revision status changed
Nikerabbit changed the status of MediaWiki.r107057 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107057 Old status: new New status: ok Commit summary for MediaWiki.r107057: Remove webfonts-help-page from resourceloader. Follow up r107056 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r94881]: New comment added
Hashar posted a comment on MediaWiki.r94881.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94881#c28317
Commit summary for MediaWiki.r94881:
Relative values of the Location header are incorrect as stated in RFC,
however they do happen and modern browsers support them.
This function loops backwards through all locations in order to build the
proper absolute URI - Marooned at wikia-inc.com
Hashar's comment:
By setting CURLOPT_HEADERFUNCTION we can pass any header to a callback:
$this-curlOptions[CURLOPT_HEADERFUNCTION] = array( $this, readHeader
);
The callback just append received header one after the other in a huge string.
It is then exploded by \r\n to an array.
protected function readHeader( $fh, $content ) {
$this-headerText .= $content;
return strlen( $content );
}
So internally, the Location: header content is really an array of any Location:
lines curl might have encountered while following redirections.
I have setup a testing env on my computer using existing virtual hosts and just
creating dummy PHP redirection files.
http://trunk.dev/redir.php redirects to tthttp://mw18.dev/redir.php/tt
http://mw18.dev/redir.php redirects to tt/landing.php/tt
h = MWHttpRequest::factory( 'http://trunk.dev/redir.php', array(
'followRedirects'=true) );
$h-execute();
print $h-getFinalUrl();
The header representation for 'location' is:
[location] = Array
(
[0] = http://mw18.dev/redir.php
[1] = /landing.php
)
So previously we would receive tt/landing.php/tt as a Location and one
could assume it is relative to the requested URL host (tttrunk.dev/tt)
whereas it is relative to the host of the previous URL having a host.
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r106948]: New comment added
Hashar posted a comment on MediaWiki.r106948. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106948#c28318 Commit summary for MediaWiki.r106948: tests for r94881 which interprets relative Location: headers Hashar's comment: Yeah it is a bit surprising to have multiple headers. A full explanation is at: https://www.mediawiki.org/wiki/Special:Code/MediaWiki/94881#c28317 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r107063]: New comment added
SPQRobin posted a comment on MediaWiki.r107063. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107063#c28319 Commit summary for MediaWiki.r107063: Include page content language so their fonts show up in the menu, per e-mail with Gerard and Santhosh. SPQRobin's comment: If it is deployed to 1.18wmf1, it needs the javascript variable wgPageContentLanguage which I added in r104483 (in a larger commit). ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r107063]: New comment added
Nikerabbit posted a comment on MediaWiki.r107063. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107063#c28320 Commit summary for MediaWiki.r107063: Include page content language so their fonts show up in the menu, per e-mail with Gerard and Santhosh. Nikerabbit's comment: Does it degrade gracefully if the config is not set? mw.config.get returns null in that case. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r107063]: New comment added
SPQRobin posted a comment on MediaWiki.r107063. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107063#c28321 Commit summary for MediaWiki.r107063: Include page content language so their fonts show up in the menu, per e-mail with Gerard and Santhosh. SPQRobin's comment: Yes, it seems to work correctly without wgPageContentLanguage. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r107065]: Revision status changed
Nikerabbit changed the status of MediaWiki.r107065 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107065 Old status: new New status: ok Commit summary for MediaWiki.r107065: Adding basic support for translatable workflow states. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r81074]: Revision status changed
Petrb changed the status of MediaWiki.r81074 to deferred
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/81074
Old status: new
New status: deferred
Commit summary for MediaWiki.r81074:
(bug 235) parser function for conversion of units of measurement.
[[Template:Convert]] on enwiki is a behemoth of a construction that just about
manages to do this sort of conversion, taking {{convert|5|mi|km}} and
outputting 5 miles (8 km), etc. To port this to another wiki requires
copying over three and a half thousand subtemplates. The additional load
produced by including numerous copies of this template is measurable on large
pages on enwiki, and it eats voraciously into the template limits.
This revision introduces {{#convert: 5 mi | km }}, outputting 8 km or
thereabouts. See http://www.mediawiki.org/wiki/User:Happy-melon/Convert for
more details, or look at the examples in the parser tests.
In a very rough profile, comparing 50 calls to {{convert}} verses the same 50
calls to the wrapper template shown at the link above, the parser function
implementation reduces page load time by 72%, preprocessor node count by 83%,
post-expand include size by 86% and template argument size by 97%. More
detailed profiling would probably reveal places where extra caching could
improve performance further.
The primary reason for putting it in ParserFunctions instead of its own
extension is availability: PFs are already available across the cluster, and
it's accepted as an essential extension for any wiki wishing to emulate or
mirror WMF content. One less separate extension installed on the cluster is
one less extension which has to be matched by reusers.
It's still missing a lot of units, which I ran out of patience to copy from
{{convert}}; I thought I'd get some feedback on the infrastructure first.
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r94421]: Revision status changed
Hashar changed the status of MediaWiki.r94421 to resolved URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94421 Old status: new New status: resolved Commit summary for MediaWiki.r94421: (bug 26283) Previewing user JS/CSS pages doesn't load other user JS/CSS pages ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r107067]: Revision status changed
Nikerabbit changed the status of MediaWiki.r107067 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107067 Old status: new New status: ok Commit summary for MediaWiki.r107067: Use ⌘ in for Mac keyboard shortcuts Looks better to the eye when playing with your User:foo/style.css http://en.wikipedia.org/wiki/Command_key ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r107066]: New comment added
Nikerabbit posted a comment on MediaWiki.r107066. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107066#c28322 Commit summary for MediaWiki.r107066: apply CSS::Janus when user preview its CSS style follow up r94421 Nikerabbit's comment: This doesn't cause any problems wrt the order the styles are loaded? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r107065]: New comment added
Siebrand posted a comment on MediaWiki.r107065. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107065#c28323 Commit summary for MediaWiki.r107065: Adding basic support for translatable workflow states. Siebrand's comment: I was wondering if we should maybe add basic workflow states (and translation) for them? Something like: in[ ]progress, needs[ ]updating, proofreading, ready, published?[https://meta.wikimedia.org/w/index.php?title=Template:Translate-status/Fundraising_2011/nlaction=edit] ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] Documentation on logging code
On 15 December 2011 00:46, Niklas Laxström niklas.laxst...@gmail.com wrote: On 14 December 2011 19:08, Daniel Barrett d...@vistaprint.com wrote: I also noticed the lack of documentation on LogPage so I just wrote this on mediawiki.org: http://www.mediawiki.org/wiki/Logging_to_Special:Log Other developers -- please fill in more detail if you like! That is the old way of doing logging. I'll try to find some time to document the new way too. Only took about a week! There is now something there that should be enough to get started. -Niklas -- Niklas Laxström ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r107051]: Revision status changed
Nikerabbit changed the status of MediaWiki.r107051 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107051 Old status: new New status: ok Commit summary for MediaWiki.r107051: Add a help link to WebFonts, pointing to mediawiki.org. i18n card #303 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r107063]: Revision status changed
Santhosh.thottingal changed the status of MediaWiki.r107063 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107063 Old status: new New status: ok Commit summary for MediaWiki.r107063: Include page content language so their fonts show up in the menu, per e-mail with Gerard and Santhosh. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r107054]: New comment added
Hashar posted a comment on MediaWiki.r107054. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107054#c28324 Commit summary for MediaWiki.r107054: do not evaluate '?php' line This happen when you are sending to eval.php a php file. The first line is the string '?php' which is passed to eval(). Boom! This patch skip that string. Example usage: $ cat somefile.php ?php echo Working!\n; $ $ cat somefile.php | php maintenance/eval.php Working! $ Hashar's comment: The file is also included,so you don't want to output # or whatever. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r100933]: New comment added
Hashar posted a comment on MediaWiki.r100933. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100933#c28325 Commit summary for MediaWiki.r100933: Quick and ugly fix to stop installs with CACHE_DB from immediately failing with DB errors. Something is wonked with the order of temp table creation. Hashar's comment: MediaWiki is sluggish without cache. So I would prefer keeping a basic level of caching, specially APC which is so easy to enable and fast. Or we could unconditionally setup a per process hash cache such as HashBagOStuff ? :D ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r107054]: New comment added
Nikerabbit posted a comment on MediaWiki.r107054. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107054#c28326 Commit summary for MediaWiki.r107054: do not evaluate '?php' line This happen when you are sending to eval.php a php file. The first line is the string '?php' which is passed to eval(). Boom! This patch skip that string. Example usage: $ cat somefile.php ?php echo Working!\n; $ $ cat somefile.php | php maintenance/eval.php Working! $ Nikerabbit's comment: Included where? What are you trying to do? Why not make them maintenance scripts? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r107068]: Revision status changed
Nikerabbit changed the status of MediaWiki.r107068 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107068 Old status: new New status: ok Commit summary for MediaWiki.r107068: fix case of addInLineScript Use the correct case wich is: addInlineScript Follow r95435 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95435]: New comment added, and revision status changed
Hashar changed the status of MediaWiki.r95435 to new and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95435#c28327 Old Status: fixme New Status: new Commit summary for MediaWiki.r95435: add inline comments to the diff output This patch rely on various previous revisions made to the CodeRevision extension. It is mostly experimental, but there is an easy way to disable it (will need to write a patch for this later so we use a global variable like $wgEnableInlineComments). To use it, simply click on a diff line to have a comment box opening. Stuff that need fixing: * the comment box is inserted above previous comments to a given line * anonymous user (or people without the correct rights) will be show the comment although the API did not save it in the DB. This is a bug in the API code : it does not check the correct right and/or does not return an error message if the comment was not inserted. * Someone without the correct right should not be able to add a comment * API call returns an HTML formatted comment, might be unneeded sometime * JavaScript not reviewed for performance * Not reviewed for security A patch will come later on to easily disable this feature. Hashar's comment: Here are the fixes: r107068 : fix case r107069 : I have not found a resource loader method to register a ready() event. So I just wrapped the initializer in a $(document).ready() call. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] Making the Lua/Javascript decision (Re: Performance roadmap update)
- Original Message - From: Peter Kaminski kamin...@istori.com I don't have anything particular against Lua and no particular love for JavaScript, but JS seems more web-native; plus code and skills developed can accrue to both client- and server-side of the web. Just so I'm clear: this is a server-side question? Cause if it's client side, JS is already in the browser seems pretty compelling to me... Cheers, -- jra -- Jay R. Ashworth Baylink j...@baylink.com Designer The Things I Think RFC 2100 Ashworth Associates http://baylink.pitas.com 2000 Land Rover DII St Petersburg FL USA http://photo.imageinc.us +1 727 647 1274 ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r100933]: New comment added
^demon posted a comment on MediaWiki.r100933. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100933#c28328 Commit summary for MediaWiki.r100933: Quick and ugly fix to stop installs with CACHE_DB from immediately failing with DB errors. Something is wonked with the order of temp table creation. ^demon's comment: The shared memory caches (like APC) are useless on the command line, see bug 28752 and related discussions. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r100933]: New comment added
Nikerabbit posted a comment on MediaWiki.r100933. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100933#c28329 Commit summary for MediaWiki.r100933: Quick and ugly fix to stop installs with CACHE_DB from immediately failing with DB errors. Something is wonked with the order of temp table creation. Nikerabbit's comment: It's not totally useless, APC can be enabled for CLI mode too, and as far as I know it uses the same cache as for web requests so it should be fine. However this is not the default configuration. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r107071]: New comment added
Siebrand posted a comment on MediaWiki.r107071. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107071#c28330 Commit summary for MediaWiki.r107071: r107056: This key is optinal for translatewiki.net Siebrand's comment: Please make it ignored. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95680]: New comment added
Hashar posted a comment on MediaWiki.r95680. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95680#c28331 Commit summary for MediaWiki.r95680: (bug 30617) inline comments forms cannot be closed On clicking a line, a javascript insert a tr element containg the form. That tr did not get an unique id which caused troubles when opening multiples inline comments. This patch forge an id based on the diff line it applies to which should be unique since we only allow one comment form per line. Hashar's comment: I do not understand how an attacker can take advantage of this for cross site scripting. The line id is generated by the PHP script. One would have to change the id using javascript, which mean it could already inject whatever it wants anywhere. Anyway, I got a follow up change to make sure the line id is an integer :-) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95680]: Revision status changed
Hashar changed the status of MediaWiki.r95680 to new URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95680 Old status: fixme New status: new Commit summary for MediaWiki.r95680: (bug 30617) inline comments forms cannot be closed On clicking a line, a javascript insert a tr element containg the form. That tr did not get an unique id which caused troubles when opening multiples inline comments. This patch forge an id based on the diff line it applies to which should be unique since we only allow one comment form per line. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r107074]: New comment added
Hashar posted a comment on MediaWiki.r107074. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107074#c28332 Commit summary for MediaWiki.r107074: make sure the line ID is an integer before injecting it Might prevents a CSS attack of some sort. I am not an expert on this topic. That follow up Tim CR on r95690. Hashar's comment: It follow up r95680 (eighty, not ninety). ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
