Re: [PATCH] VMX: no open-coding in vmx_get_cpl()

2024-04-25 Thread Andrew Cooper 
On 25/04/2024 2:27 pm, Jan Beulich wrote:
> Neither X86_SEG_AR_DPL nor MASK_EXTR() should really be avoided here,
> using literal number instead.
>
> No difference in generated code (with gcc13 at least).
>
> Signed-off-by: Jan Beulich 

Acked-by: Andrew Cooepr

[PATCH] VMX: no open-coding in vmx_get_cpl()

2024-04-25 Thread Jan Beulich 
Neither X86_SEG_AR_DPL nor MASK_EXTR() should really be avoided here,
using literal number instead.

No difference in generated code (with gcc13 at least).

Signed-off-by: Jan Beulich 

--- a/xen/arch/x86/hvm/vmx/vmx.c
+++ b/xen/arch/x86/hvm/vmx/vmx.c
@@ -1192,7 +1192,7 @@ unsigned int vmx_get_cpl(void)
 
 __vmread(GUEST_SS_AR_BYTES, );
 
-return (attr >> 5) & 3;
+return MASK_EXTR(attr, X86_SEG_AR_DPL);
 }
 
 static unsigned int cf_check _vmx_get_cpl(struct vcpu *v)