Re: [PATCH] arm/vpci: make prefetchable mem 64 bit
Hi Stewart, > On 24 Apr 2024, at 5:27 PM, Stewart Hildebrand > wrote: > > The vPCI prefetchable memory range is >= 4GB, so the memory space flags > should be set to 64-bit. See IEEE Std 1275-1994 [1] for a definition of > the field. > > [1] https://www.devicetree.org/open-firmware/bindings/pci/pci2_1.pdf > > Signed-off-by: Stewart Hildebrand Reviewed-by: Rahul Singh Regards, Rahul
Re: [PATCH] arm/vpci: make prefetchable mem 64 bit
Hi Stewart, On 24/04/2024 18:27, Stewart Hildebrand wrote: > The vPCI prefetchable memory range is >= 4GB, so the memory space flags > should be set to 64-bit. See IEEE Std 1275-1994 [1] for a definition of NIT: would be beneficial to provide chapter (in this case 2.2.1.1) > the field. > > [1] https://www.devicetree.org/open-firmware/bindings/pci/pci2_1.pdf > > Signed-off-by: Stewart Hildebrand Acked-by: Michal Orzel ~Michal > --- > xen/include/public/arch-arm.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/xen/include/public/arch-arm.h b/xen/include/public/arch-arm.h > index e167e14f8df9..289af81bd69d 100644 > --- a/xen/include/public/arch-arm.h > +++ b/xen/include/public/arch-arm.h > @@ -487,7 +487,7 @@ typedef uint64_t xen_callback_t; > #define GUEST_RAM0_SIZE xen_mk_ullong(0xc000) > > /* 4GB @ 4GB Prefetch Memory for VPCI */ > -#define GUEST_VPCI_ADDR_TYPE_PREFETCH_MEM xen_mk_ullong(0x4200) > +#define GUEST_VPCI_ADDR_TYPE_PREFETCH_MEM xen_mk_ullong(0x4300) > #define GUEST_VPCI_PREFETCH_MEM_ADDRxen_mk_ullong(0x1) > #define GUEST_VPCI_PREFETCH_MEM_SIZExen_mk_ullong(0x1) > > > base-commit: 410ef3343924b5a3928bbe8e392491992b322cf0
[PATCH] arm/vpci: make prefetchable mem 64 bit
The vPCI prefetchable memory range is >= 4GB, so the memory space flags should be set to 64-bit. See IEEE Std 1275-1994 [1] for a definition of the field. [1] https://www.devicetree.org/open-firmware/bindings/pci/pci2_1.pdf Signed-off-by: Stewart Hildebrand --- xen/include/public/arch-arm.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/include/public/arch-arm.h b/xen/include/public/arch-arm.h index e167e14f8df9..289af81bd69d 100644 --- a/xen/include/public/arch-arm.h +++ b/xen/include/public/arch-arm.h @@ -487,7 +487,7 @@ typedef uint64_t xen_callback_t; #define GUEST_RAM0_SIZE xen_mk_ullong(0xc000) /* 4GB @ 4GB Prefetch Memory for VPCI */ -#define GUEST_VPCI_ADDR_TYPE_PREFETCH_MEM xen_mk_ullong(0x4200) +#define GUEST_VPCI_ADDR_TYPE_PREFETCH_MEM xen_mk_ullong(0x4300) #define GUEST_VPCI_PREFETCH_MEM_ADDRxen_mk_ullong(0x1) #define GUEST_VPCI_PREFETCH_MEM_SIZExen_mk_ullong(0x1) base-commit: 410ef3343924b5a3928bbe8e392491992b322cf0 -- 2.43.2