Re: [PATCH v2 1/7] x86/p2m: Add braces for better code clarity

[Jan Beulich]

On 29.04.2024 12:26, Petr Beneš wrote:
> On Mon, Apr 29, 2024 at 9:07 AM Jan Beulich  wrote:
>>
>> On 28.04.2024 18:52, Petr Beneš wrote:
>>> From: Petr Beneš 
>>>
>>> No functional change.
>>>
>>> Signed-off-by: Petr Beneš 
>>
>> Where did Stefano's R-b go?
> 
> Oh no, I missed that one. Should I do v3?

Not just for this, I'd say. Just don't forget it again, if the patch needs
re-posting.

Jan

Re: [PATCH v2 1/7] x86/p2m: Add braces for better code clarity

[Petr Beneš]

On Mon, Apr 29, 2024 at 9:07 AM Jan Beulich  wrote:
>
> On 28.04.2024 18:52, Petr Beneš wrote:
> > From: Petr Beneš 
> >
> > No functional change.
> >
> > Signed-off-by: Petr Beneš 
>
> Where did Stefano's R-b go?
>
> Jan

Oh no, I missed that one. Should I do v3?

Re: [PATCH v2 1/7] x86/p2m: Add braces for better code clarity

[Jan Beulich]

On 28.04.2024 18:52, Petr Beneš wrote:
> From: Petr Beneš 
> 
> No functional change.
> 
> Signed-off-by: Petr Beneš 

Where did Stefano's R-b go?

Jan

[PATCH v2 1/7] x86/p2m: Add braces for better code clarity

[Petr Beneš]

From: Petr Beneš 

No functional change.

Signed-off-by: Petr Beneš 
---
 xen/arch/x86/mm/p2m.c | 4 
 1 file changed, 4 insertions(+)

diff --git a/xen/arch/x86/mm/p2m.c b/xen/arch/x86/mm/p2m.c
index ce742c12e0..eb7996170d 100644
--- a/xen/arch/x86/mm/p2m.c
+++ b/xen/arch/x86/mm/p2m.c
@@ -106,6 +106,7 @@ void p2m_change_entry_type_global(struct domain *d,
 unsigned int i;
 
 for ( i = 0; i < MAX_ALTP2M; i++ )
+{
 if ( d->arch.altp2m_eptp[i] != mfn_x(INVALID_MFN) )
 {
 struct p2m_domain *altp2m = d->arch.altp2m_p2m[i];
@@ -114,6 +115,7 @@ void p2m_change_entry_type_global(struct domain *d,
 change_entry_type_global(altp2m, ot, nt);
 p2m_unlock(altp2m);
 }
+}
 }
 
 p2m_unlock(hostp2m);
@@ -139,6 +141,7 @@ void p2m_memory_type_changed(struct domain *d)
 unsigned int i;
 
 for ( i = 0; i < MAX_ALTP2M; i++ )
+{
 if ( d->arch.altp2m_eptp[i] != mfn_x(INVALID_MFN) )
 {
 struct p2m_domain *altp2m = d->arch.altp2m_p2m[i];
@@ -147,6 +150,7 @@ void p2m_memory_type_changed(struct domain *d)
 _memory_type_changed(altp2m);
 p2m_unlock(altp2m);
 }
+}
 }
 
 p2m_unlock(hostp2m);
-- 
2.34.1