Re: [XEN PATCH v1 6/7] x86/MCE: guard call to Intel-specific intel_get_extended_msrs()
On 27.04.2024 01:14, Stefano Stabellini wrote: > On Tue, 23 Apr 2024, Sergiy Kibrik wrote: >> Add check for CONFIG_INTEL build option to conditional call of this routine, >> so that if Intel support is disabled the call would be eliminated. >> >> No functional change intended. >> >> Signed-off-by: Sergiy Kibrik > > Reviewed-by: Stefano Stabellini Acked-by: Jan Beulich Aiui this doesn't depend on earlier patches and hence could go in right away. Jan
Re: [XEN PATCH v1 6/7] x86/MCE: guard call to Intel-specific intel_get_extended_msrs()
On Tue, 23 Apr 2024, Sergiy Kibrik wrote: > Add check for CONFIG_INTEL build option to conditional call of this routine, > so that if Intel support is disabled the call would be eliminated. > > No functional change intended. > > Signed-off-by: Sergiy Kibrik Reviewed-by: Stefano Stabellini
[XEN PATCH v1 6/7] x86/MCE: guard call to Intel-specific intel_get_extended_msrs()
Add check for CONFIG_INTEL build option to conditional call of this routine, so that if Intel support is disabled the call would be eliminated. No functional change intended. Signed-off-by: Sergiy Kibrik --- xen/arch/x86/cpu/mcheck/mce.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/xen/arch/x86/cpu/mcheck/mce.c b/xen/arch/x86/cpu/mcheck/mce.c index 42e84e76b7..de2e16a6e2 100644 --- a/xen/arch/x86/cpu/mcheck/mce.c +++ b/xen/arch/x86/cpu/mcheck/mce.c @@ -328,7 +328,8 @@ mcheck_mca_logout(enum mca_source who, struct mca_banks *bankmask, ASSERT(mig); mca_init_global(mc_flags, mig); /* A hook here to get global extended msrs */ -if ( boot_cpu_data.x86_vendor == X86_VENDOR_INTEL ) +if ( IS_ENABLED(CONFIG_INTEL) && + boot_cpu_data.x86_vendor == X86_VENDOR_INTEL ) intel_get_extended_msrs(mig, mci); } } -- 2.25.1
