[389-devel] Re: Review process suggestion

On 03/20/2017 02:47 AM, William Brown wrote: Hi all, I've noticed that sometimes during the review process that the following happens: Europe Afternoon: code is posted to review. America Morning: code is acked Europe Afternoon: code is merged Australian Morning: "I have this comment, but the

[389-devel] Re: Discuss: local vs remote be flag

Hi William, A couple of questions (as usual... :) On 02/26/2017 03:51 PM, William Brown wrote: Hi, I think that we should have a flag of a backend as local or remote for DS. Does the remote backend mean the referral and/or the chaining backend? Or could there be more? The reason for this

[389-devel] Re: Q. on lib389 Re: Please review: #49121 ns-slapd crashes in ldif_sput due to the output buf size is less than the real size.

On 02/13/2017 08:51 AM, Lukas Slebodnik wrote: On (13/02/17 08:38), Noriko Hosoi wrote: On 02/12/2017 06:14 PM, William Brown wrote: On Sun, 2017-02-12 at 17:42 -0800, Noriko Hosoi wrote: On 02/12/2017 03:51 PM, Noriko Hosoi wrote: https://pagure.io/389-ds-base/issue/49121 https://pagure.io

[389-devel] Another Q. on pagure issue page: Please review: #49121 ns-slapd crashes in ldif_sput due to the output buf size is less than the real size.

Hi, it might be a known issue, but ... When we have multiple links in, e.g., rhbz, what is the right way to list them? Separated with ' ' does not work. It's considered one url, instead of 2, and it does not jump to the bug by clicking it... ***rhbz*

[389-devel] Re: Q. on lib389 Re: Please review: #49121 ns-slapd crashes in ldif_sput due to the output buf size is less than the real size.

On 02/12/2017 06:14 PM, William Brown wrote: On Sun, 2017-02-12 at 17:42 -0800, Noriko Hosoi wrote: On 02/12/2017 03:51 PM, Noriko Hosoi wrote: https://pagure.io/389-ds-base/issue/49121 https://pagure.io/389-ds-base/issue/raw/files

[389-devel] Q. on lib389 Re: Please review: #49121 ns-slapd crashes in ldif_sput due to the output buf size is less than the real size.

On 02/12/2017 03:51 PM, Noriko Hosoi wrote: https://pagure.io/389-ds-base/issue/49121 https://pagure.io/389-ds-base/issue/raw/files/d857ff4919940bcebeae870774896783f7b6e86ce08a2c2e924610ac2335f8de-0001-Ticket-49121-ns-slapd-crashes-in-ldif_sput-due-to-th.patch These odd » characters are shown

[389-devel] Please review: #49121 ns-slapd crashes in ldif_sput due to the output buf size is less than the real size.

https://pagure.io/389-ds-base/issue/49121 https://pagure.io/389-ds-base/issue/raw/files/d857ff4919940bcebeae870774896783f7b6e86ce08a2c2e924610ac2335f8de-0001-Ticket-49121-ns-slapd-crashes-in-ldif_sput-due-to-th.patch These odd » characters are shown at some part of the patch. I wonder what

[389-devel] Please review: [389 Project] #49104: dbscan-bin crashing due to a segmentation fault.

https://fedorahosted.org/389/ticket/49104 https://fedorahosted.org/389/attachment/ticket/49104/0001-Ticket-49104-dbscan-bin-crashing-due-to-a-segmentati.patch https://fedorahosted.org/389/attachment/ticket/49104/0002-Ticket-49104-Add-CI-test.patch git patch file (master) -- CI test

[389-devel] Please review: [389 Project] #49088: 389-ds-base rpm postinstall script bugs

https://fedorahosted.org/389/ticket/49088 https://fedorahosted.org/389/attachment/ticket/49088/0001-Ticket-49088-389-ds-base-rpm-postinstall-script-bugs.patch ___ 389-devel mailing list -- 389-devel@lists.fedoraproject.org To unsubscribe send an email

[389-devel] Re: Urgent review: 49041 ssl fails to start on f24

On 11/17/2016 12:25 PM, Rob Crittenden wrote: Noriko Hosoi wrote: On 11/17/2016 11:22 AM, Rob Crittenden wrote: Noriko Hosoi wrote: On 11/17/2016 06:36 AM, Rob Crittenden wrote: William Brown wrote: https://fedorahosted.org/389/ticket/49041 https://fedorahosted.org/389/attachment/ticket

[389-devel] Re: Urgent review: 49041 ssl fails to start on f24

On 11/17/2016 11:22 AM, Rob Crittenden wrote: Noriko Hosoi wrote: On 11/17/2016 06:36 AM, Rob Crittenden wrote: William Brown wrote: https://fedorahosted.org/389/ticket/49041 https://fedorahosted.org/389/attachment/ticket/49041/0001-Ticket-49041-SSL-fails-to-start-due-to-NSS-db-versio.patch

[389-devel] Re: Urgent review: 49041 ssl fails to start on f24

On 11/17/2016 06:36 AM, Rob Crittenden wrote: William Brown wrote: https://fedorahosted.org/389/ticket/49041 https://fedorahosted.org/389/attachment/ticket/49041/0001-Ticket-49041-SSL-fails-to-start-due-to-NSS-db-versio.patch I think this should be reviewed urgently and backported. This can

[389-devel] Re: Please review design proposal for tickets 47986 and 48976

Hi Ludwig, On 09/29/2016 05:43 AM, Ludwig Krispenz wrote: This is the initial proposal, thanks for your feedback http://www.port389.org/docs/389ds/design/delay-accepting-updates-after-init.html Please help me understanding the design... I'm having a bit hard time to figure out the

[389-devel] Re: Please review: Fix warnings Wstrict prototypes

On 09/04/2016 07:12 PM, William Brown wrote: On Sat, 2016-09-03 at 18:07 +0200, Lukas Slebodnik wrote: ehlo, https://fedorahosted.org/389/ticket/48979 The 1st 16 patches are preparation for a last huge patch which uses "(void)" for functions which does not expect any arguments. I have

[389-devel] Please review: [389 Project] #48967: passwordMinAge attribute doesn't limit the minimum age of the password

https://fedorahosted.org/389/ticket/48967 https://fedorahosted.org/389/attachment/ticket/48967/0001-Ticket-48967-passwordMinAge-attribute-doesn-t-limit-.patch -- 389-devel mailing list 389-devel@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/389-devel@lists.fedoraproject.org

[389-devel] Please review: [389 Project] #48943: When fine-grained policy is applied, a sub-tree has a priority over a user while changing password

https://fedorahosted.org/389/ticket/48943 https://fedorahosted.org/389/attachment/ticket/48943/0001-Ticket-48943-When-fine-grained-policy-is-applied-a-s.patch Note: Once this patch is applied, the test case provided by Simon passes. *Attachment*

[389-devel] Please review (take 2): [389 Project] #48936: Duplicate collation entries

https://fedorahosted.org/389/ticket/48936 https://fedorahosted.org/389/attachment/ticket/48936/0001-Ticket-48936-Duplicate-collation-entries.patch git patch file (master) -- revised based upon the comment by Rich (Thanks!) -- 389-devel mailing list 389-devel@lists.fedoraproject.org

[389-devel] Please review (take 2): [389 Project] #48939: nsslapd-workingdir is empty when ns-slapd is started by systemd

https://fedorahosted.org/389/ticket/48939 https://fedorahosted.org/389/attachment/ticket/48939/0001-Ticket-48939-nsslapd-workingdir-is-empty-when-ns-sla.2.patch Description: Thanks to tbor...@redhat.com for suggesting to reset the working dir in the error cases. I've added more error checks

[389-devel] Please review: [389 Project] #48933: drop support for legacy replication - need to clean code

https://fedorahosted.org/389/ticket/48933 https://fedorahosted.org/389/attachment/ticket/48933/0001-Ticket-48933-drop-support-for-legacy-replication-nee.patch -- 389-devel mailing list 389-devel@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/389-devel@lists.fedoraproject.org

[389-devel] Please review: [389 Project] #47413: 389-admin fails to build with latest httpd

https://fedorahosted.org/389/ticket/47413 https://fedorahosted.org/389/attachment/ticket/47413/0001-Ticket-47413-389-admin-fails-to-build-with-latest-ht.2.patch -- 389-devel mailing list 389-devel@lists.fedoraproject.org

[389-devel] Please review: [389 Project] #48914: db2bak.pl task enters infinitive loop when bak fs is almost full

https://fedorahosted.org/389/ticket/48914 https://fedorahosted.org/389/attachment/ticket/48914/0001-Ticket-48914-db2bak.pl-task-enters-infinitive-loop-w.patch -- 389-devel mailing list 389-devel@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/389-devel@lists.fedoraproject.org

[389-devel] Please review: [389 Project] #48899: Values of dbcachetries/dbcachehits in cn=monitor could overflow.

https://fedorahosted.org/389/ticket/48899 https://fedorahosted.org/389/attachment/ticket/48899/0001-Ticket-48899-Values-of-dbcachetries-dbcachehits-in-c.patch -- 389-devel mailing list 389-devel@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/389-devel@lists.fedoraproject.org

[389-devel] Please review: [389 Project] #48896: Default Setting for passwordMinTokenLength does not work

https://fedorahosted.org/389/ticket/48896 https://fedorahosted.org/389/attachment/ticket/48896/0001-Ticket-48896-Default-Setting-for-passwordMinTokenLen.patch https://fedorahosted.org/389/attachment/ticket/48896/0002-Ticket-48896-CI-test-test-case-for-ticket-48896.patch -- 389-devel mailing

[389-devel] Re: Please review (additional fixes): [389 Project] #48755: moving an entry could make the online init fail

On 06/17/2016 08:49 AM, Ludwig Krispenz wrote: On 06/17/2016 05:31 PM, Noriko Hosoi wrote: On 06/17/2016 12:17 AM, Ludwig Krispenz wrote: Hi Noriko, I still have a doubt on your fix. You now base the entries to be sent only on the parentid index, but when creating a tombstone, the entry

[389-devel] Re: Please review (additional fixes): [389 Project] #48755: moving an entry could make the online init fail

.. Continue looking into it... Thanks, --noriko Ludwig On 06/17/2016 03:05 AM, Noriko Hosoi wrote: https://fedorahosted.org/389/ticket/48755 https://fedorahosted.org/389/attachment/ticket/48755/0001-Ticket-48755-moving-an-entry-could-make-the-online-i.3.patch git patch file (master) -- additional fix

[389-devel] Please review: 3 tickets 48234, 48848, and 48833

*https://fedorahosted.org/389/ticket/48234* #48234: "matching rules" in ACI's "bind rules not fully evaluated https://fedorahosted.org/389/attachment/ticket/48234/0001-Ticket-48234-matching-rules-in-ACI-s-bind-rules-not-.patch git patch file (master)

[389-devel] Please review: [389 Project] #48848: modrdn deleteoldrdn can fail to find old attribute value, perhaps due to case folding

https://fedorahosted.org/389/ticket/48848 https://fedorahosted.org/389/attachment/ticket/48848/0001-Ticket-48848-modrdn-deleteoldrdn-can-fail-to-find-ol.patch -- 389-devel mailing list 389-devel@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/389-devel@lists.fedoraproject.org

[389-devel] Verified: Re: Q. on RDN with CES type

I verified the behavior. Our dn normalization has a problem for CES types. --noriko On 06/06/2016 02:52 PM, Noriko Hosoi wrote: Hello, I'm working on this ticket 48848. Fixing the ticket itself is easy (please see the proposed patch). https://fedorahosted.org/389/ticket/48848 Ticket

[389-devel] Q. on RDN with CES type

Hello, I'm working on this ticket 48848. Fixing the ticket itself is easy (please see the proposed patch). https://fedorahosted.org/389/ticket/48848 Ticket #48848 - modrdn deleteoldrdn can fail to find old attribute value, perhaps due to case

[389-devel] Re: Please review/comment: [389 Project] #48833: 389 showing inconsistent values for shadowMax and shadowWarning in 1.3.5.1

Thanks for your comments, William. On 05/31/2016 07:22 PM, William Brown wrote: On Tue, 2016-05-31 at 17:48 -0700, Noriko Hosoi wrote: https://fedorahosted.org/389/ticket/48833 There are 2 proposals. I'd like to have your thoughts which one would be preferable. https://fedorahosted.org/389

[389-devel] Please review (take 2): [389 Project] #48755: moving an entry could make the online init fail

https://fedorahosted.org/389/ticket/48755 https://fedorahosted.org/389/attachment/ticket/48755/0001-Ticket-48755-moving-an-entry-could-make-the-online-i.2.patch git patch file (master) -- eliminated a config param nsds5SortedTotalUpdate Changes made since the previous patch . a config param

[389-devel] Please review: [389 Project] #48834: Modifier's name is not recorded in the audit log with modrdn and moddn operations

https://fedorahosted.org/389/ticket/48834 https://fedorahosted.org/389/attachment/ticket/48834/0001-Ticket-48834-Modifier-s-name-is-not-recorded-in-the-.patch -- 389-devel mailing list 389-devel@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/389-devel@lists.fedoraproject.org

[389-devel] Please review: [389 Project] #48755: moving an entry could make the online init fail

https://fedorahosted.org/389/ticket/48755 https://fedorahosted.org/389/attachment/ticket/48755/0001-Ticket-48755-moving-an-entry-could-make-the-online-i.patch https://fedorahosted.org/389/attachment/ticket/48755/0002-Ticket-48755-CI-test-test-case-for-ticket-48755.patch -- 389-devel mailing

[389-devel] Please review (take 2): [389 Project] #48816: (1.2.11 only) add a nsTLS1.0 on or off new configuration parameter to cn=encryption, cn=config in RHEL 6 389-ds-base

https://fedorahosted.org/389/ticket/48816 https://fedorahosted.org/389/attachment/ticket/48816/0001-Ticket-48816-1.2.11-only-add-a-nsTLS1.0-on-or-off-ne.3.patch git patch file (master) -- revised based upon the comments by William and Ludwig (Thanks!) -- 389-devel mailing list

[389-devel] Please review: [389 Project] #48144: Add /usr/sbin/status-dirsrv script to get the status of the directory server instance.

https://fedorahosted.org/389/ticket/48144 https://fedorahosted.org/389/attachment/ticket/48144/0001-Ticket-48144-Add-usr-sbin-status-dirsrv-script-to-ge.2.patch git patch file (master) -- additional enhancement for the exit code -- 389-devel mailing list 389-devel@lists.fedoraproject.org

[389-devel] Please review: [389 Project] #48822: (389-ds-base-1.3.5) Fixing coverity issues.

https://fedorahosted.org/389/ticket/48822 https://fedorahosted.org/389/attachment/ticket/48822/0001-Ticket-48822-389-ds-base-1.3.5-Fixing-coverity-issue.patch git patch file (master) -- DEADCODE

[389-devel] Please review (resent): [389 Project] #48808: Paged results search returns the blank list of entries

On 04/28/2016 12:12 PM, Noriko Hosoi wrote: https://fedorahosted.org/389/ticket/48808 https://fedorahosted.org/389/attachment/ticket/48808/0001-Ticket-48808-Paged-results-search-returns-the-blank-.patch -- 389-devel mailing list 389-devel@lists.fedoraproject.org http

[389-devel] Please review: [389 Project] #48811: Console window could be hidden after login via consoles on multiple hosts

https://fedorahosted.org/389/ticket/48811 https://fedorahosted.org/389/attachment/ticket/48811/0001-Ticket-48811-Console-window-could-be-hidden-after-lo.patch -- 389-devel mailing list 389-devel@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/389-devel@lists.fedoraproject.org

[389-devel] Please review: [389 Project] #48429: running remove-ds-admin.pl multiple times will make it so you cannot install DS

https://fedorahosted.org/389/ticket/4842 https://fedorahosted.org/389/attachment/ticket/48429/0001-Ticket-48429-running-remove-ds-admin.pl-multiple-tim.patch -- 389-devel mailing list 389-devel@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/389-devel@lists.fedoraproject.org

[389-devel] Please review: [389 Project] #48410: Unable to remove / unregister a DS instance from admin server

https://fedorahosted.org/389/ticket/48410 https://fedorahosted.org/389/attachment/ticket/48410/0001-Ticket-48410-389-admin-Unable-to-remove-unregister-a.patch git patch file (389-admin master)

[389-devel] Please review: [389 Project] #48409: RHDS upgrade change Ownership of certificate files upon upgrade.

https://fedorahosted.org/389/ticket/48409 https://fedorahosted.org/389/attachment/ticket/48409/0001-Ticket-48409-RHDS-upgrade-change-Ownership-of-certif.patch -- 389-devel mailing list 389-devel@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/389-devel@lists.fedoraproject.org

[389-devel] Please review: [389 Project] #48802: Compilation warnings from clang

https://fedorahosted.org/389/ticket/48802 https://fedorahosted.org/389/attachment/ticket/48802/0001-Ticket-48802-Compilation-warnings-from-clang.patch -- 389-devel mailing list 389-devel@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/389-devel@lists.fedoraproject.org

[389-devel] Please review: [389 Project] #48799: objectclass values could be dropped on the consumer

https://fedorahosted.org/389/ticket/48799 https://fedorahosted.org/389/attachment/ticket/48799/0001-Ticket-48799-objectclass-values-could-be-dropped-on-.patch -- 389-devel mailing list 389-devel@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/389-devel@lists.fedoraproject.org

[389-devel] Please review (take n+1): [389 Project] #47536: Allow usage of OpenLDAP libraries that don't use NSS for crypto

https://fedorahosted.org/389/ticket/47536 https://fedorahosted.org/389/attachment/ticket/47536/0001-Ticket-47536-Allow-usage-of-OpenLDAP-libraries-that-.patch git patch file (master) -- another revision -- instead of checking with "OpenSSL", check with "Not MozNSS" for non-Fedora/RHEL platforms

[389-devel] Re: Please review, svrcore fix coverity issues 6 through 10

On 04/11/2016 10:30 PM, William Brown wrote: https://pagure.io/svrcore/pull-request/11 Patch bundle to fix coverity issues discovered during build processes. -- 389-devel mailing list 389-devel@%(host_name)s http://lists.fedoraproject.org/admin/lists/389-devel@lists.fedoraproject.org Maybe,

[389-devel] Please review: 3 tickets -- #47536, #48492, #48784

1. https://fedorahosted.org/389/ticket/47536 https://fedorahosted.org/389/attachment/ticket/47536/0001-Ticket-47536-Allow-usage-of-OpenLDAP-libraries-that-.patch git patch file (master)

[389-devel] Please review (Take 2): [389 Project] #48784: Make the SSL version set to the client library configurable.

https://fedorahosted.org/389/ticket/48784 https://fedorahosted.org/389/attachment/ticket/48784/0001-Ticket-48784-Make-the-SSL-version-set-to-the-client-.patch git patch file (master) -- revised based upon the reviews by William (Thanks!) * Fixed a typo in an error message. * Changed the

[389-devel] Please review: [389 Project] #48775: If nsSSL3 is on, even if SSL v3 is not really enabled, a confusing message is logged.

https://fedorahosted.org/389/ticket/48775 https://fedorahosted.org/389/attachment/ticket/48775/0001-Ticket-48775-If-nsSSL3-is-on-even-if-SSL-v3-is-not-r.patch -- 389-devel mailing list 389-devel@%(host_name)s http://lists.fedoraproject.org/admin/lists/389-devel@lists.fedoraproject.org

[389-devel] Please review (take 2): [389 Project] #48784: Make the SSL version set to the client library configurable.

https://fedorahosted.org/389/ticket/48784 https://fedorahosted.org/389/attachment/ticket/48784/0001-Ticket-48784-Make-the-SSL-version-set-to-the-client-.patch git patch file (master) -- revised based upon the reviews by William (Thanks!) -- 389-devel mailing list 389-devel@%(host_name)s

[389-devel] Please review: [389 Project] #48492: heap corruption at schema replication.

https://fedorahosted.org/389/ticket/48492 https://fedorahosted.org/389/attachment/ticket/48492/0001-Ticket-48492-heap-corruption-at-schema-replication.3.patch git patch file (master) -- revised so that the nsslapd-enquote-sup-oc info is passed to openldap parser. -- 389-devel mailing list

[389-devel] Please advice: [389 Project] #48760: NSS -- switching to the sql db

Hello, We hear quite often that the key/cert db's RHDS is using are in the old format and have been suggested to switch to the sql db. It turned out it is quite easy although there is one minor issue I described in the comment in the patch *[*]*. But as long as we use "sql:path" to access

[389-devel] Please review: [389 Project] #48757: License tag does not match actual license of code

https://fedorahosted.org/389/ticket/48757 https://fedorahosted.org/389/attachment/ticket/48757/0001-Ticket-48757-License-tag-does-not-match-actual-licen.patch -- 389-devel mailing list 389-devel@%(host_name)s http://lists.fedoraproject.org/admin/lists/389-devel@lists.fedoraproject.org

[389-devel] Re: [389-commits] wrappers/systemd.template.service.in

On 02/29/2016 11:01 AM, Lukas Slebodnik wrote: On (29/02/16 18:43), Noriko Hosoi wrote: wrappers/systemd.template.service.in |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 1e2cfe2ea4ebc7ac31f292bf0076cc1befd15a78 Author: Viktor Ashirov <vashi...@redhat.com>

[389-devel] Please review: [389 Project] #48492: heap corruption at schema replication.

https://fedorahosted.org/389/ticket/48492 https://fedorahosted.org/389/attachment/ticket/48492/0001-Ticket-48492-heap-corruption-at-schema-replication.2.patch git patch file (master) -- ignore nsslapd-enquote-sup-oc -- 389-devel mailing list 389-devel@%(host_name)s

[389-devel] Please review: [389 Project] #48662: db2index with no attribute args fail.

https://fedorahosted.org/389/ticket/48662 https://fedorahosted.org/389/attachment/ticket/48662/0001-Ticket-48662-db2index-with-no-attribute-args-fail.patch -- 389-devel mailing list 389-devel@%(host_name)s http://lists.fedoraproject.org/admin/lists/389-devel@lists.fedoraproject.org

[389-devel] Please review: [389 Project] #48536: Crash in slapi_get_object_extension

https://fedorahosted.org/389/ticket/48536 https://fedorahosted.org/389/attachment/ticket/48536/0001-Ticket-48536-Crash-in-slapi_get_object_extension.patch -- 389-devel mailing list 389-devel@%(host_name)s http://lists.fedoraproject.org/admin/lists/389-devel@lists.fedoraproject.org

[389-devel] Please review (take 3): [389 Project] #48144: Add /usr/sbin/status-dirsrv script to get the status of the directory server instance.

https://fedorahosted.org/389/ticket/48144 https://fedorahosted.org/389/attachment/ticket/48144/0001-Ticket-48144-Add-usr-sbin-status-dirsrv-script-to-ge.patch git patch file (master) -- revised following the comments by William in #comment:8

[389-devel] Please review: [389 Project] #48144: Add /usr/sbin/status-dirsrv script to get the status of the directory server instance.

https://fedorahosted.org/389/ticket/48144 https://fedorahosted.org/389/attachment/ticket/48144/0001-Ticket-48144-Add-usr-sbin-status-dirsrv-script-to-ge.patch Note: no need to review this patch

[389-devel] Please review: [389 Project] #48394: lower password history minimum to 1

https://fedorahosted.org/389/ticket/48394 https://fedorahosted.org/389/attachment/ticket/48394/0001-Ticket-48394-lower-password-history-minimum-to-1.patch https://fedorahosted.org/389/ticket/48417

[389-devel] Please review (take 2): [389 Project] #48144: Add /usr/sbin/status-dirsrv script to get the status of the directory server instance.

https://fedorahosted.org/389/ticket/48144 https://fedorahosted.org/389/attachment/ticket/48144/0001-Ticket-48144-Add-usr-sbin-status-dirsrv-script-to-ge.patch git patch file (master) -- revised based upon the review by mreynolds (Thanks!!) -- 389-devel mailing list 389-devel@%(host_name)s

[389-devel] Please review: [389 Project] #48406: Avoid self deadlock by PR_Lock(conn->c_mutex)

https://fedorahosted.org/389/ticket/48406 https://fedorahosted.org/389/attachment/ticket/48406/0002-Ticket-48406-Avoid-self-deadlock-by-PR_Lock-conn-c_m.2.patch git patch file (master; take 3) -- replacing PR_Lock/Unlock with PR_EnterMonitor/ExitMonitor, respectively Compared the 3

[389-devel] Please review: [389 Project] #548: RFE: Allow AD password sync to update shadowLastChange

https://fedorahosted.org/389/ticket/548 https://fedorahosted.org/389/attachment/ticket/548/0001-Ticket-548-RFE-Allow-AD-password-sync-to-update-shad.2.patch git patch file (master) -- additional fix for the crash bug caused by ldclt. -- 389-devel mailing list 389-devel@%(host_name)s

[389-devel] Please review: [389 Project] #48295: Entry cache is not rolled back -- Linked Attributes plug-in - wrong behaviour when adding valid and broken links

https://fedorahosted.org/389/ticket/48295 https://fedorahosted.org/389/attachment/ticket/48295/0001-Ticket-48295-Entry-cache-is-not-rolled-back-Linked-A.patch https://fedorahosted.org/389/attachment/ticket/48295/0002-Ticket-48295-CI-test-added-test-cases-for-ticket-482.patch -- 389-devel mailing

[389-devel] Please review: [389 Project] #48290 - No man page entry for - option '-u' of dbgen.pl for adding group entries with uniquemembers

https://fedorahosted.org/389/ticket/48290 https://fedorahosted.org/389/attachment/ticket/48290/0001-Ticket-48290-No-man-page-entry-for-option-u-of-dbgen.patch -- 389-devel mailing list 389-devel@%(host_name)s http://lists.fedoraproject.org/admin/lists/389-devel@lists.fedoraproject.org

[389-devel] Please review: [389 Project] #48294: Linked Attributes plug-in - won't update links after MODRDN operation

https://fedorahosted.org/389/ticket/48294 https://fedorahosted.org/389/attachment/ticket/48294/0001-Ticket-48294-Linked-Attributes-plug-in-won-t-update-.patch https://fedorahosted.org/389/attachment/ticket/48294/0002-Ticket-48294-CI-test-added-test-cases-for-ticket-482.patch -- 389-devel mailing

[389-devel] Please review: [389 Project] #48375: SimplePagedResults -- in the search error case, simple paged results slot was not released.

https://fedorahosted.org/389/ticket/48375 https://fedorahosted.org/389/attachment/ticket/48375/0001-Ticket-48375-SimplePagedResults-in-the-search-error-.patch -- 389-devel mailing list 389-devel@%(host_name)s http://lists.fedoraproject.org/admin/lists/389-devel@lists.fedoraproject.org

[389-devel] Please review: (fixing a regression) [389 Project] #48305: perl module conditional test is not conditional when checking SELinux policies

https://fedorahosted.org/389/ticket/48305 https://fedorahosted.org/389/attachment/ticket/48305/0001-Ticket-48305-perl-module-conditional-test-is-not-con.2.patch On 12/02/2015 07:49 AM, 389 Project wrote: Comment: The -f /dev/null test is not working correctly. Reopening. -- 389-devel

[389-devel] Please review: 2 perl issues: #48316 & #48348

https://fedorahosted.org/389/ticket/48316 - Perl-5.20.3-328: Use of literal control characters in variable names is deprecated https://fedorahosted.org/389/attachment/ticket/48316/0001-Ticket-48316-Perl-5.20.3-328-Use-of-literal-control-.patch https://fedorahosted.org/389/ticket/48348 -

Re: [389-devel] Please review: [nunc-stans] Remove extra curly brace

On 11/10/2015 01:29 AM, Lukas Slebodnik wrote: ehlo, I'm too lazy to follow all contribution steps for one liner :-) So simple patch is attached. LS -- 389-devel mailing list 389-devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel Thank you for fixing

[389-devel] Please review: [389 Project] #48344: acl - regression - trailing ', (comma)' in macro matched value is not removed.

https://fedorahosted.org/389/ticket/48344 https://fedorahosted.org/389/attachment/ticket/48344/0001-Ticket-48344-acl-regression-trailing-comma-in-macro-.patch -- 389-devel mailing list 389-devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel

[389-devel] Please review: [389 Project] #48338: SimplePagedResults -- abandon could happen between the abandon check and sending results

https://fedorahosted.org/389/ticket/48338 https://fedorahosted.org/389/attachment/ticket/48338/0001-Ticket-48338-SimplePagedResults-abandon-could-happen.patch -- 389-devel mailing list 389-devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel

[389-devel] Please review: [389 Project] #48257: Fix coverity issues - 08/24/2015

https://fedorahosted.org/389/ticket/48257 https://fedorahosted.org/389/attachment/ticket/48257/0001-Ticket-48257-Fix-coverity-issues-08-24-2015.patch Once this ticket is closed, is it okay to respin nunc_stans which is going to be version 0.1.6? Current: rpm/389-ds-base.spec.in:%global

[389-devel] Please review: [389 Project] #48339: Share nsslapd-threadnumber in the case nunc-stans is enabled, as well.

https://fedorahosted.org/389/ticket/48339 https://fedorahosted.org/389/attachment/ticket/48339/0001-Ticket-48339-Share-nsslapd-threadnumber-in-the-case-.patch -- 389-devel mailing list 389-devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel

Re: [389-devel] Please review: fix compiler warning

On 11/03/2015 10:42 AM, Martin Basti wrote: On 03.11.2015 19:30, Noriko Hosoi wrote: Thanks for your patch, Martin. Looks good to me. "ack". Which version is your patch supposed to be in? Just master is fine? --noriko Thank you, master is fine. Pushed to master: aff9705..0d1ce

Re: [389-devel] Please review: fix compiler warning

Thanks for your patch, Martin. Looks good to me. "ack". Which version is your patch supposed to be in? Just master is fine? --noriko On 11/03/2015 10:24 AM, Martin Basti wrote: Hello all, the gcc compiler returns warning during compiling of the freeIPA project: slapi-plugin.h:6149, GNU C

[389-devel] Please review: [389 Project] #48328: RFE: Allow RHDS to be setup using a DNS CNAME alias for General.FullMachineName

https://fedorahosted.org/389/ticket/48328 https://fedorahosted.org/389/attachment/ticket/48328/0001-Ticket-48328-RFE-Allow-RHDS-to-be-setup-using-a-DNS-.patch -- 389-devel mailing list 389-devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel

[389-devel] Please review (resending -- take 2): [389 Project] #548: RFE: Allow AD password sync to update shadowLastChange

On 10/19/2015 03:16 PM, Noriko Hosoi wrote: Thanks for the reviews on the CI test, Wiliam and Simon! Could someone please review the design doc and the implementation *[1]*? Thanks, --noriko On 10/18/2015 05:14 PM, Noriko Hosoi wrote: https://fedorahosted.org/389/ticket/548 http

Re: [389-devel] Please comment: [389 Project] #48285: The dirsrv user/group should be created in rpm %pre, and ideally with fixed uid/gid

> Should confirm that the generated configure script runs on el7 All right. I ran autogen.sh on RHEL7.2 and am pushing the secondary patch from the platform... Thanks, --noriko On 10/21/2015 11:28 AM, Rich Megginson wrote: On 10/21/2015 12:20 PM, Noriko Hosoi wrote: Thanks to Will

[389-devel] Please review (take 2): [389 Project] #48285: The dirsrv user/group should be created in rpm %pre, and ideally with fixed uid/gid

https://fedorahosted.org/389/ticket/48285 https://fedorahosted.org/389/attachment/ticket/48285/0001-Ticket-48285-The-dirsrv-user-group-should-be-created.patch git patch file (master) -- revised If these users and groups exist on the system:

[389-devel] Please review: [389 Project] #48285: The dirsrv user/group should be created in rpm %pre, and ideally with fixed uid/gid

https://fedorahosted.org/389/ticket/48285 https://fedorahosted.org/389/attachment/ticket/48285/0001-Ticket-48285-The-dirsrv-user-group-should-be-created.patch git patch file (master) -- generated files are not included. -- 389-devel mailing list 389-devel@lists.fedoraproject.org

[389-devel] Please review (take 2): [389 Project] #548: RFE: Allow AD password sync to update shadowLastChange

Thanks for the reviews on the CI test, Wiliam and Simon! Could someone please review the design doc and the implementation *[1]*? Thanks, --noriko On 10/18/2015 05:14 PM, Noriko Hosoi wrote: https://fedorahosted.org/389/ticket/548 http://www.port389.org/docs/389ds/design/shadow-account

[389-devel] Please review: [389 Project] #548: RFE: Allow AD password sync to update shadowLastChange

https://fedorahosted.org/389/ticket/548 http://www.port389.org/docs/389ds/design/shadow-account-support.html design doc https://fedorahosted.org/389/attachment/ticket/548/0001-Ticket-548-RFE-Allow-AD-password-sync-to-update-shad.patch git patch file (master)

[389-devel] Please review: [389 Project] #48287: Double free while adding entries (1.2.11 only)

https://fedorahosted.org/389/ticket/48287 https://fedorahosted.org/389/attachment/ticket/48287/0001-Ticket-48287-Double-free-while-adding-entries-1.2.11.patch -- 389-devel mailing list 389-devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel

[389-devel] Please review: [389 Project] #48305: perl module conditional test is not conditional when checking SELinux policies

https://fedorahosted.org/389/ticket/48305 https://fedorahosted.org/389/attachment/ticket/48305/0001-Ticket-48305-perl-module-conditional-test-is-not-con.patch -- 389-devel mailing list 389-devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel

[389-devel] Please review (revised): [389 Project] #48298: ns-slapd crash during ipa-replica-manage del

https://fedorahosted.org/389/ticket/48298 https://fedorahosted.org/389/attachment/ticket/48298/0001-Ticket-48298-ns-slapd-crash-during-ipa-replica-manag.4.patch git patch file (master) -- different approach -- revised following the reviews by Rich (Thank you!!) -- 389-devel mailing list

[389-devel] Please review: [389 Project] #48298: ns-slapd crash during ipa-replica-manage del

https://fedorahosted.org/389/ticket/48298 https://fedorahosted.org/389/attachment/ticket/48298/0001-Ticket-48298-ns-slapd-crash-during-ipa-replica-manag.patch -- 389-devel mailing list 389-devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel

[389-devel] Please review (additional fixes): [389 Project] #48298: ns-slapd crash during ipa-replica-manage del

https://fedorahosted.org/389/ticket/48298 https://fedorahosted.org/389/attachment/ticket/48298/0001-Ticket-48298-ns-slapd-crash-during-ipa-replica-manag.2.patch git patch file (master) -- additional fixes (merge them when commit) Thank you, Rich, for the reviews and comments. Do you think (1)

[389-devel] Please review (additional fixes - take 2): [389 Project] #48298: ns-slapd crash during ipa-replica-manage del

https://fedorahosted.org/389/ticket/48298 https://fedorahosted.org/389/attachment/ticket/48298/0001-Ticket-48298-ns-slapd-crash-during-ipa-replica-manag.2.patch git patch file (master) -- revised the previous patch following the comments by Rich (take 2) -- 389-devel mailing list

[389-devel] Please review: [389 Project] #48299: pagedresults - when timed out, search results could have been already freed.

https://fedorahosted.org/389/ticket/48299 https://fedorahosted.org/389/attachment/ticket/48299/0001-Ticket-48299-pagedresults-when-timed-out-search-resu.patch -- 389-devel mailing list 389-devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel

[389-devel] Commit: Regression in your 389 makefile patches

Thanks to Simo for fixing the 389-ds-base Makefile.am. Pushed his patch to the master branch. commit 3c827508f8e177992010011305f78da3b3ab3b25 Author: Simo Sorce Date: Wed Sep 23 15:08:17 2015 -0400 Fix out of tree build Signed-off-by: Simo Sorce

[389-devel] Please review (take 2): [389 Project] #48188: segfault in ns-slapd due to accessing Slapi_DN freed in pre bind plug-in

https://fedorahosted.org/389/ticket/48188 https://fedorahosted.org/389/attachment/ticket/48188/0001-Ticket-48188-segfault-in-ns-slapd-due-to-accessing-S.patch This patch is based upon the patch provided by Simo Sorce for Ticket #48272 - Allow PRE_BIND plugins to mangle DNs

[389-devel] Please review (take 2): [389 Project] #48277: Assorted build fixes and make rpms target

https://fedorahosted.org/389/ticket/48277 https://fedorahosted.org/389/ticket/48277#comment:4 Special thanks to Simo for his contribution and understanding our needs. I reviewed and tested the patches in #comment:4. I'd like to have another (or more) pair of eyes. Thanks, --noriko --

[389-devel] Please review: [389 Project] #48226: In MMR, double free coould occur under some special condition

https://fedorahosted.org/389/ticket/48226 https://fedorahosted.org/389/attachment/ticket/48226/0001-Ticket-48226-In-MMR-double-free-coould-occur-under-s.2.patch git patch file (master) -- additinal fix for the memory leak (regression by the previous patch) Thanks to Mark Reynolds for the CI

[389-devel] Please review: [389 Project] #48265: Complex filter in a search request doen't work as expected. (regression)

https://fedorahosted.org/389/ticket/48265 https://fedorahosted.org/389/attachment/ticket/48265/0001-Ticket-48265-Complex-filter-in-a-search-request-doen.patch git patch file (master)

[389-devel] Please review (memory leak): [389 Project] #48252: db2index creates index entry from deleted records

https://fedorahosted.org/389/ticket/48252 https://fedorahosted.org/389/attachment/ticket/48252/0001-Ticket-48252-db2index-creates-index-entry-from-delet.2.patch Description: Commit ca4d38dff3bd820af2bf60c9bcc82fd64aac2556 fixing ticket #48252 introduced memory leaks. .

[389-devel] Please review (regression): [389 Project] #48228: wrong password check if passwordInHistory is decreased.

https://fedorahosted.org/389/ticket/48228 https://fedorahosted.org/389/attachment/ticket/48228/0001-Ticket-48228-wrong-password-check-if-passwordInHisto.2.patch -- 389-devel mailing list 389-devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel

[389-devel] Please review (2 tickets): #47757 and #48252

#47757: Unable to dereference unqiemember attribute because it is dn [#UID] not dn syntax https://fedorahosted.org/389/ticket/47757 https://fedorahosted.org/389/attachment/ticket/47757/0001-Ticket-47757-Unable-to-dereference-unqiemember-attri.patch #48252: db2index creates index entry from

[389-devel] Please review (take 2 to fix regression): [389 Project] #48228: wrong password check if passwordInHistory is decreased.

https://fedorahosted.org/389/ticket/48228 https://fedorahosted.org/389/attachment/ticket/48228/0001-Ticket-48228-wrong-password-check-if-passwordInHisto.2.patch git patch file (master) -- revised: fixing the regression in the previous patch (broken qsort) -- 389-devel mailing list

[389-devel] Please review: [389 Project] #48252: db2index creates index entry from deleted records

https://fedorahosted.org/389/ticket/48252 https://fedorahosted.org/389/attachment/ticket/48252/0001-Ticket-48252-db2index-creates-index-entry-from-delet.patch -- 389-devel mailing list 389-devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel

[389-devel] Please review: [389 Project] #48228: wrong password check if passwordInHistory is decreased.

https://fedorahosted.org/389/ticket/48228 https://fedorahosted.org/389/attachment/ticket/48228/0001-Ticket-48228-wrong-password-check-if-passwordInHisto.patch https://fedorahosted.org/389/attachment/ticket/48228/0002-Ticket-48228-CI-test-added-test-cases-for-ticket-482.patch -- 389-devel

  1   2   3   4   >