Re: about maven-faces-plugin

2007-03-09 Thread Adam Winer
On 3/8/07, Martin Marinschek [EMAIL PROTECTED] wrote: I still wonder if the approach MyFaces originally had wasn't better than the new approach of the generator in Trinidad. Apart from the fact of course that generation should happen on every run of the build - we kind of neglected that. What

Re: about maven-faces-plugin

2007-03-08 Thread Martin Marinschek
I still wonder if the approach MyFaces originally had wasn't better than the new approach of the generator in Trinidad. Apart from the fact of course that generation should happen on every run of the build - we kind of neglected that. What you have with the Trinidad generator now is:

about maven-faces-plugin

2007-03-07 Thread Mathias Brökelmann
Hi all, During myfaces 1.2 development I came across the maven-faces-plugin from trinidad. AFAIK it uses some xml files which contains the model for the generated components. This saves a lot of time to quickly get new components into work. But there is room to improve it. Currently customizing

Re: about maven-faces-plugin

2007-03-07 Thread Bruno Aranda
IMO I prefer to use as much as I can the code autogenerated without having to add new code to the methods (delegating all this to the code generator). This eases the process of migrating code. Adding very specific code to methods might break future migrations (e.g. migrating tomahawk components

Re: about maven-faces-plugin

2007-03-07 Thread Adam Winer
In general, I think the approach used by the faces plugin is a really good thing. You want as much autogenerated as possible (this made upgrading to JSF 1.2 vastly easier than without it). And the specific approach actually allows for treating the template .java files as fully compileable

Re: about maven-faces-plugin

2007-03-07 Thread Matthias Wessendorf
what I didn't like this morning, for fixing a bug on MyFAces' JSF 1.2 UIViewRoot is, that I need to put this statement: /**///getPhaseListeners to get a *ignored* getter for the phaseListeners property. The rest is fine, at least the part I was dealing w/ in order to get some stuff working

Re: about maven-faces-plugin

2007-03-07 Thread Adam Winer
On 3/7/07, Matthias Wessendorf [EMAIL PROTECTED] wrote: what I didn't like this morning, for fixing a bug on MyFAces' JSF 1.2 UIViewRoot is, that I need to put this statement: /**///getPhaseListeners to get a *ignored* getter for the phaseListeners property. Well, you need this if