Re: [Qemu-devel] [PATCH 1/3] qxl: add fb_size_mb and fb_size

2012-06-11 Thread Alon Levy
On Mon, Jun 11, 2012 at 10:29:59AM +0200, Gerd Hoffmann wrote: Hi, Reminds me that I have some pending work to make vga ram size configurable which I should finish and repost ... Current state pushed to http://www.kraxel.org/cgit/qemu/log/?h=vga.1 It probably makes sense to base

Re: [Qemu-devel] [PATCH 1/3] qxl: add fb_size_mb and fb_size

2012-06-11 Thread Alon Levy
On Mon, Jun 11, 2012 at 12:18:14PM +0200, Gerd Hoffmann wrote: On 06/11/12 11:33, Alon Levy wrote: On Mon, Jun 11, 2012 at 10:29:59AM +0200, Gerd Hoffmann wrote: Hi, Reminds me that I have some pending work to make vga ram size configurable which I should finish and repost

control center display and tablets / rotating tablets

2012-06-10 Thread Alon Levy
Hi, I am playing with a new Lenovo tablet, x220t, and I've come up against what I think is a current gnome-control-center limitation, which I would like to solve. Namely, when I rotate my main display, i.e. the LVDS1 output that is the LCD panel of the laptop, the tablet doesn't rotate with

Re: [Spice-devel] rfc seamless migration

2012-06-10 Thread Alon Levy
On Sun, Jun 10, 2012 at 04:32:54PM +0200, Hans de Goede wrote: Hi, On 06/10/2012 11:05 AM, Yonit Halperin wrote: Hi, As the qemu team rejected integrating spice connection migration in qemu migration process, we remain with a solution that will involve libvirt, and passing data from

Re: [Spice-devel] rfc seamless migration

2012-06-10 Thread Alon Levy
On Sun, Jun 10, 2012 at 05:11:06PM +0200, Hans de Goede wrote: Hi, On 06/10/2012 04:44 PM, Alon Levy wrote: snip Obligatory migration data: - (1) agent/spicevmc/smartcard write buffer. i.e., data that reached the server after savevm, and thus was not written

Re: [Qemu-devel] [PATCH 1/2] libcacard: build fixes

2012-06-10 Thread Alon Levy
On Sun, Jun 10, 2012 at 01:04:32PM +, Blue Swirl wrote: Link trace objects to fix these errors: LINK vscclient oslib-posix.o: In function `trace_qemu_vfree': /src/qemu/obj-amd64/./trace.h:39: undefined reference to `trace1' oslib-posix.o: In function `trace_qemu_memalign':

Re: [fedora-virt] Multi-head SPICE support in virt-manager?

2012-06-09 Thread Alon Levy
On Thu, Jun 07, 2012 at 05:08:15PM -0500, Ian Pilcher wrote: On 06/07/2012 08:22 AM, Cole Robinson wrote: I think virt-viewer supports it, and it wouldn't be a ton of work, so if any enterprising person wanted to take a stab at a patch I'd be happy to help shepherd it along. We can only

Re: [Spice-devel] [PATCH] Release 0.11.0

2012-06-09 Thread Alon Levy
On Thu, Jun 07, 2012 at 03:35:00PM +0200, Marc-André Lureau wrote: On Thu, Jun 7, 2012 at 1:12 PM, Alon Levy al...@redhat.com wrote: ---  NEWS         |   27 +++  configure.ac |    4 ++--  2 files changed, 29 insertions(+), 2 deletions(-) Looks good to me

Re: [Spice-devel] [PATCH] Release 0.11.0

2012-06-09 Thread Alon Levy
On Sat, Jun 09, 2012 at 06:16:25PM -0400, Marc-André Lureau wrote: Hi - Mensaje original - I agree that we need to change it, but I find that page very confusing. According to point 2 at the bottom, since we are backward compatible but added interfaces, we should increment

[PATCH] map-to-output: implement reflections and rotations

2012-06-09 Thread Alon Levy
Uses the rotation translation currently set according to RandR. Signed-off-by: Alon Levy al...@redhat.com --- Tested with a x220t (lenovo tablet). The comments below correct in working zone, I believe are not related to the wrong matrix, you can see for instance that 'RR_Rotate_270

Re: [PATCH] map-to-output: implement reflections and rotations

2012-06-09 Thread Alon Levy
On Sat, Jun 09, 2012 at 05:23:37PM +0300, Alon Levy wrote: This is for xinput.. messed the $SUBJECT. Uses the rotation translation currently set according to RandR. Signed-off-by: Alon Levy al...@redhat.com --- Tested with a x220t (lenovo tablet). The comments below correct in working

[Spice-devel] [PATCH] Release 0.11.0

2012-06-07 Thread Alon Levy
--- NEWS | 27 +++ configure.ac |4 ++-- 2 files changed, 29 insertions(+), 2 deletions(-) diff --git a/NEWS b/NEWS index 2deba57..5201bcb 100644 --- a/NEWS +++ b/NEWS @@ -1,3 +1,30 @@ +Major changes in 0.11.0: +* !Development Release! +* 8817549..d905a1f +*

[Spice-devel] [PATCH] m4/spice-compile-warnings: Squelch _FORTIFY_SOURCE when needed to avoid glibc #warnings.

2012-06-06 Thread Alon Levy
Fix copied from libvirt, commit by Eric Blake. glibc 2.15 (on Fedora 17) coupled with explicit disabling of optimization during development dies a painful death: /usr/include/features.h:314:4: error: #warning _FORTIFY_SOURCE requires compiling with optimization (-O) [-Werror=cpp] cc1: all

Re: Evdev for a touchscreen w/ digitizer

2012-06-06 Thread Alon Levy
On Sun, Jun 03, 2012 at 09:54:28PM +0200, Cedric Sodhi wrote: Hello, There is an EETI eGalax 0eef:a001 Touchscreen and a Wacpm 056a:0090 ISDV4 stylus device. Evtest output for a simple tap on the eGALAX is attached. With Xorg 1.12.2, inputproto 2.2 on gentoo, xinput list egalax yields

Re: [Qemu-devel] [RFC PATCH 0/5] asynchronous migration state change handlers

2012-06-06 Thread Alon Levy
On Wed, Jun 06, 2012 at 05:22:21PM +0800, Anthony Liguori wrote: On 06/06/2012 05:10 PM, Yonit Halperin wrote: Hi, I would like to add some more points to Gerd's explanation: On 06/05/2012 04:15 PM, Gerd Hoffmann wrote: Hi, Absolutely not. This is hideously ugly and affects a bunch of

Re: [Qemu-devel] [RFC PATCH 0/5] asynchronous migration state change handlers

2012-06-06 Thread Alon Levy
On Wed, Jun 06, 2012 at 07:05:44PM +0800, Anthony Liguori wrote: On 06/06/2012 06:54 PM, Alon Levy wrote: On Wed, Jun 06, 2012 at 05:22:21PM +0800, Anthony Liguori wrote: On 06/06/2012 05:10 PM, Yonit Halperin wrote: Spice client migration has nothing to do with guest migration. Trying

Re: [Qemu-devel] [RFC PATCH 0/5] asynchronous migration state change handlers

2012-06-06 Thread Alon Levy
On Wed, Jun 06, 2012 at 08:08:40PM +0800, Anthony Liguori wrote: On 06/06/2012 08:01 PM, Yonit Halperin wrote: On 06/06/2012 12:22 PM, Anthony Liguori wrote: So send a QMP event and call it a day. Using a QMP event is making spice seamless migration dependent on libvirt version. That

Re: [Qemu-devel] [RFC PATCH 0/5] asynchronous migration state change handlers

2012-06-06 Thread Alon Levy
On Wed, Jun 06, 2012 at 08:17:29PM +0800, Anthony Liguori wrote: On 06/06/2012 08:15 PM, Alon Levy wrote: On Wed, Jun 06, 2012 at 08:08:40PM +0800, Anthony Liguori wrote: On 06/06/2012 08:01 PM, Yonit Halperin wrote: On 06/06/2012 12:22 PM, Anthony Liguori wrote: So send a QMP event

Re: [Qemu-devel] [RFC PATCH 0/5] asynchronous migration state change handlers

2012-06-06 Thread Alon Levy
On Wed, Jun 06, 2012 at 03:03:37PM +0200, Gerd Hoffmann wrote: Hi, I literally have danpb's event introspection patches from Luiz's PULL request testing on my system right now to be pushed. Good. this?: [PATCH 29/29] Add 'query-events' command to QMP to query async events This

Re: [Spice-devel] Further thoughts on the write polling in the xf86_spice_xql driver

2012-06-05 Thread Alon Levy
On Mon, Jun 04, 2012 at 08:42:17AM -0500, Jeremy White wrote: However, while the X server main loop has a facility that lets us add fds to it's select read mask, it has no such facility to let us add fds to it's *write* select mask. Right. This is the problem. I think the right

Re: [Spice-devel] Announcing the first version of spice-html5

2012-06-05 Thread Alon Levy
On Tue, Jun 05, 2012 at 10:38:09AM -0500, Jeremy White wrote: For instance, I use a french keyboard and I found issues for it on spice-html. *blush* Yes, sorry, the keyboard code is truly awful. It's a matter of translating web key codes into scan codes; I didn't find a good way to do

Re: [Spice-devel] [PATCH spice-server 1/2] server/red_channel: fix possible access to released channel clients

2012-06-04 Thread Alon Levy
On Mon, Jun 04, 2012 at 11:46:02AM +0200, Christophe Fergeau wrote: On Thu, May 31, 2012 at 10:04:05AM +0300, Yonit Halperin wrote: Added ref count for RedChannel and RedChannelClient. Just a side note, longer term we should probably introduce a SpiceRefCounted base class which would

Re: [Spice-devel] [PATCH] make celt to be optional

2012-06-04 Thread Alon Levy
On Mon, Jun 04, 2012 at 11:33:22AM +0200, Christophe Fergeau wrote: Makes sense to me though I've only looked quickly through it. Since it works for you, I'm in favour of committing it if noone disagrees. I agree. Would you do a review and ack? Christophe On Sat, Jun 02, 2012 at

Re: [Spice-devel] [PATCH spice-server 1/2] server/red_channel: fix possible access to released channel clients

2012-06-04 Thread Alon Levy
On Mon, Jun 04, 2012 at 02:39:17PM +0200, Christophe Fergeau wrote: On Mon, Jun 04, 2012 at 03:26:02PM +0300, Alon Levy wrote: On Mon, Jun 04, 2012 at 11:46:02AM +0200, Christophe Fergeau wrote: On Thu, May 31, 2012 at 10:04:05AM +0300, Yonit Halperin wrote: Added ref count

Re: [Spice-devel] Further thoughts on the write polling in the xf86_spice_xql driver

2012-06-03 Thread Alon Levy
On Sat, Jun 02, 2012 at 01:24:29PM -0500, Jeremy White wrote: I spent a fair amount of energy trying to understand the issue with EAGAIN and the xspice server. I've sent in one patch which I believe to be correct. I had some further thoughts I wanted to share as well. To reprise, the

Re: [Spice-devel] [PATCH spice-server 1/2] server/red_channel: fix possible access to released channel clients

2012-05-31 Thread Alon Levy
On Thu, May 31, 2012 at 10:04:05AM +0300, Yonit Halperin wrote: Added ref count for RedChannel and RedChannelClient. red_channel.c/red_peer_handle_incoming call to handler-cb-handle_message might lead to the release of the channel client, and the following call to handler-cb-release_msg_buf

[Spice-devel] [PATCH 05/19] qxl_surface: handle destroyed pixmaps while evacuated

2012-05-31 Thread Alon Levy
Prevent access to freed memory when: 1. qxl_leave_vt/qxl_surface_cache_evacuate_all freed cache-all_surfaces 2. ProcRenderDispatch/damageDestroyPixmap/qxl_destroy_pixmap/qxl_surface_kill access a surface that pointed inside the all_surfaces array Solution in this patch: 1. never free all_surfaces

[Spice-devel] [PATCH 18/19] qxl_surface: don't unlink surface 0

2012-05-31 Thread Alon Levy
The primary surface, i.e. qxl-primary, the only surface with id==0, is allocated in qxl_surface_cache_create_primary with prev==next==NULL. Unlinking it was producing a wrong cache-free_surfaces == NULL. This was not a problem because unlinking the primary only happened in switch_host, which then

[Spice-devel] [PATCH 11/19] qxl_pre_init: memset qxl struct

2012-05-31 Thread Alon Levy
--- src/qxl_driver.c |1 + 1 file changed, 1 insertion(+) diff --git a/src/qxl_driver.c b/src/qxl_driver.c index a3ec1f8..1dbde5b 100644 --- a/src/qxl_driver.c +++ b/src/qxl_driver.c @@ -1448,6 +1448,7 @@ qxl_pre_init(ScrnInfoPtr pScrn, int flags) if (!pScrn-driverPrivate)

[Spice-devel] [PATCH 07/19] rename qxl_reset to qxl_reset_and_create_mem_slots

2012-05-31 Thread Alon Levy
--- src/qxl_driver.c |8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/qxl_driver.c b/src/qxl_driver.c index 4c08637..c128231 100644 --- a/src/qxl_driver.c +++ b/src/qxl_driver.c @@ -525,7 +525,7 @@ setup_slot(qxl_screen_t *qxl, uint8_t slot_index_offset, }

[Spice-devel] [PATCH 01/19] uxa: remove unnecessary includes, reduces warnings due to duplicate definitions

2012-05-31 Thread Alon Levy
--- src/uxa/uxa-accel.c |2 -- src/uxa/uxa.c |2 -- 2 files changed, 4 deletions(-) diff --git a/src/uxa/uxa-accel.c b/src/uxa/uxa-accel.c index 62034c2..e456e6c 100644 --- a/src/uxa/uxa-accel.c +++ b/src/uxa/uxa-accel.c @@ -31,8 +31,6 @@ #include dix-config.h #endif #include

[Spice-devel] [PATCH 03/19] qxl_surface: remove redundant qxl_garbage_collect, qxl_allocnf calls it

2012-05-31 Thread Alon Levy
--- src/qxl_surface.c |2 -- 1 file changed, 2 deletions(-) diff --git a/src/qxl_surface.c b/src/qxl_surface.c index a8901f0..cb0de1d 100644 --- a/src/qxl_surface.c +++ b/src/qxl_surface.c @@ -357,8 +357,6 @@ make_surface_cmd (surface_cache_t *cache, uint32_t id, QXLSurfaceCmdType type)

[Spice-devel] [PATCH 10/19] qxl_driver: abort on mspace error, don't spin (default abort function)

2012-05-31 Thread Alon Levy
--- src/qxl_driver.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/src/qxl_driver.c b/src/qxl_driver.c index 3c8dcca..a3ec1f8 100644 --- a/src/qxl_driver.c +++ b/src/qxl_driver.c @@ -41,6 +41,7 @@ #include xf86Crtc.h +#include mspace.h #include qxl.h #include

[Spice-devel] [PATCH 16/19] io: add qxl_io_destroy_primary

2012-05-31 Thread Alon Levy
--- src/qxl.h|1 + src/qxl_driver.c | 15 +++ 2 files changed, 16 insertions(+) diff --git a/src/qxl.h b/src/qxl.h index 819c98d..aa6645c 100644 --- a/src/qxl.h +++ b/src/qxl.h @@ -435,6 +435,7 @@ inline void qxl_mem_unverifiable(struct qxl_mem *mem) {} void

[Spice-devel] [PATCH 04/19] qxl_driver: hide cursors on vt switch

2012-05-31 Thread Alon Levy
This is not enough to prevent any qxl_destroy_pixmap call during vt switch, but it prevents those triggered by CursorDisplayCursor. Note: a matching xf86_show_cursors call doesn't hurt, but is not required, so not adding it. It is still possible to access freed memory by the following trigger:

[Spice-devel] [PATCH 17/19] qxl_surface: add DEBUG_SURFACE_LIFECYCLE helpers

2012-05-31 Thread Alon Levy
--- src/qxl_surface.c | 46 ++ 1 file changed, 46 insertions(+) diff --git a/src/qxl_surface.c b/src/qxl_surface.c index fd62576..669a022 100644 --- a/src/qxl_surface.c +++ b/src/qxl_surface.c @@ -49,6 +49,12 @@ #include qxl.h +#ifdef

[Spice-devel] [PATCH 00/19] xf86-video-qxl cleanups, switchmode, vt segfaults

2012-05-31 Thread Alon Levy
to xf86CrtcConfigInit to allow later xf86_hide_cursors in qxl_leave_vt to avoid some pixmap references until qxl_enter_vt. I have not tested these patches with a Xinerama setup, I'd appreciate any tests or pointing out something that wouldn't work for that scenario (xf86CrtcConfigInit ?) Alon Levy (19

[Spice-devel] [PATCH 12/19] qxl_surface: cosmetics

2012-05-31 Thread Alon Levy
--- src/qxl_surface.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qxl_surface.c b/src/qxl_surface.c index d999b4d..976c339 100644 --- a/src/qxl_surface.c +++ b/src/qxl_surface.c @@ -551,7 +551,7 @@ surface_send_create (surface_cache_t *cache, /* the final +

[Spice-devel] [PATCH 08/19] qxl_leave_vt: change outb to ioport_write (easier to grep / breakpoint on a single point)

2012-05-31 Thread Alon Levy
--- src/qxl_driver.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qxl_driver.c b/src/qxl_driver.c index c128231..3c8dcca 100644 --- a/src/qxl_driver.c +++ b/src/qxl_driver.c @@ -1214,7 +1214,7 @@ qxl_leave_vt(int scrnIndex, int flags) qxl-vt_surfaces =

[Spice-devel] [PATCH 09/19] mspace: add mspace_malloc_stats_return

2012-05-31 Thread Alon Levy
--- src/mspace.c | 33 +++-- src/mspace.h |5 - 2 files changed, 31 insertions(+), 7 deletions(-) diff --git a/src/mspace.c b/src/mspace.c index 17d976a..822aade 100644 --- a/src/mspace.c +++ b/src/mspace.c @@ -1479,7 +1479,8 @@ static struct mallinfo

[Spice-devel] [PATCH 13/19] qxl_surface: logging: add function name to ErrorF

2012-05-31 Thread Alon Levy
--- src/qxl_surface.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/qxl_surface.c b/src/qxl_surface.c index 976c339..6414351 100644 --- a/src/qxl_surface.c +++ b/src/qxl_surface.c @@ -635,7 +635,7 @@ qxl_surface_create (surface_cache_t *cache, if

[Spice-devel] [PATCH 14/19] qxl.h: add device_primary tri state UNDEFINED/NONE/CREATED

2012-05-31 Thread Alon Levy
--- src/qxl.h|8 src/qxl_driver.c |4 2 files changed, 12 insertions(+) diff --git a/src/qxl.h b/src/qxl.h index c6d3793..56e03a3 100644 --- a/src/qxl.h +++ b/src/qxl.h @@ -126,6 +126,12 @@ enum { OPTION_COUNT, }; +enum { +QXL_DEVICE_PRIMARY_UNDEFINED, +

[Spice-devel] [PATCH 15/19] prefix io with qxl_io, add several

2012-05-31 Thread Alon Levy
--- src/qxl.h |9 +--- src/qxl_driver.c | 65 - src/qxl_surface.c |2 +- 3 files changed, 67 insertions(+), 9 deletions(-) diff --git a/src/qxl.h b/src/qxl.h index 56e03a3..819c98d 100644 --- a/src/qxl.h +++ b/src/qxl.h

[Spice-devel] [PATCH 19/19] qxl_switch_mode: don't evacuate, just recreate primary surface

2012-05-31 Thread Alon Levy
In summary, on vt enter we still: reset recreate memory slots clear our mspace allocators and then do what switch mode below says On vt leave we still: reset (this is redundant since the first VGA access will trigger a reset on the device side) On switch mode however we only: destroy

[Spice-devel] [PATCH v2] qxl_mem: add debug flags, simple accounting and valgrind enabled

2012-05-31 Thread Alon Levy
adds preprocessor definitions DEBUG_QXL_MEM DEBUG_QXL_MEM_VERBOSE --- v1-v2: add static in front of qxl_mem_unverifiable in the default case of undefined DEBUG_QXL_MEM. src/qxl.h|6 ++ src/qxl_driver.c |8 src/qxl_mem.c| 54

Re: [Spice-devel] [spice 0.10 PATCH] cleanup x11 library detection for building client

2012-05-31 Thread Alon Levy
On Thu, May 31, 2012 at 05:44:23PM +0300, Uri Lublin wrote: From: Nahum Shalman nshal...@elys.com ACK. Now you're making me feel back about the few patches I already cherry-picked to 0.10 without asking anyone. Consolidate two separate chunks of library hunting that depend on the same

[PATCH 05/19] qxl_surface: handle destroyed pixmaps while evacuated

2012-05-31 Thread Alon Levy
Prevent access to freed memory when: 1. qxl_leave_vt/qxl_surface_cache_evacuate_all freed cache-all_surfaces 2. ProcRenderDispatch/damageDestroyPixmap/qxl_destroy_pixmap/qxl_surface_kill access a surface that pointed inside the all_surfaces array Solution in this patch: 1. never free all_surfaces

[PATCH 18/19] qxl_surface: don't unlink surface 0

2012-05-31 Thread Alon Levy
The primary surface, i.e. qxl-primary, the only surface with id==0, is allocated in qxl_surface_cache_create_primary with prev==next==NULL. Unlinking it was producing a wrong cache-free_surfaces == NULL. This was not a problem because unlinking the primary only happened in switch_host, which then

[PATCH 11/19] qxl_pre_init: memset qxl struct

2012-05-31 Thread Alon Levy
--- src/qxl_driver.c |1 + 1 file changed, 1 insertion(+) diff --git a/src/qxl_driver.c b/src/qxl_driver.c index a3ec1f8..1dbde5b 100644 --- a/src/qxl_driver.c +++ b/src/qxl_driver.c @@ -1448,6 +1448,7 @@ qxl_pre_init(ScrnInfoPtr pScrn, int flags) if (!pScrn-driverPrivate)

[PATCH 07/19] rename qxl_reset to qxl_reset_and_create_mem_slots

2012-05-31 Thread Alon Levy
--- src/qxl_driver.c |8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/qxl_driver.c b/src/qxl_driver.c index 4c08637..c128231 100644 --- a/src/qxl_driver.c +++ b/src/qxl_driver.c @@ -525,7 +525,7 @@ setup_slot(qxl_screen_t *qxl, uint8_t slot_index_offset, }

[PATCH 01/19] uxa: remove unnecessary includes, reduces warnings due to duplicate definitions

2012-05-31 Thread Alon Levy
--- src/uxa/uxa-accel.c |2 -- src/uxa/uxa.c |2 -- 2 files changed, 4 deletions(-) diff --git a/src/uxa/uxa-accel.c b/src/uxa/uxa-accel.c index 62034c2..e456e6c 100644 --- a/src/uxa/uxa-accel.c +++ b/src/uxa/uxa-accel.c @@ -31,8 +31,6 @@ #include dix-config.h #endif #include

[PATCH 03/19] qxl_surface: remove redundant qxl_garbage_collect, qxl_allocnf calls it

2012-05-31 Thread Alon Levy
--- src/qxl_surface.c |2 -- 1 file changed, 2 deletions(-) diff --git a/src/qxl_surface.c b/src/qxl_surface.c index a8901f0..cb0de1d 100644 --- a/src/qxl_surface.c +++ b/src/qxl_surface.c @@ -357,8 +357,6 @@ make_surface_cmd (surface_cache_t *cache, uint32_t id, QXLSurfaceCmdType type)

[PATCH 10/19] qxl_driver: abort on mspace error, don't spin (default abort function)

2012-05-31 Thread Alon Levy
--- src/qxl_driver.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/src/qxl_driver.c b/src/qxl_driver.c index 3c8dcca..a3ec1f8 100644 --- a/src/qxl_driver.c +++ b/src/qxl_driver.c @@ -41,6 +41,7 @@ #include xf86Crtc.h +#include mspace.h #include qxl.h #include

[PATCH 02/19] uxa-damage: remove unnecessary include (doesn't fix any warnings)

2012-05-31 Thread Alon Levy
--- src/uxa/uxa-damage.c |1 - 1 file changed, 1 deletion(-) diff --git a/src/uxa/uxa-damage.c b/src/uxa/uxa-damage.c index 586c466..3e4c075 100644 --- a/src/uxa/uxa-damage.c +++ b/src/uxa/uxa-damage.c @@ -30,7 +30,6 @@ #includeX11/X.h #includescrnintstr.h #includewindowstr.h

[PATCH 16/19] io: add qxl_io_destroy_primary

2012-05-31 Thread Alon Levy
--- src/qxl.h|1 + src/qxl_driver.c | 15 +++ 2 files changed, 16 insertions(+) diff --git a/src/qxl.h b/src/qxl.h index 819c98d..aa6645c 100644 --- a/src/qxl.h +++ b/src/qxl.h @@ -435,6 +435,7 @@ inline void qxl_mem_unverifiable(struct qxl_mem *mem) {} void

[PATCH 04/19] qxl_driver: hide cursors on vt switch

2012-05-31 Thread Alon Levy
This is not enough to prevent any qxl_destroy_pixmap call during vt switch, but it prevents those triggered by CursorDisplayCursor. Note: a matching xf86_show_cursors call doesn't hurt, but is not required, so not adding it. It is still possible to access freed memory by the following trigger:

[PATCH 17/19] qxl_surface: add DEBUG_SURFACE_LIFECYCLE helpers

2012-05-31 Thread Alon Levy
--- src/qxl_surface.c | 46 ++ 1 file changed, 46 insertions(+) diff --git a/src/qxl_surface.c b/src/qxl_surface.c index fd62576..669a022 100644 --- a/src/qxl_surface.c +++ b/src/qxl_surface.c @@ -49,6 +49,12 @@ #include qxl.h +#ifdef

[PATCH 00/19] xf86-video-qxl cleanups, switchmode, vt segfaults

2012-05-31 Thread Alon Levy
to xf86CrtcConfigInit to allow later xf86_hide_cursors in qxl_leave_vt to avoid some pixmap references until qxl_enter_vt. I have not tested these patches with a Xinerama setup, I'd appreciate any tests or pointing out something that wouldn't work for that scenario (xf86CrtcConfigInit ?) Alon Levy (19

[PATCH 12/19] qxl_surface: cosmetics

2012-05-31 Thread Alon Levy
--- src/qxl_surface.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qxl_surface.c b/src/qxl_surface.c index d999b4d..976c339 100644 --- a/src/qxl_surface.c +++ b/src/qxl_surface.c @@ -551,7 +551,7 @@ surface_send_create (surface_cache_t *cache, /* the final +

[PATCH 08/19] qxl_leave_vt: change outb to ioport_write (easier to grep / breakpoint on a single point)

2012-05-31 Thread Alon Levy
--- src/qxl_driver.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qxl_driver.c b/src/qxl_driver.c index c128231..3c8dcca 100644 --- a/src/qxl_driver.c +++ b/src/qxl_driver.c @@ -1214,7 +1214,7 @@ qxl_leave_vt(int scrnIndex, int flags) qxl-vt_surfaces =

[PATCH 09/19] mspace: add mspace_malloc_stats_return

2012-05-31 Thread Alon Levy
--- src/mspace.c | 33 +++-- src/mspace.h |5 - 2 files changed, 31 insertions(+), 7 deletions(-) diff --git a/src/mspace.c b/src/mspace.c index 17d976a..822aade 100644 --- a/src/mspace.c +++ b/src/mspace.c @@ -1479,7 +1479,8 @@ static struct mallinfo

[PATCH 13/19] qxl_surface: logging: add function name to ErrorF

2012-05-31 Thread Alon Levy
--- src/qxl_surface.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/qxl_surface.c b/src/qxl_surface.c index 976c339..6414351 100644 --- a/src/qxl_surface.c +++ b/src/qxl_surface.c @@ -635,7 +635,7 @@ qxl_surface_create (surface_cache_t *cache, if

[PATCH 14/19] qxl.h: add device_primary tri state UNDEFINED/NONE/CREATED

2012-05-31 Thread Alon Levy
--- src/qxl.h|8 src/qxl_driver.c |4 2 files changed, 12 insertions(+) diff --git a/src/qxl.h b/src/qxl.h index c6d3793..56e03a3 100644 --- a/src/qxl.h +++ b/src/qxl.h @@ -126,6 +126,12 @@ enum { OPTION_COUNT, }; +enum { +QXL_DEVICE_PRIMARY_UNDEFINED, +

[PATCH 06/19] qxl_mem: add debug flags, simple accounting and valgrind enabled

2012-05-31 Thread Alon Levy
adds preprocessor definitions DEBUG_QXL_MEM DEBUG_QXL_MEM_VERBOSE --- src/qxl.h|6 ++ src/qxl_driver.c |8 src/qxl_mem.c| 54 +- 3 files changed, 67 insertions(+), 1 deletion(-) diff --git a/src/qxl.h

[PATCH 15/19] prefix io with qxl_io, add several

2012-05-31 Thread Alon Levy
--- src/qxl.h |9 +--- src/qxl_driver.c | 65 - src/qxl_surface.c |2 +- 3 files changed, 67 insertions(+), 9 deletions(-) diff --git a/src/qxl.h b/src/qxl.h index 56e03a3..819c98d 100644 --- a/src/qxl.h +++ b/src/qxl.h

[PATCH 19/19] qxl_switch_mode: don't evacuate, just recreate primary surface

2012-05-31 Thread Alon Levy
In summary, on vt enter we still: reset recreate memory slots clear our mspace allocators and then do what switch mode below says On vt leave we still: reset (this is redundant since the first VGA access will trigger a reset on the device side) On switch mode however we only: destroy

[PATCH v2] qxl_mem: add debug flags, simple accounting and valgrind enabled

2012-05-31 Thread Alon Levy
adds preprocessor definitions DEBUG_QXL_MEM DEBUG_QXL_MEM_VERBOSE --- v1-v2: add static in front of qxl_mem_unverifiable in the default case of undefined DEBUG_QXL_MEM. src/qxl.h|6 ++ src/qxl_driver.c |8 src/qxl_mem.c| 54

Re: [Spice-devel] [RFC PATCH 1/4] notifiers: add support for async notifiers handlers

2012-05-30 Thread Alon Levy
On Wed, May 30, 2012 at 12:02:36PM +0300, Yonit Halperin wrote: Signed-off-by: Yonit Halperin yhalp...@redhat.com One empty line that snuck in below. --- input.c |2 +- migration.c |2 +- notify.c | 79 +++---

Re: [Qemu-devel] [PATCH v2] hmp/qxl: info spice: add qxl info

2012-05-30 Thread Alon Levy
On Tue, May 29, 2012 at 01:44:35PM -0300, Luiz Capitulino wrote: On Tue, 29 May 2012 17:51:50 +0300 Alon Levy al...@redhat.com wrote: On Tue, May 29, 2012 at 10:38:20AM -0300, Luiz Capitulino wrote: On Tue, 29 May 2012 09:25:40 +0200 Gerd Hoffmann kra...@redhat.com wrote: Hi

Re: [Qemu-devel] [Spice-devel] [RFC PATCH 1/4] notifiers: add support for async notifiers handlers

2012-05-30 Thread Alon Levy
On Wed, May 30, 2012 at 12:02:36PM +0300, Yonit Halperin wrote: Signed-off-by: Yonit Halperin yhalp...@redhat.com One empty line that snuck in below. --- input.c |2 +- migration.c |2 +- notify.c | 79 +++---

Re: [Python-il] Awesome console debugger

2012-05-29 Thread Alon Levy
post - http://shlom.in/reply . ___ Python-il mailing list Python-il@hamakor.org.il http://hamakor.org.il/cgi-bin/mailman/listinfo/python-il -- Alon Levy ___ Python-il mailing list Python-il@hamakor.org.il

Re: [Spice-devel] A sever bug found in 64-bit WIndows 7 VM

2012-05-29 Thread Alon Levy
On Tue, May 29, 2012 at 02:58:19AM +, Charles.Tsai-蔡清海-研究發展部 wrote: Hi Vadim, Could you have a look? Thanks, Alon Bug description: A sever bug was found on 64-bit Windows 7 VM which crashed after running idle for a while(~ 2-3 hours). When we checked the kvm process, it was killed

Re: [Spice-devel] Question about qxl ram allocation

2012-05-29 Thread Alon Levy
On Tue, May 29, 2012 at 07:06:05PM +0800, Zhou Peng wrote: Hi all, As we know, 64M is default for qxl ram size. The default memory is 128MiB, not 64MiB - it's the sum of two 64 MiB bars, the size of each is settable. There is no help in the man page that I can find, the best you could do to

Re: [Qemu-devel] [PATCH v2] hmp/qxl: info spice: add qxl info

2012-05-29 Thread Alon Levy
On Tue, May 29, 2012 at 09:25:40AM +0200, Gerd Hoffmann wrote: Hi, How would that work? I have QXLInfo that only makes sense when the information is about a qxl device. Can't have opaque data in a QMP response, so would this be a info display qxl info display cirrus etc. or info qxl?

Re: [Qemu-devel] [PATCH v2] hmp/qxl: info spice: add qxl info

2012-05-29 Thread Alon Levy
On Tue, May 29, 2012 at 10:38:20AM -0300, Luiz Capitulino wrote: On Tue, 29 May 2012 09:25:40 +0200 Gerd Hoffmann kra...@redhat.com wrote: Hi, How would that work? I have QXLInfo that only makes sense when the information is about a qxl device. Can't have opaque data in a QMP

Re: [Spice-devel] [protocol RFC 0/2] RANDR support via QXLHead + SpiceHead

2012-05-28 Thread Alon Levy
On Fri, May 25, 2012 at 09:23:13AM +0200, Alexander Larsson wrote: On Mon, 2012-05-07 at 09:28 +0300, Alon Levy wrote: Hi, Currently we support multiple monitors by having: single pci = single display channel = single client window The RANDR architecture doesn't lend itself

Re: [Spice-devel] xf86-video-qxl performance

2012-05-28 Thread Alon Levy
:( The later is fixable with hw based compression. On Mon, May 28, 2012 at 11:19 AM, Alon Levy al...@redhat.com wrote: On Thu, May 24, 2012 at 01:24:05PM -0500, Jeremy White wrote: Actually, for WAN, we require ACK for 40 messages, but we allow sending up to 80, without getting an ack

Re: [Spice-devel] xf86-video-qxl performance

2012-05-28 Thread Alon Levy
On Mon, May 28, 2012 at 12:19:57PM +0300, Alon Levy wrote: On Thu, May 24, 2012 at 01:24:05PM -0500, Jeremy White wrote: Actually, for WAN, we require ACK for 40 messages, but we allow sending up to 80, without getting an ack for the first 40. From my experience with Windows guest

Re: [Qemu-devel] [PATCH 14/14] qapi: convert screendump

2012-05-28 Thread Alon Levy
On Fri, May 25, 2012 at 04:41:19PM -0300, Luiz Capitulino wrote: One small note below. Also activates error reporting from devices. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- console.c| 7 --- console.h| 1 - hmp-commands.hx | 5 ++--- hmp.c

Re: [Qemu-devel] [PATCH qmp-next 00/14]: qapi: convert screendump

2012-05-28 Thread Alon Levy
(or is very near to). Reviewed-by: Alon Levy al...@redhat.com console.c| 7 ++-- console.h| 5 +-- cutils.c | 100 +++ hmp-commands.hx | 5 ++- hmp.c| 9 + hmp.h| 1 + hw

Re: [Qemu-devel] [PATCH v2] hmp/qxl: info spice: add qxl info

2012-05-28 Thread Alon Levy
On Fri, May 25, 2012 at 11:43:11AM -0300, Luiz Capitulino wrote: On Thu, 24 May 2012 19:22:52 +0300 Alon Levy al...@redhat.com wrote: For all devices print id, mode and guest_bug status. Is qxl really tied to spice? In the meaning that it's impossible to use it without spice? Wouldn't

Re: [Qemu-devel] [PATCH v2] hmp/qxl: info spice: add qxl info

2012-05-28 Thread Alon Levy
On Mon, May 28, 2012 at 10:13:28AM -0300, Luiz Capitulino wrote: On Mon, 28 May 2012 12:08:13 +0300 Alon Levy al...@redhat.com wrote: On Fri, May 25, 2012 at 11:43:11AM -0300, Luiz Capitulino wrote: On Thu, 24 May 2012 19:22:52 +0300 Alon Levy al...@redhat.com wrote: For all

Re: [Spice-devel] xf86-video-qxl performance

2012-05-24 Thread Alon Levy
On Wed, May 23, 2012 at 03:20:21PM -0500, Jeremy White wrote: I need to improve the performance of the xf86-video-qxl driver; aka xspice; by a fairly substantial margin. I've set up a test case - LibreOffice over an 80 ms latency connection - that demonstrates that it's got quite a long way

Re: [Spice-devel] xf86-video-qxl performance

2012-05-24 Thread Alon Levy
On Wed, May 23, 2012 at 10:02:03PM -0400, Marc-André Lureau wrote: Hi - Mensaje original - Also, as a crazy idea, has anyone considered implementing a pure streaming video driver? That is, what if we had a frame buffer driver, and then a thread that fired 29 times a second to

Re: [Spice-devel] xf86-video-qxl performance

2012-05-24 Thread Alon Levy
On Wed, May 23, 2012 at 03:20:21PM -0500, Jeremy White wrote: I need to improve the performance of the xf86-video-qxl driver; aka xspice; by a fairly substantial margin. I've set up a test case - LibreOffice over an 80 ms latency connection - that demonstrates that it's got quite a long way

Re: [Spice-devel] [PATCH spice-server 1/2] server/red_channel: remove red_channel_client_item_being_sent

2012-05-24 Thread Alon Levy
On Thu, May 24, 2012 at 11:32:04AM +0300, Yonit Halperin wrote: The above routine was risky, since red_channel_client_init_send_data can also be called with item==NULL. Thus, not all pipe items can be tracked. The one call that was made for this routine was not necessary. Looks good, ACK

Re: [Spice-devel] QXL on Windows 8

2012-05-24 Thread Alon Levy
. Thanks a lot! /Mario On Mon, 21 May 2012 14:28:22 +0300, Alon Levy wrote: On Mon, May 21, 2012 at 10:47:05AM +0200, Mario wrote: Alon, thank you for your reply. Does this mean there is a bigger step to support Windows 8? Yes. We need to write a new driver, WDDM one, will probably share

Re: [PATCH] cvt: add -i/--interlaced to documentation

2012-05-24 Thread Alon Levy
On Wed, May 23, 2012 at 04:37:48PM -0700, Alan Coopersmith wrote: On 05/20/12 04:54 AM, Alon Levy wrote: Signed-off-by: Alon Levy al...@redhat.com cvt.c currently says: /* * I'm not documenting --interlaced for obvious reasons, even though I did * implement it. I also can't deny

Re: [Qemu-devel] [PATCHv2 1/3] ui/spice-display.c: add missing initialization for valgrind

2012-05-24 Thread Alon Levy
On Wed, May 23, 2012 at 08:59:22PM +0200, Gerd Hoffmann wrote: On 05/22/12 17:29, Alon Levy wrote: We can't initialize QXLDevSurfaceCreate field by field because it has a pa hole, and so 4 bytes remain uninitialized when building on x86-64, so just memset. So you get valgrind warnings

[Qemu-devel] [PATCH 1/4] ui/spice-display.c: add missing initialization for valgrind

2012-05-24 Thread Alon Levy
We can't initialize QXLDevSurfaceCreate field by field because it has a pa hole, and so 4 bytes remain uninitialized when building on x86-64, so just memset. Signed-off-by: Alon Levy al...@redhat.com --- ui/spice-display.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/ui/spice

[Qemu-devel] [PATCH 2/4] hw/qxl: s/qxl_guest_bug/qxl_set_guest_bug/

2012-05-24 Thread Alon Levy
Signed-off-by: Alon Levy al...@redhat.com --- hw/qxl.c | 49 +++-- hw/qxl.h |3 ++- 2 files changed, 29 insertions(+), 23 deletions(-) diff --git a/hw/qxl.c b/hw/qxl.c index 3da3399..8777ba9 100644 --- a/hw/qxl.c +++ b/hw/qxl.c @@ -30,7 +30,7

[Qemu-devel] [PATCH 4/4] qxl: stop dirty loging when not in vga mode

2012-05-24 Thread Alon Levy
Tested with linux guest. Not sure how to check actual performance affect of this. Checked with the previously send traceevent that the kvm ioctl to start/stop dirty logging is being called. (KVM_SET_USER_MEMORY_REGION). Signed-off-by: Alon Levy al...@redhat.com --- hw/qxl.c |2 ++ 1 file

Re: [Qemu-devel] [PATCH 1/4] ui/spice-display.c: add missing initialization for valgrind

2012-05-24 Thread Alon Levy
On Thu, May 24, 2012 at 12:38:11PM +0300, Alon Levy wrote: We can't initialize QXLDevSurfaceCreate field by field because it has a pa hole, and so 4 bytes remain uninitialized when building on x86-64, so just memset. This was supposed to be in reply to 4fbdf65f.8070...@redhat.com, rebased

[Qemu-devel] [PATCH 3/4] hmp/qxl: info spice: add qxl info

2012-05-24 Thread Alon Levy
For all devices print id, mode and guest_bug status. Known problems: Prints devices from highest id to lowest. Signed-off-by: Alon Levy al...@redhat.com --- hmp.c| 11 +++ hw/qxl.c | 22 ++ qapi-schema.json | 47

[Qemu-devel] [PATCH] hmp/qxl: info spice: add qxl info

2012-05-24 Thread Alon Levy
For all devices print id, mode and guest_bug status. Known problems: Prints devices from highest id to lowest. Signed-off-by: Alon Levy al...@redhat.com --- Fixed the documentation to match the command (no more qxl0). Sending to QMP maintainers per Kraxel's request for an additional ack. Alon

Re: [Qemu-devel] [PATCH] hmp/qxl: info spice: add qxl info

2012-05-24 Thread Alon Levy
On Thu, May 24, 2012 at 06:09:51PM +0300, Alon Levy wrote: For all devices print id, mode and guest_bug status. Known problems: Prints devices from highest id to lowest. Signed-off-by: Alon Levy al...@redhat.com --- Fixed the documentation to match the command (no more qxl0). Sending

Re: [Qemu-devel] [PATCH 3/4] hmp/qxl: info spice: add qxl info

2012-05-24 Thread Alon Levy
On Thu, May 24, 2012 at 02:58:40PM +0200, Gerd Hoffmann wrote: On 05/24/12 11:38, Alon Levy wrote: For all devices print id, mode and guest_bug status. Queued up 1+2+4 Please unqueue qxl: stop dirty loging when not in vga mode and I'll send it again with the separate patch hw/qxl: ignore

[Qemu-devel] [PATCH 1/2] qxl: stop dirty loging when not in vga mode

2012-05-24 Thread Alon Levy
Tested with linux guest. Not sure how to check actual performance affect of this. Checked with the previously send traceevent that the kvm ioctl to start/stop dirty logging is being called. (KVM_SET_USER_MEMORY_REGION). Signed-off-by: Alon Levy al...@redhat.com --- These are the two patches

[Qemu-devel] [PATCH 2/2] hw/qxl: ignore guest from guestbug until reset

2012-05-24 Thread Alon Levy
soft_reset is called from any of: * QXL_IO_RESET * vga io * pci reset handler Signed-off-by: Alon Levy al...@redhat.com --- hw/qxl.c | 13 - hw/qxl.h |3 +++ 2 files changed, 15 insertions(+), 1 deletion(-) diff --git a/hw/qxl.c b/hw/qxl.c index 5a7be60..b5e53ce 100644

[Qemu-devel] [PATCH v2] hmp/qxl: info spice: add qxl info

2012-05-24 Thread Alon Levy
For all devices print id, mode and guest_bug status. Known problems: Prints devices from highest id to lowest. Signed-off-by: Alon Levy al...@redhat.com --- This one builds. Fixed qapi-schema to say additions are for 1.2 hmp.c| 11 +++ hw/qxl.c | 22

<    6   7   8   9   10   11   12   13   14   15   >