Re: [Spice-devel] [Users] multiple concurrent spice consoles (was Ovirt + Spice + VDI)

2012-09-13 Thread Alon Levy
Hi Mohsen, multiple sessions to the single VM are not on the roadmap. There is experimental multi-client support but it is to make more users see the same session. Moshen, I misunderstood. In this case, I guess I don't actually see how we could fix your problem without circumventing any

Re: [Spice-devel] [PATCH 1/3] vdagent: add message_queue for messages written to pipe

2012-09-13 Thread Alon Levy
This is only part of the message corruption solution. The other part is fixing virtio-serial / spice-qemu-char throttling code. -replace write_[lock/unlock/completion] calls with [new/enqueue]_message -remove clipboard specific _out_msg_* class members -remove ugly loop - while

Re: [Spice-devel] [PATCH spice-html5] rewrite quic.js to be a native javascript implementation

2012-09-13 Thread Alon Levy
On Wed, Sep 12, 2012 at 11:22:14AM -0500, Aric Stewart wrote: there remain a few TODOs including implementing more than just rgb32 images Signed-off-by: Aric Stewart a...@codeweavers.com [cut to avoid bombarding the list] I can't actually review this, although it seems like a great

Re: [Spice-devel] [PATCH spice-html5] rewrite quic.js to be a native javascript implementation

2012-09-13 Thread Alon Levy
Alon Levy píše v Čt 13. 09. 2012 v 10:31 -0400: On Wed, Sep 12, 2012 at 11:22:14AM -0500, Aric Stewart wrote: there remain a few TODOs including implementing more than just rgb32 images Signed-off-by: Aric Stewart a...@codeweavers.com [cut to avoid bombarding the list

Re: [Spice-devel] [PATCH] Simplify memory management for the primary screen.

2012-09-13 Thread Alon Levy
Passing NULL for pbits into fbScreenInit is a treacherous thing to do. It works, because we rapidly resize the screen, and because the normal path never uses the screen pixmap. However, having NULL for pbits has side effects that derive from the fact that NULL prevents ModifyPixmapHeader

Re: [Spice-devel] [PATCH spice-html5] rewrite quic.js to be a native javascript implementation

2012-09-13 Thread Alon Levy
patch at line 35649: ) -aric On 9/13/12 9:58 AM, Alon Levy wrote: Alon Levy píše v Čt 13. 09. 2012 v 10:31 -0400: On Wed, Sep 12, 2012 at 11:22:14AM -0500, Aric Stewart wrote: there remain a few TODOs including implementing more than just rgb32 images Signed-off-by: Aric Stewart

Re: [Spice-devel] [PATCH spice-html3]rewrite quic.js to be a native javascript implementation

2012-09-13 Thread Alon Levy
Resent as a patch because of line wrapping issues there remain a number of todos including implementing more than just rgb32 images Somehow it still required manual merging. I think I got it right, but please check; Yes, the pushed patch.. next time I'll push to some other tree to avoid

Re: [Spice-devel] [PATCH] Unify memory management for the primary screen.

2012-09-13 Thread Alon Levy
We never actually connected the host_image pixmap to the primary screen, because we never operate on the bits of the primary screen. This causes problems if we wish to use traditional X operations to modify the primary screen, as they will fail and corrupt memory as they go. Looks good to

Re: [Spice-devel] [spice-gtk 2/2] cursor: don't access unitialized data when logging

2012-09-13 Thread Alon Levy
SpiceCursor::header is only valid when SPICE_CURSOR_FLAGS_NONE is not set in SpiceCursor::flags, so don't try to log info about the header before we have tested this flag. ACK both. --- gtk/channel-cursor.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git

Re: [Spice-devel] [spice-common] Fix type of SpiceCursorHeader::type

2012-09-13 Thread Alon Levy
On Thu, Sep 13, 2012 at 05:53:39PM +0200, Christophe Fergeau wrote: In spice.proto it's defined as enum8 cursor_type type;, which means it's demarshalled as an uint8_t. This caused valgrind warnings about using uninitialized memory during a connection to a VM with remote-viewer Forget

Re: [PATCH modesetting] drmmode_display: add DRM_MODE_CONNECTOR_VIRTUAL to output_names

2012-09-13 Thread Alon Levy
ping? Added by a7331e5cb, since v3.2-rc1 Signed-off-by: Alon Levy al...@redhat.com --- src/drmmode_display.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/drmmode_display.c b/src/drmmode_display.c index 5e38265..e455de9 100644 --- a/src/drmmode_display.c

Re: [Spice-devel] [spice-protocol PATCH v2 0.12.2 1/2] qxl_dev.h: add client monitors configuration notification to guest

2012-09-12 Thread Alon Levy
On 09/11/12 17:32, Alon Levy wrote: Hi, On 09/11/2012 04:35 PM, Alon Levy wrote: So far we have used the agent to notify the guest of a request to change the monitors configurations (heads) on the qxl device. This patch introduces a new interrupt and new fields in the qxl rom

Re: [Spice-devel] [PATCH xf86-video-qxl] src/qxl_driver: use the new dixScreenSpecificPrivatesSize

2012-09-12 Thread Alon Levy
Jeremy White jwh...@codeweavers.com writes: Hey Alon (and all), Could this patch be done instead with an #ifdef on XORG_VERSION_CURRENT? It'd be nice if the tip of spice could continue to be useful with older Xorgs (said a guy who's focused on RHEL development... :-/). If

[Spice-devel] [PATCH 0/3] client monitors config support

2012-09-12 Thread Alon Levy
v3: - no addition of guest capabilities, use interrupt mask instead, ignore 0 or ~0 that are set by current windows driver. - use crc to solve possible write while read. - limit heads to 64, statically allocated on rom by host. - some misc trace fixes. QEMU: Alon Levy (3): hw/qxl

[Spice-devel] [PATCH 1/3] hw/qxl: tracing fixes

2012-09-12 Thread Alon Levy
Add two new trace events: qxl_send_events(int qid, uint32_t events) %d %d qxl_set_guest_bug(int qid) %d Change qxl_io_unexpected_vga_mode parameters to be equivalent to those of qxl_io_write for easier grouping under a single systemtap probe. Change d to qxl in one place. Signed-off-by: Alon

[Spice-devel] [PATCH 2/3] qxl: add trace-event for QXL_IO_LOG

2012-09-12 Thread Alon Levy
Signed-off-by: Alon Levy al...@redhat.com --- hw/qxl.c | 1 + trace-events | 1 + 2 files changed, 2 insertions(+) diff --git a/hw/qxl.c b/hw/qxl.c index 94eb3c8..12dfc79 100644 --- a/hw/qxl.c +++ b/hw/qxl.c @@ -1503,6 +1503,7 @@ async_common: qxl_set_mode(d, val, 0); break

[Spice-devel] [PATCH 3/3] hw/qxl: support client monitor configuration via device

2012-09-12 Thread Alon Levy
the interrupt is enabled, and if so and given a non NULL monitors config will generate an interrupt QXL_INTERRUPT_CLIENT_MONITORS_CONFIG with crc checksum for the guest to verify a second call hasn't interfered. The maximal number of monitors is limited on the QXLRom to 64. Signed-off-by: Alon Levy al

[Spice-devel] [PATCH spice-protocol v2 1/2] qxl_dev.h: add client monitors configuration notification to guest

2012-09-12 Thread Alon Levy
So far we have used the agent to notify the guest of a request to change the monitors configurations (heads) on the qxl device. This patch introduces a new interrupt and new fields in the qxl rom to notify the guest about a new request, similarly to how physical hardware notifies the driver. To

[Spice-devel] [PATCH spice-protocol v2 2/2] Release 0.12.2

2012-09-12 Thread Alon Levy
New in this release: display channel: A8 surface capability qxl: client present, client capabilities and client monitors configuration. --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index b4a9cca..d80c360 100644 ---

[Spice-devel] [PATCH spice-common] Update spice-protocol module

2012-09-12 Thread Alon Levy
Add support for client monitors config in qxl device. --- spice-protocol | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/spice-protocol b/spice-protocol index 361fd16..9170263 16 --- a/spice-protocol +++ b/spice-protocol @@ -1 +1 @@ -Subproject commit

[Spice-devel] [PATCH spice v3 1/7] server/red_dispatcher: change a printerr to debug

2012-09-12 Thread Alon Levy
--- server/red_dispatcher.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/server/red_dispatcher.c b/server/red_dispatcher.c index 69d4f0a..3a4229e 100644 --- a/server/red_dispatcher.c +++ b/server/red_dispatcher.c @@ -91,7 +91,7 @@ static void

[Spice-devel] [PATCH spice v3 2/7] update spice-common module

2012-09-12 Thread Alon Levy
For qxl client_monitors_config support. --- spice-common | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/spice-common b/spice-common index f67bcd0..31c5fc1 16 --- a/spice-common +++ b/spice-common @@ -1 +1 @@ -Subproject commit f67bcd03e92c2d04f987135ad9b467c93fd47908

[Spice-devel] [PATCH spice v3 3/7] server: add QXLInterface::client_monitors_config

2012-09-12 Thread Alon Levy
Used to implement guest monitor configuration change similarly to real hardware in conjunction with the new qemu interrupt QXL_INTERRUPT_CLIENT_MONITORS_CONFIG. client_monitors_config is also used to probe the support by the interface. If it is not supported we send the message to the guest agent.

[Spice-devel] [PATCH spice v3 4/7] server/red_dispatcher: client_monitors_config support

2012-09-12 Thread Alon Levy
Adds two functions: - red_dispatcher_use_client_monitors_config: check that QXLInterface supports client_monitors_config and that it's functional. - red_dispatcher_client_monitors_config: send the client monitors configuration to the guest. --- server/red_dispatcher.c | 49

[Spice-devel] [PATCH spice v3 5/7] server: Filter VD_AGENT_MONITORS_CONFIG

2012-09-12 Thread Alon Levy
If the guest supports client monitors config we pass it the VDAgentMonitorsConfig message via the QXLInterface::client_monitors_config api instead of via the vdagent. --- server/agent-msg-filter.c | 8 ++ server/agent-msg-filter.h | 1 + server/reds.c | 65

[Spice-devel] [PATCH spice v3 6/7] server/tests: agent mock, client_monitors_config

2012-09-12 Thread Alon Levy
--- server/tests/basic_event_loop.c| 2 +- server/tests/test_display_base.c | 46 ++ server/tests/test_display_base.h | 1 + server/tests/test_display_no_ssl.c | 1 + 4 files changed, 49 insertions(+), 1 deletion(-) diff --git

[Spice-devel] [PATCH spice v3 7/7] spice-server 0.11.5

2012-09-12 Thread Alon Levy
Added api: QXL interface (3.2) client_monitors_config --- configure.ac | 6 +++--- server/spice.h | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/configure.ac b/configure.ac index 1c57110..0545af6 100644 --- a/configure.ac +++ b/configure.ac @@ -12,10 +12,10 @@

Re: [Spice-devel] [PATCH spice-protocol v2 1/2] qxl_dev.h: add client monitors configuration notification to guest

2012-09-12 Thread Alon Levy
Hi, On 09/12/2012 03:13 PM, Alon Levy wrote: So far we have used the agent to notify the guest of a request to change the monitors configurations (heads) on the qxl device. This patch introduces a new interrupt and new fields in the qxl rom to notify the guest about a new request

[Spice-devel] [PATCH spice v4 1/2] server/reds: reuse already defined local

2012-09-12 Thread Alon Levy
--- server/reds.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/server/reds.c b/server/reds.c index 98b316d..57ce88b 100644 --- a/server/reds.c +++ b/server/reds.c @@ -1208,7 +1208,7 @@ void reds_on_main_agent_data(MainChannelClient *mcc, void *message, size_t size)

[Spice-devel] [PATCH spice v4 2/2] server: Filter VD_AGENT_MONITORS_CONFIG

2012-09-12 Thread Alon Levy
If the guest supports client monitors config we pass it the VDAgentMonitorsConfig message via the QXLInterface::client_monitors_config api instead of via the vdagent. --- server/agent-msg-filter.c | 8 +++ server/agent-msg-filter.h | 1 + server/reds.c | 55

[Qemu-devel] [PATCH 0/3] client monitors config support

2012-09-12 Thread Alon Levy
v3: - no addition of guest capabilities, use interrupt mask instead, ignore 0 or ~0 that are set by current windows driver. - use crc to solve possible write while read. - limit heads to 64, statically allocated on rom by host. - some misc trace fixes. QEMU: Alon Levy (3): hw/qxl

[Qemu-devel] [PATCH 3/3] hw/qxl: support client monitor configuration via device

2012-09-12 Thread Alon Levy
the interrupt is enabled, and if so and given a non NULL monitors config will generate an interrupt QXL_INTERRUPT_CLIENT_MONITORS_CONFIG with crc checksum for the guest to verify a second call hasn't interfered. The maximal number of monitors is limited on the QXLRom to 64. Signed-off-by: Alon Levy al

[Qemu-devel] [PATCH 2/3] qxl: add trace-event for QXL_IO_LOG

2012-09-12 Thread Alon Levy
Signed-off-by: Alon Levy al...@redhat.com --- hw/qxl.c | 1 + trace-events | 1 + 2 files changed, 2 insertions(+) diff --git a/hw/qxl.c b/hw/qxl.c index 94eb3c8..12dfc79 100644 --- a/hw/qxl.c +++ b/hw/qxl.c @@ -1503,6 +1503,7 @@ async_common: qxl_set_mode(d, val, 0); break

[Qemu-devel] [PATCH 1/3] hw/qxl: tracing fixes

2012-09-12 Thread Alon Levy
Add two new trace events: qxl_send_events(int qid, uint32_t events) %d %d qxl_set_guest_bug(int qid) %d Change qxl_io_unexpected_vga_mode parameters to be equivalent to those of qxl_io_write for easier grouping under a single systemtap probe. Change d to qxl in one place. Signed-off-by: Alon

Re: [Autotest] [PATCH] client: Add systemtap profiler

2012-09-11 Thread Alon Levy
From: Yunping Zheng yunzh...@redhat.com This patch adds a systemtap profiler to autotest. Now systemtap can run during your test, providing useful debug data. When you use this profiler on virt tests, you should add 'profilers = systemtap' and 'stap_script_file =

Re: [Spice-devel] [Spice-commits] 5 commits - client/display_channel.cpp server/red_worker.c server/spice.h

2012-09-11 Thread Alon Levy
Alon Levy al...@redhat.com writes: The solution is the SPICE_INTERFACE_QXL_MAJOR SPICE_INTERFACE_QXL_MINOR versions which are stored in the compiled qemu binary in hw/qxl.c:qxl_interface Any change to the QXLInterface must be accompanied by a change to those two constants

Re: [Spice-devel] [PATCH] Bump SPICE_INTERFACE_QXL_VERSION_MINOR

2012-09-11 Thread Alon Levy
From: Søren Sandmann Pedersen s...@redhat.com Ignore the mail I sent you about bumping to 3.2 regardless - I forgot you need to actually check the fields. So ack, I'll respin my 3.2 patch to use 3.3. Then check that we have the right version before accessing the set_client_capabilities()

Re: [Spice-devel] Failure to compile [was: [Spice-commits] gtk/channel-display.c]

2012-09-11 Thread Alon Levy
On Mon, Sep 10, 2012 at 10:57:15AM -0400, Alon Levy wrote: On Mon, Sep 10, 2012 at 12:08:30PM +0300, Yaniv Kaul wrote: Confirmed, great and thanks. I'd be happy if we could avoid such situations in the future. I know we (used to?) have a build-bot for Spice. Is it alive

[Spice-devel] [spice-protocol PATCH v2 0.12.2 1/2] qxl_dev.h: add client monitors configuration notification to guest

2012-09-11 Thread Alon Levy
So far we have used the agent to notify the guest of a request to change the monitors configurations (heads) on the qxl device. This patch introduces a new interrupt and new fields in the qxl rom to notify the guest about a new request, similarly to how physical hardware notifies the driver. To

[Spice-devel] [spice-protocol PATCH v2 0.12.2 2/2] Release 0.12.2

2012-09-11 Thread Alon Levy
New in this release: display channel: A8 surface capability qxl: client present, client capabilities, client monitors configuration and guest capabilities. --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index

Re: [Spice-devel] [spice-protocol PATCH v2 0.12.2 1/2] qxl_dev.h: add client monitors configuration notification to guest

2012-09-11 Thread Alon Levy
Hi, On 09/11/2012 04:35 PM, Alon Levy wrote: So far we have used the agent to notify the guest of a request to change the monitors configurations (heads) on the qxl device. This patch introduces a new interrupt and new fields in the qxl rom to notify the guest about a new request

Re: [Qemu-devel] [PATCH 3/3] hw/qxl: support client monitor configuration via device

2012-09-11 Thread Alon Levy
On 09/11/12 08:56, Alon Levy wrote: Until now we used only the agent to change the monitor count and each monitor resolution. This patch introduces the qemu part of using the device as the mediator instead of the agent via virtio-serial. Spice (=0.11.5) calls the new QXLInterface

Re: [Qemu-devel] [PATCH 3/3] hw/qxl: support client monitor configuration via device

2012-09-11 Thread Alon Levy
Hi, I don't think an explicit handshake via QXL_IO_CLIENT_MONITORS_CONFIG_DONE is a good idea. Why? I don't see the below as being better - it just moves the checking to the guest, and racily. It is more robust. I suggested a way for it to be as robust - I take robust to mean no

Re: [Qemu-devel] [PATCH 3/3] hw/qxl: support client monitor configuration via device

2012-09-11 Thread Alon Levy
Hi, Sorry for top posting, but trying to summarize this thread here. I must say I like Gerd's approach, as it unifies code paths mostly, instead of having yet another interface where we do 2 way capabilities negotiation, with all the extra test matrix entries that would entice for full

Re: [Qemu-devel] [PATCH 3/3] hw/qxl: support client monitor configuration via device

2012-09-11 Thread Alon Levy
Hi, Sorry for top posting, but trying to summarize this thread here. I must say I like Gerd's approach, as it unifies code paths mostly, instead of having yet another interface where we do 2 way capabilities negotiation, with all the extra test matrix entries that would entice

Re: [Qemu-devel] [PATCH 3/3] hw/qxl: support client monitor configuration via device

2012-09-11 Thread Alon Levy
Hi, This will need spice-server - qemu/hw/qxl.c coordination, but I assume we will need some changes there anyway to set QXL_INTERRUPT_CLIENT_MONITORS_CONFIG, the qemu/hw/qxl.c function patching the MonitorsConfig into the romspace, and setting the irq in int_pending, could return

Re: [Qemu-devel] [PATCH 3/3] hw/qxl: support client monitor configuration via device

2012-09-11 Thread Alon Levy
ok, I'm missing something here. (and trying to catch up via Vol 3A is taking too long). I thought the order is: (1) qemu raises interrupt (2) qemu calls kvm ioctl (3) guest interrupt handler (4) guest clears interrupt by writing ~0 to qxl ram_header-int_mask. (5) qemu detects

Re: [Qemu-devel] [PATCH 3/3] hw/qxl: support client monitor configuration via device

2012-09-11 Thread Alon Levy
Hi, On 09/11/2012 03:05 PM, Alon Levy wrote: ok, I'm missing something here. (and trying to catch up via Vol 3A is taking too long). I thought the order is: (1) qemu raises interrupt (2) qemu calls kvm ioctl (3) guest interrupt handler (4) guest clears interrupt by writing ~0

[Qemu-devel] [PATCH] dtrace backend: add function to reserved words

2012-09-11 Thread Alon Levy
Signed-off-by: Alon Levy al...@redhat.com --- scripts/tracetool/backend/dtrace.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/tracetool/backend/dtrace.py b/scripts/tracetool/backend/dtrace.py index 9cab75c..6be7047 100644 --- a/scripts/tracetool/backend/dtrace.py

[Qemu-devel] [PATCH 1/3] hw/qxl: tracing fixes

2012-09-11 Thread Alon Levy
Add two new trace events: qxl_send_events(int qid, uint32_t events) %d %d qxl_set_guest_bug(int qid) %d Change qxl_io_unexpected_vga_mode parameters to be equivalent to those of qxl_io_write for easier grouping under a single systemtap probe. Change d to qxl in one place. Signed-off-by: Alon

[Qemu-devel] [PATCH 2/3] hw/qxl: add support for QXL_IO_CAPABILITIES_SET

2012-09-11 Thread Alon Levy
Guest set capabilities are written to the spice server via spice_qxl_guest_capabilities_set, provided the compiled against spice server is new enough to provide this symbol. QXL device revision will be raised in a later patch to advertise this support to the guest. Signed-off-by: Alon Levy al

[Qemu-devel] [PATCH 3/3] hw/qxl: support client monitor configuration via device

2012-09-11 Thread Alon Levy
before issuing the interrupt. (this is in addition to spice checking for the same capability). Signed-off-by: Alon Levy al...@redhat.com --- hw/qxl.c | 75 hw/qxl.h | 2 ++ trace-events | 5 3 files changed, 82 insertions

Re: [Qemu-devel] [PATCH] qxl: better cleanup for surface destroy

2012-09-11 Thread Alon Levy
Add back a call to qxl_spice_destroy_surface_wait_complete() in qxl_spice_destroy_surface_wait(), that was removed by commit c480bb7da465186b84d8427e068ef7502e47ffbf It is needed to complete surface-removal cleanup, for non async. For async, qxl_spice_destroy_surface_wait_complete is called

Re: [Qemu-devel] [PATCH 0/4] linux framebuffer display driver

2012-09-11 Thread Alon Levy
Hi, Undusting an pretty old patch series, rebasing it, testing it, fixing a bug or two, fixing codestyle issues: Qemu can run on the linux framebuffer console as graphical display now. Patch 4 doesn't apply (hmp.h), missing SoB on a few patches. Tested with Seabios. Works as advertised,

Re: [Spice-devel] spice @ arm

2012-09-10 Thread Alon Levy
Hi, FYI: spice reportly works just fine on arm, see: https://bugzilla.redhat.com/show_bug.cgi?id=613529 Just a little configure patch is required. So this is running the spicec client? we need to get remote-viewer working then. I've done n900 package a long time ago, so I think this is

Re: [Spice-devel] [warning reduction 00/11] Eliminating warnings in xf86-video-qxl

2012-09-10 Thread Alon Levy
The following patch series remove nearly all warnings from xf86-video-qxl. The final one does not remove a warning, but documents the related code with a TODO as the warning appears to be correct. You still get a large number of redudant decl warnings from two xorg include files even

[Spice-devel] [spice-protocol PATCH 2/2] qxl_dev.h: add client monitors configuration notification to guest

2012-09-10 Thread Alon Levy
so far we have used the agent to notify the guest of a request to change the monitors configurations (heads) on the qxl device. This patch introduces a new interrupt and new fields in the qxl rom to notify the guest about a new request, similarly to how physical hardware notifies the driver. To

Re: [Spice-devel] [PATCH 2/3] vdagent: don't stop due to UIPI blocking

2012-09-10 Thread Alon Levy
ACK with one question. User Interface Privilege Isolation is usually used only for specific windows of system security applications (anti-viruses etc.), so with this patch mouse will be irresponsive for these windows but keep working for the rest. A complete solution might be switching to

Re: [Spice-devel] Failure to compile [was: [Spice-commits] gtk/channel-display.c]

2012-09-10 Thread Alon Levy
On Mon, Sep 10, 2012 at 12:08:30PM +0300, Yaniv Kaul wrote: Confirmed, great and thanks. I'd be happy if we could avoid such situations in the future. I know we (used to?) have a build-bot for Spice. Is it alive and working? It was working a few weeks ago since I got a broken build

[Spice-devel] [PATCH 0/7] guest features and client_monitors_config

2012-09-10 Thread Alon Levy
bump for the new client features implemented by Soren. Alon Levy (7): server/red_dispatcher: change a printerr to debug server/spice.h: add spice_qxl_guest_capabilities_set server: add QXLInterface::client_monitors_config server/red_dispatcher: client_monitors_config support server: Filter

[Spice-devel] [PATCH 1/7] server/red_dispatcher: change a printerr to debug

2012-09-10 Thread Alon Levy
--- server/red_dispatcher.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/server/red_dispatcher.c b/server/red_dispatcher.c index 69d4f0a..3a4229e 100644 --- a/server/red_dispatcher.c +++ b/server/red_dispatcher.c @@ -91,7 +91,7 @@ static void

[Spice-devel] [PATCH 2/7] server/spice.h: add spice_qxl_guest_capabilities_set

2012-09-10 Thread Alon Levy
Allow spice to know about guest driver capabilities. Implements spice api complement to qemu QXL_IO_CAPABILITIES_SET. Implementation in red_dispatcher. Stores a copy of guest capabilities. --- server/red_dispatcher.c | 20 server/spice-server.syms | 1 + server/spice.h

[Spice-devel] [PATCH 3/7] server: add QXLInterface::client_monitors_config

2012-09-10 Thread Alon Levy
Used to implement guest monitor configuration change similarly to real hardware in conjunction with the new qemu interrupt QXL_INTERRUPT_CLIENT_MONITORS_CONFIG. Together with the added guest capabilities allows to select the right mode during runtime. This makes a linux qxl driver similar to

[Spice-devel] [PATCH 4/7] server/red_dispatcher: client_monitors_config support

2012-09-10 Thread Alon Levy
Adds two functions: red_dispatcher_use_client_monitors_config: - checks the guest for the QXL_GUEST_CAP_CLIENT_MONITORS_CONFIG_ISR cap, and that QXLInterface is new enough to support cap checking and client_monitors_config callback, returns TRUE if so. -

[Spice-devel] [PATCH 5/7] server: Filter VD_AGENT_MONITORS_CONFIG

2012-09-10 Thread Alon Levy
If the guest supports client monitors config we pass it the VDAgentMonitorsConfig message via the QXLInterface::client_monitors_config api instead of via the vdagent. --- server/agent-msg-filter.c | 8 ++ server/agent-msg-filter.h | 1 + server/reds.c | 65

[Spice-devel] [PATCH 7/7] server/tests: agent mock, guest_capabilities test

2012-09-10 Thread Alon Levy
--- server/tests/Makefile.am | 8 ++ server/tests/basic_event_loop.c| 2 +- server/tests/test_display_base.c | 46 ++ server/tests/test_display_base.h | 1 + server/tests/test_display_no_ssl.c | 1 +

[Spice-devel] [spice-protocol PATCH] Release 0.12.2

2012-09-10 Thread Alon Levy
New in this release: display channel: A8 surface capability qxl: client present, client capabilities, client monitors configuration and guest capabilities. --- This is on top of the two outstanding spice-protocol patches, required for qemu to use the new api for client monitors

Re: [Spice-devel] [PATCH] Enable the use of SpiceExitOnDisconnect so that Xspice can be configured to allow exactly one server per client session.

2012-09-09 Thread Alon Levy
Ack. --- src/qxl.h |1 + src/qxl_driver.c|2 ++ src/spiceqxl_spice_server.c | 12 3 files changed, 15 insertions(+) diff --git a/src/qxl.h b/src/qxl.h index 8494550..03d08a1 100644 --- a/src/qxl.h +++ b/src/qxl.h @@ -125,6 +125,7

Re: [Spice-devel] [Spice-commits] 5 commits - client/display_channel.cpp server/red_worker.c server/spice.h

2012-09-09 Thread Alon Levy
Hi, On 09/07/2012 06:09 PM, Søren Sandmann Pedersen wrote: client/display_channel.cpp |1 + server/red_worker.c| 31 +++ server/spice.h |5 - 3 files changed, 36 insertions(+), 1 deletion(-) New commits: commit

Re: [Spice-devel] [spice-html5] implement handing of MJPEG display streams

2012-09-06 Thread Alon Levy
On 08/27/2012 11:21 AM, Jeremy White wrote: ACK On 08/27/2012 10:59 AM, Aric Stewart wrote: Signed-off-by: Aric Stewart a...@codeweavers.com I did just check, and I don't have write access, so I can't push this myself. Help? Pushed. Thanks, Jeremy

Re: [Spice-devel] [ spice-devel ] libspice server segfault

2012-09-06 Thread Alon Levy
in ?? () from /lib/libpthread.so.0 #14 0x7f625c926fcd in clone () from /lib/libc.so.6 2012/9/5 Alon Levy al...@redhat.com: Yes it happens with and without -vnc qemu cmdline Nicolas 2012/9/5 Alon Levy al...@redhat.com: Right after the segfault, before

Re: [Qemu-devel] [PATCH v2 0/4] spice: improve vga mode performance

2012-09-06 Thread Alon Levy
On Thu, Sep 06, 2012 at 07:39:23AM +0200, Gerd Hoffmann wrote: Hi, Series is Reviewed-by: Alon Levy al...@redhat.com This patch series makes spice be more clever on screen updates when in vga mode (i.e. without qxl guest driver loaded or when using a non-qxl vga card). qemu keeps

Re: [fedora-virt] Problem with mouse (cursor) in VM

2012-09-05 Thread Alon Levy
On 09/04/2012 04:06 AM, John W. Himpel wrote: Good evening, I am running F18 inside a VM (KVM). The base OS is a current F17. I am using the qxl video driver. It seems the mouse driver is confused about the coordinates of the cursor as it continually attempts to reduce the

Re: [fedora-virt] Problem with mouse (cursor) in VM

2012-09-05 Thread Alon Levy
Good evening, I am running F18 inside a VM (KVM). The base OS is a current F17. I am using the qxl video driver. It seems the mouse driver is confused about the coordinates of the cursor as it continually attempts to reduce the application into the Activities mode (show the panel with

Re: [fedora-virt] Problem with mouse (cursor) in VM

2012-09-05 Thread Alon Levy
On 04/09/12 02:06, John W. Himpel wrote: Good evening, I am running F18 inside a VM (KVM). The base OS is a current F17. I am using the qxl video driver. I thougth the qxl driver was borked at the moment. Can you test it with another driver? I pushed a fixed one, if you have any

Re: [fedora-virt] Problem with mouse (cursor) in VM

2012-09-05 Thread Alon Levy
On Wed, 2012-09-05 at 04:16 -0400, Alon Levy wrote: Good evening, I am running F18 inside a VM (KVM). The base OS is a current F17. I am using the qxl video driver. It seems the mouse driver is confused about the coordinates of the cursor as it continually attempts

[Spice-devel] [PATCH] add registry key DisableSurfaces

2012-09-05 Thread Alon Levy
Presence of the key disables off screen surfaces creation; The callback is still registered, but it always fails. Registry key is checked on device initialization only, not during runtime, so you must reset the vm to see any affects. --- display/driver.c | 11 +++ display/driver.rc

Re: [Spice-devel] [ spice-devel ] libspice server segfault

2012-09-05 Thread Alon Levy
-next = item-next-prev = item; Regards, Nicolas 2012/9/4 Alon Levy al...@redhat.com: hello libspice 0.11.3 qemu 1.2rc2 In windows XP Guest VM , Change screensaver ( with small preview windows change) causes a segfault in libspice server . I can always reproduce it , two

Re: [Spice-devel] [ spice-devel ] libspice server segfault

2012-09-05 Thread Alon Levy
Yes it happens with and without -vnc qemu cmdline Nicolas 2012/9/5 Alon Levy al...@redhat.com: Right after the segfault, before thread apply all bt, can you please run p item p item-next info locals Thanks, Alon and with all threads : bego3 ~ # cat /storage/tmp/log6 warning: Unable

Re: [Spice-devel] [PATCH] add registry key DisableSurfaces

2012-09-05 Thread Alon Levy
ack w minor notes All correct, I'll fix and push. Alon Levy wrote: Presence of the key disables off screen surfaces creation; The callback is still registered, but it always fails. Registry key is checked on device initialization only, not during runtime, so you must reset the vm

Re: [Spice-devel] [rebase] Implement spice_server_set_exit_on_disconnect to enable an option whereby the spice server shuts down on client disconnect.

2012-09-05 Thread Alon Levy
oops, I think I acked this already, I'll apply now. Sorry Soren, you'll have to rebase your configure change. - Original Message - --- configure.ac |6 +++--- server/reds.c| 14 ++ server/spice-server.syms |4 server/spice.h

Re: [Spice-devel] [PATCH] server/red_parse_qxl: add bitmap consistency check

2012-09-04 Thread Alon Levy
On 09/03/2012 07:24 PM, Alon Levy wrote: Just checks stride vs width times bpp. This fixes a potential abort on guest generated bad images in glz_encoder. Other files touched to move some consts to red_common, they are static so no problem to be defined in both red_worker.c

[Spice-devel] [PATCH] server: add dist-hook to prevent spice version configure/spice.h difference

2012-09-03 Thread Alon Levy
--- server/Makefile.am | 3 +++ server/tests/test_spice_version.sh | 42 ++ 2 files changed, 45 insertions(+) create mode 100755 server/tests/test_spice_version.sh diff --git a/server/Makefile.am b/server/Makefile.am index 16c8b6d..18a9d8a

Re: [Spice-devel] [Qemu-devel] [PATCH-v2 spice 1/2] Set a8 capability in the QXL device if supported by the client

2012-09-03 Thread Alon Levy
--- server/red_worker.c | 2 ++ spice-common| 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/server/red_worker.c b/server/red_worker.c index 843f559..23f3464 100644 --- a/server/red_worker.c +++ b/server/red_worker.c @@ -10377,6 +10377,8 @@ static void

[Spice-devel] [PATCH] server/red_parse_qxl: add bitmap consistency check

2012-09-03 Thread Alon Levy
Just checks stride vs width times bpp. This fixes a potential abort on guest generated bad images in glz_encoder. Other files touched to move some consts to red_common, they are static so no problem to be defined in both red_worker.c and red_parse_qxl.c . --- server/red_common.h| 18

Re: [Spice-devel] [PATCH 3/5] Process outstanding commands in the ring after changing capability bits

2012-09-03 Thread Alon Levy
From: Søren Sandmann Pedersen s...@redhat.com When a new client connects, there may be commands in the ring that it can't understand, so we need to process these before forwarding new commands to the client. By doing this after changing the capability bits we ensure that the new client will

Re: [Qemu-devel] [PATCH-v2 spice 1/2] Set a8 capability in the QXL device if supported by the client

2012-09-03 Thread Alon Levy
--- server/red_worker.c | 2 ++ spice-common| 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/server/red_worker.c b/server/red_worker.c index 843f559..23f3464 100644 --- a/server/red_worker.c +++ b/server/red_worker.c @@ -10377,6 +10377,8 @@ static void

Re: [Qemu-devel] [PATCH] qxl: Add set_client_capabilities() interface to QXLInterface

2012-09-03 Thread Alon Levy
From: Søren Sandmann Pedersen s...@redhat.com This new interface lets spice server inform the guest whether (a) a client is connected (b) what capabilities the client has There is a fixed number (464) of bits reserved for capabilities, and when the capabilities bits change, the

Re: [Qemu-devel] [Spice-devel] [PATCH 3/5] Process outstanding commands in the ring after changing capability bits

2012-09-03 Thread Alon Levy
From: Søren Sandmann Pedersen s...@redhat.com When a new client connects, there may be commands in the ring that it can't understand, so we need to process these before forwarding new commands to the client. By doing this after changing the capability bits we ensure that the new client will

[Spice-devel] spice-server 0.11.3 development release

2012-09-02 Thread Alon Levy
Hi All, I'm happy to announce spice-0.11.3, a development release: Major changes in 0.11.3: * !Development Release! * This entry contains all 0.11.0 .. 0.11.3 changes. * Support seamless migration: no loss of in transit messages. Still not supported for agent,

[Qemu-devel] [PATCH] dtrace backend: add function to reserved words

2012-09-01 Thread Alon Levy
Signed-off-by: Alon Levy al...@redhat.com --- scripts/tracetool/backend/dtrace.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/tracetool/backend/dtrace.py b/scripts/tracetool/backend/dtrace.py index 9cab75c..6be7047 100644 --- a/scripts/tracetool/backend/dtrace.py

Re: [Spice-devel] [ Spice-devel / QXL Xspice crash ]

2012-08-31 Thread Alon Levy
hello, client version : spice-gtk master git / spicy qxl Xspice : master git I can connect to Xspice server, but some action crash the server and client Exemple : play a video on firefox Xspice log : qxl_surface_create: Bad bpp: 1 (1) qxl_surface_create: Bad bpp: 1 (1)

Re: [Spice-devel] New xrandr multi-mon / arbitrary resolution support issues

2012-08-31 Thread Alon Levy
Hi, On 08/27/2012 12:09 PM, Alon Levy wrote: On Mon, Aug 27, 2012 at 11:20:09AM +0200, Hans de Goede wrote: Hi, So I've been playing around with this more, and except for the issues when going fullscreen with multiple monitors (the one where the 2 windows end up on the same

[Spice-devel] [PATCH] server/red_worker: seamless: fix invalid memory reference

2012-08-30 Thread Alon Levy
replace add_ref with add for stack allocated SpiceMigrateDataDisplay. This fixes wrong MIGRATE_DATA message in display channel (symptom is glz_encoder_max being way too big, and malloc failure at target) seen on F18 with gcc-4.7.1-5.fc18.x86_64 and glibc-2.16-8.fc18.x86_64 (didn't appear on RHEL

Re: question on compiling xf86-video-qxl-0.0.17

2012-08-29 Thread Alon Levy
On Fri, Aug 24, 2012 at 05:34:13PM -0400, Ciccarelli, Michael (Michael) wrote: On rhel 5.7 and I'm trying to compile xf86-video-qxl-0.0.17 from source.. the configure script works and output seems fine, but when I run a make I get the following list of errors:

Re: [Spice-devel] [PATCH] Add new client_present and client capabilities fields to QXLRom

2012-08-29 Thread Alon Levy
On Wed, Aug 29, 2012 at 02:58:14AM +0200, Søren Sandmann wrote: Gerd Hoffmann kra...@redhat.com writes: On 08/27/12 19:20, Søren Sandmann Pedersen wrote: From: Søren Sandmann Pedersen s...@redhat.com The client_present field is a byte that is set of non-zero when a client is

[Spice-devel] [PATCH spice-gtk] support automate = 1.12 with new required AM_PROG_AR

2012-08-29 Thread Alon Levy
--- configure.ac | 2 ++ 1 file changed, 2 insertions(+) diff --git a/configure.ac b/configure.ac index 38ceeab..70897cb 100644 --- a/configure.ac +++ b/configure.ac @@ -11,6 +11,8 @@ AM_INIT_AUTOMAKE([foreign dist-bzip2 -Wall -Werror]) LT_INIT AM_MAINTAINER_MODE +m4_ifdef([AM_PROG_AR],

[Spice-devel] [PATCH spice-common] lz_compress_tmpl: silence incompatible pointer assignment warning

2012-08-29 Thread Alon Levy
cur_seg-lines is always uint8_t*, PIXEL may be that or uint16_t* or uint32_t*. --- common/lz_compress_tmpl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/common/lz_compress_tmpl.c b/common/lz_compress_tmpl.c index 7e2ce42..2b66833 100644 --- a/common/lz_compress_tmpl.c +++

Re: [Qemu-devel] [Spice-devel] [PATCH] Add new client_present and client capabilities fields to QXLRom

2012-08-29 Thread Alon Levy
On Wed, Aug 29, 2012 at 02:58:14AM +0200, Søren Sandmann wrote: Gerd Hoffmann kra...@redhat.com writes: On 08/27/12 19:20, Søren Sandmann Pedersen wrote: From: Søren Sandmann Pedersen s...@redhat.com The client_present field is a byte that is set of non-zero when a client is

Re: [Spice-devel] New xrandr multi-mon / arbitrary resolution support issues

2012-08-27 Thread Alon Levy
On Mon, Aug 27, 2012 at 11:20:09AM +0200, Hans de Goede wrote: Hi, So I've been playing around with this more, and except for the issues when going fullscreen with multiple monitors (the one where the 2 windows end up on the same monitor), things look good. There are some issues with

<    3   4   5   6   7   8   9   10   11   12   >