soukatch wrote:
Thanks for the review!
https://github.com/llvm/llvm-project/pull/91675
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/soukatch updated
https://github.com/llvm/llvm-project/pull/91675
>From 846be0552bd2da608fc1729e5928d85650e1ce06 Mon Sep 17 00:00:00 2001
From: Andrew Sukach
Date: Thu, 9 May 2024 18:49:41 -0400
Subject: [PATCH] [clang][static analyzer] ignore try statements in dead code
soukatch wrote:
> To find which file you need to add your test,
I created a new file altogether since I don't think any of the current one
would fit the test.
https://github.com/llvm/llvm-project/pull/91675
___
cfe-commits mailing list
https://github.com/soukatch updated
https://github.com/llvm/llvm-project/pull/91675
>From 4ed555c81ae5b773361da22c0736f82fbf14c90d Mon Sep 17 00:00:00 2001
From: Andrew Sukach
Date: Thu, 9 May 2024 18:49:41 -0400
Subject: [PATCH] [clang][static analyzer] ignore try statements in dead code
https://github.com/soukatch deleted
https://github.com/llvm/llvm-project/pull/91675
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -159,8 +159,10 @@ void
UnreachableCodeChecker::checkEndAnalysis(ExplodedGraph ,
SL = DL.asLocation();
if (SR.isInvalid() || !SL.isValid())
continue;
-}
-else
+
+ if (isa(S))
soukatch wrote:
everything besides this if
https://github.com/soukatch deleted
https://github.com/llvm/llvm-project/pull/91675
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
soukatch wrote:
@steakhal I believe you're the best person to tag :).
https://github.com/llvm/llvm-project/pull/91675
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -159,8 +159,10 @@ void
UnreachableCodeChecker::checkEndAnalysis(ExplodedGraph ,
SL = DL.asLocation();
if (SR.isInvalid() || !SL.isValid())
continue;
-}
-else
+
+ if (isa(S))
soukatch wrote:
everything above this point is
https://github.com/soukatch created
https://github.com/llvm/llvm-project/pull/91675
Fixes #90162. Simplest approach I could come up with was to skip cxxtry
statements. Let me know if you have any suggestions. Thanks!
>From e1fcdc37e52189abcdf8ce84ada463491d8b6c04 Mon Sep 17 00:00:00 2001
soukatch wrote:
Thank you everyone for the reviews!
https://github.com/llvm/llvm-project/pull/90012
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/soukatch closed
https://github.com/llvm/llvm-project/pull/91081
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
soukatch wrote:
@AaronBallman would it be possible to get an approval while all the checks are
green? Thanks!
https://github.com/llvm/llvm-project/pull/90012
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://github.com/soukatch updated
https://github.com/llvm/llvm-project/pull/90012
>From 9007597af4f138d2744405bb7980fce4555d7508 Mon Sep 17 00:00:00 2001
From: Andrew Sukach
Date: Wed, 24 Apr 2024 22:50:50 -0400
Subject: [PATCH 1/3] [clang] MangledSymbol: remove pointless copy of vector
---
https://github.com/soukatch updated
https://github.com/llvm/llvm-project/pull/90012
>From 9007597af4f138d2744405bb7980fce4555d7508 Mon Sep 17 00:00:00 2001
From: Andrew Sukach
Date: Wed, 24 Apr 2024 22:50:50 -0400
Subject: [PATCH 1/3] [clang] MangledSymbol: remove pointless copy of vector
---
https://github.com/soukatch updated
https://github.com/llvm/llvm-project/pull/90012
>From 9007597af4f138d2744405bb7980fce4555d7508 Mon Sep 17 00:00:00 2001
From: Andrew Sukach
Date: Wed, 24 Apr 2024 22:50:50 -0400
Subject: [PATCH 1/2] [clang] MangledSymbol: remove pointless copy of vector
---
https://github.com/soukatch updated
https://github.com/llvm/llvm-project/pull/90012
>From 9007597af4f138d2744405bb7980fce4555d7508 Mon Sep 17 00:00:00 2001
From: Andrew Sukach
Date: Wed, 24 Apr 2024 22:50:50 -0400
Subject: [PATCH] [clang] MangledSymbol: remove pointless copy of vector
---
https://github.com/soukatch updated
https://github.com/llvm/llvm-project/pull/90012
>From b8e20a5a3e37ab9a657ac640b848f638387215fa Mon Sep 17 00:00:00 2001
From: Andrew Sukach
Date: Wed, 24 Apr 2024 22:50:50 -0400
Subject: [PATCH 1/2] [clang] MangledSymbol: remove pointless copy of vector
---
soukatch wrote:
Looking at the logs, and the error seems to be unrelated to the changes made
https://buildkite.com/llvm-project/clang-ci/builds/16430#018f132d-506e-440c-b18b-fed98237def9/54-5446
https://github.com/llvm/llvm-project/pull/90012
___
soukatch wrote:
@dcb314 @shafik @EugeneZelenko Please let me know if this change looks good.
Thanks!
https://github.com/llvm/llvm-project/pull/90012
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://github.com/soukatch created
https://github.com/llvm/llvm-project/pull/90012
This pr addresses #87255 adds a std::move call to the names in MangledSymbol's
constructor.
>From b8e20a5a3e37ab9a657ac640b848f638387215fa Mon Sep 17 00:00:00 2001
From: Andrew Sukach
Date: Wed, 24 Apr 2024
21 matches
Mail list logo
