[PATCH 4/5] test: Known-broken test for overlapping/adjacent termpos

2014-06-15 Thread Austin Clements
This adds two known-broken tests and one working test related to the term positions assigned to terms from different headers or MIME parts. The first test fails because we don't create a termpos gap between different headers. The second test fails because we don't adjust termpos at all when

[PATCH] test: Known-broken test for overlapping/adjacent termpos

2014-05-17 Thread Austin Clements
Quoth myself on May 17 at 4:45 pm: > This adds two known-broken tests and one working test related to the > term positions assigned to terms from different headers or MIME parts. > The first test fails because we don't create a termpos gap between > different headers. The second test fails

[PATCH] test: Known-broken test for overlapping/adjacent termpos

2014-05-17 Thread Austin Clements
This adds two known-broken tests and one working test related to the term positions assigned to terms from different headers or MIME parts. The first test fails because we don't create a termpos gap between different headers. The second test fails because we don't adjust termpos at all when

[PATCH] test: Known-broken test for overlapping/adjacent termpos

2014-05-17 Thread Austin Clements
This adds two known-broken tests and one working test related to the term positions assigned to terms from different headers or MIME parts. The first test fails because we don't create a termpos gap between different headers. The second test fails because we don't adjust termpos at all when

Re: [PATCH] test: Known-broken test for overlapping/adjacent termpos

2014-05-17 Thread Austin Clements
Quoth myself on May 17 at 4:45 pm: This adds two known-broken tests and one working test related to the term positions assigned to terms from different headers or MIME parts. The first test fails because we don't create a termpos gap between different headers. The second test fails because

[PATCH] doc: Fix parallel build of roff files

2014-05-10 Thread Austin Clements
On Sat, 10 May 2014, "W. Trevor King" wrote: > On Thu, Apr 17, 2014 at 04:34:57PM -0400, Austin Clements wrote: >> +$(DOCBUILDDIR)/.roff.stamp: ${MAN_RST_FILES} >> ifeq ($(HAVE_SPHINX),1) >> $(SPHINXBUILD) -b man $(ALLSPHINXOPTS) $(DOCBUILDDIR)/man &

Re: [PATCH] doc: Fix parallel build of roff files

2014-05-10 Thread Austin Clements
On Sat, 10 May 2014, W. Trevor King wk...@tremily.us wrote: On Thu, Apr 17, 2014 at 04:34:57PM -0400, Austin Clements wrote: +$(DOCBUILDDIR)/.roff.stamp: ${MAN_RST_FILES} ifeq ($(HAVE_SPHINX),1) $(SPHINXBUILD) -b man $(ALLSPHINXOPTS) $(DOCBUILDDIR)/man for section in 1 5 7; do

Re: Linux-only fdatasync() in 3c13bc

2014-05-07 Thread Austin Clements
Quoth David Bremner on May 07 at 10:17 pm: Tomi Ollila tomi.oll...@iki.fi writes: On Wed, May 07 2014, Kushal Kumaran kushal.kumaran+notm...@gmail.com wrote: Xīcò x...@atelo.org writes: Also, commit 3c13bc introduced a call to fdatasync() which is not available on FreeBSD, and

Add support for specifying tags during "notmuch new"

2014-05-02 Thread Austin Clements
Quoth David Edmondson on May 02 at 9:15 am: > This patch set allows a user to specify a list of tags to be > added/removed to messages discovered during "notmuch new". > > Two use-cases are envisaged: > 1) A chunk of messages was just dumped into the configured >directory by hand,

Re: Add support for specifying tags during notmuch new

2014-05-02 Thread Austin Clements
Quoth David Edmondson on May 02 at 9:15 am: This patch set allows a user to specify a list of tags to be added/removed to messages discovered during notmuch new. Two use-cases are envisaged: 1) A chunk of messages was just dumped into the configured directory by hand, and the

github mirror

2014-04-27 Thread Austin Clements
Quoth Sam Halliday on Apr 27 at 12:09 pm: > But in any case, my RFE/question was this: how hard would it be to have > an optional mode of behaviour where tags are stored in the message > itself, so that syncing with an IMAP server (e.g. via offlineimap) > would make the tags available on all

Re: github mirror

2014-04-27 Thread Austin Clements
Quoth Sam Halliday on Apr 27 at 12:09 pm: But in any case, my RFE/question was this: how hard would it be to have an optional mode of behaviour where tags are stored in the message itself, so that syncing with an IMAP server (e.g. via offlineimap) would make the tags available on all devices.

[PATCH 02/11] test: New tests for Emacs charset handling

2014-04-24 Thread Austin Clements
Quoth Mark Walters on Apr 24 at 3:38 pm: > > On Mon, 21 Apr 2014, Austin Clements wrote: > > The test of viewing 8bit messages is known-broken. The rest pass, but > > for very fragile reasons. The next several commits will fix the > > known-broken test and make our

[PATCH 08/11] emacs: Support caching in notmuch-get-bodypart-{binary, text}

2014-04-24 Thread Austin Clements
Quoth Mark Walters on Apr 24 at 11:46 am: > > On Mon, 21 Apr 2014, Austin Clements wrote: > > (The actual code change here is small, but requires re-indenting > > existing code.) > > --- > > emacs/notmuch-lib.el | 52 > > ++--

Re: [PATCH 08/11] emacs: Support caching in notmuch-get-bodypart-{binary, text}

2014-04-24 Thread Austin Clements
Quoth Mark Walters on Apr 24 at 11:46 am: On Mon, 21 Apr 2014, Austin Clements amdra...@mit.edu wrote: (The actual code change here is small, but requires re-indenting existing code.) --- emacs/notmuch-lib.el | 52 ++-- 1 file

[PATCH] Add configurable changed tag to messages that have been changed on disk

2014-04-23 Thread Austin Clements
Quoth David Mazieres on Apr 06 at 10:19 pm: > Gaute Hope writes: > > > When one of the source files for a message is changed on disk, renamed, > > deleted or a new source file is added. A configurable changed tag is > > is added. The tag can be configured under the option 'changed_tags' in > >

[PATCH] Add configurable changed tag to messages that have been changed on disk

2014-04-23 Thread Austin Clements
Hi Dave! Quoth David Mazieres on Apr 23 at 2:00 am: > Gaute Hope writes: > > > A db-tick or a _good_ ctime solution can as far as I can see solve both > > David M's (correct me if I am wrong) and my purposes, as well as > > probably have more use cases in the future. It would even be an > >

Re: [PATCH] Add configurable changed tag to messages that have been changed on disk

2014-04-23 Thread Austin Clements
Hi Dave! Quoth David Mazieres on Apr 23 at 2:00 am: Gaute Hope e...@gaute.vetsj.com writes: A db-tick or a _good_ ctime solution can as far as I can see solve both David M's (correct me if I am wrong) and my purposes, as well as probably have more use cases in the future. It would even

Re: [PATCH] Add configurable changed tag to messages that have been changed on disk

2014-04-23 Thread Austin Clements
Quoth David Mazieres on Apr 06 at 10:19 pm: Gaute Hope e...@gaute.vetsj.com writes: When one of the source files for a message is changed on disk, renamed, deleted or a new source file is added. A configurable changed tag is is added. The tag can be configured under the option

[PATCH v2] test: Test thread linking in all possible delivery orders

2014-04-22 Thread Austin Clements
and 4 possible > roots) and the python generates 144 lines. Piping the output to sort and > uniq gives 64 lines. > > > > On Mon, 21 Apr 2014, Austin Clements wrote: > > These tests deliver all possible (single-root) four-message threads in > > all possible o

Re: [PATCH v2] test: Test thread linking in all possible delivery orders

2014-04-22 Thread Austin Clements
. Piping the output to sort and uniq gives 64 lines. On Mon, 21 Apr 2014, Austin Clements amdra...@mit.edu wrote: These tests deliver all possible (single-root) four-message threads in all possible orders and check that notmuch successfully links them into threads. There are two

[PATCH v2] test: Test thread linking in all possible delivery orders

2014-04-21 Thread Austin Clements
These tests deliver all possible (single-root) four-message threads in all possible orders and check that notmuch successfully links them into threads. There are two variants of the test: one delivers messages that reference only their immediate parent and the other delivers messages that

[PATCH 11/11] emacs: Support cid: references with shr renderer

2014-04-21 Thread Austin Clements
shr has really nice support for inline image rendering, but previously we only had the hooks for w3m cid: references. --- emacs/notmuch-show.el | 41 + 1 file changed, 33 insertions(+), 8 deletions(-) diff --git a/emacs/notmuch-show.el

[PATCH 10/11] emacs: Rewrite content ID handling

2014-04-21 Thread Austin Clements
Besides generally cleaning up the code and separating the general content ID handling from the w3m-specific code, this fixes several problems. Foremost is that, previously, the code roughly assumed that referenced parts would be in the same multipart/related as the reference. According to RFC

[PATCH 09/11] emacs: Use generalized content caching in w3m CID code

2014-04-21 Thread Austin Clements
Previously this did its own caching, but this is now supported by more generally by `notmuch-get-bodypart-binary'. --- emacs/notmuch-show.el | 23 --- 1 file changed, 8 insertions(+), 15 deletions(-) diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el index

[PATCH 08/11] emacs: Support caching in notmuch-get-bodypart-{binary, text}

2014-04-21 Thread Austin Clements
(The actual code change here is small, but requires re-indenting existing code.) --- emacs/notmuch-lib.el | 52 ++-- 1 file changed, 30 insertions(+), 22 deletions(-) diff --git a/emacs/notmuch-lib.el b/emacs/notmuch-lib.el index fc67b14..fee8512

[PATCH 07/11] emacs: Return unibyte strings for binary part data

2014-04-21 Thread Austin Clements
Unibyte strings are meant for representing binary data. In practice, using unibyte versus multibyte strings affects *almost* nothing. It does happen to matter if we use the binary data in an image descriptor (which is, helpfully, not documented anywhere and getting it wrong results in opaque

[PATCH 06/11] emacs: Remove broken `notmuch-get-bodypart-content' API

2014-04-21 Thread Austin Clements
`notmuch-get-bodypart-content' could do two very different things, depending on conditions: for text/* parts other than text/html, it would return the part content as a multibyte Lisp string *after* charset conversion, while for other parts (including text/html), it would return binary part

[PATCH 05/11] emacs: Create an API for fetching parts as undecoded binary

2014-04-21 Thread Austin Clements
The new function, `notmuch-get-bodypart-binary', replaces `notmuch-get-bodypart-internal'. Whereas the old function was really meant for internal use in `notmuch-get-bodypart-content', it was used in a few other places. Since the difference between `notmuch-get-bodypart-content' and

[PATCH 04/11] emacs: Track full message and part descriptor in w3m CID store

2014-04-21 Thread Austin Clements
This will simplify later changes. --- emacs/notmuch-show.el | 33 ++--- 1 file changed, 10 insertions(+), 23 deletions(-) diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el index 2b225df..455cfee 100644 --- a/emacs/notmuch-show.el +++ b/emacs/notmuch-show.el

[PATCH 03/11] emacs: Fix coding system in `notmuch-show-view-raw-message'

2014-04-21 Thread Austin Clements
This fixes the known-broken test of viewing 8bit messages added by the previous commit. --- emacs/notmuch-show.el | 5 +++-- test/T455-emacs-charsets.sh | 1 - 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el index 949ac09..2b225df

[PATCH 02/11] test: New tests for Emacs charset handling

2014-04-21 Thread Austin Clements
The test of viewing 8bit messages is known-broken. The rest pass, but for very fragile reasons. The next several commits will fix the known-broken test and make our charset handling robust. --- test/T455-emacs-charsets.sh | 141 test/test-lib.el

[PATCH 01/11] emacs: Remove redundant NTH argument from `notmuch-get-bodypart-content'.

2014-04-21 Thread Austin Clements
This can be derived from the PART argument (which is arguably canonical), so there's no sense in giving the caller an extra foot gun. --- emacs/notmuch-lib.el | 9 + emacs/notmuch-show.el | 6 +++--- 2 files changed, 8 insertions(+), 7 deletions(-) diff --git a/emacs/notmuch-lib.el

[PATCH 00/11] Improve charset and cid: handling

2014-04-21 Thread Austin Clements
I set out to quickly add support for cid: links in the shr renderer and wound up making our charset handling more robust and rewriting our content-ID handling. The test introduced in patch 2 passes in all but one really obscure case, but only because of many unwritten and potentially fragile

[RFC PATCH] Re: excessive thread fusing

2014-04-21 Thread Austin Clements
Quoth Mark Walters on Apr 21 at 8:20 am: > > >> I haven't tracked through all the logic of the existing algorithm for > >> this case. But I don't like hearing that notmuch constructs different > >> threads for the same messages presented in different orders. This sounds > >> like a bug separate

Re: [RFC PATCH] Re: excessive thread fusing

2014-04-21 Thread Austin Clements
Quoth Mark Walters on Apr 21 at 8:20 am: I haven't tracked through all the logic of the existing algorithm for this case. But I don't like hearing that notmuch constructs different threads for the same messages presented in different orders. This sounds like a bug separate from what

[PATCH 03/11] emacs: Fix coding system in `notmuch-show-view-raw-message'

2014-04-21 Thread Austin Clements
This fixes the known-broken test of viewing 8bit messages added by the previous commit. --- emacs/notmuch-show.el | 5 +++-- test/T455-emacs-charsets.sh | 1 - 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el index 949ac09..2b225df

[PATCH 01/11] emacs: Remove redundant NTH argument from `notmuch-get-bodypart-content'.

2014-04-21 Thread Austin Clements
This can be derived from the PART argument (which is arguably canonical), so there's no sense in giving the caller an extra foot gun. --- emacs/notmuch-lib.el | 9 + emacs/notmuch-show.el | 6 +++--- 2 files changed, 8 insertions(+), 7 deletions(-) diff --git a/emacs/notmuch-lib.el

[PATCH 00/11] Improve charset and cid: handling

2014-04-21 Thread Austin Clements
I set out to quickly add support for cid: links in the shr renderer and wound up making our charset handling more robust and rewriting our content-ID handling. The test introduced in patch 2 passes in all but one really obscure case, but only because of many unwritten and potentially fragile

[PATCH 09/11] emacs: Use generalized content caching in w3m CID code

2014-04-21 Thread Austin Clements
Previously this did its own caching, but this is now supported by more generally by `notmuch-get-bodypart-binary'. --- emacs/notmuch-show.el | 23 --- 1 file changed, 8 insertions(+), 15 deletions(-) diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el index

[PATCH 08/11] emacs: Support caching in notmuch-get-bodypart-{binary, text}

2014-04-21 Thread Austin Clements
(The actual code change here is small, but requires re-indenting existing code.) --- emacs/notmuch-lib.el | 52 ++-- 1 file changed, 30 insertions(+), 22 deletions(-) diff --git a/emacs/notmuch-lib.el b/emacs/notmuch-lib.el index fc67b14..fee8512

[PATCH 06/11] emacs: Remove broken `notmuch-get-bodypart-content' API

2014-04-21 Thread Austin Clements
`notmuch-get-bodypart-content' could do two very different things, depending on conditions: for text/* parts other than text/html, it would return the part content as a multibyte Lisp string *after* charset conversion, while for other parts (including text/html), it would return binary part

[PATCH 11/11] emacs: Support cid: references with shr renderer

2014-04-21 Thread Austin Clements
shr has really nice support for inline image rendering, but previously we only had the hooks for w3m cid: references. --- emacs/notmuch-show.el | 41 + 1 file changed, 33 insertions(+), 8 deletions(-) diff --git a/emacs/notmuch-show.el

[PATCH 04/11] emacs: Track full message and part descriptor in w3m CID store

2014-04-21 Thread Austin Clements
This will simplify later changes. --- emacs/notmuch-show.el | 33 ++--- 1 file changed, 10 insertions(+), 23 deletions(-) diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el index 2b225df..455cfee 100644 --- a/emacs/notmuch-show.el +++ b/emacs/notmuch-show.el

[PATCH 07/11] emacs: Return unibyte strings for binary part data

2014-04-21 Thread Austin Clements
Unibyte strings are meant for representing binary data. In practice, using unibyte versus multibyte strings affects *almost* nothing. It does happen to matter if we use the binary data in an image descriptor (which is, helpfully, not documented anywhere and getting it wrong results in opaque

[PATCH 05/11] emacs: Create an API for fetching parts as undecoded binary

2014-04-21 Thread Austin Clements
The new function, `notmuch-get-bodypart-binary', replaces `notmuch-get-bodypart-internal'. Whereas the old function was really meant for internal use in `notmuch-get-bodypart-content', it was used in a few other places. Since the difference between `notmuch-get-bodypart-content' and

[PATCH v2] test: Test thread linking in all possible delivery orders

2014-04-21 Thread Austin Clements
These tests deliver all possible (single-root) four-message threads in all possible orders and check that notmuch successfully links them into threads. There are two variants of the test: one delivers messages that reference only their immediate parent and the other delivers messages that

excessive thread fusing

2014-04-20 Thread Austin Clements
Quoth myself on Apr 20 at 12:48 pm: > Quoth Andrei POPESCU on Apr 20 at 12:04 am: > > On Sb, 19 apr 14, 18:52:02, Eric wrote: > > > > > > This may not actually be any help, but both hypermail and mhonarc agree > > > that two messages form a separate thread from the rest. I believe that > > > the

excessive thread fusing

2014-04-20 Thread Austin Clements
Quoth Andrei POPESCU on Apr 20 at 12:04 am: > On Sb, 19 apr 14, 18:52:02, Eric wrote: > > > > This may not actually be any help, but both hypermail and mhonarc agree > > that two messages form a separate thread from the rest. I believe that > > the latter, at least, is the JWZ algorithm. > >

Re: excessive thread fusing

2014-04-20 Thread Austin Clements
Quoth Andrei POPESCU on Apr 20 at 12:04 am: On Sb, 19 apr 14, 18:52:02, Eric wrote: This may not actually be any help, but both hypermail and mhonarc agree that two messages form a separate thread from the rest. I believe that the latter, at least, is the JWZ algorithm. mutt concurs.

Re: excessive thread fusing

2014-04-20 Thread Austin Clements
Quoth myself on Apr 20 at 12:48 pm: Quoth Andrei POPESCU on Apr 20 at 12:04 am: On Sb, 19 apr 14, 18:52:02, Eric wrote: This may not actually be any help, but both hypermail and mhonarc agree that two messages form a separate thread from the rest. I believe that the latter, at

[PATCH] News for changes from Austin Clements

2014-04-19 Thread Austin Clements
--- NEWS | 12 1 file changed, 12 insertions(+) diff --git a/NEWS b/NEWS index 4ceff94..19c6556 100644 --- a/NEWS +++ b/NEWS @@ -46,6 +46,12 @@ Changed format for saved searches saved-search :name) and (cdr saved-search) by (notmuch-saved-search-get saved-search :query) should

[PATCH] emacs: Honor debug-on-error for part renderers

2014-04-18 Thread Austin Clements
Previously, even if debug-on-error was non-nil, the debugger would not trap on part renderer errors. This made debugging part renderer bugs frustrating, so let the debugger trap these errors. --- emacs/notmuch-show.el | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git

[PATCH v2 4/4] doc: Simplify and clarify notmuch show --format=sexp description

2014-04-18 Thread Austin Clements
Previously, this was a verbatim copy of the --format=json text. Change it to instead reference the JSON text and actually describe how the S-expression format works. --- doc/man1/notmuch-show.rst | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git

[PATCH v2 3/4] doc: Clarify charset encoding of JSON output

2014-04-18 Thread Austin Clements
--- doc/man1/notmuch-show.rst | 3 +++ 1 file changed, 3 insertions(+) diff --git a/doc/man1/notmuch-show.rst b/doc/man1/notmuch-show.rst index 14d598a..78196ee 100644 --- a/doc/man1/notmuch-show.rst +++ b/doc/man1/notmuch-show.rst @@ -52,6 +52,9 @@ Supported options for **show** include

[PATCH v2 2/4] doc: Fix minor formatting issues in notmuch-show.rst

2014-04-18 Thread Austin Clements
There were some extra line breaks and missing periods. --- doc/man1/notmuch-show.rst | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/doc/man1/notmuch-show.rst b/doc/man1/notmuch-show.rst index c4518ec..14d598a 100644 --- a/doc/man1/notmuch-show.rst +++

[PATCH v2 1/4] doc: Clarify notmuch show --format=raw description

2014-04-18 Thread Austin Clements
In addition to being generally more precise, this is explicit that there is no charset conversion. --- doc/man1/notmuch-show.rst | 36 1 file changed, 20 insertions(+), 16 deletions(-) diff --git a/doc/man1/notmuch-show.rst b/doc/man1/notmuch-show.rst index

[PATCH v2 0/4] doc: notmuch-show improvements

2014-04-18 Thread Austin Clements
This is v2 of id:1397834332-25175-1-git-send-email-amdragon at mit.edu. It expands the explanation of "non-MIME" message parts and moves it to the --part documentation.

[PATCH 1/4] doc: Clarify notmuch show --format=raw description

2014-04-18 Thread Austin Clements
Quoth Mark Walters on Apr 18 at 8:23 pm: > > On Fri, 18 Apr 2014, Austin Clements wrote: > > In addition to being generally more precise, this is explicit that > > there is no charset conversion. > > --- > > doc/man1/notmuch-show.rst | 36 ++

[PATCH 4/4] doc: Simplify and clarify notmuch show --format=sexp description

2014-04-18 Thread Austin Clements
Previously, this was a verbatim copy of the --format=json text. Change it to instead reference the JSON text and actually describe how the S-expression format works. --- doc/man1/notmuch-show.rst | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git

[PATCH 3/4] doc: Clarify charset encoding of JSON output

2014-04-18 Thread Austin Clements
--- doc/man1/notmuch-show.rst | 3 +++ 1 file changed, 3 insertions(+) diff --git a/doc/man1/notmuch-show.rst b/doc/man1/notmuch-show.rst index fdfb36d..b8b10b9 100644 --- a/doc/man1/notmuch-show.rst +++ b/doc/man1/notmuch-show.rst @@ -52,6 +52,9 @@ Supported options for **show** include

[PATCH 2/4] doc: Fix minor formatting issues in notmuch-show.rst

2014-04-18 Thread Austin Clements
There were some extra line breaks and missing periods. --- doc/man1/notmuch-show.rst | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/doc/man1/notmuch-show.rst b/doc/man1/notmuch-show.rst index 2c0f64c..fdfb36d 100644 --- a/doc/man1/notmuch-show.rst +++

[PATCH 1/4] doc: Clarify notmuch show --format=raw description

2014-04-18 Thread Austin Clements
In addition to being generally more precise, this is explicit that there is no charset conversion. --- doc/man1/notmuch-show.rst | 36 1 file changed, 20 insertions(+), 16 deletions(-) diff --git a/doc/man1/notmuch-show.rst b/doc/man1/notmuch-show.rst index

[PATCH 0/4] doc: notmuch-show improvements

2014-04-18 Thread Austin Clements
While I was poking at getting content-IDs to work better in the Emacs UI, I found several things to be lacking in our notmuch-show documentation.

[PATCH 2/4] doc: Fix minor formatting issues in notmuch-show.rst

2014-04-18 Thread Austin Clements
There were some extra line breaks and missing periods. --- doc/man1/notmuch-show.rst | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/doc/man1/notmuch-show.rst b/doc/man1/notmuch-show.rst index 2c0f64c..fdfb36d 100644 --- a/doc/man1/notmuch-show.rst +++

[PATCH 0/4] doc: notmuch-show improvements

2014-04-18 Thread Austin Clements
While I was poking at getting content-IDs to work better in the Emacs UI, I found several things to be lacking in our notmuch-show documentation. ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

[PATCH 3/4] doc: Clarify charset encoding of JSON output

2014-04-18 Thread Austin Clements
--- doc/man1/notmuch-show.rst | 3 +++ 1 file changed, 3 insertions(+) diff --git a/doc/man1/notmuch-show.rst b/doc/man1/notmuch-show.rst index fdfb36d..b8b10b9 100644 --- a/doc/man1/notmuch-show.rst +++ b/doc/man1/notmuch-show.rst @@ -52,6 +52,9 @@ Supported options for **show** include

[PATCH 4/4] doc: Simplify and clarify notmuch show --format=sexp description

2014-04-18 Thread Austin Clements
Previously, this was a verbatim copy of the --format=json text. Change it to instead reference the JSON text and actually describe how the S-expression format works. --- doc/man1/notmuch-show.rst | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git

[PATCH 1/4] doc: Clarify notmuch show --format=raw description

2014-04-18 Thread Austin Clements
In addition to being generally more precise, this is explicit that there is no charset conversion. --- doc/man1/notmuch-show.rst | 36 1 file changed, 20 insertions(+), 16 deletions(-) diff --git a/doc/man1/notmuch-show.rst b/doc/man1/notmuch-show.rst index

Re: [PATCH 1/4] doc: Clarify notmuch show --format=raw description

2014-04-18 Thread Austin Clements
Quoth Mark Walters on Apr 18 at 8:23 pm: On Fri, 18 Apr 2014, Austin Clements amdra...@mit.edu wrote: In addition to being generally more precise, this is explicit that there is no charset conversion. --- doc/man1/notmuch-show.rst | 36 1 file

[PATCH v2 0/4] doc: notmuch-show improvements

2014-04-18 Thread Austin Clements
This is v2 of id:1397834332-25175-1-git-send-email-amdra...@mit.edu. It expands the explanation of non-MIME message parts and moves it to the --part documentation. ___ notmuch mailing list notmuch@notmuchmail.org

[PATCH v2 2/4] doc: Fix minor formatting issues in notmuch-show.rst

2014-04-18 Thread Austin Clements
There were some extra line breaks and missing periods. --- doc/man1/notmuch-show.rst | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/doc/man1/notmuch-show.rst b/doc/man1/notmuch-show.rst index c4518ec..14d598a 100644 --- a/doc/man1/notmuch-show.rst +++

[PATCH v2 3/4] doc: Clarify charset encoding of JSON output

2014-04-18 Thread Austin Clements
--- doc/man1/notmuch-show.rst | 3 +++ 1 file changed, 3 insertions(+) diff --git a/doc/man1/notmuch-show.rst b/doc/man1/notmuch-show.rst index 14d598a..78196ee 100644 --- a/doc/man1/notmuch-show.rst +++ b/doc/man1/notmuch-show.rst @@ -52,6 +52,9 @@ Supported options for **show** include

[PATCH v2 1/4] doc: Clarify notmuch show --format=raw description

2014-04-18 Thread Austin Clements
In addition to being generally more precise, this is explicit that there is no charset conversion. --- doc/man1/notmuch-show.rst | 36 1 file changed, 20 insertions(+), 16 deletions(-) diff --git a/doc/man1/notmuch-show.rst b/doc/man1/notmuch-show.rst index

[PATCH v2 4/4] doc: Simplify and clarify notmuch show --format=sexp description

2014-04-18 Thread Austin Clements
Previously, this was a verbatim copy of the --format=json text. Change it to instead reference the JSON text and actually describe how the S-expression format works. --- doc/man1/notmuch-show.rst | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git

[PATCH] News for changes from Austin Clements

2014-04-18 Thread Austin Clements
--- NEWS | 12 1 file changed, 12 insertions(+) diff --git a/NEWS b/NEWS index 4ceff94..19c6556 100644 --- a/NEWS +++ b/NEWS @@ -46,6 +46,12 @@ Changed format for saved searches saved-search :name) and (cdr saved-search) by (notmuch-saved-search-get saved-search :query) should

[PATCH] doc: Fix parallel build of roff files

2014-04-17 Thread Austin Clements
The roff build rule builds all of the roff files in a single command. Previously, this was expressed as a multi-target rule, but since this is equivalent to specifying a copy of the rule for each target, make -jN could start up to N parallel instances of this command. Fix this by bottlenecking

[PATCH] emacs: search: edit current query

2014-04-17 Thread Austin Clements
You can *almost* do this already with the search minibuffer history. As far as I can tell, the only thing missing is modifying a search that started as a saved search. We could fix that by simply adding saved searches to this history (and possibly filtering saved searches out for the hello

Re: [PATCH] emacs: search: edit current query

2014-04-17 Thread Austin Clements
You can *almost* do this already with the search minibuffer history. As far as I can tell, the only thing missing is modifying a search that started as a saved search. We could fix that by simply adding saved searches to this history (and possibly filtering saved searches out for the hello recent

[Patch v7 5/6] notmuch-new: backup tags before database upgrade

2014-04-10 Thread Austin Clements
On Sat, 05 Apr 2014, David Bremner wrote: > All we do here is calculate the backup filename, and call the existing > dump routine. > > Also take the opportity to add a message about being safe to opportunity > interrupt. > --- > notmuch-new.c| 29 - >

[Patch v7 4/6] restore: transparently support gzipped input

2014-04-10 Thread Austin Clements
On Sat, 05 Apr 2014, David Bremner wrote: > We rely completely on zlib to do the right thing in detecting gzipped > input. Since our dump format is chosen to be 7 bit ascii, this should > be fine. > --- > doc/man1/notmuch-restore.rst | 8 > notmuch-restore.c| 93 >

Re: [Patch v7 4/6] restore: transparently support gzipped input

2014-04-10 Thread Austin Clements
On Sat, 05 Apr 2014, David Bremner da...@tethera.net wrote: We rely completely on zlib to do the right thing in detecting gzipped input. Since our dump format is chosen to be 7 bit ascii, this should be fine. --- doc/man1/notmuch-restore.rst | 8 notmuch-restore.c| 93

Re: [Patch v7 5/6] notmuch-new: backup tags before database upgrade

2014-04-10 Thread Austin Clements
On Sat, 05 Apr 2014, David Bremner da...@tethera.net wrote: All we do here is calculate the backup filename, and call the existing dump routine. Also take the opportity to add a message about being safe to opportunity interrupt. --- notmuch-new.c| 29 -

Re: v7 gzip dump restore patches

2014-04-10 Thread Austin Clements
On Sat, 05 Apr 2014, David Bremner da...@tethera.net wrote: Supercedes id:1396554083-3892-2-git-send-email-da...@tethera.net - adds new analogues of strerror - util_error_string - gz_error_string LGTM other than the two nits I pointed out. I'd be happy to have the fixes for those

[PATCH v2 0/5] emacs: hello: convert saved-searches to plists

2014-04-06 Thread Austin Clements
LGTM. Quoth Mark Walters on Apr 06 at 6:44 am: > This is v2 of the series; v1 is at > id:1396733065-32602-1-git-send-email-markwalters1009 at gmail.com > > I have made all the changes suggested by Austin in his review of v1. I > include the diff from v1 below. > > There is now one slight

Re: [PATCH v2 0/5] emacs: hello: convert saved-searches to plists

2014-04-06 Thread Austin Clements
LGTM. Quoth Mark Walters on Apr 06 at 6:44 am: This is v2 of the series; v1 is at id:1396733065-32602-1-git-send-email-markwalters1...@gmail.com I have made all the changes suggested by Austin in his review of v1. I include the diff from v1 below. There is now one slight oddity in the

[PATCH 2/5] emacs: hello: use the saved-search helper functions

2014-04-05 Thread Austin Clements
Quoth Mark Walters on Apr 05 at 10:24 pm: > This uses the helper functions: the saved searches format has not > changed yet but backwards compatibility means everything still works. > --- > emacs/notmuch-hello.el | 48 > ++-- > emacs/notmuch.el

[PATCH 1/5] emacs: hello: add helper functions for saved-searches

2014-04-05 Thread Austin Clements
Quoth Mark Walters on Apr 05 at 10:24 pm: > Add helper functions to for saved searches to ease the transition to > the new plist form while maintaining backwards compatibility. They > will be used in the next patch. > --- > emacs/notmuch-hello.el | 39 +++ >

Re: [PATCH 1/5] emacs: hello: add helper functions for saved-searches

2014-04-05 Thread Austin Clements
Quoth Mark Walters on Apr 05 at 10:24 pm: Add helper functions to for saved searches to ease the transition to the new plist form while maintaining backwards compatibility. They will be used in the next patch. --- emacs/notmuch-hello.el | 39 +++ 1 file

Re: [PATCH 2/5] emacs: hello: use the saved-search helper functions

2014-04-05 Thread Austin Clements
Quoth Mark Walters on Apr 05 at 10:24 pm: This uses the helper functions: the saved searches format has not changed yet but backwards compatibility means everything still works. --- emacs/notmuch-hello.el | 48 ++-- emacs/notmuch.el |

Re: [PATCH 4/5] emacs: hello: switch notmuch-hello-insert-buttons to plists

2014-04-05 Thread Austin Clements
Quoth Mark Walters on Apr 05 at 10:24 pm: Switching notmuch-hello-insert-buttons to plists means we can easily pass extra options through to the buttons. --- emacs/notmuch-hello.el | 33 +++-- 1 file changed, 19 insertions(+), 14 deletions(-) diff --git

Re: [PATCH 5/5] emacs: Add a sort-order option to saved-searches

2014-04-05 Thread Austin Clements
Quoth Mark Walters on Apr 05 at 10:24 pm: This adds a sort-order option to saved-searches, stores it in the saved-search buttons (widgets), and uses the stored value when the button is pressed. Storing the sort-order in the widget was suggested by Jani in

[Patch v6 4/6] restore: transparently support gzipped input

2014-04-04 Thread Austin Clements
Quoth David Bremner on Apr 03 at 4:41 pm: > We rely completely on zlib to do the right thing in detecting gzipped > input. Since our dump format is chosen to be 7 bit ascii, this should > be fine. > --- > doc/man1/notmuch-restore.rst | 8 > notmuch-restore.c| 41

[Patch v6 1/6] dump: support gzipped and atomic output

2014-04-04 Thread Austin Clements
Quoth David Bremner on Apr 03 at 4:41 pm: > The main goal is to support gzipped output for future internal > calls (e.g. from notmuch-new) to notmuch_database_dump. > > The additional dependency is not very heavy since xapian already pulls > in zlib. > > We want the dump to be "atomic", in the

[Patch v6 4/6] restore: transparently support gzipped input

2014-04-04 Thread Austin Clements
Quoth David Bremner on Apr 03 at 4:41 pm: > We rely completely on zlib to do the right thing in detecting gzipped > input. Since our dump format is chosen to be 7 bit ascii, this should > be fine. > --- > doc/man1/notmuch-restore.rst | 8 > notmuch-restore.c| 41

[PATCH v5 0/2] lib: drop mbox support, replace header parser with gmime

2014-04-04 Thread Austin Clements
LGTM. Quoth Jani Nikula on Mar 31 at 12:21 am: > This is v5 of id:1395604866-19188-1-git-send-email-jani at nikula.org > addressing Austin's review. The most significant change is the new patch > dropping support for single-message mbox files. Diff between the > versions is at the end of this

Re: [Patch v6 4/6] restore: transparently support gzipped input

2014-04-04 Thread Austin Clements
Quoth David Bremner on Apr 03 at 4:41 pm: We rely completely on zlib to do the right thing in detecting gzipped input. Since our dump format is chosen to be 7 bit ascii, this should be fine. --- doc/man1/notmuch-restore.rst | 8 notmuch-restore.c| 41

Re: [Patch v6 1/6] dump: support gzipped and atomic output

2014-04-04 Thread Austin Clements
Quoth David Bremner on Apr 03 at 4:41 pm: The main goal is to support gzipped output for future internal calls (e.g. from notmuch-new) to notmuch_database_dump. The additional dependency is not very heavy since xapian already pulls in zlib. We want the dump to be atomic, in the sense

Re: [Patch v6 4/6] restore: transparently support gzipped input

2014-04-04 Thread Austin Clements
Quoth David Bremner on Apr 03 at 4:41 pm: We rely completely on zlib to do the right thing in detecting gzipped input. Since our dump format is chosen to be 7 bit ascii, this should be fine. --- doc/man1/notmuch-restore.rst | 8 notmuch-restore.c| 41

[Patch v5 2/6] dump: when given output file name, write atomically

2014-04-02 Thread Austin Clements
On Tue, 01 Apr 2014, Austin Clements wrote: > (Pardon the mobile review) Apparently it's 2014 and the latest and greatest version of Android still can't be bothered to add threading headers to emails. This message should at least put it in the right thread by exploiting notmuch's thread link

<    1   2   3   4   5   6   7   8   9   10   >