https://github.com/steakhal requested changes to this pull request.
The docs should also explain why is a problem to have padding bytes, and how to
fix it.
How does the generated html look like after your change for this file?
(Have a look at my commits to this or to the releasenotes file for
@@ -804,10 +804,28 @@ Check for performance anti-patterns when using Grand
Central Dispatch.
.. _optin-performance-Padding:
-optin.performance.Padding
-"
+optin.performance.Padding (PaddingChecker)
https://github.com/steakhal closed
https://github.com/llvm/llvm-project/pull/84972
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Alejandro Álvarez Ayllón
Date: 2024-03-22T11:50:34+01:00
New Revision: 730ca47a0cc7380def6df1d25b30c1378fd8bf14
URL:
https://github.com/llvm/llvm-project/commit/730ca47a0cc7380def6df1d25b30c1378fd8bf14
DIFF:
https://github.com/steakhal updated
https://github.com/llvm/llvm-project/pull/84972
>From f66c62bcf3fd1427ad3f5061ec23110c1c3a5b6e Mon Sep 17 00:00:00 2001
From: Balazs Benics
Date: Tue, 12 Mar 2024 19:55:29 +0100
Subject: [PATCH] [analyzer] Support C++23 static operator calls
Made by
Alejandro =?utf-8?q?Álvarez_Ayllón?Message-ID:
In-Reply-To:
https://github.com/steakhal closed
https://github.com/llvm/llvm-project/pull/83027
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
steakhal wrote:
Ping @NagyDonat
https://github.com/llvm/llvm-project/pull/84823
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Alejandro =?utf-8?q?=C3=81lvarez_Ayll=C3=B3n?=
Message-ID:
In-Reply-To:
steakhal wrote:
Rebase merged.
https://github.com/llvm/llvm-project/pull/83027
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
Author: Alejandro Álvarez Ayllón
Date: 2024-03-22T11:50:34+01:00
New Revision: a62441d4bb6bd0cd8eccab8c5692340c5a2c60bb
URL:
https://github.com/llvm/llvm-project/commit/a62441d4bb6bd0cd8eccab8c5692340c5a2c60bb
DIFF:
https://github.com/steakhal approved this pull request.
lgtm
https://github.com/llvm/llvm-project/pull/85515
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
steakhal wrote:
I'm sorry, but I'm out of bandwidth. Maybe someone else can step up for the
review.
https://github.com/llvm/llvm-project/pull/83675
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
steakhal wrote:
@NagyDonat Thank you for the excellent feedback. Great recommendations, with
fixes. Thanks!
All applied.
https://github.com/llvm/llvm-project/pull/85211
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
@@ -1090,7 +1090,8 @@ static bool isStandardNewDelete(const FunctionDecl *FD) {
// If the header for operator delete is not included, it's still defined
// in an invalid source location. Check to make sure we don't crash.
return !L.isValid() ||
-
steakhal wrote:
Retriggered the premerge checks.
https://github.com/llvm/llvm-project/pull/83985
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/steakhal updated
https://github.com/llvm/llvm-project/pull/83985
>From 881701d528255e2c49ed64f5f1df98f0f44c1d7b Mon Sep 17 00:00:00 2001
From: Viktor
Date: Tue, 5 Mar 2024 09:46:26 +
Subject: [PATCH] [clang][analyzer] Bring cplusplus.ArrayDelete out of alpha
---
https://github.com/steakhal closed
https://github.com/llvm/llvm-project/pull/85104
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/steakhal closed
https://github.com/llvm/llvm-project/pull/85211
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/steakhal updated
https://github.com/llvm/llvm-project/pull/85211
>From bde85e0d145049a6661afba6f4585865c5630792 Mon Sep 17 00:00:00 2001
From: Balazs Benics
Date: Thu, 14 Mar 2024 12:38:12 +0100
Subject: [PATCH 1/4] [analyzer] Wrap SymbolicRegions by ElementRegions before
https://github.com/steakhal updated
https://github.com/llvm/llvm-project/pull/85104
>From 0f964127ed91e23f8e969e08ce680535cfeb8906 Mon Sep 17 00:00:00 2001
From: Andreas Steinhausen
Date: Wed, 13 Mar 2024 17:07:53 +0100
Subject: [PATCH 01/12] Adapted MemRegion::getDescriptiveName to handle
https://github.com/steakhal updated
https://github.com/llvm/llvm-project/pull/85211
>From bde85e0d145049a6661afba6f4585865c5630792 Mon Sep 17 00:00:00 2001
From: Balazs Benics
Date: Thu, 14 Mar 2024 12:38:12 +0100
Subject: [PATCH 1/3] [analyzer] Wrap SymbolicRegions by ElementRegions before
steakhal wrote:
> Hi @steakhal, just to be sure. We are talking about a test case that covers
> that the index is "recognised" as a wrong variable (the matrix example above)?
Exactly!
https://github.com/llvm/llvm-project/pull/85104
___
cfe-commits
@@ -1186,6 +1192,14 @@ def main():
"displaying it, dump the rewritten dot file "
"to stdout",
)
+dump_conflict.add_argument(
+"--dump-html-only",
+action="store_const",
+dest="dump_html_only",
+const=True,
+
@@ -479,12 +479,15 @@ def add_raw_line(self, raw_line):
# A visitor that dumps the ExplodedGraph into a DOT file with fancy HTML-based
# syntax highlighing.
class DotDumpVisitor:
-def __init__(self, do_diffs, dark_mode, gray_mode, topo_mode,
dump_dot_only):
+def
steakhal wrote:
@T-Gruber Could you please add that test case with a FIXME?
https://github.com/llvm/llvm-project/pull/85104
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
steakhal wrote:
> I think it's good that we're moving towards establishing the invariant that
> the parent of a FieldRegion should always be a typed value region (of a
> suitable type) for the sake of consistency. Do I understand it correctly that
> this is not too far away? Would it be
@@ -451,6 +451,38 @@ void ProgramState::setStore(const StoreRef ) {
store = newStoreStore;
}
+/// FieldRegions are expected to be wrapped by an ElementRegion as a canonical
+/// representation. See f8643a9b31c4029942f67d4534c9139b45173504 why.
+static SVal
https://github.com/steakhal updated
https://github.com/llvm/llvm-project/pull/85211
>From bde85e0d145049a6661afba6f4585865c5630792 Mon Sep 17 00:00:00 2001
From: Balazs Benics
Date: Thu, 14 Mar 2024 12:38:12 +0100
Subject: [PATCH 1/2] [analyzer] Wrap SymbolicRegions by ElementRegions before
@@ -1090,7 +1090,8 @@ static bool isStandardNewDelete(const FunctionDecl *FD) {
// If the header for operator delete is not included, it's still defined
// in an invalid source location. Check to make sure we don't crash.
return !L.isValid() ||
-
https://github.com/steakhal requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/85224
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/steakhal edited
https://github.com/llvm/llvm-project/pull/85224
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
steakhal wrote:
> In addition to the above-mentioned issues there is also a conceptual problem
> with using `getOriginRegion()` to describe a symbol: it names the region
> where the symbol _originated_ (if it originated as the unknown initial value
> of a symbol), which is not necessarily the
@@ -720,14 +720,20 @@ std::string MemRegion::getDescriptiveName(bool UseQuotes)
const {
CI->getValue().toString(Idx);
ArrayIndices = (llvm::Twine("[") + Idx.str() + "]" + ArrayIndices).str();
}
-// If not a ConcreteInt, try to obtain the variable
-//
https://github.com/steakhal created
https://github.com/llvm/llvm-project/pull/85211
Inside the ExprEngine when we process the initializers, we create a
PostInitializer program-point, which will refer to the field being initialized,
see `FieldLoc` inside `ExprEngine::ProcessInitializer`.
When
https://github.com/steakhal closed
https://github.com/llvm/llvm-project/pull/82089
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/steakhal updated
https://github.com/llvm/llvm-project/pull/82089
>From 2802ef4b9ed88da3cacb16ab7738907ee806 Mon Sep 17 00:00:00 2001
From: huang-me
Date: Sat, 17 Feb 2024 10:43:48 +0800
Subject: [PATCH 01/10] Fix crash on StaticAnalyzer loop unrolling
---
https://github.com/steakhal updated
https://github.com/llvm/llvm-project/pull/82089
>From 2802ef4b9ed88da3cacb16ab7738907ee806 Mon Sep 17 00:00:00 2001
From: huang-me
Date: Sat, 17 Feb 2024 10:43:48 +0800
Subject: [PATCH 1/9] Fix crash on StaticAnalyzer loop unrolling
---
steakhal wrote:
> Hello @steakhal, I have just looked through the changes again. What is the
> advantage of using checkPreCall instead of checkLocation? I would very much
> appreciate some background information. Thanks for your help!
Oh yes, I should have explained.
So, `checkLocation` can
https://github.com/steakhal updated
https://github.com/llvm/llvm-project/pull/82089
>From 2802ef4b9ed88da3cacb16ab7738907ee806 Mon Sep 17 00:00:00 2001
From: huang-me
Date: Sat, 17 Feb 2024 10:43:48 +0800
Subject: [PATCH 1/8] Fix crash on StaticAnalyzer loop unrolling
---
@@ -1,5 +1,7 @@
// RUN: %clang_analyze_cc1 -analyzer-checker=core,debug.ExprInspection
-analyzer-config unroll-loops=true,cfg-loopexit=true -verify -std=c++14
-analyzer-config exploration_strategy=unexplored_first_queue %s
// RUN: %clang_analyze_cc1
https://github.com/steakhal updated
https://github.com/llvm/llvm-project/pull/82089
>From 2802ef4b9ed88da3cacb16ab7738907ee806 Mon Sep 17 00:00:00 2001
From: huang-me
Date: Sat, 17 Feb 2024 10:43:48 +0800
Subject: [PATCH 1/7] Fix crash on StaticAnalyzer loop unrolling
---
https://github.com/steakhal updated
https://github.com/llvm/llvm-project/pull/82089
>From 2802ef4b9ed88da3cacb16ab7738907ee806 Mon Sep 17 00:00:00 2001
From: huang-me
Date: Sat, 17 Feb 2024 10:43:48 +0800
Subject: [PATCH 1/6] Fix crash on StaticAnalyzer loop unrolling
---
https://github.com/steakhal updated
https://github.com/llvm/llvm-project/pull/85104
>From 0f964127ed91e23f8e969e08ce680535cfeb8906 Mon Sep 17 00:00:00 2001
From: Andreas Steinhausen
Date: Wed, 13 Mar 2024 17:07:53 +0100
Subject: [PATCH 1/9] Adapted MemRegion::getDescriptiveName to handle
steakhal wrote:
> However, I feel an urge to bikeshed that the "[invisible]" prefix is a bit
> puzzling for the developer who encounters it. Consider replacing it with the
> prefix "[debug]" which is a more conventional signal for "this is a debug
> printout" (i.e. normal users won't see it).
steakhal wrote:
I hope you don't mind that I reworked the testing a bit, to be similar to the
rest of the tests.
I also reverted unnecessary clang-formatting where it was not relevant.
I refined the `auto` usage, but other than that I left your code untouched.
As I did everything I thought,
https://github.com/steakhal updated
https://github.com/llvm/llvm-project/pull/85104
>From 0f964127ed91e23f8e969e08ce680535cfeb8906 Mon Sep 17 00:00:00 2001
From: Andreas Steinhausen
Date: Wed, 13 Mar 2024 17:07:53 +0100
Subject: [PATCH 1/8] Adapted MemRegion::getDescriptiveName to handle
steakhal wrote:
Merged to main as e48d5a838f69e0a8e0ae95a8aed1a8809f45465a
https://github.com/llvm/llvm-project/pull/84963
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/steakhal closed
https://github.com/llvm/llvm-project/pull/84963
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: NagyDonat
Date: 2024-03-13T14:48:42+01:00
New Revision: e48d5a838f69e0a8e0ae95a8aed1a8809f45465a
URL:
https://github.com/llvm/llvm-project/commit/e48d5a838f69e0a8e0ae95a8aed1a8809f45465a
DIFF:
https://github.com/llvm/llvm-project/commit/e48d5a838f69e0a8e0ae95a8aed1a8809f45465a.diff
https://github.com/steakhal updated
https://github.com/llvm/llvm-project/pull/84963
>From e48d5a838f69e0a8e0ae95a8aed1a8809f45465a Mon Sep 17 00:00:00 2001
From: NagyDonat
Date: Tue, 12 Mar 2024 18:24:26 +0100
Subject: [PATCH] Reapply "[analyzer] Accept C library functions from the `std`
https://github.com/steakhal updated
https://github.com/llvm/llvm-project/pull/84963
>From bca501228e3a146d3ca6c05b7de15fd914fb16b9 Mon Sep 17 00:00:00 2001
From: NagyDonat
Date: Tue, 12 Mar 2024 18:24:26 +0100
Subject: [PATCH] Reapply "[analyzer] Accept C library functions from the `std`
steakhal wrote:
You gave approval for the fix for the buggy tests I suggested. I think there is
nothing wrong with this.
Thanks for having a look at my fix.
Ill recommit this as you authored, and I coauthored.
https://github.com/llvm/llvm-project/pull/84963
https://github.com/steakhal edited
https://github.com/llvm/llvm-project/pull/84972
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/steakhal updated
https://github.com/llvm/llvm-project/pull/84972
>From 9860dad609c8a27dfaa178af5b72285e3ad050fd Mon Sep 17 00:00:00 2001
From: Balazs Benics
Date: Tue, 12 Mar 2024 19:55:29 +0100
Subject: [PATCH 1/3] [analyzer] Support C++23 static operator calls
Made by
https://github.com/steakhal updated
https://github.com/llvm/llvm-project/pull/84972
>From 9860dad609c8a27dfaa178af5b72285e3ad050fd Mon Sep 17 00:00:00 2001
From: Balazs Benics
Date: Tue, 12 Mar 2024 19:55:29 +0100
Subject: [PATCH 1/2] [analyzer] Support C++23 static operator calls
Made by
https://github.com/steakhal created
https://github.com/llvm/llvm-project/pull/84972
Made by following:
https://github.com/llvm/llvm-project/pull/83585#issuecomment-1980340866
Thanks for the details Tomek!
>From 9860dad609c8a27dfaa178af5b72285e3ad050fd Mon Sep 17 00:00:00 2001
From: Balazs
https://github.com/steakhal updated
https://github.com/llvm/llvm-project/pull/84963
>From a88c479c8c1141af65887829e27194b2715ebfb2 Mon Sep 17 00:00:00 2001
From: Balazs Benics
Date: Tue, 12 Mar 2024 18:24:26 +0100
Subject: [PATCH 1/3] Reapply "[analyzer] Accept C library functions from the
=?utf-8?q?Donát?= Nagy ,
=?utf-8?q?Donát?= Nagy ,Balazs Benics
,NagyDonat
Message-ID:
In-Reply-To:
steakhal wrote:
I proposed the PR #84963 for relanding this, including the fix for the
use-after-free of the AST of the unittest.
https://github.com/llvm/llvm-project/pull/84469
https://github.com/steakhal created
https://github.com/llvm/llvm-project/pull/84963
Relands PR #84926, after resolving use-after-free of the AST of the unittest xD
Pretty silly bug, I must admit.
>From a88c479c8c1141af65887829e27194b2715ebfb2 Mon Sep 17 00:00:00 2001
From: Balazs Benics
Date:
=?utf-8?q?Donát?= Nagy ,
=?utf-8?q?Donát?= Nagy ,Balazs Benics
,NagyDonat
Message-ID:
In-Reply-To:
steakhal wrote:
Thanks!
Indeed, it looks like valgrind also complains:
```
[ RUN ] IsCLibraryFunctionTest.AcceptsGlobal
==999215== Invalid read of size 1
==999215==at 0x15420D0:
https://github.com/steakhal closed
https://github.com/llvm/llvm-project/pull/84638
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/steakhal edited
https://github.com/llvm/llvm-project/pull/84638
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/steakhal closed
https://github.com/llvm/llvm-project/pull/84887
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -5121,11 +5142,12 @@ AST_POLYMORPHIC_MATCHER_P2(forEachArgumentWithParamType,
// argument of the method which should not be matched against a parameter, so
// we skip over it here.
BoundNodesTreeBuilder Matches;
- unsigned ArgIndex =
https://github.com/steakhal edited
https://github.com/llvm/llvm-project/pull/84887
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/steakhal edited
https://github.com/llvm/llvm-project/pull/84887
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/steakhal created
https://github.com/llvm/llvm-project/pull/84887
This is a follow-up commit of #84446.
In this patch, I demonstrate that `forEachArgumentWithParam` and
`forEachArgumentWithParamType` did not correctly handle the presence of the
explicit object parameter for
https://github.com/steakhal unassigned
https://github.com/llvm/llvm-project/pull/84823
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/steakhal unassigned
https://github.com/llvm/llvm-project/pull/84823
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/steakhal unassigned
https://github.com/llvm/llvm-project/pull/84823
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/steakhal unassigned
https://github.com/llvm/llvm-project/pull/84823
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/steakhal created
https://github.com/llvm/llvm-project/pull/84823
When debugging CSA issues, sometimes it would be useful to have a dedicated
note for the analysis entry point, aka. the function name you would need to
pass as "-analyze-function=XYZ" to reproduce a specific
=?utf-8?q?Don=C3=A1t?= Nagy ,
=?utf-8?q?Don=C3=A1t?= Nagy ,Balazs Benics
Message-ID:
In-Reply-To:
https://github.com/steakhal approved this pull request.
https://github.com/llvm/llvm-project/pull/84469
___
cfe-commits mailing list
=?utf-8?q?Don=C3=A1t?= Nagy ,
=?utf-8?q?Don=C3=A1t?= Nagy ,Balazs Benics
Message-ID:
In-Reply-To:
@@ -0,0 +1,89 @@
+#include "clang/ASTMatchers/ASTMatchFinder.h"
+#include "clang/ASTMatchers/ASTMatchers.h"
+#include "clang/Analysis/AnalysisDeclContext.h"
+#include
=?utf-8?q?Donát?= Nagy ,
=?utf-8?q?Donát?= Nagy ,Balazs Benics
Message-ID:
In-Reply-To:
@@ -0,0 +1,89 @@
+#include "clang/ASTMatchers/ASTMatchFinder.h"
+#include "clang/ASTMatchers/ASTMatchers.h"
+#include "clang/Analysis/AnalysisDeclContext.h"
+#include
=?utf-8?q?Donát?= Nagy ,
=?utf-8?q?Donát?= Nagy ,Balazs Benics
Message-ID:
In-Reply-To:
@@ -0,0 +1,89 @@
+#include "clang/ASTMatchers/ASTMatchFinder.h"
+#include "clang/ASTMatchers/ASTMatchers.h"
+#include "clang/Analysis/AnalysisDeclContext.h"
+#include
=?utf-8?q?Don=C3=A1t?= Nagy ,
=?utf-8?q?Don=C3=A1t?= Nagy ,Balazs Benics
Message-ID:
In-Reply-To:
https://github.com/steakhal approved this pull request.
I'm good now.
https://github.com/llvm/llvm-project/pull/84469
___
cfe-commits mailing list
=?utf-8?q?Donát?= Nagy ,
=?utf-8?q?Donát?= Nagy ,Balazs Benics
Message-ID:
In-Reply-To:
https://github.com/steakhal edited
https://github.com/llvm/llvm-project/pull/84469
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
Alejandro =?utf-8?q?Álvarez_Ayllón?=,
Alejandro =?utf-8?q?Álvarez_Ayllón?=,
Alejandro =?utf-8?q?Álvarez_Ayllón?=,
Alejandro =?utf-8?q?Álvarez_Ayllón?=,
Alejandro =?utf-8?q?Álvarez_Ayllón?=,
Alejandro =?utf-8?q?Álvarez_Ayllón?Message-ID:
In-Reply-To:
steakhal wrote:
> I want to avoid that some
=?utf-8?q?Don=C3=A1t?= Nagy ,NagyDonat
Message-ID:
In-Reply-To:
https://github.com/steakhal approved this pull request.
I scrolled over, and it looks harmless, so LGTM.
https://github.com/llvm/llvm-project/pull/84201
___
cfe-commits mailing list
@@ -194,11 +194,12 @@ class CoreEngine {
};
// TODO: Turn into a class.
steakhal wrote:
Remove this TODO, as its completed.
https://github.com/llvm/llvm-project/pull/84638
___
cfe-commits mailing list
https://github.com/steakhal commented:
Alright. So we can simply mark all the members private. I was surprised a bit.
LGTM, but remove the TODO comment you fix.
https://github.com/llvm/llvm-project/pull/84638
___
cfe-commits mailing list
https://github.com/steakhal edited
https://github.com/llvm/llvm-project/pull/84638
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/steakhal requested changes to this pull request.
See my previous reply.
https://github.com/llvm/llvm-project/pull/84638
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
steakhal wrote:
Thanks for the PR.
I think it would make sense to not expose data members in a class' public api.
We might need some member functions along the way to make this possible.
https://github.com/llvm/llvm-project/pull/84638
___
cfe-commits
=?utf-8?q?Donát?= Nagy ,
=?utf-8?q?Donát?= Nagy
Message-ID:
In-Reply-To:
steakhal wrote:
> I feel that I'm getting bogged down in this area with changes that are more
> general than what's strictly necessary and only tangentially related to my
> real goals...
>
> I'm not familiar with the
Alejandro =?utf-8?q?Álvarez_Ayllón?=,
Alejandro =?utf-8?q?Álvarez_Ayllón?=,
Alejandro =?utf-8?q?Álvarez_Ayllón?=,
Alejandro =?utf-8?q?Álvarez_Ayllón?=,
Alejandro =?utf-8?q?Álvarez_Ayllón?=,
Alejandro =?utf-8?q?Álvarez_Ayllón?Message-ID:
In-Reply-To:
steakhal wrote:
> This functionality could
Alejandro =?utf-8?q?Álvarez_Ayllón?=,
Alejandro =?utf-8?q?Álvarez_Ayllón?=,
Alejandro =?utf-8?q?Álvarez_Ayllón?=,
Alejandro =?utf-8?q?Álvarez_Ayllón?=,
Alejandro =?utf-8?q?Álvarez_Ayllón?=,
Alejandro =?utf-8?q?Álvarez_Ayllón?Message-ID:
In-Reply-To:
@@ -1158,6 +1173,118 @@ void
steakhal wrote:
I had to push a fixup commit, because I forgot about one switch-case.
https://github.com/llvm/llvm-project/commit/f07157eb2e8212068cb9469d77f9bc3779ef2ea4
I pushed it already to fix the build bot, but let me know if you disagree with
the fix.
Author: Balazs Benics
Date: 2024-03-08T14:55:10+01:00
New Revision: f07157eb2e8212068cb9469d77f9bc3779ef2ea4
URL:
https://github.com/llvm/llvm-project/commit/f07157eb2e8212068cb9469d77f9bc3779ef2ea4
DIFF:
https://github.com/llvm/llvm-project/commit/f07157eb2e8212068cb9469d77f9bc3779ef2ea4.diff
Alejandro =?utf-8?q?Álvarez_Ayllón?=,
Alejandro =?utf-8?q?Álvarez_Ayllón?=,
Alejandro =?utf-8?q?Álvarez_Ayllón?=,
Alejandro =?utf-8?q?Álvarez_Ayllón?=,
Alejandro =?utf-8?q?Álvarez_Ayllón?=,
Alejandro =?utf-8?q?Álvarez_Ayllón?Message-ID:
In-Reply-To:
https://github.com/steakhal edited
Alejandro =?utf-8?q?=C3=81lvarez_Ayll=C3=B3n?=,
Alejandro =?utf-8?q?=C3=81lvarez_Ayll=C3=B3n?=,
Alejandro =?utf-8?q?=C3=81lvarez_Ayll=C3=B3n?=,
Alejandro =?utf-8?q?=C3=81lvarez_Ayll=C3=B3n?=,
Alejandro =?utf-8?q?=C3=81lvarez_Ayll=C3=B3n?=,
Alejandro =?utf-8?q?=C3=81lvarez_Ayll=C3=B3n?=
Message-ID:
=?utf-8?q?Donát?= Nagy
Message-ID:
In-Reply-To:
@@ -109,6 +136,33 @@ int *potentialAfterTheEndPtr(int idx) {
// [idx].
}
+int overflowOrUnderflow(int arg) {
+ // expected-note@+2 {{Assuming 'arg' is < 0}}
+ // expected-note@+1 {{Taking false branch}}
+ if (arg >= 0)
+
=?utf-8?q?Donát?= Nagy ,
=?utf-8?q?Donát?= Nagy
Message-ID:
In-Reply-To:
https://github.com/steakhal commented:
Looks good to me, but I'd be more eased if had seen some unittests for this
matter.
You could use AST-matchers selecting different FunctionDecls and query them
using this
@@ -2515,6 +2518,57 @@ void CStringChecker::evalSprintfCommon(CheckerContext
, const CallEvent ,
C.addTransition(State);
}
+void CStringChecker::evalGetentropy(CheckerContext ,
+const CallEvent , CharKind CK) const {
+
@@ -529,3 +529,42 @@ void nocrash_on_locint_offset(void *addr, void* from,
struct S s) {
size_t iAdd = (size_t) addr;
memcpy(((void *) &(s.f)), from, iAdd);
}
+
+#if defined(__linux__) || defined(__FreeBSD__) || defined(__OpenBSD__)
+/* present in both glibc 2.25 and musl
@@ -2515,6 +2518,57 @@ void CStringChecker::evalSprintfCommon(CheckerContext
, const CallEvent ,
C.addTransition(State);
}
+void CStringChecker::evalGetentropy(CheckerContext ,
+const CallEvent , CharKind CK) const {
+
@@ -219,6 +221,7 @@ class CStringChecker : public Checker< eval::Call,
void evalSnprintf(CheckerContext , const CallEvent ) const;
void evalSprintfCommon(CheckerContext , const CallEvent ,
bool IsBounded, bool IsBuiltin) const;
+ void
@@ -2515,6 +2518,57 @@ void CStringChecker::evalSprintfCommon(CheckerContext
, const CallEvent ,
C.addTransition(State);
}
+void CStringChecker::evalGetentropy(CheckerContext ,
+const CallEvent , CharKind CK) const {
+
@@ -2516,6 +2518,47 @@ void CStringChecker::evalSprintfCommon(CheckerContext
, const CallEvent ,
C.addTransition(State);
}
+void CStringChecker::evalGetentropy(CheckerContext ,
+const CallEvent ) const {
+ DestinationArgExpr Buffer =
@@ -2515,6 +2518,57 @@ void CStringChecker::evalSprintfCommon(CheckerContext
, const CallEvent ,
C.addTransition(State);
}
+void CStringChecker::evalGetentropy(CheckerContext ,
+const CallEvent , CharKind CK) const {
+
201 - 300 of 1050 matches
Mail list logo