Re: RFR: JDK-8319413: Start of release updates for JDK 23 [v4]

2023-12-01 Thread Alan Bateman
On Thu, 30 Nov 2023 23:49:24 GMT, Joe Darcy wrote: >> Time to start making preparations for JDK 23. > > Joe Darcy has updated the pull request incrementally with one additional > commit since the last revision: > > Update symbol files to JDK 22 b26. Good good. I assume you'll bump the

Re: RFR: JDK-8319626: Override toString() for ZipFile [v5]

2023-12-01 Thread Alan Bateman
On Thu, 30 Nov 2023 21:08:35 GMT, Justin Lu wrote: >> Hello Justin, >> >>> I am not sure if you have a preference one way or another regarding >>> providing the full path versus just the file name, but I can switch the >>> full path for just the file name if need be. >> >> My opinion is that

Integrated: 8320716: ResolvedModule::reads includes self when configuration contains two or more automatic modules

2023-11-30 Thread Alan Bateman
On Sun, 26 Nov 2023 18:18:10 GMT, Alan Bateman wrote: > This is update to the specification of the j.l.module.ResolvedModule.reads > method to clarify that the set of resolved modules returned does not include > itself. There is a small implementation change to align with the > s

Re: RFR: 8320716: ResolvedModule::reads includes self when configuration contains two or more automatic modules [v2]

2023-11-30 Thread Alan Bateman
ed to add new asserts to each of the > testConfigurationXXX methods. I decided to migrate this test to JUnit while > visiting, most of it is just migrating the TestNG data providers to be > parameterized tests. If needed then we could separate this but it's a simple > migration so I l

Re: Integrated: 8321127: ProblemList java/util/stream/GatherersTest.java

2023-11-30 Thread Alan Bateman
On Thu, 30 Nov 2023 16:08:54 GMT, Daniel D. Daugherty wrote: > A trivial fix to ProblemList java/util/stream/GatherersTest.java. Marked as reviewed by alanb (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/16909#pullrequestreview-1757847283

Re: RFR: 8319123: Implement JEP 461: Stream Gatherers (Preview) [v14]

2023-11-30 Thread Alan Bateman
On Thu, 30 Nov 2023 14:30:25 GMT, Viktor Klang wrote: >> This Pull-Request implements [JEP-461](https://openjdk.org/jeps/461) > > Viktor Klang has updated the pull request with a new target base due to a > merge or a rebase. The pull request now contains 32 commits: > > - Lowering upper

Re: RFR: 8315034 : File.mkdirs() occasionally fails to create folders on Windows shared folder

2023-11-30 Thread Alan Bateman
On Fri, 3 Nov 2023 18:11:10 GMT, Weibing Xiao wrote: > File.mkdirs() occasionally fails to create folders on Windows shared folders. > It turned out that Windows API FindFirstFileW created the error > ERROR_NO_MORE_FILES. In some of the cases with a valid file path, this error > still returns

Re: RFR: 8320798: Console read line with zero out should zero out underlying buffer [v2]

2023-11-30 Thread Alan Bateman
On Thu, 30 Nov 2023 11:10:44 GMT, Jaikiran Pai wrote: > Given that the default `JdkConsole` provider implementation is the one that > uses jline (in `jdk.internal.le` module), should we also do something to zero > out this data in its implementation too. A brief glance suggests that it too >

Re: RFR: 8319123: Implement JEP 461: Stream Gatherers (Preview) [v5]

2023-11-30 Thread Alan Bateman
On Mon, 13 Nov 2023 10:08:20 GMT, Tagir F. Valeev wrote: >> Viktor Klang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Minor improvements to Gatherer Javadoc > > Marked as reviewed by tvaleev (Committer). > @amaembo, @AlanBateman,

Re: RFR: 8320652: ThreadInfo.isInNative needs to be updated to say what executing native code means [v2]

2023-11-30 Thread Alan Bateman
On Wed, 29 Nov 2023 10:49:12 GMT, Alan Bateman wrote: >>> seems to be no java method marked "native" on the stack, what case is that? >> >> A native thread that is attached to the VM but is not currently executing >> any Java code. >> >>>

Re: RFR: 8320971: Use BufferedInputStream.buf directly when param of implTransferTo() is trusted [v2]

2023-11-30 Thread Alan Bateman
On Thu, 30 Nov 2023 04:31:41 GMT, jmehrens wrote: > You have to know that it is in the java.io package and it doesn't wrap > another stream. That is a good point. In the previous work on this override, we converged on the current implementation to not leak the internal byte[] to the target.

Re: RFR: 8320860: add-opens/add-exports require '=' in JAVA_TOOL_OPTIONS

2023-11-30 Thread Alan Bateman
On Thu, 30 Nov 2023 04:30:28 GMT, David Holmes wrote: > I do not believe this clarification needs a CSR request. I agree, there isn't any new testable assertion here as it is already in the JNI spec. src/hotspot/share/prims/jvmti.xml line 746: > 744: JNI_CreateJavaVM (in the JNI

Re: RFR: 8320971: Use BufferedInputStream.buf directly when param of implTransferTo() is trusted

2023-11-29 Thread Alan Bateman
On Wed, 29 Nov 2023 20:07:37 GMT, Vladimir Sitnikov wrote: > The buffer in question is protected, so any subclass can directly access it. > In other words, untrusted code can easily acoess the buffer, and it does not > sound fair to add extra overhead to the method which was created for the

Re: RFR: 8320971: Use BufferedInputStream.buf directly when param of implTransferTo() is trusted

2023-11-29 Thread Alan Bateman
On Wed, 29 Nov 2023 11:57:37 GMT, Sergey Tsypanov wrote: > It looks like we can skip copying of `byte[]` in > `BufferedInputStream.implTransferTo()` for `OutputStreams` residing in > `java.io`. > > See comment by @vlsi in >

Re: RFR: 8320971: Use BufferedInputStream.buf directly when param of implTransferTo() is trusted

2023-11-29 Thread Alan Bateman
On Wed, 29 Nov 2023 13:56:34 GMT, Vladimir Sitnikov wrote: > What do you think of passing the buffer as is? No, it should only do for trusted targets. BAIS has an issue in that area that should be fixed. - PR Review Comment:

Re: RFR: 8320652: ThreadInfo.isInNative needs to be updated to say what executing native code means [v2]

2023-11-29 Thread Alan Bateman
On Wed, 29 Nov 2023 06:44:58 GMT, David Holmes wrote: > JDWP filters its own internal threads out of any thread lists it returns, so > this may be a case of using two different API's with different views of the > set of threads running. I think the issue that Bernd is running into is a long

Integrated: 8320858: Move jpackage tests to tier3

2023-11-29 Thread Alan Bateman
On Tue, 28 Nov 2023 08:51:17 GMT, Alan Bateman wrote: > Update the jtreg test group configuration in the jdk test tree so that the > jpackage tests run in tier3 rather than tier2. > > At this time, the jpackage tests run in jdk:tier2, more specifically > jdk:tier

Re: RFR: 8310994: Add JFR event for selection operations

2023-11-28 Thread Alan Bateman
On Tue, 28 Nov 2023 20:34:34 GMT, Markus Grönlund wrote: > Isn't this a replacement for the existing instrumentation? If these are new > events I am sorry. It's a new event. > What is keeping us from removing ASM in that case? I think file I/O, there is still instrumentation used for

Re: RFR: 8320798: Console read line with zero out should zero out underlying buffer [v2]

2023-11-28 Thread Alan Bateman
On Tue, 28 Nov 2023 19:27:45 GMT, Naoto Sato wrote: >> src/java.base/share/classes/sun/nio/cs/StreamDecoder.java line 294: >> >>> 292: private void lockedFillZeroToPosition() throws IOException { >>> 293: ensureOpen(); >>> 294: Arrays.fill(bb.array(), 0, bb.arrayOffset() +

Re: RFR: 8316141: Improve CEN header validation checking

2023-11-28 Thread Alan Bateman
On Tue, 28 Nov 2023 20:06:25 GMT, Lance Andersen wrote: > Given where we are in the JDK 22 cycle, going to hold off on finalizing the > PR until we fork for JDK 23 and look to move this forward early on allowing > for additional time to bake Tightening validation always comes with risk. Doing

Re: RFR: 8320798: Console read line with zero out should zero out underlying buffer [v2]

2023-11-28 Thread Alan Bateman
On Tue, 28 Nov 2023 19:30:34 GMT, Naoto Sato wrote: >> It is best practice to zero out the underlying buffer after use. > > Naoto Sato has updated the pull request incrementally with one additional > commit since the last revision: > > corrected fromIndex Marked as reviewed by alanb

Re: RFR: 8320665: update jdk_core at test/jdk/TEST.groups [v2]

2023-11-28 Thread Alan Bateman
On Tue, 28 Nov 2023 18:26:37 GMT, Ivan Šipka wrote: >> @bwhuang-us @mahendrachhipa > > Ivan Šipka has updated the pull request incrementally with one additional > commit since the last revision: > > added jdk_core_no_security as additional group defintion, reverting old > base definition

Re: RFR: 8310994: Add JFR event for selection operations

2023-11-28 Thread Alan Bateman
On Tue, 28 Nov 2023 18:21:33 GMT, Markus Grönlund wrote: > It would be good to integrate this quite soon because it would release the > reliance on ASM and let us only use the new ClassFile API. Now, we need to > load both implementations, leading to startup regression. This is a new event so

Re: RFR: 8319417: (dc) DatagramChannel.connect undocumented behavior [v2]

2023-11-28 Thread Alan Bateman
On Tue, 28 Nov 2023 20:06:15 GMT, Mark Sheppard wrote: > Hmm! sound like a bit of a fudge, and doesn't really make sense, as > DatagramSocket and DatagramChannel essentially delegate to the same > underlying implementation, which in turn delgates to the same underlying > native implementation

Re: RFR: 8319417: (dc) DatagramChannel.connect undocumented behavior [v2]

2023-11-28 Thread Alan Bateman
On Tue, 28 Nov 2023 18:49:53 GMT, Mark Sheppard wrote: > Returns: the local address to which the socket is bound, null if the socket > is closed, or an InetAddress representing >

Re: Revisiting JDK-4512189: ZipConstants leaking into public APIs

2023-11-28 Thread Alan Bateman
On 28/11/2023 15:50, Eirik Bjørsnøs wrote: : In light of this, I would like to revisit this issue, 22 years later: - Is my assessment that this change is actually not binary incompatible sound, or did I miss something? - Would it in any case make sense to mark ZipConstants as @Deprecated,

Re: Issue with Nifi pipeline

2023-11-28 Thread Russell Bateman
Sonia, It sounds like you may prefer the Users Mailing List (us...@nifi.apache.org)rather than this one which is more for custom processors and other development-related activities. Best regards, Russ On 11/27/23 22:49, Sonia Soleimani wrote: Hello, I am working for Telus and there has

Re: RFR: JDK-8315458 Implement JEP 463: Implicitly Declared Classes and Instance Main Method (Second Preview) [v36]

2023-11-28 Thread Alan Bateman
On Tue, 28 Nov 2023 13:52:53 GMT, Jim Laskey wrote: >> Address changes from JEP 445 to JEP 463. >> >> - Move from a SYNTHETIC unnamed class to a MANDATED implicit class. >> >> - Don't mark class on read. >> >> - Remove reflection and annotation processing related to unnamed classes. >> >> -

Re: RFR: JDK-8315458 Implement JEP 463: Implicitly Declared Classes and Instance Main Method (Second Preview) [v36]

2023-11-28 Thread Alan Bateman
On Tue, 28 Nov 2023 13:52:53 GMT, Jim Laskey wrote: >> Address changes from JEP 445 to JEP 463. >> >> - Move from a SYNTHETIC unnamed class to a MANDATED implicit class. >> >> - Don't mark class on read. >> >> - Remove reflection and annotation processing related to unnamed classes. >> >> -

Re: RFR: JDK-8315458 Implement JEP 463: Implicitly Declared Classes and Instance Main Method (Second Preview) [v36]

2023-11-28 Thread Alan Bateman
On Tue, 28 Nov 2023 13:52:53 GMT, Jim Laskey wrote: >> Address changes from JEP 445 to JEP 463. >> >> - Move from a SYNTHETIC unnamed class to a MANDATED implicit class. >> >> - Don't mark class on read. >> >> - Remove reflection and annotation processing related to unnamed classes. >> >> -

Re: RFR: JDK-8315458 Implement JEP 463: Implicitly Declared Classes and Instance Main Method (Second Preview) [v36]

2023-11-28 Thread Alan Bateman
On Tue, 28 Nov 2023 13:52:53 GMT, Jim Laskey wrote: >> Address changes from JEP 445 to JEP 463. >> >> - Move from a SYNTHETIC unnamed class to a MANDATED implicit class. >> >> - Don't mark class on read. >> >> - Remove reflection and annotation processing related to unnamed classes. >> >> -

Re: RFR: 8320652: ThreadInfo.isInNative needs to be updated to say what executing native code means [v2]

2023-11-28 Thread Alan Bateman
On Tue, 28 Nov 2023 14:29:20 GMT, Bernd wrote: > btw for the following (system/native/runtime/embryotic) Reader thread tseems > to be no java method marked "native" on the stack, what case is that? > > ``` > "JDWP Event Helper Thread" #22 daemon prio=10 os_prio=0 cpu=0.00ms > elapsed=65.02s

Re: RFR: JDK-8315458 Implement JEP 463: Implicitly Declared Classes and Instance Main Method (Second Preview) [v36]

2023-11-28 Thread Alan Bateman
On Tue, 28 Nov 2023 13:52:53 GMT, Jim Laskey wrote: >> Address changes from JEP 445 to JEP 463. >> >> - Move from a SYNTHETIC unnamed class to a MANDATED implicit class. >> >> - Don't mark class on read. >> >> - Remove reflection and annotation processing related to unnamed classes. >> >> -

Re: RFR: JDK-8315458 Implement JEP 463: Implicitly Declared Classes and Instance Main Method (Second Preview) [v36]

2023-11-28 Thread Alan Bateman
On Tue, 28 Nov 2023 13:52:53 GMT, Jim Laskey wrote: >> Address changes from JEP 445 to JEP 463. >> >> - Move from a SYNTHETIC unnamed class to a MANDATED implicit class. >> >> - Don't mark class on read. >> >> - Remove reflection and annotation processing related to unnamed classes. >> >> -

Re: RFR: JDK-8319662 ForkJoinPool trims worker threads too slowly [v5]

2023-11-28 Thread Alan Bateman
On Mon, 27 Nov 2023 22:44:30 GMT, Doug Lea wrote: >> This update cascades timeouts to trim subsequent workers after the first >> keepAlive inactive period. > > Doug Lea has updated the pull request incrementally with one additional > commit since the last revision: > > Revert 2 lines in

RFR: 8320786: Remove ThreadGroup.stop

2023-11-28 Thread Alan Bateman
ThreadGroup.stop was deprecated since JDK 1.2, deprecated for removal in Java 18, and re-specified/degraded to throw UnsupportedOperationException unconditionally in Java 20. Early in Java 23 seems a fine time to finally remove this method. Corpus analysis of 176 million classes in 485k

RFR: 8320858: Move jpackage tests to tier3

2023-11-28 Thread Alan Bateman
Update the jtreg test group configuration in the jdk test tree so that the jpackage tests run in tier3 rather than tier2. At this time, the jpackage tests run in jdk:tier2, more specifically jdk:tier2_part2 as part of the core_tools test group. The jpackage tests take a significant amount of

Re: RFR: 8319417: (dc) DatagramChannel.connect undocumented behavior [v2]

2023-11-28 Thread Alan Bateman
On Tue, 28 Nov 2023 13:35:33 GMT, Mark Sheppard wrote: > Also, the return for the case of an unbound DatagramSocket or DatagramChannel > is not specified. DatagramChannel::getLocalAddress is specified to return null when channel's socket is not bound. DatagramSocket::getLocalSocketAddress

Re: RFR: 8319417: (dc) DatagramChannel.connect undocumented behavior

2023-11-28 Thread Alan Bateman
On Mon, 13 Nov 2023 17:28:29 GMT, Michael McMahon wrote: > Hi, > > This is a small doc change for DatagramChannel.getLocalAddress() and the > equivalent methods on DatagramSocket which documents some existing (but not > currently documented) behavior. > > Thanks, > Michael Marked as

Re: RFR: 8320652: ThreadInfo.isInNative needs to be updated to say what executing native code means [v2]

2023-11-27 Thread Alan Bateman
On Tue, 28 Nov 2023 06:06:58 GMT, David Holmes wrote: > Note that there is no answer for the "syscall" case mentioned as it depends > on the code that makes the syscall: if from a native method then yes; if from > the VM then no. Right, if the thread invokes a Java native method then it may

Re: RFR: 8320652: ThreadInfo.isInNative needs to be updated to say what executing native code means [v2]

2023-11-27 Thread Alan Bateman
ot;native code" does > not include runtime or compiled code. I went through a few iterations to work > this in but all attempts just invite more questions and nit picking. To keep > it simple, this sentence is dropped so that the method description is focused > on the cases w

Re: RFR: 8320652: ThreadInfo.isInNative needs to be updated to say what executing native code means

2023-11-27 Thread Alan Bateman
On Mon, 27 Nov 2023 19:19:18 GMT, Mandy Chung wrote: > I can see why you left out the detail of a downcall handle. Maybe better to > link the text "method handle" to `Linker::downcallHandle` that is how such a > method handle is created. That's a good ideas, I've changed it to link to

Re: Problem getResourceAsStream for classes from parent layer

2023-11-27 Thread Alan Bateman
On 27/11/2023 17:18, Alex Orlov wrote: Hello all, I have a JPMS application with layer tree. In Module X on|Layer C|I need to create Spring context while Spring framework is located on|Layer B|: |boot layer |- Layer B with Spring framework. |- Layer C with Module X and Module Y| All child

Re: Automatic modules and jpackage

2023-11-27 Thread Alan Bateman
On 27/11/2023 11:44, Mark Raynsford wrote: I'm not entirely convinced that discussion on this list doesn't get lost in the endless sea of "RFR: " messages. :) It was originally sent to jigsaw-dev, then Alan Synder sent it here. As you know, automatic modules are to support migration without

RFR: 8320716: ResolvedModule::reads includes self when configuration contains two or more automatic modules

2023-11-27 Thread Alan Bateman
This is update to the specification of the j.l.module.ResolvedModule.reads method to clarify that the set of resolved modules returned does not include itself. There is a small implementation change to align with the specification and fix an anomaly that arises with configurations that contain

Re: RFR: 8316734: URLEncoder should specify that replacement bytes will be used in case of coding error [v3]

2023-11-27 Thread Alan Bateman
On Mon, 27 Nov 2023 14:24:32 GMT, Darragh Clarke wrote: >> Currently the descriptions of `URLEncoder.encode` and `URLDecoder.decode` >> don't specify their use of replacement bytes or replacement character when >> they cannot handle a character or sequence of bytes. This is longstanding >>

Re: RFR: 8320665: update jdk_core at test/jdk/TEST.groups

2023-11-27 Thread Alan Bateman
On Fri, 24 Nov 2023 11:28:23 GMT, Ivan Šipka wrote: > > I use the jdk_core test group. I know the split doesn't impact users of > > this test group but it's not clear why the change is being done. Would it > > be possible to explain why you are doing this? There is nothing in the JBS > >

Re: RFR: 8320618: NPE: Cannot invoke "java.lang.constant.ClassDesc.isArray()" because "this.sym" is null

2023-11-26 Thread Alan Bateman
On Thu, 23 Nov 2023 11:52:05 GMT, Adam Sotona wrote: > ClassFile API StackMapGenerator caused a NPE for a test case with invalid > sequence of instructions. > This fix simply avoids the NPE and adds StackMapsTest::testInvalidAALOADStack > > Please review. > > Thanks, > Adam Marked as

Re: RFR: 8319668: Fixup of jar filename typo in BadFactoryTest.sh [v2]

2023-11-24 Thread Alan Bateman
On Wed, 22 Nov 2023 18:28:30 GMT, Eirik Bjorsnos wrote: > Reviewer time is a scarce resource. It would be wasteful to spend review > cycles on getting a fix of this `.sh` test integrated now and then > immediately follow up with a delete in the rewrite PR. > > I think we should handle this

Re: RFR: 8320687: sun.jvmstat.monitor.MonitoredHost.getMonitoredHost() throws unexpected exceptions when invoked concurrently [v4]

2023-11-24 Thread Alan Bateman
On Fri, 24 Nov 2023 13:00:33 GMT, Jaikiran Pai wrote: >> Can I please get a review of this change which proposes to fix the issue >> noted in https://bugs.openjdk.org/browse/JDK-8320687? >> >> As noted in the issue, the >> `sun.jvmstat.monitor.MonitoredHost.getMonitoredHost()` uses a shared

RFR: 8320652: ThreadInfo.isInNative needs to be updated to say what executing native code means

2023-11-24 Thread Alan Bateman
This is a docs only change to j.l.management.ThreadInfo::isInNative. The method currently specifies that it tests if the thread is "executing native code via the Java Native Interface (JNI)". It would be clearer to say that it tests if the thread is executing a native method, and expand it

Re: RFR: 8320691: Timeout handler on Windows takes 2 hours to complete [v2]

2023-11-24 Thread Alan Bateman
On Fri, 24 Nov 2023 09:58:17 GMT, Daniel Jeliński wrote: >> The recent cdb versions do not support `.dump /f`: >> >> * >> * .dump /f is not supported on a user mode process. * >> *

Re: RFR: 8320691: Timeout handler on Windows takes 2 hours to complete [v2]

2023-11-24 Thread Alan Bateman
On Fri, 24 Nov 2023 12:04:01 GMT, Daniel Jeliński wrote: > Yes, with `/mA` the command exits as soon as the dump is completed. I > couldn't find a way to make `cdb` not enter interactive mode on unrecognized > parameter, so I left that part as is. Okay, maybe it can be figured out another

Re: RFR: 8320691: Timeout handler on Windows takes 2 hours to complete [v2]

2023-11-24 Thread Alan Bateman
On Fri, 24 Nov 2023 12:04:01 GMT, Daniel Jeliński wrote: > Yes, with `/mA` the command exits as soon as the dump is completed. I > couldn't find a way to make `cdb` not enter interactive mode on unrecognized > parameter, so I left that part as is. Okay, maybe it can be figured out another

Re: RFR: 8320691: Timeout handler on Windows takes 2 hours to complete [v2]

2023-11-24 Thread Alan Bateman
On Fri, 24 Nov 2023 09:58:17 GMT, Daniel Jeliński wrote: >> The recent cdb versions do not support `.dump /f`: >> >> * >> * .dump /f is not supported on a user mode process. * >> *

Re: RFR: 8320532: Remove Thread/ThreadGroup suspend/resume

2023-11-24 Thread Alan Bateman
On Fri, 24 Nov 2023 12:58:50 GMT, David Holmes wrote: > Looks good to me. I'm okay with removing the suspend/resume text from the > deprecation page - no point trying to explain a 25+ year history. Thanks, would you mind reviewing the CSR too? (The fixVersion is set to 23 so the skara bots

Re: RFR: 8320532: Remove Thread/ThreadGroup suspend/resume

2023-11-24 Thread Alan Bateman
On Fri, 24 Nov 2023 12:58:50 GMT, David Holmes wrote: > Looks good to me. I'm okay with removing the suspend/resume text from the > deprecation page - no point trying to explain a 25+ year history. Thanks, would you mind reviewing the CSR too? (The fixVersion is set to 23 so the skara bots

Re: RFR: 8320532: Remove Thread/ThreadGroup suspend/resume

2023-11-24 Thread Alan Bateman
On Fri, 24 Nov 2023 12:55:26 GMT, David Holmes wrote: > You didn't really need to rename the test even though there is now only one > degraded method left. True but it's wasn't good name for a test that only exercises one method. > test/jdk/java/nio/channels/SocketChannel/SendUrgentData.java

Re: RFR: 8320532: Remove Thread/ThreadGroup suspend/resume

2023-11-24 Thread Alan Bateman
On Fri, 24 Nov 2023 12:55:26 GMT, David Holmes wrote: > You didn't really need to rename the test even though there is now only one > degraded method left. True but it's wasn't good name for a test that only exercises one method. > test/jdk/java/nio/channels/SocketChannel/SendUrgentData.java

Re: RFR: 8320687: sun.jvmstat.monitor.MonitoredHost.getMonitoredHost() throws unexpected exceptions when invoked concurrently [v3]

2023-11-24 Thread Alan Bateman
On Fri, 24 Nov 2023 11:46:20 GMT, Jaikiran Pai wrote: >>> Right now, the sole usage of the `monitoredHostServiceLoader` instance is >>> within a `synchronized (monitoredHosts) {...}` block within a method. So it >>> wouldn't require this `assert`. >> >> Okay, I guess part of me wonders why

Re: RFR: 8320687: sun.jvmstat.monitor.MonitoredHost.getMonitoredHost() throws unexpected exceptions when invoked concurrently [v3]

2023-11-24 Thread Alan Bateman
On Fri, 24 Nov 2023 06:54:27 GMT, Jaikiran Pai wrote: > Right now, the sole usage of the `monitoredHostServiceLoader` instance is > within a `synchronized (monitoredHosts) {...}` block within a method. So it > wouldn't require this `assert`. Okay, I guess part of me wonders why this field is

Re: RFR: 8320691: Timeout handler on Windows takes 2 hours to complete [v2]

2023-11-24 Thread Alan Bateman
On Fri, 24 Nov 2023 11:33:57 GMT, Daniel Jeliński wrote: > It's ignoring the rest of the command line after `/f`, which means it ignores > the `;qd` (quit and detach) part and enters the interactive mode. Wonderful :-)Does switching to `/mA` change that? - PR Review Comment:

Re: RFR: 8320691: Timeout handler on Windows takes 2 hours to complete [v2]

2023-11-24 Thread Alan Bateman
On Fri, 24 Nov 2023 11:33:57 GMT, Daniel Jeliński wrote: > It's ignoring the rest of the command line after `/f`, which means it ignores > the `;qd` (quit and detach) part and enters the interactive mode. Wonderful :-)Does switching to `/mA` change that? - PR Review Comment:

Re: RFR: JDK-8315458 Implement JEP 463: Implicitly Declared Classes and Instance Main Method (Second Preview) [v34]

2023-11-24 Thread Alan Bateman
On Thu, 23 Nov 2023 15:55:42 GMT, Jim Laskey wrote: >> Address changes from JEP 445 to JEP 463. >> >> - Move from a SYNTHETIC unnamed class to a MANDATED implicit class. >> >> - Don't mark class on read. >> >> - Remove reflection and annotation processing related to unnamed classes. >> >> -

Re: RFR: JDK-8315458 Implement JEP 463: Implicitly Declared Classes and Instance Main Method (Second Preview) [v34]

2023-11-24 Thread Alan Bateman
On Thu, 23 Nov 2023 15:55:42 GMT, Jim Laskey wrote: >> Address changes from JEP 445 to JEP 463. >> >> - Move from a SYNTHETIC unnamed class to a MANDATED implicit class. >> >> - Don't mark class on read. >> >> - Remove reflection and annotation processing related to unnamed classes. >> >> -

Re: RFR: JDK-8315458 Implement JEP 463: Implicitly Declared Classes and Instance Main Method (Second Preview) [v34]

2023-11-24 Thread Alan Bateman
On Thu, 23 Nov 2023 15:55:42 GMT, Jim Laskey wrote: >> Address changes from JEP 445 to JEP 463. >> >> - Move from a SYNTHETIC unnamed class to a MANDATED implicit class. >> >> - Don't mark class on read. >> >> - Remove reflection and annotation processing related to unnamed classes. >> >> -

Re: RFR: JDK-8315458 Implement JEP 463: Implicitly Declared Classes and Instance Main Method (Second Preview) [v34]

2023-11-24 Thread Alan Bateman
On Thu, 23 Nov 2023 15:55:42 GMT, Jim Laskey wrote: >> Address changes from JEP 445 to JEP 463. >> >> - Move from a SYNTHETIC unnamed class to a MANDATED implicit class. >> >> - Don't mark class on read. >> >> - Remove reflection and annotation processing related to unnamed classes. >> >> -

RFR: 8320532: Remove Thread/ThreadGroup suspend/resume

2023-11-24 Thread Alan Bateman
The deadlock prone Thread/ThreadGroup suspend/resume were deprecated since JDK 1.2, deprecated for removal in Java 14, and re-specified/degraded to throw UnsupportedOperationException unconditionally in Java 19/20. Early in Java 23 seems a fine time to finally remove these methods. Corpus

RFR: 8320440: Implementation of Structured Concurrency (Second Preview)

2023-11-24 Thread Alan Bateman
This API is sitting out JDK 22, meaning no API/implementation changes in this PR. We expect this API to do a third preview in JDK 23 with some API changes. So for now, we just need to bump JEP number/title that shows up in the preview section of the javadoc. - Commit messages: -

RFR: 8320532: Remove Thread/ThreadGroup suspend/resume

2023-11-24 Thread Alan Bateman
The deadlock prone Thread/ThreadGroup suspend/resume were deprecated since JDK 1.2, deprecated for removal in Java 14, and re-specified/degraded to throw UnsupportedOperationException unconditionally in Java 19/20. Early in Java 23 seems a fine time to finally remove these methods. Corpus

Re: RFR: 8320691: Timeout handler on Windows takes 2 hours to complete [v2]

2023-11-24 Thread Alan Bateman
On Fri, 24 Nov 2023 09:40:16 GMT, Daniel Jeliński wrote: >>> Notice the absence of "params" part in that key. I wonder if that is >>> playing a role here and whether we should fix this key. >> >> Actually ignore that part. I had a look at the internal logs that you >> referenced. It appears

Re: RFR: 8320691: Timeout handler on Windows takes 2 hours to complete [v2]

2023-11-24 Thread Alan Bateman
On Fri, 24 Nov 2023 09:40:16 GMT, Daniel Jeliński wrote: >>> Notice the absence of "params" part in that key. I wonder if that is >>> playing a role here and whether we should fix this key. >> >> Actually ignore that part. I had a look at the internal logs that you >> referenced. It appears

Re: RFR: 8320691: Timeout handler on Windows takes 2 hours to complete

2023-11-24 Thread Alan Bateman
On Fri, 24 Nov 2023 07:58:18 GMT, Daniel Jeliński wrote: > The recent cdb versions do not support `.dump /f`: > > * > * .dump /f is not supported on a user mode process. * > *

Re: RFR: 8320691: Timeout handler on Windows takes 2 hours to complete

2023-11-24 Thread Alan Bateman
On Fri, 24 Nov 2023 07:58:18 GMT, Daniel Jeliński wrote: > The recent cdb versions do not support `.dump /f`: > > * > * .dump /f is not supported on a user mode process. * > *

Re: RFR: 8320665: update jdk_core at test/jdk/TEST.groups

2023-11-24 Thread Alan Bateman
On Thu, 23 Nov 2023 14:31:40 GMT, Ivan Šipka wrote: > @bwhuang-us @mahendrachhipa As a user of the jdk_core test group, would it be possible to explain why you are doing this? There is nothing in the JBS issue or PR to explain. - PR Comment:

Re: RFR: 8316734: URLEncoder should specify that replacement bytes will be used in case of coding error [v2]

2023-11-23 Thread Alan Bateman
On Thu, 23 Nov 2023 11:18:17 GMT, Darragh Clarke wrote: >> Currently the descriptions of `URLEncoder.encode` and `URLDecoder.decode` >> don't specify their use of replacement bytes or replacement character when >> they cannot handle a character or sequence of bytes. This is longstanding >>

Re: RFR: 8320687: sun.jvmstat.monitor.MonitoredHost.getMonitoredHost() throws unexpected exceptions when invoked concurrently

2023-11-23 Thread Alan Bateman
On Fri, 24 Nov 2023 06:06:16 GMT, Jaikiran Pai wrote: > Can I please get a review of this change which proposes to fix the issue > noted in https://bugs.openjdk.org/browse/JDK-8320687? > > As noted in the issue, the > `sun.jvmstat.monitor.MonitoredHost.getMonitoredHost()` uses a shared

Re: RFR: 8320608: Many jtreg printing tests are missing the @printer keyword

2023-11-22 Thread Alan Bateman
On Wed, 22 Nov 2023 19:26:40 GMT, Phil Race wrote: > Many printing tests do not have the @printer keyword. This adds them to those > that need it. > I also found one test that has nothing to do with printing in the print > folder and moved it out. test/jdk/TEST.ROOT line 15: > 13: # > 14: #

Re: RFR: 8320608: Many jtreg printing tests are missing the @printer keyword

2023-11-22 Thread Alan Bateman
On Wed, 22 Nov 2023 19:26:40 GMT, Phil Race wrote: > Many printing tests do not have the @printer keyword. This adds them to those > that need it. > I also found one test that has nothing to do with printing in the print > folder and moved it out. test/jdk/TEST.ROOT line 15: > 13: # > 14: #

Re: RFR: 8310994: Add JFR event for selection operations

2023-11-22 Thread Alan Bateman
On Fri, 17 Nov 2023 16:22:55 GMT, Tim Prinzing wrote: > Added mirror event with static methods: jdk.internal.event.SelectionEvent > that provides the duration of select calls and the count of how many keys are > available. > > Emit the event from SelectorImpl::lockAndDoSelect > > Test at

Re: RFR: 8310994: Add JFR event for selection operations

2023-11-22 Thread Alan Bateman
On Fri, 17 Nov 2023 16:22:55 GMT, Tim Prinzing wrote: > Added mirror event with static methods: jdk.internal.event.SelectionEvent > that provides the duration of select calls and the count of how many keys are > available. > > Emit the event from SelectorImpl::lockAndDoSelect > > Test at

Re: RFR: 8306055: Add a built-in Catalog to JDK XML module [v3]

2023-11-22 Thread Alan Bateman
On Mon, 20 Nov 2023 17:46:53 GMT, Joe Wang wrote: >> Implement the built-in Catalog. > > Joe Wang has updated the pull request incrementally with one additional > commit since the last revision: > > add a note; fix alignment I'm happy with the addition of the JDK built-in catalog, the

Re: RFR: 8306055: Add a built-in Catalog to JDK XML module [v3]

2023-11-22 Thread Alan Bateman
On Mon, 20 Nov 2023 17:46:53 GMT, Joe Wang wrote: >> Implement the built-in Catalog. > > Joe Wang has updated the pull request incrementally with one additional > commit since the last revision: > > add a note; fix alignment I'm happy with the addition of the JDK built-in catalog, the

Re: RFR: 8310994: Add JFR event for selection operations

2023-11-21 Thread Alan Bateman
On Fri, 17 Nov 2023 16:22:55 GMT, Tim Prinzing wrote: > Added mirror event with static methods: jdk.internal.event.SelectionEvent > that provides the duration of select calls and the count of how many keys are > available. > > Emit the event from SelectorImpl::lockAndDoSelect > > Test at

Re: RFR: JDK-8315458 Implement JEP 463: Implicitly Declared Classes and Instance Main Method (Second Preview) [v31]

2023-11-21 Thread Alan Bateman
On Tue, 21 Nov 2023 17:52:49 GMT, Jim Laskey wrote: >> Address changes from JEP 445 to JEP 463. >> >> - Move from a SYNTHETIC unnamed class to a MANDATED implicit class. >> >> - Don't mark class on read. >> >> - Remove reflection and annotation processing related to unnamed classes. >> >> -

Re: RFR: JDK-8315458 Implement JEP 463: Implicitly Declared Classes and Instance Main Method (Second Preview) [v31]

2023-11-21 Thread Alan Bateman
On Tue, 21 Nov 2023 17:52:49 GMT, Jim Laskey wrote: >> Address changes from JEP 445 to JEP 463. >> >> - Move from a SYNTHETIC unnamed class to a MANDATED implicit class. >> >> - Don't mark class on read. >> >> - Remove reflection and annotation processing related to unnamed classes. >> >> -

Re: RFR: 8319668: Fixup of jar filename typo in BadFactoryTest.sh

2023-11-21 Thread Alan Bateman
On Thu, 9 Nov 2023 16:49:41 GMT, Gaurav Chaudhari wrote: > The file test/jdk/javax/script/JDK_8196959/BadFactoryTest.sh contains a typo. > When running without security manager, the test references 'badfactoty.jar' > instead of 'badfactory.jar'. This change addresses this by correcting the jar

Re: RFR: JDK-8315458 Implement JEP 463: Implicitly Declared Classes and Instance Main Method (Second Preview) [v30]

2023-11-21 Thread Alan Bateman
On Mon, 20 Nov 2023 20:45:22 GMT, Jim Laskey wrote: >> Address changes from JEP 445 to JEP 463. >> >> - Move from a SYNTHETIC unnamed class to a MANDATED implicit class. >> >> - Don't mark class on read. >> >> - Remove reflection and annotation processing related to unnamed classes. >> >> -

Re: RFR: JDK-8315458 Implement JEP 463: Implicitly Declared Classes and Instance Main Method (Second Preview) [v30]

2023-11-21 Thread Alan Bateman
On Mon, 20 Nov 2023 20:45:22 GMT, Jim Laskey wrote: >> Address changes from JEP 445 to JEP 463. >> >> - Move from a SYNTHETIC unnamed class to a MANDATED implicit class. >> >> - Don't mark class on read. >> >> - Remove reflection and annotation processing related to unnamed classes. >> >> -

Re: RFR: 8282726: java/net/vthread/BlockingSocketOps.java timeout/hang intermittently on Windows

2023-11-21 Thread Alan Bateman
On Mon, 20 Nov 2023 16:08:10 GMT, Alan Bateman wrote: > This is a Windows specific issue where a virtual thread attempting to > establish a connection appears to hang, and the test eventually times out. It > initially looked like an issue on older releases of Windows but it

Integrated: 8282726: java/net/vthread/BlockingSocketOps.java timeout/hang intermittently on Windows

2023-11-21 Thread Alan Bateman
On Mon, 20 Nov 2023 16:08:10 GMT, Alan Bateman wrote: > This is a Windows specific issue where a virtual thread attempting to > establish a connection appears to hang, and the test eventually times out. It > initially looked like an issue on older releases of Windows but it

RFR: 8282726: java/net/vthread/BlockingSocketOps.java timeout/hang intermittently on Windows

2023-11-20 Thread Alan Bateman
This is a Windows specific issue where a virtual thread attempting to establish a connection appears to hang, and the test eventually times out. It initially looked like an issue on older releases of Windows but it turns out to be an issue that arises when a SOCKET handle is recycled quickly.

Re: RFR: JDK-8320372: test/jdk/sun/security/x509/DNSName/LeadingPeriod.java validity check failed [v2]

2023-11-20 Thread Alan Bateman
On Mon, 20 Nov 2023 17:21:00 GMT, Sean Mullan wrote: >> Set the validity date to the notBefore date of the EE certs so that >> validation won't fail when the certs expire - there is only one cert in the >> path so this should be sufficient. I also removed the trust anchor from the >> CertPath

Re: RFR: JDK-8320372: test/jdk/sun/security/x509/DNSName/LeadingPeriod.java validity check failed

2023-11-20 Thread Alan Bateman
On Mon, 20 Nov 2023 16:43:08 GMT, Sean Mullan wrote: > Set the validity date to the notBefore date of the EE certs so that > validation won't fail when the certs expire - there is only one cert in the > path so this should be sufficient. I also removed the trust anchor from the > CertPath as

Re: RFR: JDK-8315458 Implement JEP 463: Implicitly Declared Classes and Instance Main Method (Second Preview) [v26]

2023-11-20 Thread Alan Bateman
On Sun, 19 Nov 2023 20:14:10 GMT, Jim Laskey wrote: >> Address changes from JEP 445 to JEP 463. >> >> - Move from a SYNTHETIC unnamed class to a MANDATED implicit class. >> >> - Don't mark class on read. >> >> - Remove reflection and annotation processing related to unnamed classes. >> >> -

Re: RFR: JDK-8315458 Implement JEP 463: Implicitly Declared Classes and Instance Main Method (Second Preview) [v26]

2023-11-20 Thread Alan Bateman
On Sun, 19 Nov 2023 20:14:10 GMT, Jim Laskey wrote: >> Address changes from JEP 445 to JEP 463. >> >> - Move from a SYNTHETIC unnamed class to a MANDATED implicit class. >> >> - Don't mark class on read. >> >> - Remove reflection and annotation processing related to unnamed classes. >> >> -

Re: RFR: 8316734: URLEncoder should specify that replacement bytes will be used in case of coding error

2023-11-20 Thread Alan Bateman
On Mon, 20 Nov 2023 12:44:12 GMT, Daniel Fuchs wrote: > That's a good point. I see that there's another `decode(String, String)` > method above in this file that has the same old `@implNote` but not > `@throws`. Maybe the implNote should be removed there too and the `@throws` > added. Not

Re: RFR: 8320386: Remove java/nio/channels/vthread/BlockingChannelOps.java#direct-register from ProblemList

2023-11-20 Thread Alan Bateman
On Mon, 20 Nov 2023 10:09:36 GMT, Daniel Jeliński wrote: > The direct-register test variant was removed in > c099cf53f25496c99629dc578045aa5186e1109d. The failing test case was also > modified - the socket timeout is much shorter now, so even if the receive > operation gets stuck for the full

Re: RFR: JDK-8320168: handle setsocktopt return values [v4]

2023-11-20 Thread Alan Bateman
On Mon, 20 Nov 2023 08:23:51 GMT, Matthias Baesken wrote: >> There are a few places in the JDK C coding where the setsocktopt return >> value is not handled but better should be handled. > > Matthias Baesken has updated the pull request incrementally with one > additional commit since the last

Re: RFR: 8316734: URLEncoder should specify that replacement bytes will be used in case of coding error

2023-11-19 Thread Alan Bateman
On Fri, 17 Nov 2023 16:15:46 GMT, Darragh Clarke wrote: > Currently the descriptions of `URLEncoder.encode` and `URLDecoder.decode` > don't specify their use of replacement bytes or replacement character when > they cannot handle a character or sequence of bytes. This is longstanding >

<    4   5   6   7   8   9   10   11   12   13   >