Re: [PATCH] Add a cc1 option called dump-coverage-mapping

2014-08-07 Thread Bob Wilson
This is OK to commit. The option description is currently: Dump the coverage mapping records that will be emitted in a translation unit” How about changing that to the following? Dump the coverage mapping records, for testing” There are some other “dump” options with similar descriptions, and

Re: [PATCH] Add a cc1 option called dump-coverage-mapping

2014-08-07 Thread Bob Wilson
This is OK to commit. The option description is currently: Dump the coverage mapping records that will be emitted in a translation unit” How about changing that to the following? Dump the coverage mapping records, for testing” There are some other “dump” options with similar descriptions, and

Re: [PATCH] Code coverage mapping generation that enables coverage using the instrumentation based profiling

2014-08-04 Thread Bob Wilson
Wilson bob.wil...@apple.com: On Jul 18, 2014, at 5:36 PM, Alex L arpha...@gmail.com wrote: 2014-07-18 17:34 GMT-07:00 Bob Wilson bob.wil...@apple.com: On Jul 18, 2014, at 2:36 PM, Alex L arpha...@gmail.com wrote: 2014-07-18 14:23 GMT-07:00 Argyrios Kyrtzidis kyrtzi...@apple.com

Re: r206963 - [ARM64] Change inline assembly constraints to be more lax, to match the behaviour of Clang/AArch64 and GCC.

2014-08-01 Thread Bob Wilson
On Jul 24, 2014, at 7:28 AM, James Molloy james.mol...@arm.com wrote: Hi Jim, Thanks for your patience on this. I’ve gone back and taken another look at this, and I believe you’re totally right. GCC will invisibly promote whatever you give it to 64-bits and emit an X-reg

r214148 - Fix up handling of ARM options for controlling strict alignment.

2014-07-29 Thread Bob Wilson
Author: bwilson Date: Mon Jul 28 19:23:18 2014 New Revision: 214148 URL: http://llvm.org/viewvc/llvm-project?rev=214148view=rev Log: Fix up handling of ARM options for controlling strict alignment. The -mstrict-align option was originally added in r167619 as a target- independent option. It was

r214208 - Support LIBRARY_PATH on all Darwin targets.

2014-07-29 Thread Bob Wilson
Author: bwilson Date: Tue Jul 29 15:17:52 2014 New Revision: 214208 URL: http://llvm.org/viewvc/llvm-project?rev=214208view=rev Log: Support LIBRARY_PATH on all Darwin targets. r197490 changed the behavior of LIBRARY_PATH to try to match GCC's behavior for cross compilers and make clang work

Re: r214208 - Support LIBRARY_PATH on all Darwin targets.

2014-07-29 Thread Bob Wilson
I’m going to merge this to the 3.5 branch, since it is breaking MacPorts projects. On Jul 29, 2014, at 1:17 PM, Bob Wilson bob.wil...@apple.com wrote: Author: bwilson Date: Tue Jul 29 15:17:52 2014 New Revision: 214208 URL: http://llvm.org/viewvc/llvm-project?rev=214208view=rev Log

r213993 - Use -enable-global-merge option to match llvm r210639. rdar://problem/17803206

2014-07-25 Thread Bob Wilson
Author: bwilson Date: Fri Jul 25 19:37:28 2014 New Revision: 213993 URL: http://llvm.org/viewvc/llvm-project?rev=213993view=rev Log: Use -enable-global-merge option to match llvm r210639. rdar://problem/17803206 llvm revision 210639 renamed the -global-merge backend option to

Re: [PATCH] Fix -mno-global-merge option for clang

2014-07-25 Thread Bob Wilson
On Jul 25, 2014, at 4:47 PM, Steven Wu steve...@apple.com wrote: This patch fixes the problem in clang after llvm changes the option for global-merge in r210639. When using “-mno-global-merge”, clang will return following error currently: clang: Unknown command line argument

r213998 - Revert new test from 213993.

2014-07-25 Thread Bob Wilson
Author: bwilson Date: Fri Jul 25 19:51:28 2014 New Revision: 213998 URL: http://llvm.org/viewvc/llvm-project?rev=213998view=rev Log: Revert new test from 213993. It requires an arm backend and also writes output in the test directory. Modified: cfe/trunk/test/Driver/mno-global-merge.c

Re: [PATCH] Fix -mno-global-merge option for clang

2014-07-25 Thread Bob Wilson
On Jul 25, 2014, at 5:46 PM, Bob Wilson bob.wil...@apple.com wrote: On Jul 25, 2014, at 4:47 PM, Steven Wu steve...@apple.com wrote: This patch fixes the problem in clang after llvm changes the option for global-merge in r210639. When using “-mno-global-merge”, clang will return

Re: [PATCH] Code coverage mapping generation that enables coverage using the instrumentation based profiling

2014-07-18 Thread Bob Wilson
Argyrios Kyrtzidis kyrtzi...@apple.com: On Jul 18, 2014, at 9:56 AM, Sean Silva chisophu...@gmail.com wrote: On Thu, Jul 17, 2014 at 2:14 PM, Bob Wilson bob.wil...@apple.com wrote: On Jul 8, 2014, at 10:43 AM, Alex L arpha...@gmail.com wrote: Hi everyone, I've attached

Re: [PATCH] Code coverage mapping generation that enables coverage using the instrumentation based profiling

2014-07-18 Thread Bob Wilson
On Jul 18, 2014, at 5:36 PM, Alex L arpha...@gmail.com wrote: 2014-07-18 17:34 GMT-07:00 Bob Wilson bob.wil...@apple.com: On Jul 18, 2014, at 2:36 PM, Alex L arpha...@gmail.com wrote: 2014-07-18 14:23 GMT-07:00 Argyrios Kyrtzidis kyrtzi...@apple.com: CodeGenABITypes

Re: [PATCH] Code coverage mapping generation that enables coverage using the instrumentation based profiling

2014-07-17 Thread Bob Wilson
On Jul 8, 2014, at 10:43 AM, Alex L arpha...@gmail.com wrote: Hi everyone, I've attached a patch with the initial implementation of the code coverage mapping generation that enables code coverage analysis which uses the data obtained from the instrumentation based profiling. I've

Re: r212091 - Temporarily disable the indirect-goto.c test.

2014-07-01 Thread Bob Wilson
are confident we can get the optimization back, but we shouldn’t rush those changes since some of them deserve careful benchmarking to make sure we don’t regress anything else. On Jun 30, 2014, at 10:23 PM, David Blaikie dblai...@gmail.com wrote: On Mon, Jun 30, 2014 at 9:56 PM, Bob Wilson bob.wil

Re: r212091 - Temporarily disable the indirect-goto.c test.

2014-07-01 Thread Bob Wilson
In fact, Gerolf has already reenabled the test in r212092, with some changes. The commit message didn’t go out right away because it got moderated. We’re still looking into fixing the issues that required tweaking the test. On Jul 1, 2014, at 8:39 AM, Bob Wilson bob.wil...@apple.com wrote

r212091 - Temporarily disable the indirect-goto.c test.

2014-06-30 Thread Bob Wilson
Author: bwilson Date: Mon Jun 30 23:56:06 2014 New Revision: 212091 URL: http://llvm.org/viewvc/llvm-project?rev=212091view=rev Log: Temporarily disable the indirect-goto.c test. llvm r212077 causes this test to fail. We need to reorder some passes and possibly make other changes to reenable the

r211085 - Add documentation for PGO with instrumentation to clang's User's Manual.

2014-06-16 Thread Bob Wilson
Author: bwilson Date: Mon Jun 16 19:45:30 2014 New Revision: 211085 URL: http://llvm.org/viewvc/llvm-project?rev=211085view=rev Log: Add documentation for PGO with instrumentation to clang's User's Manual. rdar://problem/16771671 Modified: cfe/trunk/docs/UsersManual.rst Modified:

Re: r210584 - Fix crash with x86_64-pc-win32-macho target. rdar://problem/17235840

2014-06-11 Thread Bob Wilson
On Jun 10, 2014, at 6:07 PM, David Blaikie dblai...@gmail.com wrote: On Tue, Jun 10, 2014 at 6:04 PM, Bob Wilson bob.wil...@apple.com wrote: Thanks for fixing the output to the source tree. I should have caught that. I don’t especially know what to test for here. I wasn’t involved

Re: r210584 - Fix crash with x86_64-pc-win32-macho target. rdar://problem/17235840

2014-06-11 Thread Bob Wilson
On Jun 11, 2014, at 8:57 AM, Chandler Carruth chandl...@google.com wrote: On Wed, Jun 11, 2014 at 4:41 PM, Bob Wilson bob.wil...@apple.com wrote: On Jun 10, 2014, at 6:07 PM, David Blaikie dblai...@gmail.com wrote: On Tue, Jun 10, 2014 at 6:04 PM, Bob Wilson bob.wil...@apple.com wrote

Re: r210584 - Fix crash with x86_64-pc-win32-macho target. rdar://problem/17235840

2014-06-11 Thread Bob Wilson
On Jun 11, 2014, at 9:11 AM, Chandler Carruth chandl...@google.com wrote: On Wed, Jun 11, 2014 at 5:04 PM, Bob Wilson bob.wil...@apple.com wrote: There’s a big difference between “I don’t know how to write good tests for this” and “we need to rip it out because no one is maintaining

Re: r210584 - Fix crash with x86_64-pc-win32-macho target. rdar://problem/17235840

2014-06-11 Thread Bob Wilson
On Jun 11, 2014, at 9:57 AM, Chandler Carruth chandl...@google.com wrote: On Wed, Jun 11, 2014 at 5:41 PM, Bob Wilson bob.wil...@apple.com wrote: On Jun 11, 2014, at 9:11 AM, Chandler Carruth chandl...@google.com wrote: On Wed, Jun 11, 2014 at 5:04 PM, Bob Wilson bob.wil...@apple.com

r210693 - Run new test with -fsyntax-only.

2014-06-11 Thread Bob Wilson
Author: bwilson Date: Wed Jun 11 14:34:14 2014 New Revision: 210693 URL: http://llvm.org/viewvc/llvm-project?rev=210693view=rev Log: Run new test with -fsyntax-only. Modified: cfe/trunk/test/Misc/win32-macho.c Modified: cfe/trunk/test/Misc/win32-macho.c URL:

r210699 - Remove dev/null redirect and x86 backend requirement from new test.

2014-06-11 Thread Bob Wilson
Author: bwilson Date: Wed Jun 11 15:19:07 2014 New Revision: 210699 URL: http://llvm.org/viewvc/llvm-project?rev=210699view=rev Log: Remove dev/null redirect and x86 backend requirement from new test. Modified: cfe/trunk/test/Misc/win32-macho.c Modified: cfe/trunk/test/Misc/win32-macho.c

Re: r210693 - Run new test with -fsyntax-only.

2014-06-11 Thread Bob Wilson
/null now that it's -fsyntax-only. And the REQUIRES: x86-registered-target can be dropped too. (PS. I'm pretty sure there's an existing test for basic -target functionality this RUN line could be added to.) Alp. On Wed, Jun 11, 2014 at 12:34 PM, Bob Wilson bob.wil...@apple.com wrote

r210584 - Fix crash with x86_64-pc-win32-macho target. rdar://problem/17235840

2014-06-10 Thread Bob Wilson
Author: bwilson Date: Tue Jun 10 16:07:12 2014 New Revision: 210584 URL: http://llvm.org/viewvc/llvm-project?rev=210584view=rev Log: Fix crash with x86_64-pc-win32-macho target. rdar://problem/17235840 The changes in r204978 broke win32-macho targets. There were checks added for MSVC and Itanium

r210586 - Try to fix clang-hexagon-elf failure by requiring x86 support for this test.

2014-06-10 Thread Bob Wilson
Author: bwilson Date: Tue Jun 10 16:15:17 2014 New Revision: 210586 URL: http://llvm.org/viewvc/llvm-project?rev=210586view=rev Log: Try to fix clang-hexagon-elf failure by requiring x86 support for this test. Modified: cfe/trunk/test/Misc/win32-macho.c Modified:

Re: r210584 - Fix crash with x86_64-pc-win32-macho target. rdar://problem/17235840

2014-06-10 Thread Bob Wilson
the original change is only to header search? -eric On Tue, Jun 10, 2014 at 2:07 PM, Bob Wilson bob.wil...@apple.com wrote: Author: bwilson Date: Tue Jun 10 16:07:12 2014 New Revision: 210584 URL: http://llvm.org/viewvc/llvm-project?rev=210584view=rev Log: Fix crash with x86_64-pc

Re: r210584 - Fix crash with x86_64-pc-win32-macho target. rdar://problem/17235840

2014-06-10 Thread Bob Wilson
-triple x86_64-pc-win32-macho -emit-llvm-only On Tue, Jun 10, 2014 at 2:46 PM, Bob Wilson bob.wil...@apple.com wrote: The most important check is for header search, but I was hoping it might serve as an overall sanity check for other issues. I already found one issue with i386

Re: r210584 - Fix crash with x86_64-pc-win32-macho target. rdar://problem/17235840

2014-06-10 Thread Bob Wilson
coverage in other areas, add that to the relevant test directories. The driver should be tested in test/Driver. On Tue, Jun 10, 2014 at 4:58 PM, Bob Wilson bob.wil...@apple.com wrote: It would be sufficient, but since I think any future breakage of this is equally likely to come from the driver, I

Re: [PATCH] Always emit function declaration when generating profile instrumentation

2014-05-30 Thread Bob Wilson
On May 28, 2014, at 4:11 PM, Eric Christopher echri...@gmail.com wrote: On Wed, May 28, 2014 at 4:08 PM, Duncan P. N. Exon Smith dexonsm...@apple.com wrote: On 2014-May-28, at 15:55, Eric Christopher echri...@gmail.com wrote: ... I'll bite. Why do you want to know this function wasn't

Re: [PATCH] Always emit function declaration when generating profile instrumentation

2014-05-30 Thread Bob Wilson
On May 30, 2014, at 1:41 PM, Eric Christopher echri...@gmail.com wrote: On Fri, May 30, 2014 at 1:40 PM, Bob Wilson bob.wil...@apple.com wrote: On May 28, 2014, at 4:11 PM, Eric Christopher echri...@gmail.com wrote: On Wed, May 28, 2014 at 4:08 PM, Duncan P. N. Exon Smith dexonsm

Re: [PATCH] Always emit function declaration when generating profile instrumentation

2014-05-30 Thread Bob Wilson
On May 30, 2014, at 1:45 PM, Eric Christopher echri...@gmail.com wrote: On Fri, May 30, 2014 at 1:43 PM, Bob Wilson bob.wil...@apple.com wrote: On May 30, 2014, at 1:41 PM, Eric Christopher echri...@gmail.com wrote: On Fri, May 30, 2014 at 1:40 PM, Bob Wilson bob.wil...@apple.com wrote

r209836 - Make the -mno-global-merge option work for arm64/aarch64. rdar://17024719

2014-05-29 Thread Bob Wilson
Author: bwilson Date: Thu May 29 14:43:02 2014 New Revision: 209836 URL: http://llvm.org/viewvc/llvm-project?rev=209836view=rev Log: Make the -mno-global-merge option work for arm64/aarch64. rdar://17024719 Modified: cfe/trunk/lib/Driver/Tools.cpp cfe/trunk/test/Driver/mno-global-merge.c

r206728 - Fix a comment typo.

2014-04-20 Thread Bob Wilson
Author: bwilson Date: Sun Apr 20 20:23:36 2014 New Revision: 206728 URL: http://llvm.org/viewvc/llvm-project?rev=206728view=rev Log: Fix a comment typo. Modified: cfe/trunk/lib/CodeGen/TargetInfo.cpp Modified: cfe/trunk/lib/CodeGen/TargetInfo.cpp URL:

r206729 - ARM64: Do not expand variadic HFA/HVA arguments with the Darwin ABI.

2014-04-20 Thread Bob Wilson
Author: bwilson Date: Sun Apr 20 20:23:39 2014 New Revision: 206729 URL: http://llvm.org/viewvc/llvm-project?rev=206729view=rev Log: ARM64: Do not expand variadic HFA/HVA arguments with the Darwin ABI. Unlike the standard AAPCS64 ABI, variadic arguments are always passed on the stack with the

r206039 - [PGO] Change MapRegionCounters to be a RecursiveASTVisitor.

2014-04-11 Thread Bob Wilson
Author: bwilson Date: Fri Apr 11 12:16:13 2014 New Revision: 206039 URL: http://llvm.org/viewvc/llvm-project?rev=206039view=rev Log: [PGO] Change MapRegionCounters to be a RecursiveASTVisitor. This avoids the overhead of specifying all the traversal code when using ConstStmtVisitor and makes it

Re: r206039 - [PGO] Change MapRegionCounters to be a RecursiveASTVisitor.

2014-04-11 Thread Bob Wilson
On Apr 11, 2014, at 11:00 AM, Duncan P. N. Exon Smith dexonsm...@apple.com wrote: On Apr 11, 2014, at 10:16, Bob Wilson bob.wil...@apple.com wrote: +// Do not traverse the BlockDecl inside a BlockExpr since each BlockDecl +// is handled as a separate function. +bool

Re: [PATCH] CodeGen: Emit warnings when dropping profile data during PGO

2014-04-10 Thread Bob Wilson
On Apr 10, 2014, at 11:53 AM, Justin Bogner m...@justinbogner.com wrote: This adds a warning that triggers when profile data doesn't match for the source that's being compiled with -fprofile-instr-use=. This fires only once per translation unit, as warning on every mismatched function would

Re: [PATCH] CodeGen: Emit warnings when dropping profile data during PGO

2014-04-10 Thread Bob Wilson
On Apr 10, 2014, at 4:22 PM, Duncan P. N. Exon Smith dexonsm...@apple.com wrote: On Apr 10, 2014, at 15:53, Justin Bogner m...@justinbogner.com wrote: Bob Wilson bob.wil...@apple.com writes: I know we had already discussed that warning name, but I’m now wondering whether it should

r205920 - Add a -triple argument so that this new test passes on Darwin.

2014-04-09 Thread Bob Wilson
Author: bwilson Date: Wed Apr 9 13:51:19 2014 New Revision: 205920 URL: http://llvm.org/viewvc/llvm-project?rev=205920view=rev Log: Add a -triple argument so that this new test passes on Darwin. The section names used here are not valid for Mach-O. Modified:

r205272 - Disable this-return optimizations when targeting iOS 5 and earlier.

2014-03-31 Thread Bob Wilson
Author: bwilson Date: Mon Mar 31 20:38:16 2014 New Revision: 205272 URL: http://llvm.org/viewvc/llvm-project?rev=205272view=rev Log: Disable this-return optimizations when targeting iOS 5 and earlier. Clang implements the part of the ARM ABI saying that certain functions (e.g., constructors and

r204767 - [PGO] Add simplified branch weights for Objective-C for-collection loops.

2014-03-25 Thread Bob Wilson
Author: bwilson Date: Tue Mar 25 18:26:31 2014 New Revision: 204767 URL: http://llvm.org/viewvc/llvm-project?rev=204767view=rev Log: [PGO] Add simplified branch weights for Objective-C for-collection loops. Conceptually one of these loops is just a while-loop, but the actual code-gen is more

r204633 - Use CHECK-DAG in a test so that it isn't sensitive to metadata order.

2014-03-24 Thread Bob Wilson
Author: bwilson Date: Mon Mar 24 13:14:15 2014 New Revision: 204633 URL: http://llvm.org/viewvc/llvm-project?rev=204633view=rev Log: Use CHECK-DAG in a test so that it isn't sensitive to metadata order. This was failing on an internal branch where the order was different for some reason.

Re: r204633 - Use CHECK-DAG in a test so that it isn't sensitive to metadata order.

2014-03-24 Thread Bob Wilson
: Uh... some reason? Could you track it down? It really shouldn't be. -eric On Mon, Mar 24, 2014 at 11:14 AM, Bob Wilson bob.wil...@apple.com wrote: Author: bwilson Date: Mon Mar 24 13:14:15 2014 New Revision: 204633 URL: http://llvm.org/viewvc/llvm-project?rev=204633view=rev Log: Use

[libcxx] r203807 - Exclude .svn (and other dot directories) when installing headers.

2014-03-13 Thread Bob Wilson
Author: bwilson Date: Thu Mar 13 11:13:54 2014 New Revision: 203807 URL: http://llvm.org/viewvc/llvm-project?rev=203807view=rev Log: Exclude .svn (and other dot directories) when installing headers. My fix for PR15820 in r180132 inadvertently removed the exclusion for .*. This puts it back

Re: [libcxx] r180132 - PR15820: Use tar instead of rsync to install the headers.

2014-03-13 Thread Bob Wilson
Fixed in r203807. On Mar 12, 2014, at 12:48 PM, Bob Wilson bob.wil...@apple.com wrote: On Mar 11, 2014, at 5:40 PM, Nico Weber tha...@chromium.org wrote: This now also installs the .svn directory. Is that intentional? Definitely not intentional! I will fix that. On Tue, Apr 23

Re: [libcxx] r180132 - PR15820: Use tar instead of rsync to install the headers.

2014-03-12 Thread Bob Wilson
On Mar 11, 2014, at 5:40 PM, Nico Weber tha...@chromium.org wrote: This now also installs the .svn directory. Is that intentional? Definitely not intentional! I will fix that. On Tue, Apr 23, 2013 at 11:51 AM, Bob Wilson bob.wil...@apple.com wrote: Author: bwilson Date: Tue Apr 23 13

r203588 - Remove trailing whitespace introduced in r203028.

2014-03-11 Thread Bob Wilson
Author: bwilson Date: Tue Mar 11 12:17:16 2014 New Revision: 203588 URL: http://llvm.org/viewvc/llvm-project?rev=203588view=rev Log: Remove trailing whitespace introduced in r203028. Modified: cfe/trunk/lib/Sema/SemaObjCProperty.cpp cfe/trunk/test/SemaObjC/default-synthesize-3.m

Re: [patch] Rename CLANG_IS_PRODUCTION to CLANG_NO_PLUGIN_SUPPORT

2014-03-10 Thread Bob Wilson
On Mar 10, 2014, at 6:38 AM, Tobias Grosser tob...@grosser.es wrote: On 03/10/2014 02:35 PM, Rafael Espíndola wrote: OK. If this is not obviously beneficial, I don't have any strong opinion here. Same here. It is quiet a bit more complicated and requires patching llvm too, but it does

r203422 - Remove trailing whitespace.

2014-03-09 Thread Bob Wilson
Author: bwilson Date: Sun Mar 9 18:02:27 2014 New Revision: 203422 URL: http://llvm.org/viewvc/llvm-project?rev=203422view=rev Log: Remove trailing whitespace. Modified: cfe/trunk/lib/Sema/SemaChecking.cpp Modified: cfe/trunk/lib/Sema/SemaChecking.cpp URL:

r203131 - Run -fprofile-instr tests with %clang_cc1.

2014-03-06 Thread Bob Wilson
Author: bwilson Date: Thu Mar 6 11:18:34 2014 New Revision: 203131 URL: http://llvm.org/viewvc/llvm-project?rev=203131view=rev Log: Run -fprofile-instr tests with %clang_cc1. This should help avoid problems like the buildbot fallout from my change in r203085. I left the CodeGenCXX tests alone

r203157 - PGO: Add support for Objective-C blocks.

2014-03-06 Thread Bob Wilson
Author: bwilson Date: Thu Mar 6 14:24:27 2014 New Revision: 203157 URL: http://llvm.org/viewvc/llvm-project?rev=203157view=rev Log: PGO: Add support for Objective-C blocks. Modified: cfe/trunk/lib/CodeGen/CGBlocks.cpp cfe/trunk/lib/CodeGen/CodeGenPGO.cpp

r203165 - PGO: rename FileCheck variable to follow the existing convention.

2014-03-06 Thread Bob Wilson
Author: bwilson Date: Thu Mar 6 15:35:59 2014 New Revision: 203165 URL: http://llvm.org/viewvc/llvm-project?rev=203165view=rev Log: PGO: rename FileCheck variable to follow the existing convention. I added this STF variable without noticing that all the other counter names end with a C.

r203166 - PGO: rename profile data files from .pgodata to .profdata.

2014-03-06 Thread Bob Wilson
Author: bwilson Date: Thu Mar 6 15:36:04 2014 New Revision: 203166 URL: http://llvm.org/viewvc/llvm-project?rev=203166view=rev Log: PGO: rename profile data files from .pgodata to .profdata. These tests were added before we had settled on using a .profdata extension for the profile data files.

r203073 - Refactor PGO code in preparation for handling non-C/C++ code.

2014-03-05 Thread Bob Wilson
Author: bwilson Date: Wed Mar 5 22:55:35 2014 New Revision: 203073 URL: http://llvm.org/viewvc/llvm-project?rev=203073view=rev Log: Refactor PGO code in preparation for handling non-C/C++ code. Move the PGO.assignRegionCounters() call out of StartFunction, because that function is called from

r203072 - PGO: don't emit counter increment if no counters have been allocated.

2014-03-05 Thread Bob Wilson
Author: bwilson Date: Wed Mar 5 22:55:28 2014 New Revision: 203072 URL: http://llvm.org/viewvc/llvm-project?rev=203072view=rev Log: PGO: don't emit counter increment if no counters have been allocated. I hit this while debugging another issue where my sources were in an inconsistent state, so I

r203075 - PGO: Use the main file name to help distinguish functions with local linkage.

2014-03-05 Thread Bob Wilson
Author: bwilson Date: Wed Mar 5 22:55:41 2014 New Revision: 203075 URL: http://llvm.org/viewvc/llvm-project?rev=203075view=rev Log: PGO: Use the main file name to help distinguish functions with local linkage. In addition, for all functions, use the name from the llvm::Function to identify the

r203074 - PGO: Rename variables to avoid referring to the MangledName of a function.

2014-03-05 Thread Bob Wilson
Author: bwilson Date: Wed Mar 5 22:55:37 2014 New Revision: 203074 URL: http://llvm.org/viewvc/llvm-project?rev=203074view=rev Log: PGO: Rename variables to avoid referring to the MangledName of a function. For C++ functions, we will continue to use the mangled name to identify functions in the

r203085 - PGO: add instrumentation for Objective-C methods.

2014-03-05 Thread Bob Wilson
Author: bwilson Date: Thu Mar 6 00:10:02 2014 New Revision: 203085 URL: http://llvm.org/viewvc/llvm-project?rev=203085view=rev Log: PGO: add instrumentation for Objective-C methods. Modified: cfe/trunk/lib/CodeGen/CGObjC.cpp cfe/trunk/lib/CodeGen/CodeGenPGO.cpp

r203090 - Attempt to fix buildbots by dropping the -LABEL from some FileCheck patterns.

2014-03-05 Thread Bob Wilson
Author: bwilson Date: Thu Mar 6 00:49:37 2014 New Revision: 203090 URL: http://llvm.org/viewvc/llvm-project?rev=203090view=rev Log: Attempt to fix buildbots by dropping the -LABEL from some FileCheck patterns. Modified: cfe/trunk/test/CodeGenObjC/instr-profile.m Modified:

Re: r203085 - PGO: add instrumentation for Objective-C methods.

2014-03-05 Thread Bob Wilson
: Tweaked in r203092. Please confirm -target x86_64-darwin would be proper here. Could you consider to use %clang_cc1 instead of %clang ? 2014-03-06 15:10 GMT+09:00 Bob Wilson bob.wil...@apple.com: Author: bwilson Date: Thu Mar 6 00:10:02 2014 New Revision: 203085 URL: http://llvm.org

r202437 - Remove an assertion that no longer holds. rdar://problem/16135814

2014-02-27 Thread Bob Wilson
Author: bwilson Date: Thu Feb 27 15:59:17 2014 New Revision: 202437 URL: http://llvm.org/viewvc/llvm-project?rev=202437view=rev Log: Remove an assertion that no longer holds. rdar://problem/16135814 In r201528, I changed the PGO instrumentation counter for a do loop to not include the

r202468 - Add a testcase for r202437.

2014-02-27 Thread Bob Wilson
Author: bwilson Date: Thu Feb 27 23:57:14 2014 New Revision: 202468 URL: http://llvm.org/viewvc/llvm-project?rev=202468view=rev Log: Add a testcase for r202437. Modified: cfe/trunk/test/CodeGen/Inputs/instr-profile.pgodata cfe/trunk/test/CodeGen/instr-profile.c Modified:

Re: r202437 - Remove an assertion that no longer holds. rdar://problem/16135814

2014-02-27 Thread Bob Wilson
I added a test case in r202468. On Feb 27, 2014, at 4:45 PM, Richard Smith rich...@metafoo.co.uk wrote: Is this covered by the existing test suite? If not, could you add a test case? On Thu, Feb 27, 2014 at 1:59 PM, Bob Wilson bob.wil...@apple.com wrote: Author: bwilson Date: Thu Feb 27

Re: r199709 - Use private linkage for utf-16 objc strings too.

2014-02-26 Thread Bob Wilson
, Bob Wilson bob.wil...@apple.com wrote: Rafael, this change is causing problems. Apple’s linker needs to see labels in the __ustring sections, and with this change, the ustring labels are local to the assembler and never seen at link-time. Please revert this. We can investigate getting

[libcxx] r202280 - Don't install CMakeLists.txt along with the headers.

2014-02-26 Thread Bob Wilson
Author: bwilson Date: Wed Feb 26 11:14:09 2014 New Revision: 202280 URL: http://llvm.org/viewvc/llvm-project?rev=202280view=rev Log: Don't install CMakeLists.txt along with the headers. Modified: libcxx/trunk/Makefile Modified: libcxx/trunk/Makefile URL:

Re: r199709 - Use private linkage for utf-16 objc strings too.

2014-02-25 Thread Bob Wilson
Rafael, this change is causing problems. Apple’s linker needs to see labels in the __ustring sections, and with this change, the ustring labels are local to the assembler and never seen at link-time. Please revert this. We can investigate getting the linker to relax that constraint in the

r202002 - Do not put instrumentation counters before phis in ObjC for-in loops.

2014-02-23 Thread Bob Wilson
Author: bwilson Date: Sun Feb 23 19:13:09 2014 New Revision: 202002 URL: http://llvm.org/viewvc/llvm-project?rev=202002view=rev Log: Do not put instrumentation counters before phis in ObjC for-in loops. We still don't use the PGO to set branch weights for these loops, but at least this keeps the

r201962 - Remove support for the QA_OVERRIDE_GCC3_OPTIONS environment variable.

2014-02-22 Thread Bob Wilson
Author: bwilson Date: Sat Feb 22 18:11:56 2014 New Revision: 201962 URL: http://llvm.org/viewvc/llvm-project?rev=201962view=rev Log: Remove support for the QA_OVERRIDE_GCC3_OPTIONS environment variable. In r199283 I switched the name of this variable to CCC_OVERRIDE_OPTIONS, but I kept some code

r201830 - Fix an assertion failure when invoking dsymutil.

2014-02-20 Thread Bob Wilson
Author: bwilson Date: Thu Feb 20 18:20:07 2014 New Revision: 201830 URL: http://llvm.org/viewvc/llvm-project?rev=201830view=rev Log: Fix an assertion failure when invoking dsymutil. There is no bound architecture for the dsymutil action in the driver. Trying to check various properties of the

r201526 - Fix some minor whitespace issues.

2014-02-17 Thread Bob Wilson
Author: bwilson Date: Mon Feb 17 13:20:59 2014 New Revision: 201526 URL: http://llvm.org/viewvc/llvm-project?rev=201526view=rev Log: Fix some minor whitespace issues. Modified: cfe/trunk/lib/CodeGen/CGExprScalar.cpp cfe/trunk/lib/CodeGen/CodeGenFunction.cpp

r201527 - Some nitpicky comment fixes for i.e. and e.g. abbreviations.

2014-02-17 Thread Bob Wilson
Author: bwilson Date: Mon Feb 17 13:21:03 2014 New Revision: 201527 URL: http://llvm.org/viewvc/llvm-project?rev=201527view=rev Log: Some nitpicky comment fixes for i.e. and e.g. abbreviations. Modified: cfe/trunk/lib/CodeGen/CGStmt.cpp cfe/trunk/lib/CodeGen/CodeGenPGO.h Modified:

Re: r193934 - Default to use libc++ on OS X 10.9+ and iOS 7+.

2014-02-12 Thread Bob Wilson
get a build working for me yet. That means either a) something's broken b) something's not documented well c) I missed some important how-to announcement regarding building on 10.9 with Xcode 5 2014-02-04 Bob Wilson bob.wil...@apple.com: Would you like to contribute a patch

Re: r193934 - Default to use libc++ on OS X 10.9+ and iOS 7+.

2014-02-04 Thread Bob Wilson
...@chromium.org: On Tue, Nov 5, 2013 at 9:44 AM, Bob Wilson bob.wil...@apple.com wrote: On OS X the libc++ headers are meant to be installed along with clang. If you check out the libc++ sources in the LLVM projects directory, they should be installed in the right place. Thanks, that makes sense

r200618 - Fix an assertion failure when building for the iOS simulator. rdar://15959009

2014-02-01 Thread Bob Wilson
Author: bwilson Date: Sat Feb 1 15:06:21 2014 New Revision: 200618 URL: http://llvm.org/viewvc/llvm-project?rev=200618view=rev Log: Fix an assertion failure when building for the iOS simulator. rdar://15959009 When building for i386 or x86_64 with IPHONEOS_DEPLOYMENT_TARGET set in the

r200256 - Temporarily disable test that fails on Mac OS X 10.9.

2014-01-27 Thread Bob Wilson
Author: bwilson Date: Mon Jan 27 16:43:21 2014 New Revision: 200256 URL: http://llvm.org/viewvc/llvm-project?rev=200256view=rev Log: Temporarily disable test that fails on Mac OS X 10.9. PR18322. This test will be reenabled when the SDK gets fixed. In the meantime, it is pretty disruptive to

Re: r199682 - ObjectiveC driver. reinstate -fno-objc-legacy-dispatch behavior

2014-01-21 Thread Bob Wilson
On Jan 20, 2014, at 11:32 AM, Fariborz Jahanian fjahan...@apple.com wrote: Author: fjahanian Date: Mon Jan 20 13:32:33 2014 New Revision: 199682 URL: http://llvm.org/viewvc/llvm-project?rev=199682view=rev Log: ObjectiveC driver. reinstate -fno-objc-legacy-dispatch behavior when the

Re: r199682 - ObjectiveC driver. reinstate -fno-objc-legacy-dispatch behavior

2014-01-21 Thread Bob Wilson
On Jan 21, 2014, at 4:13 PM, jahanian fjahan...@apple.com wrote: On Jan 21, 2014, at 4:08 PM, Bob Wilson bob.wil...@apple.com wrote: On Jan 20, 2014, at 11:32 AM, Fariborz Jahanian fjahan...@apple.com wrote: Author: fjahanian Date: Mon Jan 20 13:32:33 2014 New Revision: 199682

r199696 - Stop linking with crt1.o etc. for the iOS simulator. rdar://problem/11800973

2014-01-20 Thread Bob Wilson
Author: bwilson Date: Mon Jan 20 18:17:10 2014 New Revision: 199696 URL: http://llvm.org/viewvc/llvm-project?rev=199696view=rev Log: Stop linking with crt1.o etc. for the iOS simulator. rdar://problem/11800973 Recent versions of the iOS simulator no longer require linking with the crt1.o,

r199431 - Remove an unnecessary special case to check for a few Darwin-specific options.

2014-01-16 Thread Bob Wilson
Author: bwilson Date: Thu Jan 16 15:50:37 2014 New Revision: 199431 URL: http://llvm.org/viewvc/llvm-project?rev=199431view=rev Log: Remove an unnecessary special case to check for a few Darwin-specific options. Using -mmacosx-version-min (etc.) on non-Darwin platforms should be a warning, not a

Re: r199451 - Split out -verify into two distinct option flags

2014-01-16 Thread Bob Wilson
OK, thanks for the heads-up. On Jan 16, 2014, at 6:20 PM, Alp Toker a...@nuanti.com wrote: Hi Bob, Eric asked me to give you a heads up after landing this change. The driver flag that verifies binary output is now renamed from -verify to --verify-debug-info. Feel free to tweak that

r199336 - Remove support for armv7f slice. rdar://problem/12478440

2014-01-15 Thread Bob Wilson
Author: bwilson Date: Wed Jan 15 15:43:40 2014 New Revision: 199336 URL: http://llvm.org/viewvc/llvm-project?rev=199336view=rev Log: Remove support for armv7f slice. rdar://problem/12478440 This was never used for anything so we should just get rid of it. Modified:

r199283 - Rename QA_OVERRIDE_GCC3_OPTIONS to CCC_OVERRIDE_OPTIONS. rdar://14578381

2014-01-14 Thread Bob Wilson
Author: bwilson Date: Tue Jan 14 19:41:52 2014 New Revision: 199283 URL: http://llvm.org/viewvc/llvm-project?rev=199283view=rev Log: Rename QA_OVERRIDE_GCC3_OPTIONS to CCC_OVERRIDE_OPTIONS. rdar://14578381 Continue to accept the old name for a while to make it an easier transition for people who

r199176 - Remove a temporary workaround that is no longer relevant.

2014-01-13 Thread Bob Wilson
Author: bwilson Date: Mon Jan 13 19:56:31 2014 New Revision: 199176 URL: http://llvm.org/viewvc/llvm-project?rev=199176view=rev Log: Remove a temporary workaround that is no longer relevant. Modified: cfe/trunk/lib/Driver/Tools.cpp Modified: cfe/trunk/lib/Driver/Tools.cpp URL:

Re: [libcxx] r198878 - Fix PR18404 - 'Bug in regex_token_iterator::operator++(int) implementation'. Enhance the tests for regex_token_iterator and regex_iterator.

2014-01-12 Thread Bob Wilson
Marshall, This change appears to have broken the libcxx buildbot. http://lab.llvm.org:8013/builders/libcxx_clang-x86_64-darwin11-RA/builds/587 It has been failing overall for a while for a different reason, so the problem wasn’t reported in the usual way. The test.libcxx.system failures are

Re: [PATCH] Initial instrumentation based PGO implementation

2013-12-29 Thread Bob Wilson
Eric, Thanks for your careful review of this. Your comments about the testing strategy have been especially helpful. This is an initial patch that is going to be revised extensively before the feature is finished. There are a lot of incremental changes that need to happen, and at least for

r198096 - Propagate -arch x86_64h setting to the linker. rdar://problem/15711488

2013-12-27 Thread Bob Wilson
Author: bwilson Date: Fri Dec 27 23:26:14 2013 New Revision: 198096 URL: http://llvm.org/viewvc/llvm-project?rev=198096view=rev Log: Propagate -arch x86_64h setting to the linker. rdar://problem/15711488 This is a follow-up to r194907, which added a new -arch setting to make it easier to specify

Re: [PATCH] Initial instrumentation based PGO implementation

2013-12-16 Thread Bob Wilson
LGTM. On Dec 13, 2013, at 1:43 PM, Justin Bogner m...@justinbogner.com wrote: New patch attached. The counters are now only accessed via RegionCounter objects, there's some better documentation of PGOProfileData, PGO creates the RegionCounts vector instead of it being allocated inside

r196527 - Fix assertion failure left over from changes to move away from darwin triples.

2013-12-05 Thread Bob Wilson
Author: bwilson Date: Thu Dec 5 13:38:42 2013 New Revision: 196527 URL: http://llvm.org/viewvc/llvm-project?rev=196527view=rev Log: Fix assertion failure left over from changes to move away from darwin triples. I happened to notice this while trying to write a test for an iOS simulator target.

Re: r176887 - Revert r166370 and r166540 now that Xcode 4.6 has been available for a while.

2013-11-11 Thread Bob Wilson
Nico, Have you upgraded your bots to Xcode 4.6 or Xcode 5.0 yet? On Mar 12, 2013, at 12:54 PM, Bob Wilson bob.wil...@apple.com wrote: No, sorry, I just figured that you would have updated by now. Would you like me to put it back again? On Mar 12, 2013, at 12:49 PM, Nico Weber tha

Re: r193934 - Default to use libc++ on OS X 10.9+ and iOS 7+.

2013-11-05 Thread Bob Wilson
to the performance issues, libc++ apparently can't be found by clang: http://llvm.org/bugs/show_bug.cgi?id=17821 On Sat, Nov 2, 2013 at 10:35 PM, Bob Wilson bob.wil...@apple.com wrote: I’m not familiar with those performance issues, so I’m CC’ing Howard in case he can provide any details on those issues

Re: r193934 - Default to use libc++ on OS X 10.9+ and iOS 7+.

2013-11-05 Thread Bob Wilson
/libc++.1.dylib but it should not be an issue. Le 5 nov. 2013 à 18:44, Bob Wilson bob.wil...@apple.com a écrit : On OS X the libc++ headers are meant to be installed along with clang. If you check out the libc++ sources in the LLVM projects directory, they should be installed

r193934 - Default to use libc++ on OS X 10.9+ and iOS 7+.

2013-11-02 Thread Bob Wilson
Author: bwilson Date: Sat Nov 2 18:19:53 2013 New Revision: 193934 URL: http://llvm.org/viewvc/llvm-project?rev=193934view=rev Log: Default to use libc++ on OS X 10.9+ and iOS 7+. Modified: cfe/trunk/lib/Driver/ToolChains.cpp cfe/trunk/test/PCH/cxx-typeid.cpp Modified:

r193935 - OS X 10.9+ and iOS 7+ support load/store of big atomic objects.

2013-11-02 Thread Bob Wilson
Author: bwilson Date: Sat Nov 2 18:27:49 2013 New Revision: 193935 URL: http://llvm.org/viewvc/llvm-project?rev=193935view=rev Log: OS X 10.9+ and iOS 7+ support load/store of big atomic objects. rdar://13973577 Patch by Fariborz Jahanian. Added: cfe/trunk/test/CodeGen/big-atomic-ops.c

Re: r193934 - Default to use libc++ on OS X 10.9+ and iOS 7+.

2013-11-02 Thread Bob Wilson
, PR14554, PR14555). On Sat, Nov 2, 2013 at 4:19 PM, Bob Wilson bob.wil...@apple.com wrote: Author: bwilson Date: Sat Nov 2 18:19:53 2013 New Revision: 193934 URL: http://llvm.org/viewvc/llvm-project?rev=193934view=rev Log: Default to use libc++ on OS X 10.9+ and iOS 7+. Modified

Re: Add -fauto-profile option to Clang driver

2013-10-28 Thread Bob Wilson
On Oct 28, 2013, at 7:23 AM, Diego Novillo dnovi...@google.com wrote: On Wed, Oct 23, 2013 at 9:37 AM, Diego Novillo dnovi...@google.com wrote: On Tue, Oct 22, 2013 at 6:25 PM, Chandler Carruth chandl...@google.com wrote: - I would personally prefer the intent to be explicit. The more I

Re: [PATCH] [ARM] Fix AArch32 and pre-v8 poly types to be unsigned

2013-10-11 Thread Bob Wilson
On Oct 11, 2013, at 9:07 AM, Bradley Smith bradley.sm...@arm.com wrote: Hi Bob, Since I believe it was you who objected somewhat to this last time around, do you have any opinion on this? Thanks. Regards, Bradley Smith So it hasn’t even been proposed for GCC yet? Why not? It seems

Re: r192143 - Suppress useless -Wshadow warning when using _mm* macros from emmintrin.h

2013-10-07 Thread Bob Wilson
On Oct 7, 2013, at 5:19 PM, Ted Kremenek kreme...@apple.com wrote: Interesting. Yes that seems like a reasonably generic heuristic. It does get potentially complicated if a macro uses another macro though… conceptually all from the same “expansion”. emmintrin.h is just one case. Many of

Re: VS build failure

2013-10-01 Thread Bob Wilson
If libcxx doesn't build with Visual Studio, then Chandler's patch to enable it should be changed to make it conditional on not using VS. Chandler, can that be done? On Oct 1, 2013, at 8:56 AM, jahanian fjahan...@apple.com wrote: We can disable build of libcxx on our VS buildbots. But, we

<    1   2   3   4   5   6   7   8   9   >