[Mesa-dev] [PATCH 4/4] i965/gen6: Enable ARB_viewport_array and AMD_vertex_shader_viewport_index

2015-05-06 Thread Chris Forbes
Signed-off-by: Chris Forbes chr...@ijw.co.nz --- src/mesa/drivers/dri/i965/intel_extensions.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/src/mesa/drivers/dri/i965/intel_extensions.c b/src/mesa/drivers/dri/i965/intel_extensions.c index c28c171..3088a1a

Re: [Mesa-dev] [PATCH 20/23] i965: Plumb compiler debug logging through a function pointer in brw_compiler

2015-04-30 Thread Chris Forbes
Looks like everything prior to this patch has landed; Ken's two patches for the printf-like debug plumbing, and the remaining patches from this series are: Reviewed-by: Chris Forbes chr...@ijw.co.nz On Sun, Apr 19, 2015 at 9:02 AM, Jason Ekstrand ja...@jlekstrand.net wrote: On Sat, Apr 18

Re: [Mesa-dev] [PATCH 15/20] glsl/es3.1: Allow textureGather and textureGatherOffset in GLSL ES 3.10

2015-04-30 Thread Chris Forbes
/* Only ARB_texture_gather but not GLSL 4.0 or ARB_gpu_shader5. * used for relaxation of const offset requirements. */ static bool -texture_gather_only(const _mesa_glsl_parse_state *state) +texture_gather_only_or_es31(const _mesa_glsl_parse_state *state) { return

Re: [Piglit] [PATCH 01/10] shader_runner: allow GL_MAX_VERTEX_OUTPUT_COMPONENTS in requirements

2015-04-30 Thread Chris Forbes
For the series: Reviewed-by: Chris Forbes chr...@ijw.co.nz On Fri, May 1, 2015 at 12:36 AM, Marek Olšák mar...@gmail.com wrote: From: Marek Olšák marek.ol...@amd.com --- tests/shaders/shader_runner.c | 9 + 1 file changed, 9 insertions(+) diff --git a/tests/shaders

Re: [Mesa-dev] [PATCH 15/20] glsl/es3.1: Allow textureGather and textureGatherOffset in GLSL ES 3.10

2015-04-30 Thread Chris Forbes
Nevermind, pre-coffee. On re-reading the GLSL ES 3.1 spec, the offset is required to be constant wherever texture offsets are used. On Fri, May 1, 2015 at 10:03 AM, Ilia Mirkin imir...@alum.mit.edu wrote: On Thu, Apr 30, 2015 at 5:56 PM, Chris Forbes chr...@ijw.co.nz wrote: /* Only

Re: [Mesa-dev] [PATCH 17/18] i965/ps/gen8: Refactor state uploading

2015-04-29 Thread Chris Forbes
It might be better to just prefetch no samplers in this case? -- a shader that has this many active samplers probably doesn't actually use them all in a single invocation. On Thu, Apr 30, 2015 at 5:23 AM, Kenneth Graunke kenn...@whitecape.org wrote: On Wednesday, April 29, 2015 07:47:26 PM

Re: [Mesa-dev] [PATCH v5] i965/aa: fixing anti-aliasing bug for thinnest width lines - GEN6

2015-04-28 Thread Chris Forbes
Have an: Acked-by: Chris Forbes chr...@ijw.co.nz On Fri, Apr 24, 2015 at 3:41 AM, Marius Predut marius.pre...@intel.com wrote: On SNB and IVB hw, for 1 pixel line thickness or less, the general anti-aliasing algorithm give up - garbage line is generated. Setting a Line Width of 0.0 specifies

Re: [Mesa-dev] [PATCH] i965: Disassemble sampler message names on Gen5+.

2015-04-24 Thread Chris Forbes
On the this is silly, I should really fix it list forever... Reviewed-by: Chris Forbes chr...@ijw.co.nz On Fri, Apr 24, 2015 at 6:02 PM, Kenneth Graunke kenn...@whitecape.org wrote: Previously, sampler messages were decoded as sampler (1, 0, 2, 2) mlen 6 rlen 8 { align1 1H }; I

Re: [Piglit] [PATCH] arb_texture_stencil8: add rendering test (v2)

2015-04-05 Thread Chris Forbes
Looks sensible to me. Reviewed-by: Chris Forbes chr...@ijw.co.nz On Sun, Apr 5, 2015 at 5:55 PM, Dave Airlie airl...@gmail.com wrote: This is based on ARB_stencil_texturing draw.c except it only tests stencil texturing. It's also forward ported to core profile. v2: fix test comment (Chris

Re: [Mesa-dev] [Mesa-stable] [PATCH 1/3] i965: Fix instanced geometry shaders on Gen8+.

2015-04-04 Thread Chris Forbes
For the series: Reviewed-by: Chris Forbes chr...@ijw.co.nz On Sat, Apr 4, 2015 at 11:46 PM, Kenneth Graunke kenn...@whitecape.org wrote: Jordan added this in commit 741782b5948bb3d01d699f062a37513c2e73b076 for Gen7 platforms. Embarassingly, this was missed for well over a year. Fixes

Re: [Piglit] [PATCH] arb_direct_state_access: Fix file name

2015-03-31 Thread Chris Forbes
Reviewed-by: Chris Forbes chr...@ijw.co.nz On Wed, Apr 1, 2015 at 1:57 PM, Anuj Phogat anuj.pho...@gmail.com wrote: Signed-off-by: Anuj Phogat anuj.pho...@gmail.com --- tests/spec/arb_direct_state_access/getcompressedtextureimage.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

Re: [Mesa-dev] [PATCH 14/23] i965: Use BRW_SURFACE_* in place of GL_TEXTURE_*

2015-03-31 Thread Chris Forbes
I'd adjust the write to surf[0] to use surf_type too. Other than that, this patch is: Reviewed-by: Chris Forbes chr...@ijw.co.nz On Tue, Mar 31, 2015 at 10:04 AM, Anuj Phogat anuj.pho...@gmail.com wrote: Makes no functional changes in the code. Signed-off-by: Anuj Phogat anuj.pho

Re: [Piglit] [PATCH 2/2] arb_arrays_of_arrays: fix output size

2015-03-29 Thread Chris Forbes
Reviewed-by: Chris Forbes chr...@ijw.co.nz On Mon, Mar 30, 2015 at 12:01 AM, Timothy Arceri t_arc...@yahoo.com.au wrote: Fix array sizes so that the arrays are not larger than the minimum implementation requirement of GL_MAX_VERTEX_ATTRIBS. Also assign something to the output so that its

Re: [Mesa-dev] [PATCH 3/3] glsl: Reassociate multiplication of mat*mat*vec.

2015-03-28 Thread Chris Forbes
For the series: Reviewed-by: Chris Forbes chr...@ijw.co.nz On Sat, Mar 28, 2015 at 5:22 PM, Matt Turner matts...@gmail.com wrote: The typical case of mat4*mat4*vec4 is 80 scalar multiplications, but mat4*(mat4*vec4) is only 32. On HSW (with vec4 vertex shaders): instructions in affected

Re: [Mesa-dev] [Mesa-stable] [PATCH v2] glsl: fix names in lower_constant_arrays_to_uniforms

2015-03-23 Thread Chris Forbes
Looks good to me. I should have considered this cross-stage case when I fixed the first part of this bug... Do you have a piglit test which hits this? Reviewed-by: Chris Forbes chr...@ijw.co.nz On Mon, Mar 23, 2015 at 8:12 PM, Tapani Pälli tapani.pa...@intel.com wrote: Patch changes lowering

Re: [Mesa-dev] [Mesa-stable] [PATCH v2] glsl: fix names in lower_constant_arrays_to_uniforms

2015-03-23 Thread Chris Forbes
-LIBDRM_INTEL_REQUIRED=2.4.60 +LIBDRM_INTEL_REQUIRED=2.4.59 Hang on, what's this hunk doing here? ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Piglit] [PATCH] glsl-1.20: test intrastage linking with const arrays

2015-03-23 Thread Chris Forbes
Looks like the right thing. Reviewed-by: Chris Forbes chr...@ijw.co.nz On Mon, Mar 23, 2015 at 8:50 PM, Tapani Pälli tapani.pa...@intel.com wrote: Signed-off-by: Tapani Pälli tapani.pa...@intel.com --- .../linker/intrastage-const-arrays.shader_test | 22 ++ 1 file

Re: [Piglit] [PATCH] util/ktx: Remove stray semicolon.

2015-03-22 Thread Chris Forbes
Reviewed-by: Chris Forbes chr...@ijw.co.nz On Sun, Mar 22, 2015 at 8:22 PM, Vinson Lee v...@freedesktop.org wrote: Fix stray semicolon defect reported by Coverity. Signed-off-by: Vinson Lee v...@freedesktop.org --- tests/util/piglit_ktx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion

Re: [Piglit] [PATCH] glsl-1.50/execution/geometry: Fix out-of-bounds read.

2015-03-22 Thread Chris Forbes
Reviewed-by: Chris Forbes chr...@ijw.co.nz On Sun, Mar 22, 2015 at 8:29 PM, Vinson Lee v...@freedesktop.org wrote: Fix out-of-bounds read defect reported by Coverity. Signed-off-by: Vinson Lee v...@freedesktop.org --- .../geometry/geometry-end-primitive-optional-with-points-out.c

Re: [Mesa-dev] [PATCH 10/11] i965/fs: Implement support for ir_barrier

2015-03-22 Thread Chris Forbes
jordan.l.jus...@intel.com Reviewed-by: Chris Forbes chr...@ijw.co.nz --- src/mesa/drivers/dri/i965/brw_defines.h| 5 + src/mesa/drivers/dri/i965/brw_fs.h | 3 +++ src/mesa/drivers/dri/i965/brw_fs_generator.cpp | 11 +++ src/mesa/drivers/dri/i965

Re: [Mesa-dev] [PATCH 3/4] i965: Rename do_stage_prog to brw_stage_compile

2015-03-20 Thread Chris Forbes
I think that having both the existing `struct brw_vs_compile` and a function with the same name is going to cause confusion. (same with the other non-fs stages) On Sat, Mar 21, 2015 at 2:04 PM, Ian Romanick i...@freedesktop.org wrote: On 03/20/2015 06:02 PM, Ian Romanick wrote: On 03/20/2015

Re: [Mesa-dev] [Mesa-stable] [PATCH] glsl: Generate link error for non-matching gl_FragCoord redeclarations

2015-03-19 Thread Chris Forbes
LGTM. Reviewed-by: Chris Forbes chr...@ijw.co.nz On Sat, Mar 7, 2015 at 1:15 PM, Anuj Phogat anuj.pho...@gmail.com wrote: in different fragment shaders. This also applies to a case when gl_FragCoord is redeclared with no layout qualifiers in one fragment shader and not declared but used

Re: [Mesa-dev] [PATCH] i965/fs: Print spills:fills and number of promoted constants.

2015-03-17 Thread Chris Forbes
With the fix Jason mentioned: Reviewed-by: Chris Forbes chr...@ijw.co.nz On Wed, Mar 18, 2015 at 10:19 AM, Matt Turner matts...@gmail.com wrote: On Tue, Mar 17, 2015 at 2:15 PM, Jason Ekstrand ja...@jlekstrand.net wrote: On Tue, Mar 17, 2015 at 2:09 PM, Matt Turner matts...@gmail.com wrote

Re: [Piglit] [PATCH 1/4] glsl-1.10: Add test for bug in i965 gl_FrontFacing optimization

2015-03-17 Thread Chris Forbes
For the series: Reviewed-by: Chris Forbes chr...@ijw.co.nz On Wed, Mar 18, 2015 at 10:51 AM, Ian Romanick i...@freedesktop.org wrote: From: Ian Romanick ian.d.roman...@intel.com These patterns gl_FrontFacing ? -1.0 : 1.0 gl_FrontFacing ? 1.0 : -1.0 gl_FrontFacing ? 0.0

Mesa (master): i965/disasm: Mark format() as being printf-style.

2015-03-13 Thread Chris Forbes
Module: Mesa Branch: master Commit: 7c3095d6b71c410fd625ead797c78a0f5376904d URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=7c3095d6b71c410fd625ead797c78a0f5376904d Author: Chris Forbes chr...@ijw.co.nz Date: Sat Mar 14 07:10:10 2015 +1300 i965/disasm: Mark format() as being printf

Mesa (master): i965/disasm: Fix format strings

2015-03-13 Thread Chris Forbes
Module: Mesa Branch: master Commit: 21ff9bfe1cea8c0a51e9f607cc580df62baa3445 URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=21ff9bfe1cea8c0a51e9f607cc580df62baa3445 Author: Chris Forbes chr...@ijw.co.nz Date: Sat Mar 14 07:10:11 2015 +1300 i965/disasm: Fix format strings Most

[Mesa-dev] [PATCH 2/2] i965/disasm: Fix format strings

2015-03-13 Thread Chris Forbes
Most of the brw_inst_* api returns 64bit values. This fixes disassembly of sampler messages, etc. Signed-off-by: Chris Forbes chr...@ijw.co.nz --- src/mesa/drivers/dri/i965/brw_disasm.c | 48 +- 1 file changed, 24 insertions(+), 24 deletions(-) diff --git a/src

[Mesa-dev] [PATCH 1/2] i965/disasm: Mark format() as being printf-style.

2015-03-13 Thread Chris Forbes
This allows us to get warnings from GCC when we mess up the format strings. Signed-off-by: Chris Forbes chr...@ijw.co.nz --- src/mesa/drivers/dri/i965/brw_disasm.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_disasm.c b/src/mesa/drivers/dri/i965

Mesa (master): i965/gen4-5: Cope with immutable-format texture revalidation

2015-03-13 Thread Chris Forbes
Module: Mesa Branch: master Commit: f68a973dfb8926ac872b0b0e3b4b5c2163389d06 URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=f68a973dfb8926ac872b0b0e3b4b5c2163389d06 Author: Chris Forbes chr...@ijw.co.nz Date: Mon Dec 8 20:37:00 2014 +1300 i965/gen4-5: Cope with immutable-format

Re: [Mesa-dev] [PATCH] i965/gen6 gs: Convert brw_imm_ud/brw_imm_d to src_reg

2015-03-03 Thread Chris Forbes
Reviewed-by: Chris Forbes chr...@ijw.co.nz On Wed, Mar 4, 2015 at 2:25 PM, Jordan Justen jordan.l.jus...@intel.com wrote: Same idea as this patch, only for gen6_gs_visitor: commit 49a938a265f5959c9b558995cc658f80acb6eb18 Author: Jordan Justen jordan.l.jus...@intel.com Date: Fri Feb 20 12

Re: [Mesa-dev] [PATCH] i965/gs: Check newly-generated GS-out VUE map against correct stage

2015-02-28 Thread Chris Forbes
Thanks Matt -- yes, for 10.5 as well. I'll also note that this fixes: Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=5 On Sat, Feb 28, 2015 at 8:48 PM, Matt Turner matts...@gmail.com wrote: On Fri, Feb 27, 2015 at 11:03 PM, Chris Forbes chr...@ijw.co.nz wrote: Previously, we

Mesa (master): i965/gs: Check newly-generated GS-out VUE map against correct stage

2015-02-28 Thread Chris Forbes
Module: Mesa Branch: master Commit: b51ff50a767cc78d678ed3d2c25995f5c4194fea URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=b51ff50a767cc78d678ed3d2c25995f5c4194fea Author: Chris Forbes chr...@ijw.co.nz Date: Sat Feb 28 19:57:20 2015 +1300 i965/gs: Check newly-generated GS-out VUE

[Mesa-dev] [PATCH] i965/gs: Check newly-generated GS-out VUE map against correct stage

2015-02-27 Thread Chris Forbes
if it happened to match the VS-out layout. Signed-off-by: Chris Forbes chr...@ijw.co.nz Cc: 10.4 mesa-sta...@lists.freedesktop.org --- src/mesa/drivers/dri/i965/brw_gs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_gs.c b/src/mesa/drivers/dri/i965

Re: [Mesa-dev] [PATCH] i965: Fix I/L/LA SNORM formats.

2015-02-26 Thread Chris Forbes
Reviewed-by: Chris Forbes chr...@ijw.co.nz On Fri, Feb 27, 2015 at 5:52 PM, Jason Ekstrand ja...@jlekstrand.net wrote: I'll admit that I don't know that portion of the code all that well, but it looks sensible to me. Reviewed-by: Jason Ekstrand jason.ekstr...@intel.com On Thu, Feb 26, 2015

Re: [Mesa-dev] [PATCH] i965: just avoid warnings with fp64

2015-02-19 Thread Chris Forbes
Looks reasonable, if it's going to be a while before an i965 backend is ready.. Reviewed-by: Chris Forbes chr...@ijw.co.nz On Fri, Feb 20, 2015 at 12:38 PM, Dave Airlie airl...@gmail.com wrote: This just fills in some blanks to avoid warnings in the i965 driver. Signed-off-by: Dave Airlie

Re: [Mesa-dev] [PATCH 1/3] i965: Override swizzles for integer luminance formats.

2015-02-07 Thread Chris Forbes
Reviewed-by: Chris Forbes chr...@ijw.co.nz On Sat, Feb 7, 2015 at 1:32 AM, Kenneth Graunke kenn...@whitecape.org wrote: The hardware's integer luminance formats are completely unusable; currently we fall back to RGBA. This means we need to override the texture swizzle to obtain the XXX1

Mesa (master): mesa: Make renderbuffer FBO attachments not layered

2015-02-07 Thread Chris Forbes
with GL_FRAMEBUFFER_INCOMPLETE_LAYER_TARGETS, even if no layered attachments were present. Reviewed-by: Chris Forbes chr...@ijw.co.nz Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=89026 --- src/mesa/main/fbobject.c |1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/main/fbobject.c b/src/mesa

[Mesa-dev] [PATCH] mesa: Update layered state when attaching a renderbuffer

2015-02-07 Thread Chris Forbes
Renderbuffers are never layered. Previously we'd just leave whatever value was present from the previous attachment. Signed-off-by: Chris Forbes chr...@ijw.co.nz Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=89026 --- src/mesa/main/fbobject.c | 1 + 1 file changed, 1 insertion(+) diff

Re: [Mesa-dev] [PATCH] mesa: Update layered state when attaching a renderbuffer

2015-02-07 Thread Chris Forbes
Apologies -- I'd not noticed that there was an equivalent patch already attached to the bug report. In that case, James Legg's patch is: Reviewed-by: Chris Forbes chr...@ijw.co.nz (and I'll push it shortly) On Sun, Feb 8, 2015 at 1:47 PM, Chris Forbes chr...@ijw.co.nz wrote: Renderbuffers

Re: [Mesa-dev] [PATCH 3/3] i965: Fix integer border color on Haswell.

2015-02-06 Thread Chris Forbes
Looks good to me. Reviewed-by: Chris Forbes chr...@ijw.co.nz On Sat, Feb 7, 2015 at 1:32 AM, Kenneth Graunke kenn...@whitecape.org wrote: +82 Piglits - 100% of border color tests now pass on Haswell. Signed-off-by: Kenneth Graunke kenn...@whitecape.org Cc: Chris Forbes chr...@ijw.co.nz Cc

Re: [Mesa-dev] [PATCH v2 04/28] mesa: add double uniform support. (v5)

2015-02-05 Thread Chris Forbes
I think 'component_size' would be better over the various dmul, size_mul, etc. On Fri, Feb 6, 2015 at 5:56 PM, Ilia Mirkin imir...@alum.mit.edu wrote: From: Dave Airlie airl...@redhat.com This adds support for the new uniform interfaces from ARB_gpu_shader_fp64. v2: support

Re: [Piglit] [PATCH] arb_shader_precision: set tolerance for div/assign-div

2015-02-03 Thread Chris Forbes
Matt, the default if not specified is zero. 2.5 ulps agrees with the spec, so: Reviewed-by: Chris Forbes chr...@ijw.co.nz On Wed, Feb 4, 2015 at 10:58 AM, Matt Turner matts...@gmail.com wrote: On Mon, Feb 2, 2015 at 6:04 AM, Ilia Mirkin imir...@alum.mit.edu wrote: This makes the relevant

Mesa (master): st/mesa: mark constant array of swizzles as static const

2015-02-03 Thread Chris Forbes
of swizzles as static const This saves about 0.5k in the text section for a gallium driver on amd64. Reviewed-by: Chris Forbes chr...@ijw.co.nz --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/state_tracker

Re: [Piglit] [PATCH v2] ext_polygon_offset_clamp: add simple draw test

2015-02-01 Thread Chris Forbes
dlist.c seems to be missing from this patch. On Mon, Feb 2, 2015 at 4:12 AM, Ilia Mirkin imir...@alum.mit.edu wrote: Signed-off-by: Ilia Mirkin imir...@alum.mit.edu --- As requested, added a case for positive clamp as well as negative. Also dropped version requirement to GL 2.1 and added a

Re: [Piglit] [PATCH v3] ext_polygon_offset_clamp: add simple draw test

2015-02-01 Thread Chris Forbes
You don't need the VAO, this is 2.1. With that and Glenn's concern addressed, Reviewed-by: Chris Forbes chr...@ijw.co.nz On Mon, Feb 2, 2015 at 11:19 AM, Ilia Mirkin imir...@alum.mit.edu wrote: Signed-off-by: Ilia Mirkin imir...@alum.mit.edu --- v2 - v3: *actually* include dlist.c

Re: [Mesa-dev] [PATCH 1/2] glsl: Add define for ARB_shader_precision

2015-02-01 Thread Chris Forbes
Glenn, Fixed in the version of this patch which landed (d36fa601913 on master). - Chris On Mon, Feb 2, 2015 at 2:08 PM, Glenn Kennard glenn.kenn...@gmail.com wrote: On Wed, 31 Dec 2014 21:43:51 +0100, Micah Fedke micah.fe...@collabora.co.uk wrote: --- src/glsl/glcpp/glcpp-parse.y| 3

Re: [Mesa-dev] [PATCH] GL: Update glext.h to fix ARB_dsa function prototypes.

2015-01-30 Thread Chris Forbes
With the new commit message, Reviewed-by: Chris Forbes chr...@ijw.co.nz On Sat, Jan 31, 2015 at 2:08 PM, Laura Ekstrand la...@jlekstrand.net wrote: It's updated to: GL: Update glext.h to Khronos Revision 29537. Khronos Revision 29537 fixes ARB_direct_state_access function prototypes

Re: [Piglit] [PATCH] Add a new shader attachment/link ordering test.

2015-01-26 Thread Chris Forbes
Reviewed-by: Chris Forbes chr...@ijw.co.nz On Tue, Jan 27, 2015 at 5:24 AM, Brian Paul bri...@vmware.com wrote: AFAICT, the GL and GLSL specs don't say anything about the significance of the order in which shaders are attached to a program object. For example, if there's two vertex shader

Re: [Mesa-dev] [PATCH] i965/emit: Do the sampler index adjustment directly in header.0.3

2015-01-22 Thread Chris Forbes
, the calculation is such that we can just do it in place and we don't need the scratch space at all. Cc: Chris Forbes chr...@ijw.co.nz --- src/mesa/drivers/dri/i965/brw_eu.h | 3 +-- src/mesa/drivers/dri/i965/brw_eu_emit.c | 5 ++--- src/mesa/drivers/dri/i965/brw_fs_generator.cpp

Re: [Mesa-dev] [PATCH] i965/emit: Do the sampler index adjustment directly in header.0.3

2015-01-22 Thread Chris Forbes
Ugh, I'd thinko'd this on first reading and assumed that the adjustment was header.3 += temp -- but it's not; it's header.3 = r0.3 + temp so this is fine. Reviewed-by: Chris Forbes chr...@ijw.co.nz On Fri, Jan 23, 2015 at 10:50 AM, Jason Ekstrand ja...@jlekstrand.net wrote: Prior to this commit

Re: [Mesa-dev] [PATCH] glsl: do not allow interface block to have name already taken

2015-01-20 Thread Chris Forbes
Ian, That's what the -2 variation added by that commit does. - Chris On Wed, Jan 21, 2015 at 7:29 AM, Ian Romanick i...@freedesktop.org wrote: On 01/19/2015 10:55 PM, Tapani Pälli wrote: Fixes currently failing Piglit case interface-blocks-name-reused-globally.vert Signed-off-by: Tapani

Mesa (master): mesa: Add ARB_shader_precision infrastructure

2015-01-18 Thread Chris Forbes
infrastructure Reviewed-by: Ian Romanick ian.d.roman...@intel.com Reviewed-by: Chris Forbes chr...@ijw.co.nz --- src/glsl/glcpp/glcpp-parse.y|3 +++ src/glsl/glsl_parser_extras.cpp |1 + src/glsl/glsl_parser_extras.h |2 ++ src/mapi/glapi/gen/gl_API.xml |6 +- src/mesa

Re: [Mesa-dev] Improving precision of mod(x,y)

2015-01-16 Thread Chris Forbes
Using the GLSL spec's definition (or something with equivalent precision) is also required for ARB_shader_precision, which we'll have really soon, so +1 from me too. On Fri, Jan 16, 2015 at 8:01 PM, Iago Toral ito...@igalia.com wrote: Thanks Roland and everyone else for the input. Based on the

Re: [Mesa-dev] [PATCH 1/4] i965: Replace fs_reg(fs_visitor, type) with fs_visitor::vgrf(type).

2015-01-16 Thread Chris Forbes
The vec4 side is similarly tangled, except there are 3 constructors like this spread across the src_reg and dst_reg classes. Reviewed-by: Chris Forbes chr...@ijw.co.nz On Sat, Jan 17, 2015 at 11:19 AM, Kenneth Graunke kenn...@whitecape.org wrote: I dislike how fs_reg has a constructor

Re: [Mesa-dev] [PATCH 105/133] i965/fs_nir: Implement the ARB_gpu_shader5 interpolation intrinsics

2015-01-14 Thread Chris Forbes
Looks OK to me. Reviewed-by: Chris Forbes chr...@ijw.co.nz On Thu, Jan 15, 2015 at 5:50 PM, Jason Ekstrand ja...@jlekstrand.net wrote: v2: Add a comment as to why we are using variables instead of lowering to an index like the rest of the input intrinsics. Cc: Chris Forbes chr

Re: [Piglit] [PATCH] glsl-1.50: fix some linker tests

2015-01-11 Thread Chris Forbes
Oops. Reviewed-by: Chris Forbes chr...@ijw.co.nz On Wed, Dec 24, 2014 at 7:12 PM, Timothy Arceri t_arc...@yahoo.com.au wrote: From: Timothy Arceri t.arc...@bom.gov.au dont assign values to shader inputs --- I didn't realise my mistake as Mesa currently allows inputs to change. I'm

Re: [Piglit] [PATCH] gpu_shader5: Add a test that uses an absurd number of texture arguments

2015-01-10 Thread Chris Forbes
() +{ + float f = textureProjGradOffset(s[i], coord, coord.xy, coord.zw, + ivec2(43, 7)); The offset components should really be restricted to -8/+7. + gl_FragColor = vec4(0, f, 0, 1); +} -- 2.2.0 Otherwise, Reviewed-by: Chris Forbes chr...@ijw.co.nz

Re: [Piglit] [PATCH] arb_shader_atomic_counters: Check piglit_probe_pixel_rgb results.

2015-01-08 Thread Chris Forbes
Oops... sorry about that. Reviewed-by: Chris Forbes chr...@ijw.co.nz On Fri, Jan 9, 2015 at 11:53 AM, Vinson Lee v...@freedesktop.org wrote: Fix dead assignment bugs reported by Clang Static Analyzer. Signed-off-by: Vinson Lee v...@freedesktop.org --- tests/spec/arb_shader_atomic_counters

Re: [Piglit] [PATCH piglit] shaders: Test using an int vertex attrib value that looks like NaN

2015-01-07 Thread Chris Forbes
Subtle.. Reviewed-by: Chris Forbes chr...@ijw.co.nz On Jan 8, 2015 1:07 AM, Neil Roberts n...@linux.intel.com wrote: Adds a test which tries setting a uint attrib value to 0x7f817f81. If this value were interpreted as a float then it would look like a signalling NaN. If this is passed through

Re: [Mesa-dev] [PATCH 097/133] nir/validate: Ensure that outputs are write-only and inputs are read-only

2015-01-06 Thread Chris Forbes
Worth pointing out that when tessellation gets ported to NIR, output reads are a real thing, and can't be lowered away like we do for other stages (they allow cross-invocation communication, so have to actually read back from the URB on i965) On Wed, Jan 7, 2015 at 10:43 AM, Jason Ekstrand

Re: [Mesa-dev] [PATCH 120/133] i965/fs_nir: Add support for indirect texture arrays

2015-01-06 Thread Chris Forbes
Looks sensible to me. Reviewed-by: Chris Forbes chr...@ijw.co.nz On Tue, Dec 16, 2014 at 7:13 PM, Jason Ekstrand ja...@jlekstrand.net wrote: --- src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 24 ++-- 1 file changed, 22 insertions(+), 2 deletions(-) diff --git a/src/mesa

Re: [Mesa-dev] [PATCH 119/133] nir: Rework the way samplers are lowered

2015-01-06 Thread Chris Forbes
Looks reasonable to me. Reviewed-by: Chris Forbes chr...@ijw.co.nz On Tue, Dec 16, 2014 at 7:13 PM, Jason Ekstrand ja...@jlekstrand.net wrote: --- src/glsl/nir/nir_lower_samplers.cpp | 149 ++-- 1 file changed, 74 insertions(+), 75 deletions(-) diff --git

Re: [Piglit] [PATCH] Add a new test case used to valid gl_VertexID for bug 87611

2015-01-03 Thread Chris Forbes
path. Because from the result, both of them work well. Thanks, Shuo -Original Message- From: Chris Forbes [mailto:chr...@ijw.co.nz] Sent: Thursday, January 1, 2015 2:53 AM To: Wang, Shuo Cc: piglit@lists.freedesktop.org; Romanick, Ian D Subject: Re: [Piglit] [PATCH] Add a new test

Re: [Piglit] [PATCH] Add new test to exercise GLSL compiler bug involving unused const arrays

2015-01-02 Thread Chris Forbes
Reviewed-by: Chris Forbes chr...@ijw.co.nz On Jan 3, 2015 8:53 AM, Brian Paul bri...@vmware.com wrote: Currently, this test causes the GLSL compiler to abort in ir_validate.cpp with the message: ir_dereference_variable @ 0x182ee80 specifies undeclared variable `unused_array' @ 0x182ed80

Re: [Piglit] [PATCH 1/3] ext_transform_feedback: test immediate index buffer reuse

2015-01-01 Thread Chris Forbes
These three all pass on i965 with master, so I guess you have some breakage at the gallium layer or below. All three are: Reviewed-by: Chris Forbes chr...@ijw.co.nz On Fri, Jan 2, 2015 at 3:17 AM, Marek Olšák mar...@gmail.com wrote: From: Marek Olšák marek.ol...@amd.com --- tests/all.py

Re: [Mesa-dev] [PATCH 1/2] i965: Fix BLORP sRGB MSAA overrides to cope with X vs. A formats.

2015-01-01 Thread Chris Forbes
Both of these are also Reviewed-by: Chris Forbes chr...@ijw.co.nz On Jan 1, 2015 7:48 PM, Kenneth Graunke kenn...@whitecape.org wrote: The logic in brw_blorp_surface_info::set uses brw_format_for_mesa_format for source surfaces, and brw-render_target_format[] for destination surfaces. We

Re: [Piglit] [PATCH] Add a new test case used to valid gl_VertexID for bug 87611

2014-12-31 Thread Chris Forbes
I think it would be worth mentioning that you're using GL_TRIANGLE_FAN specifically to hit the SW primitive restart path. On Thu, Jan 1, 2015 at 3:24 AM, Wang Shuo shuo.w...@intel.com wrote: This case is added for *Bug 87611 - Exercise gl_VertexID corner cases in i965 driver*, and used to

Re: [Mesa-dev] [PATCH] i965: Fix start/base_vertex_location for 1 prims but !BRW_NEW_VERTICES.

2014-12-31 Thread Chris Forbes
Seems reasonable to me. Reviewed-by: Chris Forbes chr...@ijw.co.nz On Fri, Dec 19, 2014 at 1:45 AM, Kenneth Graunke kenn...@whitecape.org wrote: This is a partial revert of c89306983c07e5a88c0d636267e5ccf263cb4213. It split the {start,base}_vertex_location handling into several steps: 1. Set

Re: [Mesa-dev] [PATCH 1/2] i965: Make the precompile ignore DEPTH_TEXTURE_MODE on Gen7.5+.

2014-12-31 Thread Chris Forbes
Nice! Both are Reviewed-by: Chris Forbes chr...@ijw.co.nz On Jan 1, 2015 5:04 PM, Kenneth Graunke kenn...@whitecape.org wrote: Gen7.5+ platforms that support the Shader Channel Select feature leave key-tex.swizzles[i] as SWIZZLE_NOOP except when GL_DEPTH_TEXTURE_MODE is GL_ALPHA (which

Re: [Piglit] [PATCH] util shader: Add support for compute shaders in shader_name()

2014-12-28 Thread Chris Forbes
Reviewed-by: Chris Forbes chr...@ijw.co.nz On Mon, Dec 29, 2014 at 7:07 PM, Tapani Pälli tapani.pa...@intel.com wrote: Currently compute shaders that fail to compile trigger assert during piglit_compile_shader_text. Signed-off-by: Tapani Pälli tapani.pa...@intel.com --- tests/util/piglit

Re: [Piglit] [PATCH] glsl-1.50: test implicitly sized arrays match explicitly sized arrays across the same stage

2014-12-22 Thread Chris Forbes
Reviewed-by: Chris Forbes chr...@ijw.co.nz On Mon, Dec 22, 2014 at 11:36 PM, Timothy Arceri t_arc...@yahoo.com.au wrote: --- ...ge-unsized-interface-array-mismatch.shader_test | 55 + ...e-unsized-interface-array-mismatch2.shader_test | 56

Re: [Mesa-dev] [PATCH V2] glsl: check if implicitly sized arrays match explicitly sized arrays across the same stage

2014-12-22 Thread Chris Forbes
OK, cool. This patch is Reviewed-by: Chris Forbes chr...@ijw.co.nz On Mon, Dec 22, 2014 at 11:44 PM, Timothy Arceri t_arc...@yahoo.com.au wrote: - Original Message - From: Chris Forbes chr...@ijw.co.nz Does this work correctly for arrays of interface blocks too? Hi Chris

Re: [Mesa-dev] [PATCH 0/3] i965: Use intel_try_pbo_upload for sub updates and 3D textures

2014-12-22 Thread Chris Forbes
Are there some performance numbers to go with this? On Tue, Dec 23, 2014 at 12:08 PM, Neil Roberts n...@linux.intel.com wrote: Here are some patches to make the i965 driver use the blit pipeline for sub-texture updates and also for 3D textures and array textures (including cube map arrays)

Re: [Mesa-dev] [Mesa-stable] [PATCH] i965: Add missing BRW_NEW_*_PROG_DATA to texture/renderbuffer atoms.

2014-12-22 Thread Chris Forbes
Reviewed-by: Chris Forbes chr...@ijw.co.nz On Tue, Dec 23, 2014 at 3:58 PM, Kenneth Graunke kenn...@whitecape.org wrote: This was probably missed when moving from a fixed binding table layout to a dynamic one that changes based on the shader. Fixes newly proposed Piglit test fbo-mrt-new-bind

Re: [Mesa-dev] [PATCH] tgsi: lowering support for alpha test

2014-12-19 Thread Chris Forbes
On Sat, Dec 20, 2014 at 8:11 AM, Rob Clark robdcl...@gmail.com wrote: @@ -1452,6 +1593,20 @@ tgsi_transform_lowering(const struct tgsi_lowering_config *config, } } + if ((info-processor == TGSI_PROCESSOR_FRAGMENT) + config-lower_alpha_test + (config-alpha_func

Re: [Piglit] [PATCH 01/24] arb_direct_state_access: DSA 2D Textures hello world test.

2014-12-15 Thread Chris Forbes
Did you mean to leave the non-DSA nvidia workaround in here? I understand this might have been useful for getting it working initially, but... if their driver is broken, it's broken. On Tue, Dec 16, 2014 at 2:24 PM, Laura Ekstrand la...@jlekstrand.net wrote: Dylan Baker: all.py: Add dsa tests.

Re: [Mesa-dev] Precision of float and trigonometric functions on i965

2014-12-11 Thread Chris Forbes
Iago, This doesn't matter for GL conformance -- but the impression I get is that dEQP is aiming at something more. In any case, the usual problem with this is inaccurate range reduction, which is fixable in software at some performance cost. The C library does this, for example. - Chris On

Re: [Mesa-dev] [PATCH] i965: Disable unlit-centroid workaround on Gen 6.

2014-12-08 Thread Chris Forbes
Reviewed-by: Chris Forbes chr...@ijw.co.nz On Tue, Dec 9, 2014 at 8:08 PM, Matt Turner matts...@gmail.com wrote: Back to the original commit (8313f444) adding the workaround, we were enabling it on gens = 7, even though gens = 5 can't do multisampling. I cannot find documentation that says

Re: [Mesa-dev] [PATCH] i965: Disable unlit-centroid workaround on Gen 6.

2014-12-08 Thread Chris Forbes
Possibly mark this for 10.4, since the assertion failures we hit when emitting a pointless centroid workaround make other issues hard to debug? On Tue, Dec 9, 2014 at 8:44 PM, Chris Forbes chr...@ijw.co.nz wrote: Reviewed-by: Chris Forbes chr...@ijw.co.nz On Tue, Dec 9, 2014 at 8:08 PM, Matt

[Mesa-dev] [PATCH] i965/gen4-5: Cope with immutable-format texture revalidation

2014-12-07 Thread Chris Forbes
This is unfortunately sometimes necessary due to rebasing levels when rendering into them. 16 piglits crash - pass, when building mesa with debug enabled. Signed-off-by: Chris Forbes chr...@ijw.co.nz --- src/mesa/drivers/dri/i965/intel_tex_validate.c | 13 ++--- 1 file changed, 10

[Piglit] [PATCH 1/6] arb_gpu_shader5: add execution test for interpolateAtCentroid

2014-12-06 Thread Chris Forbes
Signed-off-by: Chris Forbes chr...@ijw.co.nz --- tests/all.py | 1 + tests/spec/arb_gpu_shader5/CMakeLists.gl.txt | 1 + tests/spec/arb_gpu_shader5/interpolateAtCentroid.c | 165 + 3 files changed, 167 insertions(+) create mode

[Piglit] [PATCH 4/6] arb_gpu_shader5: add interpolateAtSample-nonconst test

2014-12-06 Thread Chris Forbes
Signed-off-by: Chris Forbes chr...@ijw.co.nz --- tests/all.py | 1 + tests/spec/arb_gpu_shader5/CMakeLists.gl.txt | 1 + .../arb_gpu_shader5/interpolateAtSample-nonconst.c | 186 + 3 files changed, 188 insertions(+) create mode

[Piglit] [PATCH 2/6] arb_gpu_shader5: add variant of interpolateAtCentroid test for packing interaction

2014-12-06 Thread Chris Forbes
This is interesting for mesa's varying packer, and i965's backend. The API does not allow a swizzle to be supplied here, but the backend must cope with one being introduced by packing. Signed-off-by: Chris Forbes chr...@ijw.co.nz --- tests/all.py | 1

[Piglit] [PATCH 3/6] arb_gpu_shader5: add interpolateAtSample test

2014-12-06 Thread Chris Forbes
Signed-off-by: Chris Forbes chr...@ijw.co.nz --- tests/all.py | 1 + tests/spec/arb_gpu_shader5/CMakeLists.gl.txt | 1 + tests/spec/arb_gpu_shader5/interpolateAtSample.c | 182 +++ 3 files changed, 184 insertions(+) create mode

Mesa (master): i965: Fix regs read for FS_OPCODE_INTERP_PER_SLOT_OFFSET

2014-12-06 Thread Chris Forbes
Module: Mesa Branch: master Commit: 092c73a7c32b240a26ffeab2ee475f6d590540b2 URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=092c73a7c32b240a26ffeab2ee475f6d590540b2 Author: Chris Forbes chr...@ijw.co.nz Date: Sun Dec 7 10:12:36 2014 +1300 i965: Fix regs read

Mesa (master): i965: Add opcode names for FS interpolation opcodes

2014-12-06 Thread Chris Forbes
Module: Mesa Branch: master Commit: 680f72d6f2259a1dd382a1876a594b407f933278 URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=680f72d6f2259a1dd382a1876a594b407f933278 Author: Chris Forbes chr...@ijw.co.nz Date: Sun Dec 7 10:07:16 2014 +1300 i965: Add opcode names for FS interpolation

Mesa (master): i965/Gen6-7: Fix point sprites with PolygonMode(GL_POINT)

2014-12-06 Thread Chris Forbes
Module: Mesa Branch: master Commit: ed56c16820aea0e115768d77861fe266380f2595 URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=ed56c16820aea0e115768d77861fe266380f2595 Author: Chris Forbes chr...@ijw.co.nz Date: Fri Dec 5 19:43:13 2014 +1300 i965/Gen6-7: Fix point sprites

Mesa (master): glcpp: Fix `can not` to `cannot` in error message

2014-12-06 Thread Chris Forbes
Module: Mesa Branch: master Commit: 6b0196934509ac76293581f7ca69a3399ffb2e0a URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=6b0196934509ac76293581f7ca69a3399ffb2e0a Author: Chris Forbes chr...@ijw.co.nz Date: Sun Dec 7 11:49:28 2014 +1300 glcpp: Fix `can not` to `cannot` in error

Mesa (master): glcpp: Disallow undefining GL_* builtin macros.

2014-12-06 Thread Chris Forbes
Module: Mesa Branch: master Commit: b49a069bd3c96c8a144bb671863d0757fb421a07 URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=b49a069bd3c96c8a144bb671863d0757fb421a07 Author: Chris Forbes chr...@ijw.co.nz Date: Sun Nov 30 09:54:59 2014 +1300 glcpp: Disallow undefining GL_* builtin

[Mesa-dev] [PATCH 2/2] i965: Fix regs read for FS_OPCODE_INTERP_PER_SLOT_OFFSET

2014-12-06 Thread Chris Forbes
Dead code elimination was eating the Y offset. Fixes the piglit test: spec/ARB_gpu_shader5/arb_gpu_shader5-interpolateAtOffset-nonconst Signed-off-by: Chris Forbes chr...@ijw.co.nz --- src/mesa/drivers/dri/i965/brw_fs.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/mesa/drivers

[Mesa-dev] [PATCH 1/2] i965: Add opcode names for FS interpolation opcodes

2014-12-06 Thread Chris Forbes
Signed-off-by: Chris Forbes chr...@ijw.co.nz --- src/mesa/drivers/dri/i965/brw_shader.cpp | 9 + 1 file changed, 9 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_shader.cpp b/src/mesa/drivers/dri/i965/brw_shader.cpp index 183a4f1..8f6a3de 100644 --- a/src/mesa/drivers/dri/i965

Re: [Mesa-dev] [PATCH] i965: Add opcode names for set_omask and set_sample_id.

2014-12-06 Thread Chris Forbes
Reviewed-by: Chris Forbes chr...@ijw.co.nz On Sun, Dec 7, 2014 at 10:34 AM, Matt Turner matts...@gmail.com wrote: --- src/mesa/drivers/dri/i965/brw_shader.cpp | 4 1 file changed, 4 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_shader.cpp b/src/mesa/drivers/dri/i965

Re: [Mesa-dev] [PATCH 1/2] i965: Add missing opcode names.

2014-12-06 Thread Chris Forbes
Both are: Reviewed-by: Chris Forbes chr...@ijw.co.nz On Sun, Dec 7, 2014 at 11:21 AM, Matt Turner matts...@gmail.com wrote: --- src/mesa/drivers/dri/i965/brw_shader.cpp | 9 + 1 file changed, 9 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_shader.cpp b/src/mesa/drivers

Re: [Piglit] [PATCH V2] glsl-1.20: test implicitly sized arrays match explicitly sized arrays across the same stage

2014-12-04 Thread Chris Forbes
Reviewed-by: Chris Forbes chr...@ijw.co.nz On Fri, Dec 5, 2014 at 10:18 AM, Timothy Arceri t_arc...@yahoo.com.au wrote: V2: Add Catalyst test results Test results: AMD Radeon HD 6670 - Catalyst 13.251 OpenGL 4.3 intrastage-unsized-array-mismatch.shader_test AMD: pass intrastage-unsized

Re: [Piglit] [PATCH 1/2 V2] arb_arrays_of_arrays: linker tests

2014-12-04 Thread Chris Forbes
Both patches are: Reviewed-by: Chris Forbes chr...@ijw.co.nz On Fri, Dec 5, 2014 at 10:35 AM, Timothy Arceri t_arc...@yahoo.com.au wrote: V2: add alternate version of unsized-mismatch test and fix comment describing negitive test as a positive test Test results: AMD Radeon HD 6670

Re: [Mesa-dev] [PATCH 2/3] glcpp: Disallow undefining GL_* builtin macros.

2014-12-04 Thread Chris Forbes
Ugh, yes, I'll fix that and land it at the same time. Thanks :) On Fri, Dec 5, 2014 at 11:12 AM, Ian Romanick i...@freedesktop.org wrote: On 11/29/2014 12:54 PM, Chris Forbes wrote: Fixes the piglit test: spec/glsl-es-3.00/compiler/undef-GL_ES.vert Signed-off-by: Chris Forbes chr

[Mesa-dev] [PATCH] i965/Gen6-7: Fix point sprites with PolygonMode(GL_POINT)

2014-12-04 Thread Chris Forbes
of pointsprite enables for front and back faces. Haswell ignores pointsprite state correctly in hardware for non-point rasterization, so can do this correctly, but it doesn't seem worth it. Signed-off-by: Chris Forbes chr...@ijw.co.nz Cc: 10.4 mesa-sta...@lists.freedesktop.org Bugzilla: https

Re: [Mesa-dev] [PATCH] i965: Compute VS attribute WA bits earlier and check if they changed.

2014-12-03 Thread Chris Forbes
What's the perf impact on a platform which actually needs this? I think there would be some further substantial gains to be had by giving this its own dirty bit -- piles of other atoms listen to BRW_NEW_VERTEX_PROGRAM, but don't care about the workaround bits. On Thu, Dec 4, 2014 at 2:42 PM,

Re: [Mesa-dev] [PATCH] i965: Compute VS attribute WA bits earlier and check if they changed.

2014-12-03 Thread Chris Forbes
Half-ignore the first part of that... I thinko'd and assumed Baytrail worked the same as Haswell here, but obviously doesn't. I am interested in how it affects earlier gens, though. On Thu, Dec 4, 2014 at 3:13 PM, Chris Forbes chr...@ijw.co.nz wrote: What's the perf impact on a platform which

Re: [Mesa-dev] [PATCH] i965: Compute VS attribute WA bits earlier and check if they changed.

2014-12-03 Thread Chris Forbes
Either way, Reviewed-by: Chris Forbes chr...@ijw.co.nz On Thu, Dec 4, 2014 at 7:36 PM, Kenneth Graunke kenn...@whitecape.org wrote: On Thursday, December 04, 2014 03:13:59 PM Chris Forbes wrote: What's the perf impact on a platform which actually needs this? I think there would be some

<    1   2   3   4   5   6   7   8   9   10   >