[Mesa-dev] [PATCH 1/4] i965: Correctly use ABO count to trigger flagging of new surfaces.

2014-09-23 Thread Chris Forbes
This would have *almost never* actually been an issue, since other state tends to get flagged at the same time as new ABOs -- but still bogus. Signed-off-by: Chris Forbes chr...@ijw.co.nz --- src/mesa/drivers/dri/i965/brw_wm_surface_state.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion

[Mesa-dev] [PATCH 2/4] i965: Fix typo in comment

2014-09-23 Thread Chris Forbes
--- src/mesa/drivers/dri/i965/brw_wm_surface_state.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_wm_surface_state.c b/src/mesa/drivers/dri/i965/brw_wm_surface_state.c index d473470..5f75c31 100644 ---

Re: [Mesa-dev] [PATCH 4/4] i965: Suppress re-flagging of BRW_NEW_UNIFORM_BUFFER while emitting UBO state.

2014-09-23 Thread Chris Forbes
One further note: It's possible to provoke the same bad behavior in the equivalent ABO path, by declaring an atomic counter but never binding any buffer object to the binding point, so this isn't a real fix. -- Chris On Tue, Sep 23, 2014 at 10:16 PM, Chris Forbes chr...@ijw.co.nz wrote

Re: [Mesa-dev] [PATCH] i915: Restructure debug flags

2014-09-23 Thread Chris Forbes
s/i915/i965/ in subject line? Otherwise, Reviewed-by: Chris Forbes chr...@ijw.co.nz ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Piglit] [PATCH] sso: Fixed mistakenly disabled float entry points in ProgramUniform

2014-09-22 Thread Chris Forbes
Reviewed-by: Chris Forbes chr...@ijw.co.nz On Mon, Sep 8, 2014 at 3:49 PM, Popov, Pavel E pavel.e.po...@intel.com wrote: Hi Ian, Could you review this small fix? -Pavel -Original Message- From: Popov, Pavel E Sent: Friday, August 29, 2014 10:15 AM To: piglit@lists.freedesktop.org

Re: [Piglit] [PATCH] Add shader tests for out of bounds array index

2014-09-22 Thread Chris Forbes
On Tue, Sep 23, 2014 at 11:36 AM, Anuj Phogat anuj.pho...@gmail.com wrote: +[test] +clear color 0.0 0.0 0.0 0.0 +clear +draw rect -1 -1 2 3 There's a bunch of this rect outside the clip volume. I think you meant -1 -1 2 2. (in all the tests) Other than that, Reviewed-by: Chris Forbes chr

[Mesa-dev] [RFC PATCH 00/56] ARB_tessellation_shader for core mesa

2014-09-20 Thread Chris Forbes
This series adds all the driver-independent bits for ARB_tessellation_shader. It's not quite finished, and there are still a handful of ugly hacks to remove, but I think it's complete enough to start getting some review feedback. ___ mesa-dev mailing

[Mesa-dev] [RFC PATCH 01/56] mapi: Add ARB_tessellation_shader

2014-09-20 Thread Chris Forbes
From: Fabian Bieler fabianbie...@fastmail.fm V2 [Chris]: Remove display list support; we will only do tessellation shders in the core profile. --- src/mapi/glapi/gen/ARB_tessellation_shader.xml | 62 ++ src/mapi/glapi/gen/gl_API.xml | 6 ++-

[Mesa-dev] [RFC PATCH 05/56] mesa/main: Add tessellation shader state and limits

2014-09-20 Thread Chris Forbes
--- src/mesa/main/config.h| 8 src/mesa/main/context.c | 10 ++ src/mesa/main/mtypes.h| 9 + src/mesa/main/shaderapi.c | 7 +++ 4 files changed, 34 insertions(+) diff --git a/src/mesa/main/config.h b/src/mesa/main/config.h index 4ec4b75..c0b5914 100644

[Mesa-dev] [RFC PATCH 07/56] mesa: Allow drawing of patch primitives

2014-09-20 Thread Chris Forbes
Signed-off-by: Chris Forbes chr...@ijw.co.nz --- src/mesa/main/api_validate.c | 43 ++- 1 file changed, 42 insertions(+), 1 deletion(-) diff --git a/src/mesa/main/api_validate.c b/src/mesa/main/api_validate.c index 51a3d1f..64ed465 100644 --- a/src/mesa

[Mesa-dev] [RFC PATCH 04/56] mesa: Add tessellation shader enums

2014-09-20 Thread Chris Forbes
From: Fabian Bieler fabianbie...@fastmail.fm V2 [Chris]: Adjust meta.c as well to avoid undefined behavior. --- src/mesa/drivers/common/meta.c | 2 ++ src/mesa/main/mtypes.h | 8 +--- src/mesa/main/shaderobj.h | 4 src/mesa/program/prog_print.c | 6 ++

[Mesa-dev] [RFC PATCH 06/56] mesa/program: Add tessellation shader init functions.

2014-09-20 Thread Chris Forbes
From: Fabian Bieler fabianbie...@fastmail.fm V2 [Chris]: Fix rebase issues; helper previously used here no longer exists. Signed-off-by: Chris Forbes chr...@ijw.co.nz --- src/mesa/program/program.c | 32 src/mesa/program/program.h | 10 ++ 2 files

[Mesa-dev] [RFC PATCH 02/56] mesa/main: Add ARB_tessellation_shader to extension table.

2014-09-20 Thread Chris Forbes
From: Fabian Bieler fabianbie...@fastmail.fm --- src/mesa/main/extensions.c | 1 + src/mesa/main/mtypes.h | 1 + 2 files changed, 2 insertions(+) diff --git a/src/mesa/main/extensions.c b/src/mesa/main/extensions.c index 553c01e..e676e18 100644 --- a/src/mesa/main/extensions.c +++

[Mesa-dev] [RFC PATCH 10/56] mesa: Generalize sso stage interleaving check for tess

2014-09-20 Thread Chris Forbes
Signed-off-by: Chris Forbes chr...@ijw.co.nz --- src/mesa/main/pipelineobj.c | 53 +++-- 1 file changed, 37 insertions(+), 16 deletions(-) diff --git a/src/mesa/main/pipelineobj.c b/src/mesa/main/pipelineobj.c index c902107..b91289e 100644 --- a/src/mesa

[Mesa-dev] [RFC PATCH 09/56] mesa: Allow tess stages in glUseProgramStages

2014-09-20 Thread Chris Forbes
--- src/mesa/main/pipelineobj.c | 17 + 1 file changed, 13 insertions(+), 4 deletions(-) diff --git a/src/mesa/main/pipelineobj.c b/src/mesa/main/pipelineobj.c index 61a5785..c902107 100644 --- a/src/mesa/main/pipelineobj.c +++ b/src/mesa/main/pipelineobj.c @@ -243,14 +243,13 @@

[Mesa-dev] [RFC PATCH 11/56] mesa: Require VS if TCS or TES is present in pipeline

2014-09-20 Thread Chris Forbes
Signed-off-by: Chris Forbes chr...@ijw.co.nz --- src/mesa/main/pipelineobj.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/mesa/main/pipelineobj.c b/src/mesa/main/pipelineobj.c index b91289e..75edac1 100644 --- a/src/mesa/main/pipelineobj.c +++ b/src/mesa/main

[Mesa-dev] [RFC PATCH 13/56] mesa/main: Allow setting of patch parameters.

2014-09-20 Thread Chris Forbes
From: Fabian Bieler fabianbie...@fastmail.fm --- src/mesa/main/shaderapi.c | 30 -- 1 file changed, 28 insertions(+), 2 deletions(-) diff --git a/src/mesa/main/shaderapi.c b/src/mesa/main/shaderapi.c index c11ad4f..cfad210 100644 --- a/src/mesa/main/shaderapi.c +++

[Mesa-dev] [RFC PATCH 03/56] mesa/main: Add tessellation shader structs

2014-09-20 Thread Chris Forbes
From: Fabian Bieler fabianbie...@fastmail.fm --- src/mesa/main/mtypes.h | 121 + 1 file changed, 121 insertions(+) diff --git a/src/mesa/main/mtypes.h b/src/mesa/main/mtypes.h index 59e6eeb..7a8f5f3 100644 --- a/src/mesa/main/mtypes.h +++

[Mesa-dev] [RFC PATCH 12/56] mesa: Add tessellation shader builtin varyings.

2014-09-20 Thread Chris Forbes
From: Fabian Bieler fabianbie...@fastmail.fm --- src/mesa/main/mtypes.h| 15 ++- src/mesa/program/prog_print.c | 4 2 files changed, 18 insertions(+), 1 deletion(-) diff --git a/src/mesa/main/mtypes.h b/src/mesa/main/mtypes.h index 9e989d7..9088e97 100644 ---

[Mesa-dev] [RFC PATCH 23/56] glsl: Allow linking of tessellation shaders.

2014-09-20 Thread Chris Forbes
Signed-off-by: Chris Forbes chr...@ijw.co.nz --- src/glsl/link_interface_blocks.cpp | 9 +- src/glsl/linker.cpp| 248 - 2 files changed, 252 insertions(+), 5 deletions(-) diff --git a/src/glsl/link_interface_blocks.cpp b/src/glsl

[Mesa-dev] [RFC PATCH 19/56] mesa: add system value for gl_PatchVerticesIn

2014-09-20 Thread Chris Forbes
From: Ilia Mirkin imir...@alum.mit.edu Signed-off-by: Ilia Mirkin imir...@alum.mit.edu Conflicts: src/mesa/main/mtypes.h --- src/mesa/main/mtypes.h | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/main/mtypes.h b/src/mesa/main/mtypes.h index 9bd78e4..b03afd2 100644 ---

[Mesa-dev] [RFC PATCH 17/56] mesa: Add support for UNIFORM_BLOCK_REFERENCED_BY_TESS_*_SHADER

2014-09-20 Thread Chris Forbes
Signed-off-by: Chris Forbes chr...@ijw.co.nz --- src/mesa/main/uniforms.c | 21 + 1 file changed, 17 insertions(+), 4 deletions(-) diff --git a/src/mesa/main/uniforms.c b/src/mesa/main/uniforms.c index 0d0cbf5..ceeadf4 100644 --- a/src/mesa/main/uniforms.c +++ b/src/mesa/main

[Mesa-dev] [RFC PATCH 16/56] mesa/program: Add misc tessellation shader support.

2014-09-20 Thread Chris Forbes
From: Fabian Bieler fabianbie...@fastmail.fm --- src/mesa/program/program.c | 44 ++ src/mesa/program/program.h | 60 +- 2 files changed, 103 insertions(+), 1 deletion(-) diff --git a/src/mesa/program/program.c

[Mesa-dev] [RFC PATCH 15/56] mesa/main: Add misc tessellation shader stuff.

2014-09-20 Thread Chris Forbes
From: Fabian Bieler fabianbie...@fastmail.fm --- src/mesa/main/context.c | 6 + src/mesa/main/mtypes.h| 3 ++- src/mesa/main/shaderapi.c | 29 src/mesa/main/state.c | 67 +-- 4 files changed, 102 insertions(+), 3

[Mesa-dev] [RFC PATCH 21/56] glsl: Add tessellation shader defines and built-in variables.

2014-09-20 Thread Chris Forbes
From: Fabian Bieler fabianbie...@fastmail.fm --- src/glsl/builtin_variables.cpp | 62 +- src/glsl/glcpp/glcpp-parse.y | 3 ++ 2 files changed, 64 insertions(+), 1 deletion(-) diff --git a/src/glsl/builtin_variables.cpp b/src/glsl/builtin_variables.cpp

[Mesa-dev] [RFC PATCH 22/56] glsl: Add tessellation shader parsing support.

2014-09-20 Thread Chris Forbes
From: Fabian Bieler fabianbie...@fastmail.fm --- src/glsl/ast.h | 46 + src/glsl/ast_to_hir.cpp | 145 +++- src/glsl/ast_type.cpp | 112 ++- src/glsl/glsl_parser.yy | 118

[Mesa-dev] [RFC PATCH 08/56] mesa: Support tess stages in glGetProgramPipelineiv

2014-09-20 Thread Chris Forbes
From: Fabian Bieler fabianbie...@fastmail.fm --- src/mesa/main/pipelineobj.c | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/src/mesa/main/pipelineobj.c b/src/mesa/main/pipelineobj.c index b713d95..61a5785 100644 --- a/src/mesa/main/pipelineobj.c +++

[Mesa-dev] [RFC PATCH 14/56] mesa/main: Add tessellation shader getters.

2014-09-20 Thread Chris Forbes
From: Fabian Bieler fabianbie...@fastmail.fm --- src/mesa/main/get.c | 1 + src/mesa/main/get_hash_params.py | 21 src/mesa/main/shaderapi.c| 73 3 files changed, 95 insertions(+) diff --git a/src/mesa/main/get.c

[Mesa-dev] [RFC PATCH 20/56] vbo: Add patch size to primitive structure.

2014-09-20 Thread Chris Forbes
From: Fabian Bieler fabianbie...@fastmail.fm --- src/mesa/vbo/vbo.h| 3 ++- src/mesa/vbo/vbo_exec_api.c | 2 ++ src/mesa/vbo/vbo_exec_array.c | 4 3 files changed, 8 insertions(+), 1 deletion(-) diff --git a/src/mesa/vbo/vbo.h b/src/mesa/vbo/vbo.h index 6e1a4aa..4fe4427

[Mesa-dev] [RFC PATCH 24/56] glsl: Allow tess control and tess eval shaders without VS if separate

2014-09-20 Thread Chris Forbes
Signed-off-by: Chris Forbes chr...@ijw.co.nz --- src/glsl/linker.cpp | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/glsl/linker.cpp b/src/glsl/linker.cpp index e7c8974..6ed54db 100644 --- a/src/glsl/linker.cpp +++ b/src/glsl/linker.cpp @@ -2776,13 +2776,15

[Mesa-dev] [RFC PATCH 29/56] glsl: keep track of which inputs/outputs are per-patch

2014-09-20 Thread Chris Forbes
From: Ilia Mirkin imir...@alum.mit.edu --- src/glsl/ir_set_program_inouts.cpp | 21 +++-- src/mesa/main/mtypes.h | 3 +++ 2 files changed, 18 insertions(+), 6 deletions(-) diff --git a/src/glsl/ir_set_program_inouts.cpp b/src/glsl/ir_set_program_inouts.cpp index

[Mesa-dev] [RFC PATCH 31/56] glsl: Add builtin uniforms for default inner/outer tess levels

2014-09-20 Thread Chris Forbes
If the hardware needs to always have a control shader present if and evaluation shader is present, then the control shader will need these values. --- src/glsl/builtin_variables.cpp| 14 ++ src/mesa/program/prog_statevars.c | 24

[Mesa-dev] [RFC PATCH 25/56] glsl: Make lower_clip_distance work with tessellation shaders.

2014-09-20 Thread Chris Forbes
From: Fabian Bieler fabianbie...@fastmail.fm --- src/glsl/lower_clip_distance.cpp | 181 ++- 1 file changed, 102 insertions(+), 79 deletions(-) diff --git a/src/glsl/lower_clip_distance.cpp b/src/glsl/lower_clip_distance.cpp index 2d6138d..3490203 100644 ---

[Mesa-dev] [RFC PATCH 18/56] mesa: Support querying atomic counters referenced by tess stages

2014-09-20 Thread Chris Forbes
Signed-off-by: Chris Forbes chr...@ijw.co.nz --- src/mesa/main/uniforms.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mesa/main/uniforms.c b/src/mesa/main/uniforms.c index ceeadf4..60fd11a 100644 --- a/src/mesa/main/uniforms.c +++ b/src/mesa/main/uniforms.c

[Mesa-dev] [RFC PATCH 34/56] glsl: relax unsized input/output block arrays for TCS/TES

2014-09-20 Thread Chris Forbes
--- src/glsl/ast_to_hir.cpp | 29 - 1 file changed, 24 insertions(+), 5 deletions(-) diff --git a/src/glsl/ast_to_hir.cpp b/src/glsl/ast_to_hir.cpp index 2490990..63f486e 100644 --- a/src/glsl/ast_to_hir.cpp +++ b/src/glsl/ast_to_hir.cpp @@ -5712,12 +5712,31 @@

[Mesa-dev] [RFC PATCH 26/56] glsl: Lower gl_TessLevel* from float[n] to vecn.

2014-09-20 Thread Chris Forbes
From: Fabian Bieler fabianbie...@fastmail.fm Similar to gl_ClipDistance - gl_ClipDistanceMESA V2 [Chris]: Fix rebase issues. --- src/glsl/Makefile.sources | 1 + src/glsl/ir_optimization.h | 1 + src/glsl/link_varyings.cpp | 50 +++-

[Mesa-dev] [RFC PATCH 35/56] glsl: Add missing newlines to various resource limit errors

2014-09-20 Thread Chris Forbes
Signed-off-by: Chris Forbes chr...@ijw.co.nz --- src/glsl/linker.cpp | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/glsl/linker.cpp b/src/glsl/linker.cpp index be86371..d2a818e 100644 --- a/src/glsl/linker.cpp +++ b/src/glsl/linker.cpp @@ -2478,7 +2478,7

[Mesa-dev] [RFC PATCH 36/56] glsl: Allow nonconst indexing of arrays where we can work out an implicit size

2014-09-20 Thread Chris Forbes
Signed-off-by: Chris Forbes chr...@ijw.co.nz --- src/glsl/ast_array_index.cpp | 24 +++- 1 file changed, 23 insertions(+), 1 deletion(-) diff --git a/src/glsl/ast_array_index.cpp b/src/glsl/ast_array_index.cpp index 5ca85f6..1ad8361 100644 --- a/src/glsl/ast_array_index.cpp

[Mesa-dev] [RFC PATCH 32/56] glsl: Make stand-alone compiler work with tessellation shaders.

2014-09-20 Thread Chris Forbes
From: Fabian Bieler fabianbie...@fastmail.fm --- src/glsl/main.cpp | 8 +++- src/glsl/standalone_scaffolding.cpp | 1 + src/glsl/standalone_scaffolding.h | 4 3 files changed, 12 insertions(+), 1 deletion(-) diff --git a/src/glsl/main.cpp b/src/glsl/main.cpp index

[Mesa-dev] [RFC PATCH 30/56] glsl: Add In or Out suffix to name when flattening interface blocks.

2014-09-20 Thread Chris Forbes
From: Fabian Bieler fabianbie...@fastmail.fm This is to prevent a name conflict in tessellation shaders built-in interface blocks. --- src/glsl/lower_named_interface_blocks.cpp | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/glsl/lower_named_interface_blocks.cpp

[Mesa-dev] [RFC PATCH 27/56] glsl: lower_tess_level: Use writemask instead of vector insert op for constant swizzle.

2014-09-20 Thread Chris Forbes
From: Fabian Bieler fabianbie...@fastmail.fm --- src/glsl/lower_tess_level.cpp | 46 +++ 1 file changed, 29 insertions(+), 17 deletions(-) diff --git a/src/glsl/lower_tess_level.cpp b/src/glsl/lower_tess_level.cpp index ece5988..55029d4 100644 ---

[Mesa-dev] [RFC PATCH 28/56] glsl: patch in/out qualifier

2014-09-20 Thread Chris Forbes
From: Fabian Bieler fabianbie...@fastmail.fm --- src/glsl/ast.h| 1 + src/glsl/ast_to_hir.cpp | 48 +--- src/glsl/ast_type.cpp | 3 +- src/glsl/builtin_variables.cpp| 18 +---

[Mesa-dev] [RFC PATCH 40/56] glsl: Restrict indexing for writes to TCS outputs to gl_InvocationID

2014-09-20 Thread Chris Forbes
Signed-off-by: Chris Forbes chr...@ijw.co.nz --- src/glsl/ast_to_hir.cpp | 67 + 1 file changed, 56 insertions(+), 11 deletions(-) diff --git a/src/glsl/ast_to_hir.cpp b/src/glsl/ast_to_hir.cpp index 63f486e..f962d1e 100644 --- a/src/glsl

[Mesa-dev] [RFC PATCH 41/56] glsl: properly size unsized arrays in tess stages

2014-09-20 Thread Chris Forbes
--- src/glsl/ast_to_hir.cpp | 30 ++ 1 file changed, 30 insertions(+) diff --git a/src/glsl/ast_to_hir.cpp b/src/glsl/ast_to_hir.cpp index f962d1e..91c54d5 100644 --- a/src/glsl/ast_to_hir.cpp +++ b/src/glsl/ast_to_hir.cpp @@ -3150,6 +3150,33 @@

[Mesa-dev] [RFC PATCH 39/56] glsl: Fix linking of VS outputs to TCS inputs

2014-09-20 Thread Chris Forbes
In the TCS, these are all arrays, just like GS inputs. --- src/glsl/link_varyings.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/glsl/link_varyings.cpp b/src/glsl/link_varyings.cpp index 53c26d2..5d232482 100644 --- a/src/glsl/link_varyings.cpp +++

[Mesa-dev] [RFC PATCH 46/56] glsl: Push vertex count determination down one level

2014-09-20 Thread Chris Forbes
We have the prog here, so we don't need the caller to work this out for us. --- src/glsl/link_varyings.cpp | 12 ++-- src/glsl/link_varyings.h | 3 +-- src/glsl/linker.cpp| 10 +++--- 3 files changed, 10 insertions(+), 15 deletions(-) diff --git

[Mesa-dev] [RFC PATCH 44/56] glsl: pass shader stage to lower_output_reads and handle tess control

2014-09-20 Thread Chris Forbes
From: Ilia Mirkin imir...@alum.mit.edu Tessellation control outputs can be read in directly without first having been written. Accessing these will require some special logic anyways, so just let them through. Signed-off-by: Ilia Mirkin imir...@alum.mit.edu --- src/glsl/ir_optimization.h

[Mesa-dev] [RFC PATCH 48/56] glsl: Support patch variables in varying packing

2014-09-20 Thread Chris Forbes
--- src/glsl/lower_packed_varyings.cpp | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/src/glsl/lower_packed_varyings.cpp b/src/glsl/lower_packed_varyings.cpp index 41ce8f4..d601836 100644 --- a/src/glsl/lower_packed_varyings.cpp +++

[Mesa-dev] [RFC PATCH 49/56] glsl: Analyze TES usage of gl_ClipDistance

2014-09-20 Thread Chris Forbes
--- src/glsl/linker.cpp| 19 +++ src/mesa/main/mtypes.h | 7 +++ 2 files changed, 26 insertions(+) diff --git a/src/glsl/linker.cpp b/src/glsl/linker.cpp index 7721d78..1dde5cc 100644 --- a/src/glsl/linker.cpp +++ b/src/glsl/linker.cpp @@ -629,6 +629,17 @@

[Mesa-dev] [RFC PATCH 33/56] glsl: Don't lower indexing with gl_InvocationID in the TCS to cond assign

2014-09-20 Thread Chris Forbes
From: Fabian Bieler fabianbie...@fastmail.fm --- src/glsl/ir_optimization.h | 5 +-- src/glsl/lower_variable_index_to_cond_assign.cpp | 39 src/glsl/test_optpass.cpp| 3 +- src/mesa/drivers/dri/i965/brw_shader.cpp |

[Mesa-dev] [RFC PATCH 42/56] glsl: make gl_PatchVerticesIn a system value

2014-09-20 Thread Chris Forbes
From: Ilia Mirkin imir...@alum.mit.edu Signed-off-by: Ilia Mirkin imir...@alum.mit.edu --- src/glsl/builtin_variables.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/glsl/builtin_variables.cpp b/src/glsl/builtin_variables.cpp index 5c363b8..a0befbd 100644 ---

[Mesa-dev] [RFC PATCH 37/56] glsl: Add builtin constants for ARB_tessellation_shader

2014-09-20 Thread Chris Forbes
--- src/glsl/builtin_variables.cpp | 16 src/glsl/glsl_parser_extras.cpp | 11 +++ src/glsl/glsl_parser_extras.h | 11 +++ 3 files changed, 38 insertions(+) diff --git a/src/glsl/builtin_variables.cpp b/src/glsl/builtin_variables.cpp index 0909818..5c363b8

[Mesa-dev] [RFC PATCH 38/56] glsl: more implicit sizing probably junk

2014-09-20 Thread Chris Forbes
--- src/glsl/ast_array_index.cpp | 17 +++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/src/glsl/ast_array_index.cpp b/src/glsl/ast_array_index.cpp index 1ad8361..e0110fe 100644 --- a/src/glsl/ast_array_index.cpp +++ b/src/glsl/ast_array_index.cpp @@ -107,9 +107,22

[Mesa-dev] [RFC PATCH 51/56] glsl: Add builtin barrier() function

2014-09-20 Thread Chris Forbes
--- src/glsl/builtin_functions.cpp | 17 + 1 file changed, 17 insertions(+) diff --git a/src/glsl/builtin_functions.cpp b/src/glsl/builtin_functions.cpp index 9be7f6d..f502105 100644 --- a/src/glsl/builtin_functions.cpp +++ b/src/glsl/builtin_functions.cpp @@ -99,6 +99,12 @@

[Mesa-dev] [RFC PATCH 52/56] glsl: Validate restrictions on use of barrier()

2014-09-20 Thread Chris Forbes
With the exception of always-taken switch cases (which are indistinguishable from straight line code in our IR), this disallows use of the builtin barrier() function in all the places it may not appear. Signed-off-by: Chris Forbes chr...@ijw.co.nz --- src/glsl/linker.cpp | 99

[Mesa-dev] [RFC PATCH 45/56] glsl: Support patch variables in ir_set_program_inouts

2014-09-20 Thread Chris Forbes
--- src/glsl/ir_set_program_inouts.cpp | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/src/glsl/ir_set_program_inouts.cpp b/src/glsl/ir_set_program_inouts.cpp index 91c7ba3..eadc9c7 100644 --- a/src/glsl/ir_set_program_inouts.cpp +++

[Mesa-dev] [RFC PATCH 47/56] glsl: support separate vertex count for producer when linking

2014-09-20 Thread Chris Forbes
Before tessellation, the only special case was linking VS - GS, where the VS has one output vertex and the GS has N input vertices. Now we also get to deal with the TCS - TES linking, where both sides are arrays of vertices. --- src/glsl/ir_optimization.h | 2 +-

[Mesa-dev] [RFC PATCH 43/56] glsl: Require tess input/output blocks to be arrays

2014-09-20 Thread Chris Forbes
--- src/glsl/ast_to_hir.cpp | 21 + 1 file changed, 17 insertions(+), 4 deletions(-) diff --git a/src/glsl/ast_to_hir.cpp b/src/glsl/ast_to_hir.cpp index 91c54d5..3a8c18f 100644 --- a/src/glsl/ast_to_hir.cpp +++ b/src/glsl/ast_to_hir.cpp @@ -5737,8 +5737,18 @@

[Mesa-dev] [RFC PATCH 54/56] glsl: fix linker with no tcs

2014-09-20 Thread Chris Forbes
--- src/glsl/linker.cpp | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/src/glsl/linker.cpp b/src/glsl/linker.cpp index cb27746..c1e9063 100644 --- a/src/glsl/linker.cpp +++ b/src/glsl/linker.cpp @@ -2164,16 +2164,22 @@ update_array_sizes(struct

[Mesa-dev] [RFC PATCH 50/56] glsl: Add ir node for barrier

2014-09-20 Thread Chris Forbes
--- src/glsl/ir.h | 24 src/glsl/ir_hierarchical_visitor.cpp | 9 + src/glsl/ir_hierarchical_visitor.h | 1 + src/glsl/ir_hv_accept.cpp | 6 ++ src/glsl/ir_print_visitor.cpp

[Mesa-dev] [RFC PATCH 53/56] glsl: Allow redeclaration of TCS gl_out[]

2014-09-20 Thread Chris Forbes
Signed-off-by: Chris Forbes chr...@ijw.co.nz --- src/glsl/ast_to_hir.cpp | 20 1 file changed, 16 insertions(+), 4 deletions(-) diff --git a/src/glsl/ast_to_hir.cpp b/src/glsl/ast_to_hir.cpp index 3a8c18f..ac075d8 100644 --- a/src/glsl/ast_to_hir.cpp +++ b/src/glsl

[Mesa-dev] [RFC PATCH 56/56] glsl: allow indexing of gl_out with gl_InvocationID even if length not known

2014-09-20 Thread Chris Forbes
Not all shaders are required to declare the output size; writing our outputs doesn't require the output size to be known, so don't require it. --- src/glsl/ast_array_index.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/glsl/ast_array_index.cpp

[Mesa-dev] [RFC PATCH 55/56] glsl: Account for extra level of arrayness when linking VS-TES

2014-09-20 Thread Chris Forbes
--- src/glsl/link_interface_blocks.cpp | 4 +++- src/glsl/link_varyings.cpp | 11 --- 2 files changed, 11 insertions(+), 4 deletions(-) diff --git a/src/glsl/link_interface_blocks.cpp b/src/glsl/link_interface_blocks.cpp index b97cb95..d575b1f 100644 ---

Re: [Mesa-dev] [RFC PATCH 00/56] ARB_tessellation_shader for core mesa

2014-09-20 Thread Chris Forbes
Also available in my git repo, as the series is huge: https://github.com/chrisforbes/mesa/tree/tess-core-v1 On Sun, Sep 21, 2014 at 1:40 PM, Chris Forbes chr...@ijw.co.nz wrote: This series adds all the driver-independent bits for ARB_tessellation_shader. It's not quite finished

Re: [Mesa-dev] [RFC PATCH 03/56] mesa/main: Add tessellation shader structs

2014-09-20 Thread Chris Forbes
+struct gl_tess_eval_program_state +{ + GLboolean Enabled; /** GL_ARB_TESSELLATION_SHADER */ + GLboolean _Enabled; /** Enabled and valid program? */ + struct gl_tess_eval_program *Current; /** user-bound tessellation control program */ Will

Re: [Piglit] [PATCH] arb_gpu_shader_fp64: vs-out-fs-in-double.shader_test fix

2014-09-19 Thread Chris Forbes
Reviewed-by: Chris Forbes chr...@ijw.co.nz On Fri, Sep 19, 2014 at 5:55 PM, Tapani Pälli tapani.pa...@intel.com wrote: Set 'flat' interpolation qualifier for double precision input variable as defined by the GL_ARB_gpu_shader_fp64 spec: This extension does not support interpolation

[Piglit] [PATCH] arb_copy_image: Skip if sample count is not supported

2014-09-19 Thread Chris Forbes
Signed-off-by: Chris Forbes chr...@ijw.co.nz --- tests/spec/arb_copy_image/formats.c | 8 1 file changed, 8 insertions(+) diff --git a/tests/spec/arb_copy_image/formats.c b/tests/spec/arb_copy_image/formats.c index a58580d..92715ba 100644 --- a/tests/spec/arb_copy_image/formats.c +++ b

Re: [Piglit] [PATCH] all.py: Correctly added 'invalid formats' test in oes_compressed_paletted_texture

2014-09-19 Thread Chris Forbes
Reviewed-by: Chris Forbes chr...@ijw.co.nz On Sat, Sep 20, 2014 at 12:10 AM, Pavel Popov pavel.e.po...@intel.com wrote: The group oes_compressed_paletted_texture is defined twice in all.py. Test 'invalid formats' isn't added in test list because this group is overridden. Signed-off

Mesa (master): i965/gen6: Enable GL 3.3 and GLSL 3.30

2014-09-19 Thread Chris Forbes
Module: Mesa Branch: master Commit: c4ed6c730f5fab03e19bf009d1ed85da3fd966db URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=c4ed6c730f5fab03e19bf009d1ed85da3fd966db Author: Chris Forbes chr...@ijw.co.nz Date: Sat Sep 20 10:39:37 2014 +1200 i965/gen6: Enable GL 3.3 and GLSL 3.30

[Mesa-dev] [PATCH] i965/gen6: Enable GL 3.3 and GLSL 3.30

2014-09-19 Thread Chris Forbes
Tested on my snb-gt2: 4 tests skip-pass in spec/EXT_texture_array 51 tests skip-pass in spec.glsl-3.30 4 tests skip-pass in spec/!OpenGL 3.3 No regressions; no skip-fail changes. Signed-off-by: Chris Forbes chr...@ijw.co.nz --- Had the gen6 machine out anyway to try some other things; may

Re: [Piglit] [PATCH v2] arb_gs5: add nonconst sampler access tests

2014-09-18 Thread Chris Forbes
Reviewed-by: Chris Forbes chr...@ijw.co.nz On Thu, Sep 18, 2014 at 6:10 PM, Ilia Mirkin imir...@alum.mit.edu wrote: These test some of the annoying cases of fermi/kepler instruction encodings. Signed-off-by: Ilia Mirkin imir...@alum.mit.edu --- v1 - v2: - proj - grad in filename

[Piglit] [PATCH 05/12] generated_tests: Test tessellation evaluation shader input.

2014-09-17 Thread Chris Forbes
From: Fabian Bieler fabianbie...@fastmail.fm For every GLSL variable type, generate four tests. One passes a per-vertex and one a per-patch varying of said type as a scalar from the tessellation control to the tessellation evaluation shader. The two other tests do the same for a two-element array

[Piglit] [PATCH 04/12] gen_builtin_uniform_tests.py: Add tessellation control shader tests.

2014-09-17 Thread Chris Forbes
From: Fabian Bieler fabianbie...@fastmail.fm --- generated_tests/gen_builtin_uniform_tests.py | 129 ++- 1 file changed, 125 insertions(+), 4 deletions(-) diff --git a/generated_tests/gen_builtin_uniform_tests.py b/generated_tests/gen_builtin_uniform_tests.py index

[Piglit] [PATCH 07/12] built-in-constants: Fix shader template for TCS.

2014-09-17 Thread Chris Forbes
Previously this tried to assign vec4 to float, and would fail there rather than testing anything useful. Signed-off-by: Chris Forbes chr...@ijw.co.nz --- tests/shaders/built-in-constants.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/shaders/built-in-constants.c b

[Piglit] [PATCH 09/12] arb_tessellation_shader: Test array requirements for inputs and outputs

2014-09-17 Thread Chris Forbes
Signed-off-by: Chris Forbes chr...@ijw.co.nz --- .../compiler/input-block-must-be-array-unnamed.tesc | 16 .../compiler/input-block-must-be-array-unnamed.tese | 16 .../compiler/input-block-must-be-array.tesc | 14

[Piglit] [PATCH 03/12] arb_tessellation_shader: Test global layout qualifiers.

2014-09-17 Thread Chris Forbes
From: Fabian Bieler fabianbie...@fastmail.fm Test declaring layout qualifiers in multiple shader objects and check for linking arrays if qualifiers mismatch. --- tests/all.py | 1 + .../spec/arb_tessellation_shader/CMakeLists.gl.txt | 1 +

[Piglit] [PATCH 01/12] arb_tessellation_shader: Add sanity shader_runner test.

2014-09-17 Thread Chris Forbes
redundant with nop.shader_test, but the approach in the tessellation evaluation shader is more normal (weighted sum of vertices) so both are useful. Reviewed-by: Chris Forbes chr...@ijw.co.nz --- .../execution/sanity.shader_test | 55 ++ 1 file changed, 55

[Piglit] [PATCH 12/12] arb_tessellation_shader: Add tests for gl_out[] redeclaration

2014-09-17 Thread Chris Forbes
Signed-off-by: Chris Forbes chr...@ijw.co.nz --- .../compiler/redeclaring-gl_out-junk-member.tesc| 13 + .../compiler/redeclaring-gl_out-must-be-array.tesc | 12 .../compiler/redeclaring-gl_out-no-instance-name.tesc | 12

[Piglit] [PATCH 11/12] arb_tessellation_shader: split barrier-switch test

2014-09-17 Thread Chris Forbes
Signed-off-by: Chris Forbes chr...@ijw.co.nz --- .../compiler/barrier-switch-always.tesc| 43 ++ .../compiler/barrier-switch.tesc | 2 + 2 files changed, 45 insertions(+) create mode 100644 tests/spec/arb_tessellation_shader/compiler/barrier

[Piglit] [PATCH 08/12] arb_tessellation_shader: Add tests for TCS output l-value indexing

2014-09-17 Thread Chris Forbes
Signed-off-by: Chris Forbes chr...@ijw.co.nz --- .../compiler/custom-block-out-indexing-const.tesc | 24 + .../compiler/custom-out-indexing-const.tesc| 22 +++ .../compiler/custom-out-indexing-strict.tesc | 25 ++ .../compiler

[Piglit] [PATCH 10/12] arb_tessellation_shader: test that redeclared barrier() is unrestricted

2014-09-17 Thread Chris Forbes
Signed-off-by: Chris Forbes chr...@ijw.co.nz --- .../compiler/barrier-redeclared.tesc | 44 ++ 1 file changed, 44 insertions(+) create mode 100644 tests/spec/arb_tessellation_shader/compiler/barrier-redeclared.tesc diff --git a/tests/spec

[Piglit] [PATCH] arb_tessellation_shader: Add test for unsized array with 2 shaders

2014-09-17 Thread Chris Forbes
Signed-off-by: Chris Forbes chr...@ijw.co.nz --- ...utput-size-declared-in-other-shader.shader_test | 52 ++ 1 file changed, 52 insertions(+) create mode 100644 tests/spec/arb_tessellation_shader/linker/tcs-output-size-declared-in-other-shader.shader_test diff --git

Re: [Piglit] [PATCH 02/11] glsl-1.50: Actually test row-major vs. column-major

2014-09-16 Thread Chris Forbes
Are you sure? Previously, if the data had been stored in the wrong orientation, you should have got (0.25, 0.75, 0.5, 1) due to the 0.5 and 0.75 being off the diagonal. (Or I've completely misunderstood something...) On Tue, Sep 9, 2014 at 9:34 AM, Ian Romanick i...@freedesktop.org wrote:

Mesa (master): glsl: fix error message for redeclaring gl_PerVertex as output

2014-09-16 Thread Chris Forbes
Module: Mesa Branch: master Commit: b84c02f9cdcc23ecff7f21df28a827f71be9e5fd URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=b84c02f9cdcc23ecff7f21df28a827f71be9e5fd Author: Chris Forbes chr...@ijw.co.nz Date: Tue Sep 9 19:55:29 2014 +1200 glsl: fix error message for redeclaring

Mesa (master): i965/vec4: slightly improve insn dumping with no srcs

2014-09-16 Thread Chris Forbes
Module: Mesa Branch: master Commit: 667f758788f0796d9be16f0f361022d447f622f5 URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=667f758788f0796d9be16f0f361022d447f622f5 Author: Chris Forbes chr...@ijw.co.nz Date: Tue Sep 9 19:55:28 2014 +1200 i965/vec4: slightly improve insn dumping

Re: [Piglit] [PATCH V3] gl-4.4: Test GL_MAX_VERTEX_ATTRIB_STRIDE

2014-09-12 Thread Chris Forbes
Yep, Reviewed-by: Chris Forbes chr...@ijw.co.nz On Sat, Sep 13, 2014 at 3:03 AM, Timothy Arceri t_arc...@yahoo.com.au wrote: Hey guys, Are you happy enough with this version to give a rb I'd like to commit this now that the Mesa changes are in. Thanks, Tim On Fri, 2014-08-15 at 16:56

Re: [Piglit] [PATCH 0/3] More UBO tests

2014-09-12 Thread Chris Forbes
Reviewed-by: Chris Forbes chr...@ijw.co.nz On Sep 11, 2014 10:17 AM, Ian Romanick i...@freedesktop.org wrote: These are all tests derived from failing tests generated by my test generator. These all have associated bugs. ___ Piglit mailing list

Re: [Mesa-dev] [Mesa-stable] [PATCH 1/2] i965: Skip allocating UNIFORM file storage for uniforms of size 0.

2014-09-12 Thread Chris Forbes
Ken, All looks pretty sensible to me. It won't break the sampler indexing stuff. - Chris ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] Copy Layered field in reuse_framebuffer_texture_attachment

2014-09-11 Thread Chris Forbes
It would be good to also have a piglit test which demonstrates this bad behavior. Patch is: Reviewed-by: Chris Forbes chr...@ijw.co.nz On Fri, Sep 12, 2014 at 9:42 AM, Vincent Lejeune v...@ovi.com wrote: Fix #83596 https://bugs.freedesktop.org/show_bug.cgi?id=83596 --- src/mesa/main

[Mesa-dev] [PATCH 2/2] glsl: fix error message for redeclaring gl_PerVertex as output

2014-09-09 Thread Chris Forbes
--- src/glsl/ast_to_hir.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/glsl/ast_to_hir.cpp b/src/glsl/ast_to_hir.cpp index 897505c..62122b7 100644 --- a/src/glsl/ast_to_hir.cpp +++ b/src/glsl/ast_to_hir.cpp @@ -5455,7 +5455,7 @@ ast_interface_block::hir(exec_list

[Mesa-dev] [PATCH 1/2] i965/vec4: slightly improve insn dumping with no srcs

2014-09-09 Thread Chris Forbes
Previously, we would get a trailing ', ' which looked strange. Signed-off-by: Chris Forbes chr...@ijw.co.nz --- src/mesa/drivers/dri/i965/brw_vec4.cpp | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_vec4.cpp b/src/mesa/drivers/dri/i965

Re: [Piglit] [PATCH] arb_gpu_shader_fp64: 420pack uniform initializer tests for double

2014-09-08 Thread Chris Forbes
. With these fixed, plus the [require] section fixed as per Matt's first comment, Reviewed-by: Chris Forbes chr...@ijw.co.nz ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit

Re: [Piglit] [PATCH 2/2] tests/all.py: fix built-in-constants arb_tessalation

2014-09-08 Thread Chris Forbes
Reviewed-by: Chris Forbes chr...@ijw.co.nz On Tue, Sep 9, 2014 at 5:06 PM, Dylan Baker baker.dyla...@gmail.com wrote: This test takes an argument that is not a path, and this path is provided as a relative one. This works fine if piglit is run from the piglit git tree root dir

Re: [Mesa-dev] [PATCH] Add support for NV_depth_buffer_float v2.

2014-09-08 Thread Chris Forbes
Given that this was an unintentional relaxation in the 4.2 spec (and so there is no non-NV way to invoke this behavior), I don't think we want the line in the 4.2 block of GL3.txt. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org

Re: [Mesa-dev] i965 CS state tracking

2014-09-03 Thread Chris Forbes
On Thu, Sep 4, 2014 at 7:20 AM, Kenneth Graunke kenn...@whitecape.org wrote: I know that you can link together VS/GS/FS/HS/DS and CS together in a single GLSL linked program, and it just uses the 3D shaders or the compute shader depending whether you use glDraw* or glDispatchCompute. So, if

Re: [Piglit] [PATCH] arb_gpu_shader_fp64: uniform initializer tests for double

2014-09-02 Thread Chris Forbes
Reviewed-by: Chris Forbes chr...@ijw.co.nz You might also want some for 420pack-style initializers, since we support that everywhere we'll support doubles. On Tue, Sep 2, 2014 at 11:57 PM, Tapani Pälli tapani.pa...@intel.com wrote: Signed-off-by: Tapani Pälli tapani.pa...@intel.com

Re: [Piglit] [PATCH] arb_explicit_uniform_location: lower GL and GLSL requirements

2014-09-02 Thread Chris Forbes
3.0 works for me. On Wed, Sep 3, 2014 at 5:48 PM, Tapani Pälli tapani.pa...@intel.com wrote: On 09/03/2014 08:41 AM, Matt Turner wrote: On Tue, Sep 2, 2014 at 10:00 PM, Tapani Pälli tapani.pa...@intel.com wrote: On 09/03/2014 01:07 AM, Matt Turner wrote: On Tue, Sep 2, 2014 at 1:32 AM, Tapani

Re: [Mesa-dev] [PATCH] i965: add missing parens in vec4 visitor

2014-09-01 Thread Chris Forbes
Oops. Reviewed-by: Chris Forbes chr...@ijw.co.nz On Tue, Sep 2, 2014 at 12:14 PM, Dave Airlie airl...@gmail.com wrote: From: Dave Airlie airl...@redhat.com coverity reported this, Matt said it look like missing parens, not bad identing, so lets try that. Signed-off-by: Dave Airlie airl

Re: [Piglit] [PATCH 04/11] arb_shader_subroutine: Add simple compiler tests for subroutines

2014-08-27 Thread Chris Forbes
, when they should not. On Thu, Aug 28, 2014 at 11:23 AM, Ian Romanick i...@freedesktop.org wrote: Have you tried these on any driver that supports the extension? On 08/10/2014 04:06 AM, Chris Forbes wrote: Signed-off-by: Chris Forbes chr...@ijw.co.nz --- .../arb_shader_subroutine/compiler

Re: [Piglit] [PATCH] arb_tessellation_shader: add compiler tests for barrier()

2014-08-27 Thread Chris Forbes
Reviewed-by: Chris Forbes chr...@ijw.co.nz On Thu, Aug 28, 2014 at 12:27 PM, Ilia Mirkin imir...@alum.mit.edu wrote: Signed-off-by: Ilia Mirkin imir...@alum.mit.edu --- barrier-return/switch/func fail on NVIDIA 340.32 -- apparently it's perfectly happy with them, despite what the spec

<    1   2   3   4   5   6   7   8   9   10   >