Re: [dm-devel] [PATCH 27/31] block: remove unused fmode_t arguments from ioctl handlers

2023-06-08 Thread Christian Brauner
On Tue, Jun 06, 2023 at 09:39:46AM +0200, Christoph Hellwig wrote: > A few ioctl handlers have fmode_t arguments that are entirely unused, > remove them. > > Signed-off-by: Christoph Hellwig > --- Looks good to me, Acked-by: Christian Brauner -- dm-devel mailing list dm-devel@r

Re: [dm-devel] [PATCH 24/31] rnbd-srv: replace sess->open_flags with a "bool readonly"

2023-06-08 Thread Christian Brauner
On Tue, Jun 06, 2023 at 09:39:43AM +0200, Christoph Hellwig wrote: > Stop passing the fmode_t around and just use a simple bool to track if > an export is read-only. > > Signed-off-by: Christoph Hellwig > --- Looks good to me, Acked-by: Christian Brauner -- dm-devel mailin

Re: [dm-devel] [PATCH 23/31] mtd: block: use a simple bool to track open for write

2023-06-08 Thread Christian Brauner
On Tue, Jun 06, 2023 at 09:39:42AM +0200, Christoph Hellwig wrote: > Instead of propagating the fmode_t, just use a bool to track if a mtd > block device was opened for writing. > > Signed-off-by: Christoph Hellwig > --- Looks good to me, Acked-by: Christian Brauner -- dm-dev

Re: [dm-devel] [PATCH 04/31] cdrom: remove the unused cdrom_close_write release code

2023-06-08 Thread Christian Brauner
On Tue, Jun 06, 2023 at 09:39:23AM +0200, Christoph Hellwig wrote: > cdrom_close_write is empty, and the for_data flag it is keyed off is > never set. Remove all this clutter. > > Signed-off-by: Christoph Hellwig > --- Looks good to me, Acked-by: Christian Brauner -- dm-devel

Re: [dm-devel] [PATCH 22/31] nvme: replace the fmode_t argument to the nvme ioctl handlers with a simple bool

2023-06-08 Thread Christian Brauner
od to me, Acked-by: Christian Brauner -- dm-devel mailing list dm-devel@redhat.com https://listman.redhat.com/mailman/listinfo/dm-devel

Re: [dm-devel] [PATCH 03/31] cdrom: remove the unused mode argument to cdrom_ioctl

2023-06-08 Thread Christian Brauner
On Tue, Jun 06, 2023 at 09:39:22AM +0200, Christoph Hellwig wrote: > Signed-off-by: Christoph Hellwig > --- Looks good to me, Acked-by: Christian Brauner -- dm-devel mailing list dm-devel@redhat.com https://listman.redhat.com/mailman/listinfo/dm-devel

Re: [dm-devel] [PATCH 14/31] rnbd-srv: don't pass a holder for non-exclusive blkdev_get_by_path

2023-06-08 Thread Christian Brauner
On Tue, Jun 06, 2023 at 09:39:33AM +0200, Christoph Hellwig wrote: > Passing a holder to blkdev_get_by_path when FMODE_EXCL isn't set doesn't > make sense, so pass NULL instead. > > Signed-off-by: Christoph Hellwig > --- Looks good to me, Acked-by: Christian Brauner -- dm-dev

Re: [dm-devel] [PATCH 29/31] block: always use I_BDEV on file->f_mapping->host to find the bdev

2023-06-08 Thread Christian Brauner
On Tue, Jun 06, 2023 at 09:39:48AM +0200, Christoph Hellwig wrote: > Always use I_BDEV(file->f_mapping->host) to find the bdev for a file to > free up file->private_data for other uses. > > Signed-off-by: Christoph Hellwig > --- Looks good to me, Acked-by: Christi

Re: [dm-devel] [PATCH 28/31] block: replace fmode_t with a block-specific type for block open flags

2023-06-08 Thread Christian Brauner
On Wed, Jun 07, 2023 at 11:21:24AM +0200, Christian Brauner wrote: > On Tue, Jun 06, 2023 at 09:39:47AM +0200, Christoph Hellwig wrote: > > The only overlap between the block open flags mapped into the fmode_t and > > other uses of fmode_t are FMODE_READ and FMODE_WRITE

Re: [dm-devel] [PATCH 19/31] scsi: replace the fmode_t argument to scsi_cmd_allowed with a simple bool

2023-06-08 Thread Christian Brauner
od to me, Acked-by: Christian Brauner -- dm-devel mailing list dm-devel@redhat.com https://listman.redhat.com/mailman/listinfo/dm-devel

Re: [dm-devel] [PATCH 06/31] cdrom: remove the unused mode argument to cdrom_release

2023-06-08 Thread Christian Brauner
On Tue, Jun 06, 2023 at 09:39:25AM +0200, Christoph Hellwig wrote: > Signed-off-by: Christoph Hellwig > --- Looks good to me, Acked-by: Christian Brauner -- dm-devel mailing list dm-devel@redhat.com https://listman.redhat.com/mailman/listinfo/dm-devel

Re: [dm-devel] [PATCH 01/31] block: also call ->open for incremental partition opens

2023-06-08 Thread Christian Brauner
> for ioctl only or NDELAY opens. > > Signed-off-by: Christoph Hellwig > --- This assumes that all drivers deal with additional ->open() calls for each partition correctly which I assumed you checked so, Acked-by: Christian Brauner -- dm-devel mailing list dm-devel@redhat.com

Re: [dm-devel] [PATCH 30/31] block: store the holder in file->private_data

2023-06-08 Thread Christian Brauner
> --- Feels a bit odd to store the object itself but anyway, Acked-by: Christian Brauner -- dm-devel mailing list dm-devel@redhat.com https://listman.redhat.com/mailman/listinfo/dm-devel

Re: [dm-devel] [PATCH 10/31] block: remove the unused mode argument to ->release

2023-06-08 Thread Christian Brauner
On Tue, Jun 06, 2023 at 09:39:29AM +0200, Christoph Hellwig wrote: > The mode argument to the ->release block_device_operation is never used, > so remove it. > > Signed-off-by: Christoph Hellwig > --- Good cleanup. Looks good to me, Acked-by: Christian Brauner -- dm-dev

Re: [dm-devel] [PATCH 16/31] block: use the holder as indication for exclusive opens

2023-06-08 Thread Christian Brauner
LL holder. > > For blkdev_put this requires adding the holder argument, which provides > better debug checking that only the holder actually releases the hold, > but at the same time allows removing the now superfluous mode argument. > > Signed-off-by: Christoph Hellwig > --- Looks g

Re: [dm-devel] [PATCH 08/31] block: share code between disk_check_media_change and disk_force_media_change

2023-06-08 Thread Christian Brauner
On Tue, Jun 06, 2023 at 09:39:27AM +0200, Christoph Hellwig wrote: > Factor the common logic between disk_check_media_change and > disk_force_media_change into a helper. > > Signed-off-by: Christoph Hellwig > --- Looks good to me, Acked-by: Christian Brauner -- dm-devel mailin

Re: [dm-devel] [PATCH 25/31] ubd: remove commented out code in ubd_open

2023-06-08 Thread Christian Brauner
On Tue, Jun 06, 2023 at 09:39:44AM +0200, Christoph Hellwig wrote: > This code has been dead forever, make sure it doesn't show up in code > searches. > > Signed-off-by: Christoph Hellwig > --- Looks good to me, Acked-by: Christian Brauner -- dm-devel mailing list dm-devel@r

Re: [dm-devel] [PATCH 28/31] block: replace fmode_t with a block-specific type for block open flags

2023-06-08 Thread Christian Brauner
On Tue, Jun 06, 2023 at 09:39:47AM +0200, Christoph Hellwig wrote: > The only overlap between the block open flags mapped into the fmode_t and > other uses of fmode_t are FMODE_READ and FMODE_WRITE. Define a new and FMODE_EXCL afaict > blk_mode_t instead for use in blkdev_get_by_*, ->open and

Re: [dm-devel] [PATCH 26/31] block: move a few internal definitions out of blkdev.h

2023-06-08 Thread Christian Brauner
On Tue, Jun 06, 2023 at 09:39:45AM +0200, Christoph Hellwig wrote: > All these helpers are only used in core block code, so move them out of > the public header. > > Signed-off-by: Christoph Hellwig > --- Looks good to me, Acked-by: Christian Brauner -- dm-devel mailin

Re: [dm-devel] [PATCH 15/31] btrfs: don't pass a holder for non-exclusive blkdev_get_by_path

2023-06-08 Thread Christian Brauner
ath calls. > > Signed-off-by: Christoph Hellwig > --- Looks good to me, Acked-by: Christian Brauner -- dm-devel mailing list dm-devel@redhat.com https://listman.redhat.com/mailman/listinfo/dm-devel

Re: [dm-devel] [PATCH 31/31] fs: remove the now unused FMODE_* flags

2023-06-08 Thread Christian Brauner
On Tue, Jun 06, 2023 at 09:39:50AM +0200, Christoph Hellwig wrote: > FMODE_NDELAY, FMODE_EXCL and FMODE_WRITE_IOCTL were only used for > block internal purposed and are now entirely unused, so remove them. > > Signed-off-by: Christoph Hellwig > --- Love it, Reviewed-by: Ch

Re: [dm-devel] decouple block open flags from fmode_t

2023-06-08 Thread Christian Brauner
On Tue, Jun 06, 2023 at 10:40:42AM +0200, Christoph Hellwig wrote: > On Tue, Jun 06, 2023 at 10:27:14AM +0200, Christian Brauner wrote: > > On Tue, Jun 06, 2023 at 09:39:19AM +0200, Christoph Hellwig wrote: > > > Hi all, > > > > > > this series adds a new blk

Re: [dm-devel] [PATCH 09/31] block: pass a gendisk to ->open

2023-06-08 Thread Christian Brauner
t; void (*release) (struct gendisk *, fmode_t); > int (*ioctl) (struct block_device *, fmode_t, unsigned, unsigned long); > int (*compat_ioctl) (struct block_device *, fmode_t, unsigned, unsigned > long); Looks good to me, Acked-by: Christian Brauner (I didn't bother going t

Re: [dm-devel] [PATCH 07/31] block: pass a gendisk on bdev_check_media_change

2023-06-08 Thread Christian Brauner
g > --- Under the assumption it did only in fact ever only get called on the whole device so far, Acked-by: Christian Brauner -- dm-devel mailing list dm-devel@redhat.com https://listman.redhat.com/mailman/listinfo/dm-devel

Re: [dm-devel] [PATCH 18/31] fs: remove sb->s_mode

2023-06-08 Thread Christian Brauner
On Tue, Jun 06, 2023 at 09:39:37AM +0200, Christoph Hellwig wrote: > There is no real need to store the open mode in the super_block now. > It is only used by f2fs, which can easily recalculate it. > > Signed-off-by: Christoph Hellwig > --- Looks good to me, Acked-by: Christian

Re: [dm-devel] [PATCH 11/31] block: rename blkdev_close to blkdev_release

2023-06-08 Thread Christian Brauner
On Tue, Jun 06, 2023 at 09:39:30AM +0200, Christoph Hellwig wrote: > Make the function name match the method name. > > Signed-off-by: Christoph Hellwig > --- Looks good to me, Acked-by: Christian Brauner -- dm-devel mailing list dm-devel@redhat.com https://listman.redhat.com/mail

Re: [dm-devel] [PATCH 21/31] scsi: replace the fmode_t argument to ->sg_io_fn with a simple bool

2023-06-08 Thread Christian Brauner
od to me, Acked-by: Christian Brauner -- dm-devel mailing list dm-devel@redhat.com https://listman.redhat.com/mailman/listinfo/dm-devel

Re: [dm-devel] [PATCH 20/31] scsi: replace the fmode_t argument to scsi_ioctl with a simple bool

2023-06-08 Thread Christian Brauner
od to me, Acked-by: Christian Brauner -- dm-devel mailing list dm-devel@redhat.com https://listman.redhat.com/mailman/listinfo/dm-devel

Re: [dm-devel] [PATCH 17/31] block: add a sb_open_mode helper

2023-06-08 Thread Christian Brauner
On Tue, Jun 06, 2023 at 09:39:36AM +0200, Christoph Hellwig wrote: > Add a helper to return the open flags for blkdev_get_by* for passed in > super block flags instead of open coding the logic in many places. > > Signed-off-by: Christoph Hellwig > --- Looks good to me, Acke

Re: [dm-devel] [PATCH 02/31] cdrom: remove the unused bdev argument to cdrom_open

2023-06-08 Thread Christian Brauner
On Tue, Jun 06, 2023 at 09:39:21AM +0200, Christoph Hellwig wrote: > Signed-off-by: Christoph Hellwig > --- lgtm, Acked-by: Christian Brauner -- dm-devel mailing list dm-devel@redhat.com https://listman.redhat.com/mailman/listinfo/dm-devel

Re: [f2fs-dev] [PATCH 28/31] block: replace fmode_t with a block-specific type for block open flags

2023-06-07 Thread Christian Brauner
On Wed, Jun 07, 2023 at 02:16:58PM +0200, Christoph Hellwig wrote: > On Wed, Jun 07, 2023 at 11:21:14AM +0200, Christian Brauner wrote: > > On Tue, Jun 06, 2023 at 09:39:47AM +0200, Christoph Hellwig wrote: > > > The only overlap between the block open flags mapped into the fmode

Re: [f2fs-dev] [PATCH 28/31] block: replace fmode_t with a block-specific type for block open flags

2023-06-07 Thread Christian Brauner
On Wed, Jun 07, 2023 at 11:21:24AM +0200, Christian Brauner wrote: > On Tue, Jun 06, 2023 at 09:39:47AM +0200, Christoph Hellwig wrote: > > The only overlap between the block open flags mapped into the fmode_t and > > other uses of fmode_t are FMODE_READ and FMODE_WRITE

Re: [PATCH 28/31] block: replace fmode_t with a block-specific type for block open flags

2023-06-07 Thread Christian Brauner
On Wed, Jun 07, 2023 at 11:21:24AM +0200, Christian Brauner wrote: > On Tue, Jun 06, 2023 at 09:39:47AM +0200, Christoph Hellwig wrote: > > The only overlap between the block open flags mapped into the fmode_t and > > other uses of fmode_t are FMODE_READ and FMODE_WRITE

Re: [f2fs-dev] decouple block open flags from fmode_t

2023-06-07 Thread Christian Brauner
On Tue, Jun 06, 2023 at 10:40:42AM +0200, Christoph Hellwig wrote: > On Tue, Jun 06, 2023 at 10:27:14AM +0200, Christian Brauner wrote: > > On Tue, Jun 06, 2023 at 09:39:19AM +0200, Christoph Hellwig wrote: > > > Hi all, > > > > > > this series adds a new blk

Re: decouple block open flags from fmode_t

2023-06-07 Thread Christian Brauner
On Tue, Jun 06, 2023 at 10:40:42AM +0200, Christoph Hellwig wrote: > On Tue, Jun 06, 2023 at 10:27:14AM +0200, Christian Brauner wrote: > > On Tue, Jun 06, 2023 at 09:39:19AM +0200, Christoph Hellwig wrote: > > > Hi all, > > > > > > this series adds a new blk

Re: [f2fs-dev] [PATCH 31/31] fs: remove the now unused FMODE_* flags

2023-06-07 Thread Christian Brauner
On Tue, Jun 06, 2023 at 09:39:50AM +0200, Christoph Hellwig wrote: > FMODE_NDELAY, FMODE_EXCL and FMODE_WRITE_IOCTL were only used for > block internal purposed and are now entirely unused, so remove them. > > Signed-off-by: Christoph Hellwig > --- Love it, Reviewed-by: Ch

Re: [PATCH 31/31] fs: remove the now unused FMODE_* flags

2023-06-07 Thread Christian Brauner
On Tue, Jun 06, 2023 at 09:39:50AM +0200, Christoph Hellwig wrote: > FMODE_NDELAY, FMODE_EXCL and FMODE_WRITE_IOCTL were only used for > block internal purposed and are now entirely unused, so remove them. > > Signed-off-by: Christoph Hellwig > --- Love it, Reviewed-by: Ch

Re: [f2fs-dev] [PATCH 30/31] block: store the holder in file->private_data

2023-06-07 Thread Christian Brauner
> --- Feels a bit odd to store the object itself but anyway, Acked-by: Christian Brauner ___ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

Re: [PATCH 30/31] block: store the holder in file->private_data

2023-06-07 Thread Christian Brauner
> --- Feels a bit odd to store the object itself but anyway, Acked-by: Christian Brauner ___ linux-um mailing list linux-um@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-um

Re: [f2fs-dev] [PATCH 29/31] block: always use I_BDEV on file->f_mapping->host to find the bdev

2023-06-07 Thread Christian Brauner
On Tue, Jun 06, 2023 at 09:39:48AM +0200, Christoph Hellwig wrote: > Always use I_BDEV(file->f_mapping->host) to find the bdev for a file to > free up file->private_data for other uses. > > Signed-off-by: Christoph Hellwig > --- Looks good to me, Ack

Re: [PATCH 29/31] block: always use I_BDEV on file->f_mapping->host to find the bdev

2023-06-07 Thread Christian Brauner
On Tue, Jun 06, 2023 at 09:39:48AM +0200, Christoph Hellwig wrote: > Always use I_BDEV(file->f_mapping->host) to find the bdev for a file to > free up file->private_data for other uses. > > Signed-off-by: Christoph Hellwig > --- Looks good to me, Ack

Re: [f2fs-dev] [PATCH 28/31] block: replace fmode_t with a block-specific type for block open flags

2023-06-07 Thread Christian Brauner
On Tue, Jun 06, 2023 at 09:39:47AM +0200, Christoph Hellwig wrote: > The only overlap between the block open flags mapped into the fmode_t and > other uses of fmode_t are FMODE_READ and FMODE_WRITE. Define a new and FMODE_EXCL afaict > blk_mode_t instead for use in blkdev_get_by_*, ->open and

Re: [PATCH 28/31] block: replace fmode_t with a block-specific type for block open flags

2023-06-07 Thread Christian Brauner
On Tue, Jun 06, 2023 at 09:39:47AM +0200, Christoph Hellwig wrote: > The only overlap between the block open flags mapped into the fmode_t and > other uses of fmode_t are FMODE_READ and FMODE_WRITE. Define a new and FMODE_EXCL afaict > blk_mode_t instead for use in blkdev_get_by_*, ->open and

Re: [f2fs-dev] [PATCH 27/31] block: remove unused fmode_t arguments from ioctl handlers

2023-06-07 Thread Christian Brauner
On Tue, Jun 06, 2023 at 09:39:46AM +0200, Christoph Hellwig wrote: > A few ioctl handlers have fmode_t arguments that are entirely unused, > remove them. > > Signed-off-by: Christoph Hellwig > --- Looks good to me, Acked-by: Ch

Re: [f2fs-dev] [PATCH 26/31] block: move a few internal definitions out of blkdev.h

2023-06-07 Thread Christian Brauner
On Tue, Jun 06, 2023 at 09:39:45AM +0200, Christoph Hellwig wrote: > All these helpers are only used in core block code, so move them out of > the public header. > > Signed-off-by: Christoph Hellwig > --- Looks good to me, Acked-by: Ch

Re: [PATCH 27/31] block: remove unused fmode_t arguments from ioctl handlers

2023-06-07 Thread Christian Brauner
On Tue, Jun 06, 2023 at 09:39:46AM +0200, Christoph Hellwig wrote: > A few ioctl handlers have fmode_t arguments that are entirely unused, > remove them. > > Signed-off-by: Christoph Hellwig > --- Looks good to me, Acked-by: Ch

Re: [PATCH 26/31] block: move a few internal definitions out of blkdev.h

2023-06-07 Thread Christian Brauner
On Tue, Jun 06, 2023 at 09:39:45AM +0200, Christoph Hellwig wrote: > All these helpers are only used in core block code, so move them out of > the public header. > > Signed-off-by: Christoph Hellwig > --- Looks good to me, Acked-by: Ch

Re: [f2fs-dev] [PATCH 25/31] ubd: remove commented out code in ubd_open

2023-06-07 Thread Christian Brauner
On Tue, Jun 06, 2023 at 09:39:44AM +0200, Christoph Hellwig wrote: > This code has been dead forever, make sure it doesn't show up in code > searches. > > Signed-off-by: Christoph Hellwig > --- Looks good to me, Acked-by: Ch

Re: [PATCH 25/31] ubd: remove commented out code in ubd_open

2023-06-07 Thread Christian Brauner
On Tue, Jun 06, 2023 at 09:39:44AM +0200, Christoph Hellwig wrote: > This code has been dead forever, make sure it doesn't show up in code > searches. > > Signed-off-by: Christoph Hellwig > --- Looks good to me, Acked-by: Christian Brauner __

Re: [f2fs-dev] [PATCH 24/31] rnbd-srv: replace sess->open_flags with a "bool readonly"

2023-06-07 Thread Christian Brauner
On Tue, Jun 06, 2023 at 09:39:43AM +0200, Christoph Hellwig wrote: > Stop passing the fmode_t around and just use a simple bool to track if > an export is read-only. > > Signed-off-by: Christoph Hellwig > --- Looks good to me, Acked-by: Ch

Re: [PATCH 24/31] rnbd-srv: replace sess->open_flags with a "bool readonly"

2023-06-07 Thread Christian Brauner
On Tue, Jun 06, 2023 at 09:39:43AM +0200, Christoph Hellwig wrote: > Stop passing the fmode_t around and just use a simple bool to track if > an export is read-only. > > Signed-off-by: Christoph Hellwig > --- Looks good to me, Acked-by: Ch

Re: [f2fs-dev] [PATCH 23/31] mtd: block: use a simple bool to track open for write

2023-06-07 Thread Christian Brauner
On Tue, Jun 06, 2023 at 09:39:42AM +0200, Christoph Hellwig wrote: > Instead of propagating the fmode_t, just use a bool to track if a mtd > block device was opened for writing. > > Signed-off-by: Christoph Hellwig > --- Looks good to me, Acked-by: Ch

Re: [PATCH 23/31] mtd: block: use a simple bool to track open for write

2023-06-07 Thread Christian Brauner
On Tue, Jun 06, 2023 at 09:39:42AM +0200, Christoph Hellwig wrote: > Instead of propagating the fmode_t, just use a bool to track if a mtd > block device was opened for writing. > > Signed-off-by: Christoph Hellwig > --- Looks good to me, Acked-by: Ch

Re: [f2fs-dev] [PATCH 22/31] nvme: replace the fmode_t argument to the nvme ioctl handlers with a simple bool

2023-06-07 Thread Christian Brauner
od to me, Acked-by: Christian Brauner ___ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

Re: [PATCH 22/31] nvme: replace the fmode_t argument to the nvme ioctl handlers with a simple bool

2023-06-07 Thread Christian Brauner
od to me, Acked-by: Christian Brauner ___ linux-um mailing list linux-um@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-um

Re: [f2fs-dev] [PATCH 21/31] scsi: replace the fmode_t argument to ->sg_io_fn with a simple bool

2023-06-07 Thread Christian Brauner
od to me, Acked-by: Christian Brauner ___ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

Re: [PATCH 21/31] scsi: replace the fmode_t argument to ->sg_io_fn with a simple bool

2023-06-07 Thread Christian Brauner
od to me, Acked-by: Christian Brauner ___ linux-um mailing list linux-um@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-um

Re: [f2fs-dev] [PATCH 20/31] scsi: replace the fmode_t argument to scsi_ioctl with a simple bool

2023-06-07 Thread Christian Brauner
od to me, Acked-by: Christian Brauner ___ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

Re: [f2fs-dev] [PATCH 19/31] scsi: replace the fmode_t argument to scsi_cmd_allowed with a simple bool

2023-06-07 Thread Christian Brauner
od to me, Acked-by: Christian Brauner ___ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

Re: [PATCH 20/31] scsi: replace the fmode_t argument to scsi_ioctl with a simple bool

2023-06-07 Thread Christian Brauner
od to me, Acked-by: Christian Brauner ___ linux-um mailing list linux-um@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-um

Re: [PATCH 19/31] scsi: replace the fmode_t argument to scsi_cmd_allowed with a simple bool

2023-06-07 Thread Christian Brauner
od to me, Acked-by: Christian Brauner ___ linux-um mailing list linux-um@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-um

Re: [f2fs-dev] [PATCH 18/31] fs: remove sb->s_mode

2023-06-07 Thread Christian Brauner
On Tue, Jun 06, 2023 at 09:39:37AM +0200, Christoph Hellwig wrote: > There is no real need to store the open mode in the super_block now. > It is only used by f2fs, which can easily recalculate it. > > Signed-off-by: Christoph Hellwig > --- Looks good to me, Acked-by: Ch

Re: [PATCH 18/31] fs: remove sb->s_mode

2023-06-07 Thread Christian Brauner
On Tue, Jun 06, 2023 at 09:39:37AM +0200, Christoph Hellwig wrote: > There is no real need to store the open mode in the super_block now. > It is only used by f2fs, which can easily recalculate it. > > Signed-off-by: Christoph Hellwig > --- Looks good to me, Acked-by: Ch

Re: [f2fs-dev] [PATCH 17/31] block: add a sb_open_mode helper

2023-06-07 Thread Christian Brauner
On Tue, Jun 06, 2023 at 09:39:36AM +0200, Christoph Hellwig wrote: > Add a helper to return the open flags for blkdev_get_by* for passed in > super block flags instead of open coding the logic in many places. > > Signed-off-by: Christoph Hellwig > --- Looks good to me, Acke

Re: [PATCH 17/31] block: add a sb_open_mode helper

2023-06-07 Thread Christian Brauner
On Tue, Jun 06, 2023 at 09:39:36AM +0200, Christoph Hellwig wrote: > Add a helper to return the open flags for blkdev_get_by* for passed in > super block flags instead of open coding the logic in many places. > > Signed-off-by: Christoph Hellwig > --- Looks good to me, Acke

Re: [f2fs-dev] [PATCH 16/31] block: use the holder as indication for exclusive opens

2023-06-07 Thread Christian Brauner
LL holder. > > For blkdev_put this requires adding the holder argument, which provides > better debug checking that only the holder actually releases the hold, > but at the same time allows removing the now superfluous mode argument. > > Signed-off-by: Christoph Hellwig > --- Looks g

Re: [PATCH 16/31] block: use the holder as indication for exclusive opens

2023-06-07 Thread Christian Brauner
LL holder. > > For blkdev_put this requires adding the holder argument, which provides > better debug checking that only the holder actually releases the hold, > but at the same time allows removing the now superfluous mode argument. > > Signed-off-by: Christoph Hellwig > --- Looks g

Re: [f2fs-dev] [PATCH 15/31] btrfs: don't pass a holder for non-exclusive blkdev_get_by_path

2023-06-07 Thread Christian Brauner
ath calls. > > Signed-off-by: Christoph Hellwig > --- Looks good to me, Acked-by: Christian Brauner ___ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

Re: [PATCH 15/31] btrfs: don't pass a holder for non-exclusive blkdev_get_by_path

2023-06-07 Thread Christian Brauner
ath calls. > > Signed-off-by: Christoph Hellwig > --- Looks good to me, Acked-by: Christian Brauner ___ linux-um mailing list linux-um@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-um

Re: [f2fs-dev] [PATCH 14/31] rnbd-srv: don't pass a holder for non-exclusive blkdev_get_by_path

2023-06-07 Thread Christian Brauner
On Tue, Jun 06, 2023 at 09:39:33AM +0200, Christoph Hellwig wrote: > Passing a holder to blkdev_get_by_path when FMODE_EXCL isn't set doesn't > make sense, so pass NULL instead. > > Signed-off-by: Christoph Hellwig > --- Looks good to me, Acked-by: Ch

Re: [PATCH 14/31] rnbd-srv: don't pass a holder for non-exclusive blkdev_get_by_path

2023-06-07 Thread Christian Brauner
On Tue, Jun 06, 2023 at 09:39:33AM +0200, Christoph Hellwig wrote: > Passing a holder to blkdev_get_by_path when FMODE_EXCL isn't set doesn't > make sense, so pass NULL instead. > > Signed-off-by: Christoph Hellwig > --- Looks good to me, Acked-by: Ch

Re: [f2fs-dev] [PATCH 11/31] block: rename blkdev_close to blkdev_release

2023-06-07 Thread Christian Brauner
On Tue, Jun 06, 2023 at 09:39:30AM +0200, Christoph Hellwig wrote: > Make the function name match the method name. > > Signed-off-by: Christoph Hellwig > --- Looks good to me, Acked-by: Christian Brauner ___ Linux-f2fs-devel mailing lis

Re: [f2fs-dev] [PATCH 10/31] block: remove the unused mode argument to ->release

2023-06-07 Thread Christian Brauner
On Tue, Jun 06, 2023 at 09:39:29AM +0200, Christoph Hellwig wrote: > The mode argument to the ->release block_device_operation is never used, > so remove it. > > Signed-off-by: Christoph Hellwig > --- Good cleanup. Looks good to me, Acked-by:

Re: [PATCH 11/31] block: rename blkdev_close to blkdev_release

2023-06-07 Thread Christian Brauner
On Tue, Jun 06, 2023 at 09:39:30AM +0200, Christoph Hellwig wrote: > Make the function name match the method name. > > Signed-off-by: Christoph Hellwig > --- Looks good to me, Acked-by: Christian Brauner ___ linux-um mailing l

Re: [f2fs-dev] [PATCH 09/31] block: pass a gendisk to ->open

2023-06-07 Thread Christian Brauner
t; void (*release) (struct gendisk *, fmode_t); > int (*ioctl) (struct block_device *, fmode_t, unsigned, unsigned long); > int (*compat_ioctl) (struct block_device *, fmode_t, unsigned, unsigned > long); Looks good to me, Acked-by: Christian Brauner (

Re: [PATCH 10/31] block: remove the unused mode argument to ->release

2023-06-07 Thread Christian Brauner
On Tue, Jun 06, 2023 at 09:39:29AM +0200, Christoph Hellwig wrote: > The mode argument to the ->release block_device_operation is never used, > so remove it. > > Signed-off-by: Christoph Hellwig > --- Good cleanup. Looks good to me, Acked-by:

Re: [PATCH 09/31] block: pass a gendisk to ->open

2023-06-07 Thread Christian Brauner
t; void (*release) (struct gendisk *, fmode_t); > int (*ioctl) (struct block_device *, fmode_t, unsigned, unsigned long); > int (*compat_ioctl) (struct block_device *, fmode_t, unsigned, unsigned > long); Looks good to me, Acked-by: Christian Brauner (

Re: [f2fs-dev] [PATCH 08/31] block: share code between disk_check_media_change and disk_force_media_change

2023-06-07 Thread Christian Brauner
On Tue, Jun 06, 2023 at 09:39:27AM +0200, Christoph Hellwig wrote: > Factor the common logic between disk_check_media_change and > disk_force_media_change into a helper. > > Signed-off-by: Christoph Hellwig > --- Looks good to me, Acked-by: Ch

Re: [PATCH 08/31] block: share code between disk_check_media_change and disk_force_media_change

2023-06-07 Thread Christian Brauner
On Tue, Jun 06, 2023 at 09:39:27AM +0200, Christoph Hellwig wrote: > Factor the common logic between disk_check_media_change and > disk_force_media_change into a helper. > > Signed-off-by: Christoph Hellwig > --- Looks good to me, Acked-by: Ch

Re: [f2fs-dev] [PATCH 07/31] block: pass a gendisk on bdev_check_media_change

2023-06-07 Thread Christian Brauner
g > --- Under the assumption it did only in fact ever only get called on the whole device so far, Acked-by: Christian Brauner ___ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

Re: [PATCH 07/31] block: pass a gendisk on bdev_check_media_change

2023-06-07 Thread Christian Brauner
g > --- Under the assumption it did only in fact ever only get called on the whole device so far, Acked-by: Christian Brauner ___ linux-um mailing list linux-um@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-um

Re: [f2fs-dev] [PATCH 06/31] cdrom: remove the unused mode argument to cdrom_release

2023-06-07 Thread Christian Brauner
On Tue, Jun 06, 2023 at 09:39:25AM +0200, Christoph Hellwig wrote: > Signed-off-by: Christoph Hellwig > --- Looks good to me, Acked-by: Christian Brauner ___ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net

Re: [f2fs-dev] [PATCH 05/31] cdrom: track if a cdrom_device_info was opened for data

2023-06-07 Thread Christian Brauner
as > nothing but the CDROM drivers uses that argument. > > Signed-off-by: Christoph Hellwig > --- Looks good to me, Acked-by: Christian Brauner ___ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.source

Re: [PATCH 06/31] cdrom: remove the unused mode argument to cdrom_release

2023-06-07 Thread Christian Brauner
On Tue, Jun 06, 2023 at 09:39:25AM +0200, Christoph Hellwig wrote: > Signed-off-by: Christoph Hellwig > --- Looks good to me, Acked-by: Christian Brauner ___ linux-um mailing list linux-um@lists.infradead.org http://lists.infradead.org/m

Re: [PATCH 05/31] cdrom: track if a cdrom_device_info was opened for data

2023-06-07 Thread Christian Brauner
as > nothing but the CDROM drivers uses that argument. > > Signed-off-by: Christoph Hellwig > --- Looks good to me, Acked-by: Christian Brauner ___ linux-um mailing list linux-um@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-um

Re: [f2fs-dev] [PATCH 04/31] cdrom: remove the unused cdrom_close_write release code

2023-06-07 Thread Christian Brauner
On Tue, Jun 06, 2023 at 09:39:23AM +0200, Christoph Hellwig wrote: > cdrom_close_write is empty, and the for_data flag it is keyed off is > never set. Remove all this clutter. > > Signed-off-by: Christoph Hellwig > --- Looks good to me, Acked-by: Ch

Re: [PATCH 04/31] cdrom: remove the unused cdrom_close_write release code

2023-06-07 Thread Christian Brauner
On Tue, Jun 06, 2023 at 09:39:23AM +0200, Christoph Hellwig wrote: > cdrom_close_write is empty, and the for_data flag it is keyed off is > never set. Remove all this clutter. > > Signed-off-by: Christoph Hellwig > --- Looks good to me, Acked-by: Ch

Re: [f2fs-dev] [PATCH 03/31] cdrom: remove the unused mode argument to cdrom_ioctl

2023-06-07 Thread Christian Brauner
On Tue, Jun 06, 2023 at 09:39:22AM +0200, Christoph Hellwig wrote: > Signed-off-by: Christoph Hellwig > --- Looks good to me, Acked-by: Christian Brauner ___ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net

Re: [f2fs-dev] [PATCH 02/31] cdrom: remove the unused bdev argument to cdrom_open

2023-06-07 Thread Christian Brauner
On Tue, Jun 06, 2023 at 09:39:21AM +0200, Christoph Hellwig wrote: > Signed-off-by: Christoph Hellwig > --- lgtm, Acked-by: Christian Brauner ___ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourcefor

Re: [PATCH 03/31] cdrom: remove the unused mode argument to cdrom_ioctl

2023-06-07 Thread Christian Brauner
On Tue, Jun 06, 2023 at 09:39:22AM +0200, Christoph Hellwig wrote: > Signed-off-by: Christoph Hellwig > --- Looks good to me, Acked-by: Christian Brauner ___ linux-um mailing list linux-um@lists.infradead.org http://lists.infradead.org/m

Re: [PATCH 02/31] cdrom: remove the unused bdev argument to cdrom_open

2023-06-07 Thread Christian Brauner
On Tue, Jun 06, 2023 at 09:39:21AM +0200, Christoph Hellwig wrote: > Signed-off-by: Christoph Hellwig > --- lgtm, Acked-by: Christian Brauner ___ linux-um mailing list linux-um@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-um

Re: [f2fs-dev] [PATCH 01/31] block: also call ->open for incremental partition opens

2023-06-07 Thread Christian Brauner
> for ioctl only or NDELAY opens. > > Signed-off-by: Christoph Hellwig > --- This assumes that all drivers deal with additional ->open() calls for each partition correctly which I assumed you checked so, Acked-by: Christian Brauner _

Re: [PATCH 01/31] block: also call ->open for incremental partition opens

2023-06-07 Thread Christian Brauner
> for ioctl only or NDELAY opens. > > Signed-off-by: Christoph Hellwig > --- This assumes that all drivers deal with additional ->open() calls for each partition correctly which I assumed you checked so, Acked-by: Christian Brauner ___

Re: [dm-devel] decouple block open flags from fmode_t

2023-06-07 Thread Christian Brauner
On Tue, Jun 06, 2023 at 09:39:19AM +0200, Christoph Hellwig wrote: > Hi all, > > this series adds a new blk_mode_t for block open flags instead of abusing Trying to look at this series applied but doesn't apply cleanly for anything v6.4-rc* related. What tree is this on? -- dm-devel mailing

Re: [f2fs-dev] decouple block open flags from fmode_t

2023-06-06 Thread Christian Brauner
On Tue, Jun 06, 2023 at 09:39:19AM +0200, Christoph Hellwig wrote: > Hi all, > > this series adds a new blk_mode_t for block open flags instead of abusing Trying to look at this series applied but doesn't apply cleanly for anything v6.4-rc* related. What tree is this on?

Re: decouple block open flags from fmode_t

2023-06-06 Thread Christian Brauner
On Tue, Jun 06, 2023 at 09:39:19AM +0200, Christoph Hellwig wrote: > Hi all, > > this series adds a new blk_mode_t for block open flags instead of abusing Trying to look at this series applied but doesn't apply cleanly for anything v6.4-rc* related. What tree is this on?

Re: [Linux-cachefs] [PATCH] cachefiles: Allow the cache to be non-root

2023-06-05 Thread Christian Brauner
On Fri, 19 May 2023 18:21:20 +0100, David Howells wrote: > > Set mode 0600 on files in the cache so that cachefilesd can run as an > unprivileged user rather than leaving the files all with 0. Directories > are already set to 0700. > > Userspace then needs to set the uid and gid before issuing

Re: [PATCH] cachefiles: Allow the cache to be non-root

2023-06-05 Thread Christian Brauner
On Fri, 19 May 2023 18:21:20 +0100, David Howells wrote: > > Set mode 0600 on files in the cache so that cachefilesd can run as an > unprivileged user rather than leaving the files all with 0. Directories > are already set to 0700. > > Userspace then needs to set the uid and gid before issuing

Re: [f2fs-dev] [PATCH v2 0/6] fs: Fix directory corruption when moving directories

2023-06-02 Thread Christian Brauner
On Thu, 01 Jun 2023 12:58:20 +0200, Jan Kara wrote: > this patch set fixes a problem with cross directory renames originally > reported > in [1]. To quickly sum it up some filesystems (so far we know at least about > ext4, udf, f2fs, ocfs2, likely also reiserfs, gfs2 and others) need to lock >

Re: [f2fs-dev] [PATCH v2 4/6] fs: Establish locking order for unrelated directories

2023-06-02 Thread Christian Brauner
On Thu, Jun 01, 2023 at 04:33:58PM +, David Laight wrote: > From: Jan Kara > > Sent: 01 June 2023 17:14 > > > > On Thu 01-06-23 15:37:32, David Laight wrote: > > > ... > > > > > > + * Lock any non-NULL argument. The caller must make sure that if > > > > > > he is passing > > > > > > + * in

<    1   2   3   4   5   6   7   8   9   10   >