Re: [Linux-cachefs] [PATCH] cachefiles: Allow the cache to be non-root

2023-06-05 Thread Christian Brauner
On Fri, 19 May 2023 18:21:20 +0100, David Howells wrote: > > Set mode 0600 on files in the cache so that cachefilesd can run as an > unprivileged user rather than leaving the files all with 0. Directories > are already set to 0700. > > Userspace then needs to set the uid and gid before issuing

Re: [PATCH] cachefiles: Allow the cache to be non-root

2023-06-05 Thread Christian Brauner
On Fri, 19 May 2023 18:21:20 +0100, David Howells wrote: > > Set mode 0600 on files in the cache so that cachefilesd can run as an > unprivileged user rather than leaving the files all with 0. Directories > are already set to 0700. > > Userspace then needs to set the uid and gid before issuing

Re: [f2fs-dev] [PATCH v2 0/6] fs: Fix directory corruption when moving directories

2023-06-02 Thread Christian Brauner
On Thu, 01 Jun 2023 12:58:20 +0200, Jan Kara wrote: > this patch set fixes a problem with cross directory renames originally > reported > in [1]. To quickly sum it up some filesystems (so far we know at least about > ext4, udf, f2fs, ocfs2, likely also reiserfs, gfs2 and others) need to lock >

Re: [f2fs-dev] [PATCH v2 4/6] fs: Establish locking order for unrelated directories

2023-06-02 Thread Christian Brauner
On Thu, Jun 01, 2023 at 04:33:58PM +, David Laight wrote: > From: Jan Kara > > Sent: 01 June 2023 17:14 > > > > On Thu 01-06-23 15:37:32, David Laight wrote: > > > ... > > > > > > + * Lock any non-NULL argument. The caller must make sure that if > > > > > > he is passing > > > > > > + * in

Re: [f2fs-dev] [PATCH v2 4/6] fs: Establish locking order for unrelated directories

2023-06-01 Thread Christian Brauner
On Thu, Jun 01, 2023 at 06:13:53PM +0200, Jan Kara wrote: > On Thu 01-06-23 15:37:32, David Laight wrote: > > ... > > > > > + * Lock any non-NULL argument. The caller must make sure that if he > > > > > is passing > > > > > + * in two directories, one is not ancestor of the other > > > > Not

Re: [f2fs-dev] [PATCH v2 4/6] fs: Establish locking order for unrelated directories

2023-06-01 Thread Christian Brauner
On Thu, Jun 01, 2023 at 05:24:49PM +0200, Jan Kara wrote: > On Thu 01-06-23 15:58:58, Christian Brauner wrote: > > On Thu, Jun 01, 2023 at 12:58:24PM +0200, Jan Kara wrote: > > > Currently the locking order of inode locks for directories that are not > > > in ancestor

Re: [f2fs-dev] [PATCH v2 1/6] ext4: Remove ext4 locking of moved directory

2023-06-01 Thread Christian Brauner
On Thu, Jun 01, 2023 at 05:27:46PM +0200, Jan Kara wrote: > On Thu 01-06-23 10:52:22, Theodore Ts'o wrote: > > On Thu, Jun 01, 2023 at 12:58:21PM +0200, Jan Kara wrote: > > > Remove locking of moved directory in ext4_rename2(). We will take care > > > of it in VFS instead. This effectively reverts

Re: [f2fs-dev] [PATCH v2 4/6] fs: Establish locking order for unrelated directories

2023-06-01 Thread Christian Brauner
On Thu, Jun 01, 2023 at 12:58:24PM +0200, Jan Kara wrote: > Currently the locking order of inode locks for directories that are not > in ancestor relationship is not defined because all operations that > needed to lock two directories like this were serialized by > sb->s_vfs_rename_mutex. However

Re: [Cluster-devel] [PATCH 01/12] backing_dev: remove current->backing_dev_info

2023-05-31 Thread Christian Brauner
gt; Signed-off-by: Christoph Hellwig > Reviewed-by: Hannes Reinecke > Reviewed-by: Darrick J. Wong > --- I somehow thought I'd already acked this... Anyway, Reviewed-by: Christian Brauner

Re: [f2fs-dev] [PATCH 01/12] backing_dev: remove current->backing_dev_info

2023-05-31 Thread Christian Brauner
gt; Signed-off-by: Christoph Hellwig > Reviewed-by: Hannes Reinecke > Reviewed-by: Darrick J. Wong > --- I somehow thought I'd already acked this... Anyway, Reviewed-by: Christian Brauner ___ Linux-f2fs-devel mailing list Linux-f

Re: [f2fs-dev] [PATCH 0/6] fs: Fix directory corruption when moving directories

2023-05-31 Thread Christian Brauner
On Fri, May 26, 2023 at 05:58:14PM +0200, Christian Brauner wrote: > On Thu, May 25, 2023 at 12:16:06PM +0200, Jan Kara wrote: > > Hello, > > > > this patch set fixes a problem with cross directory renames originally > > reported > > in [1]. To quickly sum it up

Re: [Linux-cachefs] [PATCH -next 0/2] lsm: Change inode_setattr() to take struct

2023-05-31 Thread Christian Brauner
On Tue, May 30, 2023 at 03:15:01PM -0700, Casey Schaufler wrote: > On 5/30/2023 9:01 AM, Christian Brauner wrote: > > On Tue, May 30, 2023 at 07:55:17AM -0700, Casey Schaufler wrote: > >> On 5/30/2023 7:28 AM, Christoph Hellwig wrote: > >>> On Tue, May 30, 2023

Re: [Linux-cachefs] [PATCH -next 0/2] lsm: Change inode_setattr() to take struct

2023-05-30 Thread Christian Brauner
On Tue, May 30, 2023 at 07:55:17AM -0700, Casey Schaufler wrote: > On 5/30/2023 7:28 AM, Christoph Hellwig wrote: > > On Tue, May 30, 2023 at 03:58:35PM +0200, Christian Brauner wrote: > >> The main concern which was expressed on other patchsets before is that > >>

Re: [Linux-cachefs] [PATCH -next 0/2] lsm: Change inode_setattr() to take struct

2023-05-30 Thread Christian Brauner
On Fri, May 26, 2023 at 06:33:05PM +0200, Mickaël Salaün wrote: > > On 15/05/2023 17:12, Christian Brauner wrote: > > On Fri, May 05, 2023 at 04:11:58PM +0800, Xiu Jianfeng wrote: > > > Hi, > > > > > > I am working on adding xattr/attr support for l

Re: [f2fs-dev] [PATCH 4/6] fs: Establish locking order for unrelated directories

2023-05-30 Thread Christian Brauner
On Mon, May 29, 2023 at 02:41:31PM +0200, Jan Kara wrote: > On Fri 26-05-23 11:45:15, Christian Brauner wrote: > > On Thu, May 25, 2023 at 12:16:10PM +0200, Jan Kara wrote: > > > Currently the locking order of inode locks for directories that are not > > > in ancestor

Re: [f2fs-dev] [PATCH 0/6] fs: Fix directory corruption when moving directories

2023-05-26 Thread Christian Brauner
On Thu, May 25, 2023 at 12:16:06PM +0200, Jan Kara wrote: > Hello, > > this patch set fixes a problem with cross directory renames originally > reported > in [1]. To quickly sum it up some filesystems (so far we know at least about > ext4, udf, f2fs, ocfs2, likely also reiserfs, gfs2 and others)

Re: [f2fs-dev] [PATCH 4/6] fs: Establish locking order for unrelated directories

2023-05-26 Thread Christian Brauner
On Thu, May 25, 2023 at 12:16:10PM +0200, Jan Kara wrote: > Currently the locking order of inode locks for directories that are not > in ancestor relationship is not defined because all operations that > needed to lock two directories like this were serialized by > sb->s_vfs_rename_mutex. However

Re: [PATCH v21 08/30] splice: Make splice from a DAX file use copy_splice_read()

2023-05-20 Thread Christian Brauner
rnel.org > cc: linux...@kvack.org > --- Fwiw, O_DIRECT and DAX could've just been folded into one patch imho. Reviewed-by: Christian Brauner

Re: [PATCH] procfs: consolidate arch_report_meminfo declaration

2023-05-17 Thread Christian Brauner
On Tue, 16 May 2023 21:57:29 +0200, Arnd Bergmann wrote: > The arch_report_meminfo() function is provided by four architectures, > with a __weak fallback in procfs itself. On architectures that don't > have a custom version, the __weak version causes a warning because > of the missing prototype. >

Re: [PATCH] fix NFSv4 acl detection on F39

2023-05-16 Thread Christian Brauner
On Tue, May 16, 2023 at 08:20:33AM -0400, Jeff Layton wrote: > On Tue, 2023-05-16 at 11:17 +0200, Christian Brauner wrote: > > On Mon, May 15, 2023 at 01:49:21PM -0400, Jeff Layton wrote: > > > On Mon, 2023-05-15 at 17:28 +, Trond Myklebust wrote: > > > > On

Re: [PATCH] fix NFSv4 acl detection on F39

2023-05-16 Thread Christian Brauner
> (cc'ing Christian and relevant kernel lists) > > > > > > I assume the F39 kernel is v6.4-rc based? If so, then I think that's > > > a > > > regression. NFSv4 client inodes should _not_ report a POSIX ACL > > > attribute since the

Re: [Linux-cachefs] [PATCH -next 0/2] lsm: Change inode_setattr() to take struct

2023-05-15 Thread Christian Brauner
On Fri, May 05, 2023 at 04:11:58PM +0800, Xiu Jianfeng wrote: > Hi, > > I am working on adding xattr/attr support for landlock [1], so we can > control fs accesses such as chmod, chown, uptimes, setxattr, etc.. inside > landlock sandbox. the LSM hooks as following are invoved: > 1.inode_setattr >

Re: [RFC PATCH v2] fs/xattr: add *at family syscalls

2023-05-15 Thread Christian Brauner
On Mon, May 15, 2023 at 04:04:21PM +0300, Amir Goldstein wrote: > On Mon, May 15, 2023 at 1:33 PM Christian Brauner wrote: > > > > On Thu, May 11, 2023 at 05:08:02PM +0200, Christian Göttsche wrote: > > > Add the four syscalls setxattrat(), getxattrat(), listxattrat()

Re: [RFC PATCH v2] fs/xattr: add *at family syscalls

2023-05-15 Thread Christian Brauner
On Thu, May 11, 2023 at 05:08:02PM +0200, Christian Göttsche wrote: > Add the four syscalls setxattrat(), getxattrat(), listxattrat() and > removexattrat(). Those can be used to operate on extended attributes, > especially security related ones, either relative to a pinned directory > or on a

Re: [PATCH v7 00/14] KVM: mm: fd-based approach for supporting KVM guest private memory

2023-04-20 Thread Christian Brauner
On Wed, Apr 19, 2023 at 05:49:55PM -0700, Sean Christopherson wrote: > On Wed, Apr 19, 2023, Christian Brauner wrote: > > On Thu, Apr 13, 2023 at 03:28:43PM -0700, Sean Christopherson wrote: > > > > But if you want to preserve the inode number and device number of the &

Re: [PATCH v7 00/14] KVM: mm: fd-based approach for supporting KVM guest private memory

2023-04-19 Thread Christian Brauner
On Thu, Apr 13, 2023 at 03:28:43PM -0700, Sean Christopherson wrote: > On Thu, Apr 13, 2023, Christian Brauner wrote: > > On Thu, Aug 18, 2022 at 04:24:21PM +0300, Kirill A . Shutemov wrote: > > > On Wed, Aug 17, 2022 at 10:40:12PM -0700, Hugh Dickins wrote: > > > &

Re: [PATCH v7 00/14] KVM: mm: fd-based approach for supporting KVM guest private memory

2023-04-13 Thread Christian Brauner
create regular, restricted memfds. I think especially with the possibility of an extension that allows you to inherit tmpfs properties by allocating the memfd restriced file in a specific tmpfs instance the argument that you're not really making use of tmpfs things has gone out of the window.

Re: [RFC PATCH v3 1/2] mm: restrictedmem: Allow userspace to specify mount for memfd_restricted

2023-04-12 Thread Christian Brauner
On Wed, Apr 05, 2023 at 09:58:44PM +, Ackerley Tng wrote: > > Thanks again for your review! > > Christian Brauner writes: > > On Tue, Apr 04, 2023 at 03:53:13PM +0200, Christian Brauner wrote: > > > On Fri, Mar 31, 2023 at 11:50:39P

Re: [f2fs-dev] [PATCH 3/5] fstests/MAINTAINERS: add supported mailing list

2023-04-05 Thread Christian Brauner
scr...@vger.kernel.org > +S: Supported > +F: common/encrypt > + > +FS-IDMAPPED > +L: linux-fsde...@vger.kernel.org > +S: Supported > +F: src/vfs/ Same suggestion as earlier, make that section VFS as it covers generic functionality, Acked-by: Christian Brauner ___ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

Re: [f2fs-dev] [PATCH 4/5] fstests/MAINTAINERS: add some specific reviewers

2023-04-05 Thread Christian Brauner
ric Biggers > L: linux-fscr...@vger.kernel.org > S: Supported > F: common/encrypt > > FS-IDMAPPED I'd just make this VFS since src/vfs/ covers generic vfs functionality. But up to you, Acked-by: Christian Brauner > +R: Christian Brauner > L: linux-fsde...

Re: [RFC PATCH v3 1/2] mm: restrictedmem: Allow userspace to specify mount for memfd_restricted

2023-04-04 Thread Christian Brauner
On Tue, Apr 04, 2023 at 03:53:13PM +0200, Christian Brauner wrote: > On Fri, Mar 31, 2023 at 11:50:39PM +, Ackerley Tng wrote: > > By default, the backing shmem file for a restrictedmem fd is created > > on shmem's kernel space mount. > > > > With this patch,

Re: [RFC PATCH v3 1/2] mm: restrictedmem: Allow userspace to specify mount for memfd_restricted

2023-04-04 Thread Christian Brauner
On Fri, Mar 31, 2023 at 11:50:39PM +, Ackerley Tng wrote: > By default, the backing shmem file for a restrictedmem fd is created > on shmem's kernel space mount. > > With this patch, an optional tmpfs mount can be specified via an fd, > which will be used as the mountpoint for backing the

Re: [dm-devel] [PATCH v8 4/9] fs, block: copy_file_range for def_blk_ops for direct block device.

2023-03-30 Thread Christian Brauner
On Wed, Mar 29, 2023 at 06:12:36PM +0530, Nitesh Shetty wrote: > On Wed, Mar 29, 2023 at 02:14:40PM +0200, Christian Brauner wrote: > > On Mon, Mar 27, 2023 at 02:10:52PM +0530, Anuj Gupta wrote: > > > From: Nitesh Shetty > > > > > > For direct bl

Re: [dm-devel] [PATCH v8 4/9] fs, block: copy_file_range for def_blk_ops for direct block device.

2023-03-30 Thread Christian Brauner
On Mon, Mar 27, 2023 at 02:10:52PM +0530, Anuj Gupta wrote: > From: Nitesh Shetty > > For direct block device opened with O_DIRECT, use copy_file_range to > issue device copy offload, and fallback to generic_copy_file_range incase > device copy offload capability is absent. > Modify checks to

Re: [RFC PATCH v2 1/2] mm: restrictedmem: Allow userspace to specify mount for memfd_restricted

2023-03-22 Thread Christian Brauner
On Tue, Mar 21, 2023 at 08:15:32PM +, Ackerley Tng wrote: > By default, the backing shmem file for a restrictedmem fd is created > on shmem's kernel space mount. > > With this patch, an optional tmpfs mount can be specified via an fd, > which will be used as the mountpoint for backing the

Re: [RFC PATCH v2] hostfs: handle idmapped mounts

2023-03-16 Thread Christian Brauner
On Thu, Mar 16, 2023 at 06:20:19AM +, Glenn Washburn wrote: > On 3/4/23 12:01, Christian Brauner wrote: > > On Sat, Mar 04, 2023 at 12:28:46AM -0600, Glenn Washburn wrote: > > > On Thu, 2 Mar 2023 09:39:28 +0100 > > > Christian Brauner wrote: > > > > &

Re: [Linux-cachefs] [PATCH 2/5] devpts: simplify two-level sysctl registration for pty_kern_table

2023-03-13 Thread Christian Brauner
On Fri, Mar 10, 2023 at 03:12:03PM -0800, Luis Chamberlain wrote: > There is no need to declare two tables to just create directories, > this can be easily be done with a prefix path with register_sysctl(). > > Simplify this registration. > > Signed-off-by: Luis Chamberlain > --- I can take

Re: [Cluster-devel] [PATCH v2 1/5] fs: add i_blockmask()

2023-03-09 Thread Christian Brauner
On Thu, Mar 09, 2023 at 08:40:31PM +0800, Yangtao Li wrote: > Introduce i_blockmask() to simplify code, which replace > (i_blocksize(node) - 1). Like done in commit > 93407472a21b("fs: add i_blocksize()"). > > Signed-off-by: Yangtao Li > --- Looks good but did you forget to convert

Re: [PATCH v2 1/5] fs: add i_blockmask()

2023-03-09 Thread Christian Brauner
On Thu, Mar 09, 2023 at 08:40:31PM +0800, Yangtao Li wrote: > Introduce i_blockmask() to simplify code, which replace > (i_blocksize(node) - 1). Like done in commit > 93407472a21b("fs: add i_blocksize()"). > > Signed-off-by: Yangtao Li > --- Looks good but did you forget to convert

Re: [f2fs-dev] [PATCH v3 00/10] acl: drop posix acl handlers from xattr handlers

2023-03-06 Thread Christian Brauner
On Wed, Feb 01, 2023 at 02:42:54PM +0100, Christian Brauner wrote: > On Wed, Feb 01, 2023 at 02:30:20PM +0100, Christoph Hellwig wrote: > > This version looks good to me, but I'd really prefer if a reiserfs > > insider could look over the reiserfs patches. > > I consider t

Re: [PATCH v3 00/10] acl: drop posix acl handlers from xattr handlers

2023-03-06 Thread Christian Brauner
On Wed, Feb 01, 2023 at 02:42:54PM +0100, Christian Brauner wrote: > On Wed, Feb 01, 2023 at 02:30:20PM +0100, Christoph Hellwig wrote: > > This version looks good to me, but I'd really prefer if a reiserfs > > insider could look over the reiserfs patches. > > I consider t

Re: [f2fs-dev] [PATCH v3 00/10] acl: drop posix acl handlers from xattr handlers

2023-03-06 Thread Christian Brauner
From: Christian Brauner (Microsoft) On Wed, 01 Feb 2023 14:14:51 +0100, Christian Brauner wrote: > Hey everyone, > > After we finished the introduction of the new posix acl api last cycle > we still left the generic POSIX ACL xattr handlers around in the > filesystems xattr h

Re: [PATCH v3 00/10] acl: drop posix acl handlers from xattr handlers

2023-03-06 Thread Christian Brauner
From: Christian Brauner (Microsoft) On Wed, 01 Feb 2023 14:14:51 +0100, Christian Brauner wrote: > Hey everyone, > > After we finished the introduction of the new posix acl api last cycle > we still left the generic POSIX ACL xattr handlers around in the > filesystems xattr h

Re: [RFC PATCH v2] hostfs: handle idmapped mounts

2023-03-04 Thread Christian Brauner
On Sat, Mar 04, 2023 at 12:28:46AM -0600, Glenn Washburn wrote: > On Thu, 2 Mar 2023 09:39:28 +0100 > Christian Brauner wrote: > > > On Tue, Feb 28, 2023 at 07:50:02PM -0600, Glenn Washburn wrote: > > > Let hostfs handle idmapped mounts. This allows to have the same &

Re: [RFC PATCH v2] hostfs: handle idmapped mounts

2023-03-02 Thread Christian Brauner
On Tue, Feb 28, 2023 at 07:50:02PM -0600, Glenn Washburn wrote: > Let hostfs handle idmapped mounts. This allows to have the same hostfs > mount appear in multiple locations with different id mappings. > > root@(none):/media# id > uid=0(root) gid=0(root) groups=0(root) > root@(none):/media# mkdir

Re: Which branch should this patch be based against?

2023-02-28 Thread Christian Brauner
On Mon, Feb 27, 2023 at 10:33:36AM -0600, Glenn Washburn wrote: > Hi, > > On Fri, 27 Jan 2023 19:41:59 -0600 > Glenn Washburn wrote: > > > Let hostfs handle idmapped mounts. This allows to have the same hostfs > > mount appear in multiple locations with different id mappings. > > This patch is

Re: [f2fs-dev] [PATCH v3 00/10] acl: drop posix acl handlers from xattr handlers

2023-02-01 Thread Christian Brauner
On Wed, Feb 01, 2023 at 02:30:20PM +0100, Christoph Hellwig wrote: > This version looks good to me, but I'd really prefer if a reiserfs > insider could look over the reiserfs patches. I consider this material for v6.4 even with an -rc8 for v6.3. So there's time but we shouldn't block it on

Re: [PATCH v3 00/10] acl: drop posix acl handlers from xattr handlers

2023-02-01 Thread Christian Brauner
On Wed, Feb 01, 2023 at 02:30:20PM +0100, Christoph Hellwig wrote: > This version looks good to me, but I'd really prefer if a reiserfs > insider could look over the reiserfs patches. I consider this material for v6.4 even with an -rc8 for v6.3. So there's time but we shouldn't block it on

[PATCH v3 00/10] acl: drop posix acl handlers from xattr handlers

2023-02-01 Thread Christian Brauner
istian Signed-off-by: Christian Brauner (Microsoft) --- Changes in v3: - Decouple POSIX ACLs from IOP_XATTR. - Allow vfs_listxattr() to function without checking for IOP_XATTR making it possible to list POSIX ACLs for filesystems that only implement POSIX ACLs and no other xattrs. - Give reiserfs

[f2fs-dev] [PATCH v3 05/10] fs: simplify ->listxattr() implementation

2023-02-01 Thread Christian Brauner
...@lists.ozlabs.org Cc: linux-e...@vger.kernel.org Cc: linux-...@lists.infradead.org Signed-off-by: Christian Brauner (Microsoft) --- Changes in v3: - Patch unchanged. Changes in v2: - Christoph Hellwig : - Rework this patch completey by keeping the legacy generic POSIX ACL handlers

[f2fs-dev] [PATCH v3 00/10] acl: drop posix acl handlers from xattr handlers

2023-02-01 Thread Christian Brauner
istian Signed-off-by: Christian Brauner (Microsoft) --- Changes in v3: - Decouple POSIX ACLs from IOP_XATTR. - Allow vfs_listxattr() to function without checking for IOP_XATTR making it possible to list POSIX ACLs for filesystems that only implement POSIX ACLs and no other xattrs. - Give reiserfs

[PATCH v3 05/10] fs: simplify ->listxattr() implementation

2023-02-01 Thread Christian Brauner
-erofs@lists.ozlabs.org Cc: linux-e...@vger.kernel.org Cc: linux-...@lists.infradead.org Signed-off-by: Christian Brauner (Microsoft) --- Changes in v3: - Patch unchanged. Changes in v2: - Christoph Hellwig : - Rework this patch completey by keeping the legacy generic POSIX ACL handlers

[f2fs-dev] [PATCH v2 6/8] fs: simplify ->listxattr() implementation

2023-01-30 Thread Christian Brauner
...@vger.kernel.org Cc: linux-...@lists.infradead.org Signed-off-by: Christian Brauner (Microsoft) --- Changes in v2: - Christoph Hellwig : - Rework this patch completey by keeping the legacy generic POSIX ACL handlers around so that array-based handler indexing still works. This means

[f2fs-dev] [PATCH v2 0/8] acl: remove generic posix acl handlers from all xattr handlers

2023-01-30 Thread Christian Brauner
...@kernel.org [2]: ssh://g...@gitolite.kernel.org/pub/scm/linux/kernel/git/vfs/idmapping.git tags/fs.acl.remove.generic.xattr.handlers.v1 Signed-off-by: Christian Brauner (Microsoft) --- Changes in v2: - Please see changelogs of the individual patches. - Christoph & Christian: Remove SB_I_XATTR and

[PATCH v2 6/8] fs: simplify ->listxattr() implementation

2023-01-30 Thread Christian Brauner
...@vger.kernel.org Cc: linux-...@lists.infradead.org Signed-off-by: Christian Brauner (Microsoft) --- Changes in v2: - Christoph Hellwig : - Rework this patch completey by keeping the legacy generic POSIX ACL handlers around so that array-based handler indexing still works. This means

[PATCH v2 0/8] acl: remove generic posix acl handlers from all xattr handlers

2023-01-30 Thread Christian Brauner
...@kernel.org [2]: ssh://g...@gitolite.kernel.org/pub/scm/linux/kernel/git/vfs/idmapping.git tags/fs.acl.remove.generic.xattr.handlers.v1 Signed-off-by: Christian Brauner (Microsoft) --- Changes in v2: - Please see changelogs of the individual patches. - Christoph & Christian: Remove SB_I_XATTR and

Re: [f2fs-dev] [PATCH 00/12] acl: remove remaining posix acl handlers

2023-01-30 Thread Christian Brauner
On Mon, Jan 30, 2023 at 10:16:15AM +0100, Christoph Hellwig wrote: > On Mon, Jan 30, 2023 at 10:10:52AM +0100, Christian Brauner wrote: > > However, a few filesystems still rely on the ->list() method of the > > generix POSIX ACL xattr handlers in their ->listxa

Re: [PATCH 00/12] acl: remove remaining posix acl handlers

2023-01-30 Thread Christian Brauner
On Mon, Jan 30, 2023 at 10:16:15AM +0100, Christoph Hellwig wrote: > On Mon, Jan 30, 2023 at 10:10:52AM +0100, Christian Brauner wrote: > > However, a few filesystems still rely on the ->list() method of the > > generix POSIX ACL xattr handlers in their ->listxa

Re: [f2fs-dev] [PATCH 00/12] acl: remove remaining posix acl handlers

2023-01-30 Thread Christian Brauner
On Wed, Jan 25, 2023 at 12:28:45PM +0100, Christian Brauner wrote: > Hey everyone, > > after we finished the introduction of the new posix acl api last cycle > we still left the generic POSIX ACL xattr handler around for two > reasons. First, because a few filesystems relie

Re: [PATCH 00/12] acl: remove remaining posix acl handlers

2023-01-30 Thread Christian Brauner
On Wed, Jan 25, 2023 at 12:28:45PM +0100, Christian Brauner wrote: > Hey everyone, > > after we finished the introduction of the new posix acl api last cycle > we still left the generic POSIX ACL xattr handler around for two > reasons. First, because a few filesystems relie

Re: [PATCH 05/12] erofs: drop posix acl handlers

2023-01-30 Thread Christian Brauner
On Mon, Jan 30, 2023 at 07:43:29AM +0100, Christoph Hellwig wrote: > This review is not for erofs specifically, but for all file systems using > the same scheme. > > > +static const char *erofs_xattr_prefix(int xattr_index, struct dentry > > *dentry) > > +{ > > + const char *name = NULL; > > +

[f2fs-dev] [PATCH 00/12] acl: remove remaining posix acl handlers

2023-01-25 Thread Christian Brauner
pping.git tags/fs.acl.remove.generic.xattr.handlers.v1 Signed-off-by: Christian Brauner (Microsoft) --- Christian Brauner (12): xattr: simplify listxattr helpers xattr, posix acl: add listxattr helpers xattr: remove unused argument fs: drop unused posix acl handlers erofs: drop posix acl hand

[f2fs-dev] [PATCH 08/12] f2fs: drop posix acl handlers

2023-01-25 Thread Christian Brauner
infrastructure of the vfs is used to interact with posix acls when it really isn't anymore. For this to work we simply rework the ->listxattr() inode operation to not rely on the generix posix acl handlers anymore. Cc: Signed-off-by: Christian Brauner (Microsoft) --- fs/f2fs/xattr.c |

[PATCH 05/12] erofs: drop posix acl handlers

2023-01-25 Thread Christian Brauner
infrastructure of the vfs is used to interact with posix acls when it really isn't anymore. For this to work we simply rework the ->listxattr() inode operation to not rely on the generix posix acl handlers anymore. Cc: Signed-off-by: Christian Brauner (Microsoft) --- fs/erofs/xattr.c |

[PATCH 00/12] acl: remove remaining posix acl handlers

2023-01-25 Thread Christian Brauner
pping.git tags/fs.acl.remove.generic.xattr.handlers.v1 Signed-off-by: Christian Brauner (Microsoft) --- Christian Brauner (12): xattr: simplify listxattr helpers xattr, posix acl: add listxattr helpers xattr: remove unused argument fs: drop unused posix acl handlers erofs: drop posix acl hand

[Kernel-packages] [Bug 1998602] Re: overlay writing user.* xattrs on symlinks

2022-12-02 Thread Christian Brauner
> I had thought I should be able to reproduce it by mounting (in an unprivileged user+mountns) an overlayfs where the underlay has, say, "/etc/rc2.d/K" symlink, then rename K to S (as i assume the 'systemctl disable dnsmasq is doing), but that did not work for me. Fwiw, I think you need index=on

Re: [Cluster-devel] [PATCH] filelock: move file locking definitions to separate header file

2022-11-21 Thread Christian Brauner
r file, and add the > appropriate #include directives to the source files that need them. By > doing this we trim down fs.h a bit and limit the amount of rebuilding > that has to be done when we make changes to the file locking APIs. > > Signed-off-by: Jeff Layton > --- Looks good to m

Re: [apparmor] [PATCH 4/8] apparmor: use type safe idmapping helpers

2022-10-25 Thread Christian Brauner
On Tue, Oct 25, 2022 at 01:30:10AM -0700, John Johansen wrote: > On 10/25/22 00:44, Christian Brauner wrote: > > On Tue, Oct 25, 2022 at 12:16:02AM -0700, John Johansen wrote: > > > On 10/24/22 04:12, Christian Brauner wrote: > > > > We already ported most parts

Re: [apparmor] [PATCH 4/8] apparmor: use type safe idmapping helpers

2022-10-25 Thread Christian Brauner
On Tue, Oct 25, 2022 at 12:16:02AM -0700, John Johansen wrote: > On 10/24/22 04:12, Christian Brauner wrote: > > We already ported most parts and filesystems over for v6.0 to the new > > vfs{g,u}id_t type and associated helpers for v6.0. Convert the remaining > > places

[apparmor] [PATCH 4/8] apparmor: use type safe idmapping helpers

2022-10-24 Thread Christian Brauner
We already ported most parts and filesystems over for v6.0 to the new vfs{g,u}id_t type and associated helpers for v6.0. Convert the remaining places so we can remove all the old helpers. This is a non-functional change. Signed-off-by: Christian Brauner (Microsoft) --- Notes: security

Re: [apparmor] [PATCH 1/2] fs/exec: Explicitly unshare fs_struct on exec

2022-10-06 Thread Christian Brauner
On Thu, Oct 06, 2022 at 01:27:34AM -0700, Kees Cook wrote: > The check_unsafe_exec() counting of n_fs would not add up under a heavily > threaded process trying to perform a suid exec, causing the suid portion > to fail. This counting error appears to be unneeded, but to catch any > possible

[f2fs-dev] [PATCH] f2fs: port to vfs{g, u}id_t and associated helpers

2022-09-09 Thread Christian Brauner
fe helpers that operate on vfs{g,u}id_t. Cc: Seth Forshee (Digital Ocean) Cc: Christoph Hellwig Cc: Jaegeuk Kim Cc: Chao Yu Cc: linux-f2fs-devel@lists.sourceforge.net Signed-off-by: Christian Brauner (Microsoft) --- fs/f2fs/acl.c | 2 +- fs/f2fs/file.c | 5 +++-- 2 files changed, 4 insert

Re: [f2fs-dev] [PATCH v5 2/8] vfs: support STATX_DIOALIGN on block devices

2022-09-07 Thread Christian Brauner
tat operating only on the block > device node, not the block device itself. However, it was felt that > doing this is preferable, in order to make the interface useful and > avoid needing separate interfaces for regular files and block devices. > > Signed-off-by: Eric Biggers > --- Look

Re: [f2fs-dev] [PATCH v5 1/8] statx: add direct I/O alignment information

2022-09-07 Thread Christian Brauner
is commit only adds the VFS-level plumbing for STATX_DIOALIGN. For > regular files, individual filesystems will still need to add code to > support it. For block devices, a separate commit will wire it up too. > > Reviewed-by: Christoph Hellwig >

Re: [RFC PATCH 2/2] fs/xattr: wire up syscalls

2022-08-30 Thread Christian Brauner
On Tue, Aug 30, 2022 at 05:28:38PM +0200, Christian Göttsche wrote: > Enable the new added extended attribute related syscalls. > > Signed-off-by: Christian Göttsche > --- Fwiw, I think a while ago it was pointed out that for most syscall additions you can just fold the hookup patch in. It

Re: [RFC PATCH 2/2] fs/xattr: wire up syscalls

2022-08-30 Thread Christian Brauner
On Tue, Aug 30, 2022 at 05:28:38PM +0200, Christian Göttsche wrote: > Enable the new added extended attribute related syscalls. > > Signed-off-by: Christian Göttsche > --- Fwiw, I think a while ago it was pointed out that for most syscall additions you can just fold the hookup patch in. It

Re: [f2fs-dev] [PATCH] Documentation: filesystems: correct possessive "its"

2022-08-30 Thread Christian Brauner
org > Cc: linux-f2fs-devel@lists.sourceforge.net > Cc: linux-...@vger.kernel.org > Cc: Christian Brauner > Cc: Seth Forshee > --- Thank you! Reviewed-by: Christian Brauner (Microsoft) ___ Linux-f2fs-devel mailing list Linux-f2fs-

Re: [ovs-dev] [PATCH net-next v3 0/2] openvswitch: allow specifying ifindex of new interfaces

2022-08-26 Thread Christian Brauner
ATCH_UPCALL_PER_CPU flag. > > Found and fixed memory leak on datapath creation error path. > > v3: > Sent memleak fix separately to net. > Improved patches according to the reviews: > - Added new OVS_DP_ATTR_IFINDEX instead of using ovs_header->dp_ifindex > - Pre-all

Re: [ovs-dev] [PATCH net-next v2 1/3] openvswitch: allow specifying ifindex of new interfaces

2022-08-22 Thread Christian Brauner
;dp_ifindex during OVS_DP_CMD_NEW as desired ifindex. > Use OVS_VPORT_ATTR_IFINDEX during OVS_VPORT_CMD_NEW to specify new netdev > ifindex. > > Signed-off-by: Andrey Zhadchenko > --- Looks good to me, Acked-by: Christian Brauner (Microsoft) _

Re: [ovs-dev] [PATCH net-next 1/1] openvswitch: allow specifying ifindex of new interfaces

2022-08-17 Thread Christian Brauner
On Wed, Aug 17, 2022 at 03:49:09PM +0300, Andrey Zhadchenko wrote: > CRIU is preserving ifindexes of net devices after restoration. However, > current Open vSwitch API does not allow to target ifindex, so we cannot > correctly restore OVS configuration. > > Use ovs_header->dp_ifindex during

Re: [ovs-dev] [PATCH net-next 0/1] openvswitch: allow specifying ifindex of new interfaces

2022-08-17 Thread Christian Brauner
On Wed, Aug 17, 2022 at 03:49:08PM +0300, Andrey Zhadchenko wrote: > Hi! > > CRIU currently do not support checkpoint/restore of OVS configurations, but > there was several requests for it. For example, > https://github.com/lxc/lxc/issues/2909 Ah right, I remember that. :) > > The main problem

Re: [Devel] [PATCH v2 1/2] neigh: fix possible DoS due to net iface start/stop loop

2022-08-15 Thread Christian Brauner
) > > Cc: "David S. Miller" > Cc: Eric Dumazet > Cc: Jakub Kicinski > Cc: Paolo Abeni > Cc: Daniel Borkmann > Cc: David Ahern > Cc: Yajun Deng > Cc: Roopa Prabhu > Cc: Christian Brauner > Cc: net...@vger.kernel.org > Cc: linux-ker...@vger.k

Re: future of dual booting Windows and Fedora, redux

2022-07-28 Thread Christian Brauner
Sorry for showing up here unannounced. This is a very strange claim. I'm not speaking in any official capacity but at least __personally__ being at the Linux Systems Group at MSFT I've never have encountered any hard requirement on grub. In any case, I want to point out a few things: * Some of

Re: [systemd-devel] Feedback sought: can we drop cgroupv1 support soon?

2022-07-21 Thread Christian Brauner
[Cc Stéphane and Serge] On Thu, Jul 21, 2022 at 11:03:49AM +0200, Lennart Poettering wrote: > Heya! > > It's currently a terrible mess having to support both cgroupsv1 and > cgroupsv2 in our codebase. > > cgroupsv2 first entered the kernel in 2014, i.e. *eight* years ago > (kernel 3.16). We

Re: [RFC PATCH v2 2/3] fs: define a firmware security filesystem named fwsecurityfs

2022-06-28 Thread Christian Brauner
On Mon, Jun 27, 2022 at 09:37:28AM +0200, Greg Kroah-Hartman wrote: > On Sun, Jun 26, 2022 at 11:48:06AM -0400, Mimi Zohar wrote: > > On Thu, 2022-06-23 at 09:23 -0400, James Bottomley wrote: > > > On Thu, 2022-06-23 at 10:54 +0200, Greg Kroah-Hartman wrote: > > > [...] > > > > > diff --git

Re: [Linux-cachefs] [PATCH v3] cred: Propagate security_prepare_creds() error code

2022-06-15 Thread Christian Brauner
On Tue, Jun 14, 2022 at 01:59:08PM -0500, Frederick Lawler wrote: > On 6/14/22 11:30 AM, Eric W. Biederman wrote: > > Frederick Lawler writes: > > > > > On 6/13/22 11:44 PM, Eric W. Biederman wrote: > > > > Frederick Lawler writes: > > > > > > > > > Hi Eric, > > > > > > > > > > On 6/13/22

[tomoyo-dev-en 444] Re: [PATCH] tomoyo: fix handling of path{1, 2}.parent.* conditions

2022-06-07 Thread Christian Brauner
On Tue, Jun 07, 2022 at 11:22:49PM +0900, Tetsuo Handa wrote: > On 2022/06/07 21:27, Christian Brauner wrote: > > When path conditions are specified tomoyo tries to retrieve information > > about > > the parent dentry. It currently assumes that the parent dentry is alwa

[tomoyo-dev-en 442] [PATCH] tomoyo: fix handling of path{1, 2}.parent.* conditions

2022-06-07 Thread Christian Brauner
ually reachable from the child dentry's mount and if not skip it. Fixes: 8761afd49ebf ("TOMOYO: Allow using owner/group etc. of file objects as conditions.") Cc: sta...@vger.kernel.org # 4.9+ Cc: Kentaro Takeda Cc: Tetsuo Handa Cc: tomoyo-dev-en@lists.osdn.me Signed-off-by: Christi

Re: [f2fs-dev] [PATCH 00/10] Convert to filemap_get_folios()

2022-06-07 Thread Christian Brauner
.h | 10 -- > include/linux/swap.h| 3 +- > mm/filemap.c| 72 + > mm/shmem.c | 13 > mm/swap.c | 29 - > mm/vmscan.c | 55 ++- > 12 files changed, 166 insertions(+), 226

Re: [f2fs-dev] [RFC PATCH v2 1/7] statx: add I/O alignment information

2022-05-20 Thread Christian Brauner
t required to > return information that wasn't requested. > > This commit adds the VFS-level plumbing for STATX_IOALIGN. Individual > filesystems will still need to add code to support it. > > Signed-off-by: Eric Biggers > --- Looks good to me, Reviewed-by: Christian Brauner (Microso

Re: [PATCH v2] erofs: support idmapped mounts

2022-05-17 Thread Christian Brauner
> > 6. mount-idmapped --map-mount b:1000:1001:1 /mnt/erofs/ /mnt/scratch_erofs/ > > 7. ls -ln /mnt/scratch_erofs/ > total 0 > -rw-rw-r-- 1 1001 1001 0 May 17 15:26 file > > Reviewed-by: Christian Brauner (Microsoft) > Reviewed-by: Gao Xiang > Signed-off-by: Chao

Re: [PATCH] erofs: support idmapped mounts

2022-05-17 Thread Christian Brauner
On Tue, May 17, 2022 at 05:15:02PM +0800, Gao Xiang wrote: > Hi Christian, > > On Tue, May 17, 2022 at 11:06:22AM +0200, Christian Brauner wrote: > > On Tue, May 17, 2022 at 03:32:10PM +0800, Chao Yu wrote: > > > This patch enables idmapped mounts for erofs, sin

Re: [PATCH] erofs: support idmapped mounts

2022-05-17 Thread Christian Brauner
or read-only filesystems we probably only need to verify that {g,u}id are correctly reported. All the writable aspects are irrelevant. Looks good, Reviewed-by: Christian Brauner (Microsoft) > fs/erofs/inode.c | 2 +- > fs/erofs/super.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions

[Bug 1969905] Re: lxc-test-no-new-privs in ubuntu_lxc failed on F-s390x zVM (lxc 1:4.0.12-0ubuntu1~20.04.1 )

2022-04-22 Thread Christian Brauner
And that only fails on s390x? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1969905 Title: lxc-test-no-new-privs in ubuntu_lxc failed on F-s390x zVM (lxc 1:4.0.12-0ubuntu1~20.04.1 ) To manage

[Touch-packages] [Bug 1969905] Re: lxc-test-no-new-privs in ubuntu_lxc failed on F-s390x zVM (lxc 1:4.0.12-0ubuntu1~20.04.1 )

2022-04-22 Thread Christian Brauner
And that only fails on s390x? -- You received this bug notification because you are a member of Ubuntu Touch seeded packages, which is subscribed to lxc in Ubuntu. https://bugs.launchpad.net/bugs/1969905 Title: lxc-test-no-new-privs in ubuntu_lxc failed on F-s390x zVM (lxc

Re: [f2fs-dev] [PATCH v4 7/8] fs: strip file's S_ISGID mode on vfs instead of on underlying filesystem

2022-04-19 Thread Christian Brauner
e regular VFS callpath because it > has separate system call > spu_create, but it t only allows the creation of directories and only allows > bits in 0777 and can ignore > 4)bpf use vfs_mkobj in bpf_obj_do_pin with "S_IFREG | ((S_IRUSR | S_IWUSR) & > ~current_umask()) mode and

Re: [f2fs-dev] [PATCH v4 1/8] fs: move sgid strip operation from inode_init_owner into inode_sgid_strip

2022-04-19 Thread Christian Brauner
On Tue, Apr 19, 2022 at 07:47:07PM +0800, Yang Xu wrote: > This has no functional change. Just create and export inode_sgid_strip api for > the subsequent patch. This function is used to strip S_ISGID mode when init > a new inode. > > Acked-by: Christian Brauner (Microsoft) > S

Re: [f2fs-dev] [PATCH v4 6/8] ntfs3: Use the same order for acl pointer check in ntfs_init_acl

2022-04-19 Thread Christian Brauner
On Tue, Apr 19, 2022 at 07:47:12PM +0800, Yang Xu wrote: > Like ext4 and other use ${fs}_init_acl filesystem, they all used the following > style > >error = posix_acl_create(dir, >i_mode, _acl, ); >if (error) > return error; > > if (default_acl) { >

Re: [f2fs-dev] [PATCH v4 5/8] f2fs: Remove useless NULL assign value for acl and default_acl

2022-04-19 Thread Christian Brauner
On Tue, Apr 19, 2022 at 07:47:11PM +0800, Yang Xu wrote: > Like other use ${fs}_init_acl and posix_acl_create filesystem, we don't > need to assign NULL for acl and default_acl pointer because f2fs_acl_create > will do this job. So remove it. > > Signed-off-by: Yang Xu > --- > fs/f2fs/acl.c | 2

Re: [f2fs-dev] [PATCH v4 4/8] NFSv3: only do posix_acl_create under CONFIG_NFS_V3_ACL

2022-04-19 Thread Christian Brauner
On Tue, Apr 19, 2022 at 07:47:10PM +0800, Yang Xu wrote: > Since nfs3_proc_create/nfs3_proc_mkdir/nfs3_proc_mknod these rpc ops are > called > by nfs_create/nfs_mkdir/nfs_mkdir these inode ops, so they are all in control > of > vfs. > > nfs3_proc_setacls does nothing in the !CONFIG_NFS_V3_ACL

<    1   2   3   4   5   6   7   8   9   10   >