Re: RFR: JDK-8304036: Use CommandLine class from shared module [v7]

2023-04-24 Thread Christian Stein
shared `CommandLine.java` in `jdk.compiler` module > - [x] Use shared `CommandLine.java` in `jdk.javadoc` module > - [x] Remove `CommandLine.java` from `jdk.compiler` module Christian Stein has updated the pull request incrementally with one additional commit since the last revision: Up

Integrated: 8304896: Update to use jtreg 7.2

2023-04-24 Thread Christian Stein
On Mon, 17 Apr 2023 14:56:16 GMT, Christian Stein wrote: > Please review the change to update to using jtreg 7.2. > > The primary change is to the `jib-profiles.js` file, which specifies the > version of jtreg to use, for those systems that rely on this file. In

Re: RFR: JDK-8304036: Use CommandLine class from shared module [v5]

2023-04-24 Thread Christian Stein
On Sat, 22 Apr 2023 12:15:38 GMT, Christian Stein wrote: >> This pull request addresses the open ends left by >> [JDK-8236919](https://bugs.openjdk.org/browse/JDK-8236919): >> - #11272 >> >> Changes: >> - [x] Extend list of targeted exports o

Integrated: 8304896: Update to use jtreg 7.2

2023-04-24 Thread Christian Stein
On Mon, 17 Apr 2023 14:56:16 GMT, Christian Stein wrote: > Please review the change to update to using jtreg 7.2. > > The primary change is to the `jib-profiles.js` file, which specifies the > version of jtreg to use, for those systems that rely on this file. In

Re: RFR: JDK-8304036: Use CommandLine class from shared module [v6]

2023-04-24 Thread Christian Stein
shared `CommandLine.java` in `jdk.compiler` module > - [x] Use shared `CommandLine.java` in `jdk.javadoc` module > - [x] Remove `CommandLine.java` from `jdk.compiler` module Christian Stein has updated the pull request incrementally with five additional commits since the last revision: - F

Re: RFR: JDK-8304036: Use CommandLine class from shared module [v5]

2023-04-24 Thread Christian Stein
On Sat, 22 Apr 2023 12:15:38 GMT, Christian Stein wrote: >> This pull request addresses the open ends left by >> [JDK-8236919](https://bugs.openjdk.org/browse/JDK-8236919): >> - #11272 >> >> Changes: >> - [x] Extend list of targeted exports o

Re: RFR: JDK-8304036: Use CommandLine class from shared module [v6]

2023-04-24 Thread Christian Stein
shared `CommandLine.java` in `jdk.compiler` module > - [x] Use shared `CommandLine.java` in `jdk.javadoc` module > - [x] Remove `CommandLine.java` from `jdk.compiler` module Christian Stein has updated the pull request incrementally with five additional commits since the last revision: - F

Re: RFR: JDK-8304036: Use CommandLine class from shared module [v5]

2023-04-22 Thread Christian Stein
shared `CommandLine.java` in `jdk.compiler` module > - [x] Use shared `CommandLine.java` in `jdk.javadoc` module > - [x] Remove `CommandLine.java` from `jdk.compiler` module Christian Stein has updated the pull request incrementally with one additional commit since the last revisio

Re: RFR: JDK-8304036: Use CommandLine class from shared module [v5]

2023-04-22 Thread Christian Stein
shared `CommandLine.java` in `jdk.compiler` module > - [x] Use shared `CommandLine.java` in `jdk.javadoc` module > - [x] Remove `CommandLine.java` from `jdk.compiler` module Christian Stein has updated the pull request incrementally with one additional commit since the last revisio

Re: RFR: JDK-8304036: Use CommandLine class from shared module [v4]

2023-04-22 Thread Christian Stein
shared `CommandLine.java` in `jdk.compiler` module > - [x] Use shared `CommandLine.java` in `jdk.javadoc` module > - [x] Remove `CommandLine.java` from `jdk.compiler` module Christian Stein has updated the pull request incrementally with one additional commit since the last revision: Upda

Re: RFR: JDK-8304036: Use CommandLine class from shared module [v4]

2023-04-22 Thread Christian Stein
shared `CommandLine.java` in `jdk.compiler` module > - [x] Use shared `CommandLine.java` in `jdk.javadoc` module > - [x] Remove `CommandLine.java` from `jdk.compiler` module Christian Stein has updated the pull request incrementally with one additional commit since the last revision: Upda

Re: RFR: JDK-8304036: Use CommandLine class from shared module [v3]

2023-04-22 Thread Christian Stein
shared `CommandLine.java` in `jdk.compiler` module > - [x] Use shared `CommandLine.java` in `jdk.javadoc` module > - [x] Remove `CommandLine.java` from `jdk.compiler` module Christian Stein has updated the pull request incrementally with one additional commit since the last r

Re: RFR: JDK-8304036: Use CommandLine class from shared module [v2]

2023-04-22 Thread Christian Stein
On Fri, 21 Apr 2023 21:42:58 GMT, Mandy Chung wrote: >> Christian Stein has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contain

Re: RFR: JDK-8304036: Use CommandLine class from shared module [v2]

2023-04-22 Thread Christian Stein
On Fri, 21 Apr 2023 21:42:58 GMT, Mandy Chung wrote: >> Christian Stein has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contain

Re: RFR: JDK-8304036: Use CommandLine class from shared module [v3]

2023-04-22 Thread Christian Stein
shared `CommandLine.java` in `jdk.compiler` module > - [x] Use shared `CommandLine.java` in `jdk.javadoc` module > - [x] Remove `CommandLine.java` from `jdk.compiler` module Christian Stein has updated the pull request incrementally with one additional commit since the last r

Re: RFR: JDK-8304036: Use CommandLine class from shared module [v2]

2023-04-21 Thread Christian Stein
shared `CommandLine.java` in `jdk.compiler` module > - [x] Use shared `CommandLine.java` in `jdk.javadoc` module > - [x] Remove `CommandLine.java` from `jdk.compiler` module Christian Stein has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev

Re: RFR: JDK-8304036: Use CommandLine class from shared module [v2]

2023-04-21 Thread Christian Stein
shared `CommandLine.java` in `jdk.compiler` module > - [x] Use shared `CommandLine.java` in `jdk.javadoc` module > - [x] Remove `CommandLine.java` from `jdk.compiler` module Christian Stein has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev

Re: RFR: JDK-8304036: Use CommandLine class from shared module

2023-04-21 Thread Christian Stein
On Mon, 13 Mar 2023 08:16:54 GMT, Christian Stein wrote: > This pull request addresses the open ends left by > [JDK-8236919](https://bugs.openjdk.org/browse/JDK-8236919): > - #11272 > > Changes: > - [x] Extend list of targeted exports of `jdk.internal.opt/jdk.internal.opt`

Re: RFR: JDK-8304036: Use CommandLine class from shared module

2023-04-21 Thread Christian Stein
On Mon, 13 Mar 2023 08:16:54 GMT, Christian Stein wrote: > This pull request addresses the open ends left by > [JDK-8236919](https://bugs.openjdk.org/browse/JDK-8236919): > - #11272 > > Changes: > - [x] Extend list of targeted exports of `jdk.internal.opt/jdk.internal.opt`

Re: RFR: 8306678: Replace use of os.version with an internal Version record

2023-04-21 Thread Christian Stein
On Fri, 21 Apr 2023 16:44:13 GMT, Roger Riggs wrote: > Create an internal Version record to hold and compare versions of the form > (major, minor, micro). > Add `OperatingSystem.version()` to return the version of the running OS. > Replace uses of os.version in java.base. > Subsequent PRs will

Re: RFR: 8306678: Replace use of os.version with an internal Version record

2023-04-21 Thread Christian Stein
On Fri, 21 Apr 2023 16:44:13 GMT, Roger Riggs wrote: > Create an internal Version record to hold and compare versions of the form > (major, minor, micro). > Add `OperatingSystem.version()` to return the version of the running OS. > Replace uses of os.version in java.base. > Subsequent PRs will

RFR: 8304896: Update to use jtreg 7.2

2023-04-17 Thread Christian Stein
Please review the change to update to using jtreg 7.2. The primary change is to the `jib-profiles.js` file, which specifies the version of jtreg to use, for those systems that rely on this file. In addition, the requiredVersion has been updated in the various `TEST.ROOT` files. -

RFR: 8304896: Update to use jtreg 7.2

2023-04-17 Thread Christian Stein
Please review the change to update to using jtreg 7.2. The primary change is to the `jib-profiles.js` file, which specifies the version of jtreg to use, for those systems that rely on this file. In addition, the requiredVersion has been updated in the various `TEST.ROOT` files. -

Re: RFR: 8305945: (zipfs) Opening a directory to get input stream produces incorrect exception message

2023-04-14 Thread Christian Stein
On Fri, 14 Apr 2023 20:24:00 GMT, Lance Andersen wrote: > Please review this trivial change when ZipFS returns the wrong > java.nio.file.FileSystemException message due the the parameters being > reversed. > > I also included a simple junit test as part of the fix. > > Mach5 tiers1-3 are

RFR: JDK-8304036: Use CommandLine class from shared module

2023-03-13 Thread Christian Stein
This pull request addresses the open ends left by [JDK-8236919](https://bugs.openjdk.org/browse/JDK-8236919): - #11272 Changes: - [x] Extend list of targeted exports of `jdk.internal.opt/jdk.internal.opt` to `jdk.compiler` and `jdk.javadoc` - [x] Use shared `CommandLine.java` in `jdk.compiler`

RFR: JDK-8304036: Use CommandLine class from shared module

2023-03-13 Thread Christian Stein
This pull request addresses the open ends left by [JDK-8236919](https://bugs.openjdk.org/browse/JDK-8236919): - #11272 Changes: - [x] Extend list of targeted exports of `jdk.internal.opt/jdk.internal.opt` to `jdk.compiler` and `jdk.javadoc` - [x] Use shared `CommandLine.java` in `jdk.compiler`

Re: [HEADS UP] Release of surefire

2023-03-10 Thread Christian Stein
+ M10 ... erm +1 for releasing 3.0.0 On Thu, Mar 9, 2023 at 10:36 AM Slawomir Jaranowski wrote: > Hi, > > According to https://issues.apache.org/jira/browse/MNG-7725 > I would like to release the next version of surefire. > > Next radical proposal: switch version to 3.0.0 and stop producing

Re: RFR: 8301701 : java/net/DatagramSocket/DatagramSocketMulticasting.java should be hardened [v2]

2023-02-14 Thread Christian Stein
On Tue, 14 Feb 2023 15:02:51 GMT, Alan Bateman wrote: >> Darragh Clarke has updated the pull request incrementally with one >> additional commit since the last revision: >> >> cleanup based on feedback > > test/jdk/java/net/DatagramSocket/DatagramSocketMulticasting.java line 66: > >> 64:

Re: RFR: 8301701 : java/net/DatagramSocket/DatagramSocketMulticasting.java should be hardened

2023-02-10 Thread Christian Stein
On Fri, 10 Feb 2023 16:28:14 GMT, Darragh Clarke wrote: >> test/jdk/java/net/DatagramSocket/DatagramSocketMulticasting.java line 75: >> >>> 73: @Test >>> 74: public void main() throws IOException { >>> 75: IPSupport.throwSkippedExceptionIfNonOperational(); >> >> This can throw

Re: RFR: 8301767: Convert virtual thread tests to JUnit [v2]

2023-02-08 Thread Christian Stein
On Wed, 8 Feb 2023 09:32:49 GMT, Jaikiran Pai wrote: > I wonder if testng (and junit) can be configured to fail the test if no test > methods were present, to flag such mistakes. JUnit's CLI tool has: `--fail-if-no-tests Fail and return exit status code 2 if no tests are found.` We can

Re: RFR: 8301767: Convert virtual thread tests to JUnit [v2]

2023-02-08 Thread Christian Stein
On Wed, 8 Feb 2023 09:32:49 GMT, Jaikiran Pai wrote: > I wonder if testng (and junit) can be configured to fail the test if no test > methods were present, to flag such mistakes. JUnit's CLI tool has: `--fail-if-no-tests Fail and return exit status code 2 if no tests are found.` We can

Re: RFR: 8301767: Convert virtual thread tests to JUnit

2023-02-07 Thread Christian Stein
On Sat, 4 Feb 2023 08:59:29 GMT, Alan Bateman wrote: > The non-hotspot tests integrated with JEP 425/428 were mostly TestNG tests. > We'd like to convert these JUnit in the main line in advance of other updates > to these tests in 21. The changes are mostly mechanical and trivial: > > -

Re: RFR: 8301767: Convert virtual thread tests to JUnit

2023-02-07 Thread Christian Stein
On Sat, 4 Feb 2023 08:59:29 GMT, Alan Bateman wrote: > The non-hotspot tests integrated with JEP 425/428 were mostly TestNG tests. > We'd like to convert these JUnit in the main line in advance of other updates > to these tests in 21. The changes are mostly mechanical and trivial: > > -

Re: RFR: 8299863: URLFromURITest.java should import org.junit.jupiter.api.Test

2023-01-20 Thread Christian Stein
On Fri, 20 Jan 2023 15:51:52 GMT, Darragh Clarke wrote: > URLFromURITest.java was mixing JUnit 4 and Jupiter APIs, this is just a > simple cleanup to swap it to use only Jupiter. > > I looked around to see if there were any other tests affected but this seems > to be the only one. 

Re: RFR: 8300228: ModuleReader.find on exploded module throws if resource name maps to invalid file path

2023-01-17 Thread Christian Stein
On Tue, 17 Jan 2023 11:34:52 GMT, Alan Bateman wrote: > The ModuleReader implementation for exploded modules maps resource names to > file paths. A small oversight is that it doesn't handle InvalidPathException > which is thrown when the resource name maps to something that can't be parsed >

Integrated: 8298178: Update to use jtreg 7.1.1

2022-12-06 Thread Christian Stein
On Tue, 6 Dec 2022 16:07:44 GMT, Christian Stein wrote: > Please review the change to update to using jtreg 7.1.1. > > The primary change is to the `jib-profiles.js` file, which specifies the > version of jtreg to use, for those systems that rely on this file. In

Integrated: 8298178: Update to use jtreg 7.1.1

2022-12-06 Thread Christian Stein
On Tue, 6 Dec 2022 16:07:44 GMT, Christian Stein wrote: > Please review the change to update to using jtreg 7.1.1. > > The primary change is to the `jib-profiles.js` file, which specifies the > version of jtreg to use, for those systems that rely on this file. In

Re: RFR: 8298178: Update to use jtreg 7.1.1 [v2]

2022-12-06 Thread Christian Stein
On Tue, 6 Dec 2022 17:45:06 GMT, Christian Stein wrote: >> Please review the change to update to using jtreg 7.1.1. >> >> The primary change is to the `jib-profiles.js` file, which specifies the >> version of jtreg to use, for those systems that rely on th

Re: RFR: 8298178: Update to use jtreg 7.1.1 [v2]

2022-12-06 Thread Christian Stein
On Tue, 6 Dec 2022 17:45:06 GMT, Christian Stein wrote: >> Please review the change to update to using jtreg 7.1.1. >> >> The primary change is to the `jib-profiles.js` file, which specifies the >> version of jtreg to use, for those systems that rely on th

Re: RFR: 8298178: Update to use jtreg 7.1.1 [v3]

2022-12-06 Thread Christian Stein
.ROOT` > files. > > This pull request was created by copying the following and using 7.1.1 at > appropriate places: > - https://github.com/openjdk/jdk/pull/11416 Christian Stein has refreshed the contents of this pull request, and previous commits have been removed. Incremental vie

Re: RFR: 8298178: Update to use jtreg 7.1.1 [v3]

2022-12-06 Thread Christian Stein
.ROOT` > files. > > This pull request was created by copying the following and using 7.1.1 at > appropriate places: > - https://github.com/openjdk/jdk/pull/11416 Christian Stein has refreshed the contents of this pull request, and previous commits have been removed. Incremental vie

Re: RFR: 8298178: Update to use jtreg 7.1.1 [v2]

2022-12-06 Thread Christian Stein
.ROOT` > files. > > This pull request was created by copying the following and using 7.1.1 at > appropriate places: > - https://github.com/openjdk/jdk/pull/11416 Christian Stein has updated the pull request incrementally with two additional commits since the last revision:

Re: RFR: 8298178: Update to use jtreg 7.1.1 [v2]

2022-12-06 Thread Christian Stein
.ROOT` > files. > > This pull request was created by copying the following and using 7.1.1 at > appropriate places: > - https://github.com/openjdk/jdk/pull/11416 Christian Stein has updated the pull request incrementally with two additional commits since the last revision:

Re: RFR: 8298178: Update to use jtreg 7.1.1

2022-12-06 Thread Christian Stein
On Tue, 6 Dec 2022 16:07:44 GMT, Christian Stein wrote: > Please review the change to update to using jtreg 7.1.1. > > The primary change is to the `jib-profiles.js` file, which specifies the > version of jtreg to use, for those systems that rely on this file. In

Re: RFR: 8298178: Update to use jtreg 7.1.1

2022-12-06 Thread Christian Stein
On Tue, 6 Dec 2022 16:07:44 GMT, Christian Stein wrote: > Please review the change to update to using jtreg 7.1.1. > > The primary change is to the `jib-profiles.js` file, which specifies the > version of jtreg to use, for those systems that rely on this file. In

Re: RFR: 8298178: Update to use jtreg 7.1.1

2022-12-06 Thread Christian Stein
On Tue, 6 Dec 2022 16:07:44 GMT, Christian Stein wrote: > Please review the change to update to using jtreg 7.1.1. > > The primary change is to the `jib-profiles.js` file, which specifies the > version of jtreg to use, for those systems that rely on this file. In

RFR: 8298178: Update to use jtreg 7.1.1

2022-12-06 Thread Christian Stein
Please review the change to update to using jtreg 7.1.1. The primary change is to the `jib-profiles.js` file, which specifies the version of jtreg to use, for those systems that rely on this file. In addition, the requiredVersion has been updated in the various `TEST.ROOT` files. This pull

Re: RFR: 8298178: Update to use jtreg 7.1.1

2022-12-06 Thread Christian Stein
On Tue, 6 Dec 2022 16:07:44 GMT, Christian Stein wrote: > Please review the change to update to using jtreg 7.1.1. > > The primary change is to the `jib-profiles.js` file, which specifies the > version of jtreg to use, for those systems that rely on this file. In

RFR: 8298178: Update to use jtreg 7.1.1

2022-12-06 Thread Christian Stein
Please review the change to update to using jtreg 7.1.1. The primary change is to the `jib-profiles.js` file, which specifies the version of jtreg to use, for those systems that rely on this file. In addition, the requiredVersion has been updated in the various `TEST.ROOT` files. This pull

Integrated: 8296710: Update to use jtreg 7.1

2022-12-01 Thread Christian Stein
On Tue, 29 Nov 2022 14:44:12 GMT, Christian Stein wrote: > Please review the change to update to using jtreg `7.1`. > > The primary change is to the `jib-profiles.js` file, which specifies the > version of jtreg to use, for those systems that rely on this file. In

Integrated: 8296710: Update to use jtreg 7.1

2022-12-01 Thread Christian Stein
On Tue, 29 Nov 2022 14:44:12 GMT, Christian Stein wrote: > Please review the change to update to using jtreg `7.1`. > > The primary change is to the `jib-profiles.js` file, which specifies the > version of jtreg to use, for those systems that rely on this file. In

RFR: 8296710: Update to use jtreg 7.1

2022-11-29 Thread Christian Stein
Please review the change to update to using jtreg `7.1`. The primary change is to the `jib-profiles.js` file, which specifies the version of jtreg to use, for those systems that rely on this file. In addition, the requiredVersion has been updated in the various `TEST.ROOT` files. This pull

RFR: 8296710: Update to use jtreg 7.1

2022-11-29 Thread Christian Stein
Please review the change to update to using jtreg `7.1`. The primary change is to the `jib-profiles.js` file, which specifies the version of jtreg to use, for those systems that rely on this file. In addition, the requiredVersion has been updated in the various `TEST.ROOT` files. This pull

Integrated: 8236919: Refactor com.sun.tools.javac.main.CommandLine into a reusable module for other JDK tools

2022-11-28 Thread Christian Stein
On Mon, 21 Nov 2022 15:40:19 GMT, Christian Stein wrote: > This PR copies the `CommandLine.java` file from module `jdk.compiler` > (package `com.sun.tools.javac.main`) into the `jdk.internal.opt` module, > creating a new package with name `jdk.internal.opt`. That new > `jdk.

Re: RFR: 8236919: Refactor com.sun.tools.javac.main.CommandLine into a reusable module for other JDK tools [v3]

2022-11-23 Thread Christian Stein
rule". > - [x] Remove `CommandLine.java` from `jdk.jartool` module > - [x] Remove `CommandLine.java` from `jdk.jlink` module > - [x] Remove `CommandLine.java` from `jdk.jpackage` module > - [x] Check for related but renamed(?) usages of `CommandLine.java` in other > JDK tools: `js

Re: RFR: 8297444: Refactor the javacserver build tool [v2]

2022-11-23 Thread Christian Stein
On Tue, 22 Nov 2022 23:40:30 GMT, Magnus Ihse Bursie wrote: >> Now that the javacserver no longer has any ambitions outside being a >> buildtool customized for the JDK build process, a lot of abstractions and >> generalizations can be removed. >> >> This will allow the actual behavior to be

Re: RFR: 8236919: Refactor com.sun.tools.javac.main.CommandLine into a reusable module for other JDK tools [v2]

2022-11-22 Thread Christian Stein
rule". > - [x] Remove `CommandLine.java` from `jdk.jartool` module > - [x] Remove `CommandLine.java` from `jdk.jlink` module > - [x] Remove `CommandLine.java` from `jdk.jpackage` module > - [x] Check for related but renamed(?) usages of `CommandLine.java` in other > JDK tools: `js

Re: RFR: 8236919: Refactor com.sun.tools.javac.main.CommandLine into a reusable module for other JDK tools

2022-11-22 Thread Christian Stein
On Mon, 21 Nov 2022 15:40:19 GMT, Christian Stein wrote: > This PR copies the `CommandLine.java` file from module `jdk.compiler` > (package `com.sun.tools.javac.main`) into the `jdk.internal.opt` module, > creating a new package with name `jdk.internal.opt`. That new > `jdk.

RFR: 8236919: Refactor com.sun.tools.javac.main.CommandLine into a reusable module for other JDK tools

2022-11-21 Thread Christian Stein
This PR copies the `CommandLine.java` file from module `jdk.compiler` (package `com.sun.tools.javac.main`) into the `jdk.internal.opt` module, creating a new package with name `jdk.internal.opt`. That new `jdk.internal.opt` package is then exported to the following modules: - `jdk.jartool` -

Re: RFR: 8297041: Remove the last remnants of sjavac

2022-11-16 Thread Christian Stein
On Wed, 16 Nov 2022 14:06:16 GMT, Erik Joelsson wrote: > Or is the replacement so imminent that it's not worth the effort? This. I aim to replace `javacserver` with a well-tested `javatoolportal` buildtool in the coming months. An almost working POC is already available - but forcing it to go

Re: RFR: 8297041: Remove the last remnants of sjavac

2022-11-16 Thread Christian Stein
On Wed, 16 Nov 2022 13:22:43 GMT, Magnus Ihse Bursie wrote: > The sjavac ("smart javac") was an ambitious project. It should parallelize > java compilation, create a background daemon process that kept the JVM "hot" > with the JITted javac code, define a public api so only noticeable changes

Integrated: JDK-8289798: Update to use jtreg 7

2022-09-07 Thread Christian Stein
On Wed, 6 Jul 2022 08:24:21 GMT, Christian Stein wrote: > Please review the change to update to using jtreg 7. > > The primary change is to the `jib-profiles.js` file, which specifies the > version of jtreg to use, for those systems that rely on this file. In > addition, the `

Integrated: JDK-8289798: Update to use jtreg 7

2022-09-07 Thread Christian Stein
On Wed, 6 Jul 2022 08:24:21 GMT, Christian Stein wrote: > Please review the change to update to using jtreg 7. > > The primary change is to the `jib-profiles.js` file, which specifies the > version of jtreg to use, for those systems that rely on this file. In > addition, the `

Re: RFR: JDK-8289798: Update to use jtreg 7 [v6]

2022-09-05 Thread Christian Stein
On Mon, 5 Sep 2022 07:38:33 GMT, Thomas Stuefe wrote: > So I guess at the minimum we would have to downport those test changes to be > able to test older JDKs with the new jtreg, right? Yes. Otherwise those tests will fail as they still do depend on hard-coded names of 3rd-party JAR files.

Re: RFR: JDK-8289798: Update to use jtreg 7 [v6]

2022-09-05 Thread Christian Stein
On Mon, 5 Sep 2022 07:38:33 GMT, Thomas Stuefe wrote: > So I guess at the minimum we would have to downport those test changes to be > able to test older JDKs with the new jtreg, right? Yes. Otherwise those tests will fail as they still do depend on hard-coded names of 3rd-party JAR files.

Re: RFR: JDK-8289798: Update to use jtreg 7 [v6]

2022-09-05 Thread Christian Stein
On Mon, 5 Sep 2022 06:36:04 GMT, Thomas Stuefe wrote: > Is jtreg 7 downward compatible? Can I use it to test older JDKs, if yes, down > to which version? Yes, down to JDK 11. Quote from [Coming soon: jtreg 7](https://mail.openjdk.org/pipermail/jdk-dev/2022-August/006869.html) > Also

Re: RFR: JDK-8289798: Update to use jtreg 7 [v6]

2022-09-05 Thread Christian Stein
On Mon, 5 Sep 2022 06:36:04 GMT, Thomas Stuefe wrote: > Is jtreg 7 downward compatible? Can I use it to test older JDKs, if yes, down > to which version? Yes, down to JDK 11. Quote from [Coming soon: jtreg 7](https://mail.openjdk.org/pipermail/jdk-dev/2022-August/006869.html) > Also

Re: RFR: JDK-8289798: Update to use jtreg 7 [v6]

2022-09-05 Thread Christian Stein
.ROOT` > files. Christian Stein has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 14 commits: - Merge branch 'openjdk:master' into JDK-8289798-jtreg-7 - Merge branch 'openjdk:master' into JDK-8289798-jtreg-7 - Update configure to

Re: RFR: JDK-8289798: Update to use jtreg 7 [v6]

2022-09-05 Thread Christian Stein
.ROOT` > files. Christian Stein has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 14 commits: - Merge branch 'openjdk:master' into JDK-8289798-jtreg-7 - Merge branch 'openjdk:master' into JDK-8289798-jtreg-7 - Update configure to

Re: RFR: JDK-8289798: Update to use jtreg 7 [v5]

2022-08-30 Thread Christian Stein
On Tue, 30 Aug 2022 09:14:12 GMT, Jaikiran Pai wrote: > Hello Christian, is it intentional that in some file the minimum required > jtreg version is represented as `7` (`lib-tests.m4`) and in some other files > as `7+1` (GitHub actions config file, then the TEST.ROOT files)? Yes. Some systems

Re: RFR: JDK-8289798: Update to use jtreg 7 [v5]

2022-08-30 Thread Christian Stein
On Tue, 30 Aug 2022 09:14:12 GMT, Jaikiran Pai wrote: > Hello Christian, is it intentional that in some file the minimum required > jtreg version is represented as `7` (`lib-tests.m4`) and in some other files > as `7+1` (GitHub actions config file, then the TEST.ROOT files)? Yes. Some systems

Re: RFR: JDK-8289798: Update to use jtreg 7 [v5]

2022-08-23 Thread Christian Stein
.ROOT` > files. Christian Stein has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 13 commits: - Merge branch 'openjdk:master' into JDK-8289798-jtreg-7 - Update configure to check for jtreg 7 or later - Merge branch 'openjdk:master

Re: RFR: JDK-8289798: Update to use jtreg 7 [v5]

2022-08-23 Thread Christian Stein
.ROOT` > files. Christian Stein has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 13 commits: - Merge branch 'openjdk:master' into JDK-8289798-jtreg-7 - Update configure to check for jtreg 7 or later - Merge branch 'openjdk:master

Re: RFR: JDK-8289798: Update to use jtreg 7 [v4]

2022-08-23 Thread Christian Stein
.ROOT` > files. Christian Stein has updated the pull request incrementally with one additional commit since the last revision: Update configure to check for jtreg 7 or later - Changes: - all: https://git.openjdk.org/jdk/pull/9393/files - new: https://git.openjdk.org/jdk/pull/9

Re: RFR: JDK-8289798: Update to use jtreg 7 [v4]

2022-08-23 Thread Christian Stein
.ROOT` > files. Christian Stein has updated the pull request incrementally with one additional commit since the last revision: Update configure to check for jtreg 7 or later - Changes: - all: https://git.openjdk.org/jdk/pull/9393/files - new: https://git.openjdk.org/jdk/pull/9

Re: RFR: JDK-8289798: Update to use jtreg 7 [v3]

2022-08-23 Thread Christian Stein
.ROOT` > files. Christian Stein has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 11 commits: - Merge branch 'openjdk:master' into JDK-8289798-jtreg-7 - Merge branch 'openjdk:master' into JDK-8289798-jtreg-7 - Revert junit.java

Re: RFR: JDK-8289798: Update to use jtreg 7 [v3]

2022-08-23 Thread Christian Stein
.ROOT` > files. Christian Stein has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 11 commits: - Merge branch 'openjdk:master' into JDK-8289798-jtreg-7 - Merge branch 'openjdk:master' into JDK-8289798-jtreg-7 - Revert junit.java

Re: RFR: JDK-8289798: Update to use jtreg 7 [v2]

2022-08-22 Thread Christian Stein
.ROOT` > files. Christian Stein has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 10 commits: - Merge branch 'openjdk:master' into JDK-8289798-jtreg-7 - Revert junit.java Commit https://github.com/

Re: RFR: JDK-8289798: Update to use jtreg 7 [v2]

2022-08-22 Thread Christian Stein
.ROOT` > files. Christian Stein has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 10 commits: - Merge branch 'openjdk:master' into JDK-8289798-jtreg-7 - Revert junit.java Commit https://github.com/

Re: RFR: JDK-8289798: Update to use jtreg 7

2022-08-20 Thread Christian Stein
On Wed, 6 Jul 2022 08:24:21 GMT, Christian Stein wrote: > Please review the change to update to using jtreg 7. > > The primary change is to the `jib-profiles.js` file, which specifies the > version of jtreg to use, for those systems that rely on this file. In > addition, the `

Re: RFR: JDK-8289798: Update to use jtreg 7

2022-08-20 Thread Christian Stein
On Wed, 6 Jul 2022 08:24:21 GMT, Christian Stein wrote: > Please review the change to update to using jtreg 7. > > The primary change is to the `jib-profiles.js` file, which specifies the > version of jtreg to use, for those systems that rely on this file. In > addition, the `

RFR: JDK-8289798: Update to use jtreg 7

2022-08-20 Thread Christian Stein
Please review the change to update to using jtreg 7. The primary change is to the `jib-profiles.js` file, which specifies the version of jtreg to use, for those systems that rely on this file. In addition, the `requiredVersion` has been updated in the various `TEST.ROOT` files. -

RFR: JDK-8289798: Update to use jtreg 7

2022-08-20 Thread Christian Stein
Please review the change to update to using jtreg 7. The primary change is to the `jib-profiles.js` file, which specifies the version of jtreg to use, for those systems that rely on this file. In addition, the `requiredVersion` has been updated in the various `TEST.ROOT` files. -

Integrated: 8292182: [TESTLIB] Enhance JAXPPolicyManager to setup required permissions for jtreg version 7 jar

2022-08-15 Thread Christian Stein
On Fri, 12 Aug 2022 16:26:30 GMT, Christian Stein wrote: > Enhance `JAXPPolicyManager` to setup required permissions for `jtreg` 7 by > accept version information in JAR file names. > > Find details in https://bugs.openjdk.org/browse/JDK-8292182 This pull request has now bee

Re: RFR: 8292182: [TESTLIB] Enhance JAXPPolicyManager to setup required permissions for jtreg version 7 jar [v3]

2022-08-13 Thread Christian Stein
> Enhance `JAXPPolicyManager` to setup required permissions for `jtreg` 7 by > accept version information in JAR file names. > > Find details in https://bugs.openjdk.org/browse/JDK-8292182 Christian Stein has updated the pull request incrementally with one additional commit si

Re: RFR: 8292182: [TESTLIB] Enhance JAXPPolicyManager to setup required permissions for jtreg version 7 jar [v2]

2022-08-12 Thread Christian Stein
On Sat, 13 Aug 2022 03:41:04 GMT, Jaikiran Pai wrote: >> Christian Stein has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Remove unused import statement > > test/jaxp/javax/xml/jaxp/libs/jaxp/library/J

Re: RFR: 8292182: [TESTLIB] Enhance JAXPPolicyManager to setup required permissions for jtreg version 7 jar [v2]

2022-08-12 Thread Christian Stein
On Fri, 12 Aug 2022 20:18:50 GMT, Naoto Sato wrote: >> Christian Stein has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Remove unused import statement > > test/jaxp/javax/xml/jaxp/libs/jaxp/library/

RFR: 8292182: [TESTLIB] Enhance JAXPPolicyManager to setup required permissions for jtreg version 7 jar

2022-08-12 Thread Christian Stein
Enhance `JAXPPolicyManager` to setup required permissions for `jtreg` 7 by accept version information in JAR file names. Find details in https://bugs.openjdk.org/browse/JDK-8292182 - Commit messages: - 8292182: [TESTLIB] Enhance JAXPPolicyManager to setup required permissions for

Re: RFR: 8287760: --do-not-resolve-by-default gets overwritten if --warn-if-resolved flags is used [v9]

2022-06-17 Thread Christian Stein
On Fri, 10 Jun 2022 18:28:46 GMT, Thiago Henrique Hüpner wrote: >> 8287760: --do-not-resolve-by-default gets overwritten if --warn-if-resolved >> flags is used > > Thiago Henrique Hüpner has updated the pull request incrementally with one > additional commit since the last revision: > >

Re: RFR: 8287906: Rewrite of GitHub Actions (GHA) sanity tests [v12]

2022-06-13 Thread Christian Stein
On Mon, 13 Jun 2022 06:45:49 GMT, Magnus Ihse Bursie wrote: >> With project Skara, the ability to run a set of sanity build and test jobs >> on selected platforms was added. This functionality was driven by >> `.github/workflows/submit.yml`. This file unfortunately lacks any real >>

Integrated: 8287121: Fix typo in jlink's description resource key lookup

2022-05-24 Thread Christian Stein
On Sun, 22 May 2022 05:58:25 GMT, Christian Stein wrote: > Commit > https://github.com/openjdk/jdk/commit/655500a4f5e3abcff176599604deceefb6ca6640 > for issue [JDK-8286654](https://bugs.openjdk.java.net/browse/JDK-8286654) > added an optional description accessor on the `

Re: RFR: 8287121: Fix typo in jlink's description resource key lookup

2022-05-24 Thread Christian Stein
On Tue, 24 May 2022 04:58:44 GMT, Jaikiran Pai wrote: >> Commit >> https://github.com/openjdk/jdk/commit/655500a4f5e3abcff176599604deceefb6ca6640 >> for issue [JDK-8286654](https://bugs.openjdk.java.net/browse/JDK-8286654) >> added an optional description accessor on the `ToolProvider`

Re: RFR: 8279031: Add API note to ToolProvider about being reusable/reentrant [v2]

2022-05-23 Thread Christian Stein
On Tue, 24 May 2022 04:50:58 GMT, Jaikiran Pai wrote: >> Christian Stein has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Update src/java.base/share/classes/java/util/spi/ToolProvider.java >>

Re: RFR: 8279031: Add API note to ToolProvider about being reusable/reentrant [v2]

2022-05-23 Thread Christian Stein
On Mon, 23 May 2022 10:32:09 GMT, Anthony Vanelverdinghe wrote: >> Christian Stein has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Update src/java.base/share/classes/java/util/spi/ToolProvider.java >>

Re: RFR: 8279031: Add API note to ToolProvider about being reusable/reentrant [v2]

2022-05-23 Thread Christian Stein
> This commit adds an API note to ToolProvider about being reusable/reentrant. Christian Stein has updated the pull request incrementally with one additional commit since the last revision: Update src/java.base/share/classes/java/util/spi/ToolProvider.java Co-authored-by: Anth

RFR: 8279031: Add API note to ToolProvider about being reusable/reentrant

2022-05-23 Thread Christian Stein
This commit adds an API note to ToolProvider about being reusable/reentrant. - Commit messages: - 8286815: Add API note to ToolProvider about being reusable/reentrant Changes: https://git.openjdk.java.net/jdk/pull/8833/files Webrev:

RFR: 8287121: Fix typo in jlink's description resource key lookup

2022-05-22 Thread Christian Stein
Commit https://github.com/openjdk/jdk/commit/655500a4f5e3abcff176599604deceefb6ca6640 for issue [JDK-8286654](https://bugs.openjdk.java.net/browse/JDK-8286654) added an optional description accessor on the `ToolProvider` interface. It included a typo in` jlink`'s description resource key

Integrated: 8286654: Add an optional description accessor on ToolProvider interface

2022-05-19 Thread Christian Stein
On Wed, 18 May 2022 14:56:47 GMT, Christian Stein wrote: > This PR adds an optional description accessor on `ToolProvider` interface. > > This PR also adds short description for each of the listed tool: > - `jar` > - `javac` > - `javadoc` > - `javap` and `jdeps`

Integrated: 8286654: Add an optional description accessor on ToolProvider interface

2022-05-19 Thread Christian Stein
On Wed, 18 May 2022 14:56:47 GMT, Christian Stein wrote: > This PR adds an optional description accessor on `ToolProvider` interface. > > This PR also adds short description for each of the listed tool: > - `jar` > - `javac` > - `javadoc` > - `javap` and `jdeps`

Re: RFR: 8286654: Add an optional description accessor on ToolProvider interface

2022-05-19 Thread Christian Stein
On Thu, 19 May 2022 06:21:40 GMT, Christian Stein wrote: >> src/jdk.compiler/share/classes/com/sun/tools/javac/resources/javac.properties >> line 387: >> >>> 385: >>> 386: javac.description=Read Java declarations and compile them into class >>

<    1   2   3   4   5   6   >