[jira] [Commented] (SUREFIRE-1733) Surefire and Failsafe JPMS additions for JUnit 5.x execution

2020-06-23 Thread Christian Stein (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17142692#comment-17142692 ] Christian Stein commented on SUREFIRE-1733: --- I created a proof-of-concept PR against your

[jira] [Commented] (SUREFIRE-1733) Surefire and Failsafe JPMS additions for JUnit 5.x execution

2020-06-23 Thread Christian Stein (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17142664#comment-17142664 ] Christian Stein commented on SUREFIRE-1733: --- Java modules are declared by developers

[jira] [Comment Edited] (SUREFIRE-1633) [JUnit5 follow-up #1343] JUnit Jupiter @Nested tests do not run when selecting enclosing class with Surefire

2020-06-13 Thread Christian Stein (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17134922#comment-17134922 ] Christian Stein edited comment on SUREFIRE-1633 at 6/13/20, 6:40 PM

[jira] [Commented] (SUREFIRE-1633) [JUnit5 follow-up #1343] JUnit Jupiter @Nested tests do not run when selecting enclosing class with Surefire

2020-06-13 Thread Christian Stein (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17134922#comment-17134922 ] Christian Stein commented on SUREFIRE-1633: --- [~vmassol] Did you try to reset the default

[jira] [Commented] (SUREFIRE-1633) [JUnit5 follow-up #1343] JUnit Jupiter @Nested tests do not run when selecting enclosing class with Surefire

2020-06-10 Thread Christian Stein (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17132577#comment-17132577 ] Christian Stein commented on SUREFIRE-1633: --- Find details why we moved the issue here

[jira] [Commented] (SUREFIRE-1765) target/test-classes should not be added to classpath when tests run on modulepath using patch-module

2020-06-08 Thread Christian Stein (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17128106#comment-17128106 ] Christian Stein commented on SUREFIRE-1765: --- With Surefire 3.0.0-M5 being released soon

[jira] [Commented] (SUREFIRE-1733) Surefire and Failsafe JPMS additions for JUnit 5.x execution

2020-06-06 Thread Christian Stein (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17127485#comment-17127485 ] Christian Stein commented on SUREFIRE-1733: --- > There must be some bug in JUnit5 why I

Re: jlink 14.0.1 with 100 modules fail

2020-05-31 Thread Christian Stein
On Sun, May 31, 2020 at 8:52 AM Alan Bateman wrote: > > > On 30/05/2020 17:40, Christian Stein wrote: > > Hi, > > > > the modular [bach-demo-99] I generated to check my build tool > > against, failed to create a custom runtime image using jlink > > via it

Re: jlink 14.0.1 with 100 modules fail

2020-05-30 Thread Christian Stein
Thanks for the quick response. On Sat, May 30, 2020 at 7:05 PM Remi Forax wrote: > > > Shall I open an issue at JBS? > > yes ! > > Done: https://bugs.openjdk.java.net/browse/JDK-8246197

jlink 14.0.1 with 100 modules fail

2020-05-30 Thread Christian Stein
Hi, the modular [bach-demo-99] I generated to check my build tool against, failed to create a custom runtime image using jlink via itsToolProvider-based service entry-point. The project consists of 100 module descriptors. No other Java source files (for classes and interfaces) are part of that

Re: [VOTE] Release Apache Maven Surefire Plugin version 2.22.3

2020-05-04 Thread Christian Stein
On Mon, May 4, 2020 at 6:45 PM Romain Manni-Bucau wrote: > Le lun. 4 mai 2020 à 18:30, Stephane Nicoll a > écrit : > > ... > OK. Why is our build failing with that error if we're importing the JUnit > > 5.5.2 bom and it does not fail if we're importing the JUnit 5.6.2 bom? > Our > > test

Re: [VOTE] Release Apache Maven Surefire Plugin version 2.22.3

2020-05-04 Thread Christian Stein
On Mon, May 4, 2020 at 5:17 PM Romain Manni-Bucau wrote: > Le lun. 4 mai 2020 à 17:06, Stephane Nicoll a > écrit : > > > Thanks but that doesn't really answer my question. That version is picked > > up by dependency management of the project as far as I can tell. If a > > project does provide

Re: source directory layout for multirelease jars

2020-05-01 Thread Christian Stein
On Fri, May 1, 2020 at 1:52 PM Hervé BOUTEMY wrote: > when the need is restricted META-INF/versions/9/module-info.class, ie not > really code per Java release, but only module or not module, isn't one > strategy better to use, given there should be less tests to be run? > > perhaps the answer is

[jira] [Commented] (SUREFIRE-1733) Surefire and Failsafe JPMS additions for JUnit 5.x execution

2020-04-29 Thread Christian Stein (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17095869#comment-17095869 ] Christian Stein commented on SUREFIRE-1733: --- As can be seen above in this thread, qualified

[jira] [Commented] (SUREFIRE-1733) Surefire and Failsafe JPMS additions for JUnit 5.x execution

2020-04-29 Thread Christian Stein (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17095866#comment-17095866 ] Christian Stein commented on SUREFIRE-1733: --- You're exposing internal information

[jira] [Comment Edited] (SUREFIRE-1733) Surefire and Failsafe JPMS additions for JUnit 5.x execution

2020-04-29 Thread Christian Stein (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17095861#comment-17095861 ] Christian Stein edited comment on SUREFIRE-1733 at 4/29/20, 8:07 PM

[jira] [Comment Edited] (SUREFIRE-1733) Surefire and Failsafe JPMS additions for JUnit 5.x execution

2020-04-29 Thread Christian Stein (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17095861#comment-17095861 ] Christian Stein edited comment on SUREFIRE-1733 at 4/29/20, 8:06 PM

[jira] [Commented] (SUREFIRE-1733) Surefire and Failsafe JPMS additions for JUnit 5.x execution

2020-04-29 Thread Christian Stein (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17095861#comment-17095861 ] Christian Stein commented on SUREFIRE-1733: --- We are not talking about having those qualified

[jira] [Commented] (SUREFIRE-1733) Surefire and Failsafe JPMS additions for JUnit 5.x execution

2020-04-29 Thread Christian Stein (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17095853#comment-17095853 ] Christian Stein commented on SUREFIRE-1733: --- Ah, okay. I see ... and will stick to `--patch

[jira] [Commented] (SUREFIRE-1733) Surefire and Failsafe JPMS additions for JUnit 5.x execution

2020-04-29 Thread Christian Stein (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17095845#comment-17095845 ] Christian Stein commented on SUREFIRE-1733: --- jdk.internal.misc.SharedSecrets seizes to work

[jira] [Commented] (SUREFIRE-1733) Surefire and Failsafe JPMS additions for JUnit 5.x execution

2020-04-29 Thread Christian Stein (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17095824#comment-17095824 ] Christian Stein commented on SUREFIRE-1733: --- [~rfscholte] summoned me ... and I still

Re: source directory layout for multirelease jars

2020-04-24 Thread Christian Stein
Robert (?) wrote this page [0] about supporting MR-JAR files. There're several approaches to the topic. It'd be nice, if the compiler- and the jar-plugin would pick one by default or based on a directory layout convention. [0]:

[jira] [Resolved] (SUREFIRE-1764) Upgrade Surefire 2.22.x to junit-platform-launcher 1.6.1

2020-03-28 Thread Christian Stein (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1764?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christian Stein resolved SUREFIRE-1764. --- Resolution: Fixed Done. > Upgrade Surefire 2.22.x to junit-platform-launc

[jira] [Updated] (SUREFIRE-1764) Upgrade Surefire 2.22.x to junit-platform-launcher 1.6.1

2020-03-28 Thread Christian Stein (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1764?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christian Stein updated SUREFIRE-1764: -- Fix Version/s: 2.22.3 > Upgrade Surefire 2.22.x to junit-platform-launcher 1.

[jira] [Commented] (SUREFIRE-1764) Upgrade Surefire 2.22.x to junit-platform-launcher 1.6.1

2020-03-27 Thread Christian Stein (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17068564#comment-17068564 ] Christian Stein commented on SUREFIRE-1764: --- Commit  [https://github.com/apache/maven

[jira] [Updated] (SUREFIRE-1764) Upgrade Surefire 2.22.x to junit-platform-launcher 1.6.1

2020-03-25 Thread Christian Stein (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1764?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christian Stein updated SUREFIRE-1764: -- Summary: Upgrade Surefire 2.22.x to junit-platform-launcher 1.6.1 (was: Upgrade

[jira] [Commented] (SUREFIRE-1757) maven-surefire-plugin versions starting from 2.22.0 do not run JUnit5 Test Suites junit-platform-runner

2020-03-25 Thread Christian Stein (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17066593#comment-17066593 ] Christian Stein commented on SUREFIRE-1757: --- Hi [~DenysGalyuk] See this [https

[jira] [Updated] (SUREFIRE-1764) Upgrade to junit-platform-launcher 1.6.x

2020-03-25 Thread Christian Stein (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1764?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christian Stein updated SUREFIRE-1764: -- Affects Version/s: (was: 3.0.0-M4) > Upgrade to junit-platform-launcher 1.

[jira] [Created] (SUREFIRE-1764) Upgrade to junit-platform-launcher 1.6.x

2020-03-25 Thread Christian Stein (Jira)
Christian Stein created SUREFIRE-1764: - Summary: Upgrade to junit-platform-launcher 1.6.x Key: SUREFIRE-1764 URL: https://issues.apache.org/jira/browse/SUREFIRE-1764 Project: Maven Surefire

Re: RFE simplify usage of patched module [by Robert Scholte, from jdk-dev]

2020-02-19 Thread Christian Stein
On Tue, Feb 18, 2020 at 6:42 PM Alex Buckley wrote: > > Good description of how the main module > [...] > etc. Then, the build tool can enrich the main module by passing > --add-modules, --add-reads, and --add-opens to javac/java while in a > test scope. No need for --patch-module-descriptor in

Re: RFE simplify usage of patched module [by Robert Scholte, from jdk-dev]

2020-02-17 Thread Christian Stein
I extended the example project with some potential use-cases for the `--patch-module-descriptor` option at [0]. Those use-cases show which command line option usages can be replaced and therefore simplified (as this RFE thread was coined) in the form of the following example: Today:

Re: RFE simplify usage of patched module [by Robert Scholte, from jdk-dev]

2020-02-14 Thread Christian Stein
On Fri, Feb 14, 2020 at 10:31 PM Alex Buckley wrote: > On 2/14/2020 11:29 AM, Christian Stein wrote: > >> A different way to address those use cases would be to ship the > >> logic just described for `--patch-module-descriptor` in a launcher > >> offere

Re: RFE simplify usage of patched module [by Robert Scholte, from jdk-dev]

2020-02-14 Thread Christian Stein
Hi Alex, On Fri, Feb 14, 2020 at 7:06 PM Alex Buckley wrote: > [...] Now, I am not "proposing" `--patch-module-descriptor` for a future JDK. > I am recognizing that certain use cases involve changing a module's > dependences and encapsulation in a tightly scoped way. I can clearly envision

Re: RFE simplify usage of patched module [by Robert Scholte, from jdk-dev]

2020-02-14 Thread Christian Stein
that suggestion, though. I'll send this answer anyway -- to round-up and effectively close this sub-thread. On Mon, Feb 10, 2020 at 11:03 PM Alex Buckley wrote: > Hi Christian, > > On 2/7/2020 4:41 AM, Christian Stein wrote: > > This time, I created a project at [0] with a detailed des

Re: Maven GroupID authority

2020-02-13 Thread Christian Stein
On Fri, Feb 14, 2020 at 8:11 AM Hervé BOUTEMY wrote: > on that precise case ("commons" instead of "org.apache.commons"), it's > from > past Maven 1 repository format time. > > then such case is not added to Central for years, only projects that > existed > at early Maven 1 repository time (like

Re: Maven GroupID authority

2020-02-13 Thread Christian Stein
On Fri, Feb 14, 2020 at 6:37 AM Manfred Moser wrote: > From the very start of the work on the module system and throughout the > work people from the Maven project have been involved. > > There was never a willingness to create any sort of enforcement.. only a > request to the community to do

[jira] [Commented] (SUREFIRE-1688) Junit Platform test with failing @BeforeAll does not fail the build

2020-02-12 Thread Christian Stein (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17035285#comment-17035285 ] Christian Stein commented on SUREFIRE-1688: --- Sounds great. Thanks for clarifying, Tibor

[jira] [Reopened] (SUREFIRE-1688) Junit Platform test with failing @BeforeAll does not fail the build

2020-02-10 Thread Christian Stein (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1688?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christian Stein reopened SUREFIRE-1688: --- Failing test case was offered by Marc Philipp and another user reported the same

[jira] [Commented] (SUREFIRE-1688) Junit Platform test with failing @BeforeAll does not fail the build

2020-02-10 Thread Christian Stein (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17033712#comment-17033712 ] Christian Stein commented on SUREFIRE-1688: --- {quote}[DEBUG] -- end configuration -- [DEBUG

Re: RFE simplify usage of patched module [by Robert Scholte, from jdk-dev]

2020-02-07 Thread Christian Stein
On Thu, Feb 6, 2020 at 8:35 AM Christian Stein wrote: > I agree with you, that the user (the build tool in most of the cases) > should > stay in control which module descriptor is in effect for every module. > > As my domain is testing, and I guess the majority of uses-

Re: RFE simplify usage of patched module [by Robert Scholte, from jdk-dev]

2020-02-05 Thread Christian Stein
I agree with you, that the user (the build tool in most of the cases) should stay in control which module descriptor is in effect for every module. As my domain is testing, and I guess the majority of uses-cases is within the realm of intra-module (white-box) testing, I'll expound on the topic

Re: RFE simplify usage of patched module [by Robert Scholte, from jdk-dev]

2020-02-04 Thread Christian Stein
On Wed, Feb 5, 2020 at 4:47 AM Christian Stein wrote: > // Hope this email will be technically associated as a reply for the > // "RFE simplify usage of patched module" thread. > > I agree with Robert that a user-friendly and (build) tool-agnostic way > to express add

Re: RFE simplify usage of patched module [by Robert Scholte, from jdk-dev]

2020-02-04 Thread Christian Stein
// Hope this email will be technically associated as a reply for the // "RFE simplify usage of patched module" thread. I agree with Robert that a user-friendly and (build) tool-agnostic way to express additional module directives and modifiers for testing purposes only is ... a good thing to

RFE simplify usage of patched module [by Robert Scholte, from jdk-dev]

2020-02-04 Thread Christian Stein
Hi, I took the freedom moving this thread to "jigsaw-dev", as suggested by David Holmes, in order to reply to it in a follow-up mail. I hope, Robert doesn't mind that I copy his text from "jdk-dev" below to start with the same context. Robert Scholte wrote in

javac/jdeps and requires with version

2020-01-10 Thread Christian Stein
Hi, given an empty module declaration: module foo{} Compile it with javac using various valid "--release r" variants yields different module descriptors in addition to the generated class file version. For JDK N, javac seems to include the version of a required module only if you omit the

[jira] [Commented] (SUREFIRE-1563) NoClassDefFoundError for JPMS modules with "require static"

2020-01-01 Thread Christian Stein (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17006605#comment-17006605 ] Christian Stein commented on SUREFIRE-1563: --- IntelliJ IDEA 2020.1 supports the `module

Re: New Commiter: Elliotte Rusty Harold

2019-12-13 Thread Christian Stein
Cheers, Elliote! On Fri, Dec 13, 2019 at 8:39 PM Enrico Olivelli wrote: > Welcome! > > Kudos > > Enrico > > Il ven 13 dic 2019, 19:31 Martin Gainty ha scritto: > > > welcome Elliotte! > > > > martin > > > > > > From: Karl Heinz Marbaise > > Sent: Friday,

[jira] [Comment Edited] (SUREFIRE-1563) NoClassDefFoundError for JPMS modules with "require static"

2019-12-01 Thread Christian Stein (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16985529#comment-16985529 ] Christian Stein edited comment on SUREFIRE-1563 at 12/1/19 11:18 AM

[jira] [Commented] (SUREFIRE-1563) NoClassDefFoundError for JPMS modules with "require static"

2019-12-01 Thread Christian Stein (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16985531#comment-16985531 ] Christian Stein commented on SUREFIRE-1563: --- {quote}[...] the *non-official* `module

[jira] [Comment Edited] (SUREFIRE-1563) NoClassDefFoundError for JPMS modules with "require static"

2019-12-01 Thread Christian Stein (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16985529#comment-16985529 ] Christian Stein edited comment on SUREFIRE-1563 at 12/1/19 11:16 AM

[jira] [Commented] (SUREFIRE-1563) NoClassDefFoundError for JPMS modules with "require static"

2019-12-01 Thread Christian Stein (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16985529#comment-16985529 ] Christian Stein commented on SUREFIRE-1563: --- Perhaps, Surefire should support the non

[jira] [Comment Edited] (SUREFIRE-1698) Parameter "skipAfterFailureCount" no working

2019-10-17 Thread Christian Stein (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16953638#comment-16953638 ] Christian Stein edited comment on SUREFIRE-1698 at 10/17/19 11:27 AM

[jira] [Commented] (SUREFIRE-1698) Parameter "skipAfterFailureCount" no working

2019-10-17 Thread Christian Stein (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16953638#comment-16953638 ] Christian Stein commented on SUREFIRE-1698: --- Wouldn't a custom `TestWatcher

Re: [shade plugin] common code with gradle shadow plugin?

2019-07-15 Thread Christian Stein
proguard plays in the same realm. Olivier Lamy schrieb am Mo., 15. Juli 2019, 13:02: > Hi > Sounds a good idea! > > On Sat, 13 Jul 2019 at 04:30, Romain Manni-Bucau > wrote: > > > Hello (again) everyone, > > > > Gradle shadow plugin - kind of shade plugin for gradle - forked Apache > > Maven

[jira] [Commented] (SUREFIRE-1673) Surefire does not detect junit 5.5.0 tests when running a maven build

2019-07-12 Thread Christian Stein (JIRA)
[ https://issues.apache.org/jira/browse/SUREFIRE-1673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16884017#comment-16884017 ] Christian Stein commented on SUREFIRE-1673: --- Does it work with Surefire 2.22.2? Seeing your

Re: Add "source of module name" to ModuleDescriptor API

2019-07-04 Thread Christian Stein
On Tue, Jul 2, 2019 at 1:14 PM Alan Bateman wrote: > On 02/07/2019 09:47, Christian Stein wrote: > > Hi, > > > > at the moment, class `java.lang.module.ModuleDescriptor` only > > provides an `isAutomatic()` getter -- which doesn't allow to > > determine from wh

Add "source of module name" to ModuleDescriptor API

2019-07-02 Thread Christian Stein
Hi, at the moment, class `java.lang.module.ModuleDescriptor` only provides an `isAutomatic()` getter -- which doesn't allow to determine from where the module name actually came from. Program `PresentModule.java` [1] creates a `JarFile` instance to determine the source of an automatic module.

Re: Anyone had an error on Eclipse IDE after upgrade maven-jar-plugin to 3.1.2?

2019-06-08 Thread Christian Stein
On Sat, Jun 8, 2019 at 6:14 PM Mickael Istria wrote: > [...] > Then seeing such negative comments towards them, which are more about > opinion than technical facts, seems really not encouraging to contribute > more to Maven. [...] It's the 2nd time in a short time-frame I find your comments

Re: Why doesn’t jdk.internal.loader.Loader implement AutoCloseable?

2019-06-07 Thread Christian Stein
On Sun, May 26, 2019 at 10:31 AM Alan Bateman wrote: > That said, it might be time to change the Windows sharing mode that > JarFile/ZipFile uses to open JAR files. I'll create an issue for that. > > -Alan > Is this the related issue? https://bugs.openjdk.java.net/browse/JDK-8224794

Re: Nashorn on the module-path

2019-05-27 Thread Christian Stein
2019 at 10:35 AM Alan Bateman wrote: > On 16/05/2019 15:02, Christian Stein wrote: > > : > > It didn't emit any new line. Is there another debug switch I can enable? > > Have you brought this up on nashorn-dev as this might require digging into > the dynalink linker and how method handles are used. > > -Alan >

Re: Nashorn on the module-path

2019-05-27 Thread Christian Stein
On Mon, May 27, 2019 at 11:37 AM Sundararajan Athijegannathan < sundararajan.athijegannat...@oracle.com> wrote: > How can this be reproduced at out end? I compiled a small example project at [1] that describes and demonstrates the issue. Please view the README.md file for details. You may

Re: Nashorn on the module-path

2019-05-27 Thread Christian Stein
nk it’s possible to reduce the problem further, ideally to a > plain java class? > > > Hannes > > > > Am 27.05.2019 um 11:40 schrieb Christian Stein : > > > > On Mon, May 27, 2019 at 11:37 AM Sundararajan Athijegannathan < > > sundararajan.athijegannat.

Re: Nashorn on the module-path

2019-05-27 Thread Christian Stein
On Mon, May 27, 2019 at 11:37 AM Sundararajan Athijegannathan < sundararajan.athijegannat...@oracle.com> wrote: > How can this be reproduced at out end? I compiled a small example project at [1] that describes and demonstrates the issue. Please view the README.md file for details. You may

Re: Nashorn on the module-path

2019-05-26 Thread Christian Stein
2019 at 10:35 AM Alan Bateman wrote: > On 16/05/2019 15:02, Christian Stein wrote: > > : > > It didn't emit any new line. Is there another debug switch I can enable? > > Have you brought this up on nashorn-dev as this might require digging into > the dynalink linker and how method handles are used. > > -Alan >

Re: Why doesn’t jdk.internal.loader.Loader implement AutoCloseable?

2019-05-26 Thread Christian Stein
On Sun, May 26, 2019 at 10:31 AM Alan Bateman wrote: > On 26/05/2019 06:45, Christian Stein wrote: > > Hi, > > > > following the documentation of ModulLayer [1] to create a > > temporary layer for testing, results in a FileSystemException > > when trying to

Why doesn’t jdk.internal.loader.Loader implement AutoCloseable?

2019-05-25 Thread Christian Stein
Hi, following the documentation of ModulLayer [1] to create a temporary layer for testing, results in a FileSystemException when trying to delete the modular jar file after tests are finished. On Windows, at least. Find more details and a minimal working example here: [2] An implementation of a

[jira] [Commented] (SUREFIRE-1546) JUnit 5 runner does not honor JUnit 5 display names

2019-05-23 Thread Christian Stein (JIRA)
[ https://issues.apache.org/jira/browse/SUREFIRE-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16847017#comment-16847017 ] Christian Stein commented on SUREFIRE-1546: --- Great seeing this feature being implemented

Re: Nashorn on the module-path

2019-05-16 Thread Christian Stein
On Thu, May 16, 2019 at 3:23 PM Alan Bateman wrote: > Can you run with -Dsun.reflect.debugModuleAccessChecks and see if > anything is printed? This can be useful to locate exception swallowing. > Given that Nashorn is using method handles it might not help but would > be useful to try. > It

[jira] [Commented] (SUREFIRE-1544) Surefire doesn't pick up tests from junit5

2019-04-17 Thread Christian Stein (JIRA)
[ https://issues.apache.org/jira/browse/SUREFIRE-1544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16819877#comment-16819877 ] Christian Stein commented on SUREFIRE-1544: --- {quote}The user's failure could be caused

[jira] [Commented] (SUREFIRE-1643) JUnit 5 in parallel execution mode confuses Surefire reports

2019-04-17 Thread Christian Stein (JIRA)
[ https://issues.apache.org/jira/browse/SUREFIRE-1643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16819870#comment-16819870 ] Christian Stein commented on SUREFIRE-1643: --- According to  [https://github.com/jazhou/junit5

Define a standard for test reports

2019-04-13 Thread Christian Stein
Hi Maven devs, especially Maven Surefire people, you're both invited and very welcome to participate in defining "a standard for test reports" at [1]. TLDR: The goal here is to have a common format which testing frameworks and build tools can understand, so that, for example, JUnit (producer)

Re: RFR: JDK-8220702: compiling in the context of an automatic module disallows --add-modules ALL-MODULE-PATH

2019-04-11 Thread Christian Stein
On Thu, Apr 11, 2019 at 8:30 PM Alex Buckley wrote: > [...] In advance > of that, can you share some detailed invocations of javac using > --patch-module in single-module and multi-module mode? > I'm not sure if this helps in any regards -- here [1] is a draft PR that adds explicit module

Re: Surefire maintenance release

2019-04-11 Thread Christian Stein
On Thu, Apr 11, 2019 at 8:09 AM Enrico Olivelli wrote: > This is the final branch from which I will cut the release. > https://github.com/apache/maven-surefire/tree/release/2.22.2 > > Re-launched Jenkins to check for the last time: > >

Re: Surefire maintenance release

2019-03-27 Thread Christian Stein
On Wed, Mar 27, 2019 at 6:14 PM Enrico Olivelli wrote: > Il mer 27 mar 2019, 18:10 Tibor Digana ha > scritto: > > > Enrico, what i maintenance release for you, 2.22.2-M1? > > > > 2.22.2 without suffix > > This.

[jira] [Updated] (SUREFIRE-1651) JUnit5 Vintage + Maven-Failsafe + Category = ???

2019-03-22 Thread Christian Stein (JIRA)
[ https://issues.apache.org/jira/browse/SUREFIRE-1651?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christian Stein updated SUREFIRE-1651: -- Summary: JUnit5 Vintage + Maven-Failsafe + Category = ??? (was: JUnit5 Vinatage

[jira] [Commented] (SUREFIRE-1651) JUnit5 Vinatage + Maven-Failsafe + Category = ???

2019-03-22 Thread Christian Stein (JIRA)
[ https://issues.apache.org/jira/browse/SUREFIRE-1651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16798877#comment-16798877 ] Christian Stein commented on SUREFIRE-1651: --- [~tibor17], doesn't Failsafe "in

Re: Surefire maintenance release

2019-03-21 Thread Christian Stein
Hi Stéphane, due to JavaLand and other "business stuff", I'll plan to review your branch early next week. >From a first glimps, it looks good to me. Cheers, Christian On Wed, Mar 20, 2019 at 9:26 AM Enrico Olivelli wrote: > +1 > > Il mar 19 mar 2019, 22:29 Olivier Lamy ha scritto: > > >

[jira] [Commented] (SUREFIRE-1643) JUnit 5 in parallel execution mode confuses Surefire reports

2019-03-01 Thread Christian Stein (JIRA)
[ https://issues.apache.org/jira/browse/SUREFIRE-1643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16782290#comment-16782290 ] Christian Stein commented on SUREFIRE-1643: --- Using `junit-platform-maven-plugin` shows

[jira] [Created] (SUREFIRE-1643) JUnit 5 in parallel execution mode confused Surefire reports

2019-03-01 Thread Christian Stein (JIRA)
Christian Stein created SUREFIRE-1643: - Summary: JUnit 5 in parallel execution mode confused Surefire reports Key: SUREFIRE-1643 URL: https://issues.apache.org/jira/browse/SUREFIRE-1643 Project

[jira] [Updated] (SUREFIRE-1643) JUnit 5 in parallel execution mode confuses Surefire reports

2019-03-01 Thread Christian Stein (JIRA)
[ https://issues.apache.org/jira/browse/SUREFIRE-1643?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christian Stein updated SUREFIRE-1643: -- Summary: JUnit 5 in parallel execution mode confuses Surefire reports (was: JUnit

Re: Surefire maintenance release

2019-02-28 Thread Christian Stein
Hi all, here are my 0.02 € on the two issues/PRs that went into Surefire 3.x already. *SUREFIRE-1546 "JUnit 5 display names"* Both, supporting "@DisplayName" and therefore also backporting https://issues.apache.org/jira/browse/SUREFIRE-1546 to the 2.x branch makes almost *no* sense to me.

[jira] [Comment Edited] (SUREFIRE-1546) JUnit 5 runner does not honor JUnit 5 display names

2019-02-28 Thread Christian Stein (JIRA)
[ https://issues.apache.org/jira/browse/SUREFIRE-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16780665#comment-16780665 ] Christian Stein edited comment on SUREFIRE-1546 at 2/28/19 3:56 PM

[jira] [Commented] (SUREFIRE-1546) JUnit 5 runner does not honor JUnit 5 display names

2019-02-28 Thread Christian Stein (JIRA)
[ https://issues.apache.org/jira/browse/SUREFIRE-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16780665#comment-16780665 ] Christian Stein commented on SUREFIRE-1546: --- > Is there a plan of where to put fold

[jira] [Comment Edited] (SUREFIRE-1546) JUnit 5 runner does not honor JUnit 5 display names

2019-02-28 Thread Christian Stein (JIRA)
[ https://issues.apache.org/jira/browse/SUREFIRE-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16780665#comment-16780665 ] Christian Stein edited comment on SUREFIRE-1546 at 2/28/19 3:54 PM

[jira] [Resolved] (MJLINK-29) Upgrade maven-compiler-plugin to version 3.8.0 in IT's

2019-02-20 Thread Christian Stein (JIRA)
[ https://issues.apache.org/jira/browse/MJLINK-29?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christian Stein resolved MJLINK-29. --- Resolution: Done Merged https://github.com/apache/maven-jlink-plugin/pull/5 > Upgrade ma

[jira] [Closed] (MJLINK-29) Upgrade maven-compiler-plugin to version 3.8.0 in IT's

2019-02-20 Thread Christian Stein (JIRA)
[ https://issues.apache.org/jira/browse/MJLINK-29?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christian Stein closed MJLINK-29. - > Upgrade maven-compiler-plugin to version 3.8.0 in I

[jira] [Created] (SUREFIRE-1633) [JUnit5 follow-up #1343] JUnit Jupiter @Nested tests do not run when selecting enclosing class with Surefire

2019-02-01 Thread Christian Stein (JIRA)
Christian Stein created SUREFIRE-1633: - Summary: [JUnit5 follow-up #1343] JUnit Jupiter @Nested tests do not run when selecting enclosing class with Surefire Key: SUREFIRE-1633 URL: https://issues.apache.org

[jira] [Commented] (SUREFIRE-1546) JUnit 5 runner does not honor JUnit 5 display names

2019-02-01 Thread Christian Stein (JIRA)
[ https://issues.apache.org/jira/browse/SUREFIRE-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16758474#comment-16758474 ] Christian Stein commented on SUREFIRE-1546: --- Having a config parameter that allows display

[jira] [Comment Edited] (SUREFIRE-1546) JUnit 5 runner does not honor JUnit 5 display names

2019-02-01 Thread Christian Stein (JIRA)
[ https://issues.apache.org/jira/browse/SUREFIRE-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16758474#comment-16758474 ] Christian Stein edited comment on SUREFIRE-1546 at 2/1/19 4:30 PM

[jira] [Commented] (SUREFIRE-1546) JUnit 5 runner does not honor JUnit 5 display names

2019-02-01 Thread Christian Stein (JIRA)
[ https://issues.apache.org/jira/browse/SUREFIRE-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16758470#comment-16758470 ] Christian Stein commented on SUREFIRE-1546: --- Display names are not intended and are not even

Re: [VOTE] Release Apache Maven Surefire Plugin version 3.0.0-M3

2018-12-20 Thread Christian Stein
+1 Cheers, Christian Simple project using Surefire 3.0.0-M3: https://github.com/junit-team/junit5-samples/commit/a8660d636058a52fc68f7a9d6a5a11b42ee44303 Result: https://travis-ci.org/junit-team/junit5-samples/jobs/470432909 On Thu, Dec 20, 2018 at 10:48 AM Tibor Digana wrote: > Hi, > > We

Re: GitHub "merge button" is active ?

2018-12-19 Thread Christian Stein
I do use the button now and then. I'd vote to install https://github.com/apps/wip which disables the button on GitHub ... "allow authors of pull requests to set status to pending while still working on it." Cheers, Christian On Wed, Dec 19, 2018 at 3:57 PM Enrico Olivelli wrote: > Hi, > I see

Re: New committer: Enrico Olivelli

2018-12-14 Thread Christian Stein
Hi Enrico!

[jira] [Commented] (SUREFIRE-1614) JUnit Runner that writes to System.out corrupts Surefire's STDOUT when using JUnit's Vintage Engine

2018-12-12 Thread Christian Stein (JIRA)
[ https://issues.apache.org/jira/browse/SUREFIRE-1614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16719502#comment-16719502 ] Christian Stein commented on SUREFIRE-1614: --- Potential fix at PR https://github.com/apache

[jira] [Assigned] (SUREFIRE-1614) JUnit Runner that writes to System.out corrupts Surefire's STDOUT when using JUnit's Vintage Engine

2018-12-12 Thread Christian Stein (JIRA)
[ https://issues.apache.org/jira/browse/SUREFIRE-1614?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christian Stein reassigned SUREFIRE-1614: - Assignee: Christian Stein > JUnit Runner that writes to System.out corru

[jira] [Commented] (SUREFIRE-1614) JUnit Runner that writes to System.out corrupts Surefire's STDOUT when using JUnit's Vintage Engine

2018-12-12 Thread Christian Stein (JIRA)
[ https://issues.apache.org/jira/browse/SUREFIRE-1614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16719344#comment-16719344 ] Christian Stein commented on SUREFIRE-1614: --- Thanks for raising the issue, [~awilkinson

Re: [VOTE] Release Apache Maven Surefire Plugin version 3.0.0-M2

2018-12-08 Thread Christian Stein
+1 Cheers, Christian

[jira] [Commented] (SUREFIRE-1585) Align JUnit Platform version at runtime

2018-12-03 Thread Christian Stein (JIRA)
[ https://issues.apache.org/jira/browse/SUREFIRE-1585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16707150#comment-16707150 ] Christian Stein commented on SUREFIRE-1585: --- Reduced the scope of this issue to *aligning

[jira] [Updated] (SUREFIRE-1585) Align JUnit Platform version at runtime

2018-12-03 Thread Christian Stein (JIRA)
[ https://issues.apache.org/jira/browse/SUREFIRE-1585?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christian Stein updated SUREFIRE-1585: -- Description: The internal *JUnitPlatformProviderInfo* should use the JUnit Platform

[jira] [Updated] (SUREFIRE-1585) Align JUnit Platform version at runtime

2018-12-03 Thread Christian Stein (JIRA)
[ https://issues.apache.org/jira/browse/SUREFIRE-1585?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christian Stein updated SUREFIRE-1585: -- Summary: Align JUnit Platform version at runtime (was: Auto-resolve "mi

<    1   2   3   4   5   6   >