On Sep 6, 2013, at 11:11 PM, Charles Oliver Nutter head...@headius.com wrote:
I can reproduce this by running a fairly normalish command in JRuby:
(Java::JavaLang::InternalError)
guard=Lambda(a0:L,a1:L,a2:L,a3:L,a4:L)={
On Sep 4, 2013, at 1:35 PM, Dmitry Samersoff dmitry.samers...@oracle.com
wrote:
Please, review the changes.
http://cr.openjdk.java.net/~dsamersoff/JDK-8015848/webrev.01/
With this change you can dump the boot class path classes again?
-- Chris
-Dmitry
--
Dmitry Samersoff
Oracle
On Aug 30, 2013, at 6:36 AM, Lois Foltan lois.fol...@oracle.com wrote:
On 8/29/2013 10:18 PM, David Holmes wrote:
On 29/08/2013 10:01 PM, Lois Foltan wrote:
On 8/29/2013 7:16 AM, David Holmes wrote:
Hi Lois,
Is this still needed:
142 PCH_FLAG/unsafe.o = $(PCH_FLAG/NO_PCH)
On Aug 27, 2013, at 9:18 AM, Lois Foltan lois.fol...@oracle.com wrote:
Please review the following fix:
open webrev at http://cr.openjdk.java.net/~hseigel/bug_jdk8022407/
Bug:
bug link at https://bugs.openjdk.java.net/browse/JDK-8022407
Summary of fix:
The JDK 8 build on MacOS,
On Jul 30, 2013, at 4:11 PM, Nick Williams
nicholas+open...@nicholaswilliams.net wrote:
Quick question for those of you that know anything about @CallerSensitive...
After looking at the code and experimenting some, I've discovered that
getCallerClass() doesn't actually keep going until it
On Aug 12, 2013, at 8:43 PM, Yumin Qi yumin...@oracle.com wrote:
Coleen,
Chris Thalinger already answered some of your concerns. For jar file which
dumped in this change, compiler replay has added functions to SA to dump out
replay jars against core file. Since customer is the one
-Original Message-
From: hotspot-runtime-dev-boun...@openjdk.java.net
[mailto:hotspot-runtime-dev-boun...@openjdk.java.net] On Behalf Of Christian
Thalinger
Sent: Monday, August 12, 2013 9:12 PM
To: Coleen Phillimore
Cc: serviceability-dev@openjdk.java.net serviceability-dev
the adlc tool
which is used early in the hotspot build.
Full webrev (OpenJDK):
http://cr.openjdk.java.net/~tbell/8019470/webrev.01/
Thanks in advance - we would like to get these changes checked in this week.
Tim
David
-
Tim
On 07/24/13 02:59 PM, Christian Thalinger
On Jul 25, 2013, at 5:14 PM, serguei.spit...@oracle.com wrote:
Please, review the fix for:
bug: http://bugs.sun.com/view_bug.do?bug_id=7187554
jbs: https://jbs.oracle.com/bugs/browse/JDK-7187554
Open webrev:
Approved for jdk7u40-dev. -- Chris
On Jul 25, 2013, at 12:13 PM, Jeff Dinkins jeff.dink...@oracle.com wrote:
Note: this is not a backport of the JDK8 Third Party README, so there's no
link to a JDK8 changeset included.
BugID: 8014850
Synopsis: 7u40 THIRDPARTY License Readme Update
On Jul 24, 2013, at 5:15 AM, Tim Bell tim.b...@oracle.com wrote:
On 07/24/13 04:43 AM, David Holmes wrote:
Hi Tim,
On 24/07/2013 8:15 AM, Tim Bell wrote:
Hello everyone-
This is a small set of changes to switch from gcc to clang when building
So we already added support for clang as
Approved for jdk7u40-dev.
-- Chris
On Jul 24, 2013, at 12:52 PM, Petr Pchelko petr.pche...@oracle.com wrote:
Hello
This is a request for phase 2 approval to push the fix for 8020371 into the
jdk7u40 repository.
7u40-critical-request justification: this is a regression in 7u40 which
I hope all the quirks have been resolved. Approved for jdk7u40-dev.
-- Chris
On Jul 24, 2013, at 4:19 PM, Michael Fang michael.f...@oracle.com wrote:
Hello,
This is a request for phase 2 approval to push the fix for 8020319 into
jdk7u40 repository.
Bug:
On Jul 19, 2013, at 2:26 PM, Dalibor Topic dalibor.to...@oracle.com wrote:
I'm delegating the maintainer authority for jdk7u to Christian Thalinger.
Christian will be helping Sean and myself with jdk7u maintainer duties.
Welcome, Christian!
Thanks! -- Chris
I'd also like to take
On Jul 11, 2013, at 12:35 AM, Cédric Champeau cedric.champ...@gmail.com wrote:
Le 11/07/2013 06:09, Charles Oliver Nutter a écrit :
Maybe a solution could be an annotation to mark calls to not
appear in any stacktrace?
Personally, I'd love to see *any* way to teach JVM about
On Jul 11, 2013, at 10:30 AM, Christian Thalinger
christian.thalin...@oracle.com wrote:
On Jul 11, 2013, at 12:35 AM, Cédric Champeau cedric.champ...@gmail.com
wrote:
Le 11/07/2013 06:09, Charles Oliver Nutter a écrit :
Maybe a solution could be an annotation to mark calls
Changeset: bd6949f9dbb2
Author:twisti
Date: 2013-07-03 11:35 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/bd6949f9dbb2
8019184: MethodHandles.catchException() fails when methods have 8 args + varargs
Reviewed-by: jrose
!
Changeset: bd6949f9dbb2
Author:twisti
Date: 2013-07-03 11:35 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/bd6949f9dbb2
8019184: MethodHandles.catchException() fails when methods have 8 args + varargs
Reviewed-by: jrose
!
Changeset: bd6949f9dbb2
Author:twisti
Date: 2013-07-03 11:35 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/bd6949f9dbb2
8019184: MethodHandles.catchException() fails when methods have 8 args + varargs
Reviewed-by: jrose
!
Couldn't find any obvious problems. Looks good.
-- Chris
On Jul 2, 2013, at 6:26 PM, John Rose john.r.r...@oracle.com wrote:
Thanks for the helpful review, Vladimir.
I have incorporated all your comments and updated the webrev here:
http://cr.openjdk.java.net/~jrose/8008688/webrev.05
Looks good. -- Chris
On Jun 19, 2013, at 8:31 AM, Mandy Chung mandy.ch...@oracle.com wrote:
Thanks. I have revised the exception message and the test:
http://cr.openjdk.java.net/~mchung/jdk7u/8014925/webrev.01/
Mandy
On 6/19/2013 4:36 AM, Alan Bateman wrote:
On 19/06/2013 06:58,
Changeset: 2b63fda275a3
Author:twisti
Date: 2013-06-17 16:24 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2b63fda275a3
7177472: JSR292: MethodType interning penalizes scalability
Reviewed-by: twisti
Contributed-by: Aleksey Shipilev aleksey.shipi...@oracle.com
!
Changeset: 2b63fda275a3
Author:twisti
Date: 2013-06-17 16:24 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2b63fda275a3
7177472: JSR292: MethodType interning penalizes scalability
Reviewed-by: twisti
Contributed-by: Aleksey Shipilev aleksey.shipi...@oracle.com
!
Changeset: 2b63fda275a3
Author:twisti
Date: 2013-06-17 16:24 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2b63fda275a3
7177472: JSR292: MethodType interning penalizes scalability
Reviewed-by: twisti
Contributed-by: Aleksey Shipilev aleksey.shipi...@oracle.com
!
On Jun 11, 2013, at 7:16 PM, Christian Thalinger
christian.thalin...@oracle.com wrote:
On Jun 11, 2013, at 2:21 PM, Aleksey Shipilev aleksey.shipi...@oracle.com
wrote:
On 06/11/2013 10:24 PM, Christian Thalinger wrote:
On Jun 11, 2013, at 9:08 AM, Aleksey Shipilev aleksey.shipi
On Jun 13, 2013, at 12:09 PM, Aleksey Shipilev aleksey.shipi...@oracle.com
wrote:
On 06/13/2013 09:51 PM, Christian Thalinger wrote:
While preparing the push I noticed the new code gives a warning:
src/share/classes/java/lang/invoke/MethodType.java:1106: warning:
[unchecked] unchecked
On Jun 11, 2013, at 1:47 AM, Aleksey Shipilev aleksey.shipi...@oracle.com
wrote:
On 06/11/2013 02:52 AM, Christian Thalinger wrote:
This looks good to me.
Thanks for the review!
Could you run RegExp with Nashorn again with and without your changes?
Being single-threaded
On Jun 11, 2013, at 9:03 AM, Aleksey Shipilev aleksey.shipi...@oracle.com
wrote:
On 06/11/2013 07:43 PM, Christian Thalinger wrote:
Thanks for this but I was thinking running it with -Xprof to see
whether some of the table methods show up on the profile.
I put little trust into this kind
On Jun 11, 2013, at 2:21 PM, Aleksey Shipilev aleksey.shipi...@oracle.com
wrote:
On 06/11/2013 10:24 PM, Christian Thalinger wrote:
On Jun 11, 2013, at 9:08 AM, Aleksey Shipilev aleksey.shipi...@oracle.com
wrote:
On 06/11/2013 08:06 PM, Christian Thalinger wrote:
Anyway, let's push
Looks good. -- Chris
On May 30, 2013, at 11:19 PM, serguei.spit...@oracle.com wrote:
Please, review the fix for:
bug: https://jbs.oracle.com/bugs/browse/JDK-8014052
jbs: https://jbs.oracle.com/bugs/browse/JDK-8014052
Open webrev:
Looks good. -- Chris
On May 29, 2013, at 9:08 PM, serguei.spit...@oracle.com wrote:
Please, review the fix and unit test for:
bug: http://bugs.sun.com/view_bug.do?bug_id=8015436
jbs: https://jbs.oracle.com/bugs/browse/JDK-8015436
Open webrev:
Looks good. -- Chris
On May 23, 2013, at 4:19 PM, serguei.spit...@oracle.com wrote:
Please, review the fix for:
bug: http://bugs.sun.com/view_bug.do?bug_id=8014288
jbs: https://jbs.oracle.com/bugs/browse/JDK-8014288
Open webrev:
Vote: yes
On May 20, 2013, at 4:41 PM, Mike Duigou mike.dui...@oracle.com wrote:
I hereby nominate Brian Goetz to jdk8 project Reviewer.
Brian is the Java Language Architect at Oracle and has been leading the
Lambda language and library efforts (JSR-335). Much of this work was recently
Looks good. Nit: why is there an empty line?
+jlong fmt8;
+
+jlong fmt32;
-- Chris
On May 15, 2013, at 1:21 PM, Morris Meyer morris.me...@oracle.com wrote:
Folks,
Could I get a review for these two small changes in src/solaris/native. This
is to fix the nightly CTW testing
On May 10, 2013, at 1:37 AM, Jochen Theodorou blackd...@gmx.org wrote:
Am 10.05.2013 02:40, schrieb Christian Thalinger:
[...]
That's because your method handle is not constant and so the compiler cannot
inline the call.
And you tell me that in the first case the call was inlined
On May 9, 2013, at 2:26 AM, Jochen Theodorou blackd...@gmx.org wrote:
Am 08.05.2013 23:12, schrieb John Rose:
On May 8, 2013, at 5:33 AM, Jochen Theodorou blackd...@gmx.org wrote:
Am 07.05.2013 19:31, schrieb Christian Thalinger:
[...]
Do you have any numbers?The problem is that if the MH
On May 7, 2013, at 8:04 AM, Jochen Theodorou blackd...@gmx.org wrote:
Hi,
I am currently investigating here some performance issues and I may have
found a culprint here - invokeExact. My case is one where method caching
fails and I will have to do an invokeExact from Java - meaning
to run inside gdb
case $1 in
-gdb)
@@ -95,16 +96,14 @@
-- Chris
Thanks,
Vladimir
On 5/6/13 9:35 AM, Christian Thalinger wrote:
Last warning! If nobody speaks up today I'm going to push this later:
http://cr.openjdk.java.net/~twisti/8008772/
-- Chris
On May 2, 2013, at 5:28
heap to make Valgrind run faster, use
-Xmx for larger heap
Thanks
Vladimir
On 5/6/13 10:20 AM, Christian Thalinger wrote:
On May 6, 2013, at 9:50 AM, Vladimir Kozlov vladimir.koz...@oracle.com
wrote:
Did you use 'hg rename' to move hotspot.script? We need to preserve history.
hg
/webrev/vs.patch also
This looks good. Christian Thalinger will be happy :)
Indeed :-) Thanks Nils and Christian for making that work!
-- Chris
Thanks,
Vladimir
Thanks,
Christian
-Original Message-
From: hotspot-dev-boun...@openjdk.java.net
[mailto:hotspot-dev-boun
and sets JDK to JDK_IMPORT_PATH if ALT_JAVA_HOME is not set:
http://cr.openjdk.java.net/~twisti/8008772/
Next question: is anyone using env.{sh,csh}? Since we removed test_gamma
these files are unused and we could stop generating them.
-- Chris
On May 2, 2013, at 3:50 PM, Christian Thalinger
On May 2, 2013, at 5:25 PM, John Rose john.r.r...@oracle.com wrote:
On May 2, 2013, at 4:44 PM, Christian Thalinger
christian.thalin...@oracle.com wrote:
is anyone using env.{sh,csh}?
I'll suggest that the answer is going to be no. I think very few people
have ever used them. — John
On Apr 25, 2013, at 8:58 AM, MacGregor, Duncan (GE Energy Management)
duncan.macgre...@ge.com wrote:
I would have thought one of the most common uses of breaking down a method
handle like this would be to immediately turn it into a java.lang.reflect
object and maybe examine annotations or
On Apr 25, 2013, at 6:45 AM, Volker Simonis volker.simo...@gmail.com wrote:
Hi Jiangli,
that's really sad!
First because it is not the way it is supposed to work and second
because we detected and fixed this same problem a few days ago as
well..
I don't understand what's the problem
a lot of thing excruciatingly slow.
//Nils
On 2013-04-22 22:55, Christian Thalinger wrote:
On Apr 22, 2013, at 1:36 PM, Daniel D. Daugherty
daniel.daughe...@oracle.com wrote:
Chris,
Just an observation and not a review.
Looks like you're removing launcher support on Windows
http://cr.openjdk.java.net/~twisti/8008772/
8008772: remove gamma launcher
Reviewed-by:
Remove linking the gamma launcher and it's associated source files.
make/Makefile
make/bsd/makefiles/launcher.make
make/bsd/makefiles/vm.make
make/hotspot.script
make/linux/makefiles/launcher.make
Dan
On 4/22/13 1:47 PM, Christian Thalinger wrote:
http://cr.openjdk.java.net/~twisti/8008772/
8008772: remove gamma launcher
Reviewed-by:
Remove linking the gamma launcher and it's associated source files.
make/Makefile
make/bsd/makefiles/launcher.make
make/bsd/makefiles/vm.make
On Apr 11, 2013, at 4:08 PM, serguei.spit...@oracle.com wrote:
Please, review the hs25 fix (round 2) below.
Open webrev:
http://cr.openjdk.java.net/~sspitsyn/webrevs/2013/hotspot/8007037-JVMTI-JSR292.2/
One thing that makes it hard to follow what going on are the variable names,
e.g.:
On Dec 4, 2012, at 12:54 AM, George Marrows george.marr...@googlemail.com
wrote:
[resend after getting stuck in moderation first time]
I was just checking out update 12 b3 with our Magik implementation on 64 bit
Windows.
Does b3 contain the backport of the Java 8 invokedynamic impl
/test/makefile
for when it is invoked directly.
There is also an outstanding issue to add a --with-jtreg option to the
configure script:
JDK-8007129 build-infra Add configure --with-jtreg option for location of
JTREG home directory.
Mike
On Apr 6 2013, at 21:39 , Christian Thalinger
On Mar 30, 2013, at 1:56 AM, Charles Oliver Nutter head...@headius.com wrote:
I've been fiddling about with performance a bit again recently, and have
noticed a perf degradation since b72. I mentioned this to the Nashorn guys
and Marcus discovered that InlineSmallCode=2000 helped them get
On Mar 27, 2013, at 8:01 PM, Mandy Chung mandy.ch...@oracle.com wrote:
Thanks for the review. I forgot to mention that Chris contributed the
initial patch (thanks).
On 3/27/2013 1:13 PM, Christian Thalinger wrote:
On Mar 27, 2013, at 10:35 AM, Mandy Chung mandy.ch...@oracle.com wrote
On Mar 27, 2013, at 10:35 AM, Mandy Chung mandy.ch...@oracle.com wrote:
This is the JDK change for JEP 176: JEP 176: Mechanical Checking of
Caller-Sensitive Methods [1]. Christian has posted the webrev for the
hotspot VM change a couple weeks ago [2].
Webrev at:
On Mar 19, 2013, at 6:02 PM, Christian Thalinger
christian.thalin...@oracle.com wrote:
On Mar 19, 2013, at 5:21 PM, John Rose john.r.r...@oracle.com wrote:
On Mar 14, 2013, at 8:31 PM, Christian Thalinger
christian.thalin...@oracle.com wrote:
[This is the HotSpot part of JEP 176
of adds a new
method to the official VM interface. Other VM implementors would have to
implement that one as well because the JDK then links to this new method.
Thanks for the review!
-- Chris
Mandy
On 3/14/13 8:31 PM, Christian Thalinger wrote:
[This is the HotSpot part of JEP 176
On Mar 19, 2013, at 5:21 PM, John Rose john.r.r...@oracle.com wrote:
On Mar 14, 2013, at 8:31 PM, Christian Thalinger
christian.thalin...@oracle.com wrote:
[This is the HotSpot part of JEP 176]
http://cr.openjdk.java.net/~twisti/7198429
7198429: need checked categorization of caller
[This is the HotSpot part of JEP 176]
http://cr.openjdk.java.net/~twisti/7198429
7198429: need checked categorization of caller-sensitive methods in the JDK
Reviewed-by:
More information in JEP 176:
http://openjdk.java.net/jeps/176
src/share/vm/ci/ciMethod.cpp
src/share/vm/ci/ciMethod.hpp
On Feb 26, 2013, at 6:09 PM, Christian Thalinger
christian.thalin...@oracle.com wrote:
On Feb 25, 2013, at 11:24 PM, David Holmes david.hol...@oracle.com wrote:
On 26/02/2013 4:42 AM, Christian Thalinger wrote:
On Feb 24, 2013, at 2:54 PM, David Holmes david.hol...@oracle.com wrote
On Feb 26, 2013, at 6:09 PM, Christian Thalinger
christian.thalin...@oracle.com wrote:
On Feb 25, 2013, at 11:24 PM, David Holmes david.hol...@oracle.com wrote:
On 26/02/2013 4:42 AM, Christian Thalinger wrote:
On Feb 24, 2013, at 2:54 PM, David Holmes david.hol...@oracle.com wrote
On Feb 25, 2013, at 11:24 PM, David Holmes david.hol...@oracle.com wrote:
On 26/02/2013 4:42 AM, Christian Thalinger wrote:
On Feb 24, 2013, at 2:54 PM, David Holmes david.hol...@oracle.com wrote:
On 23/02/2013 1:55 PM, Christian Thalinger wrote:
I talked to a lot of people about this today
On Feb 24, 2013, at 2:54 PM, David Holmes david.hol...@oracle.com wrote:
On 23/02/2013 1:55 PM, Christian Thalinger wrote:
I talked to a lot of people about this today. What we really want is to not
run tests when we build. Mikael and I were looking into how we could do
that without
script work like
the test targets in Fix 1
Fix 3) Remove the -Dsun.java.launcher=gamma and possibly replace the existing
-Dsun.boot.library.path weirdness by explicit command line options like
-Xbootlibrarypath:{/p,/a}
-- Chris
On Feb 22, 2013, at 3:21 PM, Christian Thalinger
On Feb 14, 2013, at 7:53 AM, Andrew Hughes gnu.and...@redhat.com wrote:
- Original Message -
On 2/11/13 8:29 PM, Andrew Hughes wrote:
The file:
http://hg.openjdk.java.net/jdk8/jdk8/hotspot/file/fe4a4ea5bed9/test/runtime/7158804/Test7158804.sh
has a bad copyright header with
On Feb 8, 2013, at 10:38 AM, Krystal Mo krystal...@oracle.com wrote:
Hi all,
Could I have a couple of review for this change:
7087570: java.lang.invoke.MemberName information wrong for method handles
created with findConstructor
Summary: REF_invokeSpecial DMHs (which are unusual) get
great! I should have gone this year then :-)
-- Chris
We are still in the process of securing finding for some hosting etc but will
get started shorty after.
Cheers,
Martijn
On Tuesday, 5 February 2013, Christian Thalinger wrote:
On Feb 4, 2013, at 12:42 AM, David Holmes david.hol
On Jan 22, 2013, at 4:07 PM, serguei.spit...@oracle.com wrote:
Please, review the fix for:
https://jbs.oracle.com/bugs/browse/JDK-8006542
Open webrev:
http://cr.openjdk.java.net/~sspitsyn/webrevs/2013/hotspot/8006542-JVMTI-JSR292.1/
src/share/vm/prims/jvmtiRedefineClasses.hpp:
+
checked this and the patch I reviewed was for 7u.
-- Chris
Vladimir
On 1/12/13 4:53 AM, Alejandro E Murillo wrote:
On 1/11/2013 4:17 PM, Christian Thalinger wrote:
On Jan 11, 2013, at 11:08 AM, Chris Phillips @ T O
chris...@lgonqn.org wrote:
Hi
On 11/01/13 12:29 PM, Andrew Hughes wrote
On Jan 11, 2013, at 11:08 AM, Chris Phillips @ T O chris...@lgonqn.org wrote:
Hi
On 11/01/13 12:29 PM, Andrew Hughes wrote:
- Original Message -
On 21/12/2012 9:51 AM, Coleen Phillimore wrote:
I am checking these changes into hsx24 now.
Thanks Coleen.
Yes, thanks Coleen for
On Jan 11, 2013, at 10:19 AM, Ulf Zibis ulf.zi...@cosoco.de wrote:
Hi Sherman,
Am 11.01.2013 06:47, schrieb Xueming Shen:
(1) sp++ at Ln#159 probably can be moved into ln#155? the local sp here
should
not change the real sp after break+return.
(2) maybe the overflowflag can just be
19:27, Christian Thalinger
christian.thalin...@oracle.com wrote:
On Dec 13, 2012, at 7:55 AM, MacGregor, Duncan (GE Energy Management)
duncan.macgre...@ge.com wrote:
Thanks. Meanwhile I've patched the two offending parts of the database
library to work round the problem. Although our
[Back from vacation; catching up with emails.]
On Dec 23, 2012, at 9:56 PM, Charles Oliver Nutter head...@headius.com wrote:
Ok, things are definitely looking up with Roland's and Christian's patches!
Good! :-)
Numbers for red/black get as low as 0.74s with the new logic instead
of the
On Dec 23, 2012, at 10:11 PM, Charles Oliver Nutter head...@headius.com wrote:
Oh, there's also this peculiar effect...shouldn't -TieredCompilation
just give me C2 alone?
Yes, it should.
system ~/projects/jruby $ jruby -v -J-XX:-TieredCompilation
@openjdk.java.netmailto:mlvm-dev@openjdk.java.net
Subject: Re: Java 7 update 12 issue with MethodHandles.catchException.
On Dec 12, 2012, at 11:33 AM, Christian Thalinger wrote:
That helps. I can't recall code that has a 8 argument limitation and does
something else with 9+. Maybe John has
Do you see the same failure with 8 (to rule out differences between 7u12 and 8)?
-- Chris
On Dec 12, 2012, at 7:12 AM, MacGregor, Duncan (GE Energy Management)
duncan.macgre...@ge.com wrote:
Finally got time to try running our full application under 7u12 and I've hit
a problem with our
On Nov 30, 2012, at 10:48 AM, Krystal Mo krystal...@oracle.com wrote:
Hi all,
Could I get a couple of review for this small change, please?
And could someone from the JDK side sponsor this change?
Bug: https://jbs.oracle.com/bugs/browse/JDK-8004066
Webrev:
To: Christian Thalinger christian.thalin...@oracle.com
Cc: hotspot-...@openjdk.java.net
Am Mittwoch, den 17.10.2012, 15:34 -0700 schrieb Christian Thalinger:
On Oct 17, 2012, at 3:05 PM, Roman Kennke rken...@redhat.com wrote:
Am Mittwoch, den 17.10.2012, 14:40 -0700 schrieb Christian Thalinger
To: Christian Thalinger christian.thalin...@oracle.com
Cc: hotspot-...@openjdk.java.net
Am Mittwoch, den 17.10.2012, 15:34 -0700 schrieb Christian Thalinger:
On Oct 17, 2012, at 3:05 PM, Roman Kennke rken...@redhat.com wrote:
Am Mittwoch, den 17.10.2012, 14:40 -0700 schrieb Christian Thalinger
.
I'm not comfortable to fix it as a part of 7194607.
One question is what tests are need to be run to verify possible fixes.
I'll open a separate CR under hotspot/runtime to track the Interpreter
issues related to max_stack.
Thanks,
Serguei
On 10/31/12 10:54 AM, Christian Thalinger wrote
On Oct 30, 2012, at 4:25 PM, serguei.spit...@oracle.com wrote:
Ok, it seems there are some suspicious fragments in the interpreter code.
Christian, could you, please, check and comment the fragments below?
This is how the Method::max_stack() is defined:
src/share/vm/oops/method.hpp:
On Oct 24, 2012, at 3:32 PM, John Rose john.r.r...@oracle.com wrote:
On Oct 24, 2012, at 1:08 PM, Jochen Theodorou wrote:
what do you suggest as workaround?
You could force the class to be initialized when the MH is created. This can
be done with Class.forName. It would not exactly
To: Christian Thalinger christian.thalin...@oracle.com
Cc: hotspot-...@openjdk.java.net
Am Mittwoch, den 17.10.2012, 15:34 -0700 schrieb Christian Thalinger:
On Oct 17, 2012, at 3:05 PM, Roman Kennke rken...@redhat.com wrote:
Am Mittwoch, den 17.10.2012, 14:40 -0700 schrieb Christian Thalinger
Thank you, Kelly. -- Chris
On Oct 29, 2012, at 11:05 AM, Kelly O'Hair kelly.oh...@oracle.com wrote:
Looks fine.
-kto
On Oct 29, 2012, at 10:42 AM, Christian Thalinger wrote:
This patch contains a Makefile change:
http://cr.openjdk.java.net/~rkennke/zerojdk8/webrev.03/make
On Oct 22, 2012, at 11:39 AM, mark.reinh...@oracle.com wrote:
2012/10/18 12:17 -0700, christian.thalin...@oracle.com:
On Oct 18, 2012, at 12:00 PM, mark.reinh...@oracle.com wrote:
Um, isn't this an awfully big change for what's supposed to be a low-risk
update release?
It's big, indeed.
and quick approvals then it
might be worth it.
-- Chris
I understand some more PIT testing is going to be run - Let's see how test
results look before proceeding.
regards,
Sean.
[1] http://openjdk.java.net/projects/jdk7u/bulkchanges.html
On 18/10/2012 12:22, Christian Thalinger wrote
On Oct 19, 2012, at 11:26 AM, Christian Thalinger
christian.thalin...@oracle.com wrote:
On Oct 18, 2012, at 6:48 PM, Seán Coffey sean.cof...@oracle.com wrote:
Christian,
It is quite a big code change for 7u, one worthy of more testing before
integration perhaps. Doesn't this code
On Oct 18, 2012, at 12:17 PM, Christian Thalinger
christian.thalin...@oracle.com wrote:
On Oct 18, 2012, at 12:00 PM, mark.reinh...@oracle.com wrote:
2012/10/18 11:54 -0700, christian.thalin...@oracle.com:
Webrev: http://cr.openjdk.java.net/~twisti/8000999/
8000999: backport of JSR 292
http://cr.openjdk.java.net/~twisti/6771058
6771058: TEST_BUG: java/lang/ref/Basic.java may fail with -server -Xcomp
Reviewed-by:
This test can fail if finalizer of Basic is not called for some
reason. It happens in compiled mode if compilation is more slow than
execution of the main loop.
The
fix and
it worked. The other suggested fix is to increase the sleep time (but I don't
like that).
-- Chris
Mandy
On 10/18/2012 2:43 PM, Christian Thalinger wrote:
http://cr.openjdk.java.net/~twisti/6771058
6771058: TEST_BUG: java/lang/ref/Basic.java may fail with -server -Xcomp
On Oct 17, 2012, at 8:33 AM, David Chase david.r.ch...@oracle.com wrote:
On 2012-10-16, at 8:53 PM, Charles Oliver Nutter head...@headius.com wrote:
So *almost* everything is inlining, but one path (I believe it's the
failure path from GWT after talking with Christian) is not reached.
This change broke the usage of previously built versions of hsdis. I filed a
bug for it:
8000489: older builds of hsdis don't work anymore after 6879063
Yumin, I assigned the bug to you. Could you please take care of it?
-- Chris
On Aug 27, 2012, at 2:07 PM, Yumin Qi yumin...@oracle.com
are already in HS24.
-- Chris
David
On 17/10/2012 5:54 AM, Christian Thalinger wrote:
http://cr.openjdk.java.net/~twisti/8000999
8000999: backport of JSR 292 to 7u
Reviewed-by:
This is an umbrella bug for these changes (which are backported in one
changeset):
6983728: JSR 292
Could you rerun the test with a recent JDK 8 build?
-- Chris
On Oct 10, 2012, at 3:02 PM, Ashwin Jayaprakash ashwin.jayaprak...@gmail.com
wrote:
Hi, I was looking at the Java 7 InvokeDynamic/MethodHandle feature set and I
was curious to know how it performed compared to good old Reflection.
On Oct 9, 2012, at 5:27 PM, Charles Oliver Nutter head...@headius.com wrote:
I reported this to Christian, but thought I'd toss it here in case
someone else runs into it.
It appears that C1 (tier 1) is failing to compile a indy + MH virtual
target into a proper overridden call. In other
Vote: yes
On Oct 5, 2012, at 2:21 AM, Maurizio Cimadamore
maurizio.cimadam...@oracle.com wrote:
I hereby nominate Robert Field to JDK8 Committer.
Robert works in the Langtools team at Oracle, and has already contributed
several change sets to the Lambda repository. Robert will
be
Vote: yes
On Sep 19, 2012, at 10:30 AM, John Coomes john.coo...@oracle.com wrote:
I hereby nominate Alejandro Murillo to jdk7u Committer.
Alejandro is a performance engineer and also the HotSpot gatekeeper.
In the latter role he's responsible for delivering HotSpot sources
into jdk7
On Sep 15, 2012, at 3:15 PM, Charles Oliver Nutter head...@headius.com wrote:
Things like this worry me a bit too, but there's only a couple of them :)
We need to find out why these guys deoptimize. Either add
-XX:+TraceDeoptimization or -XX:+LogCompilation (for the latter the output is
Looks good. -- Chris
On Aug 28, 2012, at 4:48 PM, Yumin Qi yumin...@oracle.com wrote:
Hi, all
Updated with feedback suggestions. Please have a look again at the same
link.
Thanks
Yumin
On 2012/8/27 14:07, Yumin Qi wrote:
Hi, all
Can I have you code review of
On Aug 27, 2012, at 2:07 PM, Yumin Qi yumin...@oracle.com wrote:
Hi, all
Can I have you code review of
6879063: SA should use hsdis for disassembly
http://cr.openjdk.java.net/~minqi/6879063
The SA has Java based disassemblers for x86 and sparc but amd64. Instead
of
On Aug 21, 2012, at 2:00 AM, MacGregor, Duncan (GE Energy)
duncan.macgre...@ge.com wrote:
On 20/08/2012 20:47, Christian Thalinger
christian.thalin...@oracle.com wrote:
On Aug 20, 2012, at 12:02 PM, MacGregor, Duncan (GE Energy)
duncan.macgre...@ge.com wrote:
While trying to do some
On Aug 21, 2012, at 2:47 PM, BILL PITTORE bill.pitt...@oracle.com wrote:
These changes allow for the (easier) addition of new processor types to SA
other than the standard x86, amd64 and sparc. By using reflection, it is not
necessary to instantiate the new class directly in the existing
201 - 300 of 1313 matches
Mail list logo
