https://github.com/cyndyishida approved this pull request.
the InstallAPI changes LGTM, thanks!
https://github.com/llvm/llvm-project/pull/93190
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://github.com/cyndyishida closed
https://github.com/llvm/llvm-project/pull/91770
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cyndyishida updated
https://github.com/llvm/llvm-project/pull/91770
>From 291412a203ea60465d4ecae9317f3490c59bfb50 Mon Sep 17 00:00:00 2001
From: Cyndy Ishida
Date: Thu, 2 May 2024 19:53:07 -0700
Subject: [PATCH 1/3] [InstallAPI] add JSON option to pass X arguments
---
https://github.com/cyndyishida updated
https://github.com/llvm/llvm-project/pull/91770
>From 291412a203ea60465d4ecae9317f3490c59bfb50 Mon Sep 17 00:00:00 2001
From: Cyndy Ishida
Date: Thu, 2 May 2024 19:53:07 -0700
Subject: [PATCH 1/2] [InstallAPI] add JSON option to pass X arguments
---
Author: Cyndy Ishida
Date: 2024-05-10T17:17:38-07:00
New Revision: 504cf554639360525c3f746e7296a242350b2af9
URL:
https://github.com/llvm/llvm-project/commit/504cf554639360525c3f746e7296a242350b2af9
DIFF:
https://github.com/llvm/llvm-project/commit/504cf554639360525c3f746e7296a242350b2af9.diff
https://github.com/cyndyishida created
https://github.com/llvm/llvm-project/pull/91770
None
>From 480f1a6dd0c78c8018ac08259b4d3cba64c25165 Mon Sep 17 00:00:00 2001
From: Cyndy Ishida
Date: Thu, 2 May 2024 19:53:07 -0700
Subject: [PATCH] [InstallAPI] add JSON option to pass X arguments
---
https://github.com/cyndyishida closed
https://github.com/llvm/llvm-project/pull/90686
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
cyndyishida wrote:
ping
https://github.com/llvm/llvm-project/pull/90686
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cyndyishida updated
https://github.com/llvm/llvm-project/pull/90686
>From faabe7752dbb596f13e0e676b5c8db9fb8ad9258 Mon Sep 17 00:00:00 2001
From: Cyndy Ishida
Date: Thu, 18 Apr 2024 07:28:44 -0700
Subject: [PATCH] [InstallAPI] Support mutually exclusive parse options
https://github.com/cyndyishida updated
https://github.com/llvm/llvm-project/pull/90686
>From c4fec501607059b1030b7c53794ad271194d Mon Sep 17 00:00:00 2001
From: Cyndy Ishida
Date: Thu, 18 Apr 2024 07:28:44 -0700
Subject: [PATCH 1/2] [InstallAPI] Support mutually exclusive parse options
https://github.com/cyndyishida created
https://github.com/llvm/llvm-project/pull/90686
Projects like libc use mutually exclusive macros to compile files multiple
times and then merge the result into the final library. For installapi to
accept these, we'd need to parse the same declarations in
https://github.com/cyndyishida closed
https://github.com/llvm/llvm-project/pull/90664
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cyndyishida created
https://github.com/llvm/llvm-project/pull/90664
Add validation in the FileList reader to check that the headers exist and use
similar diagnostics in Options.cpp
>From 42ad6921fdf179647f6529ddeb7d060e93e0f52f Mon Sep 17 00:00:00 2001
From: Cyndy Ishida
cyndyishida wrote:
> Overall I really like the direction of this. I'm curious if any of the
> maintainers from Apple have thoughts since they're the primary users of
> availability annotations.
While I like the approach of aligning availability parameters closer to
`llvm::Triple`, I am
cyndyishida wrote:
It appears your PR branch is based on a stale version of the target `llvm/main`
branch, resulting in more commits than what this PR intended for. Please merge
in the target branch and resolve any conflicts.
https://github.com/llvm/llvm-project/pull/89480
https://github.com/cyndyishida closed
https://github.com/llvm/llvm-project/pull/89483
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cyndyishida edited
https://github.com/llvm/llvm-project/pull/89483
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cyndyishida created
https://github.com/llvm/llvm-project/pull/89483
Matches up with the clang tools
>From 76ece379c8a8325b0f866a89e1de523cbeaa0c25 Mon Sep 17 00:00:00 2001
From: Cyndy Ishida
Date: Fri, 19 Apr 2024 19:34:14 -0700
Subject: [PATCH] [clang][darwin][cmake]
https://github.com/cyndyishida closed
https://github.com/llvm/llvm-project/pull/89270
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
cyndyishida wrote:
> How hard would it be to make the output here have a consistent order? I mean,
> emitting diagnostics in a consistent order isn't nearly as important as
> emitting consistent binaries, but it's still nice to have if we can get it
> easily.
I don't think it's too hard in
cyndyishida wrote:
> It looks like this is causing failures on the reverse-iteration buildbot
> (https://lab.llvm.org/buildbot/#/builders/54/builds/9683)
Thanks for the heads up, should be fixed by
https://github.com/llvm/llvm-project/pull/89270
https://github.com/cyndyishida created
https://github.com/llvm/llvm-project/pull/89270
None
>From efefd04b1545b62f3a22bc0ff53bfb0a2a512b1f Mon Sep 17 00:00:00 2001
From: Cyndy Ishida
Date: Thu, 18 Apr 2024 10:24:35 -0700
Subject: [PATCH] [InstallAPI][Tests] Update tests to be resilient to
https://github.com/cyndyishida closed
https://github.com/llvm/llvm-project/pull/88750
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -259,7 +259,10 @@ bool Options::processLinkerOptions(InputArgList ) {
if (auto *Arg = Args.getLastArg(drv::OPT_umbrella))
LinkerOpts.ParentUmbrella = Arg->getValue();
- LinkerOpts.IsDylib = Args.hasArg(drv::OPT_dynamiclib);
cyndyishida wrote:
nope,
https://github.com/cyndyishida updated
https://github.com/llvm/llvm-project/pull/88750
>From b2b54ad8ccf930a19327563a64c52c9f4013103f Mon Sep 17 00:00:00 2001
From: Cyndy Ishida
Date: Thu, 11 Apr 2024 13:13:45 -0700
Subject: [PATCH 1/4] [InstallAPI] Add support for aliased exports
Apple's ld
cyndyishida wrote:
ping, is there anything else needed to land this patch?
https://github.com/llvm/llvm-project/pull/88750
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cyndyishida updated
https://github.com/llvm/llvm-project/pull/88750
>From b2b54ad8ccf930a19327563a64c52c9f4013103f Mon Sep 17 00:00:00 2001
From: Cyndy Ishida
Date: Thu, 11 Apr 2024 13:13:45 -0700
Subject: [PATCH 1/3] [InstallAPI] Add support for aliased exports
Apple's ld
https://github.com/cyndyishida updated
https://github.com/llvm/llvm-project/pull/88750
>From b2b54ad8ccf930a19327563a64c52c9f4013103f Mon Sep 17 00:00:00 2001
From: Cyndy Ishida
Date: Thu, 11 Apr 2024 13:13:45 -0700
Subject: [PATCH 1/2] [InstallAPI] Add support for aliased exports
Apple's ld
@@ -973,5 +978,24 @@ bool DylibVerifier::verifyBinaryAttrs(const
ArrayRef ProvidedTargets,
return true;
}
+std::unique_ptr DylibVerifier::getExports() {
+ for (const auto &[Alias, Base] : Aliases) {
cyndyishida wrote:
`getExports()` only gets called once
https://github.com/cyndyishida updated
https://github.com/llvm/llvm-project/pull/88750
>From b2b54ad8ccf930a19327563a64c52c9f4013103f Mon Sep 17 00:00:00 2001
From: Cyndy Ishida
Date: Thu, 11 Apr 2024 13:13:45 -0700
Subject: [PATCH] [InstallAPI] Add support for aliased exports
Apple's ld
https://github.com/cyndyishida updated
https://github.com/llvm/llvm-project/pull/88750
>From d7a4e72f80a9dcd18770dec1e06fd54518b60233 Mon Sep 17 00:00:00 2001
From: Cyndy Ishida
Date: Thu, 11 Apr 2024 13:13:45 -0700
Subject: [PATCH] [InstallAPI] Add support for aliased exports
Apple's ld
https://github.com/cyndyishida created
https://github.com/llvm/llvm-project/pull/88750
Apple's ld supports alias_lists, described as
```
-alias_list filename
The specified filename contains a list of aliases. The symbol name
and its alias are on one
line,
Author: Cyndy Ishida
Date: 2024-04-12T22:05:12-07:00
New Revision: 79dca25f4a0fefd47e9e37d9ce47d84dc0b3bedb
URL:
https://github.com/llvm/llvm-project/commit/79dca25f4a0fefd47e9e37d9ce47d84dc0b3bedb
DIFF:
https://github.com/llvm/llvm-project/commit/79dca25f4a0fefd47e9e37d9ce47d84dc0b3bedb.diff
https://github.com/cyndyishida closed
https://github.com/llvm/llvm-project/pull/88205
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cyndyishida closed
https://github.com/llvm/llvm-project/pull/88448
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cyndyishida updated
https://github.com/llvm/llvm-project/pull/88448
>From 0039cbc0d53a4ff8530b78657f8365229162516b Mon Sep 17 00:00:00 2001
From: Cyndy Ishida
Date: Thu, 11 Apr 2024 14:10:15 -0700
Subject: [PATCH 1/2] [clang][docs] Modernize attribute docs for darwin
https://github.com/cyndyishida created
https://github.com/llvm/llvm-project/pull/88448
* Generally recommend target triples. But replace `m*version-min` with
`mtargetos`.
* Also include test coverage for -mtargetos=visionos
>From 0039cbc0d53a4ff8530b78657f8365229162516b Mon Sep 17 00:00:00
@@ -588,13 +622,58 @@ void DylibVerifier::visitSymbolInDylib(const Record ,
SymbolContext ) {
}
}
+ const bool IsLinkerSymbol = SymbolName.starts_with("$ld$");
+
+ if (R.isVerified()) {
+// Check for unavailable symbols.
+// This should only occur in the
@@ -588,13 +622,58 @@ void DylibVerifier::visitSymbolInDylib(const Record ,
SymbolContext ) {
}
}
+ const bool IsLinkerSymbol = SymbolName.starts_with("$ld$");
+
+ if (R.isVerified()) {
+// Check for unavailable symbols.
+// This should only occur in the
https://github.com/cyndyishida created
https://github.com/llvm/llvm-project/pull/88205
A zippered framework is a single framework that can be loaded in both macOS and
macatalyst processes. Broadly to InstallAPI, it means the same interface can
represent two separate platforms.
A dylib's
https://github.com/cyndyishida closed
https://github.com/llvm/llvm-project/pull/88189
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cyndyishida updated
https://github.com/llvm/llvm-project/pull/88189
>From a7894f987b80f1916195c3ab15da5c33ab69ab00 Mon Sep 17 00:00:00 2001
From: Cyndy Ishida
Date: Tue, 9 Apr 2024 13:04:18 -0700
Subject: [PATCH] [InstallAPI] Tie lifetime of FE objects to DylibVerifier
A
https://github.com/cyndyishida created
https://github.com/llvm/llvm-project/pull/88189
A few verification checks need to happen until all AST's have been traversed,
specifically for zippered framework checking. To keep source location until
that time valid, hold onto to references of
cyndyishida wrote:
> FYI, it looks like this change broke `compiler-rt` build, e.g. in
> https://lab.llvm.org/buildbot/#/builders/270/builds/12485
Should be resolved by:
https://github.com/llvm/llvm-project/commit/fe45029dbdee6b3df2dbeaed17c9dd598ec511f2
I suspect compiler-rt may be relying
@@ -1029,6 +1038,16 @@ macro(add_llvm_executable name)
add_llvm_symbol_exports( ${name} ${LLVM_EXPORTED_SYMBOL_FILE} )
endif(LLVM_EXPORTED_SYMBOL_FILE)
+ if (NOT LLVM_ENABLE_EXPORTED_SYMBOLS_IN_EXECUTABLES)
+if(LLVM_LINKER_SUPPORTS_NO_EXPORTED_SYMBOLS)
+
https://github.com/cyndyishida closed
https://github.com/llvm/llvm-project/pull/87684
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cyndyishida closed
https://github.com/llvm/llvm-project/pull/87674
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
cyndyishida wrote:
Thanks for reviewing @zixu-w !
https://github.com/llvm/llvm-project/pull/87674
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cyndyishida updated
https://github.com/llvm/llvm-project/pull/87684
>From 3ac6872328334384fa20998541fac841add767d9 Mon Sep 17 00:00:00 2001
From: Cyndy Ishida
Date: Thu, 4 Apr 2024 12:08:28 -0700
Subject: [PATCH 1/4] [cmake] Build executables with -no_exported_symbols when
https://github.com/cyndyishida updated
https://github.com/llvm/llvm-project/pull/87674
>From 7ef1a803c10cfef8f577a4e439221d778215464a Mon Sep 17 00:00:00 2001
From: Cyndy Ishida
Date: Wed, 27 Mar 2024 12:17:01 -0400
Subject: [PATCH 1/3] [InstallAPI] Capture and compare load commands that may
https://github.com/cyndyishida updated
https://github.com/llvm/llvm-project/pull/87684
>From 3ac6872328334384fa20998541fac841add767d9 Mon Sep 17 00:00:00 2001
From: Cyndy Ishida
Date: Thu, 4 Apr 2024 12:08:28 -0700
Subject: [PATCH 1/3] [cmake] Build executables with -no_exported_symbols when
https://github.com/cyndyishida updated
https://github.com/llvm/llvm-project/pull/87674
>From 7ef1a803c10cfef8f577a4e439221d778215464a Mon Sep 17 00:00:00 2001
From: Cyndy Ishida
Date: Wed, 27 Mar 2024 12:17:01 -0400
Subject: [PATCH 1/2] [InstallAPI] Capture and compare load commands that may
https://github.com/cyndyishida closed
https://github.com/llvm/llvm-project/pull/87666
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cyndyishida edited
https://github.com/llvm/llvm-project/pull/87666
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cyndyishida updated
https://github.com/llvm/llvm-project/pull/87674
>From 7ef1a803c10cfef8f577a4e439221d778215464a Mon Sep 17 00:00:00 2001
From: Cyndy Ishida
Date: Wed, 27 Mar 2024 12:17:01 -0400
Subject: [PATCH] [InstallAPI] Capture and compare load commands that may
https://github.com/cyndyishida updated
https://github.com/llvm/llvm-project/pull/87674
>From a7e67582e35fe6c33a1e391eaf6cc7d5b49087c6 Mon Sep 17 00:00:00 2001
From: Cyndy Ishida
Date: Wed, 27 Mar 2024 12:17:01 -0400
Subject: [PATCH 1/2] [InstallAPI] Capture and compare load commands that may
@@ -673,6 +673,9 @@ option(LLVM_USE_OPROFILE
option(LLVM_EXTERNALIZE_DEBUGINFO
"Generate dSYM files and strip executables and libraries (Darwin Only)" OFF)
+option(LLVM_ENABLE_EXPORTED_SYMBOLS
cyndyishida wrote:
Would
@@ -654,6 +654,11 @@ enabled sub-projects. Nearly all of these variable names
begin with
Generate dSYM files and strip executables and libraries (Darwin Only).
Defaults to OFF.
+**LLVM_ENABLE_EXPORTED_SYMBOLS**:BOOL
+ When building executables, preserve symbol exports.
@@ -673,6 +673,9 @@ option(LLVM_USE_OPROFILE
option(LLVM_EXTERNALIZE_DEBUGINFO
"Generate dSYM files and strip executables and libraries (Darwin Only)" OFF)
+option(LLVM_ENABLE_NO_EXPORTED_SYMBOLS
cyndyishida wrote:
No preference here. Whatever seems easier
https://github.com/cyndyishida updated
https://github.com/llvm/llvm-project/pull/87684
>From 3ac6872328334384fa20998541fac841add767d9 Mon Sep 17 00:00:00 2001
From: Cyndy Ishida
Date: Thu, 4 Apr 2024 12:08:28 -0700
Subject: [PATCH 1/2] [cmake] Build executables with -no_exported_symbols when
https://github.com/cyndyishida updated
https://github.com/llvm/llvm-project/pull/87666
>From 6b2f262d1e69724d4eb96f5ad75aa2c202f3eb2d Mon Sep 17 00:00:00 2001
From: Cyndy Ishida
Date: Thu, 4 Apr 2024 10:36:47 -0700
Subject: [PATCH] [InstallAPI] Add test to validate cc1 arg forwading
---
Author: Cyndy Ishida
Date: 2024-04-02T09:17:06-07:00
New Revision: 207f1531d611b8add27b94e756e0bc7eb864babf
URL:
https://github.com/llvm/llvm-project/commit/207f1531d611b8add27b94e756e0bc7eb864babf
DIFF:
https://github.com/llvm/llvm-project/commit/207f1531d611b8add27b94e756e0bc7eb864babf.diff
https://github.com/cyndyishida closed
https://github.com/llvm/llvm-project/pull/87299
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cyndyishida updated
https://github.com/llvm/llvm-project/pull/87299
>From fc2b73a261a0eddb19d49fcbbf301ec40a1d5ed2 Mon Sep 17 00:00:00 2001
From: Cyndy Ishida
Date: Mon, 1 Apr 2024 18:09:27 -0700
Subject: [PATCH] [InstallAPI] Fixup dsym test to actually run when compiler is
https://github.com/cyndyishida created
https://github.com/llvm/llvm-project/pull/87299
Update the test to run when the compiler is built to support arm64-darwin
targets.
>From fc2b73a261a0eddb19d49fcbbf301ec40a1d5ed2 Mon Sep 17 00:00:00 2001
From: Cyndy Ishida
Date: Mon, 1 Apr 2024 18:09:27
https://github.com/cyndyishida closed
https://github.com/llvm/llvm-project/pull/86980
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Cyndy Ishida
Date: 2024-03-29T10:34:35-07:00
New Revision: bdb60e6f0c8e89abf9bdf36411348db304ca65ba
URL:
https://github.com/llvm/llvm-project/commit/bdb60e6f0c8e89abf9bdf36411348db304ca65ba
DIFF:
https://github.com/llvm/llvm-project/commit/bdb60e6f0c8e89abf9bdf36411348db304ca65ba.diff
Author: Cyndy Ishida
Date: 2024-03-29T10:00:51-07:00
New Revision: 60deb8b39afe9be90e30aa18d77ad129dacd4d55
URL:
https://github.com/llvm/llvm-project/commit/60deb8b39afe9be90e30aa18d77ad129dacd4d55
DIFF:
https://github.com/llvm/llvm-project/commit/60deb8b39afe9be90e30aa18d77ad129dacd4d55.diff
https://github.com/cyndyishida closed
https://github.com/llvm/llvm-project/pull/86852
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
cyndyishida wrote:
Thanks for the reviews!
https://github.com/llvm/llvm-project/pull/86980
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cyndyishida created
https://github.com/llvm/llvm-project/pull/86980
`-reexport*` is the newer spelling for `-sub-library` which is already
supported by the clang driver when invoking ld.
Support the new spellings when passed by the user. This also helps simplify
https://github.com/cyndyishida updated
https://github.com/llvm/llvm-project/pull/86852
>From 9ddf01a4f28df19914aa393b1ac518410693af5b Mon Sep 17 00:00:00 2001
From: Cyndy Ishida
Date: Wed, 27 Mar 2024 14:33:15 -0400
Subject: [PATCH 1/4] [InstallAPI] Add support for parsing dSYMs
InstallAPI
@@ -0,0 +1,40 @@
+; RUN: rm -rf %t
+; RUN: split-file %s %t
+
+// Build a simple dylib with debug info.
+; RUN: %clang --target=arm64-apple-macos13 -g -dynamiclib %t/foo.c \
cyndyishida wrote:
Looks like the linker on the linux bot doesn't support building
@@ -511,14 +520,16 @@ DylibVerifier::Result DylibVerifier::verify(GlobalRecord
*R,
return verifyImpl(R, SymCtx);
}
-void DylibVerifier::VerifierContext::emitDiag(
-llvm::function_ref Report) {
+void DylibVerifier::VerifierContext::emitDiag(llvm::function_ref
Report,
+
https://github.com/cyndyishida updated
https://github.com/llvm/llvm-project/pull/86852
>From 9ddf01a4f28df19914aa393b1ac518410693af5b Mon Sep 17 00:00:00 2001
From: Cyndy Ishida
Date: Wed, 27 Mar 2024 14:33:15 -0400
Subject: [PATCH 1/3] [InstallAPI] Add support for parsing dSYMs
InstallAPI
https://github.com/cyndyishida updated
https://github.com/llvm/llvm-project/pull/86852
>From 9ddf01a4f28df19914aa393b1ac518410693af5b Mon Sep 17 00:00:00 2001
From: Cyndy Ishida
Date: Wed, 27 Mar 2024 14:33:15 -0400
Subject: [PATCH 1/2] [InstallAPI] Add support for parsing dSYMs
InstallAPI
@@ -0,0 +1,40 @@
+; RUN: rm -rf %t
+; RUN: split-file %s %t
+
+// Build a simple dylib with debug info.
+; RUN: %clang --target=arm64-apple-macos13 -g -dynamiclib %t/foo.c \
cyndyishida wrote:
@JDevlieghere Is there a better/known practice for generating full
https://github.com/cyndyishida created
https://github.com/llvm/llvm-project/pull/86852
InstallAPI does not directly look at object files in the dylib for
verification. To help diagnose violations where a declaration is undiscovered
in headers, parse the dSYM and look up the source location
https://github.com/cyndyishida closed
https://github.com/llvm/llvm-project/pull/86587
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cyndyishida updated
https://github.com/llvm/llvm-project/pull/86587
>From 5be17ceb3272253aa52d77fbf8426782e9c21f72 Mon Sep 17 00:00:00 2001
From: Cyndy Ishida
Date: Mon, 25 Mar 2024 17:12:14 -0400
Subject: [PATCH] [InstallAPI] Add *umbrella-header options
Umbrella headers
https://github.com/cyndyishida edited
https://github.com/llvm/llvm-project/pull/86808
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -255,7 +255,7 @@ bool InstallAPIVisitor::VisitFunctionDecl(const
FunctionDecl *D) {
return true;
// Skip methods in CXX RecordDecls.
-for (auto P : D->getASTContext().getParents(*M)) {
+for (const auto : D->getASTContext().getParents(*M)) {
https://github.com/cyndyishida approved this pull request.
Can you condense the title to something more like `[clang-installapi] Remove
unnecessary copy`?
A couple of nits but in general looks good. Thanks for fixing this!
https://github.com/llvm/llvm-project/pull/86808
https://github.com/cyndyishida updated
https://github.com/llvm/llvm-project/pull/86587
>From 9b25b0486d8f3c8409ee199a9f4695da7780e6cb Mon Sep 17 00:00:00 2001
From: Cyndy Ishida
Date: Mon, 25 Mar 2024 17:12:14 -0400
Subject: [PATCH 1/3] [InstallAPI] Add *umbrella-header options
Umbrella
https://github.com/cyndyishida edited
https://github.com/llvm/llvm-project/pull/86587
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -424,6 +448,56 @@ InstallAPIContext Options::createContext() {
if (!Glob->didMatch())
Diags->Report(diag::warn_glob_did_not_match) << Glob->str();
+ // Mark any explicit or inferred umbrella headers. If one exists, move
+ // that to the beginning of the input
https://github.com/cyndyishida updated
https://github.com/llvm/llvm-project/pull/86587
>From 9b25b0486d8f3c8409ee199a9f4695da7780e6cb Mon Sep 17 00:00:00 2001
From: Cyndy Ishida
Date: Mon, 25 Mar 2024 17:12:14 -0400
Subject: [PATCH 1/3] [InstallAPI] Add *umbrella-header options
Umbrella
Author: Cyndy Ishida
Date: 2024-03-26T11:56:16-04:00
New Revision: 6d579cd1d91cdde5adfa455bda7903e737e9d5cf
URL:
https://github.com/llvm/llvm-project/commit/6d579cd1d91cdde5adfa455bda7903e737e9d5cf
DIFF:
https://github.com/llvm/llvm-project/commit/6d579cd1d91cdde5adfa455bda7903e737e9d5cf.diff
@@ -424,6 +448,56 @@ InstallAPIContext Options::createContext() {
if (!Glob->didMatch())
Diags->Report(diag::warn_glob_did_not_match) << Glob->str();
+ // Mark any explicit or inferred umbrella headers. If one exists, move
+ // that to the beginning of the input
https://github.com/cyndyishida updated
https://github.com/llvm/llvm-project/pull/86587
>From 9b25b0486d8f3c8409ee199a9f4695da7780e6cb Mon Sep 17 00:00:00 2001
From: Cyndy Ishida
Date: Mon, 25 Mar 2024 17:12:14 -0400
Subject: [PATCH 1/2] [InstallAPI] Add *umbrella-header options
Umbrella
https://github.com/cyndyishida created
https://github.com/llvm/llvm-project/pull/86587
Umbrella headers are a concept for Darwin-based libraries. They allow framework
authors to control the order in which their headers should be parsed and allow
clients to access available headers by
https://github.com/cyndyishida closed
https://github.com/llvm/llvm-project/pull/86574
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Cyndy Ishida
Date: 2024-03-25T17:20:24-04:00
New Revision: a9d8bf41bf9538154bcc3afcef55bdf309890c6f
URL:
https://github.com/llvm/llvm-project/commit/a9d8bf41bf9538154bcc3afcef55bdf309890c6f
DIFF:
https://github.com/llvm/llvm-project/commit/a9d8bf41bf9538154bcc3afcef55bdf309890c6f.diff
https://github.com/cyndyishida closed
https://github.com/llvm/llvm-project/pull/86522
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cyndyishida closed
https://github.com/llvm/llvm-project/pull/86025
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cyndyishida updated
https://github.com/llvm/llvm-project/pull/86025
>From 9c75bb6dac672fedef114618500cd8600501f8aa Mon Sep 17 00:00:00 2001
From: Cyndy Ishida
Date: Wed, 20 Mar 2024 15:50:01 -0700
Subject: [PATCH 1/4] [InstallAPI] Report exports discovered in binary but not
@@ -21,6 +21,9 @@ CHECK-NEXT: CPP.h:5:7: error: declaration has external
linkage, but symbol has i
CHECK-NEXT: CPP.h:6:7: error: dynamic library symbol '(weak-def) Bar::init()'
is weak defined, but its declaration is not
CHECK-NEXT: int init();
CHECK-NEXT: ^
https://github.com/cyndyishida updated
https://github.com/llvm/llvm-project/pull/86025
>From 9c75bb6dac672fedef114618500cd8600501f8aa Mon Sep 17 00:00:00 2001
From: Cyndy Ishida
Date: Wed, 20 Mar 2024 15:50:01 -0700
Subject: [PATCH 1/3] [InstallAPI] Report exports discovered in binary but not
https://github.com/cyndyishida updated
https://github.com/llvm/llvm-project/pull/86025
>From 9c75bb6dac672fedef114618500cd8600501f8aa Mon Sep 17 00:00:00 2001
From: Cyndy Ishida
Date: Wed, 20 Mar 2024 15:50:01 -0700
Subject: [PATCH 1/2] [InstallAPI] Report exports discovered in binary but not
https://github.com/cyndyishida updated
https://github.com/llvm/llvm-project/pull/86025
>From 9c75bb6dac672fedef114618500cd8600501f8aa Mon Sep 17 00:00:00 2001
From: Cyndy Ishida
Date: Wed, 20 Mar 2024 15:50:01 -0700
Subject: [PATCH] [InstallAPI] Report exports discovered in binary but not in
1 - 100 of 222 matches
Mail list logo
