Re: [PATCH 4/4] drm: Add getfb2 ioctl

On 23 March 2018 at 17:31, Ville Syrjälä <ville.syrj...@linux.intel.com> wrote: > On Fri, Mar 23, 2018 at 05:00:11PM +0000, Daniel Stone wrote: >> On 23 March 2018 at 14:49, Ville Syrjälä <ville.syrj...@linux.intel.com> >> wrote: >> > On Fri, Mar 23, 2018 at

Re: [PATCH 4/4] drm: Add getfb2 ioctl

Hi, On 23 March 2018 at 14:49, Ville Syrjälä <ville.syrj...@linux.intel.com> wrote: > On Fri, Mar 23, 2018 at 01:45:52PM +0000, Daniel Stone wrote: >> + for (i = 0; i < ARRAY_SIZE(r->handles); i++) { >> + r->handles[i] = 0; >> + r

Re: [igt-dev] [PATCH i-g-t 1/3] tests/kms_getfb: Split property-ID get into helper

On 23 March 2018 at 14:53, Ville Syrjälä <ville.syrj...@linux.intel.com> wrote: > On Fri, Mar 23, 2018 at 01:46:14PM +0000, Daniel Stone wrote: >> +/** >> + * Find and return an arbitrary valid property ID. >> + */ >> +static uint32_t get_prop_id(int fd) > &

Re: [Intel-gfx] [PATCH 2/4] drm/i915: Move GEM BO inside drm_framebuffer

Hi Ville, On 23 March 2018 at 14:42, Ville Syrjälä <ville.syrj...@linux.intel.com> wrote: > On Fri, Mar 23, 2018 at 01:45:50PM +0000, Daniel Stone wrote: >> --- a/drivers/gpu/drm/i915/intel_display.c >> +++ b/drivers/gpu/drm/i915/intel_display.c >> @@ -1391

Re: [Intel-gfx] [PATCH 2/4] drm/i915: Move GEM BO inside drm_framebuffer

Hi Ville, On 23 March 2018 at 14:42, Ville Syrjälä <ville.syrj...@linux.intel.com> wrote: > On Fri, Mar 23, 2018 at 01:45:50PM +0000, Daniel Stone wrote: >> --- a/drivers/gpu/drm/i915/intel_display.c >> +++ b/drivers/gpu/drm/i915/intel_display.c >> @@ -1391

Re: [PATCH 0/8] Add GetFB2 ioctl

On 23 March 2018 at 13:42, Daniel Stone <dan...@fooishbar.org> wrote: > This submission rights that historical wrong, which allows Xorg > -background none to continue to work in the face of exotic buffers. > I've written patches to Xorg to use this as UABI verification, and >

[PATCH xserver 2/3] modesetting/drmmode: Use glamor_pixmap_from_fds

. Signed-off-by: Daniel Stone <dani...@collabora.com> --- hw/xfree86/drivers/modesetting/drmmode_display.c | 52 +++- 1 file changed, 42 insertions(+), 10 deletions(-) diff --git a/hw/xfree86/drivers/modesetting/drmmode_display.c b/hw/xfree86/drivers/modesetting/drmmode_dis

[PATCH xserver 0/3] Use DRM GetFB2 ioctl

Hi, This short patchset makes modesetting use the shiny, new, and completely not at all merged GetFB2 DRM ioctl: https://lists.freedesktop.org/archives/dri-devel/2018-March/170512.html When starting Xorg with -background none, it uses GetFB to interrogate the current framebuffer, importing it

[PATCH xserver 1/3] modesetting/drmmode: Remove unused flink call

We don't use flink in the GetFB import path anymore, as we do an FD-based import instead. Signed-off-by: Daniel Stone <dani...@collabora.com> --- hw/xfree86/drivers/modesetting/drmmode_display.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/hw/xfree86/drivers/modes

[PATCH xserver 3/3] modesetting/drmmode: Use drmModeGetFB2

Much like AddFB -> AddFB2, GetFB2 lets us get multiple buffers back as well as modifier information. This lets us use -background none with multiplanar formats, or modifiers which can't be inferred via a magic side channel. Signed-off-by: Daniel Stone <dani...@collabora.com> --- h

[PATCH i-g-t 3/3] tests/kms_getfb: Add getfb2 tests

Mirroring addfb2, add tests for the new ioctl which will return us information about framebuffers containing multiple buffers, as well as modifiers. Signed-off-by: Daniel Stone <dani...@collabora.com> --- tests/kms_getfb.c | 91 +++

[PATCH i-g-t 2/3] NOMERGE: Update DRM UAPI to latest kernel version

This depends on unmerged kernel code, so. --- include/drm-uapi/amdgpu_drm.h | 1 + include/drm-uapi/drm.h | 1 + include/drm-uapi/drm_mode.h| 9 ++--- include/drm-uapi/etnaviv_drm.h | 1 + include/drm-uapi/msm_drm.h | 9 - include/drm-uapi/virtgpu_drm.h | 1 + 6 files

[PATCH 2/4] drm/i915: Move GEM BO inside drm_framebuffer

Since drm_framebuffer can now store GEM objects directly, place them there rather than in our own subclass. Signed-off-by: Daniel Stone <dani...@collabora.com> Cc: Jani Nikula <jani.nik...@linux.intel.com> Cc: Joonas Lahtinen <joonas.lahti...@linux.intel.com> Cc: Rodri

[PATCH 1/4] drm/i915: Use intel_fb_obj() everywhere

We already have a macro to pull the GEM object from a FB, so use it everywhere. We'll make use of this later to move the object storage. Signed-off-by: Daniel Stone <dani...@collabora.com> Cc: Jani Nikula <jani.nik...@linux.intel.com> Cc: Joonas Lahtinen <joonas.lahti...@linu

[PATCH i-g-t 1/3] tests/kms_getfb: Split property-ID get into helper

We'll want to reuse this, so split it out into a (smaller!) helper. Signed-off-by: Daniel Stone <dani...@collabora.com> --- tests/kms_getfb.c | 36 +++- 1 file changed, 19 insertions(+), 17 deletions(-) diff --git a/tests/kms_getfb.c b/tests/kms_getfb.c

[Intel-gfx] [PATCH 1/4] drm/i915: Use intel_fb_obj() everywhere

We already have a macro to pull the GEM object from a FB, so use it everywhere. We'll make use of this later to move the object storage. Signed-off-by: Daniel Stone <dani...@collabora.com> Cc: Jani Nikula <jani.nik...@linux.intel.com> Cc: Joonas Lahtinen <joonas.lahti...@linu

[PATCH 3/4] drm: Reshuffle getfb error returns

Make it a little more clear what's going on inside of getfb, and also make it easier to add alternate paths to get a handle in future. Signed-off-by: Daniel Stone <dani...@collabora.com> --- drivers/gpu/drm/drm_framebuffer.c | 33 + 1 file changed, 17 inse

[PATCH 4/4] drm: Add getfb2 ioctl

getfb2 allows us to pass multiple planes and modifiers, just like addfb2 over addfb. Signed-off-by: Daniel Stone <dani...@collabora.com> --- drivers/gpu/drm/drm_crtc_internal.h | 2 + drivers/gpu/drm/drm_framebuffer.c | 109 drivers/gpu/drm/drm_i

[PATCH libdrm] NOMERGE: Add drmModeGetFB2

Add a wrapper around the getfb2 ioctl, which returns extended framebuffer information mirroring addfb2, including multiple planes and modifiers. This depends on unmerged kernel API so should not be merged. --- include/drm/drm.h | 1 + xf86drmMode.c | 40

[Intel-gfx] [PATCH 2/4] drm/i915: Move GEM BO inside drm_framebuffer

Since drm_framebuffer can now store GEM objects directly, place them there rather than in our own subclass. Signed-off-by: Daniel Stone <dani...@collabora.com> Cc: Jani Nikula <jani.nik...@linux.intel.com> Cc: Joonas Lahtinen <joonas.lahti...@linux.intel.com> Cc: Rodri

[PATCH 0/8] Add GetFB2 ioctl

Hi, AddFB is single-planar, with no offset and only depth/bpp rather than an explicit format, so we now have AddFB2 which can carry multiple planes, an explicit format and also a modifier. At the time we never actually did GetFB2 to go with GetFB. This submission rights that historical wrong,

Re: [Intel-gfx] [PATCH] drm: Fix uabi regression by allowing garbage mode->type from userspace

ts we > don't want. The mode type is just a hint anyway, and more > useful for the kernel->userspace direction. Reviewed-by: Daniel Stone <dani...@collabora.com> ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] drm: Fix uabi regression by allowing garbage mode->type from userspace

ts we > don't want. The mode type is just a hint anyway, and more > useful for the kernel->userspace direction. Reviewed-by: Daniel Stone <dani...@collabora.com> ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [Mesa-dev] [PATCH v2 1/7] waylan-drm: do not distribute generated sources

Hi Juan, On 22 March 2018 at 16:49, Juan A. Suarez Romero wrote: > Instead we will re-generate them again on building. Thanks for sending the v2 - that looks good to me. There was some kind of problem with having the sources in BUILT_SOURCES though, which Emil might be able

Re: [Mesa-dev] [PATCH] egl/wayland: Make swrast display_sync the correct queue

On 22 March 2018 at 15:20, Derek Foreman wrote: > commit 03dd9a88b0be17ff0ce91e92f6902a9a85ba584a introduced per surface > queues, but the display_sync for swrast_commit_backbuffer remained on > the old queue. This is likely to break when dispatching the correct > queue

Mesa (master): egl/wayland: Make swrast display_sync the correct queue

e sync callback we're waiting for). The easiest known reproduction case is running weston-subsurfaces under weston --use-pixman Signed-off-by: Derek Foreman <der...@osg.samsung.com> Reviewed-by: Daniel Stone <dani...@collabora.com> --- src/egl/drivers/dri2/platform_wayland.c | 2 +-

[Mesa-dev] [PATCH] x11: Only report supported DRI3/Present versions

which we support, and only pass those. Signed-off-by: Daniel Stone <dani...@collabora.com> --- src/egl/drivers/dri2/platform_x11_dri3.c | 19 +++ src/glx/dri3_glx.c | 21 +++-- 2 files changed, 30 insertions(+), 10 deletions(-) diff

Re: [Mesa-dev] [PATCH 0/8] Fix several issues/missings in make dist/distcheck

On 22 March 2018 at 11:16, Juan A. Suarez Romero <jasua...@igalia.com> wrote: > On Thu, 2018-03-22 at 11:03 +, Emil Velikov wrote: >> On 21 March 2018 at 13:36, Daniel Stone <dan...@fooishbar.org> wrote: >> > I thought we had resolved earlier to _not_ ship f

Re: [PATCH 08/10] drm/fourcc: Add definitions for Allwinner vendor and MB32 tiled format

Hi Paul, On 21 March 2018 at 15:29, Paul Kocialkowski wrote: > +/* > + * Allwinner "MB32" tiled format > + * > + * This is the primary layout coming out of the VPU, where pixels are tiled > + * 32x32. > + */ Can you please be a bit more specific here, following

Re: [PATCH 08/10] drm/fourcc: Add definitions for Allwinner vendor and MB32 tiled format

Hi Paul, On 21 March 2018 at 15:29, Paul Kocialkowski wrote: > +/* > + * Allwinner "MB32" tiled format > + * > + * This is the primary layout coming out of the VPU, where pixels are tiled > + * 32x32. > + */ Can you please be a bit more specific here, following the other examples? In

Re: [PATCH 08/10] drm/fourcc: Add definitions for Allwinner vendor and MB32 tiled format

Hi Paul, On 21 March 2018 at 15:29, Paul Kocialkowski wrote: > +/* > + * Allwinner "MB32" tiled format > + * > + * This is the primary layout coming out of the VPU, where pixels are tiled > + * 32x32. > + */ Can you please be a bit more specific here, following

Re: [Mesa-dev] [PATCH 0/8] Fix several issues/missings in make dist/distcheck

Hi Juan, On 19 March 2018 at 17:49, Juan A. Suarez Romero wrote: > The first two patches in the series is a new fix for issue > https://bugs.freedesktop.org/show_bug.cgi?id=105211, as the current version > breaks when running the above command, due "make dist/distcheck"

Re: [PATCH] drm: Reject getfb for multi-plane framebuffers

Hi, On 21 March 2018 at 08:27, Daniel Vetter <dan...@ffwll.ch> wrote: > On Tue, Mar 20, 2018 at 09:01:11PM -0400, Rob Clark wrote: >> On Tue, Mar 20, 2018 at 6:58 PM, Daniel Stone <dani...@collabora.com> wrote: >> > getfb can only return a single pl

Re: [PATCH wayland] wayland-egl: Ignore underscored symbols in ABI check

Hi, On 21 March 2018 at 08:27, Pekka Paalanen <ppaala...@gmail.com> wrote: > On Tue, 20 Mar 2018 11:46:32 +0000, Daniel Stone <dan...@fooishbar.org> wrote: >> inconvenience of maintaining a list of every linker's implementation >> detail on every platform, outwei

[PATCH] drm: Reject getfb for multi-plane framebuffers

getfb can only return a single plane, so reject attempts to use it with multi-plane framebuffers. Signed-off-by: Daniel Stone <dani...@collabora.com> Reported-by: Daniel van Vugt <daniel.van.v...@canonical.com> Fixes: 308e5bcbdb10 ("drm: add an fb creation ioctl that takes a

[Intel-gfx] [PATCH i-g-t] meson: Chamelium depends on GSL

Chamelium support requires igt_frame to be built, which requires both GSL and Pixman. Signed-off-by: Daniel Stone <dani...@collabora.com> --- meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meson.build b/meson.build index ef7017cb..5b783e5d

Re: [Mesa-dev] [PATCH] dri3: Fix typo in version check

On 20 March 2018 at 16:24, Dylan Baker <dy...@pnwbakers.com> wrote: > Quoting Daniel Stone (2018-03-20 09:17:21) >> The have-new-DRI3 codepaths would never actually properly trigger, since >> there was a typo in configure.ac which broke the version check. This >> went

Mesa (master): dri3: Fix typo in version check

Module: Mesa Branch: master Commit: 9f3509665d880457487dff82a96132d2eb27a0b4 URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=9f3509665d880457487dff82a96132d2eb27a0b4 Author: Daniel Stone <dani...@collabora.com> Date: Tue Mar 20 16:05:13 2018 + dri3: Fix typo in version

Re: [Mesa-dev] [PATCH 2/2] meson: Don't build svga on ARM/AArch64

On 20 March 2018 at 16:16, Dylan Baker <dy...@pnwbakers.com> wrote: > Quoting Daniel Stone (2018-03-20 01:54:25) >> VMware has no (published) support for Arm-architecture guests. Pushed now with review and the new suggested title - thanks both for review!

Mesa (master): meson: Don't build svga by default on ARM/AArch64

Module: Mesa Branch: master Commit: bc5e59119ef6e7fdb5b54ce0a690a1ad43e6401c URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=bc5e59119ef6e7fdb5b54ce0a690a1ad43e6401c Author: Daniel Stone <dani...@collabora.com> Date: Tue Feb 27 18:00:23 2018 + meson: Don't build svga by d

Mesa (master): meson: Add default DRI drivers for ARM/AArch64

Module: Mesa Branch: master Commit: d7603cb518cf1e0bf2c07d6ce4b139bf075b3980 URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=d7603cb518cf1e0bf2c07d6ce4b139bf075b3980 Author: Daniel Stone <dani...@collabora.com> Date: Tue Feb 27 10:00:24 2018 + meson: Add default DRI d

[Mesa-dev] [PATCH] dri3: Fix typo in version check

The have-new-DRI3 codepaths would never actually properly trigger, since there was a typo in configure.ac which broke the version check. This went unnoticed but for an error in config.log if you looked closely enough. Signed-off-by: Daniel Stone <dani...@collabora.com> Reported-by: L

Re: [PATCH weston 1/7] compositor-drm: remove superfluos get_disable_state call

Hi Emre, On 20 March 2018 at 14:28, Emre Ucan wrote: > drm_output_get_disable_state function returns > a duplicated output_state object. > > Here we are creating the object, but we are > never using it. Therefore, it is safe to remove. > > (Found by clang source code

Re: [PATCH wayland] wayland-egl: Ignore underscored symbols in ABI check

On 20 March 2018 at 11:55, Emil Velikov <emil.l.veli...@gmail.com> wrote: > On 20 March 2018 at 11:46, Daniel Stone <dan...@fooishbar.org> wrote: >> Sure. As on IRC though, we definitely need to add at least _ftext for >> MIPS anyway: >> https://g

Re: [PATCH wayland] wayland-egl: Ignore underscored symbols in ABI check

Hi Emil, On 20 March 2018 at 11:30, Emil Velikov <emil.l.veli...@gmail.com> wrote: > On 20 March 2018 at 11:01, Daniel Stone <dani...@collabora.com> wrote: >> Rather than a hard-coded list of platform symbols, just ignore anything >> prefaced with an underscore. This f

[PATCH wayland] wayland-egl: Ignore underscored symbols in ABI check

Rather than a hard-coded list of platform symbols, just ignore anything prefaced with an underscore. This fixes breakage on ARM, which declares several slightly different platform symbols to x86. Signed-off-by: Daniel Stone <dani...@collabora.com> Fixes: 21b1f22eb056 ("wayland-e

Mesa (master): dri3: Don't fail on version mismatch

Module: Mesa Branch: master Commit: 478fc2d2a1a392108f48a3ed9aa21b10be72b4a2 URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=478fc2d2a1a392108f48a3ed9aa21b10be72b4a2 Author: Daniel Stone <dani...@collabora.com> Date: Mon Mar 19 15:03:22 2018 + dri3: Don't fail on version mi

[Mesa-dev] [PATCH 2/2] meson: Don't build svga on ARM/AArch64

VMware has no (published) support for Arm-architecture guests. Signed-off-by: Daniel Stone <dani...@collabora.com> Cc: Dylan Baker <dy...@pnwbakers.com> --- meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meson.build b/meson.build index 88e90fe8119.

[Mesa-dev] [PATCH 1/2] meson: Add default DRI drivers for ARM/AArch64

On all Arm architectures (ARMv7 and below as 'arm', ARMv8 and above as 'aarch64'), only build swrast for DRI drivers. The only classic drivers which could be used are r200 and NV20 cards, which seems unlikely enough that it shouldn't be the default. Signed-off-by: Daniel Stone <d

Re: [PATCH wayland] wayland-egl: Make symbol test fail on failure

Hi, On 19 March 2018 at 16:08, Eric Engestrom <eric.engest...@imgtec.com> wrote: > On Monday, 2018-03-19 15:13:14 +0000, Daniel Stone wrote: >> +if ! test -f "$LIB"; then >> + echo "Test binary \"$LIB\" does not exist" >> + exit

[Mesa-dev] [PATCH] dri3: Don't fail on version mismatch

-by: Daniel Stone <dani...@collabora.com> Fixes: 7aeef2d4efdc ("dri3: allow building against older xcb (v3)") Cc: Dave Airlie <airl...@redhat.com> --- src/egl/drivers/dri2/egl_dri2.c | 2 +- src/egl/drivers/dri2/platform_x11_dri3.c | 10 ++--

[PATCH wayland] wayland-egl: Make symbol test fail on failure

this as an error condition, rather than test failure. v2: Don't test if we can execute $NM. Signed-off-by: Daniel Stone <dani...@collabora.com> Reported-by: Pekka Paalanen <pekka.paala...@collabora.co.uk> Fixes: 21b1f22eb056 ("wayland-egl: enhance the symbol test") Cc: E

Re: [PATCH wayland 2/2] wayland-egl: Make symbol test fail on failure

Hi Emil, On 19 March 2018 at 13:27, Emil Velikov <emil.l.veli...@gmail.com> wrote: > On 19 March 2018 at 13:20, Daniel Stone <dan...@fooishbar.org> wrote: >> Me neither really, but it seemed best for consistency with the rest of >> the file which used test rather tha

Re: [PATCH wayland 2/2] wayland-egl: Make symbol test fail on failure

Hi Quentin, Thanks for the quick review! On 19 March 2018 at 13:06, Quentin Glidic <sardemff7+wayl...@sardemff7.net> wrote: > On 3/19/18 1:31 PM, Daniel Stone wrote: >> diff --git a/egl/wayland-egl-symbols-check b/egl/wayland-egl-symbols-check >> index c47026b2..d1a4a6b

Re: [PATCH wayland v3 1/3] wayland-egl: fail the symbol check if lib is missing

Hi, On 19 March 2018 at 11:43, Emil Velikov wrote: > On 19 March 2018 at 09:56, Pekka Paalanen wrote: >> On Fri, 16 Mar 2018 16:18:57 + >> Emil Velikov wrote: >>> Right - I was aiming to remove the bonkers envvar and

[PATCH wayland 1/2] wayland-egl: Pass nm path to check script

A previous patch used $NM as an environment variable, but this was only set as a make variable. Make sure it is passed through from make to the environment we use to run tests. Signed-off-by: Daniel Stone <dani...@collabora.com> Reported-by: Pekka Paalanen <pekka.paala...@collabora.co.

[PATCH wayland 2/2] wayland-egl: Make symbol test fail on failure

this as an error condition, rather than test failure. Signed-off-by: Daniel Stone <dani...@collabora.com> Reported-by: Pekka Paalanen <pekka.paala...@collabora.co.uk> Fixes: 21b1f22eb056 ("wayland-egl: enhance the symbol test") Cc: Emil Velikov <emil.veli...@collabora.com>

Re: [PATCH wayland-protcols v3] unstable: add xdg-toplevel-decoration protocol

Hi Eike, On 18 March 2018 at 16:35, Eike Hein wrote: > On 03/18/2018 03:55 PM, Markus Ongyerth wrote: >>> a) Change the definition of "decoration" to "window controls as deemed >>> appropriate by the compositor, for example ...". This leaves what's in a >>> server-side deco and

Re: [PATCH wayland-protcols v3] unstable: add xdg-toplevel-decoration protocol

Hi, On 18 March 2018 at 16:22, Eike Hein <h...@kde.org> wrote: > On 03/18/2018 10:45 PM, Daniel Stone wrote: >> That strikes me as a problem. So what can we do to bridge the gap >> between these projects? > > FWIW, I agree this is a problem. KDE's Wayland contribut

Re: [Mesa-dev] Patchwork has 'Server Error (500)'

Hi Dieter, On 18 March 2018 at 00:48, Dieter Nützel wrote: > @ least, here fromm Germany. > > https://patchwork.freedesktop.org/ > Server Error (500) This is fixed now, and I think that particular problem shouldn't happen again. Cheers, Daniel

Re: [PATCH wayland-protcols v3] unstable: add xdg-toplevel-decoration protocol

Hi Drew, On 15 March 2018 at 16:53, Drew DeVault wrote: >> Denying facts and being disingenuous doesn't help anyone, and it's >> tiring. Tiring enough that I came into this thread with the intention >> of giving this protocol a couple of suggestions and a push towards >> getting

Re: [Mesa-dev] [PATCH 0/3] Meson patches for FreeBSD

Hi, On 16 March 2018 at 15:23, Matt Turner wrote: > On Fri, Mar 16, 2018 at 8:07 AM, Emil Velikov > wrote: >> On 16 March 2018 at 02:39, Matt Turner wrote: >>> All of your messages are going to spam on gmail: >>> >> Setting up

Re: [PATCH wayland v3 1/3] wayland-egl: fail the symbol check if lib is missing

d-off-by: Emil Velikov <emil.veli...@collabora.com> The series is: Reviewed-by: Daniel Stone <dani...@collabora.com> Cheers, Daniel ___ wayland-devel mailing list wayland-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/wayland-devel

Re: [Mesa-dev] [ANNOUNCE] Mesa 17.3.7 release candidate

Hi Juan, On 16 March 2018 at 11:42, Juan A. Suarez Romero <jasua...@igalia.com> wrote: > Trivial merge conflicts > --- > > [...] > > commit 5fd11359b66c8138d2c7ee29bd9740280b02d1e2 > Author: Daniel Stone <dani...@collabora.com> > > e

Re: [PATCH wayland-protcols v3] unstable: add xdg-toplevel-decoration protocol

On 15 March 2018 at 15:21, Drew DeVault <s...@cmpwn.com> wrote: > On 2018-03-15 3:16 PM, Daniel Stone wrote: >> You could write a compositor which put decorations on everything >> unless explicitly instructed not to, and claim victory in the name of >> technical co

Re: [PATCH wayland-protcols v3] unstable: add xdg-toplevel-decoration protocol

Hi, On 15 March 2018 at 15:12, Drew DeVault wrote: > On 2018-03-15 3:04 PM, Mike Blumenkrantz wrote: >> It seems to me that there is no harm in restating that clients are required >> to implement CSD inside a protocol which permits adding a separate, >> optional method of window

Re: [PATCH weston v2] build: honour libinput header location

whichever patch you feel more confortable with. I have a mild preference for this one, but either is: Reviewed-by: Daniel Stone <dani...@collabora.com> Cheers, Daniel ___ wayland-devel mailing list wayland-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/wayland-devel

Re: [PATCH wayland] tests: disable coredumps on sanity-test

gt; > I counted 21 entries in coredumpctl list, while only 16 functions needed > patching. After this patch no entries appear in coredumpctl list. Very nice, thankyou! Reviewed-by: Daniel Stone <dani...@collabora.com> Cheers, Daniel ___ wayl

Re: [Mesa-dev] [PATCH 1/2] autotools+dri3: allow building against older xcb (v4)

Hi, On 14 March 2018 at 13:04, Rob Clark wrote: > I'm not sure everyone wants to be updating their dri3 in a forced > march setting, this allows a nicer approach, esp when you want > to build on distro that aren't brand new. I don't have that much of an opinion on whether

Re: [PATCH] drm/vc4: Add support for SAND modifier.

ing like an 8 code / 48 params split would make more sense. Either way, those are just my opinions (you did ask), and I don't see anything really objectionable, so if you think that's a good split then this is: Acked-by: Daniel Stone <dani...@collabora.com> Cheers, Daniel

Re: [PATCH] drm/vc4: Add support for SAND modifier.

params split would make more sense. Either way, those are just my opinions (you did ask), and I don't see anything really objectionable, so if you think that's a good split then this is: Acked-by: Daniel Stone Cheers, Daniel

Re: [PATCH] drm/vc4: Add support for SAND modifier.

ing like an 8 code / 48 params split would make more sense. Either way, those are just my opinions (you did ask), and I don't see anything really objectionable, so if you think that's a good split then this is: Acked-by: Daniel Stone <dani...@collabora.com> Cheers, Daniel _

Re: [Mesa-dev] [PATCH 2/2] vulkan/wsi/x11: correct DRI3 version in comment

Hi Emil, On 13 March 2018 at 11:40, Emil Velikov <emil.l.veli...@gmail.com> wrote: > During development the version was bumped, yet the comment did not get > an update. > > Cc: Daniel Stone <dani...@collabora.com> > Fixes: c80c08e2260 ("vulkan/wsi/x11: Add supp

Re: [Mesa-dev] [PATCH 1/3] wayland-drm: Expose server-side xbgr2101010 and abgr2101010 formats.

Hi Mario, On 12 March 2018 at 20:45, Mario Kleiner wrote: > This way the wayland server can signal support for these formats > to wayland EGL clients. This is currently used by nouveau for 10 > bpc support. > > Tested with glmark2-wayland and glmark2-es2-wayland under

Re: [PATCH xserver] modesetting: Fix page flipping under DRI 3.2.

time machine, that would probably be the first thing I would change about the modifiers API. Reviewed-by: Daniel Stone <dani...@collabora.com> Cheers, Daniel ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-

Re: [Mesa-dev] [RFC] Mesa 17.3.x release problems and process improvements

Hi Juan, On 12 March 2018 at 12:10, Juan A. Suarez Romero <jasua...@igalia.com> wrote: > On Mon, 2018-03-12 at 11:49 +0000, Daniel Stone wrote: >> On 12 March 2018 at 11:31, Juan A. Suarez Romero <jasua...@igalia.com> wrote: >> > We are improving this by moving to us

Re: [Mesa-dev] [RFC] Mesa 17.3.x release problems and process improvements

Hi Juan, On 12 March 2018 at 11:31, Juan A. Suarez Romero wrote: > On Fri, 2018-03-09 at 12:12 -0800, Mark Janes wrote: >> Ilia Mirkin writes: >> - CI Automation immediately builds/tests the proposed stable branch >>whenever it changes. Release

Re: [PATCH wayland v2 1/4] Revert "wayland-egl-symbols-check: pass the DSO name via the build system"

Hi, On 12 March 2018 at 11:21, Emil Velikov <emil.l.veli...@gmail.com> wrote: > On 9 March 2018 at 11:09, Daniel Stone <dan...@fooishbar.org> wrote: >> On 9 March 2018 at 10:59, Emil Velikov <emil.l.veli...@gmail.com> wrote: >>> - above all, the internal pa

Re: [PATCH] xwm: Update input region on resize

Hi Scott, On 19 February 2018 at 19:18, Scott Moreau wrote: > Commit 332d1892 introduced a bug because the window was > shaped only when the frame was created, leaving the input > region unchanged regardless if the window was resized. > This patch updates the input region shape

Re: [Mesa-dev] [PATCH] travis: bump libxcb version to 1.13

On 10 March 2018 at 14:53, Christian Gmeiner <christian.gmei...@gmail.com> wrote: > Fixes following dependency problem: > Native dependency xcb-dri3 found: NO found '1.11' but need: '>= 1.13' Oh, oops! Thanks for the catch Christian. Reviewed-by: Daniel Stone <dani...@co

Mesa (master): vulkan/wsi/x11: Add support for DRI3 v1.2

Module: Mesa Branch: master Commit: c80c08e226033e9e33abdca43e02e7f8c845ae0a URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=c80c08e226033e9e33abdca43e02e7f8c845ae0a Author: Daniel Stone <dani...@collabora.com> Date: Thu Jun 8 17:24:30 2017 +0100 vulkan/wsi/x11: Add support fo

Mesa (master): egl/x11: Support DRI3 v1.1

nne <l...@collabora.com> Reviewed-by: Eric Engestrom <eric.engest...@imgtec.com> Reviewed-by: Emil Velikov <emil.veli...@collabora.com> Reviewed-by: Daniel Stone <dani...@collabora.com> --- src/egl/drivers/dri2/egl_dri2.c | 7 + src/egl/drivers/dri2/egl_dri2.h

Mesa (master): egl/x11: Re-allocate buffers if format is suboptimal

nne <l...@collabora.com> Reviewed-by: Daniel Stone <dani...@collabora.com> --- src/egl/drivers/dri2/egl_dri2.c | 2 ++ src/egl/drivers/dri2/egl_dri2.h | 2 ++ src/egl/drivers/dri2/platform_x11_dri3.c | 3 +++ src/glx/dri3_glx.c |

Mesa (master): vulkan/wsi/x11: Return VK_SUBOPTIMAL_KHR for X11

Return VK_SUBOPTIMAL_KHR for X11 When it is detected that a window could have been flipped but has been copied because of suboptimal format/modifier. The Vulkan client should then re-create the swapchain. Signed-off-by: Louis-Francis Ratté-Boulianne <l...@collabora.com> Reviewed-by: Daniel

Re: [PATCH weston 1/2] clients: consolidate timer code part 1

the idea of centralising error-prone things in one place. It makes it much harder for people to get it wrong, and does serve our thriving community of people who copy Weston code into their own projects. Given that, I'd be in favour of landing for release, and the series is: Acked-by: Daniel St

Re: [PATCH] compositor-wayland: Ignore pointer enter on destroyed surface

Hi, On 9 March 2018 at 14:08, Pekka Paalanen <ppaala...@gmail.com> wrote: > On Fri, 9 Mar 2018 10:08:37 + > Daniel Stone <dani...@collabora.com> wrote: >> + if (!surface) { >> + input->output = NULL; >>

Re: [PATCH wayland v2 1/4] Revert "wayland-egl-symbols-check: pass the DSO name via the build system"

Hi Emil, On 9 March 2018 at 10:59, Emil Velikov <emil.l.veli...@gmail.com> wrote: > On 9 March 2018 at 09:47, Daniel Stone <dan...@fooishbar.org> wrote: >> Patches 2-4 look fine and I'm happy to merge them with my review, but >> could you please explain some more ab

Re: [PATCH weston] compositor-wayland: handle wl_keyboard.enter(NULL)

Hi Pekka, On 22 February 2018 at 14:54, Pekka Paalanen wrote: > Destroying an output (wl_surface) can race against the parent compositor > sending wl_keyboard.enter. When this race is lost, wayland-backend > receives wl_keyboard.enter with a NULL wl_surface for the surface

[PATCH] compositor-wayland: Ignore pointer enter on destroyed surface

destroyed surfaces. Signed-off-by: Daniel Stone <dani...@collabora.com> Cc: Pekka Paalanen <pekka.paala...@collabora.co.uk> --- libweston/compositor-wayland.c | 8 1 file changed, 8 insertions(+) diff --git a/libweston/compositor-wayland.c b/libweston/compositor-wayland.c ind

Re: [PATCH weston] libweston/compositor-drm: Reset repaint scheduled status when setting DPMS level to off

Hi Marius, On 7 March 2018 at 17:36, Marius Vlad wrote: > Otherwise when setting dpms level DPMS_ON, weston_output_schedule_repaint() > will bail out early and never get a chance to wake up the output. > > Arguably this could also be done in drm_set_dpms() when

Re: [RFC][PATCH 1/2] drm_hwcomposer: Error out on YUV layer as it would fail for single planes

Hi John, On 8 March 2018 at 19:43, John Stultz wrote: > On Thu, Mar 8, 2018 at 3:10 AM, Robert Foss wrote: >>> @@ -76,8 +76,6 @@ uint32_t >>> DrmGenericImporter::ConvertHalFormatToDrm(uint32_t hal_format) { >>> return

Re: [PATCH xserver] glamor/xwayland: Add depth 30 format mapping for DRI 3.2 as well.

On 9 March 2018 at 03:58, Mario Kleiner <mario.kleiner...@gmail.com> wrote: > Signed-off-by: Mario Kleiner <mario.kleiner...@gmail.com> Reviewed-by: Daniel Stone <dani...@collabora.com> ___ xorg-devel@lists.x.org: X.Org devel

Re: [Nouveau] nouveau 30bpp / deep color status

Hi, On 8 March 2018 at 17:08, Ilia Mirkin wrote: > On Thu, Mar 8, 2018 at 11:57 AM, Mario Kleiner > wrote: >> Under EGL there is matching of channel masks, so only X11+GLX is >> problematic. Not sure if anything special would need to be done for

[Mesa-dev] [PATCH 1/2] egl/wayland: Add 10bpc BGR configs

Add support for XBGR2101010 and ABGR2101010. Signed-off-by: Daniel Stone <dani...@collabora.com> Cc: Ilia Mirkin <imir...@alum.mit.edu> --- src/egl/drivers/dri2/platform_wayland.c | 12 1 file changed, 12 insertions(+) diff --git a/src/egl/drivers/dri2/platform_wayland.

[Mesa-dev] [PATCH 2/2] gbm: Add support for 10bpp BGR formats

Add support for XBGR2101010 and ABGR2101010 formats. Signed-off-by: Daniel Stone <dani...@collabora.com> --- src/gbm/backends/dri/gbm_dri.c | 8 1 file changed, 8 insertions(+) diff --git a/src/gbm/backends/dri/gbm_dri.c b/src/gbm/backends/dri/gbm_dri.c index df20db40218..b3d6c

Re: nouveau 30bpp / deep color status

Hi, On 8 March 2018 at 17:08, Ilia Mirkin wrote: > On Thu, Mar 8, 2018 at 11:57 AM, Mario Kleiner > wrote: >> Under EGL there is matching of channel masks, so only X11+GLX is >> problematic. Not sure if anything special would need to be done for

Re: [Mesa-dev] nouveau 30bpp / deep color status

Hi, On 8 March 2018 at 17:08, Ilia Mirkin wrote: > On Thu, Mar 8, 2018 at 11:57 AM, Mario Kleiner > wrote: >> Under EGL there is matching of channel masks, so only X11+GLX is >> problematic. Not sure if anything special would need to be done for

Re: [PATCH libdrm] drm/atomic: Refuse to add invalid objects to requests

On 7 March 2018 at 16:42, Daniel Vetter <dan...@ffwll.ch> wrote: > On Wed, Mar 07, 2018 at 12:42:15PM +0000, Daniel Stone wrote: >> Object and property IDs cannot be zero. Prevent them from being added to >> the request stream at all, rather than breaking at commit time. &g

Re: [PATCH wayland] client: Don't inappropriatly close fds for zombie objects

> > Test the fd count before calling. Ouch. I misread the 'size == 0' check at the top of close_fds_in() for 'max == 0', and thought that was OK. Oh well. Reviewed-by: Daniel Stone <dani...@collabora.com> Cheers, Daniel ___ wayland-devel

[PATCH libdrm] drm/atomic: Refuse to add invalid objects to requests

Object and property IDs cannot be zero. Prevent them from being added to the request stream at all, rather than breaking at commit time. Signed-off-by: Daniel Stone <dani...@collabora.com> --- xf86drmMode.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/xf86drmMode.c b/xf86drm

<    7   8   9   10   11   12   13   14   15   16   >