Also, enable the kernel side tests since these will pass now.
Signed-off-by: Darrell Ball
---
v3: Enable tests for kernel
Associated 4 system tests will fail until patches 5 and 6 of the
series; tests could otherwise be disabled in this patch then
re-enabled in patch 6.
tests/system-kmod
Fixes: 4ea96698f667 ("Userspace datapath: Add fragmentation handling.")
Signed-off-by: Darrell Ball
---
v3: Update documentation.
lib/dpctl.man | 2 +-
lib/ipf.c | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/lib/dpctl.man b/lib/dpctl.man
index f22029
ipf_reassemble_v4_frags() and ipf_reassemble_v6_frags() are
preallocating more than needed for the reassembled packet.
Signed-off-by: Darrell Ball
---
v3: Add minor optimization.
lib/ipf.c | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/lib/ipf.c b/lib/ipf.c
index
Signed-off-by: Darrell Ball
---
lib/ipf.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/lib/ipf.c b/lib/ipf.c
index df5196f..125a815 100644
--- a/lib/ipf.c
+++ b/lib/ipf.c
@@ -456,7 +456,7 @@ ipf_reassemble_v6_frags(struct ipf_list *ipf_list)
int rest_len
It is a day one issue that got copied to the FTP handling code.
Fixes: a489b16854b5 ("conntrack: New userspace connection tracker.")
Fixes: bd5e81a0e596 ("Userspace Datapath: Add ALG infra and FTP.")
CC: Daniele Di Proietto
Signed-off-by: Darrell Ball
---
Fixes: 4ea96698f667 ("Userspace datapath: Add fragmentation handling.")
Signed-off-by: Darrell Ball
---
Following system tests will fail until patch 6 of the series;
tests could otherwise be disabled in patch 4 then re-enabled in patch 6.
conntrack - IPv6 fragmentation, multiple
Fixes: 4ea96698f667 ("Userspace datapath: Add fragmentation handling.")
Signed-off-by: Darrell Ball
---
lib/ipf.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/ipf.c b/lib/ipf.c
index a4608af..acddc02 100644
--- a/lib/ipf.c
+++ b/lib/ipf.c
@@ -61
Signed-off-by: Darrell Ball
---
1/ This patch will fail to merge because it gets corrupted in e-mail
because of the long lines, but is submitted for completeness.
2/ Associated 4 system tests will fail until patches 5 and 6 of the
series; tests could otherwise be disabled in this patch
ipf_reassemble_v4_frags() and ipf_reassemble_v6_frags() are
preallocating more than needed for the reassembled packet.
Signed-off-by: Darrell Ball
---
lib/ipf.c | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/lib/ipf.c b/lib/ipf.c
index 125a815..a4608af 100644
Signed-off-by: Darrell Ball
---
lib/ipf.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/lib/ipf.c b/lib/ipf.c
index df5196f..125a815 100644
--- a/lib/ipf.c
+++ b/lib/ipf.c
@@ -456,7 +456,7 @@ ipf_reassemble_v6_frags(struct ipf_list *ipf_list)
int rest_len
[
https://issues.apache.org/jira/browse/HIVE-19580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16772256#comment-16772256
]
Darrell Ross commented on HIVE-19580:
-
Amazon appears to just require lower case.
https
[
https://issues.apache.org/jira/browse/HIVE-19580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16772256#comment-16772256
]
Darrell Ross edited comment on HIVE-19580 at 2/19/19 7:23 PM:
--
Amazon
[
https://issues.apache.org/jira/browse/HIVE-19580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16772256#comment-16772256
]
Darrell Ross edited comment on HIVE-19580 at 2/19/19 7:22 PM:
--
Amazon
[
https://issues.apache.org/jira/browse/HIVE-19580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16772216#comment-16772216
]
Darrell Ross edited comment on HIVE-19580 at 2/19/19 6:39 PM:
--
Has anyone
[
https://issues.apache.org/jira/browse/HIVE-19580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16772216#comment-16772216
]
Darrell Ross commented on HIVE-19580:
-
Has anyone found a solution to this? I have not reproduced
Ah, ok, that’s what I thought. Then I have no complaints about improved
defaults for the fuse case as long as the use case groups retain appropriately
optimized settings. Thanks!
> On Feb 12, 2019, at 11:14 PM, Raghavendra Gowdappa
> wrote:
>
>
>
> On Tue, Feb 12, 2019 a
Is there an example of a custom profile you can share for my ovirt use case
(with gfapi enabled)? Or are you just talking about the standard group settings
for virt as a custom profile?
> On Feb 12, 2019, at 7:22 AM, Raghavendra Gowdappa wrote:
>
> https://review.gluster.org/22203
thanks for the fix Ilya
On Fri, Feb 15, 2019 at 2:37 AM Ilya Maximets
wrote:
> Accidentially changed while updating conntrack support.
>
> CC: Darrell Ball
> Fixes: 4ea96698f667 ("Userspace datapath: Add fragmentation handling.")
> Signed-off-by: Ilya Maximets
&
I resent this patch with an addition as part of a series
On Thu, Feb 14, 2019 at 5:44 PM Darrell Ball wrote:
> Signed-off-by: Darrell Ball
> ---
> lib/ipf.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/lib/ipf.c b/lib/ipf.c
> index df
Fixes: 4ea96698f667 ("Userspace datapath: Add fragmentation handling.")
Signed-off-by: Darrell Ball
---
lib/ipf.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/ipf.c b/lib/ipf.c
index ec7c889..c386b69 100644
--- a/lib/ipf.c
+++ b/lib/ipf.c
@@ -61
ipf_reassemble_v4_frags() and ipf_reassemble_v6_frags() are
preallocating more than needed for the reassembled packet.
Signed-off-by: Darrell Ball
---
lib/ipf.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/ipf.c b/lib/ipf.c
index 125a815..ec7c889 100644
--- a/lib
Signed-off-by: Darrell Ball
---
lib/ipf.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/lib/ipf.c b/lib/ipf.c
index df5196f..125a815 100644
--- a/lib/ipf.c
+++ b/lib/ipf.c
@@ -456,7 +456,7 @@ ipf_reassemble_v6_frags(struct ipf_list *ipf_list)
int rest_len
Signed-off-by: Darrell Ball
---
lib/ipf.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/lib/ipf.c b/lib/ipf.c
index df5196f..c91afd3 100644
--- a/lib/ipf.c
+++ b/lib/ipf.c
@@ -530,8 +530,6 @@ ipf_list_state_transition(struct ipf *ipf, struct ipf_list
*ipf_list
ipf_list_key *key,
uint32_t hash)
-/* OVS_REQUIRES(ipf->ipf_lock) */
+OVS_REQUIRES(ipf->ipf_lock)
{
struct ipf_list *ipf_list;
HMAP_FOR_EACH_WITH_HASH (ipf_list, node, hash, >frag_lists) {
On Wed, Feb 13, 2019 at 3:34 PM Darrell Ball wrote:
> Fragmentat
Remove the struct wrapper and remove the unneeded union members.
There may even be a portability benefit here because of the
type punning.
Signed-off-by: Darrell Ball
---
lib/conntrack-private.h | 6 +-
lib/conntrack.c | 154 +++-
lib
Signed-off-by: Darrell Ball
---
lib/conntrack.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/lib/conntrack.c b/lib/conntrack.c
index c543aea..9a618a5 100644
--- a/lib/conntrack.c
+++ b/lib/conntrack.c
@@ -2010,11 +2010,9 @@ conn_key_hash(const struct conn_key *key
apath: Add ALG infra and FTP.")
Reported-by: David Marchand
Reviewed-by: David Marchand
Signed-off-by: Darrell Ball
---
lib/conntrack.c | 118 +++-
tests/system-traffic.at | 74 +++---
2 files changed, 123 inserti
The call to inet_ntop() in repl_ftp_v6_addr() is 1 short to handle
the maximum possible V6 address size for v4 mapping case.
Found by inspection.
Fixes: bd5e81a0e596 ("Userspace Datapath: Add ALG infra and FTP.")
Signed-off-by: Darrell Ball
---
lib/conntrack.c | 8 +++-
1 file
track: New userspace connection tracker.")
CC: Daniele Di Proietto
Co-authored-by: Vishal Deep Ajmera
Co-authored-by: Venkatesan Pradeep
Co-authored-by: Nitin Katiyar
Signed-off-by: Vishal Deep Ajmera
Signed-off-by: Venkatesan Pradeep
Signed-off-by: Nitin Katiyar
Signed-off-by: Da
The new api will be used in a subsequent patch.
Signed-off-by: Darrell Ball
---
lib/dp-packet.h | 16 +++-
1 file changed, 15 insertions(+), 1 deletion(-)
diff --git a/lib/dp-packet.h b/lib/dp-packet.h
index 980ef78..ea39eeb 100644
--- a/lib/dp-packet.h
+++ b/lib/dp-packet.h
track: New userspace connection tracker.")
CC: Daniele Di Proietto
Co-authored-by: Vishal Deep Ajmera
Co-authored-by: Venkatesan Pradeep
Co-authored-by: Nitin Katiyar
Signed-off-by: Vishal Deep Ajmera
Signed-off-by: Venkatesan Pradeep
Signed-off-by: Nitin Katiyar
Signed-off-by: Da
The new api will be used in a subsequent patch.
Signed-off-by: Darrell Ball
---
lib/dp-packet.h | 16 +++-
1 file changed, 15 insertions(+), 1 deletion(-)
diff --git a/lib/dp-packet.h b/lib/dp-packet.h
index cf7d247..b993d7e 100644
--- a/lib/dp-packet.h
+++ b/lib/dp-packet.h
track: New userspace connection tracker.")
CC: Daniele Di Proietto
Co-authored-by: Vishal Deep Ajmera
Co-authored-by: Venkatesan Pradeep
Co-authored-by: Nitin Katiyar
Signed-off-by: Vishal Deep Ajmera
Signed-off-by: Venkatesan Pradeep
Signed-off-by: Nitin Katiyar
Signed-off-by: Da
The new api will be used in a subsequent patch.
Signed-off-by: Darrell Ball
---
lib/dp-packet.h | 16 +++-
1 file changed, 15 insertions(+), 1 deletion(-)
diff --git a/lib/dp-packet.h b/lib/dp-packet.h
index 7c1e637..7d5438c 100644
--- a/lib/dp-packet.h
+++ b/lib/dp-packet.h
will not be in the database as well and overall simplicity.
Accordingly, fragmentation handling is enabled by default.
This patch enables fragmentation tests for the userspace datapath.
Signed-off-by: Darrell Ball
---
Documentation/faq/releases.rst | 51 +-
NEWS | 10
This is needed in a subsequent patch and may otherwise be useful.
Signed-off-by: Darrell Ball
---
lib/dp-packet.h | 2 ++
lib/dpif-netdev.c | 1 +
2 files changed, 3 insertions(+)
diff --git a/lib/dp-packet.h b/lib/dp-packet.h
index 31c26e5..5b13329 100644
--- a/lib/dp-packet.h
+++ b/lib/dp
This new api is used in a subsequent patch and may otherwise be useful.
Signed-off-by: Darrell Ball
---
lib/dp-packet.h | 6 ++
1 file changed, 6 insertions(+)
diff --git a/lib/dp-packet.h b/lib/dp-packet.h
index 26cfcb9..31c26e5 100644
--- a/lib/dp-packet.h
+++ b/lib/dp-packet.h
@@ -817,6
Signed-off-by: Darrell Ball
---
lib/ovs-atomic.h | 36
1 file changed, 36 insertions(+)
diff --git a/lib/ovs-atomic.h b/lib/ovs-atomic.h
index 21e230e..11fa192 100644
--- a/lib/ovs-atomic.h
+++ b/lib/ovs-atomic.h
@@ -479,6 +479,42 @@ atomic_count_set
Use 'must' instead of 'should'.
Suggested-by: Justin Pettit
Signed-off-by: Darrell Ball
---
lib/conntrack.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/conntrack.c b/lib/conntrack.c
index de75c67..a044a69 100644
--- a/lib/conntrack.c
+++ b/lib/conntrack.c
@@ -1298,7
Acked-by: Justin Pettit
Signed-off-by: Darrell Ball
---
tests/system-traffic.at | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tests/system-traffic.at b/tests/system-traffic.at
index e34f7a4..de40734 100644
--- a/tests/system-traffic.at
+++ b/tests/system-traffic.at
@@ -2981,6 +2981,7
Acked-by: Justin Pettit
Signed-off-by: Darrell Ball
---
lib/conntrack.c | 4 ++--
lib/flow.c | 44 ++--
lib/flow.h | 3 ++-
3 files changed, 38 insertions(+), 13 deletions(-)
diff --git a/lib/conntrack.c b/lib/conntrack.c
index 5c43410
Acked-by: Justin Pettit
Signed-off-by: Darrell Ball
---
lib/dp-packet.h | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/lib/dp-packet.h b/lib/dp-packet.h
index c297a8f..26cfcb9 100644
--- a/lib/dp-packet.h
+++ b/lib/dp-packet.h
@@ -522,28 +522,28
n; even though
it be redundant, add for completeness.
v2: Few fixes, improvements and cleanups.
Darrell Ball (8):
dp-packet: Add const qualifiers for checksum apis.
flow: Enhance parse_ipv6_ext_hdrs.
tests: Add missed local stack checks.
conntrack: Reword conntrack_execute() description.
o
r for someone actively working on this
aspect of OVN at the moment to answer this; I added a couple of people to
the thread.
>
>
> This behavior seems strange, am I missing something here?
>
>
>
> *От:* Darrell Ball [mailto:dlu...@gmail.com]
> *Отправлено:* 13 февраля
11.40)),recirc(0x3038)
btw; I don't see something corresponding to this in previous OF flow dump
link you sent.
Probably, you need to dump both OVN Southbound flows and Openflow flows to
see where these flows originate.
>
> As can be seen from output no conntrack entry is created
Ah, ok, that’s what I thought. Then I have no complaints about improved
defaults for the fuse case as long as the use case groups retain appropriately
optimized settings. Thanks!
> On Feb 12, 2019, at 11:14 PM, Raghavendra Gowdappa
> wrote:
>
>
>
> On Tue, Feb 12, 2019 a
On Wed, Feb 13, 2019 at 1:10 AM Li RongQing wrote:
> Assure the packet size is larger than ip total length
>
> Signed-off-by: Li RongQing
> ---
> lib/conntrack.c | 4
> 1 file changed, 4 insertions(+)
>
> diff --git a/lib/conntrack.c b/lib/conntrack.c
> index 5c43410ec..4a39327b3 100644
>
Thanks very much Ben
On Mon, Feb 11, 2019 at 5:33 PM Ben Pfaff wrote:
> On Sun, Feb 10, 2019 at 06:56:30PM -0800, Darrell Ball wrote:
> > Fragmentation handling is added for supporting conntrack.
> > Both v4 and v6 are supported.
> >
> > After discussion wit
On Tue, Feb 12, 2019 at 7:50 AM Ilya Maximets
wrote:
> Not a full review. Just a few notes about docs.
> See inline.
>
> Best regards, Ilya Maximets.
>
> On 11.02.2019 5:56, Darrell Ball wrote:
> > Fragmentation handling is added for supporting conntrack.
> >
Is there an example of a custom profile you can share for my ovirt use case
(with gfapi enabled)? Or are you just talking about the standard group settings
for virt as a custom profile?
> On Feb 12, 2019, at 7:22 AM, Raghavendra Gowdappa wrote:
>
> https://review.gluster.org/22203
nit(batch);
batch->count = 1;
-batch->do_not_steal = false;
batch->packets[0] = p;
}
On Sun, Feb 10, 2019 at 6:56 PM Darrell Ball wrote:
> This is needed in a subsequent patch and may otherwise be useful.
>
> Signed-off-by: Darrell Ball
> ---
> lib/dp-packet.h
:$
I sent a V12:
v12: Fixed last minute search and replace error to shorten line length:
- pb->dnsteal)) {
+ pb->do_not_steal)) {
Darrell
On Sun, Feb 10, 2019 at 6:15 PM 0-day Robot wrote:
> Bleep bloop.
will not be in the database as well and overall simplicity.
Accordingly, fragmentation handling is enabled by default.
This patch enables fragmentation tests for the userspace datapath.
Signed-off-by: Darrell Ball
---
Documentation/faq/releases.rst | 49 +-
NEWS | 10
This is needed in a subsequent patch and may otherwise be useful.
Signed-off-by: Darrell Ball
---
lib/dp-packet.h | 2 ++
lib/dpif-netdev.c | 1 +
2 files changed, 3 insertions(+)
diff --git a/lib/dp-packet.h b/lib/dp-packet.h
index 034b81b..c4ecd2d 100644
--- a/lib/dp-packet.h
+++ b/lib/dp
This new api is used in a subsequent patch and may otherwise be useful.
Signed-off-by: Darrell Ball
---
lib/dp-packet.h | 6 ++
1 file changed, 6 insertions(+)
diff --git a/lib/dp-packet.h b/lib/dp-packet.h
index a6e2a4f..034b81b 100644
--- a/lib/dp-packet.h
+++ b/lib/dp-packet.h
@@ -804,6
Use 'must' instead of 'should'.
Suggested-by: Justin Pettit
Signed-off-by: Darrell Ball
---
lib/conntrack.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/conntrack.c b/lib/conntrack.c
index 3bbe93f..b821c2d 100644
--- a/lib/conntrack.c
+++ b/lib/conntrack.c
@@ -1298,7
Signed-off-by: Darrell Ball
---
lib/ovs-atomic.h | 36
1 file changed, 36 insertions(+)
diff --git a/lib/ovs-atomic.h b/lib/ovs-atomic.h
index 21e230e..11fa192 100644
--- a/lib/ovs-atomic.h
+++ b/lib/ovs-atomic.h
@@ -479,6 +479,42 @@ atomic_count_set
Acked-by: Justin Pettit
Signed-off-by: Darrell Ball
---
tests/system-traffic.at | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tests/system-traffic.at b/tests/system-traffic.at
index e34f7a4..de40734 100644
--- a/tests/system-traffic.at
+++ b/tests/system-traffic.at
@@ -2981,6 +2981,7
Acked-by: Justin Pettit
Signed-off-by: Darrell Ball
---
lib/conntrack.c | 4 ++--
lib/flow.c | 44 ++--
lib/flow.h | 3 ++-
3 files changed, 38 insertions(+), 13 deletions(-)
diff --git a/lib/conntrack.c b/lib/conntrack.c
index 6b46d0c
Acked-by: Justin Pettit
Signed-off-by: Darrell Ball
---
lib/dp-packet.h | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/lib/dp-packet.h b/lib/dp-packet.h
index 7b85dd9..a6e2a4f 100644
--- a/lib/dp-packet.h
+++ b/lib/dp-packet.h
@@ -509,28 +509,28
e loose than intended.
Add another sanity check for fragment ip_tot_len; even though
it be redundant, add for completeness.
v2: Few fixes, improvements and cleanups.
Darrell Ball (8):
dp-packet: Add const qualifiers for checksum apis.
flow: Enhance parse_ipv6_ext_hdrs.
tests: Add
Use 'must' instead of 'should'.
Suggested-by: Justin Pettit
Signed-off-by: Darrell Ball
---
lib/conntrack.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/conntrack.c b/lib/conntrack.c
index 3bbe93f..b821c2d 100644
--- a/lib/conntrack.c
+++ b/lib/conntrack.c
@@ -1298,7
This new api is used in a subsequent patch and may otherwise be useful.
Signed-off-by: Darrell Ball
---
lib/dp-packet.h | 6 ++
1 file changed, 6 insertions(+)
diff --git a/lib/dp-packet.h b/lib/dp-packet.h
index a6e2a4f..034b81b 100644
--- a/lib/dp-packet.h
+++ b/lib/dp-packet.h
@@ -804,6
will not be in the database as well and overall simplicity.
Accordingly, fragmentation handling is enabled by default.
This patch enables fragmentation tests for the userspace datapath.
Signed-off-by: Darrell Ball
---
Documentation/faq/releases.rst | 49 +-
NEWS | 10
This is needed in a subsequent patch and may otherwise be useful.
Signed-off-by: Darrell Ball
---
lib/dp-packet.h | 2 ++
lib/dpif-netdev.c | 1 +
2 files changed, 3 insertions(+)
diff --git a/lib/dp-packet.h b/lib/dp-packet.h
index 034b81b..c4ecd2d 100644
--- a/lib/dp-packet.h
+++ b/lib/dp
I fixed a bug in V10 and sent V11.
i.e. V10 is superceded
Darrell
On Wed, Feb 6, 2019 at 7:55 PM Darrell Ball wrote:
> Fragmentation support for userspace datapath conntrack is added; both
> v4 and v6 are supported. See the patches for additional details.
>
> Fragmen
Acked-by: Justin Pettit
Signed-off-by: Darrell Ball
---
lib/dp-packet.h | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/lib/dp-packet.h b/lib/dp-packet.h
index 7b85dd9..a6e2a4f 100644
--- a/lib/dp-packet.h
+++ b/lib/dp-packet.h
@@ -509,28 +509,28
min_frag_size is
reconfigured.
Tighten ip_tot_len sanity check for reassembled packets which
was more loose than intended.
Add another sanity check for fragment ip_tot_len; even though
it be redundant, add for completeness.
v2: Few fixes, improvements and cleanups.
Darrell Ball (8):
сообщение-
От: Darrell Ball [mailto:db...@vmware.com]
Отправлено: 8 февраля 2019 г. 23:29
Кому: Rostyslav Fridman ; Ben Pfaff
Копия: ovs-dev@openvswitch.org; Vasyl Samoilov
Тема: Re: [ovs-dev] SNAT on OVN logical_router in userspace works for ICMP
but not TCP or UDP
I thought the problem was with TCP/UDP traffic ?
Did you send TCP traffic for this test ?; if not, can you run the test with TCP
?
On 2/8/19, 12:53 PM, "Rostyslav Fridman" wrote:
# ovs-appctl dpif/dump-flows br-int
d6cd83d9dd62f0%7C0%7C0%7C636852530531092223sdata=RAl%2Fe3ktUSwxqCIY5BwGL%2Fdylgp59f%2B3vheX3wRr%2FUM%3Dreserved=0
> How are you sending said UDP/TCP packets ?
Curl and telnet requests from the container.
--
Best regards,
Rostyslav Fridman
-Исходное сообщение-
-flows
ovs-appctl dpctl/dump-conntrack
How are you sending said UDP/TCP packets ?
On 2/8/19, 10:15 AM, "ovs-dev-boun...@openvswitch.org on behalf of Ben Pfaff"
wrote:
Darrell, is this something you can help with?
On Fri, Feb 08, 2019 at 02:18:53PM +, Rostyslav F
On Wed, Feb 6, 2019 at 1:22 AM David Marchand
wrote:
> On Mon, Feb 4, 2019 at 6:56 PM Ben Pfaff wrote:
>
>> On Thu, Jan 31, 2019 at 11:35:41PM -0800, Darrell Ball wrote:
>> > The call to inet_ntop() in repl_ftp_v6_addr() is 1 short to handle
>> > the maximum p
will not be in the database as well and overall simplicity.
Accordingly, fragmentation handling is enabled by default.
This patch enables fragmentation tests for the userspace datapath.
Signed-off-by: Darrell Ball
---
Documentation/faq/releases.rst | 49 +-
NEWS | 10
Signed-off-by: Darrell Ball
---
lib/ovs-atomic.h | 36
1 file changed, 36 insertions(+)
diff --git a/lib/ovs-atomic.h b/lib/ovs-atomic.h
index 21e230e..11fa192 100644
--- a/lib/ovs-atomic.h
+++ b/lib/ovs-atomic.h
@@ -479,6 +479,42 @@ atomic_count_set
Use 'must' instead of 'should'.
Suggested-by: Justin Pettit
Signed-off-by: Darrell Ball
---
lib/conntrack.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/conntrack.c b/lib/conntrack.c
index bd5b7a6..b92dee5 100644
--- a/lib/conntrack.c
+++ b/lib/conntrack.c
@@ -1297,7
Acked-by: Justin Pettit
Signed-off-by: Darrell Ball
---
tests/system-traffic.at | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tests/system-traffic.at b/tests/system-traffic.at
index 3a62e17..6e66946 100644
--- a/tests/system-traffic.at
+++ b/tests/system-traffic.at
@@ -2978,6 +2978,7
Acked-by: Justin Pettit
Signed-off-by: Darrell Ball
---
lib/conntrack.c | 4 ++--
lib/flow.c | 44 ++--
lib/flow.h | 3 ++-
3 files changed, 38 insertions(+), 13 deletions(-)
diff --git a/lib/conntrack.c b/lib/conntrack.c
index f732b9e
Acked-by: Justin Pettit
Signed-off-by: Darrell Ball
---
lib/dp-packet.h | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/lib/dp-packet.h b/lib/dp-packet.h
index 7b85dd9..a6e2a4f 100644
--- a/lib/dp-packet.h
+++ b/lib/dp-packet.h
@@ -509,28 +509,28
ough
it be redundant, add for completeness.
v2: Few fixes, improvements and cleanups.
Darrell Ball (6):
dp-packet: Add const qualifiers for checksum apis.
flow: Enhance parse_ipv6_ext_hdrs.
tests: Add missed local stack checks.
conntrack: Reword conntrack_execute() description.
ovs-ato
Thanks very much for the thorough review
sorry; I made the changes last year and then ran into vacation and internal
priorities.
On Tue, Dec 11, 2018 at 8:15 AM Ben Pfaff wrote:
> On Mon, Nov 19, 2018 at 11:09:25AM -0800, Darrell Ball wrote:
> > Fragmentation handling is added for s
Thanks Vishal
Yes, it needs to go back to 2.6; I will be doing some backport patches soon.
Darrell
On 2/1/19, 8:57 PM, "ovs-dev-boun...@openvswitch.org on behalf of Vishal Deep
Ajmera" wrote:
>
> 'conn_key_extract()' in userspace conntrack is including L2
> (
track: New userspace connection tracker.")
CC: Daniele Di Proietto
Co-authored-by: Vishal Deep Ajmera
Co-authored-by: Venkatesan Pradeep
Co-authored-by: Nitin Katiyar
Signed-off-by: Vishal Deep Ajmera
Signed-off-by: Venkatesan Pradeep
Signed-off-by: Nitin Katiyar
Signed-off-by: Da
The new api will be used in a subsequent patch.
Signed-off-by: Darrell Ball
---
v4: Added function header comments to the new and existing APIs (Ben).
v2: Added patch to series.
lib/dp-packet.h | 15 ++-
1 file changed, 14 insertions(+), 1 deletion(-)
diff --git a/lib/dp-packet.h
copy.
Found by inspection.
Signed-off-by: Darrell Ball
---
v4: Use memcpy as safest option (Thanks Ben) in lieu of memset zero and
structure copy; reinstate a couple lines carelessly removed
(Thanks Aaron).
v3: Removed an unnecessary change and limited scope of 2 others.
v2: Found another
On 2/4/19, 12:24 PM, "Ben Pfaff" wrote:
On Mon, Feb 04, 2019 at 07:52:18PM +0000, Darrell Ball wrote:
>
>
> On 2/4/19, 11:15 AM, "ovs-dev-boun...@openvswitch.org on behalf of Ben
Pfaff" wrote:
>
> On Sun, Feb 03, 2019 at 0
On 2/4/19, 11:23 AM, "ovs-dev-boun...@openvswitch.org on behalf of Ben Pfaff"
wrote:
On Mon, Jan 28, 2019 at 10:49:03AM -0800, Darrell Ball wrote:
> The new api will be used in a subsequent patch.
>
> Signed-off-by: Darrell Ball
I think that
On 2/4/19, 11:15 AM, "ovs-dev-boun...@openvswitch.org on behalf of Ben Pfaff"
wrote:
On Sun, Feb 03, 2019 at 02:15:27PM -0800, Darrell Ball wrote:
> There are a few cases where padding may be undefined according to
> the C standard. Practically, it seems imple
On 2/4/19, 8:53 AM, "ovs-dev-boun...@openvswitch.org on behalf of Aaron
Conole" wrote:
Darrell Ball writes:
> There are a few cases where padding may be undefined according to
> the C standard. Practically, it seems implementations don't have issue,
&g
There are a few cases where padding may be undefined according to
the C standard. Practically, it seems implementations don't have issue,
but it is better to be safe. The code paths modified are not hot ones.
Found by inspection.
Signed-off-by: Darrell Ball
---
v3: Removed an unnecessary
There are a few cases where padding may be undefined according to
the C standard. Practically, it seems implementations don't have issue,
but it is better to be safe. The code paths modified are not hot ones.
Found by inspection.
Signed-off-by: Darrell Ball
---
v2: Found another one
There are a few cases where padding may be undefined according to
the C standard. Practically, it seems implementations don't have issue,
but it is better to be safe. The code paths modified are not hot ones.
Found by inspection.
Signed-off-by: Darrell Ball
---
lib/conntrack.c | 12
On Fri, Feb 1, 2019 at 1:07 AM Li,Rongqing wrote:
>
>
> 发件人: Darrell Ball [mailto:dlu...@gmail.com]
> 发送时间: 2019年2月1日 16:15
> 收件人: Li,Rongqing
> 抄送: ovs dev
> 主题: Re: [ovs-dev] [PATCH] conntrack: Remove unnecessary check in
> process_ftp_ctl_v4
>
>
On Fri, Feb 1, 2019 at 12:49 AM Li,Rongqing wrote:
>
>
> 发件人: Darrell Ball [mailto:dlu...@gmail.com]
> 发送时间: 2019年2月1日 16:25
> 收件人: Li,Rongqing
> 抄送: ovs dev
> 主题: Re: [ovs-dev] [PATCH] conntrack: compute hash value once when calling
> conn_key_lookup
>
> >
Thanks for looking
On Fri, Jan 18, 2019 at 1:47 AM Li RongQing wrote:
> it is expensive to compute hash value, and When call conn_lookup,
> hash value is computed twice, in fact, we can cache it and pass
> it to conn_lookup
>
> Signed-off-by: Zhang Yu
> Signed-off-by: Li RongQing
> ---
>
On Fri, Jan 18, 2019 at 1:49 AM Li RongQing wrote:
> It has been assured that both first and second int from ftp
> command are not bigger than 255, so their combination(first
> int << 8 +second int) must not bigger than 65535
>
> Signed-off-by: Wang Li
> Signed-off-by: Li RongQing
> ---
>
The call to inet_ntop() in repl_ftp_v6_addr() is 1 short to handle
the maximum possible V6 address size for v4 mapping case.
Found by inspection.
Fixes: bd5e81a0e596 ("Userspace Datapath: Add ALG infra and FTP.")
Signed-off-by: Darrell Ball
---
v2: s/IPV6_SCAN_LEN/INET6_ADDRSTRLEN/ i
apath: Add ALG infra and FTP.")
Reported-by: David Marchand
Reviewed-by: David Marchand
Signed-off-by: Darrell Ball
---
v5: Added Reported-by and Reviewed-by tags; remove Co-authored-by tag.
v4: Fix bug in call to inet_ntop() in repl_ftp_v4_addr().
v3: Make V4 and V6 code paths more common.
v
fense.
Skynet begins to learn at a geometric rate. It becomes self-aware at 2:14 a.m."
from Terminator 2
"FT-8 became self-aware at ......."
73 Darrell Ab2E
From: Topband on behalf of Anthony Scandurra
via Topband
Sent: Thursday, Janu
Minor comments about the commit message Yifeng
On Thu, Jan 31, 2019 at 3:10 PM Yifeng Sun wrote:
> Test "flow resume with geneve tun_metadata" failed because there is
> no controller running to send controller(pause) message.
The controller receives a 'pause' related to the continuation.
The
501 - 600 of 8947 matches
Mail list logo
