[clang-tools-extra] [clang-tidy] Optimize realpath in readability-identifier-naming (PR #92659)

https://github.com/dmpolukhin approved this pull request. https://github.com/llvm/llvm-project/pull/92659 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Modules] Enable MS Windows test for implicit-module-no-timestamp.cpp (PR #91738)

https://github.com/dmpolukhin approved this pull request. https://github.com/llvm/llvm-project/pull/91738 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Modules] Enable MS Windows test for implicit-module-no-timestamp.cpp (PR #91738)

https://github.com/dmpolukhin reopened https://github.com/llvm/llvm-project/pull/91738 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Modules] Enable MS Windows test for implicit-module-no-timestamp.cpp (PR #91738)

https://github.com/dmpolukhin closed https://github.com/llvm/llvm-project/pull/91738 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Fix Hungarian Prefix in readability-identifier-naming (PR #84236)

https://github.com/dmpolukhin approved this pull request. https://github.com/llvm/llvm-project/pull/84236 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Fix Hungarian Prefix in readability-identifier-naming (PR #84236)

@@ -229,7 +229,8 @@ Changes in existing checks - Improved :doc:`readability-identifier-naming ` check in `GetConfigPerFile` - mode by resolving symbolic links to header files. + mode by resolving symbolic links to header files. Fixed handling of Hungarian

[clang-tools-extra] [clang-tidy] Fix Hungarian Prefix in readability-identifier-naming (PR #84236)

@@ -229,7 +229,8 @@ Changes in existing checks - Improved :doc:`readability-identifier-naming ` check in `GetConfigPerFile` - mode by resolving symbolic links to header files. + mode by resolving symbolic links to header files. Fixed handling of Hungarian

[clang-tools-extra] [clang-tidy] Fix Hungarian Prefix in readability-identifier-naming (PR #84236)

@@ -229,7 +229,8 @@ Changes in existing checks - Improved :doc:`readability-identifier-naming ` check in `GetConfigPerFile` - mode by resolving symbolic links to header files. + mode by resolving symbolic links to header files. Fixed handling of Hungarian

[clang-tools-extra] [clang-tidy] Fix Hungarian Prefix in readability-identifier-naming (PR #84236)

dmpolukhin wrote: I'm not an expert in Hungarian naming but from what I know changes looks good to me. Just nit in release notes. https://github.com/llvm/llvm-project/pull/84236 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang-tools-extra] [clang-tidy][readability-identifier-naming] Resolve symlinks for checking style for file (PR #81985)

https://github.com/dmpolukhin closed https://github.com/llvm/llvm-project/pull/81985 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy][readability-identifier-naming] Resolve symlinks for checking style for file (PR #81985)

https://github.com/dmpolukhin updated https://github.com/llvm/llvm-project/pull/81985 >From ddafb4672e1a481d4a9556ebe31ca9a07e1f3569 Mon Sep 17 00:00:00 2001 From: Dmitry Polukhin Date: Fri, 16 Feb 2024 03:51:07 -0800 Subject: [PATCH 1/3] [clang-tidy][readability-identifier-naming] Resolve

[clang-tools-extra] [clang-tidy][readability-identifier-naming] Resolve symlinks for checking style for file (PR #81985)

https://github.com/dmpolukhin updated https://github.com/llvm/llvm-project/pull/81985 >From ddafb4672e1a481d4a9556ebe31ca9a07e1f3569 Mon Sep 17 00:00:00 2001 From: Dmitry Polukhin Date: Fri, 16 Feb 2024 03:51:07 -0800 Subject: [PATCH 1/3] [clang-tidy][readability-identifier-naming] Resolve

[clang-tools-extra] [clang-tidy][readability-identifier-naming] Resolve symlinks for checking style for file (PR #81985)

dmpolukhin wrote: > This problem seems like it should be handled globally, not in a single > specific check. IIUC any check that reads options from the .clang-tidy file > is affected. Yes, but the majority of checks ignores the problem but `readability-identifier-naming` handles styles per

[clang-tools-extra] [clang-tidy][readability-identifier-naming] Resolve symlinks for checking style for file (PR #81985)

https://github.com/dmpolukhin updated https://github.com/llvm/llvm-project/pull/81985 >From ddafb4672e1a481d4a9556ebe31ca9a07e1f3569 Mon Sep 17 00:00:00 2001 From: Dmitry Polukhin Date: Fri, 16 Feb 2024 03:51:07 -0800 Subject: [PATCH 1/2] [clang-tidy][readability-identifier-naming] Resolve

[clang-tools-extra] [clang-tidy][readability-identifier-naming] Resolve symlinks for checking style for file (PR #81985)

https://github.com/dmpolukhin created https://github.com/llvm/llvm-project/pull/81985 Summary: Some build systems create symlinks in a temporary build directory for headers in the source tree for isolation purposes. These symlinks prevent `readability-identifier-naming` detecting issues and

[clang] [clang] Match -isysroot behaviour with system compiler on Darwin (PR #80524)

dmpolukhin wrote: > So the intent of the current ordering was to allow creating a toolchain by > placing the libc++ headers alongside Clang, as is typically done (and > exceptionally not done on Apple platforms). On Apple platforms, you basically > always specify a sysroot, either explicitly

[clang] [clang] Match -isysroot behaviour with system compiler on Darwin (PR #80524)

dmpolukhin wrote: @ldionne if downstream is catching upstream, I would love to discuss rationale behind ignoring command line option. I asked this question several times and haven't got answer. Original [diff](https://reviews.llvm.org/D89001) that introduced this behavior also didn't explain

[clang] [clang] Match -isysroot behaviour with system compiler on Darwin (PR #80524)

dmpolukhin wrote: @ldionne what about fixing upstream behavior to match actual system compiler behavior now and when/as soon as we have new behavior in Apple compiler fix it again in newer clang versions? Moreover as I pointed out Apple compiler behavior is problematic for clang-tools and

[clang] [clang] Match -isysroot behaviour with system compiler on Darwin (PR #80524)

dmpolukhin wrote: @ldionne I also haven't see Apple compiler that matches upstream behavior. In https://reviews.llvm.org/D157283#4648242, you mentioned that "Xcode 15 RC" should be such compiler and checked it and couple version after that and none of them matched upstream so I decided to

[clang-tools-extra] [clang-apply-replacements] Apply format only if --format is specified (PR #70801)

dmpolukhin wrote: Pushed as https://github.com/llvm/llvm-project/pull/79466 https://github.com/llvm/llvm-project/pull/70801 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-apply-replacements] Apply format only if --format is specified (PR #70801)

https://github.com/dmpolukhin closed https://github.com/llvm/llvm-project/pull/70801 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang-tools-extra] Apply format only if --format is specified (PR #79466)

https://github.com/dmpolukhin closed https://github.com/llvm/llvm-project/pull/79466 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [clang] [clang-tools-extra] Apply format only if --format is specified (PR #79466)

dmpolukhin wrote: @AaronBallman @bcardosolopes please take a look. https://github.com/llvm/llvm-project/pull/79466 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [clang] [clang-tools-extra] Apply format only if --format is specified (PR #79466)

https://github.com/dmpolukhin updated https://github.com/llvm/llvm-project/pull/79466 >From 67a266e7bc5682d5f674c0424858ba86f7c9a192 Mon Sep 17 00:00:00 2001 From: Kugan <34810920+kug...@users.noreply.github.com> Date: Tue, 31 Oct 2023 12:12:10 + Subject: [PATCH] Apply format only if

[clang-tools-extra] Apply format only if --format is specified (PR #79466)

https://github.com/dmpolukhin created https://github.com/llvm/llvm-project/pull/79466 clang-apply-replacements used to apply format even without --format is specified. This because, methods like createReplacementsForHeaders only takes the Spec.Style and would re-order the headers even when it

[clang-tools-extra] [clang-apply-replacements] Apply format only if --format is specified (PR #70801)

dmpolukhin wrote: @kuganv do you have cycles to work on this issue? If not, I can commandeer this pull requests and update release notes. Please let me know what is your preference. https://github.com/llvm/llvm-project/pull/70801 ___ cfe-commits

[clang-tools-extra] [clangd] Expand response files before CDB interpolation (PR #75753)

https://github.com/dmpolukhin updated https://github.com/llvm/llvm-project/pull/75753 >From 957951483dab19b0982a5dbe7d5370bd9061d931 Mon Sep 17 00:00:00 2001 From: Dmitry Polukhin Date: Sun, 17 Dec 2023 14:11:11 -0800 Subject: [PATCH 1/3] [clangd] Expand response files before CDB interpolation

[clang-tools-extra] [clangd] Expand response files before CDB interpolation (PR #75753)

https://github.com/dmpolukhin edited https://github.com/llvm/llvm-project/pull/75753 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] Expand response files before CDB interpolation (PR #75753)

dmpolukhin wrote: @HighCommander4 PTAL https://github.com/llvm/llvm-project/pull/75753 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] Expand response files before CDB interpolation (PR #75753)

https://github.com/dmpolukhin updated https://github.com/llvm/llvm-project/pull/75753 >From 957951483dab19b0982a5dbe7d5370bd9061d931 Mon Sep 17 00:00:00 2001 From: Dmitry Polukhin Date: Sun, 17 Dec 2023 14:11:11 -0800 Subject: [PATCH 1/2] [clangd] Expand response files before CDB interpolation

[clang-tools-extra] [clangd] Expand response files before CDB interpolation (PR #75753)

https://github.com/dmpolukhin created https://github.com/llvm/llvm-project/pull/75753 Summary: After https://reviews.llvm.org/D143436 response files stopped working with CDB interpolation. It has happened because interpolation removes all unknwn flags and extra input files. Response file is

[clang] f24aa69 - [clang] Match -isysroot behaviour with system compiler on Darwin

Author: Dmitry Polukhin Date: 2023-08-23T18:10:18+01:00 New Revision: f24aa691aa4f25291db8f7c61c6e9007288859e7 URL: https://github.com/llvm/llvm-project/commit/f24aa691aa4f25291db8f7c61c6e9007288859e7 DIFF:

[clang] 6d9fcc2 - [clang][clangd] Don't crash/assert on -gsplit-dwarf=single without output

Author: Dmitry Polukhin Date: 2023-07-12T00:57:41-07:00 New Revision: 6d9fcc2ad874e4ee9b94eef4b85ffece18e501b1 URL: https://github.com/llvm/llvm-project/commit/6d9fcc2ad874e4ee9b94eef4b85ffece18e501b1 DIFF:

[clang] d60d345 - [clangd] Move standard options adaptor to CommandMangler

Author: Dmitry Polukhin Date: 2023-03-17T03:10:36-07:00 New Revision: d60d3455eb2b375d026a4aa74c4ba0c38f5d323c URL: https://github.com/llvm/llvm-project/commit/d60d3455eb2b375d026a4aa74c4ba0c38f5d323c DIFF:

[clang] b293c62 - [clang][Lexer] Fix crash/assert clang::HeaderSearch::search_dir_nth

Author: Dmitry Polukhin Date: 2023-03-16T02:19:11-07:00 New Revision: b293c6280d06f49c5ca7290855911341ab0bdffa URL: https://github.com/llvm/llvm-project/commit/b293c6280d06f49c5ca7290855911341ab0bdffa DIFF:

[clang-tools-extra] 2a84c53 - Revert "[clangd] Move standard options adaptor to CommandMangler"

Author: Dmitry Polukhin Date: 2023-03-13T07:00:56-07:00 New Revision: 2a84c53ccdc015a7f53a144aa4f7c0dddf839604 URL: https://github.com/llvm/llvm-project/commit/2a84c53ccdc015a7f53a144aa4f7c0dddf839604 DIFF:

[clang] 34de7da - [clangd] Move standard options adaptor to CommandMangler

Author: Dmitry Polukhin Date: 2023-03-13T06:08:22-07:00 New Revision: 34de7da6246cdfa6ff6f3d3c514583cddc0a10ec URL: https://github.com/llvm/llvm-project/commit/34de7da6246cdfa6ff6f3d3c514583cddc0a10ec DIFF:

[clang-tools-extra] 5d12b13 - [clang-tidy] Dump effective diagnostics level in YAML output

Author: Dmitry Polukhin Date: 2022-10-12T02:03:56-07:00 New Revision: 5d12b13b0b26bc58b02ee23c369da8b83240cceb URL: https://github.com/llvm/llvm-project/commit/5d12b13b0b26bc58b02ee23c369da8b83240cceb DIFF:

[clang] 41dbee1 - [clang] Update ReleaseNotes about a crash fix (Issue 53628)

Author: Dmitry Polukhin Date: 2022-09-20T02:05:36-07:00 New Revision: 41dbee1e66937fe7d579b73d30dc790cd79b8738 URL: https://github.com/llvm/llvm-project/commit/41dbee1e66937fe7d579b73d30dc790cd79b8738 DIFF:

[clang] 133b6d7 - [clang][C++20] Fix clang/clangd assert/crash after compilation errors

Author: Dmitry Polukhin Date: 2022-09-17T07:37:19-07:00 New Revision: 133b6d7db90d9b52b01e8e09e1aa8fb8d2da0f9d URL: https://github.com/llvm/llvm-project/commit/133b6d7db90d9b52b01e8e09e1aa8fb8d2da0f9d DIFF:

[clang] 8eaa05d - [clang] SIGSEGV at DeduceTemplateArgumentsByTypeMatch

Author: Ivan Murashko Date: 2021-07-30T12:40:38+03:00 New Revision: 8eaa05d06161db69e68ff2a5f4c8e3545a4e8080 URL: https://github.com/llvm/llvm-project/commit/8eaa05d06161db69e68ff2a5f4c8e3545a4e8080 DIFF: https://github.com/llvm/llvm-project/commit/8eaa05d06161db69e68ff2a5f4c8e3545a4e8080.diff

[clang] fceaf86 - [clang] Fix UB when string.front() is used for the empty string

Author: Dmitry Polukhin Date: 2021-06-30T01:07:47-07:00 New Revision: fceaf8621179aa758c44f3eaee02d789abfd455b URL: https://github.com/llvm/llvm-project/commit/fceaf8621179aa758c44f3eaee02d789abfd455b DIFF:

[clang-tools-extra] 47d138c - [clang-tidy] LIT test fix for Remark diagnostic

Author: Ivan Murashko Date: 2021-06-11T02:02:36-07:00 New Revision: 47d138c93992f779a5dd0810b0e7402e043df61d URL: https://github.com/llvm/llvm-project/commit/47d138c93992f779a5dd0810b0e7402e043df61d DIFF: https://github.com/llvm/llvm-project/commit/47d138c93992f779a5dd0810b0e7402e043df61d.diff

[clang] aa0d717 - [clang] NFC: test for undefined behaviour in RawComment::getFormattedText()

Author: Dmitry Polukhin Date: 2021-06-07T03:05:00-07:00 New Revision: aa0d7179bbb3fd24bc9eb1fd6203565dbd50e8d8 URL: https://github.com/llvm/llvm-project/commit/aa0d7179bbb3fd24bc9eb1fd6203565dbd50e8d8 DIFF:

[clang] 178ad93 - [clang][clangd] Use reverse header map lookup in suggestPathToFileForDiagnostics

Author: Dmitry Polukhin Date: 2021-06-03T01:37:55-07:00 New Revision: 178ad93e3f1f2381f05baea300873ee5998ac288 URL: https://github.com/llvm/llvm-project/commit/178ad93e3f1f2381f05baea300873ee5998ac288 DIFF:

[clang] 37b530a - [clang] NFC: split HeaderMapTest to have re-usable header map implementation for testing

Author: Dmitry Polukhin Date: 2021-05-31T01:57:36-07:00 New Revision: 37b530a2ea8bdc28a22a3f8ca701455fb7febdea URL: https://github.com/llvm/llvm-project/commit/37b530a2ea8bdc28a22a3f8ca701455fb7febdea DIFF:

[clang-tools-extra] 338d162 - [clang-tidy] Ignore all spaces in the list of checks

Author: Dmitry Polukhin Date: 2021-03-24T06:43:13-07:00 New Revision: 338d16275571df4d841609d7e12bcb310b3a95e6 URL: https://github.com/llvm/llvm-project/commit/338d16275571df4d841609d7e12bcb310b3a95e6 DIFF:

[clang-tools-extra] da55af7 - [clang-tidy] Enable modernize-concat-nested-namespaces also on headers

Author: Dmitry Polukhin Date: 2021-03-15T07:32:45-07:00 New Revision: da55af7f1d348c133774d8e8117d60462363fef5 URL: https://github.com/llvm/llvm-project/commit/da55af7f1d348c133774d8e8117d60462363fef5 DIFF:

[clang-tools-extra] d6a468d - [clang-tidy] adding "--config-file=" to specify custom config file.

Author: Hiral Oza Date: 2020-11-03T11:59:46Z New Revision: d6a468d622b2d48c40c47290aa54d6d910c5a6bf URL: https://github.com/llvm/llvm-project/commit/d6a468d622b2d48c40c47290aa54d6d910c5a6bf DIFF: https://github.com/llvm/llvm-project/commit/d6a468d622b2d48c40c47290aa54d6d910c5a6bf.diff LOG:

[clang-tools-extra] 55a2dee - [clang-tidy] Fix redefinition of module in the same module.modulemap file

Author: Dmitry Polukhin Date: 2020-10-23T13:20:18+01:00 New Revision: 55a2deed075b87646db62abc7bcd476541eda403 URL: https://github.com/llvm/llvm-project/commit/55a2deed075b87646db62abc7bcd476541eda403 DIFF:

[clang] 9e7fddb - [yaml][clang-tidy] Fix multiline YAML serialization

Author: Dmitry Polukhin Date: 2020-07-09T02:41:58-07:00 New Revision: 9e7fddbd36f567217255c1df1cb816b79f0250af URL: https://github.com/llvm/llvm-project/commit/9e7fddbd36f567217255c1df1cb816b79f0250af DIFF:

[clang] c98c94d - [clang-tidy] Add diagnostics level to YAML output

Author: Dmitry Polukhin Date: 2020-06-15T07:40:53-07:00 New Revision: c98c94d85f8591c22f369e8f35142379ba27bb33 URL: https://github.com/llvm/llvm-project/commit/c98c94d85f8591c22f369e8f35142379ba27bb33 DIFF:

[clang] a7afb21 - [clang][AST] Support AST files larger than 512M

Author: Dmitry Polukhin Date: 2020-04-17T06:17:33-07:00 New Revision: a7afb211dc460bd4cfb2542ad1f9b05876b57ba1 URL: https://github.com/llvm/llvm-project/commit/a7afb211dc460bd4cfb2542ad1f9b05876b57ba1 DIFF:

[clang] a8f85da - Revert "[clang][AST] Support AST files larger than 512M"

Author: Dmitry Polukhin Date: 2020-04-16T09:09:38-07:00 New Revision: a8f85da9f538a400dfea00e4954e403bf5f3269c URL: https://github.com/llvm/llvm-project/commit/a8f85da9f538a400dfea00e4954e403bf5f3269c DIFF:

[clang] 30d5946 - [clang][AST] Support AST files larger than 512M

Author: Dmitry Polukhin Date: 2020-04-16T07:27:43-07:00 New Revision: 30d5946db95fa465d7ee6caceb2b1ff191e3727c URL: https://github.com/llvm/llvm-project/commit/30d5946db95fa465d7ee6caceb2b1ff191e3727c DIFF:

[clang-tools-extra] cb1ee34 - [clang-tidy] Optional inheritance of file configs from parent directories 

Author: Dmitry Polukhin Date: 2020-04-15T06:41:31-07:00 New Revision: cb1ee34e9d32fce84613827693a8ed3aff1d36cf URL: https://github.com/llvm/llvm-project/commit/cb1ee34e9d32fce84613827693a8ed3aff1d36cf DIFF:

[clang-tools-extra] 3f8b100 - [clang-tidy] Add library for clang-tidy main function

Author: Dmitry Polukhin Date: 2020-01-24T13:00:45-08:00 New Revision: 3f8b100e94b5c848843fa91c9782d9d4df4bb026 URL: https://github.com/llvm/llvm-project/commit/3f8b100e94b5c848843fa91c9782d9d4df4bb026 DIFF:

[clang-tools-extra] 301a437 - [clang-tidy] Add clang-tidy headers to clang distribution

Author: Dmitry Polukhin Date: 2020-01-23T16:29:08-08:00 New Revision: 301a437250b03de021e6da12a8e4a927ef48881e URL: https://github.com/llvm/llvm-project/commit/301a437250b03de021e6da12a8e4a927ef48881e DIFF:

r305377 - Fix for Itanium mangler issue with templates

Author: dpolukhin Date: Wed Jun 14 04:47:47 2017 New Revision: 305377 URL: http://llvm.org/viewvc/llvm-project?rev=305377=rev Log: Fix for Itanium mangler issue with templates Patch by Serge Preis Differential Revision: https://reviews.llvm.org/D32428 Modified:

[PATCH] D24932: Fix PR 30440

DmitryPolukhin accepted this revision. DmitryPolukhin added a comment. This revision is now accepted and ready to land. I think we need to fix this regression. Repository: rL LLVM https://reviews.llvm.org/D24932 ___ cfe-commits mailing list

Re: [PATCH] D24932: Fix PR 30440

DmitryPolukhin added a comment. LGTM, added Richard in case he has something to add. Repository: rL LLVM https://reviews.llvm.org/D24932 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D24704: PR30401: Fix substitutions for functions with abi_tag

DmitryPolukhin closed this revision. DmitryPolukhin added a comment. Committed as https://reviews.llvm.org/rL282059 https://reviews.llvm.org/D24704 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r282059 - PR30401: Fix substitutions for functions with abi_tag

Author: dpolukhin Date: Wed Sep 21 03:27:03 2016 New Revision: 282059 URL: http://llvm.org/viewvc/llvm-project?rev=282059=rev Log: PR30401: Fix substitutions for functions with abi_tag Modified: cfe/trunk/lib/AST/ItaniumMangle.cpp cfe/trunk/test/CodeGenCXX/mangle-abi-tag.cpp Modified:

Re: [PATCH] D24704: PR30401: Fix substitutions for functions with abi_tag

DmitryPolukhin added a comment. Richard, please take another look. https://reviews.llvm.org/D24704 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D24704: PR30401: Fix substitutions for functions with abi_tag

DmitryPolukhin updated this revision to Diff 71778. DmitryPolukhin marked an inline comment as done. https://reviews.llvm.org/D24704 Files: lib/AST/ItaniumMangle.cpp test/CodeGenCXX/mangle-abi-tag.cpp Index: test/CodeGenCXX/mangle-abi-tag.cpp

Re: [PATCH] D24704: PR30401: Fix substitutions for functions with abi_tag

DmitryPolukhin added inline comments. Comment at: lib/AST/ItaniumMangle.cpp:668 @@ -664,3 +667,3 @@ llvm::raw_svector_ostream FunctionEncodingStream(FunctionEncodingBuf); CXXNameMangler FunctionEncodingMangler(*this, FunctionEncodingStream); // Output name of the

Re: [PATCH] D24704: PR30401: Fix substitutions for functions with abi_tag

DmitryPolukhin added inline comments. Comment at: lib/AST/ItaniumMangle.cpp:668 @@ -664,3 +667,3 @@ llvm::raw_svector_ostream FunctionEncodingStream(FunctionEncodingBuf); CXXNameMangler FunctionEncodingMangler(*this, FunctionEncodingStream); // Output name of the

[PATCH] D24704: PR30401: Fix substitutions for functions with abi_tag

DmitryPolukhin created this revision. DmitryPolukhin added a reviewer: rsmith. DmitryPolukhin added subscribers: cfe-commits, andreybokhanko. Recursive mangling should use all existing substitutions and newly created substitutions should be copied outer mangler. This patch should fix PR30401

r275974 - Fix for failing bot sanitizer-x86_64-linux-fast after r275970

Author: dpolukhin Date: Tue Jul 19 08:35:15 2016 New Revision: 275974 URL: http://llvm.org/viewvc/llvm-project?rev=275974=rev Log: Fix for failing bot sanitizer-x86_64-linux-fast after r275970 More info

Re: [PATCH] D21228: Deprecated (legacy) string literal conversion to 'char *' causes strange overloading resolution

DmitryPolukhin added a subscriber: DmitryPolukhin. DmitryPolukhin closed this revision. DmitryPolukhin added a comment. Committed as https://reviews.llvm.org/rL275970 https://reviews.llvm.org/D21228 ___ cfe-commits mailing list

r275970 - Deprecated (legacy) string literal conversion to 'char *' causes strange overloading resolution

Author: dpolukhin Date: Tue Jul 19 06:29:16 2016 New Revision: 275970 URL: http://llvm.org/viewvc/llvm-project?rev=275970=rev Log: Deprecated (legacy) string literal conversion to 'char *' causes strange overloading resolution It's a patch for PR28050. Seems like overloading resolution wipes

Re: [PATCH] D22034: [MSVC][DLL] use local vftable mangling only exported classes with virtual destructor

DmitryPolukhin added inline comments. Comment at: test/CodeGenCXX/dllimport-rtti.cpp:7 @@ -6,3 +6,1 @@ } s; -// MSVC: [[VF_S:.*]] = private unnamed_addr constant [2 x i8*] -// MSVC-DAG: @"\01??_SS@@6B@" = unnamed_addr alias i8*, getelementptr inbounds ([2 x i8*], [2 x i8*]*

Re: [PATCH] D21970: Add attribute abi_tag to the release notes

DmitryPolukhin added a comment. Hi Hans, it seems that you've just created release branch for 3.9 and this patch should go directly to the branch, right? If so could you please commit this patch for me because I'm working with git-svn and there is no instruction how to work with release LLVM

Re: [PATCH] D22034: [MSVC][DLL] use local vftable mangling only exported classes with virtual destructor

DmitryPolukhin updated this revision to Diff 63950. DmitryPolukhin marked 2 inline comments as done. DmitryPolukhin added a comment. - defer var generation if their type is class with dllimport. http://reviews.llvm.org/D22034 Files: include/clang/AST/DeclCXX.h lib/AST/DeclCXX.cpp

Re: [PATCH] D22034: [MSVC][DLL] use local vftable mangling only exported classes with virtual destructor

DmitryPolukhin added a comment. In http://reviews.llvm.org/D22034#482925, @majnemer wrote: > A flag on CXXRecordDecl which is sensitive to the most recent expression > evaluation might not be the best way to go. > Perhaps we should be able to use the VFTableBuilder to build imported and >

Re: [PATCH] D22034: [MSVC][DLL] use local vftable mangling only exported classes with virtual destructor

DmitryPolukhin updated this revision to Diff 63793. DmitryPolukhin added a comment. Sorry for delay with patch rework, PTAL! - added local vftable for constexpr - added use of imported vftable http://reviews.llvm.org/D22034 Files: include/clang/AST/DeclCXX.h lib/AST/DeclCXX.cpp

Re: [PATCH] D21970: Add attribute abi_tag to the release notes

DmitryPolukhin added a comment. Friendly ping, PTAL! http://reviews.llvm.org/D21970 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D22034: [MSVC][DLL] use local vftable mangling only exported classes with virtual destructor

DmitryPolukhin added a comment. In http://reviews.llvm.org/D22034#475603, @majnemer wrote: > Thinking about this some more, it is possible for clang to emit code that > will make everybody happy: > > If a class is being constructed in a constexpr context and all the vftable > entries it

Re: [PATCH] D22034: [MSVC][DLL] use local vftable mangling only exported classes with virtual destructor

DmitryPolukhin added a comment. In http://reviews.llvm.org/D22034#475551, @majnemer wrote: > In http://reviews.llvm.org/D22034#475540, @DmitryPolukhin wrote: > > > Here is B::foo is not exported but required to build vftable for D. > > > What happens if D also had a virtual destructor? It

Re: [PATCH] D22034: [MSVC][DLL] use local vftable mangling only exported classes with virtual destructor

DmitryPolukhin added a comment. In http://reviews.llvm.org/D22034#475331, @majnemer wrote: > Wait, can you give an example of MSVC exporting a vftable but not all the > virtual methods (other than the deleting destructor)? I don't believe I've > ever come across an example of this. It is

Re: [PATCH] D22034: [MSVC][DLL] use local vftable mangling only exported classes with virtual destructor

DmitryPolukhin added a comment. In http://reviews.llvm.org/D22034#474985, @majnemer wrote: > In http://reviews.llvm.org/D22034#474937, @DmitryPolukhin wrote: > > > David, do you know real programs that relay on constexpr and dllexport > > semantic that doesn't work on MSVC? > > > Yes, Chrome

Re: [PATCH] D22034: [MSVC][DLL] use local vftable mangling only exported classes with virtual destructor

DmitryPolukhin added a comment. I found the patch that prevents using imported vftable, http://llvm.org/viewvc/llvm-project?view=revision=260548 but the patch has no examples of constexpr + dllimport. http://reviews.llvm.org/D22034 ___

Re: [PATCH] D22034: [MSVC][DLL] use local vftable mangling only exported classes with virtual destructor

DmitryPolukhin added a comment. David, do you know real programs that relay on constexpr and dllexport semantic that doesn't work on MSVC? If not, I think we might want to report error message instead of miss-compile it as MSVC does. Anyway current implementation is not compatible with MSVC in

[PATCH] D22034: [MSVC][DLL] use local vftable mangling only exported classes with virtual destructor

DmitryPolukhin created this revision. DmitryPolukhin added a reviewer: rnk. DmitryPolukhin added a subscriber: cfe-commits. MSVC uses non-local mangling for vftable if class with dllexport attribute has no virtual destructor. I checked all examples that I fixed with MSVC and it uses '_7' in all

Re: [PATCH] D18035: [GCC] PR23529 Mangler part of attrbute abi_tag support

DmitryPolukhin added a comment. Richard, thank you for the review! I decided to commit this patch without waiting for GCC response to https://gcc.gnu.org/bugzilla/show_bug.cgi?id=71712 (that is last compatibility issues in comparison with GCC6) so more people could test Clang implementation

r274223 - Fix CodeGenCXX/mangle-abi-tag.cpp on clang-ppc64le-linux bot

Author: dpolukhin Date: Thu Jun 30 06:15:52 2016 New Revision: 274223 URL: http://llvm.org/viewvc/llvm-project?rev=274223=rev Log: Fix CodeGenCXX/mangle-abi-tag.cpp on clang-ppc64le-linux bot Modified: cfe/trunk/test/CodeGenCXX/mangle-abi-tag.cpp Modified:

r274222 - [GCC] PR23529 Mangler part of attrbute abi_tag support

Author: dpolukhin Date: Thu Jun 30 04:40:38 2016 New Revision: 274222 URL: http://llvm.org/viewvc/llvm-project?rev=274222=rev Log: [GCC] PR23529 Mangler part of attrbute abi_tag support Original patch by Stefan Bühler http://reviews.llvm.org/D12834 Difference between original and this one: -

Re: [PATCH] D18035: [GCC] PR23529 Mangler part of attrbute abi_tag support

DmitryPolukhin updated this revision to Diff 62213. DmitryPolukhin marked 2 inline comments as done. DmitryPolukhin added a comment. Use SmallVector instead of SmallSetVector and sort the vector when needed. http://reviews.llvm.org/D18035 Files: lib/AST/ItaniumMangle.cpp

Re: [PATCH] D18035: [GCC] PR23529 Mangler part of attrbute abi_tag support

DmitryPolukhin updated the summary for this revision. DmitryPolukhin updated this revision to Diff 61642. DmitryPolukhin added a comment. Fixed issue with substitution from function name used in bare type encoding and added test. With this patch Clang passes self build with GCC 5.3.1 headers and

Re: [PATCH] D18035: [GCC] PR23529 Mangler part of attrbute abi_tag support

DmitryPolukhin updated this revision to Diff 61352. DmitryPolukhin added a comment. - removed wrong asserts that I used for an experiment http://reviews.llvm.org/D18035 Files: lib/AST/ItaniumMangle.cpp lib/Sema/SemaDeclAttr.cpp test/CodeGenCXX/mangle-abi-tag.cpp test/PCH/attrs.c

Re: [PATCH] D18035: [GCC] PR23529 Mangler part of attrbute abi_tag support

DmitryPolukhin added a comment. In http://reviews.llvm.org/D18035#450258, @rsmith wrote: > Yes, I definitely want us to implement this for GCC compatibility. And now > that we have a specification for this feature, we can evaluate whether this > is doing the right thing. On that basis: > > I

Re: [PATCH] D18035: [GCC] PR23529 Mangler part of attrbute abi_tag support

DmitryPolukhin added a comment. In http://reviews.llvm.org/D18035#447473, @hfinkel wrote: > FYI: There is now a specification, see: > http://sourcerytools.com/pipermail/cxx-abi-dev/2016-June/002919.html For the records, this patch implements GCC 6 abi_tag semantic and to the best of my

r270974 - [MSVC2015] Fix mangling for static variables initialization guards

Author: dpolukhin Date: Fri May 27 03:52:34 2016 New Revision: 270974 URL: http://llvm.org/viewvc/llvm-project?rev=270974=rev Log: [MSVC2015] Fix mangling for static variables initialization guards It seems that suffix '@4HA' was omitted for unknown reason. It is non-cont non-volatile 'int' type

Re: [PATCH] D18641: [PP] Handle #include_next after include found relative to current one same as GCC

DmitryPolukhin abandoned this revision. DmitryPolukhin added a comment. It seems that there is no interest in this patch, abandon. http://reviews.llvm.org/D18641 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D18035: [GCC] PR23529 Mangler part of attrbute abi_tag support

On Thu, May 26, 2016 at 12:41 AM, David Majnemer wrote: > In http://reviews.llvm.org/D18035#434095, @DmitryPolukhin wrote: > > > One more friendly ping.. :( > > I think the best way to make progress on this is to refactor this patch > along the lines @rsmith

r270535 - [MSVC2015] dllexport for defaulted special class members

Author: dpolukhin Date: Tue May 24 01:37:14 2016 New Revision: 270535 URL: http://llvm.org/viewvc/llvm-project?rev=270535=rev Log: [MSVC2015] dllexport for defaulted special class members Clang doesn't dllexport defaulted special member function defaulted inside class but does it if they

Re: [PATCH] D20422: [MSVC2015] dllexport for defaulted special class members

DmitryPolukhin added a comment. PTAL Comment at: lib/Sema/SemaDeclCXX.cpp:13113-13114 @@ -13065,28 +13112,4 @@ -if (MD->isInvalidDecl()) - return; - -switch (Member) { -case CXXDefaultConstructor: - DefineImplicitDefaultConstructor(DefaultLoc, -

Re: [PATCH] D20422: [MSVC2015] dllexport for defaulted special class members

DmitryPolukhin updated this revision to Diff 58088. DmitryPolukhin added a comment. - drop dllexport for trivial defaulted x-tors for compatibility with MSVC2015 - move checks to CheckCompletedCXXClass because completed class definition is required to detect if x-tor is trivial

Re: [PATCH] D18035: [GCC] PR23529 Mangler part of attrbute abi_tag support

DmitryPolukhin updated this revision to Diff 58076. DmitryPolukhin added a comment. Fix test/PCH/attrs.c failure due to warning about unsupported abi_tag attribute (committed in http://reviews.llvm.org/rL269869). This patch implements abi_tag so the warning is not expected with this patch.

Re: [PATCH] D20422: [MSVC2015] dllexport for defaulted special class members

DmitryPolukhin added inline comments. Comment at: lib/Sema/SemaDeclCXX.cpp:13111 @@ -13090,3 +13110,3 @@ llvm_unreachable("Invalid special member."); } } else { rnk wrote: > Can we add `if (InClassDef) ActOnFinishInlineFunctionDef(MD);` here

  1   2   >