https://bugs.kde.org/show_bug.cgi?id=487189
--- Comment #1 from Frank Praznik ---
To note, this works as expected in GNOME, Weston, and Sway, so not likely to be
an SDL bug.
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.kde.org/show_bug.cgi?id=487189
Bug ID: 487189
Summary: Pointer confinement temporarily lost when leaving
fullscreen
Classification: Plasma
Product: kwin
Version: 6.0.4
Platform: Other
OS:
https://bugs.kde.org/show_bug.cgi?id=461063
Frank Praznik changed:
What|Removed |Added
CC||frank.praz...@gmail.com
--- Comment #1 from
vlc | branch: master | Frank Praznik <frank.praz...@gmail.com> | Wed Dec 21
14:04:02 2016 -0500| [4c85645838a12653f270667722f05ff714e648f5] | committer:
Jean-Baptiste Kempf
Use QT file browser functions which return URLs when possible.
The getOpenFileNames() and getSaveFileName() m
> On Nov 15, 2015, at 10:30, Antonio Ospite <a...@ao2.it> wrote:
>
> On Wed, 11 Nov 2015 09:49:36 -0500
> Frank Praznik <frank.praz...@gmail.com> wrote:
>
>> On systems with standby power for charging devices the LEDs and rumble on the
>> controller can co
On systems with standby power for charging devices the LEDs and rumble on the
controller can continue to function even when the system is in standby since
the state is not cleared when the system goes to sleep.
The state on wakeup can also differ from the state when the system entered
standby as
state worker
functions have been replaced with a universal sony_state_worker function which
uses this function pointer.
Signed-off-by: Frank Praznik <frank.praz...@gmail.com>
---
v2: Use a function pointer for selecting the output report function
instead of a series of if/else br
potentially damaging hardware.
USB Sixaxis and navigation controllers must be reinitialized when the hardware
is reset on resume or they won't send any input reports.
Signed-off-by: Frank Praznik <frank.praz...@gmail.com>
---
v2: Add reinitialization for the USB Sixaxis and navigation contr
On 11/9/2015 09:02, Antonio Ospite wrote:
On Sat, 7 Nov 2015 10:12:09 -0500
Frank Praznik <frank.praz...@gmail.com> wrote:
Refactor output report sending functions to allow for the sending of
output reports without enqueing a work item. Output reports for any
On systems with standby power for charging devices the LEDs and rumble on the
controller can continue to function even when the system is in standby since
the state is not cleared when the system goes to sleep.
The state on wakeup can also differ from the state when the system entered
standby as
damaging hardware.
Signed-off-by: Frank Praznik <frank.praz...@gmail.com>
---
drivers/hid/hid-sony.c | 51 +-
1 file changed, 50 insertions(+), 1 deletion(-)
diff --git a/drivers/hid/hid-sony.c b/drivers/hid/hid-sony.c
index b84b2ce..4eff8f7
. The
individual state worker functions have been replaced with a universal
sony_state_worker function which calls sony_send_output_report.
Signed-off-by: Frank Praznik <frank.praz...@gmail.com>
---
drivers/hid/hid-sony.c | 39 ++-
1 file changed, 26 insertions(
the
size check isn't really necessary anyways.
Signed-off-by: Frank Praznik <frank.praz...@gmail.com>
---
This fixes the following bug:
https://bugzilla.kernel.org/show_bug.cgi?id=107081
drivers/hid/hid-sony.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drive
used. Now that we know what it actually does and that 0x80 is
a better choice I support this patch.
Acked-by: Frank Praznik
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.
used. Now that we know what it actually does and that 0x80 is
a better choice I support this patch.
Acked-by: Frank Praznik frank.praz...@gmail.com
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info
used. Now that we know what it actually does and that 0x80 is
a better choice I support this patch.
Acked-by: Frank Praznik frank.praz...@gmail.com
--
To unsubscribe from this list: send the line unsubscribe linux-input in
the body of a message to majord...@vger.kernel.org
More majordomo info
When connected via Bluetooth the sixaxis periodically sends reports with
an ID of 1, the second byte 0xff and the rest zeroed. These reports are
not related to the controller state and must be dropped to avoid generating
false input events.
Signed-off-by: Frank Praznik frank.praz...@oh.rr.com
On 6/8/2015 11:41, si...@mungewell.org wrote:
Hi all,
I'm in the process of fixing the HID descriptor for the PS3 Move
Controller. which has a particularly convoluted layout for it's
Accelormeters, Gyros and Magnetometers involving 2 sets of data per output
report.
This set of patches adds initial support for the Sony Motion Controller via
cleaned-up initial patches from Pavel Machek, streamlines LED initialization
and state updates, adds a comment to explain why the Sixaxis has so many axes
and why they spill over into the multi-touch space and makes some
Rearrange Sony controller devices into alphabetical order in the hardware
device list.
Signed-off-by: Frank Praznik frank.praz...@oh.rr.com
---
drivers/hid/hid-core.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c
index
On 3/16/2015 09:55, Jiri Kosina wrote:
On Mon, 16 Mar 2015, Pavel Machek wrote:
On Mon 2015-03-16 13:55:39, Jiri Kosina wrote:
On Sat, 14 Mar 2015, Pavel Machek wrote:
Hi!
After oopsing kernel with ps/3 peripherals, I decided to play some
more.
First "sony motion controller" (part of ps/3
On 3/16/2015 09:55, Jiri Kosina wrote:
On Mon, 16 Mar 2015, Pavel Machek wrote:
On Mon 2015-03-16 13:55:39, Jiri Kosina wrote:
On Sat, 14 Mar 2015, Pavel Machek wrote:
Hi!
After oopsing kernel with ps/3 peripherals, I decided to play some
more.
First sony motion controller (part of ps/3
On 3/16/2015 09:55, Jiri Kosina wrote:
On Mon, 16 Mar 2015, Pavel Machek wrote:
On Mon 2015-03-16 13:55:39, Jiri Kosina wrote:
On Sat, 14 Mar 2015, Pavel Machek wrote:
Hi!
After oopsing kernel with ps/3 peripherals, I decided to play some
more.
First sony motion controller (part of ps/3
: Coding style cleanups in sixaxis_set_operational_usb()
drivers/hid/hid-sony.c | 21 +++--
1 file changed, 11 insertions(+), 10 deletions(-)
The series looks good to me. Thanks for tackling the last bit of magic
constant cleanup.
For the entire series:
Acked-by: Frank
On 2/16/2015 12:12, Antonio Ospite wrote:
Hi,
here are a few cleanups for hid-sony.
Changes are meant to follow the patch titled:
[PATCHv4] HID: sony: Enable Gasia third-party PS3 controllers
Frank, hi, I'd like to have your explicit ack at least for patch 1 and
2.
Thanks,
Antonio
Hi Brian,
On 11/17/2014 19:00, bri wrote:
Yeah, the device ID in the driver is only for tracking devices internally
and setting sane default LED values. It has no meaning outside of the
module. Like Antonio said, if you want the system number for a controller
you are better off just getting
Hi Brian,
On 11/17/2014 19:00, bri wrote:
Yeah, the device ID in the driver is only for tracking devices internally
and setting sane default LED values. It has no meaning outside of the
module. Like Antonio said, if you want the system number for a controller
you are better off just getting
Hi Brian,
On 11/17/2014 19:00, bri wrote:
Yeah, the device ID in the driver is only for tracking devices internally
and setting sane default LED values. It has no meaning outside of the
module. Like Antonio said, if you want the system number for a controller
you are better off just getting
On Tue, Nov 11, 2014 at 2:04 PM, Dmitry Torokhov
dmitry.torok...@gmail.com wrote:
Hi Frank,
static spinlock_t sony_dev_list_lock;
static LIST_HEAD(sony_device_list);
static DEFINE_IDA(sony_device_id_allocator);
@@ -811,6 +814,7 @@ struct sony_sc {
struct work_struct state_worker;
Replace stack buffers with kernel allocated buffers for sending
and receiving HID reports to prevent issues with DMA transfers
on certain hardware.
Output report buffers are allocated at initialization time to avoid
excessive calls to kmalloc and kfree.
Signed-off-by: Frank Praznik frank.praz
Replace stack buffers with kernel allocated buffers when sending
and receiving HID reports to prevent issues with DMA transfers
on certain hardware.
Output report buffers are allocated at initialization time to avoid
excessive kmalloc and kfree calls.
Signed-off-by: Frank Praznik frank.praz
The DualShock 4 touchpad has been measured to have a resolution of
44.86 dots/mm which equates to 1920x942.
Signed-off-by: Frank Praznik frank.praz...@oh.rr.com
---
drivers/hid/hid-sony.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/hid/hid-sony.c b/drivers/hid
Set the DualShock4 touchpad bits in the input_configured callback
so that they are registered properly for any input devices created
during hid_hw_start.
Signed-off-by: Frank Praznik frank.praz...@oh.rr.com
---
v2: Remove an unnecessary if (ret 0) goto err_stop; check.
This fixes the issue
Set the DualShock4 touchpad bits in the input_configured callback
so that they are registered properly for any input devices created
during hid_hw_start.
Signed-off-by: Frank Praznik frank.praz...@oh.rr.com
---
This fixes the issue with touch axes either not being present or being
incorrectly
Update the file header and correct an outdated comment block.
Signed-off-by: Frank Praznik frank.praz...@oh.rr.com
---
drivers/hid/hid-sony.c | 11 ++-
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/drivers/hid/hid-sony.c b/drivers/hid/hid-sony.c
index 75da56d..96a8ec5
the true controller orientation. Any values beyond
those extents are just noise.
Signed-off-by: Frank Praznik frank.praz...@oh.rr.com
---
drivers/hid/hid-sony.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/hid/hid-sony.c b/drivers/hid/hid-sony.c
the battery level value to set the cable state so that the power status
is reported correctly as that seems to be the only reliable way to determine the
cable status on the Sixaxis.
Signed-off-by: Frank Praznik frank.praz...@oh.rr.com
---
drivers/hid/hid-sony.c | 3 ++-
1 file changed, 2 insertions(+), 1
Previously only the first element of the array was initialized to 1
leading to potential incorrect max brightness values for the LEDs
on the Dualshock 3 and buzzer controllers.
Use a designated initializer to initialize the whole array to the
correct value.
Signed-off-by: Frank Praznik
On 4/22/2014 12:50, si...@mungewell.org wrote:
The joydev device *is* missing the mappings for the touchpad axes for
some reason (JSIOCGAXES returns 14 instead of 17 like it should). I'm
not sure why though. In the Sony driver the touchpad axis bits are set
in the probe function and work
On 4/21/2014 12:49, si...@mungewell.org wrote:
Hi,
I've noticed a glitch with the Dualshock4 on 3.15rc1 (plus LEDs patch, if
that makes a difference).
Sometimes everything works as expected, the thumbsticks work OK and the
touch-pad changes axis 15 16 (as reported by jstest). Other times axis
On 4/21/2014 13:30, Frank Praznik wrote:
On 4/21/2014 12:49, si...@mungewell.org wrote:
Hi,
I've noticed a glitch with the Dualshock4 on 3.15rc1 (plus LEDs
patch, if
that makes a difference).
Sometimes everything works as expected, the thumbsticks work OK and the
touch-pad changes axis 15
Use a struct for the Sixaxis output report that uses named members to set the
report fields.
Signed-off-by: Frank Praznik frank.praz...@oh.rr.com
---
drivers/hid/hid-sony.c | 66 +-
1 file changed, 49 insertions(+), 17 deletions(-)
diff --git
Convert all of the local initialization and shutdown functions to take a
parameter type of struct sony_sc* instead of using a mix of struct sony_sc* and
struct hid_device*.
Allows for the removal of some calls to hid_get_drvdata().
Signed-off-by: Frank Praznik frank.praz...@oh.rr.com
Use the controller Bluetooth MAC address as the unique identifier in the
battery name string instead of the atomic integer that was used before.
Signed-off-by: Frank Praznik frank.praz...@oh.rr.com
---
drivers/hid/hid-sony.c | 8 ++--
1 file changed, 2 insertions(+), 6 deletions(-)
diff
From: Simon Wood si...@mungewell.org
Without this patch the 3rd party INTEC (PS3) controller will blink all
leds when user turns them off, it appears to require an extra flag set.
Signed-off-by: Simon Wood si...@mungewell.org
Signed-off-by: Frank Praznik frank.praz...@oh.rr.com
---
drivers/hid
as per the LED class specifications.
The Sixaxis and Dualshock 4 controllers accept delays in decisecond increments
from 0 to 255 (2550 milliseconds).
The value at index 1 of the DualShock 4 USB output report must be 0xFF or the
light bar won't blink.
Signed-off-by: Frank Praznik frank.praz
the module is unloaded.
Signed-off-by: Frank Praznik frank.praz...@oh.rr.com
---
drivers/hid/hid-sony.c | 119 ++---
1 file changed, 114 insertions(+), 5 deletions(-)
diff --git a/drivers/hid/hid-sony.c b/drivers/hid/hid-sony.c
index c709161..f1649d0 100644
v5 has the following changes:
-Addresses some usability issues with the hardware blink support in the LED
code. The Sixaxis has some odd behavior where, on USB, the controller
overrides user LED settings and blinks the whole light bar until the PS button
is pushed. The new patch doesn't
Use inliners to make sure that the work queue initialization flag is always
checked and set correctly when initializing or cancelling the work queue.
Signed-off-by: Frank Praznik frank.praz...@oh.rr.com
---
drivers/hid/hid-sony.c | 29 +++--
1 file changed, 19 insertions
On 4/9/2014 01:51, si...@mungewell.org wrote:
Unfortunately I was unable to find the 'led chaining' code I mentioned. I
guess it has been lost to the sands of time
3rd Party Intec - Was unable to get any controlled blinking. As
previously
mentioned all leds flash (automatic, as if first
On 4/4/2014 12:11, si...@mungewell.org wrote:
Why not make the triggers/etc apply across the board, so it doesn't matter
which led the command is sent to - it's just registered/copied to the
first (red?) led data[].
Unfortunately, it's not that simple. There is no API for setting
triggers
On 4/4/2014 17:13, si...@mungewell.org wrote:
I see the driver has a special case/function for setting blink with
'sony_led_blink_set()' which could be made to do funky stuff but that
might very rapidly become messy.
These software-only triggers are why I'm thinking it would be good to
have an
Use a struct for the Sixaxis output report that uses named members to set the
report fields.
Signed-off-by: Frank Praznik frank.praz...@oh.rr.com
---
drivers/hid/hid-sony.c | 66 +-
1 file changed, 49 insertions(+), 17 deletions(-)
diff --git
class specifications.
The Sixaxis and Dualshock 4 controllers accept delays in decisecond increments
from 0 to 255 (2550 milliseconds).
The value at index 1 of the DualShock 4 USB output report must be 0xFF or the
light bar won't blink.
Signed-off-by: Frank Praznik frank.praz...@oh.rr.com
Convert all of the local initialization and shutdown functions to take a
parameter type of struct sony_sc* instead of using a mix of struct sony_sc* and
struct hid_device*.
Allows for the removal of some calls to hid_get_drvdata().
Signed-off-by: Frank Praznik frank.praz...@oh.rr.com
v4 of this series has been rebased against jikos/hid.git/for-linus
There was another bit of mismerge code duplication in for-linus that caused
merge conflicts with patches 3 and above in v3 of the series.
The first patch in v4 fixes the mismerge and the remaining patches now apply
cleanly.
Use inliners to make sure that the work queue initialization flag is always
checked and set correctly when initializing or cancelling the work queue.
Signed-off-by: Frank Praznik frank.praz...@oh.rr.com
---
v2 doesn't set worker_initialized to 0 when cancelling work since
cancel_work_sync
Use the controller Bluetooth MAC address as the unique identifier in the
battery name string instead of the atomic integer that was used before.
Signed-off-by: Frank Praznik frank.praz...@oh.rr.com
---
drivers/hid/hid-sony.c | 8 ++--
1 file changed, 2 insertions(+), 6 deletions(-)
diff
Remove redundant cancel_work_sync() call caused by mismerge.
Signed-off-by: Frank Praznik frank.praz...@oh.rr.com
---
Apply against jikos/hid.git/for-linus to fix mismerge code duplication
drivers/hid/hid-sony.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/hid/hid-sony.c b
the module is unloaded.
Signed-off-by: Frank Praznik frank.praz...@oh.rr.com
---
drivers/hid/hid-sony.c | 117 +++--
1 file changed, 114 insertions(+), 3 deletions(-)
diff --git a/drivers/hid/hid-sony.c b/drivers/hid/hid-sony.c
index c709161..f26f8fa 100644
On Sat, Mar 15, 2014 at 9:41 AM, Frank Praznik frank.praz...@oh.rr.com wrote:
Just a couple of small changes in v3:
Patch 6 was changed to use the controller Bluetooth MAC address as the unique
value for the battery name string.
The IDA code was moved from patch 6 to 7 since it was no longer
Use the controller Bluetooth MAC address as the unique identifier in the
battery name string instead of the atomic integer that was used before.
Signed-off-by: Frank Praznik frank.praz...@oh.rr.com
---
v3 moves the IDA code to patch 7 since it isn't needed here anymore.
drivers/hid/hid-sony.c
the module is unloaded.
Signed-off-by: Frank Praznik frank.praz...@oh.rr.com
---
v3 moves the IDA code from patch 6 to here since the previous patch no longer
needs it. It's exactly the same otherwise.
drivers/hid/hid-sony.c | 117 +++--
1 file changed
Use inliners to make sure that the work queue initialization flag is always
checked and set correctly when initializing or cancelling the work queue.
Signed-off-by: Frank Praznik frank.praz...@oh.rr.com
---
v2 doesn't set worker_initialized to 0 when cancelling work since
cancel_work_sync
Byte 31 of the Sixaxis report can change depending on whether or not the
controller is rumbling. Using bit 3 is the only reliable way to detect the
state of the cable regardless of rumble activity.
Signed-off-by: Frank Praznik frank.praz...@oh.rr.com
---
drivers/hid/hid-sony.c | 2 +-
1 file
class specifications.
The Sixaxis and Dualshock 4 controllers accept delays in decisecond increments
from 0 to 255 (2550 milliseconds).
The value at index 1 of the DualShock 4 USB output report must be 0xFF or the
light bar won't blink.
Signed-off-by: Frank Praznik frank.praz...@oh.rr.com
The Sixaxis and DualShock 4 want HID output reports sent on the control
endpoint when connected via Bluetooth. Set the
HID_QUIRK_NO_OUTPUT_REPORTS_ON_INTR_EP flag for these devices so hidraw write()
works properly.
Signed-off-by: Frank Praznik frank.praz...@oh.rr.com
---
drivers/hid/hid-sony.c
Use a struct for the Sixaxis output report that uses named members to set the
report fields.
Signed-off-by: Frank Praznik frank.praz...@oh.rr.com
---
drivers/hid/hid-sony.c | 66 +-
1 file changed, 49 insertions(+), 17 deletions(-)
diff --git
Just a couple of small changes in v3:
Patch 6 was changed to use the controller Bluetooth MAC address as the unique
value for the battery name string.
The IDA code was moved from patch 6 to 7 since it was no longer needed in
patch 6. It's the same otherwise.
--
To unsubscribe from this list:
Convert all of the local initialization and shutdown functions to take a
parameter type of struct sony_sc* instead of using a mix of struct sony_sc* and
struct hid_device*.
Allows for the removal of some calls to hid_get_drvdata().
Signed-off-by: Frank Praznik frank.praz...@oh.rr.com
On 3/10/2014 18:59, Antonio Ospite wrote:
On Thu, 6 Mar 2014 17:32:55 -0500
Frank Praznikfrank.praz...@oh.rr.com wrote:
Use the device ID to initialize the Sixaxis and DualShock 4 controller LEDs to
default values. The number or color of the controller is set relative to other
connected
On 3/10/2014 18:25, Antonio Ospite wrote:
Hi Frank,
On Thu, 6 Mar 2014 17:32:54 -0500
Frank Praznik frank.praz...@oh.rr.com wrote:
Add an IDA id allocator to assign unique, sequential device ids to Sixaxis and
DualShock 4 controllers.
Use explicit module init and exit functions since
identification string.
Signed-off-by: Frank Praznik frank.praz...@oh.rr.com
---
drivers/hid/hid-sony.c | 70 +-
1 file changed, 63 insertions(+), 7 deletions(-)
diff --git a/drivers/hid/hid-sony.c b/drivers/hid/hid-sony.c
index a9bcfbe..13af58c 100644
Byte 31 of the Sixaxis report can change depending on whether or not the
controller is rumbling. Using bit 3 is the only reliable way to detect the
state of the cable regardless of rumble activity.
Signed-off-by: Frank Praznik frank.praz...@oh.rr.com
---
drivers/hid/hid-sony.c | 2 +-
1 file
v2 rebases the previous set of patches against Benjamin Tissoires' latest patch
set and adds some additional changes:
- Adds a patch setting the new HID_QUIRK_NO_OUTPUT_REPORTS_ON_INTR_EP for the
Sixaxis and DualShock 4 when they are connected via Bluetooth. This adds
support for sending
The Sixaxis and DualShock 4 want HID output reports sent on the control
endpoint when connected via Bluetooth. Set the
HID_QUIRK_NO_OUTPUT_REPORTS_ON_INTR_EP flag for these devices so hidraw write()
works properly.
Signed-off-by: Frank Praznik frank.praz...@oh.rr.com
---
drivers/hid/hid-sony.c
Use inliners to make sure that the work queue initialization flag is always
checked and set correctly when initializing or cancelling the work queue.
Signed-off-by: Frank Praznik frank.praz...@oh.rr.com
---
v2 doesn't set worker_initialized to 0 when cancelling work sync since
cancel_work_sync
class specifications.
The Sixaxis and Dualshock 4 controllers accept delays in decisecond increments
from 0 to 255 (2550 milliseconds).
The value at index 1 of the DualShock 4 USB output report must be 0xFF or the
light bar won't blink.
Signed-off-by: Frank Praznik frank.praz...@oh.rr.com
---
v2
Convert all of the local initialization and shutdown functions to take a
parameter type of struct sony_sc* instead of using a mix of struct sony_sc* and
struct hid_device*.
Allows for the removal of some calls to hid_get_drvdata().
Signed-off-by: Frank Praznik frank.praz...@oh.rr.com
led_classdev_register so that the correct brightness
value
shows up in the LED sysfs entry.
Signed-off-by: Frank Praznik frank.praz...@oh.rr.com
---
v2 uses the id assigned by the IDA allocator to set the default values.
drivers/hid/hid-sony.c | 57
On 3/4/2014 07:34, Antonio Ospite wrote:
This can be done in the driver. See
https://www.mail-archive.com/linux-input@vger.kernel.org/msg08103.html
xpad is a joystick driver, while hid-sony is a HID driver.
I tried it and the hack works from HID space with some tweaking, but,
yeah, it's a
On 3/1/2014 08:53, Antonio Ospite wrote:
Hi Frank,
On Fri, 28 Feb 2014 22:58:55 -0500
Frank Praznik frank.praz...@oh.rr.com wrote:
This set consists of one bugfix, two mostly cosmetic changes and three larger
patches for the LED subsystem.
Patch #4 adds hardware blink support
On 3/1/2014 09:20, Antonio Ospite wrote:
Hi Frank,
On Fri, 28 Feb 2014 22:58:59 -0500
Frank Praznik frank.praz...@oh.rr.com wrote:
Add support for setting the blink rate of the LEDs. The Sixaxis allows control
over each individual LED, but the Dualshock 4 only has one global control
On 2/28/2014 22:59, Frank Praznik wrote:
Creates an LED trigger that changes LED behavior depending on the state of the
controller battery.
The trigger function runs on a 500 millisecond timer and only updates the LEDs
if the controller power state has changed or a new device has been added
Convert all of the initialization and shutdown functions to take a parameter
type of struct sony_sc instead of using a mix of struct sony_sc and
struct hid_device.
sony_set_leds() was converted as well as it was just pulling the sony_sc
struct out of the hid_device.
Signed-off-by: Frank Praznik
Use inliners to make sure that the work queue initialization flags are always
checked and set correctly when initializing or cancelling the work queue.
Signed-off-by: Frank Praznik frank.praz...@oh.rr.com
---
drivers/hid/hid-sony.c | 31 +--
1 file changed, 21
This set consists of one bugfix, two mostly cosmetic changes and three larger
patches for the LED subsystem.
Patch #4 adds hardware blink support to the controller LEDs. Values from 0 to
2.5 seconds are supported by the hardware. The Sixaxis can set all of the LEDs
individually, but the
Byte 31 of the Sixaxis report can change depending on whether or not the
controller is rumbling. Using bit 3 is the only reliable way to detect the
state of the cable regardless of rumble activity.
Signed-off-by: Frank Praznik frank.praz...@oh.rr.com
---
drivers/hid/hid-sony.c | 2 +-
1 file
Initialize the controller LEDs to a default value that isn't all-off so that
there is some visible indicator that the controller is powered on and
connected.
On the Sixaxis LED number 1 is turned on.
One the DualShock 4 the light bar is set to blue at the lowest brightness.
Signed-off-by: Frank
specifications.
The Sixaxis and Dualshock 4 controllers accept delays in decisecond increments
from 0 to 255 (2550 milliseconds).
Signed-off-by: Frank Praznik frank.praz...@oh.rr.com
---
drivers/hid/hid-sony.c | 105 +++--
1 file changed, 93 insertions(+), 12
in and charging it blinks the LEDs in 1 second intervals.
The order of subsystem initialization had to be changed in sony_probe() so that
the trigger is created before the LEDs are initialized.
By default the controller LEDs are set to the trigger local to that controller.
Signed-off-by: Frank Praznik
On Wed, Feb 19, 2014 at 1:41 PM, David Herrmann dh.herrm...@gmail.com wrote:
Hi Frank
On Wed, Feb 19, 2014 at 7:09 PM, Frank Praznik frank.praz...@oh.rr.com
wrote:
Don't initialize force-feedback for devices that don't support it to avoid
calls
to schedule_work() with an uninitialized
sony_destroy_ff() to avoid a compiler warning since it is no longer used.
Signed-off-by: Frank Praznik frank.praz...@oh.rr.com
---
This is a bugfix for 3.14.
drivers/hid/hid-sony.c | 27 ---
1 file changed, 12 insertions(+), 15 deletions(-)
diff --git a/drivers/hid/hid-sony.c b
used.
Signed-off-by: Frank Praznik frank.praz...@oh.rr.com
---
drivers/hid/hid-sony.c | 21 +++--
1 file changed, 7 insertions(+), 14 deletions(-)
diff --git a/drivers/hid/hid-sony.c b/drivers/hid/hid-sony.c
index 81917eb..ad1cebd 100644
--- a/drivers/hid/hid-sony.c
+++ b/drivers
The battery_charging and cable_state flags were backwards on the Sixaxis.
The low bit of report byte 30 is 0 when charging and 1 when not.
Bit 5 of byte 31 is 0 when a USB cable is connected and 1 when not.
Signed-off-by: Frank Praznik frank.praz...@oh.rr.com
---
drivers/hid/hid-sony.c | 4
Add formating for the Dualshock 4 output report data in Bluetooth mode.
In Bluetooth mode the Dualshock 4 wants output reports sent on the control
channel.
Signed-off-by: Frank Praznik frank.praz...@oh.rr.com
---
v3 uses the inline hid_hw_raw_request inline function
drivers/hid/hid-sony.c
have to be moved to
report 17 to let the HID driver properly process the incoming reports.
Signed-off-by: Frank Praznik frank.praz...@oh.rr.com
---
drivers/hid/hid-sony.c | 214 +
1 file changed, 214 insertions(+)
diff --git a/drivers/hid/hid-sony.c b
On Mon, Feb 3, 2014 at 11:24 AM, David Herrmann dh.herrm...@gmail.com wrote:
Hi
On Sat, Feb 1, 2014 at 5:28 PM, Benjamin Tissoires
benjamin.tissoi...@gmail.com wrote:
On Sat, Feb 1, 2014 at 11:06 AM, Frank Praznik frank.praz...@gmail.com
wrote:
On 1/31/2014 15:45, Benjamin Tissoires wrote
On Mon, Feb 3, 2014 at 1:06 PM, David Herrmann dh.herrm...@gmail.com wrote:
Hi
On Mon, Feb 3, 2014 at 6:57 PM, Dmitry Torokhov
dmitry.torok...@gmail.com wrote:
On Mon, Feb 03, 2014 at 06:45:52PM +0100, David Herrmann wrote:
Hi
Adding Dmitry+Jiri, maybe they can clarify this.
[snip]
Add the client_addr member to the hid_device struct for storing the client
address of a connected device.
Signed-off-by: Frank Praznik frank.praz...@oh.rr.com
---
include/linux/hid.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/linux/hid.h b/include/linux/hid.h
index 31b9d29
1 - 100 of 146 matches
Mail list logo
