On Fri, Sep 1, 2023 at 5:13 PM Gil Dekel wrote:
>
> On Fri, Sep 1, 2023 at 2:55 PM Rodrigo Vivi wrote:
> >
> > On Thu, Aug 24, 2023 at 04:50:20PM -0400, Gil Dekel wrote:
> > > Before sending a uevent to userspace in order to trigger a corrective
> > > modese
On Fri, Sep 1, 2023 at 5:13 PM Gil Dekel wrote:
>
> On Fri, Sep 1, 2023 at 2:55 PM Rodrigo Vivi wrote:
> >
> > On Thu, Aug 24, 2023 at 04:50:20PM -0400, Gil Dekel wrote:
> > > Before sending a uevent to userspace in order to trigger a corrective
> > > modese
On Fri, Sep 1, 2023 at 2:57 PM Rodrigo Vivi wrote:
>
> On Thu, Aug 24, 2023 at 04:50:16PM -0400, Gil Dekel wrote:
> > Instead of silently giving up when all link-training fallback values are
> > exhausted, this patch modifies the fallback's failure branch to reduces
> >
On Fri, Sep 1, 2023 at 2:57 PM Rodrigo Vivi wrote:
>
> On Thu, Aug 24, 2023 at 04:50:16PM -0400, Gil Dekel wrote:
> > Instead of silently giving up when all link-training fallback values are
> > exhausted, this patch modifies the fallback's failure branch to reduces
> >
On Fri, Sep 1, 2023 at 2:55 PM Rodrigo Vivi wrote:
>
> On Thu, Aug 24, 2023 at 04:50:20PM -0400, Gil Dekel wrote:
> > Before sending a uevent to userspace in order to trigger a corrective
> > modeset, we change the failing connector's link-status to BAD. However,
> > t
On Fri, Sep 1, 2023 at 2:55 PM Rodrigo Vivi wrote:
>
> On Thu, Aug 24, 2023 at 04:50:20PM -0400, Gil Dekel wrote:
> > Before sending a uevent to userspace in order to trigger a corrective
> > modeset, we change the failing connector's link-status to BAD. However,
> > t
iewing it), since it adds some
> > > things to the helpers that might end up being useful here :)
> > >
> > > https://patchwork.freedesktop.org/series/122589/
> > >
Do you have anything particular in mind?
> > > On Thu, 2023-08-24 at 16:50 -0400, Gil Dekel wrote:
iewing it), since it adds some
> > > things to the helpers that might end up being useful here :)
> > >
> > > https://patchwork.freedesktop.org/series/122589/
> > >
Do you have anything particular in mind?
> > > On Thu, 2023-08-24 at 16:50 -0400, Gil Dekel wrote:
When a link-training attempt fails, emit a uevent to user space that
includes the trigger property, which in this case will be
link-statue=Bad.
This will allow userspace to parse the uevent property and better
understand the reason for the previous modeset failure.
Signed-off-by: Gil Dekel
V2
() to rectify this and set all
downstream MST connectors' link-status to BAD before emitting the uevent
to userspace.
Signed-off-by: Gil Dekel
---
drivers/gpu/drm/i915/display/intel_dp.c | 16 ++--
1 file changed, 10 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/i915/display
When a link-training attempt fails, emit a uevent to user space that
includes the trigger property, which in this case will be
link-statue=Bad.
This will allow userspace to parse the uevent property and better
understand the reason for the previous modeset failure.
Signed-off-by: Gil Dekel
V2
simpler. This patch does exactly that, and updates all
modeset_retry_work dependencies to use an intel_dp instead.
Credit: this patch is a rebase of Lyude Pual's original patch:
https://patchwork.freedesktop.org/patch/216627/?series=41576=3
Signed-off-by: Gil Dekel
---
drivers/gpu/drm/i915
simpler. This patch does exactly that, and updates all
modeset_retry_work dependencies to use an intel_dp instead.
Credit: this patch is a rebase of Lyude Pual's original patch:
https://patchwork.freedesktop.org/patch/216627/?series=41576=3
Signed-off-by: Gil Dekel
---
drivers/gpu/drm/i915
() to rectify this and set all
downstream MST connectors' link-status to BAD before emitting the uevent
to userspace.
Signed-off-by: Gil Dekel
---
drivers/gpu/drm/i915/display/intel_dp.c | 16 ++--
1 file changed, 10 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/i915/display
...@redhat.com/
Signed-off-by: Gil Dekel
---
drivers/gpu/drm/display/drm_dp_mst_topology.c | 39 +++
include/drm/display/drm_dp_mst_helper.h | 3 ++
2 files changed, 42 insertions(+)
diff --git a/drivers/gpu/drm/display/drm_dp_mst_topology.c
b/drivers/gpu/drm/display
...@redhat.com/
Signed-off-by: Gil Dekel
---
drivers/gpu/drm/display/drm_dp_mst_topology.c | 39 +++
include/drm/display/drm_dp_mst_helper.h | 3 ++
2 files changed, 42 insertions(+)
diff --git a/drivers/gpu/drm/display/drm_dp_mst_topology.c
b/drivers/gpu/drm/display
out both
max_link_rate and max_link_lane_count. In addition, it stops resetting
MST params so the zeroing of the HBR fields stick. This ensures that
the MST base connector's modes will be completely pruned, since it is
effectively left with 0Gbps bandwidth.
Signed-off-by: Gil Dekel
---
drivers/gpu
out both
max_link_rate and max_link_lane_count. In addition, it stops resetting
MST params so the zeroing of the HBR fields stick. This ensures that
the MST base connector's modes will be completely pruned, since it is
effectively left with 0Gbps bandwidth.
Signed-off-by: Gil Dekel
---
drivers/gpu
the failing connector, which is in
link-status=Bad, has all its modes pruned (due to effectively having a
bandwidth of 0Gbps).
It is then the userspace's responsibility to ignore connectors with no
modes, even if they are marked as connected.
Signed-off-by: Gil Dekel
---
drivers/gpu/drm/i915
the failing connector, which is in
link-status=Bad, has all its modes pruned (due to effectively having a
bandwidth of 0Gbps).
It is then the userspace's responsibility to ignore connectors with no
modes, even if they are marked as connected.
Signed-off-by: Gil Dekel
---
drivers/gpu/drm/i915
splays stop showing up once the
connectors are pruned of all their modes and are ignored by userspace.
For your consideration and guidance.
Thanks,
Gil Dekel (6):
drm/i915/dp_link_training: Add a final failing state to link training
fallback
drm/i915/dp_link_training: Add a final failing s
splays stop showing up once the
connectors are pruned of all their modes and are ignored by userspace.
For your consideration and guidance.
Thanks,
Gil Dekel (6):
drm/i915/dp_link_training: Add a final failing state to link training
fallback
drm/i915/dp_link_training: Add a final failing s
: I6170e2755121adf04621ae4fff06985bf4b26d3a
Signed-off-by: Gil Dekel
---
drivers/gpu/drm/i915/display/intel_dp.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/display/intel_dp.c
b/drivers/gpu/drm/i915/display/intel_dp.c
index 71f54e56c4434..f45c3bab743cc 100644
() to rectify this and set all
downstream MST connectors' link-status to BAD before emitting the uevent
to userspace.
Change-Id: Iaae8f0b12b8bce4b16ecad63063c04d3c8ec93a8
Signed-off-by: Gil Dekel
---
drivers/gpu/drm/i915/display/intel_dp.c | 16 ++--
1 file changed, 10 insertions(+), 6
: I6170e2755121adf04621ae4fff06985bf4b26d3a
Signed-off-by: Gil Dekel
---
drivers/gpu/drm/i915/display/intel_dp.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/display/intel_dp.c
b/drivers/gpu/drm/i915/display/intel_dp.c
index 71f54e56c4434..f45c3bab743cc 100644
Signed-off-by: Gil Dekel
---
drivers/gpu/drm/i915/display/intel_display.c | 14 +++---
drivers/gpu/drm/i915/display/intel_display_types.h | 6 +++---
drivers/gpu/drm/i915/display/intel_dp.c| 11 ---
.../gpu/drm/i915/display/intel_dp_link_training.c | 3 +--
4 files
() to rectify this and set all
downstream MST connectors' link-status to BAD before emitting the uevent
to userspace.
Change-Id: Iaae8f0b12b8bce4b16ecad63063c04d3c8ec93a8
Signed-off-by: Gil Dekel
---
drivers/gpu/drm/i915/display/intel_dp.c | 16 ++--
1 file changed, 10 insertions(+), 6
Signed-off-by: Gil Dekel
---
drivers/gpu/drm/i915/display/intel_display.c | 14 +++---
drivers/gpu/drm/i915/display/intel_display_types.h | 6 +++---
drivers/gpu/drm/i915/display/intel_dp.c| 11 ---
.../gpu/drm/i915/display/intel_dp_link_training.c | 3 +--
4 files
...@redhat.com/
Change-Id: I42ca477f61e57d23b67e168b0f306c7c1f29
Signed-off-by: Gil Dekel
---
drivers/gpu/drm/display/drm_dp_mst_topology.c | 38 +++
include/drm/display/drm_dp_mst_helper.h | 3 ++
2 files changed, 41 insertions(+)
diff --git a/drivers/gpu/drm/display
...@redhat.com/
Change-Id: I42ca477f61e57d23b67e168b0f306c7c1f29
Signed-off-by: Gil Dekel
---
drivers/gpu/drm/display/drm_dp_mst_topology.c | 38 +++
include/drm/display/drm_dp_mst_helper.h | 3 ++
2 files changed, 41 insertions(+)
diff --git a/drivers/gpu/drm/display
: Id5de137d0ce4e1ad34e137733a73a1ebbc5b94e5
Signed-off-by: Gil Dekel
---
drivers/gpu/drm/i915/display/intel_dp.c | 27 ++-
drivers/gpu/drm/i915/display/intel_dp.h | 4 +--
.../drm/i915/display/intel_dp_link_training.c | 8 +++---
3 files changed, 21 insertions(+), 18 deletions(-)
diff --git a/drivers
: Id5de137d0ce4e1ad34e137733a73a1ebbc5b94e5
Signed-off-by: Gil Dekel
---
drivers/gpu/drm/i915/display/intel_dp.c | 27 ++-
drivers/gpu/drm/i915/display/intel_dp.h | 4 +--
.../drm/i915/display/intel_dp_link_training.c | 8 +++---
3 files changed, 21 insertions(+), 18 deletions(-)
diff --git a/drivers
Signed-off-by: Gil Dekel
---
drivers/gpu/drm/i915/display/intel_dp.c | 18 --
1 file changed, 16 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_dp.c
b/drivers/gpu/drm/i915/display/intel_dp.c
index 49a34298b1834..2b8d2ee08a2b2 100644
--- a/drivers/gpu
Signed-off-by: Gil Dekel
---
drivers/gpu/drm/i915/display/intel_dp.c | 18 --
1 file changed, 16 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_dp.c
b/drivers/gpu/drm/i915/display/intel_dp.c
index 49a34298b1834..2b8d2ee08a2b2 100644
--- a/drivers/gpu
onnectors as disconnected as well.
As a final note I should add that this approach was tested with ChromeOS as
userspace, and we observed that the zombie displays stop showing up once the
connectors are pruned of all their modes and are ignored by userspace.
For your consideration and guidance.
Than
onnectors as disconnected as well.
As a final note I should add that this approach was tested with ChromeOS as
userspace, and we observed that the zombie displays stop showing up once the
connectors are pruned of all their modes and are ignored by userspace.
For your consideration and guidance.
Than
When a link-training attempt fails, emit a uevent to user space that
includes the trigger property, which in this case will be
link-statue=Bad.
This will allow userspace to parse the uevent property and better
understand the reason for the previous modeset failure.
Signed-off-by: Gil Dekel
V2
When a link-training attempt fails, emit a uevent to user space that
includes the trigger property, which in this case will be
link-statue=Bad.
This will allow userspace to parse the uevent property and better
understand the reason for the previous modeset failure.
Signed-off-by: Gil Dekel
V2
() to rectify this and set all
downstream MST connectors' link-status to BAD before emitting the uevent
to userspace.
Signed-off-by: Gil Dekel
---
drivers/gpu/drm/i915/display/intel_dp.c | 16 ++--
1 file changed, 10 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/i915/display
() to rectify this and set all
downstream MST connectors' link-status to BAD before emitting the uevent
to userspace.
Signed-off-by: Gil Dekel
---
drivers/gpu/drm/i915/display/intel_dp.c | 16 ++--
1 file changed, 10 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/i915/display
simpler. This patch does exactly that, and updates all
modeset_retry_work dependencies to use an intel_dp instead.
Credit: this patch is a rebase of Lyude Pual's original patch:
https://patchwork.freedesktop.org/patch/216627/?series=41576=3
Signed-off-by: Gil Dekel
---
drivers/gpu/drm/i915
simpler. This patch does exactly that, and updates all
modeset_retry_work dependencies to use an intel_dp instead.
Credit: this patch is a rebase of Lyude Pual's original patch:
https://patchwork.freedesktop.org/patch/216627/?series=41576=3
Signed-off-by: Gil Dekel
---
drivers/gpu/drm/i915
...@redhat.com/
Signed-off-by: Gil Dekel
---
drivers/gpu/drm/display/drm_dp_mst_topology.c | 39 +++
include/drm/display/drm_dp_mst_helper.h | 3 ++
2 files changed, 42 insertions(+)
diff --git a/drivers/gpu/drm/display/drm_dp_mst_topology.c
b/drivers/gpu/drm/display
...@redhat.com/
Signed-off-by: Gil Dekel
---
drivers/gpu/drm/display/drm_dp_mst_topology.c | 39 +++
include/drm/display/drm_dp_mst_helper.h | 3 ++
2 files changed, 42 insertions(+)
diff --git a/drivers/gpu/drm/display/drm_dp_mst_topology.c
b/drivers/gpu/drm/display
out both
max_link_rate and max_link_lane_count. In addition, it stops resetting
MST params so the zeroing of the HBR fields stick. This ensures that
the MST base connector's modes will be completely pruned, since it is
effectively left with 0Gbps bandwidth.
Signed-off-by: Gil Dekel
---
drivers/gpu
out both
max_link_rate and max_link_lane_count. In addition, it stops resetting
MST params so the zeroing of the HBR fields stick. This ensures that
the MST base connector's modes will be completely pruned, since it is
effectively left with 0Gbps bandwidth.
Signed-off-by: Gil Dekel
---
drivers/gpu
the failing connector, which is in
link-status=Bad, has all its modes pruned (due to effectively having a
bandwidth of 0Gbps).
It is then the userspace's responsibility to ignore connectors with no
modes, even if they are marked as connected.
Signed-off-by: Gil Dekel
---
drivers/gpu/drm/i915
the failing connector, which is in
link-status=Bad, has all its modes pruned (due to effectively having a
bandwidth of 0Gbps).
It is then the userspace's responsibility to ignore connectors with no
modes, even if they are marked as connected.
Signed-off-by: Gil Dekel
---
drivers/gpu/drm/i915
link-status for downstream MST ports.
5) Emit a uevent with the "link-status" trigger property.
Gil Dekel (6):
drm/i915/dp_link_training: Add a final failing state to link training
fallback
drm/i915/dp_link_training: Add a final failing state to link training
fallback for
link-status for downstream MST ports.
5) Emit a uevent with the "link-status" trigger property.
Gil Dekel (6):
drm/i915/dp_link_training: Add a final failing state to link training
fallback
drm/i915/dp_link_training: Add a final failing state to link training
fallback for
Cc: Manasi Navare
Cc: Sean Paul
Signed-off-by: Gil Dekel
---
drivers/gpu/drm/i915/display/intel_dp.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/display/intel_dp.c
b/drivers/gpu/drm/i915/display/intel_dp.c
index aee3845edd2d..772979f163df 100644
Cc: Manasi Navare
Cc: Sean Paul
Signed-off-by: Gil Dekel
---
drivers/gpu/drm/i915/display/intel_dp.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/display/intel_dp.c
b/drivers/gpu/drm/i915/display/intel_dp.c
index aee3845edd2d..772979f163df 100644
pruned, since it is effectively left with 0Gbps bandwidth.
Once again, it is the userspace's responsibility to ignore connectors
with no modes, even if they are marked as connected.
Cc: Jani Nikula
Cc: Manasi Navare
Cc: Sean Paul
Signed-off-by: Gil Dekel
---
drivers/gpu/drm/i915/display
pruned, since it is effectively left with 0Gbps bandwidth.
Once again, it is the userspace's responsibility to ignore connectors
with no modes, even if they are marked as connected.
Cc: Jani Nikula
Cc: Manasi Navare
Cc: Sean Paul
Signed-off-by: Gil Dekel
---
drivers/gpu/drm/i915/display
Signed-off-by: Gil Dekel
---
drivers/gpu/drm/i915/display/intel_dp.c | 18 --
1 file changed, 16 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_dp.c
b/drivers/gpu/drm/i915/display/intel_dp.c
index 964bf0551bdc..1e4dae8aad90 100644
--- a/drivers/gpu/drm
Signed-off-by: Gil Dekel
---
drivers/gpu/drm/i915/display/intel_dp.c | 18 --
1 file changed, 16 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_dp.c
b/drivers/gpu/drm/i915/display/intel_dp.c
index 964bf0551bdc..1e4dae8aad90 100644
--- a/drivers/gpu/drm
are ignored by userspace.
For your consideration and guidance.
Thanks,
Gil Dekel (3):
drm/i915/dp_link_training: Add a final failing state to link training
fallback
drm/i915/dp_link_training: Add a final failing state to link training
fallback for MST
drm/i915/dp_link_training: Emit a li
are ignored by userspace.
For your consideration and guidance.
Thanks,
Gil Dekel (3):
drm/i915/dp_link_training: Add a final failing state to link training
fallback
drm/i915/dp_link_training: Add a final failing state to link training
fallback for MST
drm/i915/dp_link_training: Emit a li
The ternary expression:
x ? : y
is a GCC extension and is not a part of C/C++ standard.
Use the canonical form instead to reduce dependency over GCC extension.
Signed-off-by: Gil Dekel
---
drivers/gpu/drm/i915/display/intel_display_power_well.c | 4 +++-
1 file changed, 3 insertions(+), 1
ff-by: Gil Dekel
Tested-by: Gil Dekel
---
v2: Fix copy-paste errors in commit message so it's relevant for this
patch and the mediatek driver.
---
drivers/gpu/drm/mediatek/mtk_drm_drv.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c
b/drive
://www.spinics.net/lists/stable/msg590605.html
did to qualcomm.
Signed-off-by: Gil Dekel
Tested-by: Gil Dekel
---
drivers/gpu/drm/mediatek/mtk_drm_drv.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c
b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
index
61 matches
Mail list logo