tel N540, poulsbo) laptop.
Changes in v2:
- Fix unused variable warnings when CONFIG_BACKLIGHT is not selected by
marking the 2 variables as __maybe_unused.
Signed-off-by: Hans de Goede
---
drivers/gpu/drm/gma500/backlight.c | 94 +++-
drivers/gpu/drm/gma500/cdv_devic
.com/
Changes in v2:
- Add "Use backlight_get_brightness() to get the brightness" patch
Changes in v3:
- Fix unused variable warnings when CONFIG_BACKLIGHT is not selected by
marking the 2 variables as __maybe_unused.
Regards,
Hans
Hans de Goede (5):
drm/gma500: Refactor backlight sup
kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch#_base_tree_information]
>
> url:
> https://github.com/intel-lab-lkp/linux/commits/Hans-de-Goede/drm-gma500-Backlight-handling-c
Hi,
On 8/25/22 21:19, Maccraft123 wrote:
> From: Maya Matuszczyk
>
> Yet another x86 gaming handheld.
>
> This one has many SKUs with quite a few of DMI strings,
> so let's just use a catchall, just as with Aya Neo Next.
>
> Signed-off-by: Maya Matuszczyk
Thanks, I have pushed this out to
d Bell Dot SC (Intel Atom N2600, cedarview)
and a Sony Vaio vpc-x11s1e (Intel N540, poulsbo) laptop.
Signed-off-by: Hans de Goede
---
drivers/gpu/drm/gma500/backlight.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/gma500/backlight.c
b/drivers/gpu/drm/
Use backlight_get_brightness() instead of directly referencing
bd->props.brightness. This will take backlight_is_blank() into account,
properly setting brightness to 0 when screen-blanking has been requested
through the backlight sysfs interface.
Suggested-by: Sam Ravnborg
Signed-off-by: Hans
native backlight device.
Add a call to the new acpi_video_register_backlight() function after
setting up the gma500's native backlight, so that the acpi_video backlight
device gets registered on systems where the gma500's native backlight
device is not registered.
Signed-off-by: Hans de Goede
.com/
Changes in v2:
- Add "Use backlight_get_brightness() to get the brightness" patch
Regards,
Hans
Hans de Goede (5):
drm/gma500: Refactor backlight support
drm/gma500: Change registered backlight device type to raw/native
drm/gma500: Use backlight_get_brightness() to get the
devices for a single display really is
undesirable, don't register the GPU's native backlight device when
another backlight device should be used.
Signed-off-by: Hans de Goede
---
drivers/gpu/drm/gma500/backlight.c | 8
1 file changed, 8 insertions(+)
diff --git a/drivers/gpu/drm
tel N540, poulsbo) laptop.
Signed-off-by: Hans de Goede
---
drivers/gpu/drm/gma500/backlight.c | 94 +++-
drivers/gpu/drm/gma500/cdv_device.c | 50 +++--
drivers/gpu/drm/gma500/oaktrail_device.c | 65 ++--
drivers/gpu/drm/gma500/opregion.c|
Hi,
On 8/3/22 20:24, Maccraft123 wrote:
> From: Maya Matuszczyk
>
> This device is another x86 gaming handheld, and as (hopefully) there is
> only one set of DMI IDs it's using DMI_EXACT_MATCH
>
> Signed-off-by: Maya Matuszczyk
Thanks I have added this patch to my local drm-misc-next branch.
Hi,
On 8/24/22 15:02, Jilin Yuan wrote:
> Delete the redundant word 'the'.
>
> Signed-off-by: Jilin Yuan
Thanks I have added this patch to my local drm-misc-next branch.
I will push this out to the official drm-misc-next branch after
running some local tests.
Regards,
Hans
> ---
>
Hi Patrik,
On 9/14/22 09:50, Patrik Jakobsson wrote:
> On Fri, Sep 9, 2022 at 1:56 PM Hans de Goede wrote:
>>
>> Hi Patrik,
>>
>> Here is another gma500 patch-series with one more bugfix and a bunch
>> of other cleanups of stuff which I noticed while doin
Hi,
On 9/14/22 12:29, Maxime Ripard wrote:
> Hi Hans,
>
> On Mon, Sep 05, 2022 at 10:35:47AM +0200, Hans de Goede wrote:
>> Hi All,
>>
>> Now that all patches have been reviewed/acked here is an immutable
>> backlight-detect-refactor
>> branch with
Hi,
On 9/14/22 12:29, Maxime Ripard wrote:
> Hi Hans,
>
> On Mon, Sep 05, 2022 at 10:35:47AM +0200, Hans de Goede wrote:
>> Hi All,
>>
>> Now that all patches have been reviewed/acked here is an immutable
>> backlight-detect-refactor
>> branch with
Hi,
On 9/14/22 12:29, Maxime Ripard wrote:
> Hi Hans,
>
> On Mon, Sep 05, 2022 at 10:35:47AM +0200, Hans de Goede wrote:
>> Hi All,
>>
>> Now that all patches have been reviewed/acked here is an immutable
>> backlight-detect-refactor
>> branch with
Hi,
On 9/14/22 12:29, Maxime Ripard wrote:
> Hi Hans,
>
> On Mon, Sep 05, 2022 at 10:35:47AM +0200, Hans de Goede wrote:
>> Hi All,
>>
>> Now that all patches have been reviewed/acked here is an immutable
>> backlight-detect-refactor
>> branch with
Hi,
On 9/14/22 08:50, Patrik Jakobsson wrote:
> On Fri, Sep 9, 2022 at 1:56 PM Hans de Goede wrote:
>>
>> Hi Patrik,
>>
>> Here is another gma500 patch-series with one more bugfix and a bunch
>> of other cleanups of stuff which I noticed while doing the previo
Hi,
On 9/12/22 23:20, Peter wrote:
> Hi all,
>
>
> Op maandag 12 september 2022 om 15:14:09 +0200 schreef Juerd Waalboer
> :
>> Hans de Goede skribis 2022-09-12 7:16 (+0200):
>>> During a big hacker event in the Netherlands this summer (MCH) the logistics
>>
Hi All,
Juerd (in the Cc) reported the following problem to me at our local hackerspace.
During a big hacker event in the Netherlands this summer (MCH) the logistics
team used custom barcodes to keep track of inventory. These custom barcodes
contain a # symbol.
They noticed that with the
Hi Sam,
On 9/11/22 13:48, Sam Ravnborg wrote:
> Hi Hans,
>
> just a few minor things. See comments.
> I like the diff - removes much more than it adds.
I'm glad you like it and thank you for the review.
> On Sat, Sep 10, 2022 at 10:50:58PM +0200, Hans de Goede wrote:
>&g
Hi All,
On 9/9/22 12:23, Hans de Goede wrote:
> Hi All,
>
> I will be at Plumbers Dublin next week and I was wondering if
> anyone interested in this wants to get together for a quick
> discussion / birds of a feather session about this?
>
> I have just posted version
Hi All,
On 9/9/22 12:23, Hans de Goede wrote:
> Hi All,
>
> I will be at Plumbers Dublin next week and I was wondering if
> anyone interested in this wants to get together for a quick
> discussion / birds of a feather session about this?
>
> I have just posted version
tel N540, poulsbo) laptop.
Signed-off-by: Hans de Goede
---
drivers/gpu/drm/gma500/backlight.c | 94 +++-
drivers/gpu/drm/gma500/cdv_device.c | 50 +++--
drivers/gpu/drm/gma500/oaktrail_device.c | 65 ++--
drivers/gpu/drm/gma500/opregion.c|
native backlight device.
Add a call to the new acpi_video_register_backlight() function after
setting up the gma500's native backlight, so that the acpi_video backlight
device gets registered on systems where the gma500's native backlight
device is not registered.
Signed-off-by: Hans de Goede
devices for a single display really is
undesirable, don't register the GPU's native backlight device when
another backlight device should be used.
Signed-off-by: Hans de Goede
---
drivers/gpu/drm/gma500/backlight.c | 8
1 file changed, 8 insertions(+)
diff --git a/drivers/gpu/drm
d Bell Dot SC (Intel Atom N2600, cedarview)
and a Sony Vaio vpc-x11s1e (Intel N540, poulsbo) laptop.
Signed-off-by: Hans de Goede
---
drivers/gpu/drm/gma500/backlight.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/gma500/backlight.c
b/drivers/gpu/drm/
com/
Regards,
Hans
Hans de Goede (4):
drm/gma500: Refactor backlight support
drm/gma500: Change registered backlight device type to raw/native
drm/gma500: Don't register backlight when another backlight should be
used
drm/gma500: Call acpi_video_register_backlight()
drivers/gpu/dr
Hi Patrik,
On 9/9/22 10:45, Hans de Goede wrote:
> Hi,
>
> On 9/9/22 09:34, Patrik Jakobsson wrote:
>> On Thu, Sep 8, 2022 at 3:39 PM Hans de Goede
>> wrote:
>>>
>>> Hi,
>>>
>>> On 9/8/22 15:26, Patrik Jakobsson wrote:
>>>
Hi,
On 9/9/22 15:39, Simon Ser wrote:
> On Friday, September 9th, 2022 at 12:12, Hans de Goede
> wrote:
>
>> Phase 3: Deprecate /sys/class/backlight uAPI
>>
>>
>> Once most userspace has moved over to using the new
Hi,
On 9/9/22 15:39, Simon Ser wrote:
> On Friday, September 9th, 2022 at 12:12, Hans de Goede
> wrote:
>
>> Phase 3: Deprecate /sys/class/backlight uAPI
>>
>>
>> Once most userspace has moved over to using the new
Hi,
On 9/9/22 15:05, Vratislav Podzimek wrote:
> On 9/9/22 13:50, Leigh Scott wrote:
>>
>>> Also note that you will also need to create a kmod package for
>>> the also out of tree v4l2-loopback kernel driver. The closed-source
>>> userspace bits Intel provide only work with gstreamer. So the
>>>
The gma_crtc_set_config() and psb_unlocked_ioctl() functions are 1:1
wrappers for drm_helpers. Drop these wrappers.
Signed-off-by: Hans de Goede
---
drivers/gpu/drm/gma500/gma_display.c | 8 +---
drivers/gpu/drm/gma500/gma_display.h | 2 --
drivers/gpu/drm/gma500/psb_drv.c | 8
(and therefor has no pm_runtime_foo() equivalent).
The 2 code paths which were using gma_power_is_on() are actually both
guaranteed to only run when the device is powered-on so the 2 checks
can simply be dropped.
Signed-off-by: Hans de Goede
---
drivers/gpu/drm/gma500/oaktrail_lvds.c | 1 -
drivers
The psb_runtime_suspend/resume/thaw/freeze/restore functions are all
just 1:1 wrappers around gma_power_suspend/_resume.
Drop these wrappers and use the DEFINE_RUNTIME_DEV_PM_OPS() macro to
define the dev_pm_ops struct.
Signed-off-by: Hans de Goede
---
drivers/gpu/drm/gma500/power.c | 25
runtime_allowed is initialized to 0, so the runtime_allowed == 1 condition
is never true making this dead code. Remove it.
Signed-off-by: Hans de Goede
---
drivers/gpu/drm/gma500/psb_drv.c | 11 ---
1 file changed, 11 deletions(-)
diff --git a/drivers/gpu/drm/gma500/psb_drv.c b/drivers
Hi Patrik,
Here is another gma500 patch-series with one more bugfix and a bunch
of other cleanups of stuff which I noticed while doing the previous
set of bugfixes.
Regards,
Hans
Hans de Goede (6):
drm/gma500: Wait longer for the GPU to power-down
drm/gma500: Remove runtime_allowed dead
The rpm_enabled flag is never set, remove it.
Signed-off-by: Hans de Goede
---
drivers/gpu/drm/gma500/gma_display.c | 13 +
drivers/gpu/drm/gma500/psb_drv.h | 3 ---
2 files changed, 1 insertion(+), 15 deletions(-)
diff --git a/drivers/gpu/drm/gma500/gma_display.c
b/drivers
as contents).
Hopefully this also fix this issue.
Signed-off-by: Hans de Goede
---
drivers/gpu/drm/gma500/cdv_device.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/gma500/cdv_device.c
b/drivers/gpu/drm/gma500/cdv_device.c
index ce96234f3df2..ff5104fe5692
Hi Vratislav,
On 9/9/22 11:42, Vratislav Podzimek wrote:
> Hello,
> I got a new Dell XPS laptop with the "amazing" [1] Intel MIPI IPU6 webcam.
> There are upstream repos with drivers [2] and user-space stuff and Ubuntu [3]
> and Arch [4] have user repositories with everything required packaged.
Hi All,
I will be at Plumbers Dublin next week and I was wondering if
anyone interested in this wants to get together for a quick
discussion / birds of a feather session about this?
I have just posted version 2 of the RFC:
Hi All,
I will be at Plumbers Dublin next week and I was wondering if
anyone interested in this wants to get together for a quick
discussion / birds of a feather session about this?
I have just posted version 2 of the RFC:
Hi all,
Here is v2 of my "drm/kms: control display brightness through drm_connector
properties" RFC:
Changes from version 1:
- Drop bl_brightness_0_is_min_brightness from list of new connector
properties.
- Clearly define that 0 is always min-brightness when setting the brightness
through
Hi all,
Here is v2 of my "drm/kms: control display brightness through drm_connector
properties" RFC:
Changes from version 1:
- Drop bl_brightness_0_is_min_brightness from list of new connector
properties.
- Clearly define that 0 is always min-brightness when setting the brightness
through
Hi,
On 9/9/22 10:20, Patrik Jakobsson wrote:
> On Tue, Sep 6, 2022 at 10:38 PM Hans de Goede wrote:
>>
>> psb_gem_unpin() calls dma_resv_lock() but the underlying ww_mutex
>> gets destroyed by drm_gem_object_release() move the
>> drm_gem_object_release() call in psb
Hi,
On 9/9/22 09:34, Patrik Jakobsson wrote:
> On Thu, Sep 8, 2022 at 3:39 PM Hans de Goede
> wrote:
>>
>> Hi,
>>
>> On 9/8/22 15:26, Patrik Jakobsson wrote:
>>> On Tue, Sep 6, 2022 at 10:38 PM Hans de Goede wrote:
>>>>
>>>> Fi
Hi All,
I'm sending this to both systemd-devel and lkml since I'm not sure
what is causing this.
For some reason the msi-laptop module is not autoloading on a
MSI S270 (yes that is a very old laptop).
Here is some debugging info:
$ cat /sys/class/dmi/id/modalias
Hi,
On 9/8/22 15:26, Patrik Jakobsson wrote:
> On Tue, Sep 6, 2022 at 10:38 PM Hans de Goede wrote:
>>
>> Fix gnome-shell (and other page-flip users) hanging after suspend/resume
>> because of the gma500's IRQs not working.
>>
>> This fixes 2 proble
000246 R12: c01864b0
[ 512.124584] R13: 0009 R14: 55cc9df484d0 R15: 55cc9af5d0c0
[ 512.124647]
Signed-off-by: Hans de Goede
---
drivers/gpu/drm/gma500/gma_display.c | 11 +++
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/gma
vents"
- Add "drm/gma500: Fix (vblank) IRQs not working after suspend/resume"
Regards,
Hans
Hans de Goede (3):
drm/gma500: Fix BUG: sleeping function called from invalid context
errors
drm/gma500: Fix WARN_ON(lock->magic != lock) error
drm/gma500: Fix (vblank) IRQs no
disabled at (725978): []
__schedule+0xdd3/0x1670
[ 79.695803] softirqs last enabled at (725974): []
__irq_exit_rcu+0xed/0x160
[ 79.695825] softirqs last disabled at (725969): []
__irq_exit_rcu+0xed/0x160
[ 79.695845] ---[ end trace ]---
Signed-off-by: Hans de Goede
---
.
Replace the PCI-config registers save/restore with pci_disable_msi() on
suspend + pci_enable_msi() on resume. Fixing e.g. gnome-shell hanging.
Signed-off-by: Hans de Goede
---
drivers/gpu/drm/gma500/cdv_device.c | 4 +---
drivers/gpu/drm/gma500/oaktrail_device.c | 5 +
drivers
Hi Michel,
On 9/6/22 12:25, Michel Dänzer wrote:
> On 2022-09-05 15:37, Hans de Goede wrote:
>> The gma500 page-flip code kinda assume that userspace never queues more
>> then 1 vblank event. So basically it assume that userspace does:
>>
>> - page-flip
>> -
Hi,
On 9/6/22 14:50, Patrik Jakobsson wrote:
> On Mon, Sep 5, 2022 at 3:37 PM Hans de Goede wrote:
>>
>> gma_crtc_page_flip() was holding the event_lock spinlock while calling
>> crtc_funcs->mode_set_base() which takes ww_mutex.
>>
>> The only reason to
x86
subsystems.
----
Hans de Goede (31):
ACPI: video: Add acpi_video_backlight_use_native() helper
drm/i915: Don't register backlight when another backlight should be used
(v2)
drm/amdgpu: Don't register backlight when anot
disabled at (725978): []
__schedule+0xdd3/0x1670
[ 79.695803] softirqs last enabled at (725974): []
__irq_exit_rcu+0xed/0x160
[ 79.695825] softirqs last disabled at (725969): []
__irq_exit_rcu+0xed/0x160
[ 79.695845] ---[ end trace ]---
Signed-off-by: Hans de Goede
---
hed which gma500 currently
does not support.
Note this is not a real fix for the issue of the gma500 code not
supporting multiple page-flips events being pending, but it at least
improves the situation a bit.
Signed-off-by: Hans de Goede
---
drivers/gpu/drm/gma500/gma_display.c | 11 +++---
000246 R12: c01864b0
[ 512.124584] R13: 0009 R14: 55cc9df484d0 R15: 55cc9af5d0c0
[ 512.124647]
Signed-off-by: Hans de Goede
---
drivers/gpu/drm/gma500/gma_display.c | 10 +++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/gma500/gma
with a WARN_ON constantly
triggering.
This series consists of 3 small non backlight fixes,
2 of which fix WARN_ON oopses/backtraces.
Regards,
Hans
Hans de Goede (3):
drm/gma500: Fix BUG: sleeping function called from invalid context
errors
drm/gma500: Fix crtc_vblank reference leak when userspace
x86
subsystems.
----
Hans de Goede (31):
ACPI: video: Add acpi_video_backlight_use_native() helper
drm/i915: Don't register backlight when another backlight should be used
(v2)
drm/amdgpu: Don't register backlight when anot
x86
subsystems.
----
Hans de Goede (31):
ACPI: video: Add acpi_video_backlight_use_native() helper
drm/i915: Don't register backlight when another backlight should be used
(v2)
drm/amdgpu: Don't register backlight when anot
x86
subsystems.
----
Hans de Goede (31):
ACPI: video: Add acpi_video_backlight_use_native() helper
drm/i915: Don't register backlight when another backlight should be used
(v2)
drm/amdgpu: Don't register backlight when anot
Hi,
On 8/26/22 00:21, Daniel Dadap wrote:
> On 8/25/22 9:37 AM, Hans de Goede wrote:
>> On some new laptop designs a new Nvidia specific WMI interface is present
>> which gives info about panel brightness control and may allow controlling
>> the brightness through this interf
Hi,
On 8/26/22 00:21, Daniel Dadap wrote:
> On 8/25/22 9:37 AM, Hans de Goede wrote:
>> On some new laptop designs a new Nvidia specific WMI interface is present
>> which gives info about panel brightness control and may allow controlling
>> the brightness through this interf
Hi,
On 8/26/22 00:21, Daniel Dadap wrote:
> On 8/25/22 9:37 AM, Hans de Goede wrote:
>> On some new laptop designs a new Nvidia specific WMI interface is present
>> which gives info about panel brightness control and may allow controlling
>> the brightness through this interf
Hi,
On 8/26/22 00:21, Daniel Dadap wrote:
> On 8/25/22 9:37 AM, Hans de Goede wrote:
>> On some new laptop designs a new Nvidia specific WMI interface is present
>> which gives info about panel brightness control and may allow controlling
>> the brightness through this interf
Hi,
On 8/23/22 02:44, Adam Williamson wrote:
> Hey folks! I apologize for the wide distribution, but this seemed like
> a bug it'd be appropriate to get a wide range of input on.
>
> There's a bug that was proposed as an F37 Beta blocker:
> https://bugzilla.redhat.com/show_bug.cgi?id=1907030
>
Hi,
On 8/23/22 02:44, Adam Williamson wrote:
> Hey folks! I apologize for the wide distribution, but this seemed like
> a bug it'd be appropriate to get a wide range of input on.
>
> There's a bug that was proposed as an F37 Beta blocker:
> https://bugzilla.redhat.com/show_bug.cgi?id=1907030
>
h just having a kernel cmdline parameter to hide/unhide
it might be good enough.
Regards,
Hans
>
> On Thu, Aug 25, 2022 at 3:27 AM Hans de Goede <mailto:hdego...@redhat.com>> wrote:
>
> Hi Yusuf,
>
> On 8/24/22 04:18, Yusuf Khan wrote:
> > Sorry
h just having a kernel cmdline parameter to hide/unhide
it might be good enough.
Regards,
Hans
>
> On Thu, Aug 25, 2022 at 3:27 AM Hans de Goede <mailto:hdego...@redhat.com>> wrote:
>
> Hi Yusuf,
>
> On 8/24/22 04:18, Yusuf Khan wrote:
> > Sorry
Hi,
On 8/19/22 20:01, Mario Limonciello wrote:
> It was observed that on a Thinkpad T14 Gen1 (AMD) that the platform
> profile is starting up in 'low-power' mode after refreshing what the
> firmware had. This is most likely a firmware bug, but as a harmless
> workaround set the default profile
Hi,
On 8/18/22 23:00, Wolfram Sang wrote:
> Follow the advice of the below link and prefer 'strscpy' in this
> subsystem. Conversion is 1:1 because the return value is not used.
> Generated by a coccinelle script.
>
> Link:
>
.
This is because the entries using the removed wmi_backlight_power flag
also use other model specific quirks from the asus-wmi quirk_entry struct.
So the quirk_asus_x55u struct and the entries pointing to it cannot be
dropped.
Acked-by: Rafael J. Wysocki
Signed-off-by: Hans de Goede
---
drivers/acpi
:
- Use WMI_BRIGHTNESS_GUID define
Acked-by: Rafael J. Wysocki
Signed-off-by: Hans de Goede
---
drivers/acpi/Kconfig | 1 +
drivers/acpi/video_detect.c| 37 ++
drivers/gpu/drm/gma500/Kconfig | 2 ++
drivers/gpu/drm/i915/Kconfig | 2 ++
include/acpi
Add an entry summarizing the discussion about dealing with brightness
control on devices with more then 1 internal panel.
The original discussion can be found here:
https://lore.kernel.org/dri-devel/20220517152331.16217-1-hdego...@redhat.com/
Reviewed-by: Lyude Paul
Signed-off-by: Hans de Goede
Signed-off-by: Hans de Goede
---
drivers/acpi/acpi_video.c | 10 --
drivers/acpi/video_detect.c | 16
include/acpi/video.h| 4
3 files changed, 30 deletions(-)
diff --git a/drivers/acpi/acpi_video.c b/drivers/acpi/acpi_video.c
index d1e41f30c004
efore
the addition of the acpi_video_get_backlight_type() != native check.
Removing this should be ok now, since the ACPI video code has improved
heuristics for this itself now (which includes a chassis-type check).
Signed-off-by: Hans de Goede
---
drivers/platform/x86/asus-wmi.c | 7 ---
1 file ch
Wysocki
Signed-off-by: Hans de Goede
---
drivers/acpi/video_detect.c | 15 ---
1 file changed, 15 deletions(-)
diff --git a/drivers/acpi/video_detect.c b/drivers/acpi/video_detect.c
index 67a0211c07b4..af2833b57b8b 100644
--- a/drivers/acpi/video_detect.c
+++ b/drivers/acpi/video
Move the WMI interface definitions to a header, so that the definitions
can be shared with drivers/acpi/video_detect.c .
Changes in v2:
- Add missing Nvidia copyright header
- Move WMI_BRIGHTNESS_GUID to nvidia-wmi-ec-backlight.h as well
Suggested-by: Daniel Dadap
Signed-off-by: Hans de Goede
or when it is
disabled.
Changes in v2:
- Make register_backlight_delay a module parameter, mainly so that it can
be disabled by Nvidia binary driver users
Acked-by: Rafael J. Wysocki
Signed-off-by: Hans de Goede
---
drivers/acpi/acpi_video.c | 50
. Wysocki
Signed-off-by: Hans de Goede
---
drivers/acpi/video_detect.c | 39 ++---
1 file changed, 23 insertions(+), 16 deletions(-)
diff --git a/drivers/acpi/video_detect.c b/drivers/acpi/video_detect.c
index fb49b8f4523a..cc9d0d91e268 100644
--- a/drivers/acpi
bug.cgi?id=215683
Tested-by: Werner Sembach
Acked-by: Rafael J. Wysocki
Signed-off-by: Hans de Goede
---
drivers/acpi/video_detect.c | 92 +
1 file changed, 1 insertion(+), 91 deletions(-)
diff --git a/drivers/acpi/video_detect.c b/drivers/acpi/video_dete
] quirks from samsung-laptop to
drivers/acpi/video_detect.c .
Note the X360 -> acpi_backlight=native quirk is not moved because that
already was present in drivers/acpi/video_detect.c .
Acked-by: Rafael J. Wysocki
Signed-off-by: Hans de Goede
---
drivers/acpi/video_detect.c |
de Goede
---
drivers/gpu/drm/nouveau/nouveau_acpi.c | 5 +
drivers/gpu/drm/nouveau/nouveau_acpi.h | 2 ++
drivers/gpu/drm/nouveau/nouveau_backlight.c | 7 +++
3 files changed, 14 insertions(+)
diff --git a/drivers/gpu/drm/nouveau/nouveau_acpi.c
b/drivers/gpu/drm/nouveau
add DMI quirks for those.
Acked-by: Rafael J. Wysocki
Signed-off-by: Hans de Goede
---
drivers/acpi/video_detect.c | 19 +++
drivers/platform/x86/toshiba_acpi.c | 16
2 files changed, 19 insertions(+), 16 deletions(-)
diff --git a/drivers/acpi
When acpi_video_register() has not run yet the video_bus_head will be
empty, so there is no need to check the register_count flag first.
Acked-by: Rafael J. Wysocki
Signed-off-by: Hans de Goede
---
drivers/acpi/acpi_video.c | 12
1 file changed, 4 insertions(+), 8 deletions
call acpi_video_register_backlight() when a panel is detected
Changes in v3:
-Add a new intel_acpi_video_register() helper which checks if a panel
is present and then calls acpi_video_register_backlight()
Signed-off-by: Hans de Goede
---
drivers/gpu/drm/i915/display/intel_acpi.c| 27
es.
Acked-by: Rafael J. Wysocki
Signed-off-by: Hans de Goede
---
drivers/acpi/video_detect.c | 53 ++
drivers/platform/x86/acer-wmi.c | 66 -
2 files changed, 53 insertions(+), 66 deletions(-)
diff --git a/drivers/acpi/video_detect.c b/dr
Now that acpi_video_get_backlight_type() has apple-gmux detection (using
apple_gmux_present()), it is no longer necessary for the apple-gmux code
to manually remove possibly conflicting drivers.
So remove the handling for this from the apple-gmux driver.
Signed-off-by: Hans de Goede
devices for a single display really is
undesirable, don't register the GPU's native backlight device when
another backlight device should be used.
Changes in v2:
- Use drm_info(drm_dev, ...) for log messages
Reviewed-by: Jani Nikula
Signed-off-by: Hans de Goede
---
drivers/gpu/drm/i915
() is troublesome because it may end up
getting called after other backlight drivers have already called
acpi_video_get_backlight_type() resulting in the other drivers
already being registered even though they should not.
Acked-by: Rafael J. Wysocki
Signed-off-by: Hans de Goede
---
drivers/acpi
-backlight in
drivers/acpi/video_detect.c already checks that the WMI advertised
brightness-source is the embedded controller, this new check makes it
unnecessary for nvidia_wmi_ec_backlight_probe() to check this itself.
Suggested-by: Daniel Dadap
Reviewed-by: Daniel Dadap
Signed-off-by: Hans de Goede
er
Signed-off-by: Hans de Goede
---
drivers/gpu/drm/Kconfig | 7 +++
drivers/gpu/drm/radeon/atombios_encoders.c | 7 +++
drivers/gpu/drm/radeon/radeon_legacy_encoders.c | 7 +++
3 files changed, 21 insertions(+)
diff --git a/drivers/gpu/drm/Kconfig b/d
necessary to monitor for a
native (BACKLIGHT_RAW) device showing up later and to then unregister
the acpi_video backlight device(s).
Acked-by: Rafael J. Wysocki
Signed-off-by: Hans de Goede
---
drivers/acpi/acpi_video.c | 2 --
drivers/acpi/video_detect.c | 36
send out a pull-request to all involved subsystems based on
this branch soon.
Regards,
Hans
Hans de Goede (31):
ACPI: video: Add acpi_video_backlight_use_native() helper
drm/i915: Don't register backlight when another backlight should be
used (v2)
drm/amdgpu: Don't register
backlight device because of e.g. the firmware_flags
or the acpi_video_get_backlight_type() return value. This ensures that
if the acpi_video backlight device should be used, it will be available
before the radeon drm_device gets registered with userspace.
Acked-by: Alex Deucher
Signed-off-by: Hans de
.
Relying on the cached native_available value not only is simpler, it will
also work correctly in cases where then native backlight registration was
skipped because of acpi_video_backlight_use_native() returning false.
Acked-by: Rafael J. Wysocki
Signed-off-by: Hans de Goede
---
drivers/acpi
() with
adding a new acpi_video_backlight_use_native() helper.
Acked-by: Rafael J. Wysocki
Signed-off-by: Hans de Goede
---
drivers/acpi/video_detect.c | 24
include/acpi/video.h| 5 +
2 files changed, 25 insertions(+), 4 deletions(-)
diff --git a/drivers/acpi
of:
acpi_video_set_dmi_backlight_type(acpi_backlight_vendor);
Inside the apple-gmux driver.
Acked-by: Rafael J. Wysocki
Signed-off-by: Hans de Goede
---
drivers/acpi/video_detect.c | 4
include/acpi/video.h| 1 +
2 files changed, 5 insertions(+)
diff --git a/drivers/acpi
de Goede
---
drivers/gpu/drm/amd/amdgpu/atombios_encoders.c| 9 +++--
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 ++
2 files changed, 9 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/atombios_encoders.c
b/drivers/gpu/drm/amd/amdgpu/atombios_encoders.c
501 - 600 of 25982 matches
Mail list logo
